Marvin,
I will review your patches this week.
-Jaben
> -Original Message-
> From: Marvin Häuser [mailto:marvin.haeu...@outlook.com]
> Sent: Thursday, May 19, 2016 1:20 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: RE: [edk2] [PATCH v1 1/1] ShellP
Can we safely remove the ASSERt now?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marvin Häuser
> Sent: Thursday, May 19, 2016 12:04 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subje
Those pointers are dependent on library constructors from associated libraries.
You need to correctly include the library to make them function.
The table pointer in your module's entry point should always be valid though.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-dev
unhelpful. I
like return values way more than I do asserts. The same way we have libraries
in EDKII that have constructors and no destructors which means they are risky
and potentially useless for any code that must support unload.
-Jaben
> On May 18, 2016, at 9:57 AM, Carsey, Jaben wr
Sure.
Reviewed by: Jaben Carsey
-Jaben
> On May 18, 2016, at 9:44 AM, El-Haj-Mahmoud, Samer
> wrote:
>
> Thanks Jaben!
>
> Will you give it a reviewed-by ?
>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf
> -Original Message-
> From: Palmer, Thomas [mailto:thomas.pal...@hpe.com]
> Sent: Wednesday, May 18, 2016 9:21 AM
> To: jim_dai...@dell.com; Carsey, Jaben ; edk2-
> de...@lists.01.org
> Cc: Kinney, Michael D ; Yao, Jiewen
> ; Gao, Liming
> Subject: RE: [edk2]
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Thomas Palmer
> Sent: Wednesday, May 18, 2016 9:01 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Yao, Jiewen
> ; Gao, Liming
> Subject: [edk2] [PATCH] [MdePkg/BaseLib]: Remove ove
Amended for commit.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jordan Justen
> Sent: Thursday, May 12, 2016 3:20 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Qiu, Shumin
> Subject: Re: [edk2] [Patch] Us
Why write the function UintnToAscDec to convert UINTN to ascii string?
PrintLib can do that for you.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Fu, Siyuan
> Sent: Thursday, May 05, 2016 7:33 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shum
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Qiu, Shumin
> Sent: Wednesday, May 04, 2016 11:05 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin ; Carsey, Jaben
>
> Subject: [PATCH] ShellPkg: Remove debug message in release binaries.
> I
Thanks!
> -Original Message-
> From: Zeng, Star
> Sent: Monday, May 02, 2016 9:39 PM
> To: Carsey, Jaben ; Cinnamon Shia
> ; edk2-devel@lists.01.org
> Cc: Qiu, Shumin ; samer.el-haj-mahm...@hpe.com
> Subject: RE: [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error mes
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zeng, Star
> Sent: Monday, May 02, 2016 1:25 AM
> To: Cinnamon Shia ; edk2-devel@lists.01.org
> Cc: Qiu, Shumin ; Carsey, Jaben
> ; samer.el-haj-mahm...@hpe.com
> Subject: RE: [PATCH v3 1/2] ShellPkg/UefiDpLib:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Shia, Cinnamon [mailto:cinnamon.s...@hpe.com]
> Sent: Monday, May 02, 2016 2:23 AM
> To: Zeng, Star ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Gao, Liming
>
> Subject: RE: [PATCH] Performa
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Shia, Cinnamon
> Sent: Monday, May 02, 2016 2:23 AM
> To: Zeng, Star ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
> ; Gao, Liming
I missed that the default was from the RFC. I agree with you.
-Jaben
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, April 29, 2016 11:00 AM
> To: Carsey, Jaben
> Cc: Marcin Wojtas ; Fu, Siyuan ;
> ha...@marvell.com; edk2-
Updated UNI spec to remove info specific to some consumers, not format.
Updated UNI spec to allow non-ascii characters in strings.
Cc: Qiu Shumin mailto:shumin@intel.com>>
Cc: Erik Bjorge
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
mailto:jaben.car
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Cinnamon Shia
> Sent: Thursday, April 28, 2016 7:42 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
> ; Zeng, Star
> Su
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Cinnamon Shia
> Sent: Thursday, April 28, 2016 7:42 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
> ; Zeng, Star
> Su
Maybe we should have a PCD control the default value so that people who build
it can set it as per their own best value. Adding a parameter seems like a
great (but separate) solution.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>
You could look at the source code for that command since you know that does
what you want.
It's located here: ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> devendra rawat
> Sent: Thu
arsey
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, April 27, 2016 1:12 PM
> To: Carsey, Jaben ; edk2-devel-01 de...@ml01.01.org>
> Cc: Ni, Ruiyu ; Justen, Jordan L
> ; Tian, Feng ; Yao, Jiewen
> ; Zeng, Star
> Subject: Re:
Done.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Attar, Abdul Lateef
> Sent: Tuesday, April 26, 2016 3:42 AM
> To: Qiu, Shumin ; Carsey, Jaben
> ; Ni, Ruiyu ; edk2-
> de...@lists.01.org
> Cc: Parthasar
Laszlo,
Does the library destructor not get called? Shouldn't that destructor
unregister the protocol notify and leave the callback pointer in DXE core
correct?
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El-
> Haj-Mahmoud, Samer
> Sent: Wednesday, April 27, 2016 8:11 AM
> To: Shah, Tapan ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subje
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, April 26, 2016 6:21 PM
> To: Bhupesh Sharma ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ye, Ting ;
> Fu, Siyuan
> Subject: RE: [edk2] [Patch] ShellPkg: Enhance ping6 to
Ok. You can rb me, but I don't maintain that pkg so...
Reviewed-by Jaben Carsey
-Jaben
> On Apr 25, 2016, at 11:17 AM, El-Haj-Mahmoud, Samer
> wrote:
>
> Thanks Jaben. I did notice this and tried to submit the patch with the
> modified subject (using git send-email wit
Samer,
Note: This is not in the EDK2 yet, but in the staging... change [PATCH] to
[Staging/HTTPS-TLS PATCH] (or something like that per the rules...)
2 questions inline also.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Samer El
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Qiu, Shumin
> Sent: Sunday, April 24, 2016 10:56 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin ; Carsey, Jaben
>
> Subject: [PATCH] ShellPkg: Fix Shell treats every .EFI file as an executable
> applica
Looks good to me.
I will let Shumin or Ray review also.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Abdul Lateef Attar
> Sent: Thursday, April 21, 2016 4:24 AM
> To: Carsey, Jaben ; Ni, Ruiyu
Reviewed-by: Jaben Carsey
From: Qiu, Shumin
Sent: Tuesday, April 19, 2016 7:52 PM
To: Carsey, Jaben
Cc: Qiu, Shumin ; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH] ShellPkg: Support connect a device handle
recursively with '-r'.
Importance: High
Hi Jaben,
'ShellComm
-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu
> Shumin
> Sent: Monday, April 18, 2016 1:18 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: [edk2] [PATCH] ShellPkg: Support connect a device handle
> recursively wi
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, April 18, 2016 6:52 PM
> To: edk2-devel@lists.01.org
> Cc: David Van Arnem ; Bhupesh Sharma
> ; Carsey, Jaben ; Ye,
> Ting ; Fu, Siyuan
> Subject: [Patch] ShellPkg: Enhance ping
That sounds like a good enhancement to me.
-Jaben
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, April 14, 2016 8:52 PM
> To: Carsey, Jaben ; David Van Arnem
> ; Bhupesh Sharma ;
> Laszlo Ersek ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zeng, Star
> Sent: Wednesday, April 13, 2016 1:07 AM
> To: Qiu, Shumin ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject:
.@ml01.01.org; Ye, Ting ; Carsey, Jaben
> ; Fu, Siyuan ; David Van
> Arnem
> Subject: Re: [edk2] [Patch] ShellPkg: Update ping command options to sync
> with Spec
> Importance: High
>
> On 04/13/16 05:16, Jiaxin Wu wrote:
> > This patch is used to update ping command optio
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Wednesday, April 13, 2016 12:16 AM
> To: Qiu, Shumin ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH v2] ShellPkg : Cache the environment vari
2 comments below.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Qiu, Shumin
> Sent: Sunday, April 10, 2016 5:55 AM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin ; Carsey, Jaben
> ; Ni, Ruiyu
> Subject: [PATCH] ShellPkg : Cache the environment va
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Friday, April 08, 2016 3:10 AM
> To: Qiu, Shumin ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: RE: [edk2] [PATCH] ShellPkg: Fix Shell ASSERT when mv file with cwd
&g
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, April 07, 2016 12:30 AM
> To: Justen, Jordan L ; Ni, Ruiyu
> ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH 03/12] FatBinPkg: Change to 2-clause BSD lice
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Monday, April 04, 2016 10:47 AM
> To: Bhupesh Sharma
> Cc: edk2-devel@lists.01.org ; David Van Arnem
>
> Subject: Re: [edk2] Using multiple SNP drivers on Shell
> Importa
If your BDS supports PXE booting, you should be able to "exit" the shell and
then use BDS to initiate a PXE boot..
I think you're right that there is no built in command to initiate a PXE boot.
There is no command to initiate any boot type.
-Jaben
> -Original Message-
> From: edk2-dev
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Qiu, Shumin
> Sent: Sunday, March 27, 2016 11:48 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin ; Carsey, Jaben
>
> Subject: [PATCH] ShellPkg: Refine the comparisons code in ShellPkg.
> Importance: High
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Qiu, Shumin
> Sent: Tuesday, March 22, 2016 1:36 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: [PATCH] ShellPkg: Make the USB mouse behavior in 'edit' consistent
> with 'hexed
-Jaben
> On Mar 22, 2016, at 10:32 AM, "jim_dai...@dell.com"
> wrote:
>
>
>> Jaben asked:
>
>> Why would we want to add something case sensitive when everything else
>> is not case sensitive? Do we really want to have to add DIR, dIR,
>> Dir,
>> (etc...) to properly handle the built in al
Jim,
Why would we want to add something case sensitive when everything else is not
case sensitive? Do we really want to have to add DIR, dIR, Dir, (etc...) to
properly handle the built in alias that is required in the shell spec?
What if we requested to change the spec to say alias is case ins
Looks good.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Tapan Shah [mailto:tapands...@hpe.com]
> Sent: Wednesday, March 16, 2016 10:31 AM
> To: edk2-devel@lists.01.org
> Cc: samer.el-haj-mahm...@hpe.com; Carsey, Jaben
> ; Tapan Shah
> Subject
We need to split into 2 patches (a series), one for MdePkg and one for
ShellPkg. Comments below inline.
> -Original Message-
> From: Tapan Shah [mailto:tapands...@hpe.com]
> Sent: Wednesday, March 16, 2016 8:55 AM
> To: edk2-devel@lists.01.org
> Cc: samer.el-haj-mahm...@
One final question below.
> -Original Message-
> From: Tapan Shah [mailto:tapands...@hpe.com]
> Sent: Wednesday, March 16, 2016 10:32 AM
> To: edk2-devel@lists.01.org
> Cc: samer.el-haj-mahm...@hpe.com; Carsey, Jaben
> ; Tapan Shah
> Subject: [PATCH] ShellPkg: Modi
Got it. makes sense.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Shah, Tapan [mailto:tapands...@hpe.com]
> Sent: Wednesday, March 16, 2016 11:08 AM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: El-Haj-Mahmoud, Samer
> Subject: RE: [PATCH] ShellPkg:
Looks good to me. I will let Shumin check also.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Tapan Shah [mailto:tapands...@hpe.com]
> Sent: Friday, March 18, 2016 9:32 AM
> To: edk2-devel@lists.01.org
> Cc: samer.el-haj-mahm...@hpe.com; Carsey, Jaben
> ; Tap
Reviewed-by: Jaben Carsey
> -Original Message-
> From: jim_dai...@dell.com [mailto:jim_dai...@dell.com]
> Sent: Tuesday, March 15, 2016 2:09 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: [PATCH] ShellPkg:
> Importance: High
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, March 13, 2016 7:14 PM
> To: Qiu, Shumin ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: RE: [PATCH] ShellPkg: Fix Shell ASSERT when read 'TAB' key fail from
&
BaseTools and Conf should be one directory up I think.
From: Jim Slaughter [mailto:jwslau...@yahoo.com]
Sent: Tuesday, March 08, 2016 4:19 PM
To: Carsey, Jaben ; Gao, Liming ;
Tian, Feng ; edk2-devel@lists.01.org
Subject: Re: [edk2] EDK2 Setup & Configuration Issue
Importance: High
Win
Jim,
You need to download or build the BaseTools that are used during the build.
Have you done that?
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jim
> Slaughter
> Sent: Tuesday, March 08, 2016 2:21 PM
> To: Gao, Liming ; Tian, Fen
> -Original Message-
> From: Justen, Jordan L
> Sent: Tuesday, March 08, 2016 11:37 AM
> To: Carsey, Jaben
> Cc: edk2-devel@lists.01.org; Gao, Liming ; Bjorge, Erik
> C
> Subject: Re: [edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support
> Python 3
> Impor
> On Mar 7, 2016, at 7:16 PM, Jordan Justen wrote:
>
> The script is updated to support both python 2.7 and python 3.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jordan Justen
> Cc: Yonghong Zhu
> Cc: Liming Gao
> Cc: Erik Bjorge
> ---
> BaseTools/Scripts/C
Fix Intel's copyright years in the modified files. If you do that, then good.
Reviewed-By: Jaben Carsey
-Jaben
Sent from my iPad.
> On Mar 8, 2016, at 4:57 AM, Qiu, Shumin wrote:
>
> Use DOS format end of line(CR, LF).
>
> Cc: Jaben Carsey
> Contributed-under:
Also for series.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El-
> Haj-Mahmoud, Samer
> Sent: Monday, March 07, 2016 4:57 AM
> To: edk2-devel@lists.01.org; Shia, Cinnamon
> Subject: Re: [edk2] [PATCH v2 1/2] Per
Reviewed-by: Jaben Carsey
And commited.
> -Original Message-
> From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com]
> Sent: Thursday, March 03, 2016 7:32 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
> ; Samer El-Haj-Mahmoud mahm...@
01, 2016 6:14 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Wu, Jiaxin
> ; Ye, Ting ; Fu, Siyuan
>
> Subject: [patch] ShellPkg: Merge Ping6 and Ifconfig6 tools to Shell command.
> Importance: High
>
> According to the new Shell spec, we add Network2 profile and
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Subramanian, Sriram (EG Servers Platform SW) [mailto:sriram-
> s...@hpe.com]
> Sent: Wednesday, March 02, 2016 7:13 PM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Carsey,
> Jaben ;
:57 PM
>> To: Laszlo Ersek
>> Cc: Wu, Jiaxin ; edk2-devel@lists.01.org > de...@ml01.01.org>; Ye, Ting ; Carsey, Jaben
>> ; Fu, Siyuan
>> Subject: Re: [edk2] [Patch] ShellPkg: Update 'ifconfig -r' implementation
>>
>>> On 2 March 2016 at 09:02,
Reviewed-by: Jaben Carsey
This patch worked great!
> -Original Message-
> From: jim_dai...@dell.com [mailto:jim_dai...@dell.com]
> Sent: Tuesday, March 01, 2016 1:02 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: [PATCH] ShellPkg:
; Sent: Tuesday, March 01, 2016 12:48 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: [edk2] [EDK2] [PATCH] ShellPkg: Ensure UEFI apps open the correct
> StdOut
> Importance: High
>
> Dell - Internal Use - Confidential
>
> ShellPkg: E
You could use map to delete the standard map names for sure, then remap them
how you like. I think the problem would be parsing the HD node in a script
file though.
-Jaben
> -Original Message-
> From: Foster, Matthew I
> Sent: Tuesday, March 01, 2016 9:00 AM
> To: C
Matthew,
I don't know how to do that quickly given the current code. When you change
the HD node of the device path, the whole thing changes.
The consistent name is designed to accommodate adding or removing devices and
not l losing the names of the other devices in the system. This is not
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel-boun...@lists.01.org [mailto:edk2-devel-
> boun...@lists.01.org] On Behalf Of jim_dai...@dell.com
> Sent: Thursday, February 18, 2016 6:41 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, S
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel-boun...@lists.01.org [mailto:edk2-devel-
> boun...@lists.01.org] On Behalf Of jim_dai...@dell.com
> Sent: Thursday, February 18, 2016 6:47 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, S
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel-boun...@lists.01.org [mailto:edk2-devel-
> boun...@lists.01.org] On Behalf Of jim_dai...@dell.com
> Sent: Thursday, February 18, 2016 7:52 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, S
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Qiu, Shumin
> Sent: Thursday, February 25, 2016 10:54 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin ; Carsey, Jaben
> ; Ni, Ruiyu
> Subject: [PATCH] ShellPkg: Fix unexpected behavior of mouse cursor in
&
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu
> Shumin
> Sent: Monday, February 22, 2016 11:01 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v4 0/2] Enhance Shell to support finding help message
> em
Reviewed-by: Jaben Carsey
-Jaben
Sent from my iPad.
> On Feb 21, 2016, at 6:49 PM, Qiu, Shumin wrote:
>
> Do NULL pointer check before the pointer is used to avoid dereferenced.
>
> Cc: Jaben Carsey
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreemen
That sounds good to me.
> -Original Message-
> From: jim_dai...@dell.com [mailto:jim_dai...@dell.com]
> Sent: Thursday, February 18, 2016 8:26 AM
> To: Carsey, Jaben
> Cc: Qiu, Shumin ; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH] ShellPkg: Increase realloca
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> jim_dai...@dell.com
> Sent: Thursday, February 18, 2016 7:52 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: [edk2] [PATCH] ShellPk
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Daryl McDaniel
> Sent: Tuesday, February 16, 2016 12:09 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Colin King
>
> Subject: [edk
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu
> Shumin
> Sent: Monday, February 15, 2016 6:07 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: [edk2] [
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ryan Harkin [mailto:ryan.har...@linaro.org]
> Sent: Wednesday, February 10, 2016 6:16 AM
> To: jim_dai...@dell.com
> Cc: edk2-devel@lists.01.org; Carsey, Jaben ; Qiu,
> Shumin
> Subject: Re: [e
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif
> Lindholm
> Sent: Tuesday, February 09, 2016 10:13 AM
> To: Carsey, Jaben
> Cc: edk2-devel@lists.01.org; Qiu, Shumin ; Ard
> Biesheuvel
> Subject: Re: [edk2]
Ryan Harkin
> Sent: Tuesday, February 09, 2016 10:15 AM
> To: Carsey, Jaben
> Cc: jim_dai...@dell.com; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes
> Importance: High
>
> Hi Jaben,
>
> On 8 February 2016 at 19:35, Carsey
el@lists.01.org; Carsey, Jaben ; Qiu,
> Shumin
> Subject: Re: [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg
> Importance: High
>
> On 9 February 2016 at 18:18, Leif Lindholm
> wrote:
> > Separate ShellPkg and ShellBinPkg into separate entities.
>
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, February 09, 2016 9:19 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
> ; Ard Biesheuvel
> Subject: [PATCH] Maintainers.txt: Update maintainers for She
olm
> Sent: Tuesday, February 09, 2016 8:54 AM
> To: Carsey, Jaben
> Cc: edk2-devel@lists.01.org; Laszlo Ersek ; Qiu, Shumin
> ; Ard Biesheuvel
> Subject: Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.
> Importance: High
>
> Thanks!
>
> (Argh, forgot
-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
> ; Laszlo Ersek ; Ard Biesheuvel
>
> Subject: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.
> Importance: High
>
> The binaries of ShellBinPkg are generated with ShellPkg from
> 9a8f6fb40712 (&qu
Committed and done.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> jim_dai...@dell.com
> Sent: Monday, February 08, 2016 1:53 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject:
to:jim_dai...@dell.com]
Sent: Monday, February 08, 2016 11:03 AM
To: Carsey, Jaben
Cc: Qiu, Shumin
Subject: RE: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes
Importance: High
Strange. I didn't see them on the mailing list posting, but I assumed the list
had stripped
them. They are
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Cinnamon Shia
> Sent: Monday, February 08, 2016 9:39 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] ShellPkg/UefiDpLib: Refine the code of locating all
> h
Since you asked here is a little more info:
The file's EFI_FILE_PROTOCOL is insufficient information to find it as it just
contains the path in file system for the file. That's the equivalent to saying
"I want to open file directory/foo.txt". you need to give more context for
success.
To loa
ro-u...@lists.linaro.org; Carsey, Jaben
>
> Subject: Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM
> Platform DSC / FDF / ArmPlatformLib template"
> Importance: High
>
> On 02/04/16 12:53, Ryan Harkin wrote:
> > On 3 February 2016 at 17:38, Leif
> -Original Message-
> From: Ryan Harkin [mailto:ryan.har...@linaro.org]
> Sent: Wednesday, February 03, 2016 9:25 AM
> To: Carsey, Jaben
> Cc: edk2-de...@ml01.01.org; linaro-u...@lists.linaro.org; Leif Lindholm
> ; Justen, Jordan L ; Ard
> Biesheuvel
> Subject
Change looks good.
Question - Is there a way to optimize the patch/email for this type of change
so that we do not see the "diff" for a file that is deleted? It seems
redundant to show a whole file of "-" lines...
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun.
I like that a lot.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Justen, Jordan L
> Sent: Tuesday, February 02, 2016 9:35 AM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: RE: [edk2] [PATCH] Maintainers.txt: Update sour
Looks like good info. Should we clarify that SVN is read only also?
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jordan Justen
> Sent: Tuesday, February 02, 2016 9:03 AM
> To: edk2-devel@lists.01.org
> Cc: Juste
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Qiu, Shumin
> Sent: Monday, January 25, 2016 12:01 AM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin ; Carsey, Jaben
>
> Subject: [PATCH] ShellPkg: Refine the code to avoid use a constant number as
> of
For series. Reviewed-by: Jaben Carsey
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, January 21, 2016 9:07 AM
> To: edk2-devel-01
> Cc: Carsey, Jaben ; Ryan Harkin
>
> Subject: [PATCH v2 00/14] ShellPkg: BCFG dump improvemen
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, January 21, 2016 9:07 AM
> To: edk2-devel-01
> Cc: Carsey, Jaben ; Ryan Harkin
>
> Subject: [PATCH v2 01/14] ShellPkg: BcfgDisplayDump(): update
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, January 21, 2016 8:13 AM
> To: Carsey, Jaben ; Ryan Harkin
>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] [ShellPkg] f
> -Original Message-
> From: Ryan Harkin [mailto:ryan.har...@linaro.org]
> Sent: Thursday, January 21, 2016 12:47 AM
> To: Laszlo Ersek
> Cc: Carsey, Jaben ; edk2-devel@lists.01.org de...@ml01.01.org>
> Subject: Re: [PATCH] [ShellPkg] fix operator
> Importance:
l-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, January 20, 2016 5:12 PM
> To: edk2-de...@ml01.01.org
> Cc: Carsey, Jaben ; Ryan Harkin
>
> Subject: [edk2] [PATCH 00/13] ShellPkg: BCFG dump improvements
> Importance: High
>
> This series cleans up the &q
Note that when you specify your 1 2 3 it’s interpreted as a keystroke code. If
you want a string you should use “1 2 3”…
From: Ryan Harkin [mailto:ryan.har...@linaro.org]
Sent: Wednesday, January 20, 2016 2:18 PM
To: Carsey, Jaben
Cc: edk2-devel@lists.01.org ; Laszlo Ersek
Subject: RE
ER_OPT (x)
(BCFG_VAR_BUFFER_DPATH(x)+BCFG_VAR_BUFFER_LEN(x))
-Jaben
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, January 20, 2016 1:26 PM
> To: Ryan Harkin ; Carsey, Jaben
>
> Cc: edk2-devel@lists.01.org ; Linaro UEFI
>
501 - 600 of 723 matches
Mail list logo
