Re: [edk2] [PATCH v2 0/3] *** Add Nvme.h and NvmExpressLib ***

re Management protocol patch together. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of darbin.emm.re...@hpe.com Sent: Wednesday, May 18, 2016 5:16 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Darbin

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: VALID_ARCH cleanup to list supported options

o.a...@intel.com>; edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com> Subject: Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: VALID_ARCH cleanup to list supported options No AARCH64 ? Thomas -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Beha

Re: [edk2] [PATCH 0/2] Add Erase Block Protocol support for UFS devices

Looks good to me Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Monday, May 9, 2016 11:39 AM To: edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com> Cc: Wu, Hao A <hao.a...@intel.com> Subject: [PATCH 0/2] Add Er

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Wednesday, May 18, 2016 10:10 PM To: Laszlo Ersek <ler...@redhat.com>; Andrew Fish <af...@apple.com>; Foster, Matthew I <matthew.i.fos...@intel.com>; Tian, Feng <feng.t...@intel.com> Cc: edk2-dev

Re: [edk2] [PATCH] MdeModulePkg NvmExpressDxe: Add BlockIo2 support

Looks good to me Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Friday, May 6, 2016 4:01 PM To: edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com> Cc: Wu, Hao A <hao.a...@intel.com> Subject: [PATCH] MdeModul

Re: [edk2] [PATCH v2 3/3] MdeModulePkg: Add NvmExpressLib.

Message- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Wednesday, May 18, 2016 9:51 PM To: Tian, Feng <feng.t...@intel.com>; Reyes, Darbin <darbin.emm.re...@hpe.com>; edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Kinney, Michael

Re: [edk2] Filesystem installation issue on SATA HDD

[mailto:shaveta.lee...@nxp.com] Sent: Wednesday, May 18, 2016 5:28 PM To: Shaveta Leekha <shaveta.lee...@nxp.com>; Tian, Feng <feng.t...@intel.com>; edk2-devel@lists.01.org; Linaro UEFI Mailman List <linaro-u...@lists.linaro.org>; Jan Dąbroś <j...@semihalf.com> Subject: RE:

Re: [edk2] [PATCH v2 3/3] MdeModulePkg: Add NvmExpressLib.

RARY_CLASS = UefiNvmExpressLib |DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER Thanks Feng -Original Message- From: darbin.emm.re...@hpe.com [mailto:darbin.emm.re...@hpe.com] Sent: Wednesday, May 18, 2016 5:59 AM To: edk2-devel@lists.01.org Cc: Tian, Fe

Re: [edk2] Filesystem installation issue on SATA HDD

Do you mean to format the HDD to FAT32 file system? Or you found the BIOS doesn't identify the file system in the HDD correctly? If you meant the former, you need to use DiskUtilities to format your HDD. You can get it from http://www.intel.com/technology/efi/agree_diskutil.htm If you meant

Re: [edk2] Problem with SD stack

coherence issue, it's abstracted by PciIo.AllocateBuffer() & Map() & Unmap() interface to provide a consistent memory. Thanks Feng -Original Message- From: Jan Dąbroś [mailto:j...@semihalf.com] Sent: Tuesday, May 17, 2016 11:07 PM To: Tian, Feng <feng.t...@intel.com> Cc: edk2-

Re: [edk2] [PATCH 0/3] *** Add Nvme.h and NvmExpressLib ***

e have new request to support NVMe 1.2, we can add new definitions in. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Reyes, Darbin Sent: Friday, May 13, 2016 7:37 AM To: Tian, Feng <feng.t...@intel.com> Cc: Reyes, Darbin <darb

Re: [edk2] [PATCH v2 0/6] ATA PassThru & SATA device path PortMultiplier update

Looks good to me Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Tuesday, May 10, 2016 10:25 AM To: edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com> Cc: Wu, Hao A <hao.a...@intel.com> Subject: [PATCH v2 0/6] A

Re: [edk2] [PATCH 0/3] *** Add Nvme.h and NvmExpressLib ***

: darbin.emm.re...@hpe.com [mailto:darbin.emm.re...@hpe.com] Sent: Thursday, May 12, 2016 6:59 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming <liming@intel.com

Re: [edk2] [Patch v3] SecurityPkg OpalPasswordDxe: Error handling enhance when input password.

May 11, 2016 11:15 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [edk2] [Patch v3] SecurityPkg OpalPasswordDxe: Error handling enhance when input password. V2 -> V3: Refine the message in the popup dialog: 1. L"Confirm: Not unlock device and continue bo

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Fix wrong HII behavior for more than 8 RAM disks

It's ok for me. Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: Tuesday, May 3, 2016 4:24 AM To: Laszlo Ersek <ler...@redhat.com>; Wu, Hao A <hao.a...@intel.com> Cc: edk2-de...@ml01.01.org;

Re: [edk2] [Patch] SecurityPkg TcgStorageOpalLib: Check the capability before use.

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Dong, Eric Sent: Thursday, May 5, 2016 8:51 AM To: edk2-devel@lists.01.org Cc: Feng; Tian, Feng <feng.t...@intel.com> Subject: [Patch] SecurityPkg TcgStorageOpalLib: Check the capabilit

Re: [edk2] [patch] MdeModulePkg/Sd: add Erase Block support on sd/emmc device

I agree your comment. I will update it during check-in Thanks Feng -Original Message- From: Wu, Hao A Sent: Monday, May 9, 2016 10:54 AM To: Tian, Feng <feng.t...@intel.com> Cc: edk2-devel@lists.01.org Subject: RE: [patch] MdeModulePkg/Sd: add Erase Block support on sd/emmc devic

Re: [edk2] [PATCH] MdeModulePkg: FileExplorerLib: prevent freeing null pointer

Thanks for your contribution, Mike. Your commit log misses the license statement, I will help add below in. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Zimmermann Here is my response: Reviewed-by: Feng Tian

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken "Supported VPD Pages" VPD page

Laszlo, Thanks for your details. It looks make sense. Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, May 5, 2016 12:47 AM To: Tian, Feng &

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

. Thanks Feng -Original Message- From: Shaveta Leekha [mailto:shaveta.lee...@nxp.com] Sent: Thursday, May 5, 2016 2:02 PM To: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Laszlo Ersek <ler...@redhat.com>; edk2-devel@lists.01.org <e

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

AtaAtapiPassThru produces ATA_PASS_THRU and EXT_SCSI_PASS_THRU two protocol instances. AtaBus consumes ATA_PASS_THRU protocol to convert upper layer BlockIo request to ATA cmd and sent the cmd to specified ATA device. ScsiBus + ScsiDisk consume EXT_SCSI_PASS_THRU protocol to convert upper

Re: [edk2] [Patch 0/7] Enhance BlockSid releated logic.

Two minor comments: 1. please use a new macro to describe the ComId used for BlockSID. 2. It looks the patch 7/7's comment is not very matched with the code. The code always does BlockSid operation no matter if it's in unlock process. Others look good to me. Reviewed-by: Feng Tian

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken "Supported VPD Pages" VPD page

4, 2016 12:30 AM To: edk2-devel-01 <edk2-de...@ml01.01.org> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken &

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Install menu without device dependency.

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Dong, Eric Sent: Friday, April 29, 2016 2:07 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [Patch] SecurityPkg OpalPasswordDxe: Install menu without device

Re: [edk2] [Patch 0/3] Improve Fixed-MTRR programming performance

For patch #1, I have comment: 1. the parameter name is StartMsrNum, but the parameter comment is MsrNum. 2. the algorithm is calculating the MsrNum from *StartMsrNum + 1, it seems not match the comment "The start index of the fixed MTRR MSR to program". Other looks good to me. Reviewed-by: Feng

Re: [edk2] [Patch] MdeModulePkg: Correct PlatformHookLibSerialPortPpi module type.

Looks good to me Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Gao, Liming Sent: Friday, April 15, 2016 1:41 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [Patch] MdeModulePkg: Correct PlatformHookLibS

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Allocate Reserved memory

[mailto:g...@suse.com] Sent: Friday, April 15, 2016 11:37 AM To: Tian, Feng <feng.t...@intel.com> Cc: Laszlo Ersek <ler...@redhat.com>; Wu, Hao A <hao.a...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; edk2-de...@ml01.01.org Subject: Re: [edk2] [PATCH] MdeModulePkg RamDi

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Allocate Reserved memory

Hi, Lin Could you introduce more details on this? "I applied the NFIT patch(*) and it complained the allocated memory is not reserved so I wrote this patch." If os loader/app would like to create ramdisk for runtime use, it should invoke EFI_RAM_DISK_PROTOCOL to register the ramdisk using

Re: [edk2] [PATCH v2] MdeModulePkg NvmExpressDxe: Ensure write-through for NVMe write command

Looks good to me Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Wu, Hao A Sent: Thursday, April 14, 2016 9:14 AM To: edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com> Cc: Wu, Hao A <hao.a...@intel.com> Subject: [PATCH v2] MdeModulePkg Nvm

Re: [edk2] [Patch 0/6] Reference PCDs/Protocols defined in MdeModulePkg

Sorry for missing #4 patch. It's ok to me as well. Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Tian, Feng Sent: Monday, April 11, 2016 4:07 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@i

Re: [edk2] [Patch 0/6] Reference PCDs/Protocols defined in MdeModulePkg

#1,2,3 &6 patch looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, April 11, 2016 3:47 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu

Re: [edk2] [Patch v2] MdeModulePkg/Ps2Keyboard: Add missing PCD and protocol to DEC file

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, April 11, 2016 11:02 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [Patch v2] MdeModulePkg/Ps2Key

Re: [edk2] [Patch] UefiCpuPkg/CpuMpPei: Fix potential AP mwait wakeup issue

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, April 1, 2016 12:58 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [Patch] UefiCp

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message.

: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong <eric.d...@intel.com> Cc: Feng Tian <feng.t...@intel.com> -

Re: [edk2] [Patch] SecurityPkg TcgStorageOpalLib: Fix a typo.

01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [Patch] SecurityPkg TcgStorageOpalLib: Fix a typo. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong <eric.d...@intel.com> Cc: Feng Tian <feng.t...@intel.com> --- SecurityPkg/Library/TcgStorageOpal

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Suppress option for special device.

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Dong, Eric Sent: Thursday, April 7, 2016 1:59 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [Patch] SecurityPkg OpalPasswordDxe: Suppress option for spe

Re: [edk2] [Patch 0/4] Enhance the code of Opal Password solution.

I have given comments on 3rd patch in the series. Others look good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Friday, April 1, 2016 1:38 PM To:

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Enhance code to make it more safely.

s Feng -Original Message- From: Dong, Eric Sent: Tuesday, April 5, 2016 11:02 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [Patch] SecurityPkg OpalPasswordDxe: Enhance code to make it more safely. Patched fixed some small issue for this library: 1. Remove t

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent: Tuesday, April 5, 2016 11:54 AM To: Tian, Feng <feng.t...@intel.com> Cc: Ryan Harkin <ryan.har...@linaro.org>; edk2-devel@lists.01.org; Leif Lindholm

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

Hi, HaoJian We newly added EDKII SD/MMC stack to EDKII repo. If the SD/MMC host controller follows SD PCI host controller spec, the whole stack should work. But looks like PL180 doesn't follow the SD PCI host controller spec, you would have to add a new SD host controller driver to produce

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

for those non-coherent DMA or coherent DMA archs. Thanks Feng -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, April 1, 2016 3:21 PM To: Leendert van Doorn <leend...@paramecium.org> Cc: Leo Duran <leo.du...@amd.com>; Tian, Feng <feng

Re: [edk2] [PATCH] MdeModulePkg EmmcDxe: Fix GCC build failure with set but unused variables

an <feng.t...@intel.com> Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, March 30, 2016 5:25 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [PATCH] MdeModulePkg EmmcDxe: Fix GCC build failure with set but unused variables

Re: [edk2] [PATCH 0/2] Ensure write-through behavior for Scsi & NvmE devices

l01.01.org; Tian, Feng <feng.t...@intel.com> Cc: Paolo Bonzini <pbonz...@redhat.com> Subject: RE: [edk2] [PATCH 0/2] Ensure write-through behavior for Scsi & NvmE devices Hi Laszlo, I checked the NVM Express 1.2a spec and the SCSI Block Commands - 4 (SBC-4) spec. Though FUA is an

Re: [edk2] [Patch 1/8] MdePkg: Add definition for TCG Storage Core and Opal specs.

PS: please make sure latest GCC build pass before push as a new set-but-not-used option is introduced. Thanks Feng -Original Message- From: Tian, Feng Sent: Tuesday, March 29, 2016 9:42 AM To: Dong, Eric <eric.d...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@

Re: [edk2] [Patch 1/8] MdePkg: Add definition for TCG Storage Core and Opal specs.

Series reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Dong, Eric Sent: Monday, March 21, 2016 11:17 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [Patch 1/8] MdePkg: Add definition for TCG Storage Core an

Re: [edk2] [PATCH] MdeModulePkg PartitionDxe: Add Re-entry handling logic for BindingStop

<ruiyu...@intel.com>; Tian, Feng <feng.t...@intel.com> Cc: Wu, Hao A <hao.a...@intel.com> Subject: [PATCH] MdeModulePkg PartitionDxe: Add Re-entry handling logic for BindingStop There are scenario when the BindingStop service of PartitionDxe driver be re-entered. The current

Re: [edk2] [PATCH] MdeModulePkg PartitionDxe: Some ISO images cannot be recognized properly

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Thursday, March 17, 2016 10:46 AM To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu...@intel.com>; Tian, Feng <feng.t...@intel.com> Cc: Wu, Hao A <hao.a...@intel

Re: [edk2] [PATCH] MdeModulePkg DiskIoDxe: Media status check not be done at DiskIo level

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Thursday, March 17, 2016 10:46 AM To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu...@intel.com>; Tian, Feng <feng.t...@intel.com> Cc: Wu, Hao A <hao.a...@intel

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

Device Address. Thanks Feng -Original Message- From: Leendert van Doorn [mailto:leend...@paramecium.org] Sent: Friday, March 25, 2016 9:49 PM To: Ard Biesheuvel Cc: Tian, Feng; Leo Duran; edk2-devel@lists.01.org; leif.lindh...@linaro.org Subject: Re: [edk2] [PATCH] MdeModulePkg: support

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

please let me know. Thanks Feng -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, March 25, 2016 6:41 PM To: Leendert van Doorn Cc: Tian, Feng; Leo Duran; edk2-devel@lists.01.org; leif.lindh...@linaro.org Subject: Re: [edk2] [PATCH] MdeModulePkg: suppo

Re: [edk2] [PATCH 00/35] remove unused but set variables

MdeModulePkg series reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, March 24, 2016 6:37 PM To: edk2-devel-01 Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A;

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

Duran Could you explain more about this fix? 1) What's the meaning of PCI emulation here? 2) What's the difference between normal case and this PCI emulation? 3) Why this PCI emulation case needs to update driver to directly use PCI address for filling transfer descriptor content? Thanks

Re: [edk2] [Patch] MdeModulePkg/Bds: Fix VS2012 build failure.

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Thursday, March 24, 2016 10:34 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: [Patch] MdeModulePkg/Bds

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Fix typo in HII message

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Zeng, Star Sent: Thursday, March 24, 2016 8:44 AM To: Alcantara, Paulo <paulo.alc.cavalca...@hp.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: Re: [edk2] [P

Re: [edk2] [patch 3/4] MdePkg/IndustryStandard: Add SD/EMMC common definitions

Thanks for raising this issue, I will update it. Thanks Feng -Original Message- From: Yao, Jiewen Sent: Wednesday, March 23, 2016 10:55 AM To: Tian, Feng <feng.t...@intel.com>; edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Zeng, Star <star.z...@intel.c

Re: [edk2] [PATCH 0/3] MdeModulePkg RamDiskDxe: Fix potential issues

Series reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Wu, Hao A Sent: Tuesday, March 22, 2016 10:42 AM To: edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com> Cc: Wu, Hao A <hao.a...@intel.com> Subject: [PATCH 0/3] MdeModuleP

Re: [edk2] [COMMIT] MdeModulePkg: ConSplitterDxe: use U64 mult/div wrappers in AbsPtr scaling

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, March 16, 2016 9:10 PM To: edk2-de...@ml01.01.org Subject: [edk2] [COMMIT] MdeModulePkg: ConSplitterDxe: use

Re: [edk2] Is there any exiting way in edk2 to format a partition with FAT file system?

http://www.intel.com/technology/efi/agree_diskutil.htm Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Friday, March 18, 2016 6:23 PM To: edk2-devel@lists.01.org Subject: [edk2] Is there any exiting way in edk2 to

Re: [edk2] [PATCH] MdeModulePkg: Add PcdMaxPeiPerformanceLogEntries16 PROMPT STR to *.uni

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Qiu, Shumin Sent: Monday, March 14, 2016 9:55 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Cinnamon Shia <cinnamon.s...@hpe.com>; Tian, Feng <feng.t...@i

Re: [edk2] [PATCH v6] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

ch 9, 2016 8:44 AM To: Cecil Sheng <cecil.sh...@hpe.com>; edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com> Subject: RE: [edk2] [PATCH v6] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition. Reviewed-by: Eric Dong <eric.d...@intel.com> Feng,

Re: [edk2] [Patch] UefiCpuPkg: Add dynamic type for PcdCpuMaxLogicalProcessorNumber

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Fan, Jeff Sent: Thursday, March 3, 2016 3:29 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [Patch] UefiC

Re: [edk2] EDK2 Setup & Configuration Issue

Git https://github.com/tianocore/edk2-BaseTools-win32.git Svn mirror https://svn.code.sf.net/p/edk2-toolbinaries/code/trunk/Win32 Please download it to BaseTools\Bin\Win32 directory. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [PATCH v2 0/2] RAM disk driver implementation

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El-Haj-Mahmoud, Samer Sent: Friday, February 26, 2016 8:34 PM To: Wu, Hao A <hao.a...@intel.com>; edk2-devel@lists.01.org

Re: [edk2] [Patch V2 1/3] MdeModulePkg/PciBus: Change local variable AddressSpace to Descriptor

Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Wednesday, February 24, 2016 4:07 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Tian, Feng <feng.t...@intel.com>; Fan, Jeff <jeff@intel.com>

Re: [edk2] [Patch] MdeModulePkg/Partition: Fix 64bit build failure caused by last patch

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Monday, February 22, 2016 10:45 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg/Partition: Fix 64bit build failure caused by last patch Contributed-under: Tia

Re: [edk2] [Patch] MdeModulePkg/Partition: Use proper partition number for MBR

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Thursday, February 18, 2016 14:43 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg/Partition: Use proper partition number for MBR UEFI Spec 2.3.1.D Section 9

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

As far as I know, there is no any BlockIo producers bouncing I/O. Just DiskIo producers have such behavior. Jeremy may mix them up. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, February 15, 2016 19:46 To: Tian, Feng; Ryan Harkin; Jeremy Linton Cc

Re: [edk2] [PATCH] MdeModulePkg/UsbBusDxe: Fix memory leak

Paulo, Thanks for fixing this bug. Reviewed-by: Feng Tian <feng.t...@intel.com> Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Alcantara, Paulo Sent: Tuesday, February 09, 2016 04:54 To: edk2-devel@lists.01.org Cc: Tian

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

Hi, Jeremy Sorry for missing this mail. I would *REJECT* this patch as it should be grub2's bug in which it passes down an unaligned buffer. Accroding to UEFI spec , it clearly described that the IoAlign should be met by the BlockIo's caller "IoAlign Supplies the alignment requirement for

Re: [edk2] [Patch] MdeModulePkg/UsbAbsPointer:Fix GetState() to return absolute value

Looks good to me Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Tuesday, February 02, 2016 16:04 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg/UsbAbsPointer:Fix GetState() to return absolute valu

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for MdeModulePkg

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Thursday, January 28, 2016 4:23 PM To: edk2-devel@lists.01.org Cc: Tian, Feng; Gao, Liming Subject: [edk2] [PATCH] Maintainers.txt:

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Don't unnecessarily create timezone variable.

Looks good to me. Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, January 28, 2016 10:22 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [edk2]

Re: [edk2] [PATCH 1/3] MdeModulePkg: NvmExpressDxe: clean up NvmeRead() / NvmeWrite() debug msgs

rmance Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, January 27, 2016 10:36 To: edk2-de...@ml01.01.org Cc: Tian, Feng Subject: [PATCH 1/3] MdeModulePkg: NvmExpressDxe: clean up NvmeRead() / NvmeWrite() debug msgs These workhorse functions ar

Re: [edk2] [Patch] MdeModulePkg/PciHostBridgeDxe: Fix GCC build failure.

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Monday, January 25, 2016 10:28 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg/PciHostBridgeDxe: Fix GCC build failure. Contributed-under: TianoCore Contri

Re: [edk2] [PATCH] MdeModulePkg/.../IdeMode: correctly report length of returned data

rsek [mailto:ler...@redhat.com] Sent: Saturday, January 23, 2016 00:59 To: Paolo Bonzini; Tian, Feng Cc: edk2-de...@ml01.01.org; js...@redhat.com Subject: Re: [edk2] [PATCH] MdeModulePkg/.../IdeMode: correctly report length of returned data On 01/22/16 15:23, Paolo Bonzini wrote: > > > On 21/

Re: [edk2] [PATCH] MdeModulePkg/.../IdeMode: correctly report length of returned data

Paolo, I think for short write case it means the data length to be written in AtaPacketReadWrite, that is ByteCount, is less than the one shipped in ATA cmd, for example, CDB (READ10.byte7&8). For such case, it should jump out the while loop in AtaPacketReadWrite and send EFI_DEVICE_ERROR as

Re: [edk2] [PATCH 0/2] MdeModulePkg/.../IdeMode: restore handling of "short reads"

amp; SPC4 spec, they all state the inquiry data includes at least 36 bytes. But we defines it as 96 bytes or more. Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, January 19, 2016 08:35 To: edk2-de...@ml01.01.org Cc: Tian, Feng; Zeng, Star; Joh

Re: [edk2] [Patch V4 1/4] MdeModulePkg: Add new library class PciHostBridgeLib

Reviewed-by: Feng Tian <feng.t...@intel.com> A very trivial comment: why the file macro naming is _*__ rather than __*__ or _*_? -Original Message- From: Ni, Ruiyu Sent: Wednesday, January 13, 2016 16:00 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng; Fan, Jeff; Kinney, M

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Wednesday, January 13, 2016 16:00 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Fan, Jeff; Tian, Feng Subject: [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver. This driver

Re: [edk2] [Patch V4 2/4] MdeModulePkg: Add PciHostBridgeLibNull

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Wednesday, January 13, 2016 16:00 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Fan, Jeff; Tian, Feng Subject: [Patch V4 2/4] MdeModulePkg: Add PciHostBridgeLibNull Contributed-under: Tia

[edk2] [patch 2/2] MdeModulePkg/NvmExpressDxe: Fix MS toolchain /Od 32bit build failure

Note NVME_ACQ & NVME_ASQ internal data structure are changed to make build pass. Cc: Wu, Hao A Cc: Zeng, Star Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian ---

[edk2] [patch 0/2] Fix MS tool chain 32bit /Od build failure

Two drivers are involved: 1. UfsBlockIoPei 2. NvmExpressDxe Tian Feng (2): MdeModulePkg/UfsBlockIoPei: Fix MS toolchain /Od 32bit build failure MdeModulePkg/NvmExpressDxe: Fix MS toolchain /Od 32bit build failure MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c | 6

[edk2] [patch 1/2] MdeModulePkg/UfsBlockIoPei: Fix MS toolchain /Od 32bit build failure

Cc: Wu, Hao A Cc: Zeng, Star Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [edk2] [PATCH] MdeModulePkg: Fix 'accroding' typos in MdeModulePkg.dec/.uni

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Tuesday, January 05, 2016 09:21 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [edk2] [PATCH] MdeModulePkg: Fix 'acc

Re: [edk2] [Edk2] bug in nvme driver disk info protocol

Update edk2 mail list to edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> as the edk2-de...@lists.sourceforge.net<mailto:edk2-de...@lists.sourceforge.net> was deprecated. From: Tian, Feng Sent: Monday, January 04, 2016 11:16 To: 'Anindya Rai' Cc: edk2-de...@lists.sourceforg

Re: [edk2] [PATCH 0/8] Fix typo for 'accroding' to 'according'

Looks good to me for MdeModulePkg changes Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Friday, December 25, 2015 09:24 To: edk2-devel@lists.01.org; Yao, Jiewen Cc: Wu, Hao A Subject:

Re: [edk2] [PATCH] MdeModulePkg/XhciPei: Fix VS2015 build warning

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Anbazhagan, Baraneedharan Sent: Tuesday, December 22, 2015 12:27 AM To: edk2-devel@lists.01.org; Tian, Feng Subject: [edk2] [PATCH] MdeModulePkg/X

Re: [edk2] [PATCH] MdeModulePkg: Add error DEBUG statements in Ata bus driver

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud Sent: Tuesday, December 22, 2015 5:45 AM To: edk2-devel@lists.01.org Cc: Samer El-Haj-Mahmoud; Tian, Feng Subject: [edk2]

Re: [edk2] [PATCH] MdeModulePkg ScsiDiskDxe: Fix async request retry times info lost issue

Looks good to me. Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, December 21, 2015 17:35 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [edk2] [PATCH] MdeMod

Re: [edk2] [PATCH 0/3] ScsiDiskDxe: Modify BlockIo(2) APIs to follow spec

Looks good to me. Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Wu, Hao A Sent: Monday, December 21, 2015 17:06 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH 0/3] ScsiDiskDxe: Modify BlockIo(2) APIs to follow spec Right now, SCSI

Re: [edk2] [PATCH] MdeModulePkg ScsiDiskDxe: Add retry scheme for async SCSI I/O command

Looks good to me Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Wu, Hao A Sent: Tuesday, December 22, 2015 00:18 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH] MdeModulePkg ScsiDiskDxe: Add retry scheme for async SCSI I/O command

Re: [edk2] [PATCH 0/3] Not signal caller event when async SCSI I/O cmd fails

Looks good to me Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Wu, Hao A Sent: Monday, December 21, 2015 17:33 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH 0/3] Not signal caller event when async SCSI I/O cmd fails When a Bl

Re: [edk2] [PATCH] MdeModulePkg DiskIoDxe: Check for MediaPresent in DiskIo2ReadWriteDisk()

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, December 21, 2015 17:08 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [edk2] [PATCH] MdeModulePkg DiskIoDxe:

Re: [edk2] [PATCH 0/4] Raise Tpl to TPL_NOTIFY when dealing SCSI async I/O

-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Tuesday, December 22, 2015 00:15 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [edk2] [PATCH 0/4] Raise Tpl to TPL_NOTIFY when dealing SCSI async I/O When reading data from non-blockingly from a CD-ROM logic par

Re: [edk2] [PATCH] MdeModulePkg: Fix VS2012 build failure.

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: Qiu, Shumin Sent: Thursday, December 17, 2015 13:03 To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Tian, Feng; Cecil Sheng Subject: [PATCH] MdeModulePkg: Fix VS2012 build failure. Cc: Feng Tian <feng.t...@inte

[edk2] [patch 0/2] Fix two issues in PciSioSerialDxe

There are two issues: 1. Add assertion to make sure there is no non-null pointer dereference 2. Make sure the operands of bitwise operation have same size Tian Feng (2): MdeModulePkg/PciSioSerialDxe:add non-null pointer dereference assertion MdeModulePkg/PciSioSerialDxe:bitwise operation

[edk2] [patch 2/2] MdeModulePkg/PciSioSerialDxe:bitwise operation have same width operands

Operands in a bitwise operation have different size. Update code to fix it. Cc: Qiu Shumin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/PciSioSerialDxe/Serial.c | 2 +- 1 file changed, 1

Re: [edk2] [PATCH] MdeModulePkg UfsPassThru: ASSERT if params are NULL in SignalCallerEvent

Reviewed-by: Feng Tian <feng.t...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, December 14, 2015 09:44 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A; Qiu, Shumin Subject: [edk2] [PATCH] MdeMod

Re: [edk2] [Patch] ShellPkg/Mm: Fix build warnings

On behalf of Ray. Reviewed-by: Feng Tian Same again, I will help commit it. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Sunday, December 13, 2015 05:50 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu;

Re: [edk2] [Patch] MdeModulePkg/PciSioSerialDxe: Fix compiler warnings

On behalf of Ray, Reviewed-by: Feng Tian I will help commit it. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Sunday, December 13, 2015 04:33 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu

<    1   2   3   4   >