Right. Thanks a lot to catch it.
I will fix it before check in.
Thank you
Yao Jiewen
-Original Message-
From: Zhang, Chao B
Sent: Thursday, August 13, 2015 9:32 AM
To: Yao, Jiewen; edk2-devel@lists.01.org
Subject: RE: [patch 1/2] Add TPM2 definition in trusted computing group.
Hi
Reviewed-by: Yao, Jiewen jiewen@intel.com
At same time, I suggest we move PcdTpm2HashMask to Dynamic section too, because
now Tcg2Pei will set this PCD according to TPM2 device capability.
If you agree, I will check in both.
Thank you
Yao Jiewen
-Original Message-
From: El-Haj
OK
-Original Message-
From: Gao, Liming
Sent: Tuesday, August 18, 2015 10:48 AM
To: Yao, Jiewen; Michael Zimmermann; edk2-devel@lists.01.org
Subject: RE: [edk2] Section Alignment of elf binaries compiled with GCC(Linux)
Jiewen:
The updated message is useful. I suggest to change error
more question.
Thank you
Yao Jiewen
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of David
Van Arnem
Sent: Saturday, August 22, 2015 12:44 AM
To: edk2-devel@lists.01.org
Subject: Re: [edk2] Measured boot in OVMF with QEMU TPM passthrough?
Hello
Reviewed-by: jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Tuesday, August 18, 2015 8:29 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [PATCH] MdeModulePkg: Add PlatformVarCleanupLib library
Cc: Jiewen Yao jiewen@intel.com
Contributed-under: TianoCore
Reviewed-by: jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Tuesday, August 18, 2015 8:29 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [PATCH] MdeModulePkg: Add VarCheckPcdLib NULL class library
The check will be based on PcdVarCheck binary that generated
Reviewed-by: jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Tuesday, August 18, 2015 8:29 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [PATCH] MdeModulePkg: Add VarCheckHiiLib NULL class library
The check will be based on VarCheckHiiBin that generated
from FV
HI Samer
Yes, I can, if you can attach you patch.
I think it is good idea, but I have not seen your patch yet.
Thank you
Yao Jiewen
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Saturday, August 15, 2015 7:45 PM
To: edk2-devel@lists.01.org; Yao, Jiewen
Cc: Zhang, Chao B
Thanks for the info. That makes sense.
It is pity that there is no X64 version and SMP not work. We can make
improvement step by step.
Thank you
Yao Jiewen
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Wednesday, July 29
Hello
Do we consider below 2 options?
-- DriversPkg/Vendor/VendorName/Bus/BusType ?
or
-- DriversPkg/Bus/BusType/Vendor/VendorName ?
Another option is that we add DriverCategory, like GOP/UNDI/RAID/SIO. Then we
can put UNDI driver together, no matter it is PCI based or USB based.
Thank you
Yao
Reviewed by: Yao, Jiewen jiewen@intel.com
-Original Message-
From: Qiu, Shumin
Sent: Monday, August 03, 2015 3:05 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Yao, Jiewen
Subject: [PATCH] SecurityPkg/Tcg/MemoryOverwriteRequestControlLock: Add missing
header file description
Hi Bill
That is good question. In first version of TrEE, we do measure it at same
place. But later, we realize it might cause issue on Win8. I added comments in
code.
//
// We need measure Separator(7) here, because this event must be between
SecureBootPolicy (Configure)
// and
Reviewed-by: Yao, Jiewen jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Friday, July 24, 2015 3:34 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [PATCH] MdeModulePkg Variable: Read
Reviewed by: Yao, Jiewen jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Tuesday, July 21, 2015 5:02 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [PATCH 2/2] SecurityPkg AuthVariableLib: Correct address pointers data
Originally, the double pointer (VOID
. And it is approved working in EDKII FSP wrapper.
Thank you
Yao Jiewen
-Original Message-
From: Rangarajan, Ravi P
Sent: Tuesday, October 27, 2015 1:08 AM
To: Yao, Jiewen; edk2-devel@lists.01.org
Cc: Ma, Maurice; Kinney, Michael D
Subject: RE: [patch] Publish FspHob to PEI Hob by default, because
Looks good. Reviewed by: jiewen@intel.com
Thank you
Yao Jiewen
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, October 28, 2015 2:09 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Fan, Jeff
Subject: [PATCH] UefiCpuPkg: SmmCpuFeaturesLib: Add MSR_SMM_FEATURE_CONTROL
instead of EFI_D_INFO in InternalDumpData() and
InternalDumpHex().
8. Use correct VendorGuid and VendorTable to measure.
Cc:Jiewen Yao <jiewen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.z...@intel.com>
---
.../SmbiosMe
this patch is unnecessary, I believe.
For debug purpose, you can apply it at first in your branch, just in case it is
emulator error.
Have a good night!
Thank you
Yao Jiewen
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday,
Ah, yes, you are right! Thank you!
I will resend patch.
-Original Message-
From: Mike Maslenkin [mailto:mike.maslen...@gmail.com]
Sent: Monday, October 26, 2015 5:31 PM
To: Yao, Jiewen
Cc: edk2-devel@lists.01.org; Ma, Maurice; Rangarajan, Ravi P
Subject: Re: [edk2] [patch] Do
Looks good. Reviewed by jiewen@inter.com
-Original Message-
From: Kinney, Michael D
Sent: Thursday, October 22, 2015 7:26 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Fan, Jeff
Subject: [PATCH] UefiCpuPkg: PiSmmCpuDxeSmm: Remove unused references to SmmLib
The PiSmmCpuDxeSmm
Good suggestion. I will update.
-Original Message-
From: Zhang, Chao B
Sent: Monday, November 09, 2015 9:00 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Subject: RE: [patch] Add error handling for TPM in S3 resume failure.
Jiewen:
Should we do HashLogExtendEvent after SetTpm2HashMask
Reviewed by: jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo
Sent: Tuesday, November 10, 2015 1:52 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D; Heyi Guo; Yao, Jiewen; Gao, Liming
Subject: [edk2] [PATCH V2
ing@intel.com>
Reviewed-by: Star Zeng <star.z...@intel.com>
Reviewed-by: Jiewen Yao <jiewen@intel.com>
---
.../BasePostCodeLibPort80.inf | 5 +++--
MdePkg/Library/BasePostCodeLibPort80/PostCode.c| 24 ++---
to figure out other
better way.
Thank you
Yao Jiewen
-Original Message-
From: Justen, Jordan L
Sent: Thursday, November 12, 2015 6:41 AM
To: Kinney, Michael D; Yao, Jiewen; Laszlo Ersek
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing
TSEG
Good. Thanks!
Reviewed by: jiewen@intel.com
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, November 14, 2015 4:52 AM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Kinney, Michael D; Justen, Jordan L
Subject: [PATCH] MdeModulePkg: SmmLockBoxPeiLib
Hi
Thanks for the update.
Would you consider adding Table Revision 0x2 as well?
Reviewed-by: jiewen@intel.com
Thank you
Yao Jiewen
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo
Sent: Monday, November 09, 2015 5:30 PM
To: edk2
Reviewed by jiewen@intel.com
Do you think we can add ASSERT for invalid port width?
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng,
Star
Sent: Monday, November 09, 2015 1:37 PM
To: Gao, Liming; edk2-devel@lists.01.org
Subject: Re:
DxeCpu driver. I'm just thinking if we have
robust way to prevent error happening again... if DxeCpu driver is not written
by us.
Thank you
Yao Jiewen
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Friday, October 30, 2015 4
Reviewed-by: jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Friday, October 30, 2015 10:12 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Qiu, Shumin
Subject: [PATCH] MdeModulePkg SmbiosMeasurementDxe: NULL check to String from
GetSmbiosStringById
When StringId
Looks good. Reviewed by: jiewen@intel.com
Would you please add some comments in the code to indicate why we need skip
check in Set() and add check in Get()?
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, October 19,
Reviewed by: jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Thursday, October 15, 2015 4:42 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [PATCH] SecurityPkg: Use PcdSet##S to instead
PiSmmCore is inside of SMM, so it can still access same physical address, by
using 1:1 mapping paging in SMM.
Thank you
Yao Jiewen
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of iMac Pro
Sent: Thursday, October 15, 2015 4:59 PM
To: edk2-devel@lists.01.o
Looks good.
-Original Message-
From: Zeng, Star
Sent: Thursday, October 08, 2015 3:40 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Gao, Liming
Subject: [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use PcdSet64S to instead of
PcdSet64
PcdSet## has no error status returned
Hello
According to "IA32 SDM, page 1428, 4-330 Vol. 2B, RSM?Resume from System
Management Mode", I do not find word say: 64bit mode is invalid.
Would you please point out where you find "RSM is invalid in 64-bit mode "?
===
Operation
ReturnFromSMM;
IF (IA-32e mode
Looks good, reviewed by jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Thursday, October 15, 2015 10:58 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [PATCH] MdeModulepkg VarCheckLib: Return NULL when no property set
to variable with wildcard name
reviewed by jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Thursday, October 15, 2015 10:58 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [PATCH] SecurityPkg AuthVariableLib: Add the missing
gEfiAuthenticatedVariableGuid
There is no real build failure
reviewed by jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Thursday, October 15, 2015 10:58 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [PATCH] MdeModulePkg VariableRuntimeDxe: Add the missing
gEfiImageSecurityDatabaseGuid
Otherwise there will be build
Looks good. Thanks!
-Original Message-
From: Qiu, Shumin
Sent: Thursday, August 27, 2015 1:13 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Yao, Jiewen; Zhang, Chao B
Subject: [PATCH 3/3] SecurityPkg: Refine the local variable name to follow EDK2
coding style.
Cc: Yao Jiewen jiewen
Looks good. Thanks!
-Original Message-
From: Qiu, Shumin
Sent: Thursday, August 27, 2015 1:13 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Yao, Jiewen; Zhang, Chao B
Subject: [PATCH 2/3] SecurityPkg: Add missing Lib definition in DEC file.
Cc: Yao Jiewen jiewen@intel.com
Cc: Chao
Sounds great! :-)
BTW: Do you know if there is TPM2 passthrough support for QEMU?
The TCG is moving to TPM2 now...
Thank you
Yao Jiewen
-Original Message-
From: David Van Arnem [mailto:dvanar...@cmlab.biz]
Sent: Friday, August 28, 2015 4:56 AM
To: edk2-devel@lists.01.org; Yao, Jiewen
Reviewed-by: jiewen@intel.com
-Original Message-
From: Fan, Jeff
Sent: Wednesday, September 02, 2015 4:13 PM
To: edk2-devel@lists.01.org
Cc: Tian, Feng; Yao, Jiewen
Subject: [Patch] UefiCpuPkg/MtrrLib: MtrrValidBitsMask and MtrrValidAddressMask
wrong
Per IA32 SDM, if CPUID
Looks good.
Reviewed by: jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer
El-Haj-Mahmoud
Sent: Tuesday, September 15, 2015 4:40 AM
To: edk2-devel@lists.01.org
Cc: Samer El-Haj-Mahmoud; Zhang, Chao B; Samer
Reviewed by: jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Thursday, September 17, 2015 1:54 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Gao, Liming
Subject: [PATCH] MdeModulePkg DxeCore: Take the range in resource HOB for PHIT
as higher priority
Take the range
Looks good.
Reviewed-by: jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan
Sent: Wednesday, September 16, 2015 4:15 PM
To: edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Yao, Jiewen; Gao, Liming
Subject: [edk2] [Patch
Reviewed by: jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Wednesday, September 16, 2015 7:59 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Gao, Liming
Subject: [PATCH] MdeModulePkg DxeCore: Relocate HOB List after other tested
memory resources added
The HOB List
Hi
As I know, Win10 is using TCG2 protocol, and TCG has errata to make TCG2
capability structure unpacked. So I do not suggest we add pack for CAPABLITY in
this case.
Thank you
Yao Jiewen
-Original Message-
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com]
Sent
Thanks. Reviewed-by: jiewen@intel.com
-Original Message-
From: Bu, Daocheng
Sent: Wednesday, December 02, 2015 4:01 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [Patch] MdePkg: Add Ipmi2.0 definitions head file.
Add Ipmi2.0 definitions head file based on Ipmi category
ot;)); <== New line
return ;
}
Thank you
Yao Jiewen
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Friday, December 04, 2015 8:27 AM
To: Laszlo Ersek; Kinney, Michael D
Cc: Hamel, Lee M; edk2-devel@lists.0
And UEFI_APPLICATION, I think. :-)
-Original Message-
From: Gao, Liming
Sent: Thursday, December 17, 2015 8:48 AM
To: Bu, Daocheng; edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: RE: [edk2] [Patch] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library
Class.
Does it need to support
Reviewed by jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Thursday, December 17, 2015 2:51 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2 3/3] EdkCompatibilityPkg: Fix GCC error to avoid the
HI Samer
The patch is good.
The check in comment seems not match the file you changed. Should it be "The
GicVersion field is defined in ACPI 5.1 and 6.0"?
Reviewed-by: jiewen@intel.com, if you change the comment, when you check in.
-Original Message-
From: edk2-devel
-30_0-52.pdf
I checked "Table 1: Physical Presence Interface Operation Summary for TPM 1.2",
But I cannot to find " PHYSICAL_PRESENCE_CLEAR_DEACTIVATE_DISABLE
23"
23 - 127 Reserved
Would you please share the info on where you get this definition?
Thank you
Yao J
OK. I can help on that.
Thanks to fix that.
Thank you
Yao Jiewen
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com]
Sent: Tuesday, December 15, 2015 8:54 AM
To: edk2-devel@lists.01.org; Yao, Jiewen
Subject: RE: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions
Reviewed-by: jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 16, 2015 1:05 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] MdeModulePkg: Update print error level for
RuntimeDriver
Hi Liming
Can we use SmmIsBufferOutsideSmmValid() in SmmMemLib?
Then we can remove IsAddressValid() completely.
Thank you
Yao Jiewen
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 16, 2015 6:18 PM
To: edk2
Reviewed by: jiewen@intel.com
-Original Message-
From: Kinney, Michael D
Sent: Thursday, January 07, 2016 9:53 AM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B; Yao, Jiewen
Subject: [Patch] SecurityPkg/Tcg: Fix debug messages
Debug messages are using a format strings with %s
Reviewed by: jiewen@intel.com
-Original Message-
From: Kinney, Michael D
Sent: Thursday, January 07, 2016 9:50 AM
To: edk2-devel@lists.01.org
Cc: Steele, Kelly; Yao, Jiewen
Subject: [Patch] QuarkPlatformPkg/PlatformInit: Adjust memory bin size to avoid
reboot
Update memory bin
Reviewed by: jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang,
Chao B
Sent: Friday, January 08, 2016 3:34 PM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Zhang, Chao B; Long, Qin
Subject: [edk2] [PATCH] SecurityPkg
Reviewed by: jiewen@intel.com
-Original Message-
From: Wu, Hao A
Sent: Friday, December 25, 2015 9:24 AM
To: edk2-devel@lists.01.org; Yao, Jiewen
Cc: Wu, Hao A
Subject: [PATCH 8/8] SecurityPkg Tcg2Pei: Fix a typo in function description
Contributed-under: TianoCore Contribution
Reviewed by jiewen@intel.com
-Original Message-
From: Zeng, Star
Sent: Monday, December 28, 2015 2:19 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [PATCH] MdeModulePkg Variable: VarErrFlag need to be consistent in NV
flash and cache
The code wrongly has TempFlag wrote
Hi
I suggest we also handle PcdShellMaxHistoryCommandCount == 0 case.
I think we can add below at the begging of function.
if (MaxHistoryCmdCount == 0) {
return ;
}
Other change seems good. Reviewed by: jiewen@intel.com
Thank you
Yao Jiewen
-Original Message-
From: edk2
Reviewed by: jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu
Shumin
Sent: Thursday, December 24, 2015 2:10 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Carsey, Jaben; Qiu, Shumin; Yao, Jiewen
Subject: [edk2] [PATCH v2 1
Reviewed by: jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Wednesday, December 23, 2015 5:06 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Yao, Jiewen
Subject: [edk2] [Patch V2] Nt32Pkg
, December 18, 2015 10:54 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [Patch] MdePkg: Modify Ipmi2.0 definitions header files for
data structure name suffix.
Modify Ipmi2.0 definitions header files for data structure name suffix for
request/response data.
Contributed-under
Comments below:
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, November 25, 2015 10:48 PM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Fan, Jeff; Zeng, Star
Subject: Re: [edk2] [patch 1/7] MdeModulePkg/PiSmmCore: Add EDKII PI SMM
Hi Laszlo
Comments below:
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Friday, November 27, 2015 5:57 AM
To: Yao, Jiewen; Kinney, Michael D; edk2-de...@ml01.01.org
Cc: Paolo Bonzini; Fan, Jeff
Subject: Re: [edk2] [patch 2/2
com]
Sent: Friday, November 27, 2015 8:07 PM
To: Yao, Jiewen
Cc: Ard Biesheuvel; edk2-devel-01; Leif Lindholm (Linaro address)
Subject: Re: [edk2] please DO NOT commit unreviewed patches to subversion!
On 11/27/15 12:31, Yao, Jiewen wrote:
> Hi Laszlo and Ard
> First of all, I apologize the c
rviceSelector : 4;
+ UINT8 TapDialStringSelector : 4;
+} DESTINATION_TAP_ACCOUNT;
+
+typedef struct {
+ UINT8 TapSelector;
+ UINT8 PagerIdString[16];
+} TAP_PAGER_ID_STRING;
+
-Original Message-
From: Bu, Daocheng
Sent: Thursday, November 26, 2015 4:23 PM
To: edk2-devel@lists.01.org
Cc:
Agree. I will not separate patch, but keep his suggestion in.
Definitely, he deserves the credit.
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, November 27, 2015 10:24 PM
To: Paolo Bonzini; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Yao, Jiewen; Fan
not aware the difference of commit between SVN and GIT.
Laszlo
I am fine to revert them and commit in the way reviewed. I appreciate your help!
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, November 27, 2015 6:33 PM
To: Ard Biesheuvel; Yao, Jiewen
Cc: edk2
I will repost the patch, including your fix.
Appreciate your help on that!
-Original Message-
From: Paolo Bonzini [mailto:pbonz...@redhat.com]
Sent: Friday, November 27, 2015 9:47 PM
To: edk2-de...@ml01.01.org
Cc: ler...@redhat.com; Fan, Jeff; Yao, Jiewen; Kinney, Michael D
Subject
Great! Thanks for your kind help!
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, November 27, 2015 9:51 PM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Cc: Fan, Jeff; Kinney, Michael D
Subject: Re: [patch REPOST 0/3] Add 2 APIs in SmmCpuFeaturesLib.
On 11/27
Got it. I will create a new patch to handle that.
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 26, 2015 8:00 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D
Cc: Fan, Jeff
Subject: RE: [patch] UefiCpuPkg/PiSmmCpu: Move XD enable to ASM before paging
file. We can do
it in C code directly.
Then there is no *COPY*, just INIT. I hope this can eliminate the confusing.
Thank you
Yao Jiewen
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 26, 2015 8:10 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D
Cc: Fan
Thanks Mike. I have checked in SVN 18958, with comment update as your
suggestion.
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 26, 2015 2:39 AM
To: Laszlo Ersek; edk2-de...@ml01.01.org; Kinney, Michael D
Cc: Yao, Jiewen; Fan, Jeff
Subject: RE: [edk2] [PATCH v2 2/2
be read only, after I set IDT table to be
ReadOnly, because they are all mixed into one data region.
Thank you
Yao Jiewen
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 26, 2015 1:16 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D
Cc: Fan, Jeff
Subject
think it is better solution?
Agree. I will use MACRO instead of hardcode 0xc080 and 0x800.
Agree. I will remove unused ActivateXd().
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 26, 2015 1:28 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D
Cc
Got it. I generated it successfully with your guide. Thanks!
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, November 25, 2015 11:35 PM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Fan, Jeff; Zeng, Star
Subject: Re: [edk2] [patch 1/7
Hi Mike
Thanks for the suggestion.
Previously, I just want to *ADD* without touch old logic. I will use your way
to do it.
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 26, 2015 2:01 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D
Cc: Fan, Jeff
Yes, that is good suggestion. I will update comment section before check in.
-Original Message-
From: Kinney, Michael D
Sent: Thursday, November 26, 2015 1:50 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D
Cc: Yao, Jiewen; Fan, Jeff
Subject: RE: [edk2] [patch 2/3
Sorry, I should call you Laszlo.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao,
Jiewen
Sent: Wednesday, November 25, 2015 7:49 PM
To: Laszlo Ersek; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Fan, Jeff
Subject: Re: [edk2] [patch 2/3
HI Ersek
May I know when you plan to check in your SmmCpuFeaturesLib for SMM?
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Wednesday, November 25, 2015 7:39 PM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Cc: Kinney, Michael D
Sure. That would be better for me. Thanks a lot!
I found Mike already replied to me to clarify API. It would not be long. I
hope. :-)
Thank you
Yao Jiewen
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, November 25, 2015 8:00 PM
To: Yao, Jiewen; edk2
Thanks to catch that!
I will fix it when I check in.
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, November 25, 2015 8:34 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D
Cc: Zeng, Star; Fan, Jeff
Subject: RE: [patch] MdeModulePkg/PiSmmCore: Install
Looks good. Thank you very much for your kind help!
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, December 01, 2015 3:58 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Paolo Bonzini; Fan, Jeff
Subject: Re: [edk2] [patch V2 0/2
Reviewed by: jiewen@intel.com
-Original Message-
From: Fan, Jeff
Sent: Wednesday, November 18, 2015 2:45 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D; Yao, Jiewen
Subject: [Patch 2/2] UefiCpuPkg/SmmFeatureLib: Check SmmFeatureControl by
Code_Access_Chk
Bit
and after
gSmmCpuPrivate->SmmCoreEntry(). Just in case, we need some additional action,
we can update PerformPreTasks() and PerformRemainingTasks(), without touch
BSPHandler().
Thank you
Yao Jiewen
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, November 23, 2
Agree. Thanks!
-Original Message-
From: Fan, Jeff
Sent: Tuesday, November 24, 2015 11:33 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Cc: Kinney, Michael D
Subject: RE: [patch] UefiCpuPkg/PiSmmCpu: Eliminate
EFI_IMAGE_MACHINE_TYPE_SUPPORTED(EFI_IMAGE_MACHINE_X64).
This commit title
org
Cc: Kinney, Michael D; Gao, Liming; Yao, Jiewen; Fan, Jeff; Zeng, Star
Subject: [edk2] [patch] EdkCompatibilityPkg/SmmBaseHelper: Install LoadedImage
protocol for ECP SMM driver.
PiSmmCore installs LoadedImage for each SMM driver. However ECP SMM driver is
missing.
Since SmmBaseHelper loads
HI
I just discussed with Star.
We decide to let PiSmmCore install LoadedImage protocol - same way as DxeCore.
If so, we can assign correct FilePath there. Then we do not need update
PiSmmIpl.
I will send another patch. This update can be discard.
-Original Message-
From: Yao, Jiewen
Comments below:
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, November 23, 2015 10:39 PM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Fan, Jeff
Subject: Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move
RestoreSmmConfigurationInS3 from
to allocate normal memory?
See SmmReadyToLockEventNotify() in PiSmmCpuDxeSmm.c.
Thank you
Yao Jiewen
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, November 24, 2015 2:24 PM
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek; Yao, Jiewen; Fan, Jeff
Subject: [PATCH 2/2
Got it. Agree.
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, November 24, 2015 10:47 PM
To: Yao, Jiewen; edk2-devel@lists.01.org; Kinney, Michael D
Cc: Laszlo Ersek; Fan, Jeff
Subject: RE: [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize
ACPI_CPU_DATA for S3
Got it. I will remove the two leading space characters. Thanks!
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, November 24, 2015 6:21 PM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Cc: Fan, Jeff; Kinney, Michael D
Subject: Re: [patch] UefiCpuPkg/PiSmmCpu
records the register info.
Thank you
Yao Jiewen
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, November 24, 2015 10:47 PM
To: Yao, Jiewen; Kinney, Michael D; edk2-devel@lists.01.org
Cc: Fan, Jeff
Subject: Re: [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module
work.
Especially this is library constructor, and ProcessLibraryConstructorList does
not have return status.
So we had better use ASSERT_EFI_ERROR here directly.
Thank you
Yao Jiewen
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> St
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Friday, June 3, 2016 10:09 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen@intel.com>
> Subject: [PATCH 1/2] MdeModulePkg SmmLockBoxSmmLib: Add
> DESTRUCT
Reviewed by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zhang, Chao B
> Sent: Wednesday, June 8, 2016 3:38 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen@intel.com>; Zh
Correct a typo.
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao,
Jiewen
Sent: Wednesday, June 8, 2016 4:41 PM
To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org
Cc: Carsey, Jaben <jaben.car...@intel.com>; Gao, Liming <liming@intel.com>
lem inside of PerformanceLib
and zero-touch on BDS.
Some possible ways below:
1) Extend PEI_PERFORMANCE_LOG_HEADER to include the frequency/start/end
info.
2) Extend Performance Library and Protocol to report the
frequency/start/end info.
I think #1 could be an easy way.
Thank you
1 - 100 of 1198 matches
Mail list logo
