Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-08 Thread Ni, Ruiyu
, Tim -Original Message- From: edk2-devel On Behalf Of Laszlo Ersek Sent: Friday, October 5, 2018 4:33 AM To: Carsey, Jaben ; Andrew Fish Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable On 10/04/18 22:54, Carsey, Jaben wrote: L

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-08 Thread Jim.Dailey
>-Original Message- >From: Ni, Ruiyu [mailto:ruiyu...@intel.com] >Sent: Monday, October 8, 2018 1:42 AM >To: Dailey, Jim; edk2-devel@lists.01.org >Cc: jaben.car...@intel.com >Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment >variable >

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-07 Thread Ni, Ruiyu
On 10/4/2018 12:02 AM, jim.dai...@dell.com wrote: Create a homefilesystem environment variable whose value is the file system on which the executing shell is located. For example: "FS14:". This eliminates the need for people to have to try and find the "boot" file system in their startup script.

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-05 Thread Laszlo Ersek
On 10/05/18 17:00, Carsey, Jaben wrote: > > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Friday, October 05, 2018 4:33 AM >> To: Carsey, Jaben ; Andrew Fish >> >> Cc: edk2-devel@lists.01.org >>

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-05 Thread Carsey, Jaben
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, October 05, 2018 4:33 AM > To: Carsey, Jaben ; Andrew Fish > > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment > var

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-05 Thread Tim Lewis
1.org Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable On 10/04/18 22:54, Carsey, Jaben wrote: > Laszlo, > > The leading "_" was required for out of spec, but built in, commands. The spec has no restrictions on environment variables except some

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-05 Thread Laszlo Ersek
On 10/04/18 22:54, Carsey, Jaben wrote: > Laszlo, > > The leading "_" was required for out of spec, but built in, commands. The > spec has no restrictions on environment variables except some have special > meaning and may be read only. > > I can certainly work on slowing down the process. I

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-04 Thread Carsey, Jaben
half Of > Andrew Fish > Sent: Thursday, October 04, 2018 12:20 PM > To: Laszlo Ersek > Cc: Carsey, Jaben ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment > variable > Importance: High > > > > > On Oct 4, 2018

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-04 Thread Laszlo Ersek
On 10/04/18 21:05, jim.dai...@dell.com wrote: >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek > > I'll attempt answer some of your questions, but Jaben may have to > answer some of them (like his commit speed :-) or questions about what > the shell spec a

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-04 Thread Andrew Fish
t; I think I would have suggested an improvement (or a clarification about) > the commit message. It says: > >>> -Original Message- >>> From: Carsey, Jaben >>> Sent: Wednesday, October 03, 2018 11:15 AM >>> To: 'jim.dai...@dell.com' ; edk2-devel@li

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-04 Thread Jim.Dailey
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek I'll attempt answer some of your questions, but Jaben may have to answer some of them (like his commit speed :-) or questions about what the shell spec allows). > >So my first question would have been, what if

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-04 Thread Laszlo Ersek
t says: >> -Original Message- >> From: Carsey, Jaben >> Sent: Wednesday, October 03, 2018 11:15 AM >> To: 'jim.dai...@dell.com' ; edk2-devel@lists.01.org >> Subject: RE: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment >> variable >>

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-03 Thread Carsey, Jaben
Pushed. c0b1f749ef1304810ed4ea58ded65b7f41d79d3e > -Original Message- > From: Carsey, Jaben > Sent: Wednesday, October 03, 2018 11:15 AM > To: 'jim.dai...@dell.com' ; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH] ShellPkg: Create a homefilesyst

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-03 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: jim.dai...@dell.com [mailto:jim.dai...@dell.com] > Sent: Wednesday, October 03, 2018 9:02 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: [edk2] [PATCH] ShellPkg: Create a homefile

[edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-03 Thread Jim.Dailey
Create a homefilesystem environment variable whose value is the file system on which the executing shell is located. For example: "FS14:". This eliminates the need for people to have to try and find the "boot" file system in their startup script. After this change they can simply execute %homefil