On 9/25/2018 11:13 AM, Zeng, Star wrote:
On 2018/9/25 10:47, Ni, Ruiyu wrote:
But then there will be a little inconsistent, for example OPERATION_TYPE
is only used by PciRootBridgeIo.c.
Since coding style document doesn't define clear rule for this (I also
don't like a coding style document
On 2018/9/25 10:47, Ni, Ruiyu wrote:
On 9/25/2018 10:35 AM, Zeng, Star wrote:
On 2018/9/21 19:12, Laszlo Ersek wrote:
On 09/21/18 09:25, Ruiyu Ni wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
On 9/25/2018 10:35 AM, Zeng, Star wrote:
On 2018/9/21 19:12, Laszlo Ersek wrote:
On 09/21/18 09:25, Ruiyu Ni wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26
On 2018/9/21 19:12, Laszlo Ersek wrote:
On 09/21/18 09:25, Ruiyu Ni wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26 ++
1 file changed, 12 insertions(+), 14
On 9/21/2018 7:12 PM, Laszlo Ersek wrote:
On 09/21/18 09:25, Ruiyu Ni wrote:
Two superficial comments:
- edk2 prefers long parameter names, so I suggest replacing "R" in the
macro definition with "Resource"
- taking the parameter as a pointer is frequently considered more flexible.
#define
3/3] MdeModulePkg/PciHostBridge: Add RESOURCE_VALID() to
simplify code
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26 ++
1 file changed, 12 insertions(+), 14
On 09/21/18 09:25, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni
> Cc: Star Zeng
> ---
> .../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26
> ++
> 1 file changed, 12 insertions(+), 14 deletions(-)
>
> diff --git
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26 ++
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git
8 matches
Mail list logo