Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 01/16/16 15:46, Zeng, Star wrote: > On 2016/1/16 1:39, Laszlo Ersek wrote: >> On 01/15/16 18:33, Ryan Harkin wrote: >>> On 15 January 2016 at 17:05, Laszlo Ersek wrote: Hi, snipping context liberally... > Whilst simple text input seems to work

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

[...] The above analysis is very clear, thanks. I am a little concern about if the code changes below follow the comments in the code. In Terminal.c: // // Set the timeout value of serial buffer for // keystroke response performance issue // In TerminalConIn.c: // //

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 01/18/16 17:17, Brian J. Johnson wrote: > On 01/18/2016 05:55 AM, Laszlo Ersek wrote: >> On 01/18/16 12:41, Ryan Harkin wrote: >>> >On 18 January 2016 at 11:33, Laszlo Ersek wrote: >>On 01/18/16 11:24, Zeng, Star wrote: > >>>[...] > >>> >>> > >>>

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 01/18/16 12:41, Ryan Harkin wrote: > On 18 January 2016 at 11:33, Laszlo Ersek wrote: >> On 01/18/16 11:24, Zeng, Star wrote: >>> [...] >>> > > The above analysis is very clear, thanks. I am a little concern about if > the code changes below follow the comments

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 01/18/16 11:24, Zeng, Star wrote: > [...] > >>> >>> The above analysis is very clear, thanks. I am a little concern about if >>> the code changes below follow the comments in the code. >>> >>> In Terminal.c: >>> // >>> // Set the timeout value of serial buffer for >>> //

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 18 January 2016 at 11:33, Laszlo Ersek wrote: > On 01/18/16 11:24, Zeng, Star wrote: >> [...] >> The above analysis is very clear, thanks. I am a little concern about if the code changes below follow the comments in the code. In Terminal.c:

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 01/18/2016 05:55 AM, Laszlo Ersek wrote: On 01/18/16 12:41, Ryan Harkin wrote: >On 18 January 2016 at 11:33, Laszlo Ersek wrote: >>On 01/18/16 11:24, Zeng, Star wrote: >>>[...] >>> > >The above analysis is very clear, thanks. I am a little concern about if

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 2016/1/18 19:33, Laszlo Ersek wrote: On 01/18/16 11:24, Zeng, Star wrote: [...] The above analysis is very clear, thanks. I am a little concern about if the code changes below follow the comments in the code. In Terminal.c: // // Set the timeout value of serial buffer for

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

[...] The above analysis is very clear, thanks. I am a little concern about if the code changes below follow the comments in the code. In Terminal.c: // // Set the timeout value of serial buffer for // keystroke response performance issue // In TerminalConIn.c: // //

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 2016/1/16 1:39, Laszlo Ersek wrote: On 01/15/16 18:33, Ryan Harkin wrote: On 15 January 2016 at 17:05, Laszlo Ersek wrote: Hi, snipping context liberally... Whilst simple text input seems to work ok, cursor support does not. And we need cursor support for Intel BDS.

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 15 January 2016 at 10:03, Zeng, Star wrote: > On 2016/1/15 16:56, Ryan Harkin wrote: >> >> " >> >> On 15 January 2016 at 08:51, Zeng, Star wrote: >>> >>> On 2016/1/15 16:08, Ryan Harkin wrote: On 15 January 2016 at 06:50, Zeng, Star

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

Hi Star, On Fri, Jan 15, 2016 at 06:03:10PM +0800, Zeng, Star wrote: > >>>git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18378 > >>>6f19259b-4bc3-4df7-8a09-765794883524 > >>> > >>>This is because Intel BDS using cursor keys, ARM BDS does not. > >> > >> > >>Sorry, I am not familiar

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 15 January 2016 at 17:05, Laszlo Ersek wrote: > Hi, > > snipping context liberally... > >> Whilst simple text input seems to work ok, cursor support does not. >> And we need cursor support for Intel BDS. > > (1) I think this is important. See below. > >> When

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 01/15/16 18:33, Ryan Harkin wrote: > On 15 January 2016 at 17:05, Laszlo Ersek wrote: >> Hi, >> >> snipping context liberally... >> >>> Whilst simple text input seems to work ok, cursor support does not. >>> And we need cursor support for Intel BDS. >> >> (1)

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 15 January 2016 at 18:05, Laszlo Ersek wrote: > Hi, > > snipping context liberally... > >> Whilst simple text input seems to work ok, cursor support does not. >> And we need cursor support for Intel BDS. > > (1) I think this is important. See below. > >> When

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 15 January 2016 at 18:32, Laszlo Ersek wrote: > On 01/15/16 18:59, Ryan Harkin wrote: >> On 15 January 2016 at 17:39, Laszlo Ersek wrote: >>> On 01/15/16 18:33, Ryan Harkin wrote: On 15 January 2016 at 17:05, Laszlo Ersek wrote: >

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

> On Jan 15, 2016, at 11:14 AM, Ryan Harkin wrote: > > On 15 January 2016 at 18:32, Laszlo Ersek wrote: >> On 01/15/16 18:59, Ryan Harkin wrote: >>> On 15 January 2016 at 17:39, Laszlo Ersek wrote: On 01/15/16 18:33, Ryan

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 01/15/16 18:59, Ryan Harkin wrote: > On 15 January 2016 at 17:39, Laszlo Ersek wrote: >> On 01/15/16 18:33, Ryan Harkin wrote: >>> On 15 January 2016 at 17:05, Laszlo Ersek wrote: Ryan, can you please test the following patch? > diff --git

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On Fri, Jan 15, 2016 at 06:05:03PM +0100, Laszlo Ersek wrote: > snipping context liberally... Snipping clear and very detailed (and useful) explanation. > (4) My opinion: > > - The new driver's ReceiveFifoDepth setting, on init and on Reset, is > correct. (Conforms to the spec.) > > - The

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 2016/1/15 16:08, Ryan Harkin wrote: On 15 January 2016 at 06:50, Zeng, Star wrote: On 2016/1/15 14:36, Ryan Harkin wrote: On 15 Jan 2016 01:41, "Zeng, Star" wrote: Hi Ryan, On 2016/1/15 3:10, Ryan Harkin wrote: Hi Star, This patch breaks

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

" On 15 January 2016 at 08:51, Zeng, Star wrote: > On 2016/1/15 16:08, Ryan Harkin wrote: >> >> On 15 January 2016 at 06:50, Zeng, Star wrote: >>> >>> On 2016/1/15 14:36, Ryan Harkin wrote: On 15 Jan 2016 01:41, "Zeng, Star"

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 2016/1/15 16:56, Ryan Harkin wrote: " On 15 January 2016 at 08:51, Zeng, Star wrote: On 2016/1/15 16:08, Ryan Harkin wrote: On 15 January 2016 at 06:50, Zeng, Star wrote: On 2016/1/15 14:36, Ryan Harkin wrote: On 15 Jan 2016 01:41, "Zeng,

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

Hi Ryan, On 2016/1/15 3:10, Ryan Harkin wrote: Hi Star, This patch breaks the serial terminal for ARM FVP and Juno platforms. I assume it also breaks TC2 and other such "vexpress" platforms effected by this change. Whilst simple text input seems to work ok, cursor support does not. And we

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

Hi Star, This patch breaks the serial terminal for ARM FVP and Juno platforms. I assume it also breaks TC2 and other such "vexpress" platforms effected by this change. Whilst simple text input seems to work ok, cursor support does not. And we need cursor support for Intel BDS. Below is my hack

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 15 Jan 2016 01:41, "Zeng, Star" wrote: > > Hi Ryan, > > > On 2016/1/15 3:10, Ryan Harkin wrote: >> >> Hi Star, >> >> This patch breaks the serial terminal for ARM FVP and Juno platforms. >> I assume it also breaks TC2 and other such "vexpress" platforms >> effected by this

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 2016/1/15 14:36, Ryan Harkin wrote: On 15 Jan 2016 01:41, "Zeng, Star" wrote: Hi Ryan, On 2016/1/15 3:10, Ryan Harkin wrote: Hi Star, This patch breaks the serial terminal for ARM FVP and Juno platforms. I assume it also breaks TC2 and other such "vexpress"

[edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

It is also to integrate PL011SerialPortExtLib to PL011SerialPortLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution