[edk2] [PATCH] Fix orderedlist grammar inconsistency

2014-07-24 Thread Dong, Eric
This patch fixed this reported issue, also compatible with old format. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.commailto:eric.d...@intel.com Thanks, Eric From: Dong, Eric [mailto:eric.d...@intel.com] Sent: Tuesday, July 22, 2014 8:56 AM

Re: [edk2] [PATCH] OvmfPkg/build.sh: Support IA32+X64 build

2014-07-24 Thread Laszlo Ersek
comments below On 07/23/14 22:04, Jordan Justen wrote: Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- OvmfPkg/build.sh | 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-) diff

Re: [edk2] Strange Issue With PcdGetXX()

2014-07-24 Thread Varad Gautam
On Thu, Jul 24, 2014 at 12:51 AM, Andrew Fish af...@apple.com wrote: What is the value for _PCD_GET_MODE_32_##TokenName in the autogen of the module where the 0 is returned? Is it calling LibPcdGet32() or does it point to the global? _PCD_GET_MODE_32_##TokenName is #defined to the appropriate

[edk2] Bug Report for UEFI Shell

2014-07-24 Thread Jeff Bobzin
Dear Shell Maintainers, We would like you to check this - In file ShellPkg\Library\UefiShellDebug1CommandsLib\Pci.h Order of struct is wrong. Also structure name is misspelled but that is not as critical. Original code below: typedef struct { UINT8 PcieCapId; UINT8

Re: [edk2] UEFI mouse/touchscreen in Hyper-V

2014-07-24 Thread Thomas Rognon
Hyper-V is Microsoft's virtual machine technology. It doesn't have USB pass-through support (the device path for text input is AcpiEx(...)/VenHw(...) with a USB keyboard). So I don't think I can use UsbMouseDxe and I guess Microsoft hasn't made a custom driver for pointer input. On Thu, Jul 24,

[edk2] [PATCH] Update VS2010 and VS2012 RC.exe locations

2014-07-24 Thread Hauch, Larry
CodeModule: BaseTools - tools_def.txt VS2010, VS2010x86, VS2012 and VS2012x86 update locations for rc.exe tool This change will point to the correct location of the rc.exe tool. RC.exe is used for building UEFI compliant drivers that must have a UEFI_HII_RESOURCE_SECTION generated as part of

Re: [edk2] Strange Issue With PcdGetXX()

2014-07-24 Thread Andrew Fish
On Jul 24, 2014, at 6:56 AM, Varad Gautam varadgau...@gmail.com wrote: On Thu, Jul 24, 2014 at 12:51 AM, Andrew Fish af...@apple.com wrote: What is the value for _PCD_GET_MODE_32_##TokenName in the autogen of the module where the 0 is returned? Is it calling LibPcdGet32() or does it point

Re: [edk2] Bug Report for UEFI Shell

2014-07-24 Thread Carsey, Jaben
Jeff, Can you do a contributed-under and signed off by for legal purposes... -Jaben From: Jeff Bobzin [mailto:jeff.bob...@charter.net] Sent: Thursday, July 24, 2014 7:58 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] Bug Report for UEFI Shell Dear Shell Maintainers, We would like you

Re: [edk2] KVM Forum 2014 Call for Participation (reminder)

2014-07-24 Thread Paolo Bonzini
The deadline is coming in three days! Paolo Il 16/06/2014 18:07, Paolo Bonzini ha scritto: = KVM Forum 2014: Call For Participation October 14-16, 2014 - Congress Centre Düsseldorf - Düsseldorf, Germany (All submissions must

Re: [edk2] Strange Issue With PcdGetXX()

2014-07-24 Thread Laszlo Ersek
On 07/24/14 18:20, Andrew Fish wrote: On Jul 24, 2014, at 6:56 AM, Varad Gautam varadgau...@gmail.com mailto:varadgau...@gmail.com wrote: On Thu, Jul 24, 2014 at 12:51 AM, Andrew Fish af...@apple.com mailto:af...@apple.com wrote: What is the value for _PCD_GET_MODE_32_##TokenName in the

Re: [edk2] [edk2-buildtools] Tianocore.org wiki performance issues

2014-07-24 Thread Jarlstrom, Laurie
Another update: Also I have noticed that if you are behind a firewall that the Sourceforge tianocorehttp://tianocore.sourceforge.net/wiki/Welcome wiki is substantially slower. I have had best results with the Firefox browser and with proxy settings as set up to being used behind a fire wall.

Re: [edk2] UEFI mouse/touchscreen in Hyper-V

2014-07-24 Thread Sergey Isakov
Qemu has no pointer as well. Same problem. On 24 июля 2014 г., at 19:05, Thomas Rognon tcrog...@gmail.com wrote: Hyper-V is Microsoft's virtual machine technology. It doesn't have USB pass-through support (the device path for text input is AcpiEx(...)/VenHw(...) with a USB keyboard). So I

Re: [edk2] [PATCH v2 0/2] edksetup.sh: Improvements for out-of-tree BaseTools

2014-07-24 Thread Jordan Justen
On Wed, Jul 23, 2014 at 10:05 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 04/07/2014 10:20, Paolo Bonzini ha scritto: Ok to apply the patches, since they work for all packaging scenarios? Ping? You can add Reviewed-by: Jordan Justen jordan.l.jus...@intel.com to this series, and: BuildEnv:

Re: [edk2] Bug Report for UEFI Shell

2014-07-24 Thread Jeff Bobzin
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Bobzin (jeff.bob...@insyde.com mailto:jeff.bob...@insyde.com ) Original code below: typedef struct { UINT8 PcieCapId; UINT8 NextCapPtr; UINT16 PcieCapReg; UINT32 PcieDeviceCap; UINT16

[edk2] Patch: StdLib/Malloc.c

2014-07-24 Thread Mcdaniel, Daryl
Jaben, Stefan: could you please review the attached change? Both patch format and full file are attached. StdLib/LibC/StdLib/Malloc.c: Revert cast removal to fix GCC build breakage. The cast to (void**) is needed for the last parameter of the AllocatePool call in malloc(). This is because

Re: [edk2] UEFI mouse/touchscreen in Hyper-V

2014-07-24 Thread Kris Harper
Hi, As noticed, there is no mouse support in the Hyper-V UEFI implementation. In generation 2 virtual machines, all the devices are synthetic and need their own drivers. What kind of scenarios are you thinking of for UEFI mouse support in Hyper-V? Thanks, Kris (Hyper-V UEFI developer)

[edk2] MdeModulePkg: Fix parameter verification for SetAttribute

2014-07-24 Thread Carsey, Jaben
Erik Mike, Can you please check this? I found this during debug and I realize that this is not verifying the correct number of bits. I need to get an error when the 8th bit being set. Reference from UEFI 2.4B SetAttribute() API: Attribute The

Re: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute

2014-07-24 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge erik.c.bjo...@intel.com From: Carsey, Jaben Sent: Thursday, July 24, 2014 3:59 PM To: Bjorge, Erik C; Kinney, Michael D Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: MdeModulePkg: Fix parameter verification for SetAttribute Erik Mike, Can you please

Re: [edk2] Patch: StdLib/Malloc.c

2014-07-24 Thread Jordan Justen
Code style suggestion: Status = gBS-AllocatePool( EfiLoaderData, NodeSize, (void**)Head); = Status = gBS-AllocatePool (EfiLoaderData, NodeSize, (void**) Head); Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On 2014-07-24 14:06:52, Mcdaniel, Daryl wrote: Jaben, Stefan: could you please

Re: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute

2014-07-24 Thread Kinney, Michael D
Reviewed-by: Michael Kinney michael.d.kin...@intel.commailto:michael.d.kin...@intel.com From: Bjorge, Erik C Sent: Thursday, July 24, 2014 4:15 PM To: Carsey, Jaben; Kinney, Michael D Cc: edk2-devel@lists.sourceforge.net Subject: RE: MdeModulePkg: Fix parameter verification for SetAttribute

Re: [edk2] UEFI mouse/touchscreen in Hyper-V

2014-07-24 Thread Thomas Rognon
I love Hyper-V because of its deep integration with the hardware, OS, and especially powershell. I test my code in Hyper-V because I've found it to be much faster, safer, and more convenient than testing on a real machine. Some of my products have user interfaces and I would like to test my user

Re: [edk2] [PATCH] OvmfPkg/build.sh: Support IA32+X64 build

2014-07-24 Thread Jordan Justen
Your suggestions seem good. R-b with those changes? On Thu, Jul 24, 2014 at 4:58 AM, Laszlo Ersek ler...@redhat.com wrote: comments below On 07/23/14 22:04, Jordan Justen wrote: Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen jordan.l.jus...@intel.com

Re: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute

2014-07-24 Thread Li, Elvin
Jaben, Your fix is right. I also checked terminal console driver, its SetAttribute has no such problem. Reviewed-by: Elvin Li elvin...@intel.commailto:elvin...@intel.com Thanks Elvin From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, July 25,

[edk2] [PATCH] MdePkg/IndestryStandard/Pci.h: Just fix macro align problems

2014-07-24 Thread Chen Fan
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- MdePkg/Include/IndustryStandard/Pci22.h | 124 MdePkg/Include/IndustryStandard/Pci23.h | 14 ++-- MdePkg/Include/IndustryStandard/Pci30.h | 2 +- 3

Re: [edk2] [PATCH v2 0/2] edksetup.sh: Improvements for out-of-tree BaseTools

2014-07-24 Thread Paolo Bonzini
Il 24/07/2014 21:27, Jordan Justen ha scritto: You can add Reviewed-by: Jordan Justen jordan.l.jus...@intel.com to this series, and: BuildEnv: remove useless check before setting $WORKSPACE Do you have these in a public edk2 repo based on https://github.com/tianocore/edk2? I'm pushing

[edk2-buildtools] [PATCH] Update VS2010 and VS2012 RC.exe locations

2014-07-24 Thread Hauch, Larry
CodeModule: BaseTools - tools_def.txt VS2010, VS2010x86, VS2012 and VS2012x86 update locations for rc.exe tool This change will point to the correct location of the rc.exe tool. RC.exe is used for building UEFI compliant drivers that must have a UEFI_HII_RESOURCE_SECTION generated as part of