Re: [edk2] [PATCH v2] MdeModulePkg Variable: Enhance variable performance by reading from existed memory cache.

2015-10-22 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Lin, Derek (HPS UEFI Dev) Sent: Thursday, October 22, 2015 3:53 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Lin, Derek (HPS UEFI Dev) Subject:

[edk2] [PATCH v2] MdeModulePkg Variable: Enhance variable performance by reading from existed memory cache.

2015-10-22 Thread Derek Lin
Current variable driver already have memory cache to improve performance. Change the code which read from physical MMIO address to read from memory cache. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin --- Changes in v2: - change one

Re: [edk2] [MdeModulePkg] RegularExpressionDxe does not compile with Xcode 6.3.2

2015-10-22 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Thursday, October 22, 2015 10:54 AM To: edk2-devel-01 Subject: [edk2] [MdeModulePkg]

Re: [edk2] [MdeModulePkg] RegularExpressionDxe does not link with Xcode 6.3.2

2015-10-22 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Thursday, October 22, 2015 10:54 AM To: edk2-devel-01 Subject: [edk2] [MdeModulePkg] RegularExpressionDxe

Re: [edk2] [PATCH v3 28/52] OvmfPkg: build PiSmmCpuDxeSmm for -D SMM_REQUIRE

2015-10-22 Thread Laszlo Ersek
On 10/15/15 00:26, Laszlo Ersek wrote: > At this point we can enable building PiSmmCpuDxeSmm. > > The SmmLib dependency is resolved to MdePkg's SmmLibNull instance. First, > this matches the resolution in "UefiCpuPkg/UefiCpuPkg.dsc". Second, from > this library class, PiSmmCpuDxeSmm calls the

Re: [edk2] [PATCH] UefiCpuPkg: PiSmmCpuDxeSmm: Remove unused references to SmmLib

2015-10-22 Thread Laszlo Ersek
Mike, On 10/22/15 01:25, Michael Kinney wrote: > The PiSmmCpuDxeSmm module does not use any services from the SmmLib. > This change removes the SmmLib from PiSmmCpuDxeSmm module and also > removes the lib mapping in the UefiCpuPkg DSC file because no other > modules in the UefiCpuPkg use the

Re: [edk2] style question/Omap3530Gpio

2015-10-22 Thread Leif Lindholm
On Wed, Oct 21, 2015 at 09:03:15AM -0700, Andrew Fish wrote: > > (Sorry about butting in.) > > > > If the "PL061Gpio.h" file comes from a device data sheet, then it > > should go under "ArmPlatformPkg/Include/IndustryStandard". (Or > > maybe "ArmPkg/Include/IndustryStandard".) A few such

Re: [edk2] Configuration Menu

2015-10-22 Thread Dong, Eric
Hi Foster, Do you use goto opcode to create "System Setup" menu? Can you help to attach the source code for your menu? I think it must be some error in the goto opcode caused this issue. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [PATCH] OvmfPkg: increase MP services startup timeout

2015-10-22 Thread Laszlo Ersek
On 10/21/15 21:26, Jordan Justen wrote: > On 2015-10-21 01:44:39, Laszlo Ersek wrote: >> On 10/20/15 22:09, Janusz wrote: >>> W dniu 20.10.2015 o 21:27, Laszlo Ersek pisze: Due to Linux kernel commit b18d5431acc7 ("KVM: x86: fix CR0.CD virtualization"), vCPUs need more time to start up,

Re: [edk2] [PATCH] OvmfPkg: increase MP services startup timeout

2015-10-22 Thread Laszlo Ersek
On 10/22/15 02:12, Fan, Jeff wrote: > Jordan, > > CPU ID only could get the max logical processor number supported in current > socket. It cannot handle multi-sockets case. > > Yes. We could promote PcdCpuMaxLogicalProcessorNumber to dynamic type. But we > need find one reliable way like you

Re: [edk2] [PATCH] MdePkg BaseExtractGuidedSectionLib: R15917 removed useful information wrongly

2015-10-22 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zeng, Star Sent: Friday, October 23, 2015 12:41 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH] MdePkg BaseExtractGuidedSectionLib: R15917 removed useful information wrongly As the title, this patch

Re: [edk2] [MdeModulePkg] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf will not compile with Xcode 6.3.2

2015-10-22 Thread Zeng, Star
On 2015/10/22 23:29, Andrew Fish wrote: On Oct 21, 2015, at 6:34 PM, Zeng, Star wrote: On 2015/10/22 7:02, Andrew Fish wrote: "/usr/bin/clang" -target x86_64-pc-win32-macho -c -g -Os -Wall -Werror -Wextra -include AutoGen.h -funsigned-char -fno-ms-extensions

Re: [edk2] [PATCH v2] MdeModulePkg Variable: Enhance variable performance by reading from existed memory cache.

2015-10-22 Thread Zeng, Star
On 2015/10/22 16:52, Derek Lin wrote: Current variable driver already have memory cache to improve performance. Change the code which read from physical MMIO address to read from memory cache. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin

[edk2] [Patch 1/2] MdeModulePkg: Update BootManagerMenuApp to not display itself

2015-10-22 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jiewen Yao --- .../Application/BootManagerMenuApp/BootManagerMenu.c| 17 +++-- .../BootManagerMenuApp/BootManagerMenuApp.inf | 1 + 2 files

Re: [edk2] [MdeModulePkg] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf will not compile with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
> On Oct 21, 2015, at 6:34 PM, Zeng, Star wrote: > > On 2015/10/22 7:02, Andrew Fish wrote: >> "/usr/bin/clang" -target x86_64-pc-win32-macho -c -g -Os -Wall -Werror >> -Wextra -include AutoGen.h -funsigned-char -fno-ms-extensions >> -fno-stack-protector -fno-builtin

[edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
The -Wempty-body warning for clang does not like an empty for loop that ends in );. Placing the ; in the body of the loop removes the warning. Should we fix the code or suppress the warning in clang. Note: GCC tends to catch up with clang on warnings so we may hit this with other compilers in

[edk2] [MdeModulePkg] RegularExpressionDxe does not link with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
I get linker errors that memcpy does not exist. The memcpy was generated by the compiler is response to a structure assignment with an =. Need to add in CopyMem to fix the issue: diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regcomp.c