Re: [edk2] Using multiple SNP drivers on Shell

2016-04-04 Thread Laszlo Ersek
On 04/04/16 10:44, Bhupesh Sharma wrote: >> From: David Van Arnem >> The ping command allows you to specify the interface you would like to >> use with the -s flag, e.g. >> >> ping -s eth0 192.168.1.1 >> >> or >> >> ping -s eth1 192.168.1.1 >> >> The options for ping can be displayed in the Shell

Re: [edk2] [wave 3 PATCH 00/15] OvmfPkg, ArmVirtPkg: VirtIo 1.0

2016-04-04 Thread Laszlo Ersek
On 03/14/16 13:53, Laszlo Ersek wrote: > This series enables OvmfPkg and ArmVirtPkg to work with non-transitional > VirtIo 1.0 PCI devices. The first 12 patches rework our edk2-only, > private VIRTIO_DEVICE_PROTOCOL (and its two existent implementations), > and adapt the four device drivers we

Re: [edk2] Using multiple SNP drivers on Shell

2016-04-04 Thread Bhupesh Sharma
> From: David Van Arnem > Sent: Friday, April 01, 2016 11:53 PM > On 04/01/2016 06:48 AM, Bhupesh Sharma wrote: > > Hello, > > > > Any suggestions for this issue? Is this a known issue? > > > > Hi Bhupesh, > > The ping command allows you to specify the interface you would like to > use with

Re: [edk2] [Patch 1/2] MdeModulePkg: Check received packet size before use it.

2016-04-04 Thread Laszlo Ersek
On 04/04/16 06:06, Subramanian, Sriram (EG Servers Platform SW) wrote: >> (By the way, the register dump seems to be consistent >> with RxToken->CallBack() freeing the packet. Namely, >> in the disassembly, we can see that %rax is being >> dereferenced, and the value of %rax is AFAFAFAFAFAFAFAF

[edk2] [PATCH v1 0/2] Rename and update HttpGenRequestString API

2016-04-04 Thread Nagaraj Hegde
This patch series updates the message creation logic for the API HttpGenRequestString in DxeHttpLib and also updates the name of the API to avoid confusion. Following the update to API are the changes to the callers. Nagaraj Hegde (2): MdeModulePkg:DxeHttpLib: Update to DxeHttpLib API

[edk2] [PATCH v1 2/2] NetworkPkg:HttpDxe:Consume DxeHttpLib API changes

2016-04-04 Thread Nagaraj Hegde
HttpGenRequestString is updated to HttpGenRequestMessage, with an additional argument. This patch updates the caller of the DxeHttpLib API. Also, we will avoid adding any '\0' to the string, which was added to make AsciiStrLen to work on the string. Contributed-under: TianoCore Contribution

[edk2] [PATCH v1 1/2] MdeModulePkg:DxeHttpLib: Update to DxeHttpLib API

2016-04-04 Thread Nagaraj Hegde
Rename and update the logic of HttpGenRequestString API provided by DxeHttpLib. The RequestString size is returned as an argument. The user is not expected to do a AsciiStrLen anymore, and is not logical too, since request string can contain message body and using AsciiStrLen on such a string can

Re: [edk2] [PATCH] MdeModulePkg: DxeUdpIoLib: fix non-empty payload path in UDP reception

2016-04-04 Thread Laszlo Ersek
On 04/04/16 05:45, Subramanian, Sriram (EG Servers Platform SW) wrote: > Thanks for testing that, Laszlo. > > Reviewed-by: Sriram Subramanian Thanks a lot for the quick review! Since this bug makes OVMF more or less unusable, I pushed the patch (which is also very simple)

Re: [edk2] [PATCH v1 0/2] Rename and update HttpGenRequestString API

2016-04-04 Thread El-Haj-Mahmoud, Samer
Series reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hegde, Nagaraj P Sent: Monday, April 4, 2016 4:51 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 0/2] Rename and update

Re: [edk2] [Patch] BaseTools/GenFds: Fix the bug for wrong alignment generate for RAW file

2016-04-04 Thread Gao, Liming
Signed-off-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Friday, April 01, 2016 3:22 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools/GenFds: Fix the bug for

Re: [edk2] [PATCH] MdeModulePkg: DxeUdpIoLib: fix non-empty payload path in UDP reception

2016-04-04 Thread Fu, Siyuan
Laszlo, Thanks for the quick fix. Siyuan From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, April 4, 2016 7:56 PM To: Subramanian, Sriram (EG Servers Platform SW) Cc: edk2-devel-01 ; Fu, Siyuan ; Wu, Jiaxin

Re: [edk2] How to initiate a PXE boot from the UEFI shell

2016-04-04 Thread Mahan, Patrick
Just wanted to update the list that I managed to do a PXE boot from the EFI Shell using the MdeModulePkg Application BootManagerMenuApp. It required some defensive code in my drivers Start() routine and loading the driver in the shell but *not* connecting it. The downside is that it trashes

[edk2] [Patch] BaseTools: Enhance --Pcd which override by build option

2016-04-04 Thread Yonghong Zhu
This patch 1) enhance the help info for --pcd to use " but not '. 2) Add the condition statements for build option Pcd type check. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 ++

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-04-04 Thread Dong, Eric
> -Original Message- > From: Michael Brown [mailto:mc...@ipxe.org] > Sent: Saturday, April 02, 2016 12:50 AM > To: Laszlo Ersek; Dong, Eric; Bi, Dandan > Cc: Justen, Jordan L; edk2-devel-01; Ard Biesheuvel > Subject: Re: [edk2] HII incompatibility between edk2 and iPXE? > > On 31/03/16

Re: [edk2] [PATCHv2 0/2] Bds: Correct the total RAM calculation

2016-04-04 Thread Zeng, Star
On 2016/4/2 5:53, Jeremy Linton wrote: v2: This version updates the ram shift constants with RShiftU64. it also applies similar changes to the MdeModulePkg/UiApp which has a duplicate version of the UpdateFrontPageStrings function with some additional checks/error handling. In the latter case

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Tian, Feng
No, your SD/MMC host controller driver doesn't need be at PCI bus. You just need write a such h/c driver to produce EfiSdMmcPassThruProtocol interface. EmmcDxe/SdDxe is a common driver to consume EfiSdMmcPassThruProtocol interface to produce BlockIo interface, it's generic for SD/MMC device.

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Tian, Feng
Hi, HaoJian We newly added EDKII SD/MMC stack to EDKII repo. If the SD/MMC host controller follows SD PCI host controller spec, the whole stack should work. But looks like PL180 doesn't follow the SD PCI host controller spec, you would have to add a new SD host controller driver to produce

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Haojian Zhuang
On 5 April 2016 at 02:54, Ard Biesheuvel wrote: > On 4 April 2016 at 19:17, Ryan Harkin wrote: >> Hi Haojian, >> >> I've had time to investigate where TC2 is hanging with your patches >> applied and narrowed it down to the single line of code

[edk2] [Patch] SecurityPkg OpalPasswordDxe: Enhance code to make it more safely.

2016-04-04 Thread Eric Dong
Patched fixed some small issue for this library: 1. Remove the hard code debug build option in inf. 2. Check the pointer before use it to make code more safely. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Feng Tian

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Haojian Zhuang
On 5 April 2016 at 11:25, Tian, Feng wrote: > Hi, HaoJian > > We newly added EDKII SD/MMC stack to EDKII repo. If the SD/MMC host > controller follows SD PCI host controller spec, the whole stack should work. > > But looks like PL180 doesn't follow the SD PCI host controller

Re: [edk2] [Patch v3 1/3] MdeModulePkg/Bds: Allocate reserved memory for RAM Disk boot media

2016-04-04 Thread Ni, Ruiyu
Sunny, Thanks for your comments. ZeroMem I think is very useful to initialize a structure where the default value of many fields are 0. But in such case, ZeroMem() is not optimal because only when code contains bug the ZeroMem() is useful. Otherwise, it costs time to zero the memory. For a RAM

Re: [edk2] [Patch] BaseTools: cache the defined Guid tool to improve the performance

2016-04-04 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, March 29, 2016 1:38 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: cache the defined Guid

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Ryan Harkin
Hi Haojian, I've had time to investigate where TC2 is hanging with your patches applied and narrowed it down to the single line of code marked below. I'm going to read the code now and see if I can work out what it's trying to do, but I thought I'd tell you sooner because you might have a better

Re: [edk2] Using multiple SNP drivers on Shell

2016-04-04 Thread Laszlo Ersek
On 04/04/16 19:38, Bhupesh Sharma wrote: >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Monday, April 04, 2016 11:06 PM >> >> On 04/04/16 19:24, David Van Arnem wrote: >>> On 04/04/2016 03:17 AM, Laszlo Ersek wrote: >> The most recent version (that I have) of the Shell Spec is 2.2.

Re: [edk2] Using multiple SNP drivers on Shell

2016-04-04 Thread Carsey, Jaben
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Monday, April 04, 2016 10:47 AM > To: Bhupesh Sharma > Cc: edk2-devel@lists.01.org ; David Van Arnem >

Re: [edk2] Using multiple SNP drivers on Shell

2016-04-04 Thread Laszlo Ersek
On 04/04/16 19:24, David Van Arnem wrote: > On 04/04/2016 03:17 AM, Laszlo Ersek wrote: >> The most recent version (that I have) of the Shell Spec is 2.2. That >> version lists both "ping" and "ping6", and the synopsis for "ping" is: >> >>Ping [-n count] [-l size] [-s SourceIp] TargetIp > >

Re: [edk2] Using multiple SNP drivers on Shell

2016-04-04 Thread David Van Arnem
On 04/04/2016 03:17 AM, Laszlo Ersek wrote: On 04/04/16 10:44, Bhupesh Sharma wrote: From: David Van Arnem The ping command allows you to specify the interface you would like to use with the -s flag, e.g. ping -s eth0 192.168.1.1 or ping -s eth1 192.168.1.1 The options for ping can be

Re: [edk2] Using multiple SNP drivers on Shell

2016-04-04 Thread Bhupesh Sharma
> From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, April 04, 2016 11:06 PM > > On 04/04/16 19:24, David Van Arnem wrote: > > On 04/04/2016 03:17 AM, Laszlo Ersek wrote: > > >> The most recent version (that I have) of the Shell Spec is 2.2. That > >> version lists both "ping" and

Re: [edk2] [PATCH 00/62] Add FatPkg with 2-clause BSD license

2016-04-04 Thread Leif Lindholm
Hi Laszlo, Sorry for the delay - just back from 2 weeks of relaxing holiday. On 31/03/16 19:47, Laszlo Ersek wrote: > On 03/30/16 03:10, Jordan Justen wrote: >> I don't think sending all 62 patches will be useful (but, I can easily >> send them out if requested). Instead, the patches are

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: API BmIsValidLoadOptionVariableName

2016-04-04 Thread Thomas Palmer
Redfine the BmIsValidLoadOptionVariableName function to allow public use. Change name to EfiBootManagerIsValidLoadOptionVariableName to match naming scheme. Check that VariableName is never NULL and allow OptionType and OptionNumber to be optional. Contributed-under: TianoCore Contribution

Re: [edk2] Using multiple SNP drivers on Shell

2016-04-04 Thread David Van Arnem
On 04/04/2016 11:58 AM, Carsey, Jaben wrote: -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Monday, April 04, 2016 10:47 AM To: Bhupesh Sharma Cc: edk2-devel@lists.01.org ;

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Ard Biesheuvel
On 4 April 2016 at 19:17, Ryan Harkin wrote: > Hi Haojian, > > I've had time to investigate where TC2 is hanging with your patches > applied and narrowed it down to the single line of code marked below. > > I'm going to read the code now and see if I can work out what it's