Re: [edk2] [RESEND PATCH 1/1] ArmPlatformPkg/ArmTrustZone: Add support for specifying Subregions to be disabled

Hi Leif, Thanks for the review. Please see my replies in-line. > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, October 17, 2016 6:55 PM > > On Mon, Oct 17, 2016 at 10:18:01AM +, Bhupesh Sharma wrote: > > Hi Ard, Leif, > > > > Any comments on this patch ? > > You

[edk2] [PATCH] BaseTools/Genfds: Fix Guid.xref missing GUIDs defined in Library.

The original Guid.xref lost some Guid which only defined in Library. When the library is used by a driver, its Guids were not listed in Guid.xref. Now they will. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin ---

Re: [edk2] [RESEND PATCH 1/1] ArmPlatformPkg/ArmTrustZone: Add support for specifying Subregions to be disabled

Hi Ard, > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, October 17, 2016 7:46 PM > > On 17 October 2016 at 14:25, Leif Lindholm > wrote: > > On Mon, Oct 17, 2016 at 10:18:01AM +, Bhupesh Sharma wrote: > >> Hi Ard, Leif, > >> > >> Any

Re: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

Hi Andrew, We also see this issue recently. And we have a fix. I've send email patch minutes ago. Thanks, Derek From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Thursday, October 27, 2016 9:08 AM To: edk2-devel Subject: [edk2]

Re: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

Andrew, The ModuleGuidDict was not for performance, it's because Arch IA32 X64 have same library name/FILE_GUID pair, for not duplicate it. You are right the patch add library FILE_GUID but they are not end up in the ROM, I'm ok remove it or not. Feel free to update the patch. Thanks, Derek

Re: [edk2] [PATCH 2/3] MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion

Mike, You are right, the VS2015x64 IA32 build would fail. With your fix, the code could pass build. If there is no objection, I will help to push this fix tomorrow after adding EDKII commit log with your Sign-off and my Review-by. Thanks Feng -Original Message- From: Kinney, Michael

Re: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

> On Oct 26, 2016, at 9:09 PM, Lin, Derek (HPS UEFI Dev) > wrote: > > Hi Andrew, > > We also see this issue recently. And we have a fix. I've send email patch > minutes ago. > Derek, Thanks for sharing the fix. I noticed it introduced a build failure for a badly

Re: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

I agree with Andrew to only add the missing Ppi/Protocol/Guid used in Library INF file. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Lin, > Derek (HPS UEFI Dev) > Sent: Thursday, October 27, 2016 1:50 PM > To: af...@apple.com > Cc:

Re: [edk2] [PATCH v4 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

On 22 April 2016 at 17:17, G Gregory wrote: > On 22 April 2016 at 15:26, Leif Lindholm wrote: >> On Wed, Apr 20, 2016 at 06:35:06PM +0100, Sudeep Holla wrote: >>> XPress-RICH3 PCIe driver initializes the root complex with the source >>> and

Re: [edk2] [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements

On 10/18/2016 10:34 AM, Brian J. Johnson wrote: On 10/14/2016 03:37 PM, Laszlo Ersek wrote: On 10/14/16 21:39, Brian J. Johnson wrote: On 10/12/2016 03:17 AM, Ryan Harkin wrote: On 7 October 2016 at 16:59, Leif Lindholm wrote: Roy can now be found at Roy Franz

Re: [edk2] Force reconnect children from within a DXE driver

Hi Laszlo, Thank you for your help. It worked finally worked. Best regards, Marcin 2016-10-17 19:00 GMT+02:00 Laszlo Ersek : > On 10/17/16 18:05, Marcin Wojtas wrote: >> Hi, >> >> Short introduction to the problem I'm facing with EDK2: I implemented >> 'ifconfig' command

Re: [edk2] [PATCH V4 08/15] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

Jiewen, I have looked Microsoft UX capsule in the Microsoft Windows UEFI Firmware Update Platform Specification, and that specification only defines support for an ImageType value of 0, which is bitmap format based on ACPI 5.0 BGRT. There are no defined ImageType values for BMP. I recommend

Re: [edk2] [PATCH 13/47] EdkCompatibilityPkg/Sample/Tools: rebase to ARRAY_SIZE()

Reviewed-by: Liming Gao -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, October 27, 2016 3:05 AM To: edk2-devel-01 Cc: Gao, Liming Subject: [PATCH 13/47]

Re: [edk2] [PATCH 12/47] EdkCompatibilityPkg/FrameworkHiiOnUefiHiiThunk: rebase to ARRAY_SIZE()

Reviewed-by: Liming Gao -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, October 27, 2016 3:04 AM To: edk2-devel-01 Cc: Gao, Liming Subject: [PATCH 12/47]

Re: [edk2] [PATCH 34/47] NetworkPkg/TcpDxe: rebase to ARRAY_SIZE()

Reviewed-by: Fu Siyuan siyuan...@intel.com > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 27, 2016 3:05 AM > To: edk2-devel-01 > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject:

Re: [edk2] [PATCH 33/47] NetworkPkg/IScsiDxe: rebase to ARRAY_SIZE()

Reviewed-by: Fu Siyuan siyuan...@intel.com > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 27, 2016 3:05 AM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject:

Re: [edk2] [PATCH 07/47] NetworkPkg/IpsecConfig: remove module-local ARRAY_SIZE macro

Reviewed-by: Fu Siyuan siyuan...@intel.com > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 27, 2016 3:04 AM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject:

Re: [edk2] [PATCH 02/47] NetworkPkg/IpsecConfig: guard the definition of ARRAY_SIZE

Reviewed-by: Fu Siyuan siyuan...@intel.com > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 27, 2016 3:04 AM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject:

Re: [edk2] [PATCH V4 6/8] QuarkPlatformPkg/PlatformBootManager: Add capsule/recovery handling.

Jiewen, Thanks. That makes sense. Let's make sure the array is handled correctly in this platform specific solution and the new tool feature. Mike From: Yao, Jiewen Sent: Wednesday, October 26, 2016 6:48 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Tian,

Re: [edk2] [PATCH 16/47] IntelFrameworkModulePkg/BdsDxe: rebase to ARRAY_SIZE()

Reviewed-by: Jeff Fan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, October 27, 2016 3:05 AM To: edk2-devel-01 Cc: Fan, Jeff Subject: [PATCH 16/47] IntelFrameworkModulePkg/BdsDxe: rebase to ARRAY_SIZE() Cc: Jeff Fan

Re: [edk2] [PATCH V4 03/10] Vlv2TbltDevicePkg/SystemFirmwareDescriptor: Add Descriptor for capsule update.

Jiewen, Why is .aslc file used in this PEIM. It is not an ACPI table. You are generating a C structure that is used to set the value of a PCD. The C structure could be a global variable in the PEIM that is initialized the same way the .aslc file does or you could initialize the fields in the

Re: [edk2] [PATCH V4 03/10] Vlv2TbltDevicePkg/SystemFirmwareDescriptor: Add Descriptor for capsule update.

Mike That is a good question. We create a standalone FFS SECTION to hold the descriptor purposely. The reason is that: the SystemFirmwareUpdate need to know the version of the *new image*. SystemFirmwareUpdate can know the version and lowest supported version of the current image by using

Re: [edk2] [PATCH V4 06/15] MdeModulePkg/DxeCapsuleLibFmp: Add DxeCapsuleLibFmp instance.

Hi Mike I think that is misunderstanding. Chao did test before and the UX capsule from Windows does contain a BMP file. He told me that I should use BMP file. I will let Chao to clarify more. I also include Sean Brogan to double check the Windows side. Thank you Yao Jiewen From: Kinney,

Re: [edk2] [PATCH 05/47] MdePkg/Include/Base.h: introduce the ARRAY_SIZE() function-like macro

With that change: Reviewed-by: Michael Kinney Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, October 26, 2016 3:26 PM > To: Kinney, Michael D ; edk2-devel-01 de...@ml01.01.org> > Cc:

Re: [edk2] [PATCH 22/47] MdeModulePkg/Core/PiSmmCore: rebase to ARRAY_SIZE()

Reviewed-by: Michael Kinney > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, October 26, 2016 12:05 PM > To: edk2-devel-01 > Cc: Tian, Feng ; Kinney, Michael D >

Re: [edk2] [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements

Sorry for missing this patch. Reviewed-by: Feng Tian I will help push it in. Thanks Feng -Original Message- From: Brian J. Johnson [mailto:bjohn...@sgi.com] Sent: Wednesday, October 26, 2016 11:00 PM To: Tian, Feng ; Zeng, Star

[edk2] [Patch 1/3] MdeModulePkg: Update NetLib interface to support classless addressing.

The classful addressing (IP class A/B/C) has been deprecated according to RFC4632. This patch updates the NetLib NetGetIpClass() and NetIp4IsUnicast() accordingly. NetGetIpClass() The function is kept for compatibility, while the caller of this function could only check the returned value against

[edk2] [Patch 2/3] MdeModulePkg: Update IP4 stack drivers for classless address unicast check.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Ye Ting Cc: Zhang Lubo Cc: Wu Jiaxin --- MdeModulePkg/Include/Library/IpIoLib.h | 4 ++-

Re: [edk2] [PATCH 41/47] ShellPkg/UefiDpLib: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Carsey, Jaben ; Ni, Ruiyu >Subject: [PATCH

Re: [edk2] [PATCH V4 3/8] QuarkPlatformPkg/SystemFirmwareDescriptor: Add Descriptor for capsule update.

Jiewen, Why is .aslc file used in this PEIM. It is not an ACPI table. You are generating a C structure that is used to set the value of a PCD. The C structure could be a global variable in the PEIM that is initialized the same way the .aslc file does or you could initialize the fields in the

Re: [edk2] [PATCH] CorebootPayloadPkg: Make EFI shell the last boot option.

Reviewed-by: Maurice Ma -Original Message- From: Dong, Guo Sent: Wednesday, October 26, 2016 5:51 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo Subject: [edk2] [PATCH] CorebootPayloadPkg: Make EFI shell the last boot option. To let it

Re: [edk2] [PATCH 2/3] MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion

Tian Feng, Unfortunately, this patch that was pushed to edk2/master today breaks on IA32 VS2015x86 builds with a signed/unsigned mismatch on 3 lines. I think the right fix might be: diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c

Re: [edk2] [PATCH 15/47] IntelFrameworkModulePkg/LegacyBootManagerLib: rebase to ARRAY_SIZE()

Reviewed-by: Jeff Fan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, October 27, 2016 3:05 AM To: edk2-devel-01 Cc: Fan, Jeff Subject: [PATCH 15/47] IntelFrameworkModulePkg/LegacyBootManagerLib: rebase to ARRAY_SIZE() Cc: Jeff Fan

Re: [edk2] [PATCH V4 06/10] Vlv2TbltDevicePkg/PlatformBootManager: Add capsule/recovery handling.

Jiewen, See feedback for QuarkPlatformPkg/PlatformBootManager. The same feedback applies. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen > Yao > Sent: Saturday, October 22, 2016 7:33 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH V4 6/8] QuarkPlatformPkg/PlatformBootManager: Add capsule/recovery handling.

Jiewen, Can the code that checks for the use of a test key be moved into a common BDS lib or module? Maybe in MdeModulePkg\Universal\BdsDxe\BdsEntry.c right before the call to PlatformBootManagerAfterConsole()? The logic in BdsEntry.c can do the check and set the PcdTestKeyUsed PCD and can go

Re: [edk2] [PATCH V4 03/10] Vlv2TbltDevicePkg/SystemFirmwareDescriptor: Add Descriptor for capsule update.

Good question again. That is because the platform PEI phase does not report all FV information to DXE. I did use this way in my early version. I give up later, because I realize if so we need update all platforms to let it report all FV information. It is a burden. Using PCD is a standalone

Re: [edk2] [PATCH V4 1/8] QuarkPlatformPkg/dec: Add test key file guid.

Jiewen, Why are these 2 PCDs added to a platform specific DEC file? The same feedback applies to the Vlv2 platform. Since we want platform agnostic detection for the use of test keys, these PCDs should be added to SignedCapsulePkg. I think the best place to do the check for use of test keys

Re: [edk2] [PATCH 25/47] MdeModulePkg/UefiBootManagerLib: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,

Re: [edk2] [PATCH 28/47] MdeModulePkg/BdsDxe: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,

Re: [edk2] [PATCH 28/47] MdeModulePkg/BdsDxe: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,

Re: [edk2] [PATCH V4 6/8] QuarkPlatformPkg/PlatformBootManager: Add capsule/recovery handling.

Yes, Mike. You are right. We do have plan to make it generic. As we discussed before, we will enhance the tool to detect such info and set a PCD at build time. Then we can include that in the UiApp driver to report such error directly. The tool is not ready yet. So current platform solution is

Re: [edk2] [PATCH 36/47] OptionRomPkg/AtapiPassThruDxe: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Ni, Ruiyu >Subject: [PATCH 36/47] OptionRomPkg/AtapiPassThruDxe:

Re: [edk2] [PATCH 42/47] ShellPkg/UefiShellLevel2CommandsLib: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Carsey, Jaben ; Ni, Ruiyu >Subject: [PATCH

Re: [edk2] [PATCH 35/47] Nt32Pkg/WinNtSerialIoDxe: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Ni, Ruiyu >Subject: [PATCH 35/47]

Re: [edk2] [PATCH 19/47] MdeModulePkg/PciHostBridgeDxe: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,

Re: [edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

Guo, I think it is better to add "EFIAPI" to force the calling convention. Thanks Maurice -Original Message- From: Dong, Guo Sent: Wednesday, October 26, 2016 5:35 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo Subject: [edk2] [PATCH] CorebootModulePkgPkg:

Re: [edk2] [PATCH V4 7/8] QuarkPlatformPkg/dsc/fdf: Add capsule/recovery support.

Jiewen, A couple comments inline below. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen > Yao > Sent: Saturday, October 22, 2016 7:32 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Gao, Liming

[edk2] [PATCH] CorebootPayloadPkg: Make EFI shell the last boot option.

To let it boot to OS automatically, make built in shell as the last boot option. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong Reviewed-by: Maurice Ma --- .../Library/PlatformBootManagerLib/PlatformBootManager.c

Re: [edk2] [PATCH 14/47] FatPkg/EnhancedFatDxe: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Ni, Ruiyu >Subject: [PATCH 14/47]

Re: [edk2] [PATCH 27/47] MdeModulePkg/Logo: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,

Re: [edk2] [PATCH 18/47] MdeModulePkg/PciBusDxe: rebase to ARRAY_SIZE()

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, October 27, 2016 3:05 AM >To: edk2-devel-01 >Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,

Re: [edk2] [PATCH] CorebootPayloadPkg: Add "Down" key to Boot Manager Menu

Reviewed-by: Maurice Ma -Original Message- From: Dong, Guo Sent: Wednesday, October 26, 2016 5:45 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo Subject: [edk2] [PATCH] CorebootPayloadPkg: Add "Down" key to Boot Manager Menu Also add

Re: [edk2] [Patch] MdePkg/PciSegmentLib: Optimize PCI_SEGMENT_LIB_ADDRESS()

Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Thursday, October 27, 2016 5:18 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] MdePkg/PciSegmentLib: Optimize > PCI_SEGMENT_LIB_ADDRESS() >

Re: [edk2] [PATCH 04/47] OvmfPkg/XenBusDxe: guard the definition of ARRAY_SIZE

On Wed, Oct 26, 2016 at 09:04:21PM +0200, Laszlo Ersek wrote: > In one of the next patches, we'll introduce ARRAY_SIZE in > "MdePkg/Include/Base.h". In order to proceed in small steps, make the > module-local definition of ARRAY_SIZE conditional. This way the > introduction of the macro under

Re: [edk2] [PATCH 09/47] OvmfPkg/XenBusDxe: remove module-local ARRAY_SIZE macro

On Wed, Oct 26, 2016 at 09:04:26PM +0200, Laszlo Ersek wrote: > Rely on the central macro definition from "MdePkg/Include/Base.h" instead. > Reviewed-by: Gary Lin > Cc: Gary Lin > Cc: Jordan Justen > Contributed-under: TianoCore

Re: [edk2] [PATCH V4 06/15] MdeModulePkg/DxeCapsuleLibFmp: Add DxeCapsuleLibFmp instance.

Jiewen, I have looked Microsoft UX capsule in the Microsoft Windows UEFI Firmware Update Platform Specification, and that specification only define support for an ImageType value of 0, which is bitmap format based on ACPI 5.0 BGRT. There are no defined ImageType values for BMP. We need to

Re: [edk2] [PATCH] CorebootModulePkg: Fix memmap issue

Reviewed-by: Maurice Ma -Original Message- From: Dong, Guo Sent: Tuesday, October 18, 2016 12:11 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo Subject: [edk2] [PATCH] CorebootModulePkg: Fix memmap issue Some reserved memory (e.g. CSE

Re: [edk2] [PATCH 00/47] edk2: centralize and adopt ARRAY_SIZE()

MdeModulePkg reviewed-by: Feng Tian Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, October 27, 2016 3:04 AM To: edk2-devel-01 Cc: Ard Biesheuvel ; Cecil Sheng

Re: [edk2] [PATCH 00/47] edk2: centralize and adopt ARRAY_SIZE()

Reviewed-by: Star Zeng to MdeModulePkg changes. Thanks, Star -Original Message- From: Tian, Feng Sent: Thursday, October 27, 2016 9:17 AM To: Laszlo Ersek ; edk2-devel-01 Cc: Ard Biesheuvel ;

Re: [edk2] [PATCH 07/47] NetworkPkg/IpsecConfig: remove module-local ARRAY_SIZE macro

Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 27, 2016 3:04 AM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Fu, Siyuan

Re: [edk2] [PATCH 34/47] NetworkPkg/TcpDxe: rebase to ARRAY_SIZE()

Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 27, 2016 3:05 AM > To: edk2-devel-01 > Cc: Fu, Siyuan ; Wu, Jiaxin

[edk2] [PATCH] CorebootPayloadPkg: Add "Down" key to Boot Manager Menu

Also add Down key to Boot Manager Menu since some serial terminals don't support F2 key. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong Reviewed-by: Maurice Ma ---

Re: [edk2] [PATCH V4 03/10] Vlv2TbltDevicePkg/SystemFirmwareDescriptor: Add Descriptor for capsule update.

Jiewen, They why do we need the PCD? We should be able to find this section in current FLASH image and in new FLASH image. Right? Mike From: Yao, Jiewen Sent: Wednesday, October 26, 2016 6:15 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Tian, Feng

Re: [edk2] [Patch] PcAtChipsetPkg/HpetTimerDxe: Fix race condition in SetTimerPeriod()

Reviewed-by: Ruiyu Ni >-Original Message- >From: Kinney, Michael D >Sent: Thursday, October 27, 2016 6:31 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [Patch] PcAtChipsetPkg/HpetTimerDxe: Fix race condition in >SetTimerPeriod() >

Re: [edk2] [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

Hi Laszlo, I investigated the QuarkSocPkg ones. The extra #include of BaseType.h should be removed from: QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c However, it should not be removed from the other one: QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c The

[edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

CbPlatformSupportLib might use FindCbTag() API to parse platform specific information. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong Reviewed-by: Maurice Ma --- CorebootModulePkg/Include/Library/CbParseLib.h | 19

[edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

I noticed if a GUID (PPI & Protocol) was only used via a library it does not end up in the Guid.xref file. It looks to me like this code is only extracting the GUIDs from the Drivers INF file and the GUIDs defined in dependent libraries are skipped?

Re: [edk2] [PATCH V4 7/8] QuarkPlatformPkg/dsc/fdf: Add capsule/recovery support.

Agree and updated. From: Kinney, Michael D Sent: Thursday, October 27, 2016 8:41 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Tian, Feng ; Gao, Liming ; Zeng, Star

Re: [edk2] [PATCH 29/33] SecurityPkg: Fix typos in comments

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, October 19, 2016 3:02 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [PATCH 29/33] SecurityPkg: Fix typos in

Re: [edk2] [PATCH V4 1/8] QuarkPlatformPkg/dec: Add test key file guid.

Agree. I will move the 2 PCD to SignedCapsulePkg. From: Kinney, Michael D Sent: Thursday, October 27, 2016 9:28 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Tian, Feng ; Gao, Liming

Re: [edk2] [PATCH 02/47] NetworkPkg/IpsecConfig: guard the definition of ARRAY_SIZE

Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 27, 2016 3:04 AM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Fu, Siyuan

Re: [edk2] [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments

Reviewed-by: Maurice Ma -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, October 19, 2016 12:01 AM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince Subject: [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments - dirver ->

Re: [edk2] Force reconnect children from within a DXE driver

On 10/26/16 18:02, Marcin Wojtas wrote: > Hi Laszlo, > > Thank you for your help. It worked finally worked. Thanks for the feedback! :) Laszlo > 2016-10-17 19:00 GMT+02:00 Laszlo Ersek : >> On 10/17/16 18:05, Marcin Wojtas wrote: >>> Hi, >>> >>> Short introduction to the

Re: [edk2] [PATCH] ArmPlatformPkg: remove ARM BDS

On 26 October 2016 at 13:33, Ryan Harkin wrote: > On 25 October 2016 at 18:16, Ard Biesheuvel wrote: >> This is no longer used, and does not belong in a reference code base, >> so remove it. >> >> Contributed-under: TianoCore Contribution

[edk2] [PATCH] CorebootPayloadPkg: Switch to use StatusCode drvier in MdeModulePkg

The current CorebootPayloadPkg uses PEI/DXE StatusCode drivers from IntelFrameworkModulePkg. This patch switches to use the StatusCode driver from MdeModulePkg instead. Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Maurice Ma

[edk2] [PATCH] CorebootPayloadPkg DSC: Change the section alignment option

The current CorebootPayloadPkg will print the following message "InsertImageRecord - Section Alignment(0x20) is not 4K" during boot. It is caused by the section alignment arranged by the linker. This patch change the alignment to 4K for runtime drivers. Cc: Prince Agyeman

Re: [edk2] [PATCH 04/33] CorebootModulePkg: Fix typos in comments

Reviewed-by: Maurice Ma -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, October 19, 2016 12:01 AM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince Subject: [PATCH 04/33] CorebootModulePkg: Fix typos in comments - inforamtion

[edk2] [PATCH 01/47] MdeModulePkg/RegularExpressionDxe: guard the definition of ARRAY_SIZE

In one of the next patches, we'll introduce ARRAY_SIZE in "MdePkg/Include/Base.h". In order to proceed in small steps, make the module-local definition of ARRAY_SIZE conditional. This way the introduction of the macro under MdePkg will silently switch this module over (after which we can remove

[edk2] [PATCH 00/47] edk2: centralize and adopt ARRAY_SIZE()

I'm sure most of us have wished at some point that ARRAY_SIZE() had existed in a central header file, like it does in many other open source projects. This series implements that. Patches 01-04 round up the modules that #define ARRAY_SIZE() just for themselves, and wrap their definitions in

[edk2] [PATCH 03/47] OvmfPkg/PlatformBootManagerLib: guard the definition of ARRAY_SIZE

In one of the next patches, we'll introduce ARRAY_SIZE in "MdePkg/Include/Base.h". In order to proceed in small steps, make the module-local definition of ARRAY_SIZE conditional. This way the introduction of the macro under MdePkg will silently switch this module over (after which we can remove

Re: [edk2] [PATCH] CorebootPayloadPkg: Notify EndOfDxe and install ReadyToLock protocol.

This patch looks good to me. Reviewed-by: Maurice Ma -Original Message- From: Dong, Guo Sent: Monday, October 17, 2016 3:39 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo Subject: [edk2] [PATCH] CorebootPayloadPkg: Notify EndOfDxe and

Re: [edk2] [PATCH] CorebootModulePkg: Add a library to parse platform specific info.

Hi, Guo, Please fix the typos "specif" in commit message. Other than this, it looks good to me. Reviewed-by: Maurice Ma -Original Message- From: Dong, Guo Sent: Monday, October 17, 2016 3:33 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince;

[edk2] [PATCH 47/47] Vlv2TbltDevicePkg/SmBiosMiscDxe: rebase to ARRAY_SIZE()

Cc: David Wei Cc: Tim He Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscOemType0x94Function.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH 46/47] Vlv2TbltDevicePkg/PlatformSetupDxe: rebase to ARRAY_SIZE()

Cc: David Wei Cc: Tim He Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH 43/47] Vlv2TbltDevicePkg/FirmwareUpdate: rebase to ARRAY_SIZE()

Cc: David Wei Cc: Tim He Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2] [PATCH 44/47] Vlv2TbltDevicePkg/PlatformInitPei: rebase to ARRAY_SIZE()

M: David Wei M: Tim He Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Vlv2TbltDevicePkg/PlatformInitPei/FlashMap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH 42/47] ShellPkg/UefiShellLevel2CommandsLib: rebase to ARRAY_SIZE()

Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- ShellPkg/Library/UefiShellLevel2CommandsLib/TimeDate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[edk2] [PATCH 37/47] OvmfPkg/QemuBootOrderLib: rebase to ARRAY_SIZE()

Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[edk2] [PATCH 41/47] ShellPkg/UefiDpLib: rebase to ARRAY_SIZE()

Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- ShellPkg/Library/UefiDpLib/DpTrace.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[edk2] [PATCH 39/47] PerformancePkg/Dp_App: rebase to ARRAY_SIZE()

Cc: Daryl McDaniel Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- PerformancePkg/Dp_App/Dp.c | 2 +- PerformancePkg/Dp_App/DpTrace.c | 10 +- 2 files

[edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE()

Cc: Chao Zhang Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[edk2] [PATCH 45/47] Vlv2TbltDevicePkg/PlatformPei: rebase to ARRAY_SIZE()

Cc: David Wei Cc: Tim He Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Vlv2TbltDevicePkg/PlatformPei/BootMode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2] [PATCH 24/47] MdeModulePkg/BootManagerUiLib: rebase to ARRAY_SIZE()

Cc: Dandan Bi Cc: Eric Dong Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 26/47] MdeModulePkg/VarCheckHiiLib: rebase to ARRAY_SIZE()

Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGen.c | 4 ++--

[edk2] [PATCH 28/47] MdeModulePkg/BdsDxe: rebase to ARRAY_SIZE()

Cc: Feng Tian Cc: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 2 +- 1 file changed, 1 insertion(+), 1

[edk2] [PATCH 27/47] MdeModulePkg/Logo: rebase to ARRAY_SIZE()

Cc: Feng Tian Cc: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Logo/Logo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[edk2] [PATCH 25/47] MdeModulePkg/UefiBootManagerLib: rebase to ARRAY_SIZE()

Cc: Feng Tian Cc: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 2 +-

[edk2] [PATCH 16/47] IntelFrameworkModulePkg/BdsDxe: rebase to ARRAY_SIZE()

Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c| 2 +- IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BBSsupport.c| 4 ++--

[edk2] [PATCH 19/47] MdeModulePkg/PciHostBridgeDxe: rebase to ARRAY_SIZE()

Cc: Feng Tian Cc: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 2 +- 1 file changed, 1

[edk2] [PATCH 23/47] MdeModulePkg/BootMaintenanceManagerUiLib: rebase to ARRAY_SIZE()

Cc: Dandan Bi Cc: Eric Dong Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

  1   2   >