[edk2] [PATCH] Vlv2TbltDevicePkg:Add Intel I210 lan UNDI driver on Turbot2.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Vlv2TbltDevicePkg/PlatformPkg.fdf| 7 +++ Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 7 +++ 2 files changed, 14 insertions(+) diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf b/Vlv2TbltDevicePkg/PlatformPk

Re: [edk2] [PATCH] Vlv2TbltDevicePkg:Add Intel I210 lan UNDI driver on Turbot2.

Looks good. Reviewed-by: Mike Wu Best Regards Mike Wu -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of lushifex Sent: Friday, December 02, 2016 4:58 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH] Vlv2TbltDevicePkg:Add Intel I210 lan UNDI

[edk2] [shell] Redirected Environment Variables Are Not Saved Correctly

Test by doing this, immediately after booting: Notice that echo has created a new environment variable _key to the value 4, But this variable does not show up when running "set" Why? It is because the FileHandleWrappers does not use SetEnvironmentVariable. Instead, it tries to read and write th

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: AllocatePool should use MemoryType.

On 12/02/16 03:03, Yao, Jiewen wrote: > Thank you Laszlo. > > > > This time, I did not use number purposely. > > > > My thinking is that each patch resolves a specific problem. Although I > fixed all of them at same time, they can be check in independently. Ah! I looked briefly at the patc

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On 12/02/16 01:58, Jordan Justen wrote: > On 2016-12-01 12:54:34, Laszlo Ersek wrote: >> On 12/01/16 21:06, Jordan Justen wrote: >>> On 2016-12-01 10:43:24, Laszlo Ersek wrote: Hrpmf, wait a second, I do see something interesting: in this series you *are* modifying APIs declared in a libr

Re: [edk2] [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL

On 12/02/16 05:54, Zeng, Star wrote: > On 2016/12/2 9:53, Yao, Jiewen wrote: >> HI Laszlo >> Thank you to raise this long time existing issue. :-) >> >> There is historic reason that we inherit this undocumented API from >> EDK-I to EDKII. >> >> I do not object your update. Thanks! >> I am thinki

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On 12/02/16 05:36, Gao, Liming wrote: > I agree to root cause this issue with GCC6. Could you help submit this issue > in bugzilia? Then, we will investigate it further. Thanks, Liming, I've now filed . Cheers Laszlo > Thanks > Liming > -

Re: [edk2] [PATCH 3/5] OvmfPkg/IndustryStandard: add QemuFwCfgDma.h

On 12/02/16 02:01, Jordan Justen wrote: > On 2016-12-01 12:48:51, Laszlo Ersek wrote: >> On 12/01/16 20:34, Jordan Justen wrote: >>> On 2016-12-01 09:56:31, Laszlo Ersek wrote: Add the type and macro definitions related to QEMU's DMA-like fw_cfg access method in a dedicated header file. >

Re: [edk2] [PATCH v4 3/5] MdeModulePkg: implement generic PCI I/O driver for non-discoverable devices

Ray, any comments on the below? Regards, Leif On Wed, Nov 30, 2016 at 02:06:55PM +, Leif Lindholm wrote: > Hi Ray, > > Ard is on holiday this week, and mostly managing to stay off the > email... > > Anyway, I could really use this support in order to bring the Marvell > Armada 70x0 support

[edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

EFI_BOOT_SCRIPT_PCI_CONFIG_READ_WRITE_OPCODE expects the PCI address to access in UEFI encoding, not in edk2/PciLib encoding. Convert the ICH9_GEN_PMCON_1 register's address to UEFI representation before storing it in the boot script. Cc: Jordan Justen Contributed-under: TianoCore Contribution Ag

Re: [edk2] [PATCH 1/5] ArmVirtPkg/QemuFwCfgLib: remove superfluous InternalQemuFwCfgIsAvailable()

On Thu, Dec 01, 2016 at 06:56:29PM +0100, Laszlo Ersek wrote: > InternalQemuFwCfgIsAvailable() is an API that is incorrectly exposed by > the "OvmfPkg/Include/Library/QemuFwCfgLib.h" library class header; the API > is meant to be used internally to library instances (if it's needed at > all). ArmVi

Re: [edk2] [PATCH 4/5] ArmVirtPkg/QemuFwCfgLib: rebase lib instance to OvmfPkg/IndustryStandard

On Thu, Dec 01, 2016 at 06:56:32PM +0100, Laszlo Ersek wrote: > where "QemuFwCfgDma.h" was added in the previous patch. > > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek This is nice cleanup. One bit of bikeshedding below, address or

Re: [edk2] [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

On Thu, Dec 01, 2016 at 11:38:42AM -0800, Jordan Justen wrote: > For the future, I'd recommend adding Cc's for package owners to the > associated patch commit message. I guess what you're actually asking for is to have only the parts of series I want your review on sent to you? That's a fair poin

Re: [edk2] [PATCH 4/5] ArmVirtPkg/QemuFwCfgLib: rebase lib instance to OvmfPkg/IndustryStandard

On 12/02/16 12:03, Leif Lindholm wrote: > On Thu, Dec 01, 2016 at 06:56:32PM +0100, Laszlo Ersek wrote: >> where "QemuFwCfgDma.h" was added in the previous patch. >> >> Cc: Ard Biesheuvel >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek > > This is nice c

Re: [edk2] [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

On 12/02/16 12:27, Leif Lindholm wrote: > On Thu, Dec 01, 2016 at 11:38:42AM -0800, Jordan Justen wrote: >> For the future, I'd recommend adding Cc's for package owners to the >> associated patch commit message. > > I guess what you're actually asking for is to have only the parts of > series I wa

Re: [edk2] [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

On Fri, Dec 02, 2016 at 12:53:45PM +0100, Laszlo Ersek wrote: > On 12/02/16 12:27, Leif Lindholm wrote: > > On Thu, Dec 01, 2016 at 11:38:42AM -0800, Jordan Justen wrote: > >> For the future, I'd recommend adding Cc's for package owners to the > >> associated patch commit message. > > > > I guess

Re: [edk2] [PATCH v4 3/5] MdeModulePkg: implement generic PCI I/O driver for non-discoverable devices

Regards, Ray >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Wednesday, November 30, 2016 10:07 PM >To: Ni, Ruiyu >Cc: Ard Biesheuvel ; edk2-devel@lists.01.org; Gao, >Liming ; >af...@apple.com; Kinney, Michael D ; >m...@semihalf.com; Tian, Feng >Subj

[edk2] [shell] @ does not work before if, endif, for and many other command.

Try this: :start @if %1 == "" then @goto Done @endif @echo Parameter: %1 @shift goto start :Done Per Chapter 4 Also, additional '@' before a command in a script file can prevent the current command from being echoed. ___

Re: [edk2] [PATCH v4 3/5] MdeModulePkg: implement generic PCI I/O driver for non-discoverable devices

On Fri, Dec 02, 2016 at 12:54:45PM +, Ni, Ruiyu wrote: > >> > +Dev->ConfigSpace.Device.Bar[Idx] = (UINT32)Desc->AddrRangeMin; > >> > +Dev->BarCount++; > >> > + > >> > +if (Desc->AddrSpaceGranularity == 64) { > >> > + Dev->ConfigSpace.Device.Bar[Idx] |= 0x4; > >> > + Dev->C

Re: [edk2] [Patch v2 0/4] Fix SOURCE_DEBUG_ENABLE

Reviewed-by: jiewen@intel.com > -Original Message- > From: Kinney, Michael D > Sent: Friday, December 2, 2016 6:08 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Wei, David > ; Guo, Mang > Subject: [Patch v2 0/4] Fix SOURCE_DEBUG_ENABLE > > Changes in V2 > = > * Fix

[edk2] [shell] shift generates errors with no command-line options

In a script that looks like this: :start if not %1 == "" then echo %1 shift goto start endif 'shift' will generate an error message. The spec doesn't describe any behavior like this and it is annoying to write scripts that must avoid it. Of course you can work around it... Tim __

Re: [edk2] [PATCH v4 3/5] MdeModulePkg: implement generic PCI I/O driver for non-discoverable devices

> On 2 Dec 2016, at 14:40, Leif Lindholm wrote: > > On Fri, Dec 02, 2016 at 12:54:45PM +, Ni, Ruiyu wrote: > +Dev->ConfigSpace.Device.Bar[Idx] = (UINT32)Desc->AddrRangeMin; > +Dev->BarCount++; > + > +if (Desc->AddrSpaceGranularity == 64) { > + Dev->Config

Re: [edk2] [PATCH v4 3/5] MdeModulePkg: implement generic PCI I/O driver for non-discoverable devices

On Fri, Dec 02, 2016 at 03:07:39PM +, Ard Biesheuvel wrote: > > > On 2 Dec 2016, at 14:40, Leif Lindholm wrote: > > > > On Fri, Dec 02, 2016 at 12:54:45PM +, Ni, Ruiyu wrote: > > +Dev->ConfigSpace.Device.Bar[Idx] = (UINT32)Desc->AddrRangeMin; > > +Dev->BarCount++; > >

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On Thu, Dec 01, 2016 at 07:43:24PM +0100, Laszlo Ersek wrote: > On 12/01/16 16:28, Anthony PERARD wrote: > > Hi, > > > > That might be only with the Xen part of OVMF but now that the GCC5 > > toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail > > to boot in Xen guests. > > [..

Re: [edk2] [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

On Thu, Dec 01, 2016 at 03:53:19PM +, Leif Lindholm wrote: > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied > from IntelFrameworkModulePkg to MdeModulePkg, but the originals were > kept for compatibility. > > Nevertheless, new code should be using the MdeModulePkg versi

Re: [edk2] [shell] Pipe causes pool failure in Shell.c

Does that leak memory? It looks like that memory was allocated at 1720, then moved from Out to In at 1729-1735. Did the pointer possibly get mangled at 1724 or somewhere in between? Ray, Have you seen this? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lis

Re: [edk2] [PATCH v4 3/5] MdeModulePkg: implement generic PCI I/O driver for non-discoverable devices

On 2 December 2016 at 15:56, Leif Lindholm wrote: > On Fri, Dec 02, 2016 at 03:07:39PM +, Ard Biesheuvel wrote: >> >> > On 2 Dec 2016, at 14:40, Leif Lindholm wrote: >> > >> > On Fri, Dec 02, 2016 at 12:54:45PM +, Ni, Ruiyu wrote: >> > +Dev->ConfigSpace.Device.Bar[Idx] = (UINT32)D

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On 12/02/16 17:02, Anthony PERARD wrote: > On Thu, Dec 01, 2016 at 07:43:24PM +0100, Laszlo Ersek wrote: >> On 12/01/16 16:28, Anthony PERARD wrote: >>> Hi, >>> >>> That might be only with the Xen part of OVMF but now that the GCC5 >>> toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OV

[edk2] [PATCH v2 0/6] OvmfPkg/QemuFwCfgLib: support the DMA-like interface

Version 2 of . The following patches [PATCH 3/5] OvmfPkg/IndustryStandard: add QemuFwCfgDma.h [PATCH 4/5] ArmVirtPkg/QemuFwCfgLib: rebase lib instance to OvmfPkg/IndustryStandard have been replaced with [PA

[edk2] [PATCH v2 2/6] OvmfPkg/QemuFwCfgLib: move InternalQemuFwCfgIsAvailable() to lib instances

InternalQemuFwCfgIsAvailable() is an API that is incorrectly exposed by the "OvmfPkg/Include/Library/QemuFwCfgLib.h" library class header; the API is meant to be used internally to library instances (if it's needed at all). In OvmfPkg, we have two lib instances (for SEC and PEI/DXE); they provide

[edk2] [PATCH v2 4/6] OvmfPkg/QemuFwCfgLib: extend lib class header with more definitions

The last patch consists purely of code movement; going forward, we should use a few more symbolic constants. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - split these out to a

[edk2] [PATCH v2 3/6] ArmVirtPkg, OvmfPkg: QemuFwCfgLib: move DMA-related defs to lib class

Move the type and macro definitions related to QEMU's DMA-like fw_cfg access method to the library class header. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - move definitions

[edk2] [PATCH v2 1/6] ArmVirtPkg/QemuFwCfgLib: remove superfluous InternalQemuFwCfgIsAvailable()

InternalQemuFwCfgIsAvailable() is an API that is incorrectly exposed by the "OvmfPkg/Include/Library/QemuFwCfgLib.h" library class header; the API is meant to be used internally to library instances (if it's needed at all). ArmVirtPkg's instance has no use for it actually, so simplify the code and

[edk2] [PATCH v2 5/6] ArmVirtPkg/QemuFwCfgLib: rebase lib instance to updated lib class header

Put the FW_CFG_F_DMA constant, introduced in the last patch, to use. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - no need to include another header [Leif] - scope is smaller now (only FW_CF

[edk2] [PATCH v2 6/6] OvmfPkg/QemuFwCfgLib: support QEMU's DMA-like fw_cfg access method

The benefits of the DMA-like access method are (a) speed, (b) write support in QEMU 2.9+. (IOPort-based write support was discontinued in QEMU 2.4, and the DMA-based one is being added to QEMU 2.9. Write support needs no separate feature detection because writeability is governed on the level of i

[edk2] Handling multiple paths to the same EFI system partition?

I am trying to deal with a requirement that our firmware show 2 boot options when there are multiple paths to a GPT disk with an EFI system partition. The specific ask is for both paths to be shown in the boot order. However, the short form device path means these would be duplicate entries whic

Re: [edk2] [shell] Pipe causes pool failure in Shell.c

Jaben -- I'm not sure. In the debugger, it clearly showed the memory as having already been freed at the pointer. But I didn't track down who had done it. Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, December 02, 2016 8:39 AM To: Tim Lewis ;

Re: [edk2] [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL

HI Laszlo Would you please give me some time, so that I could discuss internal team to see if there is any concern on this API update? The estimation will be 1 work week at most. Usually adding a new API does not need compatibility check, but updating an existing API always need. Thank you Yao