Re: [edk2] ASSERT in QemuVideoDxe driver during reset

Agree. We should not break Window7. Let’s see the result. Thank you Yao Jiewen From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, September 7, 2017 6:58 PM To: Yao, Jiewen ; Wang, Jian J ; Justen, Jordan L Cc:

Re: [edk2] [PATCH v4 0/6] read-only UDF file system support

Paulo, On 09/07/17 02:23, Ni, Ruiyu wrote: > Sure. Please. Before pushing the series, I wanted to slightly regression-test OVMF and ArmVirtQemu with it. However, I've found that the series doesn't build for OVMF IA32. I get an error like this: > MdeModulePkg/Universal/Disk/UdfDxe/File.c: In

Re: [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common buffers at ExitBootServices()

On 09/07/17 06:34, Yao, Jiewen wrote: > Thanks. > It seems the discussion becomes too long. I try to make it short. > > > 1) As long as we use same mechanism to handle both common buffer and > read/write buffer. I have no concern at all. :) > > > 2) I am sorry that I do not have

Re: [edk2] [Patch] BaseTools: Not show *B when Pcd value in build option same with DEC

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, September 04, 2017 4:42 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch]

[edk2] [PATCH] MdeModulePkg Xhci: Correct description of Timeout param in XhciReg.h

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=653 Correct description of Timeout param in XhciReg.h to be matched with XhciReg.c. Cc: Alexei Fedorov Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

On 09/07/17 03:28, Yao, Jiewen wrote: > OK. Got you. > > I think we can move the zero memory to DxeIpl. > The DxeIpl can check if the 0 is allocated in MemoryAllocationHob, and zero > it if it is not allocated. Regarding the zeroing out of page 0, this solution seems good to me as well. (I

Re: [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common buffers at ExitBootServices()

On 09/07/17 06:46, Yao, Jiewen wrote: > Thanks for the sharing, Brijesh. > > "If a page was marked as "shared" > then its guest responsibility to make it "private" after its done > communicating with > hypervisor." > > I believe I have same understanding - a *guest* should guarantee that. > >

[edk2] [staging/Intel_UNDI]: Creation of new branch (Intel_UNDI) and initial commit

Hi edk2-devel members, As per agreement with Michael D. Kinney (michael.d.kin...@intel.com), Intel PreBoot team has submitted a new feature branch to edk2-staging repository. Intel_UNDI branch introduces open-source UEFI UNDI Drivers code supporting Intel(r)

Re: [edk2] [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro.

On Thu, Sep 07, 2017 at 07:47:52PM +0530, Meenakshi Aggarwal wrote: > We want to print name of the function resulted in error, > but __FUNCTION__ macro was missing. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Meenakshi Aggarwal Like

Re: [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common buffers at ExitBootServices()

Great. Thanks to confirm that. Now it is clear to me. Then let's wait Laszlo's new patch to make all DMA buffer to private. :) Thank you Yao, Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Brijesh Singh Sent: Thursday, September 7, 2017 10:40 PM To: Laszlo Ersek

Re: [edk2] [PATCH] BaseTools/GCC5: set -Wno-unused-const-variables on RELEASE builds

I suggest to also add this option in GCC49 tool chain RELEASE builds. GCC49 can be used for GCC 4.9 or the above version. It doesn't enable LTO. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Thomas > Lamprecht > Sent:

Re: [edk2] [PATCH v4 0/6] read-only UDF file system support

Laszlo, On 07/09/2017 08:35, Laszlo Ersek wrote: Paulo, On 09/07/17 02:23, Ni, Ruiyu wrote: Sure. Please. Before pushing the series, I wanted to slightly regression-test OVMF and ArmVirtQemu with it. However, I've found that the series doesn't build for OVMF IA32. I get an error like this:

Re: [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common buffers at ExitBootServices()

Hi Jiewen, On 09/07/2017 06:46 AM, Laszlo Ersek wrote: On 09/07/17 06:46, Yao, Jiewen wrote: Thanks for the sharing, Brijesh. "If a page was marked as "shared" then its guest responsibility to make it "private" after its done communicating with hypervisor." I believe I have same

[edk2] [Patch] BaseTools: correct to use specific arch to generate DSC database

Not generic to use 'Common' arch, but use current build arch. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/WorkspaceDatabase.py | 2 +- 1 file changed, 1

Re: [edk2] [PATCH v3 2/2] SD : Updated CMD 6 implememtation.

On Thu, Sep 07, 2017 at 07:47:53PM +0530, Meenakshi Aggarwal wrote: > For setting high speed in SD card, > First CMD 6 (Switch) is send to check if card supports High Speed and > Second command is send to switch card to high speed mode. > > In current inplementation, CMD 6 was sent only once to

Re: [edk2] [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro.

Hi Leif, Yes, I agree to contribute under TianoCore Contribution Agreement 1.1 Thanks, Meenakshi > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, September 07, 2017 8:07 PM > To: Meenakshi Aggarwal > Cc:

Re: [edk2] [PATCH v3 2/2] SD : Updated CMD 6 implememtation.

Hi Leif, I agree to contribute under TianoCore Contribution Agreement 1.1 Thanks, Meenakshi > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, September 07, 2017 8:05 PM > To: Meenakshi Aggarwal > Cc:

[edk2] Fwd: Boot####, Key####

Hi, Implementing support for UEFI inside different OS environments, I don't see anything in the spec about being able to find the various Boot and Key values without trying 0-0x which is slow (takes 10+ seconds).What's the better way? Thanks.

[edk2] Fwd: StartImage with Secure Boot on Self-Signed App

Hello, What is the proper way to allow running another app that is verified with a self-signed certificate? Example, App1 is signed with one that allows secure boot booting (in firmware) and has a public key embedded in the signed code, App2 is verified by App1 and so is allowed to run, but

[edk2] [PATCH] BaseTools/GCC5: set -Wno-unused-const-variables on RELEASE builds

TianoCore BZ#700 This fixes the RELEASE build of OVMF with GCC in version 6 or newer. GCC 6 added the '-Wunused-const-variable' warning, which gets activated by '-Wunused-variable' and has the following behavior: "Warn whenever a constant

Re: [edk2] [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro.

Thanks! For the series: Reviewed-by: Leif Lindholm Pushed as c50596a701..ea21f1d98d / Leif On Thu, Sep 07, 2017 at 03:19:34PM +, Meenakshi Aggarwal wrote: > Hi Leif, > > Yes, I agree to contribute under TianoCore Contribution Agreement 1.1 > > Thanks, >

Re: [edk2] [PATCH] BaseTools/GCC5: set -Wno-unused-const-variables on RELEASE builds

On 09/07/17 17:04, Gao, Liming wrote: > I suggest to also add this option in GCC49 tool chain RELEASE builds. GCC49 > can be used for GCC 4.9 or the above version. It doesn't enable LTO. Good idea. There could be several reasons for picking GCC49; see e.g. commit 432f1d83f77a

Re: [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common buffers at ExitBootServices()

On 09/07/17 16:48, Yao, Jiewen wrote: > Great. Thanks to confirm that. Now it is clear to me. > > Then let's wait Laszlo's new patch to make all DMA buffer to private. :) I've got the patches ready and smoke-tested. Let me look a bit more at the logs, and re-review the patches. I hope I can post

Re: [edk2] Fwd: Boot####, Key####

> On Sep 7, 2017, at 1:01 PM, David F. wrote: > > Hi, > > Implementing support for UEFI inside different OS environments, I > don't see anything in the spec about being able to find the various > Boot and Key values without trying 0-0x which is slow > (takes 10+

Re: [edk2] Fwd: Boot####, Key####

On 09/07/17 22:32, Andrew Fish wrote: > >> On Sep 7, 2017, at 1:01 PM, David F. wrote: >> >> Hi, >> >> Implementing support for UEFI inside different OS environments, I >> don't see anything in the spec about being able to find the various >> Boot and Key values without

Re: [edk2] [PATCH 0/5] OvmfPkg/VirtioNetDxe: map host address to device address

Hi Brijesh, On 09/01/17 13:24, Brijesh Singh wrote: > The patch updates VirtioNetDxe to use IOMMU-like member functions to > map the system physical address to device address for buffers > (including vring, device specific request and response pointed by > vring descriptor, and any furter memory

[edk2] [PATCH 01/10] MdeModulePkg/AtaAtapiPassThru: cache EnabledPciAttributes

Both AtaAtapiPassThruStart() and AtaAtapiPassThruStop() fetch the supported attributes of the device, just so they can toggle the IO+MMIO+BusMaster subset. After we compute this bitmask in AtaAtapiPassThruStart(), we can cache it for later, and save the fetch in AtaAtapiPassThruStop(). Cc: Ard

[edk2] [PATCH 03/10] MdeModulePkg/AtaAtapiPassThru: disable the device at ExitBootServices()

The AtaAtapiPassThru driver maps three system memory regions for Bus Master Common Buffer operation on the following call path, if the controller has PCI_CLASS_MASS_STORAGE_SATADPA class code: AtaAtapiPassThruStart() EnumerateAttachedDevice() AhciModeInitialization()

[edk2] [PATCH 10/10] OvmfPkg/IoMmuDxe: unmap all IOMMU mappings at ExitBootServices()

Register an ExitBootServices() callback that tears down all IOMMU mappings, without modifying the UEFI memory map. The trick is that in the ExitBootServices() callback, we don't immediately do the work; instead we signal another (private) event. Normally the dispatch order of ExitBootServices()

[edk2] [PATCH 05/10] OvmfPkg/VirtioGpuDxe: don't unmap VRING & BackingStore at ExitBootServices

In one of the following patches, we'll change OvmfPkg/IoMmuDxe so that it unmaps all existent bus master operations (CommonBuffer, Read, Write) at ExitBootServices(), strictly after the individual device drivers abort pending DMA on the devices they manage, in their own ExitBootServices()

[edk2] [PATCH 07/10] OvmfPkg/VirtioScsiDxe: don't unmap VRING at ExitBootServices()

In one of the following patches, we'll change OvmfPkg/IoMmuDxe so that it unmaps all existent bus master operations (CommonBuffer, Read, Write) at ExitBootServices(), strictly after the individual device drivers abort pending DMA on the devices they manage, in their own ExitBootServices()

[edk2] [PATCH 00/10] MdeModulePkg, OvmfPkg: unmap DMA buffers at ExitBootServices

Repo: https://github.com/lersek/edk2.git Branch: iommu_exit_boot This series is the result of the discussion under [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common buffers at ExitBootServices()

[edk2] [PATCH 06/10] OvmfPkg/VirtioRngDxe: don't unmap VRING at ExitBootServices()

In one of the following patches, we'll change OvmfPkg/IoMmuDxe so that it unmaps all existent bus master operations (CommonBuffer, Read, Write) at ExitBootServices(), strictly after the individual device drivers abort pending DMA on the devices they manage, in their own ExitBootServices()

[edk2] [PATCH 08/10] OvmfPkg/IoMmuDxe: track all mappings

The "mRecycledMapInfos" list implements an internal pool of unused MAP_INFO structures between the IoMmuUnmap() and IoMmuMap() functions. The original goal was to allow IoMmuUnmap() to tear down CommonBuffer mappings without releasing any memory: IoMmuUnmap() would recycle the MAP_INFO structure

[edk2] [PATCH 02/10] MdeModulePkg/AtaAtapiPassThru: unmap DMA buffers after disabling BM DMA

In AtaAtapiPassThruStop(), if the device has been operating in AHCI mode, we unmap the DMA buffers and then disable the device (including bus master DMA). The order of these actions is wrong; we shouldn't unmap DMA buffers until bus master DMA is turned off. Reverse the steps. Cc: Ard Biesheuvel

[edk2] [PATCH 09/10] OvmfPkg/IoMmuDxe: generalize IoMmuUnmap() to IoMmuUnmapWorker()

IoMmuUnmapWorker() is identical to IoMmuUnmap(), it just takes an additional BOOLEAN parameter called "MemoryMapLocked". If the memory map is locked, IoMmuUnmapWorker() does its usual job, but it purposely leaks memory rather than freeing it. This makes it callable from ExitBootServices()

[edk2] [PATCH 04/10] OvmfPkg/VirtioBlkDxe: don't unmap VRING at ExitBootServices()

In one of the following patches, we'll change OvmfPkg/IoMmuDxe so that it unmaps all existent bus master operations (CommonBuffer, Read, Write) at ExitBootServices(), strictly after the individual device drivers abort pending DMA on the devices they manage, in their own ExitBootServices()

[edk2] [PATCH v5 4/6] OvmfPkg: Enable UDF file system support

This patch enables UDF file system support by default. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara Reviewed-by: Laszlo Ersek ---

[edk2] [PATCH v5 0/6] read-only UDF file system support

Hi, This series introduces read-only UDF file system support in EDK2. As Laszlo (or Red Hat) seemed to be interested in such support, I'm posting it again after ~3 years. The idea is not replacing the default FAT file system, nor breaking any existing file system support, but extending EDK2 with

[edk2] [PATCH v5 1/6] MdePkg: Add UDF volume structure definitions

This patch adds basic volume structure definitions necessary to identify a valid UDF file system on a block device, as specified by OSTA Universal Disk Format Specification 2.60. Cc: Michael D Kinney Cc: Liming Gao Cc: Laszlo Ersek

Re: [edk2] [PATCH v5 0/6] read-only UDF file system support

Ray, On 07/09/2017 20:13, Paulo Alcantara wrote: v5: - Fixed OVMF IA32 build. - Fixed a typo in UdfDriveBindingStop() ("This" -> "SimpleFs") which broke retrieval of private fs data from SimpleFs protocol -- identified by 'reconnect -r' command in UEFI shell. Follow the diff

[edk2] [PATCH v5 6/6] Nt32Pkg: Enable UDF file system support

This patch enables UDF file system support by default. Cc: Ruiyu Ni Cc: Hao Wu Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara --- Nt32Pkg/Nt32Pkg.dsc | 1 +

[edk2] [PATCH v5 2/6] MdeModulePkg/PartitionDxe: Add UDF file system support

Scan for UDF file systems on all block devices, as specified by OSTA Universal Disk Format Specification 2.60, and install a Vendor-Defined Media Device Path for each file system found. The Vendor-Defined Media Device Path for the UDF file system is then checked by UdfDxe to decide whether or not

[edk2] [PATCH v5 5/6] ArmVirtPkg: Enable UDF file system support

This patch enables UDF file system support by default. Cc: Laszlo Ersek Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara Reviewed-by: Ard Biesheuvel

Re: [edk2] Fwd: StartImage with Secure Boot on Self-Signed App

On Thu, Sep 07, 2017 at 01:00:03PM -0700, David F. wrote: > Hello, > > What is the proper way to allow running another app that is verified > with a self-signed certificate? > > Example, App1 is signed with one that allows secure boot booting (in > firmware) and has a public key embedded in the

[edk2] [Patch] MdeModulePkg: Update PiDxeS3BootScriptLib Internal function name

To avoid the function name conflict, update the internal function name to be the specific one. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptExecute.c | 4 ++-- 1 file changed, 2

[edk2] WARNING: No source level debug

Hi, Was having trouble getting the debug messages to show in the debug log list in the developer window that launches the simulated shell window. I started out following the driver building edk2 lab pdf instructions in building one of the test drivers. In the lab they have you enter the debug

Re: [edk2] [PATCH v5 0/6] read-only UDF file system support

Paulo, Did you mix the usage of "\r\n" and "\n"? because I saw a ^M in your diff. However, the diff content looks good to me. Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, September 8, 2017 8:56 AM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH v5 6/6] Nt32Pkg: Enable UDF file system support

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Friday, September 8, 2017 7:13 AM > To: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Ni, Ruiyu ; Wu, > Hao A

Re: [edk2] Fwd: StartImage with Secure Boot on Self-Signed App

Thanks, looking forward, can the people on the board dealing with the specification please consider revising EFI_LOADED_IMAGE_PROTOCOL to include a new "Flags" field and one of the bits allows StartImage to start the image even if LoadImage reported a EFI_SECURITY_VIOLATION was reported. defined

[edk2] Curious question regarding lack of debug in MdeModulePkg

Hi, Was trying to figure out why I could not output debug messages with a simple driver using the Debug macro compiled against the MdeModulePkg until I discovered that the same driver code works when compiled against Nt32Pkg and all my debug messages get posted in the debug console. Would anyone

Re: [edk2] PI 1.6: Issues within the SPI sections.

Thank you very much Andrew, hadn't seen it yet. Sorry for spamming here. Best regards, Marvin. From: af...@apple.com [mailto:af...@apple.com] Sent: Wednesday, September 6, 2017 5:31 PM To: Marvin H?user Cc: edk2-devel@lists.01.org Subject: Re: [edk2] PI 1.6: Issues

Re: [edk2] Curious question regarding lack of debug in MdeModulePkg

Hey, Did you make sure you use the proper DebugLib instance in your .dsc (or if you build MdeModulePkg directly, adapted its)? You likely want UefiDebugLibConOut. Also make sure you enabled the necessary debug levels via PCD. Regards, Marvin. > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH v5 0/6] read-only UDF file system support

Hi, On 07/09/2017 23:41, Ni, Ruiyu wrote: Paulo, Did you mix the usage of "\r\n" and "\n"? because I saw a ^M in your diff. However, the diff content looks good to me. No, I didn't. My local repo just lacked the 'git config core.whitespace cr-at-eol' setting so 'git diff' showed the CRLFs as

[edk2] [Patch 2/2] MdeModulePkg: Update modules to consume CalculateCrc32()

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Core/RuntimeDxe/Crc32.c | 74 +- MdeModulePkg/Core/RuntimeDxe/Runtime.c | 5 - MdeModulePkg/Core/RuntimeDxe/Runtime.h |

[edk2] [Patch 0/2] Add CalculateCrc32() API in MdePkg BaseLib

Add CalculateCrc32() as the public API for code sharing. Liming Gao (2): MdePkg BaseLib: Add new API CalculateCrc32() MdeModulePkg: Update modules to consume CalculateCrc32() MdeModulePkg/Core/RuntimeDxe/Crc32.c | 74 +- MdeModulePkg/Core/RuntimeDxe/Runtime.c

[edk2] [Patch 1/2] MdePkg BaseLib: Add new API CalculateCrc32()

CalculateCrc32() bases on the initialized mCrcTable. When CalculateCrc32() is used, mCrcTable will take 1KB size in the image. When CalculateCrc32() is not used, mCrcTable will not be built in the image, and no size impact. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] WARNING: No source level debug

Please check the debuglib instance. MdeModulePkg.dsc sets DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf. This library instance prints the debug message to Console. Nt32.dsc sets

Re: [edk2] [Patch] BaseTools: correct to use specific arch to generate DSC database

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Thursday, September 07, 2017 9:29 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2]

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

Marvin, Thank you for your contribution. We will need some time to review the definitions against PI Spec. If there is a need to post V2, it might be better to separate the header files in different groups. For example, LegacySpi group, SPI group, SMM SPI group. Thanks/Ray > -Original

Re: [edk2] [PATCH 1/1] OvmfPkg/IoMmuDxe: shut up "unused-const-variable" gcc-6 warning in RELEASE

On 09/07/17 07:47, Thomas Lamprecht wrote: > On 09/07/2017 05:38 AM, Gao, Liming wrote: >> Laszlo: >>    I add -Wno-unused-const-variable option in GCC5 RELEASE option, and >> build OvmfPkg with GCC5.3. I don't meet any warning or error. Do you >> meet any issue? So, you think we can't add this

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Ubuntu boot

Add Ubuntu boot loader file path \\EFI\\UBUNTU\\GRUBX64.EFI into known OS loader list. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: xianhu2x --- .../Library/GenericBdsLib/BdsBoot.c| 26 ++

Re: [edk2] [PATCH][edk2-platforms] Ubuntu boot

Hi all, Please ignore this patch. The subject is not quite right. I have re-submitted a patch with subject: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Ubuntu boot. Thanks. Best Regards Liu Xianhui -Original Message- From: Wei, David Sent: Thursday, September 7, 2017 11:15 AM