[edk2] [PATCH] MdeModulePkg/UdfDxe: Fix NULL pointer dereference

2017-09-11 Thread Paulo Alcantara
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=704 For root directory, the FID (File Identifier Descriptor) pointer is accessible through PRIVATE_UDF_FILE_DATA.Root, whereas non-root directory and regular files, their FIDs are accessible through PRIVATE_UDF_FILE_DATA.File. In

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: GetBarAttributes() returns Host address

2017-09-11 Thread Ni, Ruiyu
Laszlo, Your understanding is: DeviceAddress = HostAddress + AddressTranslationOffset But my patch assumes: HostAddress = DeviceAddress + AddressTranslationOffset They are totally different. If I follow your understanding, the patch is wrong! Since UEFI spec doesn't describe "apply to" in

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Change Reset Type

2017-09-11 Thread lushifex
Change Reset Type according to different Board. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- .../Board/BensonGlacier/BoardInitPostMem/BoardInit.c | 7 +++ .../Board/BensonGlacier/BoardInitPostMem/BoardInit.h

Re: [edk2] [patch 0/3] MdeModulePkg/Udf: Fix VS tool chain build failures

2017-09-11 Thread Paulo Alcantara
Dandan, On 11/09/2017 02:44, Dandan Bi wrote: Dandan Bi (3): MdeModulePkg/PartitionDxe: Don't use non-constant expression in array initialization MdeModulePkg/UdfDxe: Don't use non-constant expression in array initialization MdeModulePkg/UdfDxe: Add type cast to fix build

[edk2] [PATCH v2 5/6] MdeModulePkg/SetupBrowser: Handle questions with Bit VarStore

2017-09-11 Thread Dandan Bi
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 For oneof/numeric/CheckBox(storage can be Bit VarStore) If the question value can be updated and shown correctly in UI page, we need do enhancements in following cases: 1. Parse the Ifr data to get the bit VarStore info correctly. 2. Set/get

[edk2] [PATCH v2 6/6] MdeModulePkg/DriverSample: Add sample questions with bit/union VarStore

2017-09-11 Thread Dandan Bi
V2: Refine the new added questions and their field name in Varstore. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [PATCH v2 0/6] Support bitfield in storage of vfr

2017-09-11 Thread Dandan Bi
V2: Pacth1: Support bit field for Guided extension and appending question. Patch3: Add previous missing logic to handle question with Bit VarStore in UefiHiiLib. Patch4: Merge block data value with same offset/width or offset/width has overlap region. Patch6: Refine the new added questions and

[edk2] [PATCH v2 2/6] MdeModulePkg: Add GUID/flags to implement BitField support

2017-09-11 Thread Dandan Bi
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Include/Guid/MdeModuleHii.h | 20

[edk2] [PATCH v2 4/6] MdeModulePkg/HiiDatabase: Handle questions with Bit VarStore

2017-09-11 Thread Dandan Bi
V2: Merge block data value with same offset/width or offset/width has overlap region. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 For oneof/numeric/checkbox, their storage may be bit field. When generating string to get default value for these questions, we need to parse the Ifr data

[edk2] [PATCH v2 3/6] MdeModulePkg/UefiHiiLib: Add codes to validate question with bit fields

2017-09-11 Thread Dandan Bi
V2: Add previous missing logic to handle question with Bit VarStore in UefiHiiLib. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 In UefiHiiLib, there are codes to validate the current setting of questions, now update the logic to handle question with bit storage. Cc: Eric Dong

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Change Reset Type

2017-09-11 Thread Wei, David
Reviewed-by: zwei4 Thanks, David Wei > -Original Message- > From: Lu, ShifeiX A > Sent: Tuesday, September 12, 2017 10:54 AM > To: edk2-devel@lists.01.org > Cc: Wei, David > Subject:

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: GetBarAttributes() returns Host address

2017-09-11 Thread Ard Biesheuvel
On 11 September 2017 at 07:46, Laszlo Ersek wrote: > On 09/11/17 07:01, Ruiyu Ni wrote: >> Per the UEFI Spec, GetBarAttributes() should return the Host address. >> But current implementation returns the address read from the BAR, >> which is the Device address. >> Per the

[edk2] can bootorder add additional paramter for efi applications

2017-09-11 Thread wang xiaofeng
Hello All, Do anyone knows whether bootorder can add additional paramter for efi applications?Just like the following format Boot0007* testefi HD(1,GPT,d50ab0e8-2cc0-4f80-ac10-dbe7bc9cb336,0x800,0x10)/File(\EFI\test\ testefi.efi)testpara=1 testpara=2 ( expect the testefi can

Re: [edk2] Question on Iscsi Behavior

2017-09-11 Thread Karunakar P
Hello All, Could you please help in clarifying below question on ISCSI behavior. 2 ISCSI Attempts are added with different configuration Case 1: Attempt 1--Enabled(ISCSI Mode)--IP4-DHCP ---> In Valid Attempt (In Valid Target Details) Attempt 2--Enabled(ISCSI

[edk2] [PATCH v2 7/8] OvmfPkg/VirtioNetDxe: map caller-supplied Tx packet to device-address

2017-09-11 Thread Brijesh Singh
When device is behind the IOMMU, driver is require to pass the device address of caller-supplied transmit buffer for the bus master operations. The patch uses VirtioNetMapTxBuf() to map caller-supplied Tx packet to a device-address and enqueue the device address in VRING for transfer and perform

[edk2] [PATCH v2 8/8] OvmfPkg/VirtioNetDxe: negotiate VIRTIO_F_IOMMU_PLATFORM

2017-09-11 Thread Brijesh Singh
VirtioNetDxe driver has been updated to use IOMMU-like member functions from VIRTIO_DEVICE_PROTOCOL to translate the system physical address to device address. We do not need to do anything special when VIRTIO_F_IOMMU_PLATFORM bit is present hence treat it in parallel with VIRTIO_F_VERSION_1. Cc:

[edk2] [PATCH v2 1/8] OvmfPkg/VirtioNetDxe: add helper VirtioNetUninitRing()

2017-09-11 Thread Brijesh Singh
Consolidate the virtio VRING resource cleanup into VirtioNetUninitRing(). Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Tom Lendacky Cc: Laszlo Ersek Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups

2017-09-11 Thread Paulo Alcantara
On 11/09/2017 03:58, Laszlo Ersek wrote: On 09/10/17 17:51, Paulo Alcantara wrote: On 10/09/2017 11:27, Shi, Steven wrote: OK. Does the UDF image you created correctly show up as CD-ROM content in Linux, e.g Fedora? The Fedora image I have (Fedora-Workstation-Live-x86_64-26-1.5.iso) does

[edk2] [PATCH v2 4/8] OvmfPkg/VirtioNetDxe: dynamically alloc transmit header

2017-09-11 Thread Brijesh Singh
Each network packet is submitted for transmission by pushing the head descriptor of a two-part descriptor chain to the Available Ring of the TX queue. VirtioNetInitTx() sets up the the descriptor chains for all queueable packets in advance, and points all the head descriptors to the same shared,

[edk2] [PATCH v2 3/8] OvmfPkg/VirtioNetDxe: alloc RxBuf using AllocateSharedPages()

2017-09-11 Thread Brijesh Singh
When device is behind the IOMMU, VirtioNetDxe is required to use the device address in bus master operations. RxBuf is allocated using AllocatePool() which returns the system physical address. The patch uses VIRTIO_DEVICE_PROTOCOL.AllocateSharedPages() to allocate the RxBuf and map with

[edk2] [PATCH v2 0/8] OvmfPkg/VirtioNetDxe: map host address to device address

2017-09-11 Thread Brijesh Singh
The patch updates VirtioNetDxe to use IOMMU-like member functions to map the system physical address to device address for buffers (including vring, device specific request and response pointed by vring descriptor, and any furter memory reference by those request and response). Repo:

[edk2] [PATCH v2 2/8] OvmfPkg/VirtioNetDxe: map VRINGs using VirtioRingMap()

2017-09-11 Thread Brijesh Singh
When device is behind the IOMMU then driver need to pass the device address when programing the bus master. The patch uses VirtioRingMap() to map the VRING system physical address[es] to device address[es]. Cc: Ard Biesheuvel Cc: Jordan Justen

[edk2] [PATCH v2 6/8] OvmfPkg/VirtioNetDxe: add Tx packet map/unmap helper functions

2017-09-11 Thread Brijesh Singh
When device is behind IOMMU, driver is require to pass the device address of TxBuf in the Tx VRING. The patch adds helper functions and data structure to map and unmap the TxBuf system physical address to a device address. Since the TxBuf is returned back to caller from VirtioNetGetStatus() hence

[edk2] [PATCH v2 5/8] OvmfPkg/VirtioNetDxe: update TechNotes

2017-09-11 Thread Brijesh Singh
In next patches we will update Virtio transmit to use the device-mapped address of the caller-supplied packet. The patch documents the new model. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Tom Lendacky Cc: Laszlo

Re: [edk2] [PATCH edk2-platforms 03/14] Platform: add support for Socionext Synquacer eval board

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:04PM +0100, Ard Biesheuvel wrote: > This is a barebones port based on the .DSC/.FDF and ArmPlatformLib > code provided by Socionext. It can boot into the UiApp menu screen > or the UEFI Shell, but lacks support for any peripherals. > > Contributed-under: TianoCore

Re: [edk2] [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups

2017-09-11 Thread Ni, Ruiyu
Steven, Thanks for capturing the bug using ASAN! -Original Message- From: Shi, Steven Sent: Monday, September 11, 2017 9:08 PM To: Paulo Alcantara ; Laszlo Ersek ; edk2-devel-01 Cc: Ni, Ruiyu ; Dong, Eric

Re: [edk2] [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups

2017-09-11 Thread Ard Biesheuvel
On 10 September 2017 at 01:12, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: udf_fixes_cleanups > > Patches #2, #3 and #4 are needed (and enough) for me to build OVMF for > IA32 and X64 with clang-3.8, after the UDF introduction. > > Patches #1 and

Re: [edk2] [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups

2017-09-11 Thread Laszlo Ersek
On 09/11/17 15:07, Shi, Steven wrote: > Hi Laszlo, > Your code is good. But there is a "Null Pointer Use" issue, which is a > undefined behavior in C spec, in > edk2/MdeModulePkg/Universal/Disk/UdfDxe/File.c, line:696, column: 7 and > line:707, column: 14. > > Line695: > FileIdentifierDesc =

Re: [edk2] [PATCH edk2-platforms 01/14] Silicon/Synquacer: add package with platform headers

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:02PM +0100, Ard Biesheuvel wrote: > Add a package .DEC description for Synquacer with an [Includes] > section, and add header files containing descriptions of the > platform's memory map and PCIe configuration. No code yet. > > Contributed-under: TianoCore

Re: [edk2] [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups

2017-09-11 Thread Paulo Alcantara
Hi Steven, On 11/09/2017 10:07, Shi, Steven wrote: Hi Laszlo, Your code is good. But there is a "Null Pointer Use" issue, which is a undefined behavior in C spec, in edk2/MdeModulePkg/Universal/Disk/UdfDxe/File.c, line:696, column: 7 and line:707, column: 14. Line695: FileIdentifierDesc =

Re: [edk2] [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups

2017-09-11 Thread Shi, Steven
Hi Laszlo, Your code is good. But there is a "Null Pointer Use" issue, which is a undefined behavior in C spec, in edk2/MdeModulePkg/Universal/Disk/UdfDxe/File.c, line:696, column: 7 and line:707, column: 14. Line695: FileIdentifierDesc = PrivFileData->File.FileIdentifierDesc; if

Re: [edk2] [PATCH edk2-platforms 02/14] Silicon/Synquacer: add MemoryInitPeiLib implementation

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:03PM +0100, Ard Biesheuvel wrote: > Replace the common MemoryInitPeiLib implementation with one that does > not remove the primary FV from the memory map. This is a waste of > memory and TLB entries, given that the OS can no longer use a 1 GB > block mapping to map

Re: [edk2] [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups

2017-09-11 Thread Shi, Steven
Hi Paulo, Your fix works for me. The "Null Pointer Use" issue disappears after apply your new assignment patch. Thanks! Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Monday,

[edk2] [PATCH v2 2/3] MdeModulePkg/UdfDxe: Initialize the array after declaration

2017-09-11 Thread Dandan Bi
Initialize the array DescriptorLBAs[] after declaration to fix non-constant aggregate initializer warning in VS tool chains. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 13

[edk2] [PATCH v2 1/3] MdeModulePkg/PartitionDxe: Initialize the array after declaration

2017-09-11 Thread Dandan Bi
Initialize the array DescriptorLBAs[] after declaration to fix non-constant aggregate initializer warning in VS tool chains. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 13

[edk2] [PATCH v2 3/3] MdeModulePkg/UdfDxe: Add type cast to fix build failure in VS tools

2017-09-11 Thread Dandan Bi
Cc: Eric Dong Cc: Paulo Alcantara Cc: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi ---

Re: [edk2] [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups

2017-09-11 Thread Laszlo Ersek
On 09/10/17 17:51, Paulo Alcantara wrote: > > > On 10/09/2017 11:27, Shi, Steven wrote: >> OK. Does the UDF image you created correctly show up as CD-ROM content >> in Linux, e.g Fedora? > > The Fedora image I have (Fedora-Workstation-Live-x86_64-26-1.5.iso) does > not contain a valid UDF file

Re: [edk2] [PATCH v2] BaseTools/GCC: set -Wno-unused-const-variables on RELEASE builds

2017-09-11 Thread Thomas Lamprecht
On 09/08/2017 09:05 PM, Laszlo Ersek wrote: On 09/08/17 09:01, Thomas Lamprecht wrote: TianoCore BZ#700 [1] Set the '-Wno-unused-const-variables' in RELEASE builds with the GGC49 and GCC5 toolchain. This fixes the RELEASE build of OVMF with GCC in version 6 or newer. GCC 6 added the

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: GetBarAttributes() returns Host address

2017-09-11 Thread Laszlo Ersek
On 09/11/17 07:01, Ruiyu Ni wrote: > Per the UEFI Spec, GetBarAttributes() should return the Host address. > But current implementation returns the address read from the BAR, > which is the Device address. > Per the description of AddressTranslationOffset in ACPI spec: > "For bridges that

Re: [edk2] Can't load Refind boot loader inside Secmain UGA Window

2017-09-11 Thread Gao, Liming
NT32 boot to UEFI Shell only. It can't boot to any OS. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >david moheban >Sent: Sunday, September 10, 2017 8:35 AM >To: edk2-devel@lists.01.org >Subject: [edk2] Can't load Refind boot

[edk2] UEFI SATA dvd cannot be detected in uiapp without SCSIdriver

2017-09-11 Thread wang xiaofeng
Dear All, I meet a problem that after I remove the following drivers in dsc and fdf , MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf The boot option of UEFI SATA DVD-ROM is losted in UIAPP. Is it a designed behavior? In shell,

Re: [edk2] [PATCH edk2-platforms 05/14] Silicon/Synquacer: implement PciHostBridgeLib support

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:06PM +0100, Ard Biesheuvel wrote: > Implement the glue library that exposes the PCIe root complexes to > the generic PCI host bridge driver. Since that driver is the first > one to access the PCI config space, put the low level init code for > the RCs into this

Re: [edk2] ApolloLake with EDK2 - Ubuntu boots but Windows 10 does not

2017-09-11 Thread Johnson, Brian (EXL - Eagan)
Amrit, You may be able to hook up Microsoft's remote kernel debugger and get some idea of how far it is getting. I'm afraid I can't give you specifics on doing that, though; it's been years since I've tried. I know in general Windows is pretty sensitive to ACPI issues. Linux is much more

Re: [edk2] [PATCH edk2-platforms 06/14] Silicon/Synquacer: implement EFI_CPU_IO2_PROTOCOL

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:07PM +0100, Ard Biesheuvel wrote: > The Synquacer SOC has two separate PCIe RCs, which means there is > no single value for the translation offset between I/O port accesses > and MMIO accesses. So add a special implementation of EFI_CPU_IO2_PROTOCOL > that takes the

[edk2] [PATCH 0/5] Add HardwareInterrupt2 for ARM

2017-09-11 Thread evan . lloyd
From: EvanLloyd This v3 series of patches corrects a problem detected on the ARM Juno platform that is actually generic (at least to ARM GIC platforms). The HardwareInterrupt protocol had no means of handling characteristics like Edge/Level triggered and polarity. A new

[edk2] [PATCH 2/5] EmbeddedPkg: Introduce HardwareInterrupt2 protocol

2017-09-11 Thread evan . lloyd
From: Ard Biesheuvel The existing HardwareInterrupt protocol lacks the means to configure the level/edge and polarity properties of an interrupt. So introduce a new protocol HardwareInterrupt2, and add some new members that allow manipulation of those properties.

Re: [edk2] [PATCH edk2-platforms 07/14] Platform/SynquacerEvalBoard: add PCI support

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:08PM +0100, Ard Biesheuvel wrote: > Wire up the various drivers and libraries for the SynquacerEvalBoard > platform. Also enable the usual PCI suspects: XHCI, SATA and NVME, > and the various bus, partition and file system drivers that we need > to make use of PCIe

[edk2] [PATCH 4/5] ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type

2017-09-11 Thread evan . lloyd
From: Ard Biesheuvel Utilise the new HardwareInterrupt2 protocol to adjust the Edge/Level characteristics of the Watchdog interrupt. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Signed-off-by: Girish

[edk2] [PATCH 1/5] ArmPkg: Tidy GIC code before changes.

2017-09-11 Thread evan . lloyd
From: Evan Lloyd This change is purely cosmetic, to tidy some code before change. Mods involve: Reflow overlength comments. Split overlength code lines. Make protocol functions STATIC. Remove "Horor vacui" comments. Contributed-under: TianoCore Contribution

[edk2] [PATCH 3/5] ArmPkg/ArmGicDxe: Expose HardwareInterrupt2 protocol

2017-09-11 Thread evan . lloyd
From: Ard Biesheuvel The existing HardwareInterrupt protocol lacked a means to configure the level/edge properties of an interrupt. The new HardwareInterrupt2 protocol introduced this capability. This patch updates the GIC drivers to provide the new interfaces. The

[edk2] [PATCH 5/5] ArmPkg: Tidy up GenericWatchdogDxe.c

2017-09-11 Thread evan . lloyd
From: Evan Lloyd This cosmetic change has no functional content. It adjusts comment oddities, etc, noticed during previous work. Specific changes are: Re-order #includes Use ns consistently (always "100ns" not sometimes "100 nS") Reflow overlength comments

Re: [edk2] [patch 1/3] MdeModulePkg/PartitionDxe: Don't use non-constant expression in array

2017-09-11 Thread Ni, Ruiyu
Dandan, Thanks for fixing this. But, why not write code as below? EFI_LBA DescriptorLBAs[4]; DescriptorLBA[0] = 256; DescriptorLBA[1] = EndLBA - 256; ... Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Monday, September 11, 2017 1:45 PM > To: edk2-devel@lists.01.org >

Re: [edk2] StartImage() return value an error or return code ?

2017-09-11 Thread Gao, Liming
Per UEFI spec, StartImage() has the optional output ExitData. If ExitData is not NULL, the exit status will be from the image. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >David F. >Sent: Friday, September 08, 2017 2:53 PM >To:

Re: [edk2] [PATCH edk2-platforms 14/14] Platform/Synquacer: incorporate NOR flash and variable drivers

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:15PM +0100, Ard Biesheuvel wrote: > Wire up the non-volatile EFI variable store support, by switching from > the emulation driver to the real one, and enabling the prerequisite > FTW and NOR flash drivers. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH 1/1] StdLib/EfiSocketLib: Fix ABI mismatch for 2 event functions

2017-09-11 Thread Palmer, Thomas
Daryl? I haven't seen a comment on this patch since 8/10 Regards, Thomas Palmer "I have only made this letter longer because I have not had the time to make it shorter" - Blaise Pascal -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Thursday,

Re: [edk2] [PATCH edk2-platforms 13/14] Silicon/Socionext: add driver for SPI NOR flash

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:14PM +0100, Ard Biesheuvel wrote: > This imports the driver sources provided by Socionext for the FIP006 > SPI NOR flash device found on Synquacer SoCs. It has been slightly > tweaked to bring it up to date with the changes made on the EDK2 side > since it was forked.

Re: [edk2] [PATCH edk2-platforms 12/14] Silicon/Synquacer: add NorFlashPlatformLib implementation

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:13PM +0100, Ard Biesheuvel wrote: > Add the platform glue for the NOR flash driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH edk2-platforms 09/14] Platform/SynquacerEvalBoard: add NETSEC driver

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:10PM +0100, Ard Biesheuvel wrote: > Add the NETSEC driver to the SynquacerEvalBoard platform. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH edk2-platforms 11/14] Silicon/Synquacer: add device tree support for eval board

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:12PM +0100, Ard Biesheuvel wrote: > Add a device tree description of the Synquacer SoC, and expose it for > the SynquacerEvalBoard platforms. This includes the menu option in the > UEFI boot menu to switch between ACPI and DT. > > Contributed-under: TianoCore

Re: [edk2] [PATCH edk2-platforms 10/14] Silicon/Synquacer: add ACPI support

2017-09-11 Thread Leif Lindholm
On Fri, Sep 08, 2017 at 07:23:11PM +0100, Ard Biesheuvel wrote: > Enable ACPI support for the SynquacerEvalBoard platform: add descriptions > of the CPUs, the GIC, the serial port, the timers and the PCIe RCs, > including the MSI routing via the GICv3 ITS. > > Note that PCIe support is limited to

[edk2] [PATCH] ArmPkg/PlatformBootManagerLib: process pending capsules

2017-09-11 Thread Ard Biesheuvel
Process any capsule HOBs that were left for us by CapsulePei. This involves calling ProcessCapsules() twice, as explained in the comment in DxeCapsuleLibFmp [sic]. 1) The first call must be before EndOfDxe. The system capsules is processed. If device capsule FMP protocols are exposted at this

Re: [edk2] [PATCH 4/5] MdeModulePkg/PartitionDxe: don't divide 64-bit values with C operators

2017-09-11 Thread Bi, Dandan
Hi Laszlo, When do you plan to push this patch? IA32 build is blocked for this issue now. Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Sunday, September 10, 2017 8:13 AM To: edk2-devel-01

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Change Reset Type

2017-09-11 Thread lushifex
Change Reset Type according to different Board. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- .../Board/BensonGlacier/BoardInitPostMem/BoardInit.c | 7 +++ .../Board/BensonGlacier/BoardInitPostMem/BoardInit.h

[edk2] [PATCH 2/3] ArmVirtPkg/ArmVirtQemu: port HTTP_BOOT_ENABLE from OvmfPkg

2017-09-11 Thread Laszlo Ersek
* From commit ab44a6e833fa ("OvmfPkg: Add HttpBoot support", 2015-08-23): - introduce HTTP_BOOT_ENABLE build define - resolve HttpLib class - include NetworkPkg drivers DnsDxe, HttpDxe, HttpBootDxe * From commit 1a85139d9eac ("OvmfPkg: Build HTTP utilities driver", 2015-08-28): -

[edk2] [PATCH 0/3] ArmVirtPkg: add HTTP_BOOT_ENABLE and UsbMassStorageDxe

2017-09-11 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: armvirt_http_usbstor I was... ugh... experimenting with "stuff" over the weekend, and realized these were missing. Cc: Ard Biesheuvel Thanks Laszlo Laszlo Ersek (3): ArmVirtPkg: don't build the network stack

[edk2] [PATCH 3/3] ArmVirtPkg/ArmVirtQemu: include UsbMassStorageDxe

2017-09-11 Thread Laszlo Ersek
This is needed for recognizing QEMU's "usb-storage" device model. Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/ArmVirtQemu.dsc | 1 +

Re: [edk2] [PATCH 0/5] MdeModulePkg, UefiCpuPkg, OvmfPkg: lower some DEBUGs from ERROR level

2017-09-11 Thread Laszlo Ersek
On 09/04/17 22:13, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: degrade_non_errors > > Building OVMF with > > --pcd=gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel=0x8000 > > (i.e., DEBUG_ERROR only) exposes a smattering of DEBUG messages that are > logged

Re: [edk2] [PATCH 0/2] MdePkg, OvmfPkg: fix IoWriteFifo8(), and print debug messages with it

2017-09-11 Thread Laszlo Ersek
On 09/04/17 17:57, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: debugprint_iofifo > > The first patch (for MdePkg) fixes an assembly language operand ordering > oversight in the unrolled / SEV implementations of IoWriteFifoXX(). > > The second patch makes OvmfPkg

Re: [edk2] [PATCH 1/1] StdLib/EfiSocketLib: Fix ABI mismatch for 2 event functions

2017-09-11 Thread Daryl McDaniel (EDK2 Lists)
Thomas, I'll take a look at this. Have you determined what the impact of changing the signature of the functions (adding/removing parameters) will be? Can it adversely affect existing code? Sincerely, Daryl McDaniel > -Original Message- > From: Palmer, Thomas

Re: [edk2] [PATCH 1/1] StdLib/EfiSocketLib: Fix ABI mismatch for 2 event functions

2017-09-11 Thread Palmer, Thomas
Hi Daryl, The gist of the patch is to have these callbacks match the EFI_EVENT_NOTIFY when compiled in GCC/DEBUG. The EFIAPI token's absence is not noticed in Visual Studio builds b/c VS builds everything with Microsoft's ABI. However, with GCC/DEBUG the EFIAPI token is critical