[edk2] [Patch] BaseTools: Fix the bug to display the single SKUID info

2018-02-20 Thread Yonghong Zhu
when defined SKUID_IDENTIFIER = DEFAULT|TEST in DSC [Defines] section, per spec it means current SKUID is single, the bug is build report print both DEFAULT and TEST info, it should only print TEST. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu

Re: [edk2] [PATCH v2 05/10] MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message

2018-02-20 Thread Laszlo Ersek
On 02/20/18 00:30, Andrew Fish wrote: > > >> On Feb 19, 2018, at 11:23 AM, Laszlo Ersek wrote: >> >> On 02/19/18 19:59, Ard Biesheuvel wrote: >>> On 9 February 2018 at 04:16, Ruiyu Ni wrote: + DEBUG ((DEBUG_INFO, "DXE ResetSystem2: Reset call depth =

[edk2] [PATCH 2/3] ArmVirtPkg: switch to DXE runtime version of DebugLib where appropriate

2018-02-20 Thread Ard Biesheuvel
Switch all users of ArmVirt.dsc.inc to the new DebugLib implementation that was created especially for DXE_RUNTIME_DRIVER modules, ensuring that DEBUG() calls do not touch the UART at runtime. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 0/3] Create UART DebugLib implementation for runtime drivers

2018-02-20 Thread Ard Biesheuvel
Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message") broke the DEBUG build for systems using a MMIO mapped UART for DEBUG output. Instead of patching it up locally, let's fix this issue once and for all, by creating a UART DebugLib implementation that does the right

[edk2] [PATCH 1/3] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-20 Thread Ard Biesheuvel
Introduce a variant of BaseDebugLibSerialPort that behaves correctly wrt to use of the serial port after ExitBootServices(). Also, it uses fixed PCDs for all the parameterized values so that no calls into PcdLib are made at runtime. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH 3/3] MdePkg/BaseDebugLibSerialPort: blacklist for use by DXE runtime drivers

2018-02-20 Thread Ard Biesheuvel
BaseDebugLibSerialPort is not suitable for use by DXE_RUNTIME_DRIVER modules, so blacklist it for use by such modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH 1/3] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-20 Thread Leif Lindholm
On Tue, Feb 20, 2018 at 11:05:22AM +, Ard Biesheuvel wrote: > +/** > + Prints an assert message containing a filename, line number, and > description. > + This may be followed by a breakpoint or a dead loop. > + > + Print a message of the form "ASSERT (): > \n" > + to the debug output

Re: [edk2] [PATCH 3/3] MdePkg/BaseDebugLibSerialPort: blacklist for use by DXE runtime drivers

2018-02-20 Thread Leif Lindholm
On Tue, Feb 20, 2018 at 11:05:24AM +, Ard Biesheuvel wrote: > BaseDebugLibSerialPort is not suitable for use by DXE_RUNTIME_DRIVER > modules, so blacklist it for use by such modules. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 1/2] Platform/Hisilicon/HiKey960: add boot options

2018-02-20 Thread Laszlo Ersek
Hi, On 02/15/18 16:14, Haojian Zhuang wrote: > Add four boot options in emu variable region. They are > "Boot on SD", "Grub", "Android Boot" and "Android Fastboot". > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang > --- >

Re: [edk2] [PATCH 1/3] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-20 Thread Leif Lindholm
On Tue, Feb 20, 2018 at 08:20:48AM -0800, Andrew Fish wrote: > > On Feb 20, 2018, at 6:16 AM, Leif Lindholm wrote: > > > > On Tue, Feb 20, 2018 at 11:05:22AM +, Ard Biesheuvel wrote: > >> +/** > >> + Prints an assert message containing a filename, line number, and

Re: [edk2] [PATCH 1/3] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-20 Thread Andrew Fish
> On Feb 20, 2018, at 6:16 AM, Leif Lindholm wrote: > > On Tue, Feb 20, 2018 at 11:05:22AM +, Ard Biesheuvel wrote: >> +/** >> + Prints an assert message containing a filename, line number, and >> description. >> + This may be followed by a breakpoint or a dead

Re: [edk2] [PATCH 1/3] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-20 Thread Laszlo Ersek
On 02/20/18 12:05, Ard Biesheuvel wrote: > Introduce a variant of BaseDebugLibSerialPort that behaves correctly wrt > to use of the serial port after ExitBootServices(). Also, it uses fixed > PCDs for all the parameterized values so that no calls into PcdLib are > made at runtime. > >

Re: [edk2] [PATCH 2/3] ArmVirtPkg: switch to DXE runtime version of DebugLib where appropriate

2018-02-20 Thread Laszlo Ersek
On 02/20/18 12:05, Ard Biesheuvel wrote: > Switch all users of ArmVirt.dsc.inc to the new DebugLib implementation > that was created especially for DXE_RUNTIME_DRIVER modules, ensuring > that DEBUG() calls do not touch the UART at runtime. > > Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 3/3] MdePkg/BaseDebugLibSerialPort: blacklist for use by DXE runtime drivers

2018-02-20 Thread Laszlo Ersek
On 02/20/18 15:22, Leif Lindholm wrote: > On Tue, Feb 20, 2018 at 11:05:24AM +, Ard Biesheuvel wrote: >> BaseDebugLibSerialPort is not suitable for use by DXE_RUNTIME_DRIVER >> modules, so blacklist it for use by such modules. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >>

Re: [edk2] [PATCH 1/3] MdePkg: introduce DxeRuntimeDebugLibSerialPort

2018-02-20 Thread Kinney, Michael D
Ard, Both FixedAtBuild and PatchableInModule are safe at runtime. Should not limit to only FixedAtBuild. It is also possible to use Dynamic and DynamicEx from a runtime driver as long as the PCD values are retrieved before ExitBootServices(). Mike > -Original Message- > From:

[edk2] [PATCH edk2-platforms v2 6/7] Platform/NinetySixBoards: add core driver for LS connector and config

2018-02-20 Thread Ard Biesheuvel
This adds a driver that manages the 96boards LS connector, i.e, it installs a HII page to configure the type of mezzanine that is installed in the slot, and it exposes this information via the LS connector protocol. It is also in charge of applying the overlay to the platform device tree at end of

[edk2] [PATCH edk2-platforms v2 0/7] Add Secure96 mezzanine support

2018-02-20 Thread Ard Biesheuvel
Almost a complete rewrite of the v1. I omitted the patches that add SPI and I2C DT nodes to the SynQuacer DTS. I did include the v2 of the Atmel AtSha204a driver, since the latter patches depend on it. This version implements a complete split between the generic 96boards LS connector support and

[edk2] [PATCH edk2-platforms v2 5/7] Platform/NinetySixBoards: add a driver for the Secure96 mezzanine board

2018-02-20 Thread Ard Biesheuvel
Add a driver that describes the Secure96 mezzanine board, and exposes both the information required to describe it to the OS using a DT overlay, and to describe it to UEFI itself. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH edk2-platforms v2 3/7] Platform/NinetySixBoards: introduce I2C driver

2018-02-20 Thread Ard Biesheuvel
Implement a I2C DXE driver that wires up the I2C devices exposed by a 96boards mezzanine into the EDK2 I2C stack. Note that this requires the platform to identify its I2C master implementations using special GUIDs-as-protocols. It also assumes [for now] that I2C buses are not shared between the

[edk2] [PATCH edk2-platforms v2 1/7] Silicon/Atmel: add support for AtSha204a RNG

2018-02-20 Thread Ard Biesheuvel
This adds support for using the random number generator in the Atmel AtSha204a over I2C. Other functionality of the chip is currently unsupported. Note that the the I2C support in this device essentially violates the protocol layering, by requiring that the device is woken up by driving SDA low

[edk2] [PATCH edk2-platforms v2 2/7] Platform/NinetySixBoards: introduce package and mezzanine protocol

2018-02-20 Thread Ard Biesheuvel
Introduce the mezzanine protocol and the 96boards package defining the PCDs and GUIDs that may be used by implementations of the protocol. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH edk2-platforms v2 4/7] Platform/NinetySixBoards: introduce LsConnector protocol

2018-02-20 Thread Ard Biesheuvel
Introduce a protocol describing the presence of a 96boards LS connector, and identifying the type of mezzanine that has been installed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH edk2-platforms v2 7/7] Platform/Socionext/DeveloperBox: add 96boards mezzanine support

2018-02-20 Thread Ard Biesheuvel
Wire up the various drivers for the 96boards LS connector and the optional Secure96 mezzanine board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc| 34

Re: [edk2] [PATCH 3/3] MdePkg/BaseDebugLibSerialPort: blacklist for use by DXE runtime drivers

2018-02-20 Thread Kinney, Michael D
I do not agree with this change. If the PCDs that describe the UART are for a UART that is owned by the FW and hidden from the OS, then this lib can work well at runtime. Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, February 20, 2018 9:00 AM