Re: [edk2] [PATCH v2 1/9] OvmfPkg/TlsAuthConfigLib: configure trusted cipher suites for HTTPS boot

On Wed, Apr 11, 2018 at 12:42:39PM +0200, Laszlo Ersek wrote: > Read the list of trusted cipher suites from fw_cfg and to store it to > EFI_TLS_CA_CERTIFICATE_VARIABLE. > > The fw_cfg file is formatted by the "update-crypto-policies" utility on > the host side, so that the host settings take

Re: [edk2] [PATCH v2 0/9] {Ovmf, Mde, Network, Crypto}Pkg: fixes+features for setting HTTPS cipher suites

Hi Laszlo, In the commit log of patch 0001, "EFI_TLS_CA_CERTIFICATE_VARIABLE" should be "EDKII_HTTP_TLS_CIPHER_LIST_VARIABLE". Others looks good to me. Series Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: Laszlo Ersek

Re: [edk2] [PATCH v2 0/9] {Ovmf, Mde, Network, Crypto}Pkg: fixes+features for setting HTTPS cipher suites

On 04/12/18 09:28, Wu, Jiaxin wrote: > Hi Laszlo, > > In the commit log of patch 0001, "EFI_TLS_CA_CERTIFICATE_VARIABLE" should > be "EDKII_HTTP_TLS_CIPHER_LIST_VARIABLE". Good catch, thanks! > Others looks good to me. > > Series Reviewed-by: Jiaxin Wu Thank you,

Re: [edk2] [PATCH v2 1/9] OvmfPkg/TlsAuthConfigLib: configure trusted cipher suites for HTTPS boot

On 04/12/18 09:08, Gary Lin wrote: > On Wed, Apr 11, 2018 at 12:42:39PM +0200, Laszlo Ersek wrote: >> Read the list of trusted cipher suites from fw_cfg and to store it to >> EFI_TLS_CA_CERTIFICATE_VARIABLE. >> >> The fw_cfg file is formatted by the "update-crypto-policies" utility on >> the host

Re: [edk2] [PATCH v2 1/9] OvmfPkg/TlsAuthConfigLib: configure trusted cipher suites for HTTPS boot

On Thu, Apr 12, 2018 at 10:49:15AM +0200, Laszlo Ersek wrote: > On 04/12/18 09:08, Gary Lin wrote: > > On Wed, Apr 11, 2018 at 12:42:39PM +0200, Laszlo Ersek wrote: > >> Read the list of trusted cipher suites from fw_cfg and to store it to > >> EFI_TLS_CA_CERTIFICATE_VARIABLE. > >> > >> The fw_cfg

Re: [edk2] [PATCH v2 1/2] CryptoPkg/OpensslLib: Fix the documentation about submodule update

Hello Qin, On 04/12/18 05:08, Long Qin wrote: > This patch is to drop "--remote" option from the original suggested > submodule update command ("$ git submodule update --recursive > --remote") in HOWTO document. > > "--remote" option will integrate changes from the upstream subproject > with the

[edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

Background description: In SmmProfileInternal.h, ECC check tool report an issue at line 103. Detailed ECC Error info:Variable definition appears in header file. Include files should contain only public or only private data and cannot contain code or define data variables ECC report similar issues

Re: [edk2] [PATCH v2 0/9] {Ovmf, Mde, Network, Crypto}Pkg: fixes+features for setting HTTPS cipher suites

On 04/12/18 08:32, Long, Qin wrote: > Hi, Laszlo, > > The updated patch series looks good to me. > > Reviewed-by: Long Qin Many thanks; I'll fix up the commit messages as suggested by Jiaxin and Gary, and push the series sometime later today. Thanks! Laszlo

Re: [edk2] [PATCH 09/10] ArmVirtPkg/PlatformHasAcpiDtDxe: depend on gEfiVariableArchProtocolGuid

On 04/12/18 08:28, Ard Biesheuvel wrote: > On 12 April 2018 at 02:55, Laszlo Ersek wrote: >> PlatformHasAcpiDtDxe consumes the DynamicHii PCD called >> "gArmVirtTokenSpaceGuid.PcdForceNoAcpi". The PcdGetBool() library call >> terminates in gRT->GetVariable(), in the

[edk2] [PATCH edk2-platforms] Silicon/SynQuacer/NetsecDxe: fix buffer allocation bug

The receive buffers of the NETSEC driver are owned by the driver itself (as opposed to the protocol client in the case of the transmit path), and so the descriptors and the buffers (which are of a fixed size) are allocated in one go. The idea is that the 'buffer' member of the descriptor should

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

Hello Dandan, On 04/12/18 10:50, Dandan Bi wrote: > Background description: > In SmmProfileInternal.h, ECC check tool report an issue at line 103. > Detailed ECC Error info:Variable definition appears in header file. > Include files should contain only public or only private data and > cannot

Re: [edk2] [PATCH v2 1/2] CryptoPkg/OpensslLib: Fix the documentation about submodule update

Ah, "it's wrong here" means "the existence of "--remote" in original suggested command is wrong". "It's important" looks also make sense to address the "update" goal. I can update that, if old message will cause confusion. Best Regards & Thanks, LONG, Qin -Original Message- From:

Re: [edk2] [PATCH v2 1/9] OvmfPkg/TlsAuthConfigLib: configure trusted cipher suites for HTTPS boot

On Thu, Apr 12, 2018 at 11:43:35AM +0200, Laszlo Ersek wrote: > On 04/12/18 11:10, Gary Lin wrote: > > On Thu, Apr 12, 2018 at 10:49:15AM +0200, Laszlo Ersek wrote: > >> On 04/12/18 09:08, Gary Lin wrote: > >>> On Wed, Apr 11, 2018 at 12:42:39PM +0200, Laszlo Ersek wrote: > Read the list of

Re: [edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

On 12 April 2018 at 02:55, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: depex_fixes > > ArmVirtQemu boots again, it just took a few more patches than I expected > :) > > Some of these patches will have to be ported to edk2-platforms, I think. > >

Re: [edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

On 12 April 2018 at 11:09, Ard Biesheuvel wrote: > On 12 April 2018 at 02:55, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: depex_fixes >> >> ArmVirtQemu boots again, it just took a few more patches than I expected >>

Re: [edk2] [PATCH 09/10] ArmVirtPkg/PlatformHasAcpiDtDxe: depend on gEfiVariableArchProtocolGuid

On 04/12/18 17:16, Gao, Liming wrote: > Laszlo: > We also have the similar idea that auto appends Variable read or Variable > write protocol. Build tool can know which PCD is configured as DynamicHii. > But, it doesn't know whether this PCD is consumed or produced in the driver > entry point.

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

On 04/12/18 18:47, Kinney, Michael D wrote: > Laszlo, > > I think I would rather see the ECC tool fixed. I didn't dare suggest that, but I agree it's a superior solution. When I tried ECC last time, I was surprised how powerful it was, so if it recognized even this case, that would certainly fit

Re: [edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

On 04/12/18 12:09, Ard Biesheuvel wrote: > On 12 April 2018 at 02:55, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: depex_fixes >> >> ArmVirtQemu boots again, it just took a few more patches than I expected >> :) >> >> Some of these patches will

Re: [edk2] Boot failure for ArmVExpress-FVP-AArch64, CpuArch protocol does not appear to be registered

On 04/12/18 17:02, Gao, Liming wrote: > Laszlo: > On variable storage format are hex, could you submit one bugzillar for it? > I have some idea to simplify its description. We can reuse FV section for > Variable storage. Its FV section is like below. > > [FV.NVStorage] > FileSystemGuid =

Re: [edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

On 04/12/18 19:23, Leif Lindholm wrote: > On Thu, Apr 12, 2018 at 12:09:46PM +0200, Ard Biesheuvel wrote: >> On 12 April 2018 at 02:55, Laszlo Ersek wrote: >>> Repo: https://github.com/lersek/edk2.git >>> Branch: depex_fixes >>> >>> ArmVirtQemu boots again, it just took a few

Re: [edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

On 04/12/18 18:51, Supreeth Venkatesh wrote: > Thanks Laszlo. > It works for me too. Appreciate the testing! Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH edk2-platforms v2 4/6] Platform/ARM/Sgi: add support for virtio block device

From: Daniil Egranov Add the registration of the virtio block device. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov Signed-off-by: Thomas Abraham ---

[edk2] [PATCH edk2-platforms v2 5/6] Platform/ARM/Sgi: add the initial set of acpi tables

From: Daniil Egranov Add the initial version of Acpi tables for the SGI-575 platform which is required to boot the linux kernel up to a busybox prompt. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov

[edk2] [PATCH edk2-platforms v2 6/6] Platform/ARM/Sgi: add initial support for ARM SGI platform

From: Vishwanatha HG Add the initial support for ARM's System Guidance for Infrastructure (SGI) platforms. SGI-575 is the supported platform in this initial implementation and can be extented to include support for upcoming SGI platforms as well. Contributed-under:

[edk2] [PATCH edk2-platforms v2 1/6] Platform/ARM/Sgi: Add Platform library implementation

Add initial SGI platform library support. This includes the virtual memory map and helper functions for platform intialization. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Abraham --- Platform/ARM/SgiPkg/Include/SgiPlatform.h |

[edk2] [PATCH edk2-platforms v2 3/6] Platform/ARM/Sgi: add initial platform dxe driver implementation

From: Daniil Egranov Add a initial platform dxe driver which starts of being almost an empty implemenation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov Signed-off-by: Thomas Abraham

[edk2] [PATCH edk2-platforms v2 2/6] Platform/ARM/Sgi: add NOR flash platform library implementation

From: Vishwanatha HG Add a initial NOR flash driver platform wrapper as part of the platform library. Access to NOR fash 0 is enabled in this initial implementation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vishwanatha HG

[edk2] [PATCH edk2-platforms v2 0/6] Platform/ARM/Sgi: Add Arm's SGI platform support

Changes since v1: - minor update to commit messages Arm CoreLink System Guidance for Infrastructure is a collection of resources to provide a representative view of typical compute subsystems that can be designed and implemented using specific generations of Arm IP. These compute subsystems

Re: [edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

On 04/12/18 15:39, Steve Capper wrote: > On 12 April 2018 at 11:09, Ard Biesheuvel wrote: >> On 12 April 2018 at 02:55, Laszlo Ersek wrote: >>> Repo: https://github.com/lersek/edk2.git >>> Branch: depex_fixes >>> >>> ArmVirtQemu boots again, it

Re: [edk2] [PATCH v2 1/9] OvmfPkg/TlsAuthConfigLib: configure trusted cipher suites for HTTPS boot

(comment/question at the end for Ard and Jordan) On 04/12/18 12:17, Gary Lin wrote: > On Thu, Apr 12, 2018 at 11:43:35AM +0200, Laszlo Ersek wrote: >> On 04/12/18 11:10, Gary Lin wrote: >>> On Thu, Apr 12, 2018 at 10:49:15AM +0200, Laszlo Ersek wrote: On 04/12/18 09:08, Gary Lin wrote: >

Re: [edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

On Thu, Apr 12, 2018 at 12:09:46PM +0200, Ard Biesheuvel wrote: > On 12 April 2018 at 02:55, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/edk2.git > > Branch: depex_fixes > > > > ArmVirtQemu boots again, it just took a few more patches than I expected > > :) > > >

[edk2] derailing into patch style discussion

Since you already have my r-b on the set, I'll pick up the style topic, partly because I'm not sure if I've ever explained my thinking publicly in words that anyone other than Ard understands. On Thu, Apr 12, 2018 at 07:45:19PM +0200, Laszlo Ersek wrote: > > Well, there are a couple of places

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

Laszlo, I think I would rather see the ECC tool fixed. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Thursday, April 12, 2018 2:34 AM > To: Bi, Dandan ; edk2- > de...@lists.01.org > Cc:

Re: [edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

Thanks Laszlo. It works for me too. Supreeth -Original Message- From: Laszlo Ersek Sent: Wednesday, April 11, 2018 7:56 PM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel ; Leif Lindholm ; Steve Capper

Re: [edk2] derailing into patch style discussion

On 04/12/18 20:13, Leif Lindholm wrote: > Since you already have my r-b on the set, I'll pick up the style > topic, partly because I'm not sure if I've ever explained my > thinking publicly in words that anyone other than Ard understands. > > On Thu, Apr 12, 2018 at 07:45:19PM +0200, Laszlo Ersek

Re: [edk2] [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

On 04/12/18 02:55, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: depex_fixes > > ArmVirtQemu boots again, it just took a few more patches than I expected > :) > > Some of these patches will have to be ported to edk2-platforms, I think. > > Cc: Ard Biesheuvel

Re: [edk2] [PATCH] MdeModulePkg/Terminal: Check status of OpenProtocol in BindingStart

Generally, I am ok with the change. But, what is the case for the change? If the new "if condition" is TRUE, the ASSERT above it will happen, so the new "if condition" is for RELEASE build case? And if the code passes Support() check, then seemingly, the "if condition" in Start() will not

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

Thanks Laszlo for the detailed description. I will communicate will ECC owner to see whether ECC tool can be enhanced for these issues firstly. Thank you all. Regards, Dandan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, April 13, 2018 1:51 AM To:

[edk2] [PATCH 1/1] BaseTools: Fix one or more multiply defined symbols found issue

self.Guids update with package Guids will generate multiply defined GUID symbols in AutoGen file Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng ---

Re: [edk2] [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level to DEBUG_INFO

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Wednesday, April 4, 2018 4:39 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Chiu, Chasel ; Chan, Amy

[edk2] [PATCH] MdeModulePkg/Terminal: Check status of OpenProtocol in BindingStart

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Steven Shi Cc: Star Zeng --- MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

Hi Ard, Any comments? Anyway we can modify the code if you insist on using an intermediate CPU IO address space. Thanks, Heyi On Sat, Mar 31, 2018 at 09:37:47AM +0800, Guo Heyi wrote: > Hi Ard, > > Thanks for your time of reviewing the patches. > Please see my opinions below. > > On Fri,

[edk2] [PATCH v1 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries

sometimes just delete it. sometimes the loop needed .values() instead Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 0/2] BaseTools: refactor for code simplification

- remove/replace more None comparisons to conforn to code style - remove/replace .keys() calls to reduce the number of temporary lists made from dictionaries Jaben (2): BaseTools: fix None comparisons BaseTools: refactor and remove un-needed use of .keys() on dictionaries

[edk2] [PATCH v1 1/2] BaseTools: fix None comparisons

when comparing a list/string against None and empty, just compare the object. when comparing against None, dont use !=, ==, <> Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey

Re: [edk2] Boot failure for ArmVExpress-FVP-AArch64, CpuArch protocol does not appear to be registered

Laszlo: On variable storage format are hex, could you submit one bugzillar for it? I have some idea to simplify its description. We can reuse FV section for Variable storage. Its FV section is like below. [FV.NVStorage] FileSystemGuid = gEfiSystemNvDataFvGuid VariableSignatureGuid =

Re: [edk2] [PATCH 09/10] ArmVirtPkg/PlatformHasAcpiDtDxe: depend on gEfiVariableArchProtocolGuid

Laszlo: We also have the similar idea that auto appends Variable read or Variable write protocol. Build tool can know which PCD is configured as DynamicHii. But, it doesn't know whether this PCD is consumed or produced in the driver entry point. If PCD is used in driver entry point, Build

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

If the cases can be listed completely, then it will be better to also add them in the comments for the two GUIDs, then consumer can easily know them. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi, Dandan Sent: Thursday, April

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Good suggestion. Thanks Star. I will cover them in V2 patches. Thanks, Dandan -Original Message- From: Zeng, Star Sent: Thursday, April 12, 2018 2:03 PM To: Bi, Dandan ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Dong, Eric

Re: [edk2] [edk2-platforms Patch V2 3/6] SynQuacer/PlatformFlashAccessLib: Add progress API

On 12 April 2018 at 03:01, Kinney, Michael D wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=801 > > Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. > This allows the platform to inform the user of progress when a > firmware storage device is

Re: [edk2] [PATCH 09/10] ArmVirtPkg/PlatformHasAcpiDtDxe: depend on gEfiVariableArchProtocolGuid

On 12 April 2018 at 02:55, Laszlo Ersek wrote: > PlatformHasAcpiDtDxe consumes the DynamicHii PCD called > "gArmVirtTokenSpaceGuid.PcdForceNoAcpi". The PcdGetBool() library call > terminates in gRT->GetVariable(), in the MdeModulePkg/Universal/PCD/Dxe > driver. Put

Re: [edk2] [PATCH v2 0/9] {Ovmf, Mde, Network, Crypto}Pkg: fixes+features for setting HTTPS cipher suites

Hi, Laszlo, The updated patch series looks good to me. Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, April 11, 2018 6:43 PM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel

Re: [edk2] [edk2-platforms Patch V2 3/6] SynQuacer/PlatformFlashAccessLib: Add progress API

Ard, I agree. I mentioned it in the patch summary. I will add it to the commit log for each patch. Thanks, Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, April 11, 2018 11:18 PM > To: Kinney, Michael D