Re: [edk2] [PATCH edk2-platforms 39/39] Platform/NXP:PCIe enablement for LS2088A RDB

On Fri, Feb 16, 2018 at 02:20:35PM +0530, Meenakshi wrote: > From: Vabhav > > Compilation: Update the fdf, dsc and dec files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > --- >

Re: [edk2] gdb reload-uefi missing EFI_SYSTEM_TABLE_POINTER [was: Source code debugging of OVMF]

On 04/20/18 10:38, Johannes Swoboda wrote: > Hello again, > > Thank you again for taking the time to help me with this. > > On 2018-04-20 17:58, Palmer, Thomas wrote: >> Also, did you start qemu with the "-s" option before you started gdb? > > Unfortunately, I start qemu with -s -S; then, I

Re: [edk2] gdb reload-uefi missing EFI_SYSTEM_TABLE_POINTER [was: Source code debugging of OVMF]

Also, did you start qemu with the "-s" option before you started gdb? Regards, Thomas Palmer “I have only made this letter longer because I have not had the time to make it shorter” - Blaise Pascal -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, April

[edk2] [PATCH v1 00/27] BaseTools refactoring

remove unused code/variables/file move re.compile to eliminate recompiling same expression replace string constants in code with predefined constants (including sets, preferred for "in" testing, and lists of string constants) (include making new constants, sets, and lists) switch dict to

[edk2] [PATCH v1 01/27] BaseTools: Misc - refactor RegEx to minimize multiple compiling

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Misc.py | 16 +++- 1 file changed, 11 insertions(+), 5

[edk2] [PATCH v1 02/27] BaseTools: GenPatchPcdTable - refactor RegEx to minimize multiple compiling

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/GenPatchPcdTable/GenPatchPcdTable.py | 24 1 file changed,

[edk2] [PATCH v1 05/27] BaseTools: Autogen - replace string constants with those from DataType

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 68 ++-- 1 file changed, 34 insertions(+),

[edk2] [PATCH v1 04/27] BaseTools: Workspace - refactor RegEx to minimize multiple compiling

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/DscBuildData.py | 4 +++-

[edk2] [PATCH v1 18/27] BaseTools: Replace PCD type strings with predefined constant

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4 +-- BaseTools/Source/Python/AutoGen/GenC.py

[edk2] [PATCH v1 12/27] BaseTools: remove dict from DscBuildData

the dict is not needed as BaseTools can check the set Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/DscBuildData.py

[edk2] [PATCH v1 20/27] BaseTools: remove duplicate variable

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/DataType.py | 2 -- 1 file changed, 2 deletions(-) diff --git

[edk2] [PATCH v1 07/27] BaseTools: Workspace - refactor GetStructurePcdInfo

the function doesn't use self and can be static defaultdict replaces dict and removes the dict initialization code Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey

[edk2] [PATCH v1 10/27] BaseTools: Remove extra .keys()

Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/GenFds/Fv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH v1 08/27] BaseTools: AutoGen - remove dictionary populated, but never accessed

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [edk2] gdb reload-uefi missing EFI_SYSTEM_TABLE_POINTER [was: Source code debugging of OVMF]

Hello again, Thank you again for taking the time to help me with this. On 2018-04-20 17:58, Palmer, Thomas wrote: Also, did you start qemu with the "-s" option before you started gdb? Unfortunately, I start qemu with -s -S; then, I attach gdb. I know the attaching works because I gdb

[edk2] [PATCH v1 22/27] BaseTools: remove redundant if comparison

inherently python will check string and list for None and having data if in [None, ''] and similar are superflous. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey

[edk2] [PATCH v1 19/27] BaseTools: Replace Binary File type strings with predefined constant

BINARY_FILE_TYPE_FW was 'FW' BINARY_FILE_TYPE_GUID was 'GUID' BINARY_FILE_TYPE_PREEFORM was 'PREEFORM' BINARY_FILE_TYPE_UEFI_APP was 'UEFI_APP' BINARY_FILE_TYPE_UNI_UI was 'UNI_UI' BINARY_FILE_TYPE_UNI_VER was 'UNI_VER' BINARY_FILE_TYPE_LIB was 'LIB' BINARY_FILE_TYPE_PE32 was 'PE32'

[edk2] [PATCH v1 15/27] BaseTools: Share a dictionary instead of keeping multiples

Move a dictionary to a shared location and use from there Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/DataType.py

[edk2] [PATCH v1 13/27] BaseTools: replace string constants used for module types

replace raw strings in the code (note: except UPT) with constants. SUP_MODULE_BASE was 'BASE' SUP_MODULE_SEC was 'SEC' SUP_MODULE_PEI_CORE was 'PEI_CORE' SUP_MODULE_PEIM was 'PEIM' SUP_MODULE_DXE_CORE was 'DXE_CORE' SUP_MODULE_DXE_DRIVER was 'DXE_DRIVER' SUP_MODULE_DXE_RUNTIME_DRIVER was

[edk2] [PATCH v1 17/27] BaseTools: DataType - cleanup list constants

remove unused ones convert lists used for membership testing to sets use shared ones not local ones Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 25/27] BaseTools: AutoGen - use defaultdict to auto initialize

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/GenVar.py | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-)

[edk2] [PATCH v1 27/27] BaseTools: CommonClass - remove unused classes

CommonDataClass/CommonClass has only 1 used class: SkuInfoClass remove all unused classes Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 09/27] BaseTools: AutoGen - remove unused variables.

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/GenMake.py | 2 -- 1 file changed, 2 deletions(-) diff --git

[edk2] [PATCH v1 23/27] BaseTools: AutoGen - use dafultdict instead of dict

since we manually make each entry a set(), just use defaultdict(set) Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 14/27] BaseTools: Define and use a set for common list

share a set for both PEI module types Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++--

[edk2] [PATCH v1 26/27] BaseTools: remove unused MigrationUtilities.py

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/MigrationUtilities.py | 568

[edk2] [PATCH v1 21/27] BaseTools: replace string with predefined constant

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Ecc/Check.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH v1 16/27] BaseTools: Replace EDK Component strings with predefined constant

EDK_COMPONENT_TYPE_LIBRARY was 'LIBRARY' EDK_COMPONENT_TYPE_SECURITY_CORE was 'SECURITY_CORE' EDK_COMPONENT_TYPE_COMBINED_PEIM_DRIVER was 'COMBINED_PEIM_DRIVER' EDK_COMPONENT_TYPE_PIC_PEIM was 'PIC_PEIM' EDK_COMPONENT_TYPE_RELOCATABLE_PEIM was 'RELOCATABLE_PEIM' EDK_COMPONENT_TYPE_BS_DRIVER was

[edk2] [PATCH v1 03/27] BaseTools: Share RegEx between files

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Misc.py | 22 +++-

[edk2] [PATCH v1 24/27] BaseTools: GenFds - simplify testing for Hex number

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/GlobalData.py | 1 + BaseTools/Source/Python/GenFds/FdfParser.py | 9

Re: [edk2] [PATCH edk2-platforms 00/39] NXP: Add support of LS1043, LS1046 and LS2088 SoCs

Allright, that is all the feedback we have to give on this set. Thank you for this contribution. However, for such a large patch set, it would be very much appreciated if you could put v2 on a publicly accessible git branch and include a link in the cover letter. Best Regards, Leif On Fri, Feb

Re: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Update RouteConfig function

I have no opinion / please the 5th. I defer to the experts. Regards, Thomas Palmer "I have only made this letter longer because I have not had the time to make it shorter" - Blaise Pascal -Original Message- From: Bi, Dandan [mailto:dandan...@intel.com] Sent: Friday, April 20, 2018

Re: [edk2] gdb reload-uefi missing EFI_SYSTEM_TABLE_POINTER [was: Source code debugging of OVMF]

Can you check that the arguments for the source and reload-uefi arguments are real files and resolve correctly? Also, remove the "-S" part and try connecting gdb when EDK2 transistions to DXE or BDS Regards, Thomas Palmer "I have only made this letter longer because I have not had the

Re: [edk2] [RFC v2 0/4] Add FmpDevicePkg

Star, Thanks for the feedback. I think the "BuildTime" helps clarify the scope and usage of this PCD. The LowestSupportedVersion name is used in many places. The name of this PCD clarifies that this is the LowestSupportedVersion value provided at the time the FmpDxe module was built and is

Re: [edk2] GenFds issue with multiple paths in PACKAGES_PATH

Sorry for the delay in response on this, got caught up with other tasks. I think the issue was I had WORKSPACE setup incorrectly I had WORKSPACE set as the edk2 directory and multiple directories mapped parallel to edk2 directory in PACKAGES_PATH Multiple of them had the same

Re: [edk2] [RFC v2 0/4] Add FmpDevicePkg

How about: LowestSupportedVersionCheckRequired() LockFmpDeviceAtLockEventGuidRequired() Mike > -Original Message- > From: Yao, Jiewen > Sent: Thursday, April 19, 2018 9:18 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Sean Brogan

Re: [edk2] [RFC v2 0/4] Add FmpDevicePkg

that is also ok, as long as we can know the api returns a state instead of do the work. thank you! Yao, Jiewen > 在 2018年4月21日，上午7:00，Kinney, Michael D 写道： > > How about: > > LowestSupportedVersionCheckRequired() > LockFmpDeviceAtLockEventGuidRequired() > > Mike

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

Star, I did consider a PCD based method and I even prototyped it. It does work. However, it uses the Dynamic PCD memory database as a shared resource between all the FMP modules and depends on the FMP modules to set the PCDs when their SetImage() service is called. Since not all FMP modules

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

Jiewen, Thanks for the reminder. I will add a 32-bit Version field. Mike > -Original Message- > From: Yao, Jiewen > Sent: Thursday, April 19, 2018 9:23 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Sean Brogan ;

Re: [edk2] [PATCH edk2-platforms 34/39] Silicon/NXP: Implement EFI_CPU_IO2_PROTOCOL

On Fri, Feb 16, 2018 at 02:20:30PM +0530, Meenakshi wrote: > From: Vabhav > > NXP SOC has mutiple PCIe RCs,Adding respective implementation of > EFI_CPU_IO2_PROTOCOL to provide Memory Space Read/Write functions > used by generic Host Bridge Driver including correct value

Re: [edk2] gdb reload-uefi missing EFI_SYSTEM_TABLE_POINTER [was: Source code debugging of OVMF]

On 04/20/18 16:54, Johannes Swoboda wrote: > Hello, > > Thank you all for your insights. > > You advised me to use the scripts from [1]. > I did so following this guide [2] (thank you also for putting it back > up!), with the minor adaptions that I made the script > python3-compatible[3], and

Re: [edk2] [PATCH edk2-platforms 35/39] Compilation: Update the fdf, dsc and dec files.

On Fri, Feb 16, 2018 at 02:20:31PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > LS1043A PCIe compilation and update firmware device, > description and declaration files.Defining Embedded Package > PCD which should be at least 20 for 64K PCIe IO size required

Re: [edk2] [PATCH edk2-platforms 36/39] DWC3 : Add DWC3 USB controller initialization driver.

Minor comments below. On Fri, Feb 16, 2018 at 02:20:32PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Add support of DWC3 controller driver which > Performs DWC3 controller initialization and > Register itself as NonDiscoverableMmioDevice > >

Re: [edk2] [PATCH edk2-platforms 37/39] LS2088 : Enable support of USB controller

On Fri, Feb 16, 2018 at 02:20:33PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Enable support of USB drives on ls2088 board. > LS2088 has DWC3 controller > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal

Re: [edk2] [PATCH edk2-platforms 38/39] Platform/NXP:PCIe enablement for LS1046A RDB

On Fri, Feb 16, 2018 at 02:20:34PM +0530, Meenakshi wrote: > From: Vabhav > > Compilation: Update the fdf, dsc and dec files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > --- >

Re: [edk2] [PATCH edk2-platforms 32/39] Silicon/NXP: Implement PciSegmentLib to support multiple RCs

>-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Friday, April 20, 2018 12:57 AM >To: Meenakshi Aggarwal >Cc: ard.biesheu...@linaro.org; edk2-devel@lists.01.org; Udit Kumar >; Varun Sethi ;

Re: [edk2] [PATCH edk2-platforms 33/39] Silicon/NXP: Implement PciHostBridgeLib support

On 16 February 2018 at 09:50, Meenakshi wrote: > From: Vabhav > > Implement the library that exposes the PCIe root complexes to the > generic PCI host bridge driver,Putting SoC Specific low level init > code for the RCs. > > Contributed-under:

Re: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Update RouteConfig function

Thanks for the updating. These changes make sense. Reviewed-by: Dandan Bi for this patch series. But the Spec seems not to be clear enough. When looking into details about the "progress" parameter in EFI HII Configuration Routing Protocol and

Re: [edk2] [PATCH edk2-platforms 34/39] Silicon/NXP: Implement EFI_CPU_IO2_PROTOCOL

On 16 February 2018 at 09:50, Meenakshi wrote: > From: Vabhav > > NXP SOC has mutiple PCIe RCs,Adding respective implementation of > EFI_CPU_IO2_PROTOCOL to provide Memory Space Read/Write functions > used by generic Host Bridge Driver including

Re: [edk2] [PATCH 1/1] OvmfPkg/README: add HTTPS Boot

On 04/19/18 11:55, Gary Lin wrote: > Add the new section for HTTPS Boot. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gary Lin

Re: [edk2] [PATCH v3 1/2] EmbeddedPkg: add platform boot manager protocol

Hello Haojian, On 04/19/18 12:42, Haojian Zhuang wrote: > Create the PlatformBootManagerProtocol that is used to add > predefined boot options in platform driver. This interface > will be used in ArmPkg/PlatformBootManagerLib. > > Cc: Laszlo Ersek > Cc: Leif Lindholm

Re: [edk2] Source code debugging of OVMF

Hello Brian, Unfortunately, if I understand it correctly, this page explains how to debug efi-apps (where gdb can simply load the efi-file to load the symbols), but this isn't applicable for the ovmf.fd-file itself; gdb refuses to open it. However, this will be of help when I'll look at an

Re: [edk2] [PATCH edk2-platforms 32/39] Silicon/NXP: Implement PciSegmentLib to support multiple RCs

On Fri, Apr 20, 2018 at 06:40:27AM +, Vabhav Sharma wrote: > > > >-Original Message- > >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > >Sent: Friday, April 20, 2018 12:57 AM > >To: Meenakshi Aggarwal > >Cc: ard.biesheu...@linaro.org;

Re: [edk2] [PATCH 4/4] ArmPlatformPkg: add PL011 UART runtime debug driver

Leif, Ard When do you plan to push this patch? Alexei. From: edk2-devel on behalf of Leif Lindholm Sent: 15 March 2018 12:49:27 To: Ard Biesheuvel Cc: eric.d...@intel.com; edk2-devel@lists.01.org;

Re: [edk2] [PATCH v3 2/2] ArmPkg/PlatformBootManagerLib: load platform boot options

On 04/19/18 12:42, Haojian Zhuang wrote: > Make platform driver to create predefined boot options and related > hot keys. > > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix AddLoadOptionVariable docs/prototype

Ping -- can I get a review for this please; it's a trivial patch. Thanks Laszlo On 04/17/18 11:30, Laszlo Ersek wrote: > Clean up the leading comment and the prototype of > EfiBootManagerAddLoadOptionVariable(): > > - the function may modify Option on output, annotate the parameter with > OUT

Re: [edk2] [PATCH edk2-platforms 33/39] Silicon/NXP: Implement PciHostBridgeLib support

My only comment in addition to Ard's comments/questions: Use same endianness handling here as for preceding patches? / Leif On Fri, Feb 16, 2018 at 02:20:29PM +0530, Meenakshi wrote: > From: Vabhav > > Implement the library that exposes the PCIe root complexes to the

[edk2] gdb reload-uefi missing EFI_SYSTEM_TABLE_POINTER [was: Source code debugging of OVMF]

Hello, Thank you all for your insights. You advised me to use the scripts from [1]. I did so following this guide [2] (thank you also for putting it back up!), with the minor adaptions that I made the script python3-compatible[3], and applied the patches mentioned in [2] manually. I assume