[edk2] [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support

2018-06-19 Thread Chris Co
From: Chris Co This patch adds a build option for invoking GCC49 ARM cross compiler in the Windows environment to build firmware for Windows 10 IoT devices using NXP i.MX6 and i.MX7 SoCs. In addition, this build option targets the Microsoft ASL compiler instead of iasl. The Microsoft ASL

[edk2] [PATCH v1 0/1] BaseTools/tools_def: Add WINGCC49 support

2018-06-19 Thread Chris Co
REF: https://github.com/christopherco/edk2/tree/wingcc_build This patch adds a build option for invoking GCC49 ARM cross compiler in the Windows environment to build firmware for Windows 10 IoT devices using NXP i.MX6 and i.MX7 SoCs. In addition, this build option targets the Microsoft ASL

Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***

2018-06-19 Thread Achin Gupta
Hi Jiewen, On Mon, Jun 18, 2018 at 03:12:46PM +, Yao, Jiewen wrote: > Yes. I think so. > > However, I found the V3 just contains partial of the patch. It is hard to > find some V2 and some V3. > Also this series includes multiple package. We need different package > maintainer to push

Re: [edk2] [PATCH] EmbeddedPkg/GdbSerialLib: avoid left shift of negative quantity

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 00:51, Laszlo Ersek wrote: > On 06/18/18 23:57, Leif Lindholm wrote: >> On Mon, Jun 18, 2018 at 10:49:18PM +0200, Ard Biesheuvel wrote: >>> Clang complains about left shifting a negative value being undefined. >> >> As well it should. >> >>>

[edk2] [patch 0/9] Add new Perf macros

2018-06-19 Thread Dandan Bi
Add a group of new Perf macros in performance library for performance logging. Which will simplify the usage model of performance measurement. And also introduce new control functionality to disable different perf types. Patch 1-2: Add a new internal protocol PERFORMANCE_MEASUREMENT_PROTOCOL,

Re: [edk2] [Patch] BaseTool: Fixed the bug of Boolean Hii Pcd packing.

2018-06-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Thursday, June 14, 2018 11:01 AM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTool: Fixed the bug of Boolean Hii Pcd packing. > >When packing HiiPcd into

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib ARM: fix Mva to use idx instead of table base

2018-06-19 Thread Chris Co
Hi, Just checking if there is anything needed on my end to get this patch merged in. Chris > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, April 19, 2018 5:30 AM > To: Chris Co > Cc: Leif Lindholm ; edk2-devel@lists.01.org > Subject: Re: [PATCH] ArmPkg/ArmMmuLib ARM: fix

Re: [edk2] [Patch] FDF Spec: clean up the and usage in spec

2018-06-19 Thread Zhu, Yonghong
Yes, I will separate it into two. Best Regards, Zhu Yonghong -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, June 19, 2018 8:33 PM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Kinney, Michael D ; Shaw, Kevin W ; Gao, Liming Subject: Re:

[edk2] [Patch V2] FDF Spec: clean up the and usage in spec

2018-06-19 Thread Yonghong Zhu
::= {"PCD(" ")"} {} {} ::= {} {"$(NAMED_GUID)"} Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 3_edk_ii_fdf_file_format/32_fdf_definition.md | 5

[edk2] [PATCH v2 1/2] ArmPkg/ArmScmiDxe: Fix ASSERT error in SCMI DXE

2018-06-19 Thread Girish Pathak
This change fixes a bug in the SCMI DXE which is observed with the upcoming release of the SCP firmware. The PROTOCOL_ID_MASK (0xF) which is used to generate an index in the ProtocolInitFxns is wrong because protocol ids can be anywhere in 0x10 - 15 or 0x80 - FF range. This mask generates the

Re: [edk2] [PATCH] EmbeddedPkg/GdbSerialLib: avoid left shift of negative quantity

2018-06-19 Thread Leif Lindholm
On Tue, Jun 19, 2018 at 02:51:41PM +0200, Laszlo Ersek wrote: > On 06/19/18 11:54, Leif Lindholm wrote: > > On Tue, Jun 19, 2018 at 12:51:49AM +0200, Laszlo Ersek wrote: > >> On 06/18/18 23:57, Leif Lindholm wrote: > >>> On Mon, Jun 18, 2018 at 10:49:18PM +0200, Ard Biesheuvel wrote: > Clang

[edk2] [PATCH v2 2/2] ArmPkg/ArmScmiDxe: Dynamically allocate buffer for protocol ids

2018-06-19 Thread Girish Pathak
Dynamically allocate the buffer to receive the SCMI protocol list. This makes MAX_PROTOCOLS redundant, so it is removed. It also fixes one minor code alignment issue and removes an unused macro PROTOCOL_MASK. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak

[edk2] [PATCH v2 0/2] ArmPkg/ArmScmiDxe: Fix a bug uncovered with the new SCP firmware

2018-06-19 Thread Girish Pathak
This patch series addresses comments on the original https://github.com/girishpathak/edk2/tree/281_scmi_fix_v1 This series fixes a bug in the ArmScmiDxe which was revealed while testing with the new SCP firmware. The changes can be seen at

Re: [edk2] [PATCH] Silicon/NXP/Pcf8563RealTimeClockLib: add rtc device initialization

2018-06-19 Thread Masahisa Kojima
Hi Ard, > So could we simply return EPOCH_BASE/1/1 0:0:0 in case the VL bit is > set? That allows the time/date commands to work right? Then, it is up > to the user to set the correct time and data, and the VL bit will > remain set until they do so. Yes, I can boot and set time/date correctly. I

Re: [edk2] [PATCH v3] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-19 Thread Zeng, Star
With + // + // Track the state so that the PCI attributes that were modified + // can be restored to the original value later. Updated to + // + // Track the state so that the PCI attributes that were modified + // can be restored to the original value later. + // Reviewed-by: Star Zeng

[edk2] [patch 5/9] MdeModulePkg: Update performance library instances

2018-06-19 Thread Dandan Bi
Update the performance library instances in MdeModulePkg to implement the APIs used for new added Perf macros. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 664

[edk2] [patch 7/9] MdeModulePkg: Use new added Perf macros

2018-06-19 Thread Dandan Bi
Replace old Perf macros with the new added ones. Cc: Liming Gao Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 7 + MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c|

[edk2] [patch 8/9] SecurityPkg: Use new added Perf macros

2018-06-19 Thread Dandan Bi
Replace old Perf macros with the new added ones. Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../DxeRsa2048Sha256GuidedSectionExtractLib.c| 16 .../PeiRsa2048Sha256GuidedSectionExtractLib.c

[edk2] [patch 2/9] MdeModulePkg: Update Performance instances to use new protocol

2018-06-19 Thread Dandan Bi
Update Update Performance instances in MdeModulePkg to use new PerformanceMeasurement protocol. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 325 +---

[edk2] [patch 1/9] MdeModulePkg: Add PERFORMANCE_MEASUREMENT_PROTOCOL

2018-06-19 Thread Dandan Bi
Add PerformanceMeasurement protocol to log performance info. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdeModulePkg/Include/Guid/PerformanceMeasurement.h | 91 ++ MdeModulePkg/MdeModulePkg.dec

[edk2] [patch 3/9] MdePkg/PerformanceLib.h: Add new Perf macros

2018-06-19 Thread Dandan Bi
1. Add new Perf macros for performance measurement and related APIs and definitions in Performance library class. 2. Update NULL performance library instance in MdePkg. Cc: Liming Gao Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi ---

[edk2] [patch 6/9] ShellPkg/dp: Update dp tool to parse new Perf record

2018-06-19 Thread Dandan Bi
Since performance library instances have been updated to create new FPDT records for new Perf macros. So enhance dp tool to parse the new FPDT records. Enhancement mainly includes: 1. parse the single records for PERF_EVENT macro 2. Parse the new added FPDT_DUAL_GUID_STRING_EVENT_RECORD Cc:

[edk2] [patch 9/9] UefiCpuPkg: Use new added Perf macros

2018-06-19 Thread Dandan Bi
Replace old Perf macros with the new added ones. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[edk2] [patch 4/9] MdeModulePkg/ExtendedFirmwarePerf: Remove PerfId definitions

2018-06-19 Thread Dandan Bi
Remove the definitions of performance identifier since they have been added into PerformanceLib.h. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Include/Guid/ExtendedFirmwarePerformance.h | 25 --

Re: [edk2] [PATCH] Silicon/NXP/Pcf8563RealTimeClockLib: add rtc device initialization

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 03:09, Masahisa Kojima wrote: > Hi Ard, > > This issue can be divided into following two issues. > > 1) Assertion occurs during boot time in DEBUG build, it depends on > the uninitialized RTC device state(~70%) > 2) SetTime() fails if GetTime() fails > > For issue 1), we

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-19 Thread Sami Mujawar
Hi Star, My sincere apologies for getting your name wrong. For some reason my email client displays your name as 'surname, name'. However, it is still my fault. I will ensure I address you correctly in the future. Hi Lazlo, Thanks for letting me know. Regards, Sami Mujawar -Original

[edk2] [Patch] FDF Spec: clean up the and usage in spec

2018-06-19 Thread Yonghong Zhu
::= {"PCD(" ")"} {} {} ::= {} {"$(NAMED_GUID)"} Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 2_fdf_design_discussion/26_[capsule]_sections.md | 4 +--

Re: [edk2] [PATCH v1] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-19 Thread Sami Mujawar
Hi Star, Thank you for your feedback. I will submit a new patch with the issues addressed. Kindly ignore the v2 patch. Regards, Sami Mujawar -Original Message- From: Zeng, Star Sent: 19 June 2018 03:53 AM To: Sami Mujawar ; edk2-devel@lists.01.org Cc: ruiyu...@intel.com; Stephanie

[edk2] [patch] SignedCapsulePkg/SystemFirmwareUpdateDxe: Fix ECC issues

2018-06-19 Thread Dandan Bi
Make function comments align with functions. Cc: Star Zeng Cc: Michael D Kinney Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 5 + 1 file changed, 5 insertions(+)

Re: [edk2] [PATCH] EmbeddedPkg/GdbSerialLib: avoid left shift of negative quantity

2018-06-19 Thread Laszlo Ersek
On 06/19/18 11:54, Leif Lindholm wrote: > On Tue, Jun 19, 2018 at 12:51:49AM +0200, Laszlo Ersek wrote: >> On 06/18/18 23:57, Leif Lindholm wrote: >>> On Mon, Jun 18, 2018 at 10:49:18PM +0200, Ard Biesheuvel wrote: Clang complains about left shifting a negative value being undefined. >>> >>>

[edk2] [PATCH v3] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-19 Thread Sami Mujawar
The SATA controller driver crashes while accessing the PCI memory [AHCI Base Registers (ABAR)], as the PCI memory space is not enabled. Enable the PCI memory space access to prevent the SATA Controller driver from crashing. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [Patch] FDF Spec: clean up the and usage in spec

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 10:12, Yonghong Zhu wrote: > ::= {"PCD(" ")"} {} > {} > ::= {} {"$(NAMED_GUID)"} > > Cc: Liming Gao > Cc: Michael Kinney > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- >

Re: [edk2] [PATCH] EmbeddedPkg/GdbSerialLib: avoid left shift of negative quantity

2018-06-19 Thread Leif Lindholm
On Tue, Jun 19, 2018 at 12:51:49AM +0200, Laszlo Ersek wrote: > On 06/18/18 23:57, Leif Lindholm wrote: > > On Mon, Jun 18, 2018 at 10:49:18PM +0200, Ard Biesheuvel wrote: > >> Clang complains about left shifting a negative value being undefined. > > > > As well it should. > > > >>