Re: [edk2] [PATCH v3] MdePkg/SynchronizationLib: fix Interlocked[De|In]crement return value

The patch is good. Could you submit BZ to track this change? Thanks Liming >-Original Message- >From: Ni, Ruiyu >Sent: Thursday, September 13, 2018 5:51 PM >To: edk2-devel@lists.01.org >Cc: Yao, Jiewen ; Gao, Liming >; Kinney, Michael D >Subject: [PATCH v3] MdePkg/SynchronizationLib: fix

[edk2] [Patch v2 01/14] UefiCpuPkg/Include/Register/Msr: Update reference spec info.

Latest SDM has moved MSR related content from volume 3 chapter 35 to volume 4 chapter 2. Current MSR's comments need to be updated to reference the new chapter info. Changes includes: 1. Update referenced chapter info from some MSRs. 2. Update referenced SDM version info. Cc: Michael D

[edk2] [Patch v2 00/14] Update MSR definitions

Current MSR definition are follow the SDM 2016-09 version. The latest SDM is 2018-05. This patch serial update the MSR related definition to follow the latest SDM 2018-05 version. MSR related defintion are saved at UefiCpuPkg\Include\Register\. V2 changes include: 1. Only change Patch 8 and 14

Re: [edk2] [Patch 00/14] Update MSR definitions.

Hi Laszlo, > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, September 18, 2018 5:02 PM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Ni, Ruiyu > > Subject: Re: [edk2] [Patch 00/14] Update

Re: [edk2] UEFIPayload build issue

Hello Zhu, I am indeed using cxfreeze as is normally recommended. It will remove these binaries and use the tools from source. Best Regards, Wim Vervoorn -Original Message- From: Zhu, Yonghong [mailto:yonghong@intel.com] Sent: Friday, September 21, 2018 9:33 AM To: Wim

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs

Jian and Laszlo, There is also a superficial comment at below. On 2018/9/20 14:02, Jian J Wang wrote: v2 changes: a. remove macros no longer needed b. remove DEBUG and ASSERT in ToEnableExecuteDisableFeature() c. change ToEnableExecuteDisableFeature to EnableNonExec BZ#1116:

Re: [edk2] [Patch 0/5] Support windowsize to benefit tftp/pxe download performance.

Hi Laszlo, > > If that's the case, should we consider the three drivers under > "MdeModulePkg/Universal/Network/" deprecated, and should we abandon > them > completely? > I think the answer is NO (At least for now). In my opinion, the drivers in MdeModulePkg is also useful in some case,

[edk2] [PATCH 1/3] MdeModulePkg/PciHostBridge: Enhance boundary check in Io/Mem.Read/Write

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- .../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git

[edk2] [PATCH 0/3] Fix a bug that prevents PMEM access

The patch sets fix a bug in PciHostBridge driver that prevents PMEM access sometimes. Additionally, it enhances the boundary check and add a new macro to simplify the code. Ruiyu Ni (3): MdeModulePkg/PciHostBridge: Enhance boundary check in Io/Mem.Read/Write MdeModulePkg/PciHostBridge:

[edk2] [PATCH 2/3] MdeModulePkg/PciHostBridge: Fix a bug that prevents PMEM access

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1196 RootBridgeIoCheckParameter() verifies that the requested MMIO access can fit in any of the MEM/PMEM 32/64 ranges. But today's logic somehow only checks the requested access against MEM 32/64 ranges. It should also check the requested

[edk2] [Patch][edk2-staging/UEFIPayload] Add maintainers' info

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tang Xiaohu --- Maintainers.txt | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 Maintainers.txt diff --git a/Maintainers.txt b/Maintainers.txt new file mode 100644 index 00..60b2158610 --- /dev/null

Re: [edk2] How do I access Prefetchable Memory region through EFI_PCI_IO_PROTOCOL

Garrett, I think it's a real bug in the code. Thanks for reporting that. I just submitted a Bz 1196 for this issue. Patches are also sent out. Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of > Kirkendall, Garrett > Sent: Wednesday, September 19, 2018 9:53 AM > To: Laszlo

[edk2] [PATCH 3/3] MdeModulePkg/PciHostBridge: Add RESOURCE_VALID() to simplify code

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- .../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26 ++ 1 file changed, 12 insertions(+), 14 deletions(-) diff --git

Re: [edk2] UEFIPayload build issue

Hi Wim Vervoorn, May I know your steps? From the error message, seems you freeze the BaseTools to binary exe file, and this failure was caused by the cxfreeze step. We recommend run BaseTools Python from source in Windows. Thanks. Best Regards, Zhu Yonghong -Original Message- From:

[edk2] [Patch v2 13/14] UefiCpuPkg/Include/Register/Msr/GoldmontMsr.h: Add new MSR name and keep old one.

Changes includes: 1. Change MSR name: 1. MSR_GOLDMONT_SGXOWNER0 => MSR_GOLDMONT_SGXOWNEREPOCH0 2. MSR_GOLDMONT_SGXOWNER1 => MSR_GOLDMONT_SGXOWNEREPOCH1 2. Keep old MSR definition (MSR_GOLDMONT_SGXOWNER0/1) for compatibility. 1. Define old MSR like below style: #define

[edk2] [Patch v2 05/14] UefiCpuPkg/Include/Register/Msr/XeonPhiMsr.h: Add new MSR.

Changes includes: 1. Add new MSR definition: 1. MSR_XEON_PHI_PPIN_CTL 2. MSR_XEON_PHI_PPIN 3. MSR_XEON_PHI_MISC_FEATURE_ENABLES 4. MSR_XEON_PHI_MSRUNCORE_RATIO_LIMIT 2. Add DisplayModule == 0x85 supports. Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek

[edk2] [Patch v2 08/14] UefiCpuPkg/Include/Register/ArchitecturalMsr.h: Change structure definition.

V2 changes include: 1. Use X in ReservedX fields from totally new value if MSR structure definition changed. For example, if in current structure, the max reserved variable is Reserved2, in new definition, reserved variable is begin with Reserved3. V1 Changes includes: 1. Change fields

[edk2] [Patch v2 11/14] UefiCpuPkg/Include/Register/Msr/CoreMsr.h: Remove old MSR.

Changes includes: 1. Remove old MSR which not existed in 2018-05 version spec: 1. MSR_CORE_ROB_CR_BKUPTMPDR6 Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong ---

[edk2] [Patch v2 07/14] UefiCpuPkg/Include/Register/ArchitecturalMsr.h: Add new MSR.

Changes includes: 1. Add new MSRs: MSR_IA32_L2_QOS_CFG/MSR_IA32_CSTAR. Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/ArchitecturalMsr.h | 64 ++ 1

[edk2] [Patch v2 10/14] UefiCpuPkg/Include/Register/Msr/P6Msr.h: Remove old MSR.

Changes includes: 1. Remove MSR which not existed in 2018-05 version spec: MSR_P6_ROB_CR_BKUPTMPDR6. Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/P6Msr.h | 48

[edk2] [Patch v2 06/14] UefiCpuPkg/Include/Register/Msr/SkylakeMsr.h: Add new MSRs.

Changes includes: 1. Add new MSR definitions. 2. Add support platform info. Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/SkylakeMsr.h | 1548

[edk2] [Patch v2 12/14] UefiCpuPkg/Include/Register/Msr/SkylakeMsr.h: Add new MSR name and keep old one.

Changes includes: 1. Change MSR name: 1. MSR_SKYLAKE_SGXOWNER0 => MSR_SKYLAKE_SGXOWNEREPOCH0 2. MSR_SKYLAKE_SGXOWNER1 => MSR_SKYLAKE_SGXOWNEREPOCH1 2. Keep old MSR definition(MSR_SKYLAKE_SGXOWNER0/1) for compatibility 1. Use below coding style to define old MSR #define

[edk2] [Patch v2 03/14] UefiCpuPkg/Include/Register/Msr/SilvermontMsr.h: Add new MSR.

Changes includes: 1. Add new MSR: MSR_SILVERMONT_PLATFORM_INFO Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/SilvermontMsr.h | 48 + 1 file

[edk2] [Patch v2 02/14] UefiCpuPkg/Include/Register/Msr/GoldmontPlusMsr.h: Add new MSR file for goldmont plus microarchitecture.

Changes includes: 1. Add new MSR file which used for goldmont plus microarchitecture. Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr.h | 7 +-

[edk2] [Patch v2 04/14] UefiCpuPkg/Include/Register/Msr/*.h: Add new MSR.

Changes includes: 1. Add new MSR: MSR_*_MSRUNCORE_RATIO_LIMIT Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/BroadwellMsr.h | 54 +

[edk2] [Patch v2 14/14] UefiCpuPkg/Include/Register/Msr/XeonPhiMsr.h: Change structure definition.

V2 changes include: 1. Use X in ReservedX fields from totally new value if MSR structure definition changed. For example, if in current structure, the max reserved variable is Reserved2, in new definition, reserved variable is begin with Reserved3. V1 Changes: Changes includes: 1.

[edk2] [Patch v2 09/14] UefiCpuPkg/Include/Register/Msr/Core2Msr.h: Remove old MSR.

Changes includes: 1. Remove old MSR which not existed in 2018-05 version spec: 1. MSR_CORE2_BBL_CR_CTL3 Cc: Michael D Kinney Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Register/Msr/Core2Msr.h |

Re: [edk2] [Patch 0/5] Support windowsize to benefit tftp/pxe download performance.

On 09/21/18 08:33, Wu, Jiaxin wrote: > I agree we need document something to highlight that. Siyuan/Ting, if no > objection, I will do that in separate patch instead of mixing with this new > feature support. That's a good idea (well, both: documenting the differences, and adding the

[edk2] [PATCH edk2-platforms 10/27] Silicon/NXP: Add iMX6Pkg dec

This adds PCD declarations common across NXP i.MX6 SoCs Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMX6Pkg/iMX6Pkg.dec | 143 1 file changed, 143

[edk2] [PATCH edk2-platforms 08/27] Silicon/NXP: Add Virtual RTC support for i.MX platform

This adds a virtual RTC library that implements EFI RTC runtime services based on the ARM performance counter. It should only be used for relative time measurement, such as for Windows Boot Manager. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard

[edk2] [PATCH edk2-platforms 09/27] Silicon/NXP: Add headers for SoC-specific i.MX packages to use

This adds common headers for other NXP i.MX SoC packages. More specifically, this adds i.MX-generic GPIO, IoMux, and Platform definitions. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney ---

[edk2] [PATCH edk2-platforms 07/27] Silicon/NXP: Add i.MX display library support

This adds support for processing EDID data on NXP i.MX platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMXPlatformPkg/Include/iMXDisplay.h| 114

[edk2] [PATCH edk2-platforms 03/27] Platform/Microsoft: Add MsPkg

MsPkg is a collection of libraries and drivers that are specific to supporting Windows IoT Core but are not Platform/Silicon specific. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney ---

[edk2] [PATCH edk2-platforms 05/27] Silicon/NXP: Add UART library support for i.MX platforms

This adds support for interact with the UART controller on NXP i.MX platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMXPlatformPkg/Include/iMXUart.h

[edk2] [PATCH edk2-platforms 00/27] Import Hummingboard Edge platform for Windows IoT Core

REF: https://github.com/christopherco/edk2-platforms/tree/winiot_hmb_v1 v0: * https://lists.01.org/pipermail/edk2-devel/2018-July/027213.html * https://lists.01.org/pipermail/edk2-devel/2018-July/027266.html * https://lists.01.org/pipermail/edk2-devel/2018-July/027333.html *

[edk2] [PATCH edk2-platforms 06/27] Silicon/NXP: Add I2C library support for i.MX platforms

This adds support for I2C controller on NXP i.MX platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMXPlatformPkg/Include/iMXI2cLib.h | 162 +++

[edk2] [PATCH edk2-platforms 04/27] Silicon/NXP: Add iMXPlatformPkg dec

iMXPlatformPkg holds drivers, libraries, and include files that are common across the NXP i.MX line of SoCs. This commit defines iMXPlatform PCDs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney

[edk2] [PATCH edk2-platforms 01/27] Platform/Microsoft: Add OpteeClientPkg dec

On Windows IoT Core devices with ARM TrustZone capabilities, EDK2 runs in normal world and we use OP-TEE to execute secure world operations. The overall package will contain client-side support to invoke EDK2 services implemented as OP-TEE trusted applications that run in secure world. This

[edk2] [PATCH edk2-platforms 17/27] Silicon/NXP: Add i.MX6 USB Phy Library

This adds support for configuring the USB EHCI PHY on NXP i.MX6 SoCs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMX6Pkg/Include/iMX6UsbPhy.h| 20 ++

[edk2] [PATCH edk2-platforms 16/27] Silicon/NXP: Add i.MX6 Timer DXE driver

This adds DXE support for EPIT timer on NXP i.MX6 SoCs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMX6Pkg/Drivers/TimerDxe/Timer.c | 278

[edk2] [PATCH edk2-platforms 24/27] Silicon/NXP: Add i.MX6 common dsc and fdf files

This adds the common dsc and fdf definitions for NXP i.MX6 platforms. Platform dsc definitions will define $(BOARD_NAME), $(IMX_FAMILY), $(IMX_CHIP_TYPE), $(DRAM_SIZE), and $(BOARD_DIR) to indicate i.MX SoC family and board-specific configurations. Contributed-under: TianoCore Contribution

[edk2] [PATCH edk2-platforms 25/27] Platform/Solidrun: Add Hummingboard Peripheral Initialization

This adds support to initialize the different peripherals on the Solidrun i.MX 6Quad Hummingboard Edge. It will initialize the pad mux and clocks for the different peripherals. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Michael D Kinney Cc: Ard

[edk2] [PATCH edk2-platforms 14/27] Silicon/NXP: Add i.MX6 GPT and EPIT timer headers

This adds the definitions for the NXP i.MX6 General Purpose Timer and the Enhanced Periodic Interrupt Timer modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney ---

[edk2] [PATCH edk2-platforms 13/27] Silicon/NXP: Add support for iMX SDHC

This adds support for using the SD host controller on NXP i.MX platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMXPlatformPkg/Drivers/SdhcDxe/SdhcDxe.c | 1246

[edk2] [PATCH edk2-platforms 12/27] Silicon/NXP: Add i.MX6 I/O MUX library

This adds support for initializing and manipulating the I/O Pads on NXP i.MX6 SoCs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMX6Pkg/Library/iMX6IoMuxLib/iMX6IoMux.c |

[edk2] [PATCH edk2-platforms 19/27] Silicon/NXP: Add i.MX6 ACPI tables

This adds baseline ACPI table support for booting Windows on NXP i.MX6 SoCs. Platforms may override these tables as necessary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney ---

[edk2] [PATCH edk2-platforms 27/27] Platform/Solidrun: Add i.MX 6Quad Hummingboard Edge dsc and fdf files

This adds the dsd and fdf definitions for Solidrun's i.MX 6Quad Hummingboard Edge platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney ---

[edk2] [PATCH edk2-platforms 15/27] Silicon/NXP: Add i.MX6 GPT Timer library

This adds support for GPT Timer on NXP i.MX6 SoCs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMX6Pkg/Include/iMX6Timer.h | 24 ++

Re: [edk2] [PATCH v2] UefiCpuPkg PiSmmCpuDxeSmm: Update SmiEntry function run the same position

Hi Liming, On 09/21/18 02:56, Liming Gao wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1191 > > Before commit e21e355e2ca7fefb15b4df7078f995d3fb9c2b89, jmp _SmiHandler > is commented. And below code, ASM_PFX(CpuSmmDebugEntry) is moved into rax, > then call it. But, this code

[edk2] [PATCH edk2-platforms 21/27] Silicon/NXP: Add i.MX6 PCIe DXE driver

This adds DXE driver support for PCIe on NXP i.MX6 SoCs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/NXP/iMX6Pkg/Drivers/PciExpress/iMX6PciExpress.c | 1139

[edk2] [PATCH edk2-platforms 23/27] Silicon/NXP: Add i.MX6 Smbios Driver

This adds support populating the SMBIOS tables on an i.MX6 SoC. Platforms just need to define the relevant PCDs in their dsc file and this driver will fill out the SMBIOS table structures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel

[edk2] [PATCH edk2-platforms 18/27] Silicon/NXP: Add i.MX6 Clock Library

This adds support for managing clocks on NXP i.MX6 SoC. It will manipulate the Clock Gating registers (CCGR). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney ---

[edk2] [PATCH edk2-platforms 20/27] Silicon/NXP: Add i.MX6 Board init library

This adds support for board initialization which is common to NXP i.MX6-based platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney ---

[edk2] [PATCH edk2-platforms 26/27] Platform/SolidRun: Add i.MX 6Quad Hummingboard Edge ACPI tables

This adds ACPI table support for SolidRun's i.MX 6Quad Hummingboard Edge platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher Co Cc: Michael D Kinney Cc: Ard Biesheuvel Cc: Leif Lindholm ---

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs

Another minor suggestion is to move IsExecuteDisableBitAvailable() to VirtualMemory.c, then there will be no need to declare it in VirtualMemeory.h. Thanks, Star On 2018/9/21 14:00, Zeng, Star wrote: Jian and Laszlo, There is also a superficial comment at below. On 2018/9/20 14:02, Jian J

Re: [edk2] [Patch v2 08/14] UefiCpuPkg/Include/Register/ArchitecturalMsr.h: Change structure definition.

On 9/21/2018 3:41 PM, Eric Dong wrote: UINT32 User:1; -UINT32 Reserved1:2; +/// +/// [Bit 4] PwrEvtEn. +/// +UINT32 PwrEvtEn:1; +/// +/// [Bit 5] FUPonPTW. +/// +UINT32 FUPonPTW:1; /// /// [Bit 6] FabricEn. If (CPUID.(EAX=07H,

Re: [edk2] [PATCH 1/3] MdeModulePkg/PciHostBridge: Enhance boundary check in Io/Mem.Read/Write

On 09/21/18 09:25, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Star Zeng > --- > .../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26 > +- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git

Re: [edk2] SPI Flash Corruption

More comments: The NV Variable region starts from 0x4. Is there any data remains within 0x4 - 0x44000 region? Could you dump the flash image and share it with us, and also file a bug in https://bugzilla.tianocore.org as Jiewen mentioned? It occurred to me that on some old version of

Re: [edk2] [Patch v2 08/14] UefiCpuPkg/Include/Register/ArchitecturalMsr.h: Change structure definition.

On 09/21/18 10:44, Ni, Ruiyu wrote: > On 9/21/2018 3:41 PM, Eric Dong wrote: >>   UINT32  User:1; >> -    UINT32  Reserved1:2; >> +    /// >> +    /// [Bit 4] PwrEvtEn. >> +    /// >> +    UINT32  PwrEvtEn:1; >> +    /// >> +    /// [Bit 5] FUPonPTW. >> +    /// >> +    UINT32  FUPonPTW:1; >>  

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs

On 09/21/18 10:42, Zeng, Star wrote: > Another minor suggestion is to move IsExecuteDisableBitAvailable() to > VirtualMemory.c, then there will be no need to declare it in > VirtualMemeory.h. I'm fine with both ideas (name change as you see fit, and code movement). Thanks Laszlo > > > Thanks,

Re: [edk2] [PATCH 2/3] MdeModulePkg/PciHostBridge: Fix a bug that prevents PMEM access

On 09/21/18 09:25, Ruiyu Ni wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1196 > > RootBridgeIoCheckParameter() verifies that the requested MMIO access > can fit in any of the MEM/PMEM 32/64 ranges. But today's logic > somehow only checks the requested access against MEM 32/64

Re: [edk2] [PATCH 3/3] MdeModulePkg/PciHostBridge: Add RESOURCE_VALID() to simplify code

On 09/21/18 09:25, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Star Zeng > --- > .../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26 > ++ > 1 file changed, 12 insertions(+), 14 deletions(-) > > diff --git

Re: [edk2] [Patch v2 14/14] UefiCpuPkg/Include/Register/Msr/XeonPhiMsr.h: Change structure definition.

On 9/21/2018 3:41 PM, Eric Dong wrote: -UINT32 CStateRange:3; -UINT32 Reserved1:13; -UINT32 Reserved2:32; +UINT32 CStateRange:7; +UINT32 Reserved3:9; +UINT32 Reserved4:32; Similarly, Reserved2 name doesn't need to change. -- Thanks, Ray

Re: [edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Clean up build scripts

Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS From: Steele, Kelly Sent: Friday, September 21, 2018 1:58 AM To: edk2-devel@lists.01.org Cc: Wei, David ; Guo, Mang Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Clean up build scripts >From

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Update platform ID

>From 3584ac675af11249d5e9aa525288ff5b8efa Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:23:08 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Update platform ID Since no platform uses PMIC_PWRGOOD to determine platform ID, I removed it from the

Re: [edk2] [Question] Testing environment regarding SMM driver

On 09/21/18 20:15, poxyran wrote: > Hello again, > > my question is: is it possible to create a SMM driver that > installs/register a SMI handler (in order to call it from a usermode app > in the OS) and test it in the UEFI Shell or do I need to setup up a > dedicated machine with the SMM stack

Re: [edk2] Stack issue after warm UEFI reset and MMU enabling on an Armv8 platform

> On Sep 21, 2018, at 4:24 PM, Vladimir Olovyannikov > wrote: > > On Thu, Sep 20, 2018 at 2:52 PM Vladimir Olovyannikov > wrote: >> >> On Wed, Sep 19, 2018 at 5:21 PM Bill Paul wrote: >>> >>> Of all the gin joints in all the towns in all the world, Vladimir >>> Olovyannikov >>> had to

Re: [edk2] [Question] Testing environment regarding SMM driver

Hello again, my question is: is it possible to create a SMM driver that installs/register a SMI handler (in order to call it from a usermode app in the OS) and test it in the UEFI Shell or do I need to setup up a dedicated machine with the SMM stack as described in official EDK II documentation

Re: [edk2] Stack issue after warm UEFI reset and MMU enabling on an Armv8 platform

On Thu, Sep 20, 2018 at 2:52 PM Vladimir Olovyannikov wrote: > > On Wed, Sep 19, 2018 at 5:21 PM Bill Paul wrote: > > > > Of all the gin joints in all the towns in all the world, Vladimir > > Olovyannikov > > had to walk into mine at 16:58 on Wednesday 19 September 2018 and say: > > > > > >From:

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] FDF has unused PCDs

>From 64a0e3c16bcc91be85e368ad3150a340628a9fcc Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:17:09 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] FDF has unused PCDs There were several PCDs that were not being used in the FDF. Removed them and fixed

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Flag after GPIO init

>From b4b50a16977879f664fe93c1fd8355ac5df012c3 Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:20:56 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Flag after GPIO init Need to prevent modifying the SoC PADs after GPIO init in the I2C code so I added

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Add Fab C GPIO support

>From 873dd2d29b9e0aede07749713314ee5ac8bca9c3 Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:18:59 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Add Fab C GPIO support Sync the Fab C GPIO changes from the EEPROM image into the firmware so that the

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Dynamic debug UART

>From f91d7f365c00f2c16c82431d407f6b63e23e3a5b Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:09:13 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Dynamic debug UART Went from a static build time PCD to using the UART scrathpad registers to determine

Re: [edk2] [PATCH v2 1/2] MdePkg/IndustryStandard: Add Global Plaform header file

On 27 August 2018 at 04:50, Sumit Garg wrote: > Add Global Plaform header file specific to TEE Client API Specification v1 > . > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under:

Re: [edk2] [Question] Testing environment regarding SMM driver

> On Sep 21, 2018, at 11:15 AM, poxyran wrote: > > Hello again, > > my question is: is it possible to create a SMM driver that > installs/register a SMI handler (in order to call it from a usermode app > in the OS) and test it in the UEFI Shell poxyran, Does "test it in the UEFI Shell"

Re: [edk2] [PATCH 0/4] MdeModulePkg: add support for dispatching foreign arch PE/COFF images

> On Sep 19, 2018, at 1:43 PM, Ard Biesheuvel wrote: > > On 19 September 2018 at 12:35, Andrew Fish > wrote: >> >> >>> On Sep 15, 2018, at 6:28 AM, Ard Biesheuvel >>> wrote: >>> >>> On 13 September 2018 at 19:20, Kinney, Michael D >>> wrote: Ard,

Re: [edk2] Stack issue after warm UEFI reset and MMU enabling on an Armv8 platform

On Fri 21 Sep 2018 at 16:57, Andrew Fish wrote: > > > > On Sep 21, 2018, at 4:24 PM, Vladimir Olovyannikov < > vladimir.olovyanni...@broadcom.com> wrote: > > > > On Thu, Sep 20, 2018 at 2:52 PM Vladimir Olovyannikov > > wrote: > >> > >> On Wed, Sep 19, 2018 at 5:21 PM Bill Paul wrote: > >>> >

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

> -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, September 19, 2018 3:59 AM > To: Duran, Leo ; Laszlo Ersek ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling > MTRRs prior to MTRR change. > > On

Re: [edk2] SPI Flash Corruption

From a design point of view VPD == Vital Product Data. The idea behind VPD was to be a place to store platform unique information generally programmed in the factory. So things like serial number, system UUID, mac address, etc. Usually VPD is programmed in the factory and never updated, thus it

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

> -Original Message- > From: Duran, Leo > Sent: Friday, September 21, 2018 11:53 AM > To: 'Ni, Ruiyu' ; Laszlo Ersek ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: RE: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling > MTRRs prior to MTRR change. > > > > >

Re: [edk2] SPI Flash Corruption

Thanks guys for your answers. I will open a bug in bugzilla and attach the binary. *Is there any data remains within 0x4 - 0x44000 region? * Yes there is Data between 0x4 and 0x44000. it's after 44 that you can only see FFs in the affected units. The bios we are using is based on