Usually, we do not encourage to use SerialPortLib directly in a hardware
independent environment.
I do not suggest we bring an architecture dependency on the existence of
SerialPort in a common code.
However, if ARCH64 has some specific code that must use SerialPortLib
explicitly, I am OK.
Can
Thanks to remind me.
I took a look at all patches.
I skipped all ARM specific patches, and reviewed rest of them.
All my feedback is provided in the individual patch.
Thank you
Yao Jiewen
> -Original Message-
> From: Achin Gupta [mailto:achin.gu...@arm.com]
> Sent: Friday, January 18,
On Fri, 18 Jan 2019 at 16:40, Yao, Jiewen wrote:
>
> The idea seems good.
>
> May I know if there is any restriction on 64 handlers?
>
> +STATIC UINT64 mExtractGuidedSectionHandlerInfo[64];
>
> If a system is configured with more handlers, what is expected behavior?
>
Good question. I wasn't
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, January 16, 2019 12:22 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Achin Gupta
> ; Yao, Jiewen ; Supreeth
> Venkatesh ; Leif Lindholm
> ;
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, January 16, 2019 12:22 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Achin Gupta
> ; Yao, Jiewen ; Supreeth
> Venkatesh ; Leif Lindholm
> ;
Add Mike Kinney.
Hi Mike
Do you have any suggestion on how to implement this in a self-contained
environment for gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress?
STATIC UINT64 mExtractGuidedSectionHandlerInfo[64];
PcdSet64 (PcdGuidedExtractHandlerTableAddress,
> On Jan 18, 2019, at 9:08 AM, Felix Polyudov wrote:
>
> Mike,
>
> I think EFI_GUID and EFI_STATUS should cover most of the use cases.
>
I think I missed a couple in my original mail
But here are the typedef and #define names that get remapped (or redone) in
On Fri, 18 Jan 2019 at 06:38, Gao, Liming wrote:
>
> This is my idea to avoid the duplicated mail. I also include Ard and Laszlo
> to collect the feedback on how to handle the partial update in the patchset.
>
Laszlo may disagree with me, but I think that it is not always
necessary to resend
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, January 16, 2019 12:22 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Achin Gupta
> ; Yao, Jiewen ; Supreeth
> Venkatesh ; Leif Lindholm
> ;
Mike,
I think EFI_GUID and EFI_STATUS should cover most of the use cases.
-Original Message-
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Thursday, January 17, 2019 3:04 PM
To: Felix Polyudov; 'Andrew Fish'; Kinney, Michael D
Cc: edk2-devel@lists.01.org
Subject: RE:
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, January 18, 2019 3:13 AM
> To: Wang, Jian J
> Cc: edk2-devel@lists.01.org; Kinney, Michael D
> ; Gao, Liming ; Ye,
> Ting ; Wei, Gang ; Zhang, Chao B
> ; Yao,
On Fri, 18 Jan 2019 at 16:27, Yao, Jiewen wrote:
>
> Usually, we do not encourage to use SerialPortLib directly in a hardware
> independent environment.
> I do not suggest we bring an architecture dependency on the existence of
> SerialPort in a common code.
>
> However, if ARCH64 has some
The idea seems good.
May I know if there is any restriction on 64 handlers?
+STATIC UINT64 mExtractGuidedSectionHandlerInfo[64];
If a system is configured with more handlers, what is expected behavior?
Thank you
Yao Jiewen
> -Original Message-
> From: Ard Biesheuvel
That would be even better. Thanks Ard.
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, January 18, 2019 7:32 AM
> To: Yao, Jiewen
> Cc: edk2-devel@lists.01.org; Achin Gupta ;
> Supreeth Venkatesh ; Leif Lindholm
> ; Jagadeesh Ujja ;
> Thomas
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, January 16, 2019 12:23 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Achin Gupta
> ; Yao, Jiewen ; Supreeth
> Venkatesh ; Leif Lindholm
> ;
Anther, the parameters of constructor are removed, so their descriptions in
function header also need to be cleaned up. Same comment to patch 2. With them
fixed, Reviewed-by: Star Zeng to the series.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Friday, January 18, 2019 4:15
On Fri, 18 Jan 2019 at 08:06, Wang, Jian J wrote:
>
>
>
> Reviewed-by: Jian J Wang
>
Chao, Jiewen, do you have any objections to this patch?
>
> > -Original Message-
> > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> > Sent: Thursday, January 17, 2019 5:22 AM
> > To:
On Wed, 16 Jan 2019 at 22:22, Ard Biesheuvel wrote:
>
> Add MM_STANDALONE to the list of module types that are permitted to
> link to this library.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> ---
>
Hi Jiaxin,
I am happy to see the creation of this branch. However, Could you
possibly resubmit this as a diff adding a Readme.md rather than
modifying it?
The diff against edk2/Readme.md is not really relevant, and confuses review.
(For example, in your branch, *delete* the existing Readme.md
On Fri, 18 Jan 2019 at 08:08, Wang, Jian J wrote:
>
>
>
> Reviewed-by: Jian J Wang
>
Ting, do you have any objections to this patch?
>
> > -Original Message-
> > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> > Sent: Thursday, January 17, 2019 5:22 AM
> > To:
On Fri, 18 Jan 2019 at 19:39, Ard Biesheuvel wrote:
>
> On Fri, 18 Jan 2019 at 19:30, Julien Grall wrote:
> >
> > Hi all,
> >
> > I am trying to boot a Xen guest using the latest EDK2 master (cce9d76358
> > "BaseTools: Allow empty value for HiiPcd in Dsc"), GRUB and Linux 5.0-rc2.
> >
> > The
On Fri, 18 Jan 2019 at 19:30, Julien Grall wrote:
>
> Hi all,
>
> I am trying to boot a Xen guest using the latest EDK2 master (cce9d76358
> "BaseTools: Allow empty value for HiiPcd in Dsc"), GRUB and Linux 5.0-rc2.
>
> The last code executed by Linux is when installing the virtual address
> map
Hi all,
I am trying to boot a Xen guest using the latest EDK2 master (cce9d76358
"BaseTools: Allow empty value for HiiPcd in Dsc"), GRUB and Linux 5.0-rc2.
The last code executed by Linux is when installing the virtual address
map in the EFI stub and then it seems to get stuck. I don't have much
On 01/18/19 12:09, Ard Biesheuvel wrote:
> On Fri, 18 Jan 2019 at 06:38, Gao, Liming wrote:
>>
>> This is my idea to avoid the duplicated mail. I also include Ard and Laszlo
>> to collect the feedback on how to handle the partial update in the patchset.
>>
>
> Laszlo may disagree with me, but I
On Fri, Jan 18, 2019 at 04:08:57PM +0800, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1426
>
> When calculating the address of RelocBaseEnd,
> the RelocBase address is ImageBase + RelocDir->VirtualAddress,
> the size of RelocDir is RelocDir->Size.
> So the RelocBaseEnd
Hi Ard,
For all the patches...
Reviewed-by: Achin Gupta
Jiewen. There are changes to the generic Standalone MM code in this series. Do
you want to have a look as well?
cheers,
Achin
From: Ard Biesheuvel
Sent: 16 January 2019 20:22
To:
UEFI_Redfish branch is to develop the UEFI Redfish feature. The code base
of development is based on the release of edk2-stable201811 tag. Please
refer to the patch of Readme.md to get the detailed feature introduction.
Note: The branch will be created by the end of Jan 28th if no objection.
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1426
When calculating the address of RelocBaseEnd,
the RelocBase address is ImageBase + RelocDir->VirtualAddress,
the size of RelocDir is RelocDir->Size.
So the RelocBaseEnd address is:
ImageBase + RelocDir->VirtualAddress + RelocDir->Size - 1
This patch does not touch VarCheckLib at all, but only touch VarCheckUefiLib,
so the title and commit message need be updated.
With them updated correctly, Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday,
29 matches
Mail list logo
