Thanks Kilian.
There was no issue. This patch was sent in error.
However, I will look into this feedback - "The GenBin.c should be extended by a
manual BIN2TXT translation."
Supreeth
From: Minnow Ware
Sent: Friday, March 29, 2019 9:29 AM
To: Jin, Eric ; Supreeth Venkatesh
;
Sorry. This was sent in error. I was testing my new Desktop with git send-email.
Please ignore.
Supreeth
-Original Message-
From: Jin, Eric
Sent: Friday, March 29, 2019 3:32 AM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: Jin, Eric
Subject: RE: [edk2] [edk2-test][PATCH v2]
Hi Supreeth,
theoretically the standard C implementation of fopen(char *filename, char *mode)
“can” support BINARY and TEXT mode. This is specified here
http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf, “7.19.2 Streams”
In praxis only Windows-/DOS platforms supports a BINARY ( w/ “b”)
+ @param[in] *Cr2 Pointer to variable to hold CR2 register value
+**/
the indicator in should be out。
发自我的小米手机
在 2019年3月29日 下午9:56，nkvangup 写道：
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593
For every SMI occurrence, save and restore CR2 register only when SMM
on-demand paging
Thank you very much for the comments/feedback.
I will check this in after taking care of your feedback.
Supreeth
-Original Message-
From: Jin, Eric
Sent: Friday, March 29, 2019 4:04 AM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: Jin, Eric
Subject: RE: [edk2-test][PATCH v1
Bob:
How about use /MP option without process number? The compiler will retrieves
the number of effective processors on your computer.
And, move this option into CC_FLAGS in tools_def.txt. If so, platform can
override it in platform DSC file.
Last, please provide the performance data
Hi Ray,
Yes, the new UefiPayload will not require legacy 8254 timer.
And we could remove Coreboot packages after UefiPayloadPkg check in.
Thanks,
Guo
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, March 28, 2019 10:15 PM
> To: Dong, Guo ; edk2-devel@lists.01.org; Laszlo Ersek
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593
For every SMI occurrence, save and restore CR2 register only when SMM
on-demand paging support is enabled in 64 bit operation mode.
This is not a bug but to have better improvement of code.
Patch5 is updated with separate functions for Save
Yes. Please submit one BZ for it.
> -Original Message-
> From: Feng, Bob C
> Sent: Friday, March 29, 2019 8:40 PM
> To: Gao, Liming ; edk2-devel@lists.01.org
> Subject: RE: [Patch] BaseTools: Fixed issue in MultiThread Genfds function
>
> That will impact the original GenFds since the
Reviewed-by: Ray Ni
Sent from small device
> 在 2019年3月29日，下午11:45，Vanguput, Narendra K 写道：
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593
>
> For every SMI occurrence, save and restore CR2 register only when SMM
> on-demand paging support is enabled in 64 bit operation mode.
>
1. Why would you do this for 64 bit but not 32 bit?
2. Why don't you add the if statement to MpService.c instead of spreading it to
PageTbl.c?
3. What is the reason for this anyway? Adding the conditional is probably more
execution time than just reading CR2 always.
Thanks,
Nate
-Original
> On Mar 29, 2019, at 2:22 PM, Desimone, Nathaniel L
> wrote:
>
> 1. Why would you do this for 64 bit but not 32 bit?
Is paging enabled on 32-bit, it is required for Long mode?
Also I'm not clear why it is an enhancement given you could take a periodic SMM
in the kernels page fault
https://devblogs.microsoft.com/cppblog/recommendations-to-speed-c-builds-in-visual-studio/#_PCH
Bob,
Per above article, It seems /Gm needs to be removed when /MP is used.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng,
> Bob C
> Sent:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593
For every SMI occurrence, save and restore CR2 register only when SMM
on-demand paging support is enabled in 64 bit operation mode.
This is not a bug but to have better improvement of code.
Patch5 is updated with separate functions for Save
Reviewed-by: Liming Gao
> -Original Message-
> From: Fan, ZhijuX
> Sent: Thursday, March 28, 2019 11:21 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Feng, Bob C
> Subject: [edk2][PATCH V3] BaseTools:Trim will trig exception when input asl
> UTF8 format file
>
>
Bob:
Could you update the rule to depend on EFI image from DEBUG_DIR? I would like
to remove the additional copy from DEBUG dir to OUTPUT dir and save the disk
and performance.
$(FFS_OUTPUT_DIR)\$(MODULE_GUID)SEC2.1.1.1.pe32 : $(DEBUG_DIR)\LogoDxe.efi
GenSec -s EFI_SECTION_PE32 -o
From: Zhiju Fan
https://bugzilla.tianocore.org/show_bug.cgi?id=1672
The /MP option of MSVC compiler can reduce the total
time to compile the source files on the command line.
This patch is going to enable this MSVC option in BaseTools.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore
That will impact the original GenFds since the command is generate by reusing
the GenFds functions. What about enter a new BZ to do that change?
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Friday, March 29, 2019 8:33 PM
To: Feng, Bob C ; edk2-devel@lists.01.org
Subject: RE:
Reviewed by Qian Yi
Thanks
Qian Yi
> -Original Message-
> From: Sun, Zailiang
> Sent: Friday, March 29, 2019 3:13 PM
> To: edk2-devel@lists.01.org
> Cc: Wei, David ; Qian, Yi
> Subject: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017]
> Vlv2TbltDevicePkg: Fix issue with
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Ting Ye
Cc: Gang Wei
Cc: Jian Wang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Ting Ye
Cc: Jian Wang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
On Fri, 8 Mar 2019 at 16:31, Ard Biesheuvel wrote:
>
> Bring DeveloperBox in line with EDK2 core changes to StandaloneMmPkg:
> - switch from BaseExtractGuidedSectionLib to PrePiExtractGuidedSectionLib
> - include a NULL library class resolution for VariableMmDependency
>
> Contributed-under:
Provide a prebuilt binary of the standalone MM payload containing the
UEFI authenticated variable store drivers. These are built from EDK2
components, but the resulting image needs to be wrapped in a FIP
container and built into the secure world TF-A image.
TF-A commit: e86e202c2e4e
Leaf 1FH is very similar to leaf 0BH. Both return the CPU topology
information.
Leaf 0BH returns 3-level (Package/Core/Thread) CPU topology info.
Leaf 1FH returns 6-level (Package/Die/Tile/Module/Core/Thread) CPU
topology info.
The logic to enumerate the topology info is the same.
But today's
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
v2: Remove some description in 04/10.
v3: Add 11/12 and 12/12.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Shenglei Zhang (12):
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.../BaseMemoryLibRepStr.inf
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.../DebugAgentCommon/Ia32/AsmFuncs.S | 415
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Ting Ye
Cc: Gang Wei
Cc: Jian Wang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
Reviewed-by: Jian J Wang
> -Original Message-
> From: Zhang, Shenglei
> Sent: Friday, March 29, 2019 3:31 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Gang Wei ; Wang, Jian
> J
> Subject: [PATCH v3 11/12] CryptoPkg/IntrinsicLib: Remove .S files for IA32
> arch
>
> .nasm file
https://bugzilla.tianocore.org/show_bug.cgi?id=1671
Build fails when SOURCE_DEBUG_ENABLE is set to TRUE. This is due to
limited size of FV MAIN region. To work around the issue, we increase
size for the region by another 320KB provided that MINNOW2_FSP_BUILD
is set to FALSE.
Contributed-under:
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.../BaseMemoryLibOptPei.inf
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Change-Id: Ibf97f907a36f84bf46b2b562a2f7e8eb514a8b8e
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.../BaseMemoryLibOptDxe.inf
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
v2: Remove CpuSleep.nasm| GCC and CpuFlushTlb.nasm| GCC in X64 arch
in BaseCpuLib.inf.
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
Reviewed-by: Eric Dong
---
GetProcessorLocation2ByApicId() extracts the
package/die/tile/module/core/thread ID from the initial APIC ID.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ray Ni
Cc: Eric Dong
---
UefiCpuPkg/Include/Library/LocalApicLib.h | 29 +++-
Hi Supreeth,
This patch can't be applied to the lasted code base SHA-1: 33022e.
One patch from may already fix the issue. Please check again.
Best Regards
Eric
-Original Message-
From: edk2-devel On Behalf Of Supreeth
Venkatesh
Sent: Friday, March 29, 2019 7:08 AM
To:
Reviewed-by: Jian J Wang
> -Original Message-
> From: Zhang, Shenglei
> Sent: Friday, March 29, 2019 3:32 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wang, Jian J
> Subject: [PATCH v3 11/12] CryptoPkg/IntrinsicLib: Remove .S files for IA32
> arch
>
> .nasm file has been added
On Fri, Mar 29, 2019 at 08:32:31AM +0100, Ard Biesheuvel wrote:
> On Fri, 8 Mar 2019 at 16:31, Ard Biesheuvel wrote:
> >
> > Bring DeveloperBox in line with EDK2 core changes to StandaloneMmPkg:
> > - switch from BaseExtractGuidedSectionLib to PrePiExtractGuidedSectionLib
> > - include a NULL
On Fri, 29 Mar 2019 at 09:56, Leif Lindholm wrote:
>
> On Fri, Mar 29, 2019 at 08:32:31AM +0100, Ard Biesheuvel wrote:
> > On Fri, 8 Mar 2019 at 16:31, Ard Biesheuvel
> > wrote:
> > >
> > > Bring DeveloperBox in line with EDK2 core changes to StandaloneMmPkg:
> > > - switch from
On Fri, 29 Mar 2019 at 09:57, Leif Lindholm wrote:
>
> On Fri, Mar 29, 2019 at 08:46:12AM +0100, Ard Biesheuvel wrote:
> > Provide a prebuilt binary of the standalone MM payload containing the
> > UEFI authenticated variable store drivers. These are built from EDK2
> > components, but the
On Fri, Mar 29, 2019 at 08:46:12AM +0100, Ard Biesheuvel wrote:
> Provide a prebuilt binary of the standalone MM payload containing the
> UEFI authenticated variable store drivers. These are built from EDK2
> components, but the resulting image needs to be wrapped in a FIP
> container and built
Hi Supreeth,
Thanks a lot to fix this build issue at first.
Comments for this series of patches are replied below.
Patch 1/2 :
1. Could the two patches can be re-organized? For example, merge the change of
*.dsc in patch 2 to patch 1 to make it clear.
2. The change of CommonGenFramework.sh in
Yes. With below "Cr2 !=0" removed from final commit, Reviewed-by: Ray Ni
> > +RestoreCr2 (
> > + UINTN Cr2
> > + )
> > +{
> > + if ((!mCpuSmmStaticPageTable) && (Cr2 != 0)) {
> > +AsmWriteCr2 (Cr2);
> > + }
> > +}
> -Original Message-
> From: Vanguput, Narendra K
> Sent:
On Fri, Mar 29, 2019 at 10:52:41AM +0100, Ard Biesheuvel wrote:
> On Fri, 29 Mar 2019 at 09:57, Leif Lindholm wrote:
> >
> > On Fri, Mar 29, 2019 at 08:46:12AM +0100, Ard Biesheuvel wrote:
> > > Provide a prebuilt binary of the standalone MM payload containing the
> > > UEFI authenticated
Hi Ray,
While programming, I thought this cannot be 0 as in SDM, it says page-fault
linear address.
>> CR2 - Contains the page-fault linear address (the linear address that caused
>> a page fault).
So added a check for 0.
Now as the function is changed like program into CR2 register based on
On Fri, 29 Mar 2019 at 11:06, Leif Lindholm wrote:
>
> On Fri, Mar 29, 2019 at 10:52:41AM +0100, Ard Biesheuvel wrote:
> > On Fri, 29 Mar 2019 at 09:57, Leif Lindholm
> > wrote:
> > >
> > > On Fri, Mar 29, 2019 at 08:46:12AM +0100, Ard Biesheuvel wrote:
> > > > Provide a prebuilt binary of the
That's to fix the issue that make will fail if enable multiple thread genfds.
For example, If enable Multiple thread Genfds, there will be GenSec command in
the Makefile like below.
$(FFS_OUTPUT_DIR)\$(MODULE_GUID)SEC2.1.1.1.pe32 : $(OUTPUT_DIR)\LogoDxe.efi
GenSec -s EFI_SECTION_PE32
Reviewed-by: Liming Gao
> -Original Message-
> From: Gao, Zhichao
> Sent: Friday, March 22, 2019 11:07 AM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Zeng, Star
> ; Gao, Liming ; Ard Biesheuvel
>
> Subject: [PATCH V2 0/2] Change reset logic related on
https://bugzilla.tianocore.org/show_bug.cgi?id=1450
In the Multiple thread Genfds feature, build tool generates
GenSec, GenFFS command in Makefile.
The Non-Hii Driver does not generate .offset file for uni string offset,
but the build tool has not knowledge about this in autogen phase. So
in this
Bob:
Could you list the more information on why update build_rule.txt?
> -Original Message-
> From: Feng, Bob C
> Sent: Friday, March 29, 2019 7:07 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [Patch] BaseTools: Fixed issue in MultiThread Genfds function
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Friday, March 29, 2019 3:28 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Dong, Eric ; Ni, Ray
>
> Subject: [PATCH v3 00/12] Remove .S files for IA32 and X64 arch in MdePkg and
>
56 matches
Mail list logo
