Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Kinney, Michael D
, then it completely replaces the environment variable. Mike -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Wednesday, August 05, 2015 8:45 AM To: Kinney, Michael D Cc: Justen, Jordan L; edk2-devel@lists.01.org; Laszlo Ersek; Gao

Re: [edk2] BaseTools features: multiple workspaces

2015-08-05 Thread Kinney, Michael D
Jordan, We already have EDK_TOOLS_PATH for the path to the tools, so I don't think we should add WORKSPACE_TOOLS. The DSC file specifies the output directory and the syntax supports both workspace relative paths and absolute paths. I am not sure I understand what issue is addressed by adding

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Kinney, Michael D
Jordan, If we make a slight change to the requirements, we can provide clear priority rules. WORKSPACE is used to find Build and Conf. If WORKSPACE_MULTIPLE exists, then it is used as a prioritized list of paths to resolve all other workspace relative paths. This means WORKSPACE_MULTIPLE

Re: [edk2] [Patch 3/3] UefiCpuPkg/CpuDxe: Place APs into protected mode when ExitBootService

2015-10-26 Thread Kinney, Michael D
be delivered to BSP and all APs. Best regards, Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Monday, October 26, 2015 10:37 AM >To: Fan, Jeff; edk2-de...@ml01.01.org >Cc: Kinney, Michael D >Subject: Re: [Patch 3/3] UefiCpuPkg/CpuDxe: Place

Re: [edk2] [PATCH] UefiCpuPkg: PiSmmCpuDxeSmm: Remove unused references to SmmLib

2015-10-26 Thread Kinney, Michael D
Laszlo, I updated the message with your suggestion. Thanks, Mike >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, October 22, 2015 3:44 AM >To: Kinney, Michael D; edk2-de...@ml01.01.org >Cc

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-29 Thread Kinney, Michael D
t; S3BootScriptWidthUint16 - 0x000780A0 (0x) >> ExecuteBootScript - 7E620037 >> EFI_BOOT_SCRIPT_INFORMATION_OPCODE >> BootScriptExecuteInformation - 0x7E62003E >> BootScriptInformation: DE AD BE EF >> ExecuteBootScript - 7E620042 >> S3_BOOT_SCRIPT_LIB_TERMINATE_OPCODE

Re: [edk2] [PATCH v3 27/52] OvmfPkg: use relaxed AP SMM synchronization mode

2015-10-26 Thread Kinney, Michael D
o.bonz...@gmail.com] On Behalf Of Paolo >Bonzini >Sent: Sunday, October 25, 2015 7:53 PM >To: Laszlo Ersek; edk2-de...@ml01.01.org >Cc: Kinney, Michael D; Justen, Jordan L >Subject: Re: [edk2] [PATCH v3 27/52] OvmfPkg: use relaxed AP SMM >synchronization mode > >On 23/10/2015 1

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-28 Thread Kinney, Michael D
: edk2-devel-01; Kinney, Michael D >Subject: about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei > >Hi, > >I have a question about the following code in >"UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c", function >S3RestoreConfig2(): > >>

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-10-28 Thread Kinney, Michael D
Leif, Please test the patch I just sent to see if it resolves your issue. Thanks, Mike >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif >Lindholm >Sent: Wednesday, October 28, 2015 7:51 AM >To: Tian, Feng >Cc: Ni, Ruiyu;

Re: [edk2] [PATCH] OvmfPkg: increase MP services startup timeout

2015-10-21 Thread Kinney, Michael D
g; Eduardo Habkost; edk2-de...@ml01.01.org; Alex >Williamson; Kinney, Michael D >Subject: Re: [edk2] [PATCH] OvmfPkg: increase MP services startup timeout > >CC'ing Eduardo > >On 10/20/15 23:39, Jordan Justen wrote: >> On 2015-10-20 12:27:42, Laszlo Ersek wrote: >>> Due

Re: [edk2] Authentication status for signed FVs extracted in PEI

2015-11-10 Thread Kinney, Michael D
Eugene, I believe the current behavior is that only FVs that are either unsigned or FVs that are signed and pass authentication can be passed from PEI to DXE. I believe your use case is to pass an FV from PEI to DXE that is signed, but has not been authenticated yet. Given the current PI

Re: [edk2] [RFC] Adaptively set serial terminal input polling interval

2015-11-10 Thread Kinney, Michael D
O of the device will not overflow during a burst input? > >Thanks. > >On 11/10/2015 01:25 AM, Kinney, Michael D wrote: >> Heyi, >> >> The function TerminalConInTimerHandler () computes a timeout based on the >> baud rate, data bits, and st

Re: [edk2] [RFC] Adaptively set serial terminal input polling interval

2015-11-09 Thread Kinney, Michael D
Heyi, The function TerminalConInTimerHandler () computes a timeout based on the baud rate, data bits, and stop bits // // According to BAUD rate to calculate the timeout value. // SerialInTimeOut = (1 + Mode->DataBits + Mode->StopBits) * 2 * 100 / (UINTN)

Re: [edk2] [PATCH] MdeModulePkg: SmmLockBoxPeiLib: work without EFI_PEI_SMM_COMMUNICATION_PPI

2015-11-16 Thread Kinney, Michael D
Laszlo, I also agree this is a good solution. Thanks, Mike -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Monday, November 16, 2015 10:38 AM To: Yao, Jiewen <jiewen@intel.com> Cc: Kinney, Michael D <mich

Re: [edk2] EDK2 windows compile

2015-11-16 Thread Kinney, Michael D
Matthew, The default paths for tool chains are in the file Conf/tools_def.txt that is copied from BaseTools/Conf/tools_def.template the first time edksetup is run. The file Conf/tools_def.txt is intended to be customized (as needed) if tool chains are installed into locations other than the

Re: [edk2] EFI GOP with manual vsync trigger

2015-11-11 Thread Kinney, Michael D
Michael, A periodic event timer at 30 times a second should not cause pauses forever, unless the action you are performing in the event notification function takes more than 1/30 of a second to complete. You should be able to just add a periodic event handler that does nothing, so you can

Re: [edk2] [RFC] Adaptively set serial terminal input polling interval

2015-11-10 Thread Kinney, Michael D
nal Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo >Sent: Tuesday, November 10, 2015 5:27 PM >To: Kinney, Michael D; edk2-devel@lists.01.org >Cc: Tian, Feng >Subject: Re: [edk2] [RFC] Adaptively set serial terminal input polling interval &g

Re: [edk2] [RFC] Adaptively set serial terminal input polling interval

2015-11-10 Thread Kinney, Michael D
, or Receive FIFO depth have changed, and if they have, compute and set the new periodic timer rate for the event. Mike >-Original Message- >From: Heyi Guo [mailto:heyi@linaro.org] >Sent: Tuesday, November 10, 2015 7:07 PM >To: Kinney, Michael D; edk2-devel@lists.01.o

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Kinney, Michael D
Laszlo, Yes. They are compatible. And I do recommend switching to BaseXApicX2ApicLib unconditionally. Mike >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Wednesday, November 04, 2015 12:09 PM >To: Ki

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-04 Thread Kinney, Michael D
5 1:01 PM >To: edk2-de...@ml01.01.org >Cc: Kinney, Michael D; Justen, Jordan L >Subject: [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM >during PEI > >"MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf" is the library >instance that implements the Lo

Re: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build environment if it is set.

2015-11-04 Thread Kinney, Michael D
Liming, Why do you a different method than WORKSPACE to display the PACKAGES_PATH and EDK_TOOLS_BIN environment variables? Thanks, Mike >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Liming Gao >Sent: Tuesday, November 03, 2015 5:15 PM

Re: [edk2] [Patch] BaseTools: Don't require ECP pkg in WORKSPACE when PACKAGES_PATH is set

2015-11-04 Thread Kinney, Michael D
Reviewed-by: Michael Kinney >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Liming Gao >Sent: Tuesday, November 03, 2015 3:52 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Don't require ECP pkg

Re: [edk2] [PATCH v4 06/41] OvmfPkg: PlatformPei: account for TSEG size with PcdSmmSmramRequire set

2015-11-04 Thread Kinney, Michael D
Laszlo, Reviewed-by: Michael Kinney <michael.d.kin...@intel.com> Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, November 03, 2015 1:01 PM >To: edk2-de...@ml01.01.org >Cc: Kinney, Michael D >Subject: [PATCH v4 06/41] OvmfP

Re: [edk2] [PATCH v4 02/41] OvmfPkg: Sec: force reinit of BaseExtractGuidedSectionLib handler table

2015-11-04 Thread Kinney, Michael D
3, 2015 1:01 PM >To: edk2-de...@ml01.01.org >Cc: Kinney, Michael D; Justen, Jordan L >Subject: [PATCH v4 02/41] OvmfPkg: Sec: force reinit of >BaseExtractGuidedSectionLib handler table > >BaseExtractGuidedSectionLib uses a table at the static physical address >PcdGuidedExt

Re: [edk2] C Coding Standards Specification disappeared

2015-11-05 Thread Kinney, Michael D
Laszlo, I agree cast operators need their own rule in the coding standard. I prefer to use () with sizeof(). For example, some compilers do not seem to like sizeof CHAR16, but they work with sizeof (CHAR16). Mike >-Original Message- >From: edk2-devel

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Kinney, Michael D
th >= 256 VCPUs? Thanks, Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, November 04, 2015 2:41 AM >To: Paolo Bonzini; edk2-de...@ml01.01.org; Kinney, Michael D; Fan, Jeff; >Justen, Jordan L >Subject: Re: [edk2] [PATCH v4 18/41

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-30 Thread Kinney, Michael D
t;From: Yao, Jiewen >Sent: Friday, October 30, 2015 7:18 AM >To: Laszlo Ersek; Kinney, Michael D; Fan, Jeff >Cc: Justen, Jordan L; edk2-devel-01 >Subject: RE: [edk2] about the SMM_S3_RESUME_SMM_64 branch in >S3Resume2Pei > >Yes, first, thanks the great analysis from Laszlo. >

Re: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build environment if it is set.

2015-11-05 Thread Kinney, Michael D
already been updated is os.environ. Reviewed-by: Michael Kinney <michael.d.kin...@intel.com> Mike >-Original Message- >From: Gao, Liming >Sent: Thursday, November 05, 2015 5:30 PM >To: Kinney, Michael D; edk2-devel@lists.01.org >Subject: RE: [edk2] [Patch] BaseTools

Re: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build environment if it is set.

2015-11-05 Thread Kinney, Michael D
ormcase(os.path.normpath(os.environ["PACKAGES_PATH"] Mike >-Original Message- >From: Gao, Liming >Sent: Thursday, November 05, 2015 4:58 PM >To: Kinney, Michael D; edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: RE: [edk2] [Patch] BaseTools: Print PAC

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-05 Thread Kinney, Michael D
-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, November 05, 2015 3:15 AM >To: Kinney, Michael D; edk2-de...@ml01.01.org >Cc: Justen, Jordan L >Subject: Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG- >as-SMRAM during PEI >

Re: [edk2] C Coding Standards Specification disappeared

2015-11-05 Thread Kinney, Michael D
Laszlo, The semi-formal way is to discuss these types of change requests on this mailing list and get agreement. I think your suggestion to add a new horizontal spacing rule that there should be no space between cast operator and cast operand is good. I will collect results of these

Re: [edk2] [PATCH] ArmPkg/BdsLib: Increase fallback tftp buffer size

2015-11-06 Thread Kinney, Michael D
Hi, There are macros in MdePkg/Include/Base.h that help align values and pointers to the next boundary. This patch could use the following: TftpBufferSize = ALIGN_VALUE (TftpBufferSize, SIZE_16MB); /** Rounds a value up to the next boundary using a specified alignment. This

Re: [edk2] [PATCH v3 51/52] OvmfPkg: double the SMRAM (TSEG) size for the 64-bit DXE phase builds

2015-10-16 Thread Kinney, Michael D
Laszlo, The PCD setting for TSEG size needs to be set for both IA32 and X64 modules in OvmfPkg/OvmfPkgIa32X64.dsc. The this current patch, TSEG PCD is set to DEC default value for PEIMs of 1MB and 2MB for DXE/SMM phase. This causes SMM Core to only see 1MB SMRAM area. I found this when

Re: [edk2] [PATCH v3 04/52] UefiCpuPkg: CpuDxe: broadcast MTRR changes to APs

2015-10-16 Thread Kinney, Michael D
Laszlo, Here is a proposed fix on top of your v3 patch services to address a race condition that was introduced by the v3 patch series call to StartupAllAPs() with SingleThread set to TRUE in the MP initialization. If the APs have not entered their idle loop before StartupAllAPs() is called,

Re: [edk2] SMM core problems

2015-10-15 Thread Kinney, Michael D
Dimiri, Can you please clarify what OS move operation is being performed? Memory ranges of type EfiRuntimeServicesData must remain at the same physical address. When SetVirtualAddressMap() is called, the OS can specify a virtual address that is different than the physical address, but the

Re: [edk2] [PATCH 7/7] UefiCpuPkg: Add missing UefiCpuPkgTokenSpace include

2015-10-07 Thread Kinney, Michael D
- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, October 07, 2015 10:38 AM To: Kinney, Michael D; edk2-de...@ml01.01.org Subject: Re: [edk2] [PATCH 7/7] UefiCpuPkg: Add missing UefiCpuPkgTokenSpace include On 10/05/15 01:57, Michael Kinney wrote: > Add missing include fi

Re: [edk2] [PATCH 6/7] UefiCpiPkg: Add PiSmmCpuDxeSmm module

2015-10-07 Thread Kinney, Michael D
Hi Laszlo, Thanks for the feedback! Please let me know if I missed any of your questions. Mike >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Wednesday, October 07, 2015 10:32 AM >To: Kinney, Michael

Re: [edk2] [PATCH v3] Pkg-Module: Integrate new RngLib into RngDxe

2015-10-08 Thread Kinney, Michael D
LONG, Qin, Do you know if the 10uS delay required in RdRandGetSeed128()? Thanks, Mike >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Long, >Qin >Sent: Wednesday, October 07, 2015 8:44 PM >To: Justen, Jordan L; Thomas Palmer;

Re: [edk2] [PATCH 7/7] UefiCpuPkg: Add missing UefiCpuPkgTokenSpace include

2015-10-08 Thread Kinney, Michael D
le.com [mailto:af...@apple.com] >Sent: Thursday, October 08, 2015 8:03 AM >To: Laszlo Ersek >Cc: Kinney, Michael D; edk2-de...@ml01.01.org >Subject: Re: [edk2] [PATCH 7/7] UefiCpuPkg: Add missing >UefiCpuPkgTokenSpace include > > >> On Oct 8, 2015, at 4:22 AM, Laszlo Ersek <l

Re: [edk2] [PATCH v2 00/16] UefiCpuPkg: Add CPU SMM and SecCore

2015-10-15 Thread Kinney, Michael D
Hi Jeff, I have addressed the feedback you sent on code style issues. 1) Fix function header comment blocks. 2) Added missing .h files to PisSmmCpuDxeSmm INF file. I have posted a V3 public branch with your feedback incorporated at:

Re: [edk2] [PATCH v4 04/19] UefiCpuPkg: CpuDxe: Wait for APs to enter idle loop

2015-10-19 Thread Kinney, Michael D
can minimize the wait time for all AP sync operations. Thanks, Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Monday, October 19, 2015 6:57 AM >To: Kinney, Michael D; edk2-de...@ml01.01.org >Cc: Fan, Jeff >Subject: Re: [PATCH v4 04/19] UefiCpuPkg:

Re: [edk2] [PATCH v4 17/19] UefiCpuPkg: Add PiSmmCpuDxeSmm module no IA32/X64 files

2015-10-19 Thread Kinney, Michael D
5 7:51 AM >To: Kinney, Michael D; edk2-de...@ml01.01.org >Cc: Paolo Bonzini >Subject: Re: [PATCH v4 17/19] UefiCpuPkg: Add PiSmmCpuDxeSmm module no >IA32/X64 files > >On 10/19/15 16:20, Laszlo Ersek wrote: >> On 10/19/15 09:44, Michael Kinney wrote: >>> Add module that

Re: [edk2] SMM core problems

2015-10-19 Thread Kinney, Michael D
Dimitri, Yes. A virtual mapping to the physical pages with the RT attribute may be provided by the OS if the OS calls SetVirtualAddressMap(). The UEFI Spec quote below shows that some of the structures passed from firmware to OS contain physical pointers that are not fixed up when

Re: [edk2] [PATCH v4 03/19] UefiCpuPkg: CpuDxe: broadcast MTRR changes to APs

2015-10-19 Thread Kinney, Michael D
t;From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Monday, October 19, 2015 6:43 AM >To: Kinney, Michael D; edk2-de...@ml01.01.org >Cc: edk2-devel >Subject: Re: [edk2] [PATCH v4 03/19] UefiCpuPkg: CpuDxe: broadcast MTRR >changes to APs > &

Re: [edk2] [PATCH v3 01/52] UefiCpuPkg: CpuDxe: Fix ASSERT() when only 1 CPU detected

2015-10-20 Thread Kinney, Michael D
Bruce, No. Different ASSERT(). That looks like a new bug, and it is in the new code I added to force BSP to wait for all APs to enter sleeping state before StartupAllAPs() is called. How did you reproduce this? Thanks, Mike >-Original Message- >From: edk2-devel

Re: [edk2] [PATCH v3 00/52] OvmfPkg: support SMM for better security (steps towards MP and X64)

2015-10-14 Thread Kinney, Michael D
== EFI_SUCCESS || Status == EFI_NOT_STARTED); Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, October 14, 2015 3:26 PM >To: edk2-de...@ml01.01.org >Cc: Paolo Bonzini; Justen, Jordan L; Kinney, Michael D >Subject: [PATCH v3 00/52] Ov

Re: [edk2] [PATCH v3 04/52] UefiCpuPkg: CpuDxe: broadcast MTRR changes to APs

2015-10-17 Thread Kinney, Michael D
o:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Friday, October 16, 2015 11:04 PM >To: Kinney, Michael D; edk2-de...@ml01.01.org >Subject: Re: [edk2] [PATCH v3 04/52] UefiCpuPkg: CpuDxe: broadcast MTRR >changes to APs > >On 10/16/15 23:17, Kinney, Michael D w

Re: [edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe

2015-10-06 Thread Kinney, Michael D
Thomas, I think it would make this module simpler if you just use the 64-bit variant. Mike -Original Message- From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] Sent: Tuesday, October 06, 2015 11:00 AM To: Kinney, Michael D; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] Pkg

Re: [edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe

2015-10-06 Thread Kinney, Michael D
Thomas, In other EDK II functions, we use the name "Uintn" instead of "Word" for a function that returns a value that is the natural size of the executing CPU. Also, I do not think you need the internal work function to generate a natural sized random number. Both IA32 and X64 versions the

Re: [edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe v2

2015-10-06 Thread Kinney, Michael D
Thomas, How about something like below to further simplify to one function and handle alignment issues. Also, do you know where the 10us delay comes from in RdRandGetSeed128()? Is there a pointer to a document? EFI_STATUS EFIAPI RdRandGetBytes ( IN UINTN Length, OUT UINT8

Re: [edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe v2

2015-10-06 Thread Kinney, Michael D
Thomas, Given that there is HW that can generate random number that big, I think it makes sense to add an API to RngLib for 128 bit values. Mike -Original Message- From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] Sent: Tuesday, October 06, 2015 4:19 PM To: Kinney, Michael D; edk2

Re: [edk2] [PATCH 0/7] UefiCpuPkg: Add CPU SMM and SecCore

2015-10-13 Thread Kinney, Michael D
>-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, October 13, 2015 11:42 AM >To: Kinney, Michael D; edk2-de...@ml01.01.org >Subject: Re: [edk2] [PATCH 0/7] UefiCpuPkg: Add CPU SMM and SecCore > >Mike, > >On 10/05/15 01:57, Michael Kinney

Re: [edk2] [PATCH 2/3] OvmfPkg: Fix VS20xx and DebugAgent ASSERT()

2015-10-13 Thread Kinney, Michael D
. Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, October 13, 2015 11:56 AM >To: Justen, Jordan L; Kinney, Michael D; edk2-de...@ml01.01.org >Subject: Re: [edk2] [PATCH 2/3] OvmfPkg: Fix VS20xx and DebugAgent ASSERT() > >On 1

Re: [edk2] [PATCH 6/7] UefiCpiPkg: Add PiSmmCpuDxeSmm module

2015-10-09 Thread Kinney, Michael D
Laszlo, Thanks for the feedback. I agree I need to update UefiCpuPkg DSC file. Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, October 09, 2015 6:57 AM >To: Kinney, Michael D >Cc: edk2-de...@ml01.01.org >Subject: Re: [edk2] [PAT

Re: [edk2] [Patch 2/2] UefiCpuPkg/SmmFeatureLib: Check SmmFeatureControl by Code_Access_Chk

2015-11-18 Thread Kinney, Michael D
Reviewed-by: Michael Kinney <michael.d.kin...@intel.com> Mike -Original Message- From: Fan, Jeff Sent: Tuesday, November 17, 2015 10:45 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Pat

Re: [edk2] [PATCH V2 03/12] MdeModulePkg BaseSerialPortLib16550: Add GetControl/SetControl/SetAttributes implementation

2015-11-18 Thread Kinney, Michael D
[mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, November 17, 2015 3:07 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com>; Gao, Liming <liming@intel.com> &g

Re: [edk2] [Patch 1/2] UefiCpuPkg: Not touch SmmFeatureControl if Code_Access_Chk not Set

2015-11-18 Thread Kinney, Michael D
Reviewed-by: Michael Kinney <michael.d.kin...@intel.com> Mike -Original Message- From: Fan, Jeff Sent: Tuesday, November 17, 2015 10:45 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Pat

Re: [edk2] [PATCH V2 01/12] MdePkg SerialPortLib: Upstream GetControl/SetControl/SetAttributes interfaces

2015-11-18 Thread Kinney, Michael D
o:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, November 17, 2015 3:07 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <liming@intel.com> > Subject: [edk2] [PATCH V2 01/12] Md

Re: [edk2] [PATCH V2 04/12] MdeModulePkg: Upstream SerialDxe from EmbeddedPkg

2015-11-18 Thread Kinney, Michael D
o:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, November 17, 2015 3:07 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com>; Gao, Liming <liming@intel.com> > Sub

Re: [edk2] [PATCH V2 00/12] Upstream SerialDxe from EmbeddedPkg to MdeModulePkg

2015-11-18 Thread Kinney, Michael D
Star, I think I am seeing some files with incorrect line endings in this patch series. Please make sure you use the BaseTools\Scripts\PatchCheck.py script. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent:

Re: [edk2] [PATCH V2 02/12] PcAtChipsetPkg SerialIoLib: Add GetControl/SetControl/SetAttributes implementation

2015-11-18 Thread Kinney, Michael D
[mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, November 17, 2015 3:07 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Ni, Ruiyu > <ruiyu...@intel.com>; Gao, Liming <liming@intel.com> >

Re: [edk2] [PATCH V2 00/12] Upstream SerialDxe from EmbeddedPkg to MdeModulePkg

2015-11-18 Thread Kinney, Michael D
Star, It looks like the function header comment block for SerialPortSetAttributes() has the same issues in all patches in this series. Please make sure to apply my feedback to patch 1/12 to all patches in the series. Thanks, Mike > -Original Message- > From: Kinney, Michael D

Re: [edk2] VS tools version and code size

2015-09-15 Thread Kinney, Michael D
Hi Matthew, I am not seeing large differences in size using the default flags from tools_def.txt. Here are some measurements of the DxeCore.efi module in MdeModulePkg/Core/Dxe. I have included the LZMA compressed size too because that the most common compression for FVs/Modules. TARGET

Re: [edk2] Where do I find the system table address for an EFI app ?

2015-12-02 Thread Kinney, Michael D
Shubha, You can run the dmem command from the UEFI shell with no parameters, and it will show the UFI System Table address along with other standard table addresses. Shell> dmem Memory Address 0FD6E010 200 Bytes 0FD6E010: 49 42 49 20 53 59 53 54-32 00 02 00 48 00 00 00 *IBI

Re: [edk2] [Patch V3] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-08 Thread Kinney, Michael D
*Divisor++; *BaudRate = ClockRate / ((UINTN)(*Divisor) << 4); return TRUE; Best regards, Mike > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, December 8, 2015 1:08 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Tian, Feng <feng

Re: [edk2] [Patch V3] ShellPkg/mm: Fix mm to support multiple root bridge platform

2015-12-08 Thread Kinney, Michael D
the latest version of trunk. Thanks, Mike > -Original Message- > From: Ni, Ruiyu > Sent: Monday, December 7, 2015 9:15 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > Subject: RE: [edk2]

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
Paolo, The RTC driver runs and produces the runtime services before the ACPI tables are available so what you suggest is not always possible. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Paolo > Bonzini > Sent: Wednesday, December

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
) is that it is compatible with existing ACPI Table implementations. Mike > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, December 9, 2015 9:40 AM > To: Laszlo Ersek <ler...@redhat.com>; Kinney, Michael D > <michael.d.kin...@inte

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
nal Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, December 9, 2015 8:42 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; Ni, Ruiyu > <ruiyu...@intel.com>; Scott Duplichan <sc...@notabs.org> > Cc: 'edk2-devel@lists.01

Re: [edk2] [Patch 6/6] OvmfPkg: Fix VS2015 warning C4459 in XenBusDxe

2015-12-03 Thread Kinney, Michael D
Liming, The source changes look good to me and I have verified that all 3 OVMF DSC files build with VS2015. Acked-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao >

Re: [edk2] InsertImageRecord and Section Alignment

2015-12-03 Thread Kinney, Michael D
message you are seeing is not an error. It is a warning message that a runtime driver was loaded that does not meet the requirements to set this bit. Mike > -Original Message- > From: Hamel, Lee M > Sent: Thursday, December 3, 2015 11:19 AM > To: Kinney, Michael D &l

Re: [edk2] [Patch 4/6] MdeModulePkg: Fix VS2015 warning C4311 & C4312 in RegularExpressionDxe

2015-12-03 Thread Kinney, Michael D
Liming, The source changes look good to me and I have verified that RegularExpressionDxe builds with VS2015. I will let Samer do the review. Acked-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]

Re: [edk2] [Patch 5/6] CryptoPkg: Disable VS2015 warning C4311 in OpensslLib

2015-12-03 Thread Kinney, Michael D
Liming, Reviewed-by: Michael Kinney I have also verified that builds of the CryptoPkg complete with VS2015 for IA32 and X64. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao > Sent:

Re: [edk2] [Patch 3/6] MdeModulePkg: Fix VS2015 warning C4456 in RegularExpressionDxe

2015-12-03 Thread Kinney, Michael D
Liming, The source changes look good to me and I have verified that RegularExpressionDxe builds with VS2015. I will let Samer do the review. Acked-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] InsertImageRecord and Section Alignment

2015-12-03 Thread Kinney, Michael D
Lee, You can fix this by adding the following to the DSC file to force modules of type DXE_RUNTIME_DRIVER to use 4KB alignment. [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] MSFT:*_*_*_DLINK_FLAGS = /ALIGN:4096 Mike > -Original Message- > From: edk2-devel

Re: [edk2] InsertImageRecord and Section Alignment

2015-12-03 Thread Kinney, Michael D
to:ler...@redhat.com] > Sent: Thursday, December 3, 2015 3:36 PM > To: Kinney, Michael D <michael.d.kin...@intel.com> > Cc: Hamel, Lee M <lee.m.ha...@intel.com>; edk2-devel@lists.01.org > <edk2-de...@ml01.01.org> > Subject: Re: [edk2] InsertImageRecord and Section Alignment &g

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-03 Thread Kinney, Michael D
y, December 2, 2015 9:13 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > Cc: edk2-devel@lists.01.org; Tian, Feng <feng.t...@intel.com> > Subject: RE: [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver > > Suggest to u

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-03 Thread Kinney, Michael D
age- > From: Kinney, Michael D > Sent: Thursday, December 3, 2015 4:00 PM > To: Tian, Feng <feng.t...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Kinney, > Michael D <michael.d.kin...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: RE: [Patch 1/2] MdeModulePkg:

Re: [edk2] [PATCH 1/3] BaseTools/Scripts: Add ConvertUtf16ToUtf8.py script

2015-12-02 Thread Kinney, Michael D
Jordan, Do the UTF-8 files generated include a BOM? Just in case someone depends on UNI files in UTF-16LE format, do you think it makes sense for this script to support conversion to from UTF-8 to UTF-16LE too? Or add a second script to that conversion? Thanks, Mike > -Original

Re: [edk2] [Patch 2/6] MdeModulePkg: Fix VS2015 warning C4459 in DriverSampleDxe

2015-12-03 Thread Kinney, Michael D
Liming, Reviewed-by: Michael Kinney I have also verified that builds of the MdeModulePkg/Universal/DriverSampleDxe complete with VS2015 for IA32 and X64. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] InsertImageRecord and Section Alignment

2015-12-07 Thread Kinney, Michael D
Jiewen, I agree that is a good place to put the error message. Mike > -Original Message- > From: Yao, Jiewen > Sent: Sunday, December 6, 2015 7:06 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; Laszlo Ersek > <ler...@redhat.com>; Kinney,

Re: [edk2] [PATCH 1/3] BaseTools/Scripts: Add ConvertUtf16ToUtf8.py script

2015-12-02 Thread Kinney, Michael D
Jordan, Good. I was hoping it did not add the BOM...because that would still be a binary file I think. I really appreciate you working on the reverse conversion. Mike > -Original Message- > From: Justen, Jordan L > Sent: Wednesday, December 2, 2015 4:25 PM > To: Kinne

Re: [edk2] MdeModulePkg: DebugAssert enhancement

2015-12-02 Thread Kinney, Michael D
Baranee, I also think the following line could be changed for smaller code gen from: + ModuleNameSize = AsciiStrLen("[") + AsciiStrLen (gEfiCallerBaseName) + AsciiStrLen("] "); To: + // + // Compute string size of module name enclosed by [] + // + ModuleNameSize = 2 + AsciiStrSize

Re: [edk2] [Patch V4] ShellPkg/mm: Fix mm to support multiple root bridge platform

2015-12-09 Thread Kinney, Michael D
Ray, Looks good. Reviewed-by: Michael Kinney <michael.d.kin...@intel.com> Mike > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, December 8, 2015 10:45 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Kinney, Michael D &g

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
Ray, Do you prefer PCD solution? Mike > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, December 9, 2015 4:45 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; Laszlo Ersek > <ler...@redhat.com> > Cc: Paolo Bonzini <pbonz...@redhat.com>

Re: [edk2] [Patch] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-09 Thread Kinney, Michael D
u <ruiyu...@intel.com>; Tian, Feng <feng.t...@intel.com>; Kinney, > Michael D <michael.d.kin...@intel.com> > Subject: [Patch] MdeModulePkg: Add PciSioSerialDxe driver > > PciSioSerialDxe driver can manages UARTs on a SIO chip or a PCI/PCIE > card. > It manages the SI

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

2015-12-15 Thread Kinney, Michael D
create the new edk2-non-osi repository on tianocore and import this content? Thanks, Mike > -Original Message- > From: Justen, Jordan L > Sent: Monday, December 14, 2015 11:47 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- > de...@lists.01.org (ed

Re: [edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

2015-12-16 Thread Kinney, Michael D
Samer, Yes. Thank you! Mike From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Wednesday, December 16, 2015 8:59 AM To: patrick.ma...@caviumnetworks.com; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: El-Haj-Mahmoud, Samer <samer.el

Re: [edk2] [Patch] MdePkg: Convert IoLibEbc.c source file to DOS format

2015-12-16 Thread Kinney, Michael D
Liming, Thanks for fixing this. Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On > Behalf Of Liming Gao > Sent: Wednesday, December 16, 2015 11:22 PM > To: edk2-devel@lists.01.org >

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

2015-12-13 Thread Kinney, Michael D
iginal Message- > From: Justen, Jordan L > Sent: Saturday, December 12, 2015 9:31 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- > de...@lists.01.org (edk2-devel@lists.01.org) de...@lists.01.org> > Subject: RE: [edk2] [PATCH] Add QuarkSocPkg and Quark

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

2015-12-15 Thread Kinney, Michael D
QuarkSocPkg committed as SVN r19286 QuarkPlatformPkg committed as SVN r19287 > -Original Message- > From: Justen, Jordan L > Sent: Tuesday, December 15, 2015 11:30 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- > de...@lists.01.org (edk2-devel@lists

Re: [edk2] InsertImageRecord and Section Alignment

2015-12-15 Thread Kinney, Michael D
-devel [mailto:edk2-devel-boun...@lists.01.org] On > Behalf Of Anbazhagan, Baraneedharan > Sent: Tuesday, December 15, 2015 8:31 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; Yao, Jiewen > <jiewen@intel.com>; Laszlo Ersek <ler...@redhat.com> > Cc: Hamel

Re: [edk2] InsertImageRecord and Section Alignment

2015-12-15 Thread Kinney, Michael D
RUNTIME_DRIVER] >MSFT:*_*_*_DLINK_FLAGS = /ALIGN:4096 > > Thanks, > Baranee > > > -Original Message- > > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > > Sent: Tuesday, December 15, 2015 6:57 PM > > To: Anbazhagan, Baraneedharan <an

Re: [edk2] [PATCH v2 00/20] Convert utf-16 .uni files to utf-8

2015-12-10 Thread Kinney, Michael D
Jordan, I have reviewed the whole series. Thanks for all the work on this! Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On > Behalf Of Jordan Justen > Sent: Friday, December 4, 2015

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
> -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, December 9, 2015 10:48 AM > To: Laszlo Ersek <ler...@redhat.com> > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Paolo Bonzini > <pbonz...@redhat.com>; Scott Duplichan <sc...@notabs.org>; >

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

2015-12-10 Thread Kinney, Michael D
; To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- > de...@lists.01.org (edk2-de...@ml01.01.org) de...@lists.01.org> > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > Subject: Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg > packages > > On

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

2015-12-10 Thread Kinney, Michael D
files to utf-8 5) Replace tabs with spaces and remove trailing spaces 6) Add License.txt Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney <michael.d.kin...@intel.com> Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursd

Re: [edk2] [Patch] ShellPkg/Mm: Fix build warnings

2015-12-14 Thread Kinney, Michael D
Jaben, Eric Tian made the commit. Can you please verify that it was rebased correctly. Thanks, Mike > -Original Message- > From: Carsey, Jaben > Sent: Monday, December 14, 2015 8:12 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- > de...@lists.0

Re: [edk2] [PATCH v3 2/7] MdeModulePkg: Add IpmiLib and Ppi/Protocol header file.

2015-12-22 Thread Kinney, Michael D
Daocheng Bu, This patch appears to contain both additions to the DEC file and white space clean up of the DEC file. Can you please split these into separate patches? Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Daocheng

Re: [edk2] how to develop an UEFI runtime driver

2015-12-22 Thread Kinney, Michael D
A good place to start is the UEFI Driver Writer's Guide https://github.com/tianocore/tianocore.github.io/wiki/UEFI-Driver-Writer's-Guide Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > LiHongcheng > Sent: Tuesday, December 22, 2015

  1   2   3   4   5   6   7   8   9   10   >