Re: [edk2] [Patch 2/3] OvmfPkg: use new BDS and UiApp in MdeModulePkg

2015-08-12 Thread Laszlo Ersek
Continuing: On 08/12/15 00:53, Laszlo Ersek wrote: On 08/03/15 07:41, Ruiyu Ni wrote: Compare to the old BDS, the new BDS separates the UI part to a standalone application UiApp. QemuBootOrderLib was changed to depend on the UefiBootManagerLib. I've covered the following files thus far

Re: [edk2] [Patch 2/3] OvmfPkg: use new BDS and UiApp in MdeModulePkg

2015-08-11 Thread Laszlo Ersek
ruiyu...@intel.com Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Laszlo Ersek ler...@redhat.com --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 1438 .../Library/PlatformBootManagerLib/BdsPlatform.h | 246 .../Library/PlatformBootManagerLib

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-08 Thread Laszlo Ersek
On 08/08/15 08:13, Benjamin Herrenschmidt wrote: Hi ! I'm still trying to get my head around the internals of EDK here so bear with me if there's an obvious answer that I missed ... :-) I'm trying to understand how I can properly reserve bits of memory from my PrePei or Pei so that DXE

Re: [edk2] [PATCH] BaseTools X64: prevent .eh_frame sections from being generated

2015-08-12 Thread Laszlo Ersek
. So I modified GCC44_IA32_CC_FLAGS similarly, just for build-testing the OvmfPkgIa32.dsc platform, and the flag works for that too. Please include the GCC44_IA32_CC_FLAGS change as well, and repost with: Reviewed-by: Laszlo Ersek ler...@redhat.com Build-tested-by: Laszlo Ersek ler...@redhat.com

Re: [edk2] [PATCH 11/15] OvmfPkg: Link separated VarCheckUefiLib NULL class library instance

2015-08-21 Thread Laszlo Ersek
On 08/17/15 10:24, Star Zeng wrote: Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Laszlo Ersek ler...@redhat.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng star.z...@intel.com --- OvmfPkg/OvmfPkgIa32.dsc| 5 - OvmfPkg/OvmfPkgIa32X64.dsc | 5

Re: [edk2] [PATCH 04/15] OvmfPkg: Add VarCheckLib library mapping

2015-08-21 Thread Laszlo Ersek
On 08/17/15 10:23, Star Zeng wrote: Since Variable driver has been updated to consume the separated VarCheckLib. Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Laszlo Ersek ler...@redhat.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng star.z

Re: [edk2] [PATCH v2 2/2] OvmfPkg: Add HttpBoot support

2015-08-21 Thread Laszlo Ersek
.fdf | 5 + 6 files changed, 45 insertions(+) Reviewed-by: Laszlo Ersek ler...@redhat.com Please ask Siyuan, Jordan, or Ard to commit this for you. Laszlo diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index 4ab618d..9a6de15 100644 --- a/OvmfPkg/OvmfPkgIa32.dsc

Re: [edk2] [PATCH v3 2/2] OvmfPkg: Add HttpBoot support

2015-08-21 Thread Laszlo Ersek
.dsc | 10 ++ OvmfPkg/OvmfPkgX64.fdf | 5 + 6 files changed, 45 insertions(+) Reviewed-by: Laszlo Ersek ler...@redhat.com diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index 4ab618d..9a6de15 100644 --- a/OvmfPkg/OvmfPkgIa32.dsc +++ b/OvmfPkg/OvmfPkgIa32

Re: [edk2] Measured boot in OVMF with QEMU TPM passthrough?

2015-08-21 Thread Laszlo Ersek
On 08/21/15 18:44, David Van Arnem wrote: Hello again, I've done some analysis and here's where I'm at with measured boot with OVMF in a QEMU guest: I've verified that most of the relevant modules that need to be added according to the instructions at

Re: [edk2] [PATCH 13/15] ArmVirtPkg: Link separated VarCheckUefiLib NULL class library instance

2015-08-21 Thread Laszlo Ersek
On 08/18/15 14:05, Ard Biesheuvel wrote: On 17 August 2015 at 10:24, Star Zeng star.z...@intel.com wrote: Cc: Laszlo Ersek ler...@redhat.com Cc: Ard Biesheuvel ard.biesheu...@linaro.org Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng star.z...@intel.com

Re: [edk2] [PATCH v2 00/16] unify GCC command line options

2015-08-18 Thread Laszlo Ersek
On 08/18/15 22:04, Paolo Bonzini wrote: On 18/08/2015 08:52, Ard Biesheuvel wrote: Personally, I would not mind deprecating GCC44, but the biggest question I would have is what toolchains do the latest UDK releases claim to support. We also have the issue that every time I ask about

Re: [edk2] [PATCH 2/2] CryptoPkg/OpensslLib: Undefine NO_BUILTIN_VA_FUNCS to fix varargs breakage

2015-07-30 Thread Laszlo Ersek
On 07/30/15 13:37, David Woodhouse wrote: On Tue, 2015-07-28 at 20:26 +0200, Laszlo Ersek wrote: series (up to and including 3/2) Tested-by: Laszlo Ersek ler...@redhat.com If you did this by pulling my tree, rather than manually applying patches — which I'm fairly sure you did — then you

Re: [edk2] efi acpidump port

2015-07-30 Thread Laszlo Ersek
On 07/30/15 01:27, Andrew Fish wrote: On Jul 29, 2015, at 4:11 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-07-29 13:43:43, Smith, Jonathan D wrote: Attaching a zip of the files -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-04 Thread Laszlo Ersek
On 08/04/15 05:16, Ni, Ruiyu wrote: No. I forgot to emphasize that I only tested the QEMU boot timeout feature after changing the QemuBootOrderLib. I don't know how to test the boot order feature. This series, on the surface, seems intrusive and to have potential to cause many

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-04 Thread Laszlo Ersek
On 08/04/15 12:53, Laszlo Ersek wrote: No matter how carefully we review and test the new code, something will inevitably break, This wasn't meant as lack of trust in your code; it's just that there are many cases and corner cases in the related OVMF code, and it's quite hard to test them all

Re: [edk2] BaseTools features: multiple workspaces

2015-08-04 Thread Laszlo Ersek
On 08/03/15 19:35, Jordan Justen wrote: On 2015-08-03 02:08:14, Gao, Liming wrote: Paolo: I think that keep the exiting syntax for WORKSPACE to be a single path can minimize the impacts to exiting tools that assume a single workspace. I know you originally suggested to use WORKSPACE,

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-04 Thread Laszlo Ersek
On 08/04/15 12:42, David Woodhouse wrote: On Tue, 2015-08-04 at 03:16 +, Ni, Ruiyu wrote: I forgot to emphasize that I only tested the QEMU boot timeout feature after changing the QemuBootOrderLib. I don't know how to test the boot order feature. For the SeaBIOS CSM, can you tell me how

Re: [edk2] [PATCH] Check arguments for PrintLib format format string

2015-08-04 Thread Laszlo Ersek
On 08/04/15 03:19, Scott Duplichan wrote: Andrew Fish [mailto:af...@apple.com] wrote: ]Sent: Monday, August 03, 2015 04:48 PM ]To: Scott Duplichan sc...@notabs.org ]Cc: edk2-devel@lists.01.org edk2-de...@ml01.01.org; Laszlo Ersek ler...@redhat.com ]Subject: Re: [edk2] [PATCH] Check

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Laszlo Ersek
On 08/04/15 11:44, Zeng, Star wrote: -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, August 4, 2015 5:25 PM To: Zeng, Star; Justen, Jordan L Cc: Paolo Bonzini; edk2-de...@ml01.01.org; Yao, Jiewen Subject: Re

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Laszlo Ersek
Star, On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD PcdSetNxForStack is added to turn on/off this feature, and it is FALSE by default. diff --git a/MdeModulePkg/MdeModulePkg.dec

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Laszlo Ersek
On 08/04/15 10:38, Sharma Bhupesh wrote: -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, August 04, 2015 2:01 PM On 4 August 2015 at 10:07, Sharma Bhupesh bhupesh.sha...@freescale.com wrote: With the EFI_STUB becoming more or less mandatory

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Laszlo Ersek
On 08/04/15 10:59, Zeng, Star wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 4, 2015 4:34 PM To: Zeng, Star Cc: edk2-de...@ml01.01.org; Yao, Jiewen; Paolo Bonzini Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Laszlo Ersek
On 08/04/15 09:57, Ard Biesheuvel wrote: LinuxLoader has been split off from the ARM BDS into a separate EFI application. Because we never included this application into the ArmVirtPkg platforms, its ARM BDS builds have effectively been broken ever since that change was merged. Let's fix

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default

2015-08-04 Thread Laszlo Ersek
On 08/04/15 14:40, Ard Biesheuvel wrote: ARM BDS support in ArmVirtQemu has been broken since SVN r17969 (ArmPkg/BdsLib: Remove Linux loader from BdsLib) dated July 14th. Instead of fixing this, let's get rid of the ARM BDS and LinuxLoader altogether: they violate both the UEFI spec and the

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: add LinuxLoader UEFI app to ARM build

2015-08-04 Thread Laszlo Ersek
/LinuxLoader/LinuxLoader.inf +!endif + [FV.FVMAIN_COMPACT] FvAlignment= 16 ERASE_POLARITY = 1 Looks good. But, since you are going to submit a new version of the other patch, can you post a two-part series instead, with that patch and this patch? Reviewed-by: Laszlo Ersek ler

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: add LinuxLoader UEFI app to ARM build

2015-08-04 Thread Laszlo Ersek
On 08/04/15 15:41, Laszlo Ersek wrote: Looks good. But, since you are going to submit a new version of the other patch, can you post a two-part series instead, with that patch and this patch? Sorry, that's three patches (the Xen change is separate). Thanks Laszlo

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default

2015-08-04 Thread Laszlo Ersek
On 08/04/15 16:34, Ard Biesheuvel wrote: On 4 August 2015 at 15:35, Laszlo Ersek ler...@redhat.com wrote: On 08/04/15 14:40, Ard Biesheuvel wrote: ARM BDS support in ArmVirtQemu has been broken since SVN r17969 (ArmPkg/BdsLib: Remove Linux loader from BdsLib) dated July 14th. Instead

Re: [edk2] [PATCH] ArmVirtPkg: align ARM BDS build with LinuxLoader changes

2015-08-04 Thread Laszlo Ersek
On 08/04/15 11:21, Sharma Bhupesh wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 04, 2015 2:36 PM On 08/04/15 10:38, Sharma Bhupesh wrote: -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday

Re: [edk2] today's US CERT UEFI advisory

2015-07-30 Thread Laszlo Ersek
On 07/30/15 21:02, Andrew Fish wrote: On Jul 30, 2015, at 11:43 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/30/15 20:09, Andrew Fish wrote: I’m not sure that the commit messages is the best way to communicate the info, and something could get fixed prior CVE

Re: [edk2] [PATCH 2/4] ArmVirtPkg: use 'auto' alignment and FIXED placement for XIP modules

2015-07-30 Thread Laszlo Ersek
clang-specific rules (eg. by duplicating the current rules and restricting them with *_XCODE5_* and *_GCC4x_* respectively). ... I hope the above mishmash can be called review. :) Reviewed-by: Laszlo Ersek ler...@redhat.com ___ edk2-devel mailing list

Re: [edk2] more code sharing joy between OvmfPkg and ArmVirtPkg, re SMBIOS

2015-07-30 Thread Laszlo Ersek
On 07/30/15 20:54, Jordan Justen wrote: On 2015-07-30 10:09:34, Laszlo Ersek wrote: (Sigh, I left off the list address. This should be discussed publicly. Resending.) Clearly, the SMBIOS patches I posted and got committed last time are not good enough. That's because the SMBIOS 3.0 entry

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64)

2015-07-30 Thread Laszlo Ersek
On 07/27/15 15:52, Ard Biesheuvel wrote: On 27 July 2015 at 15:34, Liu, Yingke D yingke.d@intel.com wrote: Reviewed-by: Yingke Liu yingke.d@intel.com Thank you Committed as SVN r18077 ... r18080 I do have another question related to the use of FIXED in a [Rule] section: since

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization

2015-07-30 Thread Laszlo Ersek
On 07/31/15 01:31, Andrew Fish wrote: On Jul 30, 2015, at 4:17 PM, Laszlo Ersek ler...@redhat.com wrote: On 07/27/15 15:52, Ard Biesheuvel wrote: On 27 July 2015 at 15:34, Liu, Yingke D yingke.d@intel.com wrote: Reviewed-by: Yingke Liu yingke.d@intel.com Thank you Committed

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization

2015-07-30 Thread Laszlo Ersek
On 07/31/15 01:49, Ard Biesheuvel wrote: On 31 July 2015 at 01:17, Laszlo Ersek ler...@redhat.com wrote: On 07/27/15 15:52, Ard Biesheuvel wrote: On 27 July 2015 at 15:34, Liu, Yingke D yingke.d@intel.com wrote: Reviewed-by: Yingke Liu yingke.d@intel.com Thank you Committed as SVN

[edk2] [PATCH 0/9] OvmfPkg, ArmVirtPkg: SMBIOS 3.0, round 2

2015-07-31 Thread Laszlo Ersek
. Somlo so...@cmu.edu Thanks Laszlo Laszlo Ersek (9): OvmfPkg: SmbiosVersionLib: add plugin for detecting SMBIOS version OvmfPkg: set SMBIOS version in DetectSmbiosVersionLib instead of PlatformPei ArmVirtPkg: set SMBIOS version in DetectSmbiosVersionLib instead of QemuFwCfgToPcdDxe

[edk2] [PATCH 1/9] OvmfPkg: SmbiosVersionLib: add plugin for detecting SMBIOS version

2015-07-31 Thread Laszlo Ersek
: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.inf | 51 + OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.c | 76 2 files changed, 127 insertions(+) diff --git

[edk2] [PATCH 3/9] ArmVirtPkg: set SMBIOS version in DetectSmbiosVersionLib instead of QemuFwCfgToPcdDxe

2015-07-31 Thread Laszlo Ersek
Suggested-by: Jordan Justen jordan.l.jus...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf | 4 -- ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.c | 40 ArmVirtPkg

[edk2] [PATCH 4/9] ArmVirtPkg: revert ArmVirtPkg: add QemuFwCfgToPcdDxe

2015-07-31 Thread Laszlo Ersek
-by: Laszlo Ersek ler...@redhat.com --- ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf | 42 ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.c | 33 --- ArmVirtPkg/ArmVirtQemu.dsc | 1 - ArmVirtPkg/ArmVirtQemu.fdf | 2 - 4 files

[edk2] [PATCH 5/9] OvmfPkg: introduce PcdQemuSmbiosValidated

2015-07-31 Thread Laszlo Ersek
defaults for it in the OvmfPkg DSC files. Cc: Ard Biesheuvel ard.biesheu...@linaro.org Cc: Wei Huang w...@redhat.com Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Gabriel L. Somlo so...@cmu.edu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com

[edk2] [PATCH 6/9] ArmVirtPkg/ArmVirtQemu.dsc: set default for PcdQemuSmbiosValidated

2015-07-31 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek ler...@redhat.com --- ArmVirtPkg/ArmVirtQemu.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 618a158..8c842c7 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -237,6 +237,7

[edk2] [PATCH 7/9] OvmfPkg: SmbiosPlatformDxe: eliminate duplicate entry point validation

2015-07-31 Thread Laszlo Ersek
jordan.l.jus...@intel.com Cc: Gabriel L. Somlo so...@cmu.edu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.inf | 1 + OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 4

[edk2] [PATCH 9/9] OvmfPkg: SmbiosVersionLib: recognize SMBIOS 3.x entry point

2015-07-31 Thread Laszlo Ersek
: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.inf | 1 + OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.c | 17 + OvmfPkg/OvmfPkgIa32.dsc

[edk2] [PATCH 8/9] ArmVirtPkg: set default for PcdSmbiosDocRev

2015-07-31 Thread Laszlo Ersek
. Because we use that driver in the ArmVirtQemu.dsc platform, we must provide a default for the dynamic PCD. Cc: Ard Biesheuvel ard.biesheu...@linaro.org Cc: Wei Huang w...@redhat.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- ArmVirtPkg

[edk2] [PATCH 2/9] OvmfPkg: set SMBIOS version in DetectSmbiosVersionLib instead of PlatformPei

2015-07-31 Thread Laszlo Ersek
. Somlo so...@cmu.edu Suggested-by: Jordan Justen jordan.l.jus...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- OvmfPkg/PlatformPei/PlatformPei.inf | 2 - OvmfPkg/PlatformPei/Platform.c | 39 OvmfPkg

Re: [edk2] [PATCH 2/2] CryptoPkg/OpensslLib: Undefine NO_BUILTIN_VA_FUNCS to fix varargs breakage

2015-07-28 Thread Laszlo Ersek
in powershell in Windows). series (up to and including 3/2) Tested-by: Laszlo Ersek ler...@redhat.com I didn't try to mess with the clock, so if you wish, we can restrict my Tested-by to the first two patches, and add Regression-tested-by for the third. Thanks Laszlo

Re: [edk2] [PATCH 11/58] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-07-28 Thread Laszlo Ersek
On 07/25/15 01:00, Laszlo Ersek wrote: The EFI_SMM_COMMUNICATION_PROTOCOL implementation that is provided by the SMM core depends on EFI_SMM_CONTROL2_PROTOCOL; see the mSmmControl2-Trigger() call in the SmmCommunicationCommunicate() function [MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
On 07/28/15 09:33, Paolo Bonzini wrote: On 28/07/2015 09:09, Fan, Jeff wrote: I did not receive the patch 42. I have only gotten 38,39,40,41. OK, If this mtrr setting stored in ACPI NVS is for CpuS3DataDxe to store into SMRAM, that's fine. Then, another question, what's requirement to

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
On 07/28/15 08:51, Paolo Bonzini wrote: On 28/07/2015 08:05, Fan, Jeff wrote: Ersek, I have one comment for PCD PcdCpuSyncMtrrToAcpiNvs. I knew OvmfPkg implemented LockBox based on ACPI NVS. Saving MTRR setting in AcpiNVS is OK for OvmfPkg. If I understand correctly what you are

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
: Tuesday, July 28, 2015 3:34 PM To: Fan, Jeff; Laszlo Ersek; edk2-de...@ml01.01.org Cc: Chen Fan; Justen, Jordan L Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block On 28/07/2015 09:09, Fan, Jeff wrote: I did not receive the patch

Re: [edk2] How could I allocate aligned memory?

2015-07-28 Thread Laszlo Ersek
On 07/28/15 07:14, winddy wrote: Dear Experts, Now I want to allocate some reserved memory which should be aligned at 64MB. And if I use gBS-AllocatePages() it return OK(AllocateSize = NeedSize + AlignSize, then use ALIGN_VALUE()). But I think in this method I will waste much space for

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-29 Thread Laszlo Ersek
with regard to ClearSmi(). Thanks! Laszlo Thank you Yao Jiewen -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, July 29, 2015 3:31 AM To: Paolo Bonzini; Fan, Jeff; edk2-de...@ml01.01.org Cc: Chen Fan; Justen

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtXen: add missing BdsLib instance

2015-08-05 Thread Laszlo Ersek
/CustomizedDisplayLib.inf + BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf + [LibraryClasses.common.UEFI_DRIVER] UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf Reviewed-by: Laszlo Ersek ler...@redhat.com ___ edk2-devel mailing list edk2

Re: [edk2] [PATCH 0/9] OvmfPkg, ArmVirtPkg: SMBIOS 3.0, round 2

2015-08-05 Thread Laszlo Ersek
patches (they are easy and the idea in them was suggested by you (and I thank you for that)), (2) add Wei to the poster-without-subscription whitelist, in case that option is available in the mailing list software? Thank you Laszlo Thanks, -Wei On 7/31/15 13:40, Laszlo Ersek wrote: The SMBIOS

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Laszlo Ersek
On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD PcdSetNxForStack is added to turn on/off this feature, and it is FALSE by default. Cc: Jiewen Yao jiewen@intel.com

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Laszlo Ersek
On 08/05/15 18:18, Andrew Fish wrote: On Aug 5, 2015, at 8:41 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD

[edk2] more code sharing joy between OvmfPkg and ArmVirtPkg, re SMBIOS

2015-07-30 Thread Laszlo Ersek
(Sigh, I left off the list address. This should be discussed publicly. Resending.) Clearly, the SMBIOS patches I posted and got committed last time are not good enough. That's because the SMBIOS 3.0 entry point is structurally different from the prior versions (because why not). Therefore, now

Re: [edk2] more code sharing joy between OvmfPkg and ArmVirtPkg, re SMBIOS

2015-07-30 Thread Laszlo Ersek
(resending this one too) On 07/30/15 19:09, Laszlo Ersek wrote: (Sigh, I left off the list address. This should be discussed publicly. Resending.) Clearly, the SMBIOS patches I posted and got committed last time are not good enough. That's because the SMBIOS 3.0 entry point is structurally

Re: [edk2] [PATCH 11/58] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-07-30 Thread Laszlo Ersek
On 07/30/15 20:50, Paolo Bonzini wrote: On 28/07/2015 20:44, Laszlo Ersek wrote: I have a significant update for this patch. On S3 resume, the APMC_EN bit (and other bits) are cleared in SMI_EN (which is necessary, see qemu commit be66680e). For the trigger method to work right after S3

Re: [edk2] today's US CERT UEFI advisory

2015-07-30 Thread Laszlo Ersek
On 07/30/15 20:09, Andrew Fish wrote: On Jul 30, 2015, at 9:58 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/30/15 17:49, Blibbet wrote: FYI, in case any OEM's missed today's US-CERT UEFI vulnerability notice: http://firmwaresecurity.com/2015/07/30/us-cert-bios

Re: [edk2] [PATCH 0/4] StdLib: Add ARM SoftFloat AArch64 supports

2015-07-30 Thread Laszlo Ersek
On 07/30/15 04:21, Daryl McDaniel wrote: Now that we have received legal approval of the LLVM / University of Illinois license, I can say that this set of patches looks OK to me. 0. [PATCH 0/4] StdLib: Add ARM SoftFloat AArch64 supports 1. [PATCH 1/4] StdLib: Added BaseStackLib for

Re: [edk2] posting to the new list without subscription?

2015-07-30 Thread Laszlo Ersek
On 07/29/15 23:38, Jordan Justen wrote: On 2015-07-28 12:59:46, Laszlo Ersek wrote: Hi Jordan, what are the rules for posting to the new list without being subscribed? On the old list, I think we dropped all such emails. Currently we are rejecting them on the new list. Paolo posted

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-11 Thread Laszlo Ersek
Thanks a lot Andrew for the followup! I'll make a few comments: On 08/10/15 23:38, Andrew Fish wrote: On Aug 10, 2015, at 1:51 PM, Benjamin Herrenschmidt b...@kernel.crashing.org mailto:b...@kernel.crashing.org wrote: On Mon, 2015-08-10 at 20:14 +0200, Laszlo Ersek wrote: On 08/10/15 18:46

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-11 Thread Laszlo Ersek
On 08/11/15 01:01, Benjamin Herrenschmidt wrote: On Tue, 2015-08-11 at 08:08 +1000, Benjamin Herrenschmidt wrote: .../... That means that if I want to reserve memory elsewhere in the system, I need to either: - Make sure that chunk of memory is not covered by a memory resource

Re: [edk2] [PATCH 3/3] OvmfPkg/Xen: use lower case x in hex immediate value

2015-08-11 Thread Laszlo Ersek
actually (refer to 6.4.4.1 Integer constants: hexadecimal-prefix: one of 0x 0X ) but I find 0X terribly unreadable myself, so yeah. For this patch: Reviewed-by: Laszlo Ersek ler...@redhat.com For the other two patches in the series: Acked-by: Laszlo Ersek ler...@redhat.com Thanks Laszlo

Re: [edk2] Status of porting acpidump to edk2 ?

2015-08-11 Thread Laszlo Ersek
On 08/11/15 05:52, Andrew Fish wrote: On Aug 10, 2015, at 7:33 PM, Shubha Ramani shubharam...@yahoo.com wrote: I know people were attempting to port acpidump from https://www.acpica.org/ to EDK2. Any success ? I need it desperately. If you look at the mailing list history

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-11 Thread Laszlo Ersek
Laszlo -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 4, 2015 7:10 PM To: Ni, Ruiyu ruiyu...@intel.com Cc: edk2-de...@ml01.01.org; David Woodhouse dw...@infradead.org Subject: Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg On 08/04

Re: [edk2] Status of porting acpidump to edk2 ?

2015-08-11 Thread Laszlo Ersek
- From: Andrew Fish [mailto:af...@apple.com] Sent: Tuesday, August 11, 2015 7:05 AM To: Laszlo Ersek Cc: Shubha Ramani; Smith, Jonathan D; edk2-devel@lists.01.org Subject: Re: [edk2] Status of porting acpidump to edk2 ? On Aug 11, 2015, at 5:56 AM, Laszlo Ersek ler...@redhat.com wrote

Re: [edk2] [PATCH 0/9] OvmfPkg, ArmVirtPkg: SMBIOS 3.0, round 2

2015-08-06 Thread Laszlo Ersek
On 07/31/15 20:40, Laszlo Ersek wrote: The SMBIOS 3.x entry point is structurally different from the 2.x variant, therefore the current code used by OvmfPkg and ArmVirtPkg doesn't recognize an SMBIOS 3.0 entry point structure even if QEMU exports one. This series rectifies that. The first

Re: [edk2] BaseTools features: multiple workspaces

2015-08-06 Thread Laszlo Ersek
On 08/05/15 23:46, Jordan Justen wrote: On 2015-08-05 13:21:37, Andrew Fish wrote: On Aug 5, 2015, at 12:16 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Tim gave another idea to define multiple source locations in Platform DSC file. It

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-06 Thread Laszlo Ersek
the setting in CpuMp. I will come up a patch for that. Thanks! Laszlo Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, August 6, 2015 12:28 AM To: Andrew Fish Cc: Justen, Jordan L; edk2-de...@ml01.01

Re: [edk2] [PATCH] OvmfPkg: PlatformDebugLibIoPort: fix AsciiSPrint() format string

2015-08-06 Thread Laszlo Ersek
On 08/05/15 18:32, Laszlo Ersek wrote: The LineNumber parameter of the DebugAssert() function has type UINTN. DebugAssert() passes it to AsciiSPrint() with the %d conversion specifier at the moment, but %d would require an INT32 argument. Fix this by casting LineNumber to UINT64, also

Re: [edk2] apparent SMBASE relocation issue with noexec enabled [was: MdeModulePkg DxeIpl: Add stack NX support]

2015-08-06 Thread Laszlo Ersek
On 08/07/15 00:38, Laszlo Ersek wrote: On 08/06/15 16:55, Paolo Bonzini wrote: On 06/08/2015 16:31, Laszlo Ersek wrote: kvm_cpuid:func 8001 rax 6e8 rbx 0 rcx 0 rdx 10 kvm_enter_smm:vcpu 0: leaving SMM, smbase 0x7ffc kvm_entry:vcpu 0 kvm_exit

Re: [edk2] apparent SMBASE relocation issue with noexec enabled [was: MdeModulePkg DxeIpl: Add stack NX support]

2015-08-06 Thread Laszlo Ersek
On 08/06/15 16:55, Paolo Bonzini wrote: On 06/08/2015 16:31, Laszlo Ersek wrote: kvm_cpuid:func 8001 rax 6e8 rbx 0 rcx 0 rdx 10 kvm_enter_smm:vcpu 0: leaving SMM, smbase 0x7ffc kvm_entry:vcpu 0 kvm_exit: reason TRIPLE_FAULT rip

[edk2] [PATCH] OvmfPkg: prevent code execution from DXE stack

2015-08-07 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek ler...@redhat.com --- Notes: - This patch depends on Star's [edk2] [PATCH] UefiCpuPkg CpuDxe: Sync up the settings of Execute Disable to APs http://thread.gmane.org/gmane.comp.bios.edk2.devel/960 and should be applied

Re: [edk2] [RFC PATCH] ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency

2015-08-07 Thread Laszlo Ersek
] [LibraryClasses] BaseLib BaseMemoryLib - BdsLib DebugLib DevicePathLib MemoryAllocationLib Reviewed-by: Laszlo Ersek ler...@redhat.com ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-07 Thread Laszlo Ersek
On 08/07/15 19:00, Andrew Fish wrote: On Aug 7, 2015, at 5:21 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 08/07/15 03:27, Zeng, Star wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, August 6, 2015 9:43 PM To: Zeng

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-07 Thread Laszlo Ersek
On 08/07/15 03:27, Zeng, Star wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, August 6, 2015 9:43 PM To: Zeng, Star; Paolo Bonzini Cc: Andrew Fish; Justen, Jordan L; edk2-de...@ml01.01.org; Yao, Jiewen; Chen Fan; Fan, Jeff Subject: Re: [edk2

Re: [edk2] [PATCH] UefiCpuPkg CpuDxe: Sync up the settings of Execute Disable to APs

2015-08-07 Thread Laszlo Ersek
Laszlo for the early draft patch, thanks. Cc: Laszlo Ersek ler...@redhat.com Cc: Jeff Fan jeff@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng star.z...@intel.com --- UefiCpuPkg/CpuDxe/ApStartup.c | 133

[edk2] OVMF BoF @ KVM Forum 2015

2015-08-10 Thread Laszlo Ersek
Hi. Let's do an OVMF BoF at this year's KVM Forum too. Paolo will present Securing secure boot: system management mode in KVM and Tiano Core on Thursday, August 20, in the 5:00pm - 5:30pm time slot. Right after that, the BoF section starts at 5:30pm:

Re: [edk2] [PATCH 0/5] secure boot support for ARM FVP

2015-08-11 Thread Laszlo Ersek
On 08/08/15 14:00, Ard Biesheuvel wrote: This series adds support for using the Intel BDS with ArmVExpress-FVP, and for building it with UEFI Secure Boot enabled. Note that the former is a prerequisite of the latter, since the ARM BDS has no GUI for enrolling certificates and enabling secure

Re: [edk2] [PATCH 1/2] ArmVirtPkg: build our DEBUG Shell using the small code model

2015-08-11 Thread Laszlo Ersek
+ GCC:DEBUG_*_AARCH64_DLINK_FLAGS = -z common-page-size=0x1000 } I hope all this finesse is going to work with gcc-4.8! :) Reviewed-by: Laszlo Ersek ler...@redhat.com ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org

Re: [edk2] [PATCH 00/58] OvmfPkg: support SMM for better security (single VCPU, IA32)

2015-08-11 Thread Laszlo Ersek
Ping, because: On 07/25/15 01:00, Laszlo Ersek wrote: For a short introduction, jump to the last patch. Past discussions (just what I could easily find): http://thread.gmane.org/gmane.comp.bios.tianocore.devel/14243 http://thread.gmane.org/gmane.comp.bios.tianocore.devel/14243/focus=14330

Re: [edk2] [PATCH] OvmfPkg: prevent code execution from DXE stack

2015-08-11 Thread Laszlo Ersek
Jordan, On 08/08/15 02:02, Zeng, Star wrote: -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Saturday, August 8, 2015 12:00 AM To: edk2-devel-01 Cc: Paolo Bonzini; Zeng, Star; Justen, Jordan L Subject: [edk2] [PATCH

Re: [edk2] [PATCH 2/2] BaseTools AARCH64: use tiny code model by default

2015-08-11 Thread Laszlo Ersek
) --gc-sections Since these are general flags, I'll defer to Leif, but you can add my Reviewed-by: Laszlo Ersek ler...@redhat.com ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Library refinement: OptionRomPkg/BltLib

2015-08-10 Thread Laszlo Ersek
On 08/10/15 05:09, Ni, Ruiyu wrote: Jordan and Laszlo, I reviewed the OptionRomPkg/BltLib again and would like to discuss with you about the potential API refinement. I attached two versions of the refined BltLib.h. The common part of the two versions is: 1. BltLibGetSizes()

Re: [edk2] error when use ovmf

2015-08-10 Thread Laszlo Ersek
On 08/10/15 08:50, 闪耀 wrote: when i used ovmf.fd in qemu manager, then occurcs this tips: Boot Failed. EFI DVD/CDROM Boot Failed. EFI Floopy i don't know what does this mean? Your QEMU boot order specification (-boot ... option, or -device ...,bootindex=N properties) are incompatible

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-06 Thread Laszlo Ersek
Hi Star, On 08/06/15 11:44, Zeng, Star wrote: Hi Laszlo, Could you help take a try with the attached patch on your VM before I send it for formal review? I got your patch via your first (public) message as well -- not the one reflected by the list software, but on the direct route. So, I

[edk2] apparent SMBASE relocation issue with noexec enabled [was: MdeModulePkg DxeIpl: Add stack NX support]

2015-08-06 Thread Laszlo Ersek
Separate followup message with the symptoms I managed to gather about the failure on KVM. On 08/06/15 15:42, Laszlo Ersek wrote: Hi Star, On 08/06/15 11:44, Zeng, Star wrote: Hi Laszlo, Could you help take a try with the attached patch on your VM before I send it for formal review? I got

Re: [edk2] [PATCH 1/3] ArmVirtPkg/ArmVirtQemu: drop ARM BDS and make Intel BDS the default

2015-08-04 Thread Laszlo Ersek
-!if $(INTEL_BDS) == TRUE # # TianoCore logo (splash screen) # FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { SECTION RAW = MdeModulePkg/Logo/Logo.bmp } -!endif [FV.FVMAIN_COMPACT] FvAlignment= 16 Reviewed-by: Laszlo Ersek ler

Re: [edk2] [PATCH 2/3] ArmVirtPkg/ArmVirtXen: remove unused PcdFirmwareVendor PCD

2015-08-04 Thread Laszlo Ersek
] [PcdsFixedAtBuild.common] - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|XEN-UEFI gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L$(FIRMWARE_VER) gArmPlatformTokenSpaceGuid.PcdCoreCount|1 Reviewed-by: Laszlo Ersek ler

Re: [edk2] [Patch 2/3] OvmfPkg: use new BDS and UiApp in MdeModulePkg

2015-08-14 Thread Laszlo Ersek
://thread.gmane.org/gmane.comp.bios.edk2.devel/759/focus=1153 Thanks! Laszlo Thanks, Ray -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, August 12, 2015 10:59 PM To: Ni, Ruiyu ruiyu...@intel.com Cc: Justen, Jordan L jordan.l.jus...@intel.com; edk2-de

Re: [edk2] [PATCH 2/2] OvmfPkg: Add HttpBoot support

2015-08-14 Thread Laszlo Ersek
Hi Gary, On 08/14/15 11:03, Gary Ching-Pang Lin wrote: This commit introdues a new build option to OvmfPkg: HTTP_BOOT_ENABLE. When HttpBoot is enabled, a new Network boot option will show in the boot manager menu with the device path like this:

Re: [edk2] [PATCH 2/2] CryptoPkg/OpensslLib: Undefine NO_BUILTIN_VA_FUNCS to fix varargs breakage

2015-07-27 Thread Laszlo Ersek
= $(OPENSSL_FLAGS) $(OPENSSL_EXFLAGS) -w GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) $(OPENSSL_EXFLAGS) -w Reviewed-by: Laszlo Ersek ler...@redhat.com ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2

Re: [edk2] [PATCH v2 5/7] ArmVirtPkg: move to unified GCC linker script

2015-07-27 Thread Laszlo Ersek
-size=0x1 [LibraryClasses.common] !if $(TARGET) == RELEASE Acked-by: Laszlo Ersek ler...@redhat.com ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Enable optimization for gcc x64 builds

2015-07-27 Thread Laszlo Ersek
On 07/27/15 20:31, Scott Duplichan wrote: Andrew Fish [mailto:af...@apple.com] wrote: ]Sent: Friday, July 24, 2015 12:21 PM ]To: David Woodhouse dw...@infradead.org ]Cc: Jordan Justen jordan.l.jus...@intel.com; edk2-de...@ml01.01.org; Laszlo Ersek ler...@redhat.com; ]Paolo Bonzini pbonz

Re: [edk2] Enable optimization for gcc x64 builds

2015-07-27 Thread Laszlo Ersek
On 07/27/15 20:31, Scott Duplichan wrote: The gcc -Wformat messages are usually clear, but I found one misleading: format '%g' expects argument of type 'void *', but argument 4 has type 'EFI_GUID {aka struct anonymous In this case, the entire GUID struct is being passed instead of the GUID

[edk2] [PATCH] OvmfPkg: fix conversion specifiers in DEBUG format strings

2015-07-27 Thread Laszlo Ersek
Cc: Scott Duplichan sc...@notabs.org Cc: Jordan Justen jordan.l.jus...@intel.com Reported-by: Scott Duplichan sc...@notabs.org Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- Notes: Scott, can you please test-build with the attached

Re: [edk2] [RFC] OpenSSL HEAD WIP

2015-07-27 Thread Laszlo Ersek
On 07/27/15 22:13, David Woodhouse wrote: To be used with http://git.infradead.org/users/dwmw2/openssl.git/ checked out in CryptoPkg/Library/OpensslLib/openssl/ and on top of my other EDK2 patches (http://git.infradead.org/users/dwmw2/edk2.git/). Automatically generate the file list from

Re: [edk2] Temporary git repo - Re: TianoCore Subversion down?

2015-07-23 Thread Laszlo Ersek
, Laszlo Ersek wrote: On 07/23/15 19:31, Jordan Justen wrote: On 2015-07-23 10:04:26, Laszlo Ersek wrote: On 07/23/15 02:06, Jordan Justen wrote: Okay. Based on Laszlo's request, I setup a temporary git repo to collect up the changes that should have been committed to svn the past week. https

Re: [edk2] TianoCore Subversion down?

2015-07-22 Thread Laszlo Ersek
On 07/22/15 21:44, Bruce Cran wrote: On 7/22/2015 4:18 AM, Laszlo Ersek wrote: How about someone creates a temporary branch off the github master branch, and applies all new patches from the list that have been reviewed thus far? Then once SVN is back up, the patches from that git branch

  1   2   3   4   5   6   7   8   9   10   >