Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-16 Thread Bastien Guerry
Ihor Radchenko writes: > Applied, onto main. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6954fe93e Thanks! -- Bastien Guerry

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-15 Thread Ihor Radchenko
Bastien Guerry writes: > Ihor Radchenko writes: > >> See the attached tentative patch. > > LGTM. Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6954fe93e -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-14 Thread Bastien Guerry
Ihor Radchenko writes: > See the attached tentative patch. LGTM. >> 2) Also remove the current C-u C-u C-u arg and make it the default >>when a region is active. >> ... >> (2) should be done anyway. > > I studied this further and what you suggest will interfere with >

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-14 Thread Ihor Radchenko
Bastien Guerry writes: > Here is another suggestion: > > 1) Remove the option and make adding the dup link on top the default. > > (1) is because removing this option would be a breaking change, and > inflincting a new option to every user to deal with a hypothetical > use-case does not seem

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-14 Thread Ihor Radchenko
Samuel Wales writes: > i currently want to copy a link location and then paste that link > loadtion. i don't recall theis breaking before. it does now. Please provide more details. (https://orgmode.org/manual/Feedback.html#Feedback) Otherwise, it is very hard to figure out what exactly you

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-13 Thread Samuel Wales
i currently want to copy a link location and then paste that link loadtion. i don't recall theis breaking before. it does now. On 8/13/23, Ihor Radchenko wrote: > Bastien Guerry writes: > >> Here is another suggestion: >> >> 1) Remove the option and make adding the dup link on top the

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-13 Thread Ihor Radchenko
Bastien Guerry writes: > Here is another suggestion: > > 1) Remove the option and make adding the dup link on top the default. > > 2) Also remove the current C-u C-u C-u arg and make it the default >when a region is active. > > (1) is because removing this option would be a breaking change,

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-13 Thread Bastien Guerry
Hi Ihor, Thanks for bearing with me while I discuss something is done, required time and work, and isn't probably a priority. Ihor Radchenko writes: > Bastien Guerry writes: > >> (1) by always store the latest link on top and remove old dups. >> >> (2) always store latest link at the top and

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-11 Thread Ihor Radchenko
Bastien Guerry writes: > (1) by always store the latest link on top and remove old dups. > > (2) always store latest link at the top and remove old dups and allow > to keep dups with 3 universal prefix args. > ... > I'm in favor of option (2) as it deals with the above use-case, and >

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-08 Thread Bastien Guerry
Ihor Radchenko writes: > This would be yet another breaking change... Of course, you're right! Then here are two suggestions, assuming it's best to spare us yet another option: (1) by always store the latest link on top and remove old dups. (2) always store latest link at the top and remove

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-08 Thread Ihor Radchenko
Samuel Wales writes: > i am confused. org-stored-links is a command? what are the known > user needs for storing and pasting links? Typo. Meant to be org-store-link. > i am also unclear on why we have a dedicated paste function as opposed > to kill ring. probably a good reason. but wfm.

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-08 Thread Ihor Radchenko
Bastien writes: > Ihor Radchenko writes: > >> * lisp/ol.el (org-link-store-existing): New customization controlling >> how to deal with already stored links. >> (org-store-link): Respect the new customization, allowing duplicates >> to (1) be added anyway; (2) be ignored; (3) be moved to front

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-06 Thread Samuel Wales
i am confused. org-stored-links is a command? what are the known user needs for storing and pasting links? i am also unclear on why we have a dedicated paste function as opposed to kill ring. probably a good reason. but wfm. i merely wanted to store then yank a link. which in bugfix errors

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-06 Thread Bastien
Ihor Radchenko writes: > * lisp/ol.el (org-link-store-existing): New customization controlling > how to deal with already stored links. > (org-store-link): Respect the new customization, allowing duplicates > to (1) be added anyway; (2) be ignored; (3) be moved to front of > `org-stored-links'.

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-21 Thread Ihor Radchenko
Samuel Wales writes: > On 7/15/23, Ihor Radchenko wrote: >> Applied, onto main. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c0dbcf361 > > thank you! will this reach bugfix too? No, because it is a new feature. So, it is for the next release. -- Ihor Radchenko //

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-20 Thread Samuel Wales
On 7/15/23, Ihor Radchenko wrote: > Applied, onto main. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c0dbcf361 thank you! will this reach bugfix too? -- The Kafka Pandemic A blog about science, health, human rights, and misopathy: https://thekafkapandemic.blogspot.com

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-15 Thread Ihor Radchenko
Ihor Radchenko writes: > From a05e2cc235b10a7096538da4f6ae6d17c82a6b25 Mon Sep 17 00:00:00 2001 > Message-ID: > > From: Ihor Radchenko > Date: Wed, 5 Jul 2023 13:14:56 +0300 > Subject: [PATCH] org-store-link: Move already stored link to front by default Applied, onto main.

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-05 Thread Samuel Wales
On 7/5/23, Ihor Radchenko wrote: > Ihor Radchenko writes: > >> What Samuel described is a sequence of M-x org-store-link followed by >> M-x org-insert-all-links. With such workflow, user can expect that the >> links are going to be stored in order. If we are instead shuffle the >> stored links,

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-05 Thread Ihor Radchenko
Samuel Wales writes: >>> this buffer contains nothing useful and shortens the above buffer. >> >> This is fine. I assume that you can simply hide it away using >> `display-buffer-alist'. > > i have struggled with this in a wider context and gotten nowhere for years. (add-to-list

[PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-05 Thread Ihor Radchenko
Ihor Radchenko writes: > What Samuel described is a sequence of M-x org-store-link followed by > M-x org-insert-all-links. With such workflow, user can expect that the > links are going to be stored in order. If we are instead shuffle the > stored links, M-x org-insert-all-links may result in

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-04 Thread Samuel Wales
On 7/4/23, Ihor Radchenko wrote: > Samuel Wales writes: > >>> -UUU:**--F1 *Org Links*Top L1 (Fundamental) >> >> this buffer contains nothing useful and shortens the above buffer. > > This is fine. I assume that you can simply hide it away using > `display-buffer-alist'. i have

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-04 Thread Ihor Radchenko
Samuel Wales writes: >> -UUU:**--F1 *Org Links*Top L1 (Fundamental) > > this buffer contains nothing useful and shortens the above buffer. This is fine. I assume that you can simply hide it away using `display-buffer-alist'. > --- >> http: https: >>

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Samuel Wales
On 7/3/23, Max Nikulin wrote: > On 04/07/2023 07:28, Samuel Wales wrote: >> again i normally work with 1 window so i can have enough text. >> sometimes i have a minuibffer. the end. > > 8< > File Edit Options Buffers Tools Minibuf Help > > * title > :PROPERTIES: > :ID:

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Max Nikulin
On 04/07/2023 07:28, Samuel Wales wrote: again i normally work with 1 window so i can have enough text. sometimes i have a minuibffer. the end. 8< File Edit Options Buffers Tools Minibuf Help * title :PROPERTIES: :ID: e69336ca-ca50-4535-9bad-63a31e030f31 -UU-:F1

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Samuel Wales
again i normally work with 1 window so i can have enough text. sometimes i have a minuibffer. the end. On 7/3/23, Samuel Wales wrote: > the copletions window dos notc ontain the link dscription or a > default. there is no tdeafult listed in minibuffer or any tlink > description. so it is 1

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Samuel Wales
the copletions window dos notc ontain the link dscription or a default. there is no tdeafult listed in minibuffer or any tlink description. so it is 1 orig buffer, which is saller and therefoere lss useful, 1 links buffer, which is useless beause does not show what i need, 1 copletions buffer

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Samuel Wales
maybe most folk are ok with 3 windows + minibuffer. this is not useful to me. On 7/3/23, Samuel Wales wrote: > please feel free to give up if that doesn't get it across. i can't > continue a bac and forth for unrelated reasons. > > On 7/3/23, Samuel Wales wrote: >> scratch the expanded thing.

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Samuel Wales
please feel free to give up if that doesn't get it across. i can't continue a bac and forth for unrelated reasons. On 7/3/23, Samuel Wales wrote: > scratch the expanded thing. > > it ends up showing orig smaller less useful, links uselessly > boilerplate, completions -- 3 windows! and a terse

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Samuel Wales
scratch the expanded thing. it ends up showing orig smaller less useful, links uselessly boilerplate, completions -- 3 windows! and a terse minibuffer i wouldn't be able to use. -q. i cannot use such a ui. in contrast, what i expected is orig, and then expanded minibuffer with, instead of

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Samuel Wales
my reading was: s> another window would not work for me but using completion as i do with e.g. refile goto would m> try again s> creates another window. ergo not work for me. in fact, it is worse than that for me. with my fonts, the links window shows nothing useful on screen. it is

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Samuel Wales
defait cp[;etopm immediately makes 2 windows [orig+links] + expanded completion imnibuffer. not useful for me. On 7/3/23, Max Nikulin wrote: > On 02/07/2023 13:03, Samuel Wales wrote: >> there is not supposed to be any connection between org refile or org >> goto with the code in org insert

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-03 Thread Max Nikulin
On 02/07/2023 13:03, Samuel Wales wrote: there is not supposed to be any connection between org refile or org goto with the code in org insert link. completion works to select ol paths for org refile and also for org refile when it is doing goto. i just want the same for links. I am giving

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-02 Thread Samuel Wales
there is not supposed to be any connection between org refile or org goto with the code in org insert link. completion works to select ol paths for org refile and also for org refile when it is doing goto. i just want the same for links. On 7/1/23, Max Nikulin wrote: > On 02/07/2023 12:02,

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-01 Thread Max Nikulin
On 02/07/2023 12:02, Samuel Wales wrote: another window would not work for me but using completion as i do with e.g. refile goto would. Samuel, you claimed that completion by description does not work for `org-insert-link'. I expect that it is fixed in Org-9.6 since I do not see the issue

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-01 Thread Samuel Wales
another window would not work for me but using completion as i do with e.g. refile goto would. On 7/1/23, Max Nikulin wrote: > On 01/07/2023 13:12, Max Nikulin wrote: >> On 01/07/2023 12:15, Samuel Wales wrote: >>> emacs -q 9.6.7, vaniila except for whatever -q loads, opens a links >>> window

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-01 Thread Max Nikulin
On 01/07/2023 13:12, Max Nikulin wrote: On 01/07/2023 12:15, Samuel Wales wrote: emacs -q 9.6.7, vaniila except for whatever -q loads, opens a links window that shows descrtipition and truncated link. Ignore the links window and try to type first letter of a link description and TAB.

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-01 Thread Max Nikulin
On 01/07/2023 12:15, Samuel Wales wrote: emacs -q 9.6.7, vaniila except for whatever -q loads, opens a links window that shows descrtipition and truncated link. Ignore the links window and try to type first letter of a link description and TAB.

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-06-30 Thread Samuel Wales
i guess i expected completion to show only description with recently saved at top. if i want, i can also select by ido's flex, c-spc, arrow keys, etc. ido is already set up for accessibility for me and is used all the time for other purposes. then there is the opportunity for fanciness with

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-06-30 Thread Samuel Wales
yes, 9.6.7 has the bug as i described it, at least with my window and ido setup. emacs -q 9.6.7, vaniila except for whatever -q loads, opens a links window that shows descrtipition and truncated link. idk what you do to select. idk what it does with completion setups. one problem is this

org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-06-30 Thread Max Nikulin
On 28/06/2023 08:35, Samuel Wales wrote: 2) org-insert-link, with my ido setup, and i am aware other completion mechanisms exist but find it difficult to switch, offers as completion candidates a completely useless list. The Org version in the Anthony's report is 9.5. Samuel, could

Re: what is the purpose of "This link has already been stored"?

2023-06-29 Thread Samuel Wales
or to [/mere brainstorm alert/] get really fancy, to be able to mark a place where links are to be inserted [perhas to become a plain list or so] then collect llinks from all over, then hit store and they all go to the place you marked. crash-proof. On 6/29/23, Samuel Wales wrote: > although i

Re: what is the purpose of "This link has already been stored"?

2023-06-29 Thread Samuel Wales
although i just store and insert now, i'd also welcome the ability to collect links from various places and have them someplace like a register where they can be pasted all at once. or even edit the list in the register, clear it, etc. On 6/29/23, Ihor Radchenko wrote: > Anthony Carrico

Re: what is the purpose of "This link has already been stored"?

2023-06-29 Thread Ihor Radchenko
Anthony Carrico writes: >> Makes sense. It is a +1 for a defcustom. >> Although I still believe that we should change the current default, even >> if leaving an option to fall back to previous behaviour. > > I don't think there is much reason to complicate the interface with a > defcustom. The

Re: what is the purpose of "This link has already been stored"?

2023-06-29 Thread Anthony Carrico
On 6/29/23 06:28, Ihor Radchenko wrote: Samuel Wales writes: if you move the recent one to top of list, that would work for my mindless store/insert, but it might not work for a user who has carefully cultivated a set of links that are all to be inserted, or such. although idk if the

Re: what is the purpose of "This link has already been stored"?

2023-06-29 Thread Ihor Radchenko
Samuel Wales writes: > i am not sure i am using store/insert to their full actual or > potential potential. > > if you move the recent one to top of list, that would work for my > mindless store/insert, but it might not work for a user who has > carefully cultivated a set of links that are all

Re: what is the purpose of "This link has already been stored"?

2023-06-28 Thread Samuel Wales
i am not sure i am using store/insert to their full actual or potential potential. if you move the recent one to top of list, that would work for my mindless store/insert, but it might not work for a user who has carefully cultivated a set of links that are all to be inserted, or such. although

Re: what is the purpose of "This link has already been stored"?

2023-06-28 Thread Samuel Wales
that is, if completing-read is changed, idk if ido will work with it well or not idk if proposed fix means - include id and description in orig list for selection - include id and description is for marginalia - user selects description and id is returned - another change just showing the

Re: what is the purpose of "This link has already been stored"?

2023-06-28 Thread Samuel Wales
On 6/28/23, Ihor Radchenko wrote: > This behaviour has been introduced in bb61b37ee > > bb61b37ee223fd89cf951a5fbf62e35e606a4646 > Author: Bastien > AuthorDate: Thu Dec 5 17:11:26 2019 +0100 > ol.el: Don't store the same link twice > > * lisp/ol.el (org-store-link): Don't store the same link

Re: what is the purpose of "This link has already been stored"?

2023-06-28 Thread Ihor Radchenko
Anthony Carrico writes: > Storing the link is also currently somewhat buggy. I almost always link > to the top of the page (the title), and org creates a table entry which > looks like this: > > Abstract Syntax Graphs for Domain Specific Languages> I cannot reproduce. Please provide more

Re: what is the purpose of "This link has already been stored"?

2023-06-28 Thread Anthony Carrico
I agree that the current behavior is useless, and I agree that a good default would be to bring the link to the front of the list. Storing the link is also currently somewhat buggy. I almost always link to the top of the page (the title), and org creates a table entry which looks like this:

Re: what is the purpose of "This link has already been stored"?

2023-06-28 Thread Ihor Radchenko
Samuel Wales writes: > in maint and bugfix i frequently do org-store-link on a > heading that has a properties drawer with an id in it. > > ... > i frequently get "This link has already been > stored". perhaps this is meant to teach me that i can find > it in org-insert-link? there are 2

what is the purpose of "This link has already been stored"?

2023-06-27 Thread Samuel Wales
in maint and bugfix i frequently do org-store-link on a heading that has a properties drawer with an id in it. my intent is to store it so that i can paste the link later with org-insert-link. i frequently get "This link has already been stored". perhaps this is meant to teach me that i can