[E-devel] elementary doc build error
Hi, Building the doxygen doc of elementary doesn't seem to work anymore. When running 'make doc', the shell launch a loop: /bin/sh -c for ss in flip:preview-00.png:widget_preview_flip:100:100 button:preview-00.png:widget_preview_button1:160:50 button:preview-01.png:widget_preview_button2:160:50 ... and run things like this at each step, which spawn a window: /tmp/elementary/doc/widgets/.libs/lt-widget_preview_panes 200 100 but it get stuck, stalling the build. Killing the processes one by one give these errors: rm -rf img/widget html/ latex/ man/ xml/ ../elementary-0.8.0.0-doc.tar* make[2]: Entering directory `/tmp/elementary/doc/widgets' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/tmp/elementary/doc/widgets' convert: unable to open image `../doc/html/img/widget/flip/preview-00.png': @ error/blob.c/OpenBlob/2587. convert: unable to open file `../doc/html/img/widget/flip/preview-00.png' @ error/png.c/ReadPNGImage/3234. convert: missing an image filename `../doc/latex/img/widget/flip/preview-00.eps' @ error/convert.c/ConvertImageCommand/3011. convert: unable to open image `../doc/html/img/widget/button/preview-00.png': @ error/blob.c/OpenBlob/2587. convert: unable to open file `../doc/html/img/widget/button/preview-00.png' @ error/png.c/ReadPNGImage/3234. convert: missing an image filename `../doc/latex/img/widget/button/preview-00.eps' @ error/convert.c/ConvertImageCommand/3011. ... make[1]: *** [widget-preview] Error 1 make[1]: Leaving directory `/tmp/elementary/doc' make: *** [doc] Error 2 And no html output... It was working for r68441, but I got this problem with r68610. Moreover, running 'make doc' before a single 'make' gives an (quite logical) error: ngc891@comet:/tmp/elementary$ make doc entering doc/ make -C doc doc make[1]: Entering directory `/tmp/elementary/doc' Making all in widgets make[2]: Entering directory `/tmp/elementary/doc/widgets' CC widget_preview_button1.o make[2]: *** No rule to make target `../../src/lib/libelementary.la', needed by `widget_preview_button1'. Stop. make[2]: Leaving directory `/tmp/elementary/doc/widgets' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/tmp/elementary/doc' make: *** [doc] Error 2 This should be handle appropriately, -- Jérôme Pinot http://ngc891.blogdns.net/ signature.asc Description: Digital signature -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] elm_genlist - add item flip set/get
Thanks for your patch.
Everything is fine but I still see the floating item bug.
And if the item is on dragging, it should not be unrealized.
As far as I know, when an item is on dragging, unrealizing the item
will cause unexpected problems.
I don't remember what it is exactly.
So I politely recommend you to solve this bug with another solution.
Thanks.
Daniel Juyung Seo (SeoZ)
On Fri, Mar 2, 2012 at 5:14 PM, Hyoyoung Chang hyoyo...@gmail.com wrote:
I attached improved version of flip patch
Thanks
On Thu, Mar 1, 2012 at 10:52 PM, Hyoyoung Chang hyoyo...@gmail.com wrote:
First of all, thanks for detailed review
On Thu, Mar 1, 2012 at 3:01 PM, Daniel Juyung Seo seojuyu...@gmail.com
wrote:
Thanks Hyoyoung, overall it looks good :)
I have some comments.
1. diff option
Create a diff with -x -up optoin.
It shows c function name for each changes.
This makes review so much easier and faster.
$ svn diff -x -up *.c
2. remove default properties from edc.
- mouse_events: 1
- rel1.relative: 0 0
- rel2.relative: 1 1
3. use elm_win_util_standard_add
elm_win_add + elm_bg_add is ok but I encourage you to use
elm_win_util_standard_add in normal cases.
It does elm_win_add + elm_bg_add and reduces 6 lines of code.
I didn't know it. I'll apply
4. formatting
There are some wrong formatted codes.
In or edc?
5. build warnings
test_genlist.c: In function ‘_flip_icon_clicked_cb’:
test_genlist.c:2495:82: warning: unused parameter ‘event_info’
test_genlist.c: In function ‘gl16_content_get’:
test_genlist.c:2516:17: warning: unused variable ‘ic’
test_genlist.c: In function ‘test_genlist16’:
test_genlist.c:2553:39: warning: unused variable ‘bt’
test_genlist.c:2553:33: warning: unused variable ‘bx2’
Yeah, It should be removed
6. In _flip_icon_clicked_cb, you can just do:
tit-checked = !tit-checked
However, I would recommend to use elm_genlist_item_flip_get() instead
of remembering tit-checked.
This covers more API usage and it's useful example.
And without checked, you don't even need to use tit array, you can
just pass (void *)(long) i as an item data.
If you don't prefer to use that casting trick, you can just use tit
but without checked member.
U're right :)
7. const to getters.
Yes, add const to getters.
EAPI Eina_Bool elm_genlist_item_flip_get(const Elm_Object_Item *it);
Yeah i'll add it
8. in elm_genlist_item_flip_set
Instead of
_it-flipped = EINA_TRUE / EINA_FALSE;
You can do
_it-flipped = flip;
9. floating item bug
a. flip many items
b. scroll
Then I can see floating items bug. I attached screenshot.
This also happens easily in this case:
a. flip many items
b. drag flipped item and scroll it out of viewport.
10. if statement in elm_genlist_item_flip_set
You already checked if _it-flipped equals to flip,
so you do not need to check _it-flipped again.
if (_it-flipped == flip) return; you already checked it
if (flip)
else
{
if (_it-flipped) do not need to check this
else
}
First checking is to verify changed.
Second checking is about previous status.
So It leaves at it is.
I don't think it's good or clean code either.
But checking is right. Maybe it should be re-written to make clean code.
These are just trivial comments.
Please apply them.
Otherwise, this patch looks good :)
Thanks.
you're always passionate.
Thanks very much for detail review.
Daniel Juyung Seo (SeoZ)
On Wed, Feb 29, 2012 at 9:17 PM, Hyoyoung Chang hyoyo...@gmail.com wrote:
Dear all.
I made a patch to introduce new genlist item mode.
Two public apis are added.
+EAPI void elm_genlist_item_flip_set(Elm_Object_Item *it, Eina_Bool flip);
+EAPI Eina_Bool elm_genlist_item_flip_get(Elm_Object_Item *it);
It provides on-the-flying item change. It works like that a new item
added on existed item.
In elementary test, you can test it.
It's useful at adding widgets or show buttons in genlist item.
Thanks.
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elementary doc build error
On Fri, 2 Mar 2012 19:04:31 +0900 Jérôme Pinot ngc...@gmail.com wrote: Building the doxygen doc of elementary doesn't seem to work anymore. When running 'make doc', the shell launch a loop: /bin/sh -c for ss in flip:preview-00.png:widget_preview_flip:100:100 button:preview-00.png:widget_preview_button1:160:50 button:preview-01.png:widget_preview_button2:160:50 ... and run things like this at each step, which spawn a window: /tmp/elementary/doc/widgets/.libs/lt-widget_preview_panes 200 100 but it get stuck, stalling the build. Killing the processes one by one give these errors: rm -rf img/widget html/ latex/ man/ xml/ ../elementary-0.8.0.0-doc.tar* make[2]: Entering directory `/tmp/elementary/doc/widgets' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/tmp/elementary/doc/widgets' convert: unable to open image `../doc/html/img/widget/flip/preview-00.png': @ error/blob.c/OpenBlob/2587. convert: unable to open file `../doc/html/img/widget/flip/preview-00.png' @ error/png.c/ReadPNGImage/3234. convert: missing an image filename `../doc/latex/img/widget/flip/preview-00.eps' @ error/convert.c/ConvertImageCommand/3011. convert: unable to open image `../doc/html/img/widget/button/preview-00.png': @ error/blob.c/OpenBlob/2587. convert: unable to open file `../doc/html/img/widget/button/preview-00.png' @ error/png.c/ReadPNGImage/3234. convert: missing an image filename `../doc/latex/img/widget/button/preview-00.eps' @ error/convert.c/ConvertImageCommand/3011. ... make[1]: *** [widget-preview] Error 1 make[1]: Leaving directory `/tmp/elementary/doc' make: *** [doc] Error 2 And no html output... It was working for r68441, but I got this problem with r68610. I was getting that problem last night, and discussed it a bit on IRC. Since I was trying to solve another bug at the time, I did not do much more with this one. The others on IRC where telling me it had to do with not compiling the software buffer in evas, but that was being compiled here. Could you supply your ./configure options and output for evas, ecore, and elementary please? -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elementary doc build error
On 03/02/12 21:13, David Seikel wrote: On Fri, 2 Mar 2012 19:04:31 +0900 Jérôme Pinot ngc...@gmail.com wrote: Building the doxygen doc of elementary doesn't seem to work anymore. When running 'make doc', the shell launch a loop: /bin/sh -c for ss in flip:preview-00.png:widget_preview_flip:100:100 button:preview-00.png:widget_preview_button1:160:50 button:preview-01.png:widget_preview_button2:160:50 ... and run things like this at each step, which spawn a window: /tmp/elementary/doc/widgets/.libs/lt-widget_preview_panes 200 100 but it get stuck, stalling the build. Killing the processes one by one give these errors: rm -rf img/widget html/ latex/ man/ xml/ ../elementary-0.8.0.0-doc.tar* make[2]: Entering directory `/tmp/elementary/doc/widgets' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/tmp/elementary/doc/widgets' convert: unable to open image `../doc/html/img/widget/flip/preview-00.png': @ error/blob.c/OpenBlob/2587. convert: unable to open file `../doc/html/img/widget/flip/preview-00.png' @ error/png.c/ReadPNGImage/3234. convert: missing an image filename `../doc/latex/img/widget/flip/preview-00.eps' @ error/convert.c/ConvertImageCommand/3011. convert: unable to open image `../doc/html/img/widget/button/preview-00.png': @ error/blob.c/OpenBlob/2587. convert: unable to open file `../doc/html/img/widget/button/preview-00.png' @ error/png.c/ReadPNGImage/3234. convert: missing an image filename `../doc/latex/img/widget/button/preview-00.eps' @ error/convert.c/ConvertImageCommand/3011. ... make[1]: *** [widget-preview] Error 1 make[1]: Leaving directory `/tmp/elementary/doc' make: *** [doc] Error 2 And no html output... It was working for r68441, but I got this problem with r68610. I was getting that problem last night, and discussed it a bit on IRC. Since I was trying to solve another bug at the time, I did not do much more with this one. The others on IRC where telling me it had to do with not compiling the software buffer in evas, but that was being compiled here. Could you supply your ./configure options and output for evas, ecore, and elementary please? You can find build output there: http://ngc891.blogdns.net/pub/projects/debug/ Nothing special, except the sdl option that I have to remove. You can find the build scripts (and configure options) there: http://slacke17.git.sourceforge.net/git/gitweb.cgi?p=slacke17/slacke17;a=blob;f=evas/evas.SlackBuild;h=f7ebeaf9b1488b2020df26b1bb97482165c96d6e;hb=HEAD http://slacke17.git.sourceforge.net/git/gitweb.cgi?p=slacke17/slacke17;a=blob;f=ecore/ecore.SlackBuild;h=7c11e62b5ae9c8ef28177786c7bb019ccfd7ff14;hb=HEAD http://slacke17.git.sourceforge.net/git/gitweb.cgi?p=slacke17/slacke17;a=blob;f=elementary/elementary.SlackBuild;h=a6000ea101f1e07525e64b60852bf15249f3eacf;hb=HEAD BTW, I can make the build log of SlackE17 public (in the git repo) if it may help... -- Jérôme Pinot http://ngc891.blogdns.net/ signature.asc Description: Digital signature -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elementary doc build error
On Fri, 2 Mar 2012 20:30:11 +0900 Jérôme Pinot ngc...@gmail.com wrote: On 03/02/12 21:13, David Seikel wrote: On Fri, 2 Mar 2012 19:04:31 +0900 Jérôme Pinot ngc...@gmail.com wrote: Building the doxygen doc of elementary doesn't seem to work anymore. When running 'make doc', the shell launch a loop: /bin/sh -c for ss in flip:preview-00.png:widget_preview_flip:100:100 button:preview-00.png:widget_preview_button1:160:50 button:preview-01.png:widget_preview_button2:160:50 ... and run things like this at each step, which spawn a window: /tmp/elementary/doc/widgets/.libs/lt-widget_preview_panes 200 100 but it get stuck, stalling the build. Killing the processes one by one give these errors: rm -rf img/widget html/ latex/ man/ xml/ ../elementary-0.8.0.0-doc.tar* make[2]: Entering directory `/tmp/elementary/doc/widgets' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/tmp/elementary/doc/widgets' convert: unable to open image `../doc/html/img/widget/flip/preview-00.png': @ error/blob.c/OpenBlob/2587. convert: unable to open file `../doc/html/img/widget/flip/preview-00.png' @ error/png.c/ReadPNGImage/3234. convert: missing an image filename `../doc/latex/img/widget/flip/preview-00.eps' @ error/convert.c/ConvertImageCommand/3011. convert: unable to open image `../doc/html/img/widget/button/preview-00.png': @ error/blob.c/OpenBlob/2587. convert: unable to open file `../doc/html/img/widget/button/preview-00.png' @ error/png.c/ReadPNGImage/3234. convert: missing an image filename `../doc/latex/img/widget/button/preview-00.eps' @ error/convert.c/ConvertImageCommand/3011. ... make[1]: *** [widget-preview] Error 1 make[1]: Leaving directory `/tmp/elementary/doc' make: *** [doc] Error 2 And no html output... It was working for r68441, but I got this problem with r68610. I was getting that problem last night, and discussed it a bit on IRC. Since I was trying to solve another bug at the time, I did not do much more with this one. The others on IRC where telling me it had to do with not compiling the software buffer in evas, but that was being compiled here. Could you supply your ./configure options and output for evas, ecore, and elementary please? You can find build output there: http://ngc891.blogdns.net/pub/projects/debug/ Nothing special, except the sdl option that I have to remove. You can find the build scripts (and configure options) there: http://slacke17.git.sourceforge.net/git/gitweb.cgi?p=slacke17/slacke17;a=blob;f=evas/evas.SlackBuild;h=f7ebeaf9b1488b2020df26b1bb97482165c96d6e;hb=HEAD http://slacke17.git.sourceforge.net/git/gitweb.cgi?p=slacke17/slacke17;a=blob;f=ecore/ecore.SlackBuild;h=7c11e62b5ae9c8ef28177786c7bb019ccfd7ff14;hb=HEAD http://slacke17.git.sourceforge.net/git/gitweb.cgi?p=slacke17/slacke17;a=blob;f=elementary/elementary.SlackBuild;h=a6000ea101f1e07525e64b60852bf15249f3eacf;hb=HEAD BTW, I can make the build log of SlackE17 public (in the git repo) if it may help... Looks like you have the same software buffer engine stuff I have. The IRC people where not much more explicit. Hopefully they can sort it out with the info we have given them. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: gastal trunk/elementary/doc
On Mon, 27 Feb 2012 10:59:12 -0300 Jonas M. Gastal jgas...@profusion.mobi said: On Saturday 25 February 2012 09:35:01 Carsten Haitzler wrote: well logical for a user would be that list AND genlist are in the same section - genlist is just a more flexible/powerful/extendable list - that's all. to a user they are pretty much exactly the same - just genlist will be more efficient when it comes to vast numbers of items, and requires more work to use (as well as being able to do trees). elm list could be able to be just like genlist with 1 trivial function call to set the style of an item. Well, I think that's acutally a very good point. And since the documentation should focus on new users instead of people who know the intricacies of the workings of the list/genlist, how would everyone feel about moving list to the containers list? In the same spirit I wonder if the toolbar and segment control wouldn't be better off in the containers list. I point them out because they have layout diagrams, if we need a diagram to exemplify the widget it seems to make sense to say it doesn't have it's own visual identity and is a container. hmm. you should read the dictionary as to what it says a container is. containers PRIMARILY hold something. that is their job. lists, toolbars etc. dont - they generate their own content (except icons). -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
On Tue, 28 Feb 2012 13:05:33 +0900 ChunEon Parkher...@naver.com said: well my comment still stands - without being able to load a named palettes, save it. you didnt address # 6 - where u get an object item returned then u use color number (index) to address it. thats a bit inconsistent. Here is a Shilpa’s mail forwarded(shilpa.si...@samsung.com) Hi, Please find attached updated patch of new widget colorpalette with review comment fixes. Change Description: New widget elm_colorpalette is added. ColorPalette is a color selection widget. It allows the user to set a series of colors. The colors can be picked by user from the color set by clicking on individual color item. All the review comments given below from 1-7 have been fixed. 3. support totally custom colorset (clear+add/change your colors) Fixed.[ elm_colorpalette_color_add, elm_colorpalette_clear APIs are supported ] 4. use a better layout (flow/wrap - yes, i know.. there is a bug there that elm test brings out - u can expand, but not contract horizontally) Fixed. 5. imho most likely needs the idea of a selected color - so when u click/select that color becomes the current selected color - much like a list has a selected item... this nicely allows for keyboard control too :) Fixed. 1. have a default color set in USER config (_elm_config or somewhere else maybe) loaded from user config files etc. and saved back to them on editing. 2. it'd have to also support custom palettes - but handle the saving/loading for you - eg just give palette a name (default by default, or photos or painting etc..) or a full path to save it in. Currently reading colors from config and writing back to it has not been supported, this needs some more analysis, this enhancement will be supported in next patch. Thanks Regards Shilpa Singh -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Elementary : New widget Elm_datetime patch
-- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elementary_test] test_focus
On Tue, 28 Feb 2012 11:10:12 +0900 cnook kimci...@gmail.com said: in svn. tnx! Dear All, Hello~ I have attached a patch which is for test_focus. Please review this and give any feedbacks. Thanks. Sincerely, Shinwoo Kim. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Elementary : New widget Elm_datetime patch
This patch was made by Sumanth Krishna Mannam.
Please refer following message ~ and attached patch.
===
first i was strolling along, reading elm_datetime.c... and then i saw:
static int _days_in_month[12] = { 31, 28, 31, 30, 31, 30,
31, 31, 30, 31, 30, 31 };
and then i was like:
http://www.youtube.com/watch?v=6FWUjJF1ai0
and i saw...
if (__isleap(*timearr[ELM_DATETIME_YEAR])
and i was like:
http://www.youtube.com/watch?v=fM1O9jWeNoI
(look at clock module src of e17 (in svn trunk/e/src/modules/clock) - in
there it manages to draw months and handle month sizes by using syscalls
that should get this from a time database and thus be correct. you can
figure out the range by using syscalls to do it all look @ _time_eval()).
I felt array based count is not that bad... and even elm_calendar does the
same . anyway, I gave a try with your method, using mktime() and check for
month wraaping and then deciding. Patch is updated accordingly .
http://www.corkscrew-balloon.com/travel/9812paris/leap.html
leap years do not make feb have 29 days EVERY 4 year. there are oddities to
this over history and probably will be in the future too. thats the pont of
the
system time database and apis to figure out so you dont have to :)
limits for years.. why 1970-2037? that seems a bit silly to limit it -
what if i'm entering the date of birth of my father? it's definitely before
1970 :)
I made 1970 as the default limit based on Epoc time 1970.
I have no issues to make default limit to further lowest :) I changed the
limits to 1900 2037.
why not just allow ANY date ... no limits? what if someone uses the widget for
a historcal event Examination app that asks students when events happened in
history...
The default limits for the year are used for displaying the possible values on
modules plug-ins like ctx_popup/disk selector list and spinner module.
More over, it's default limit and applications can override the limit with
provided APIs ( value_min/max set ), based on their need.
Example, any app accepting historical years, can set the min limit back to 1800
or even less. No restrictions.
and then i was looking at api:
Elm_Datetime_FieldType - Elm_Datetime_Field_Type
otherwise i shall not quibble about api :)
Yep...renamed to Elm_Datetime_Field_Type.
cool - fix the above limit. it dont like it. for at least 1 reason given
above.
other than that take note of that page on leap years and just do some research
yourself about time and how humans have, over history, defined it, written it
down, played with it, adjusted it and tried to make your time system match the
natural world around us. it'll encourage you to just piggy-back on someone
elses time api so you dont have to re-do all the work.. and if there is a bug
-
its fixed in 1 place for everyone.
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http
On Thu, 1 Mar 2012 23:59:26 +0100 Cedric BAIL cedric.b...@free.fr said:
On Thu, Mar 1, 2012 at 7:35 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
elev8: Allow loading modules in runtime
There are now two kinds of modules: native (.so) and JavaScript (.js). Both
modules can be loaded using the same interface and is completely
transparent to the application developer, by using the global require()
function. For example, to load the elementary module:
elm = require('elm');
This will try to open 'libelm.so' in the current directory, then
'libelm.so' in elev8's module directory. If that fails, it will try to
open 'elm.js' in the current directory, then 'elm.js' in elev8's directory.
Should any of these attempts work, it will save the module in an internal
cache and return a reference to an object containing all exported symbols
from that module.
That's a really great update. I really like this new activity in
elev8. I have just a little concern about security. I would have
choosen a different order. First I would have tried system module (in
elev8's module directory), then I would have tried 'elm.js' in elev8's
system directory. If all that's failed, I will try current directory,
maybe first the javascript ('elm.js') and the module. Reason is that
.so in current directory are much more likely to contain some nasty
code. If by just putting a file in the right place I can inject native
code, that's sound bad to me.
security here is a matter for a later date. right now the point is for a js app
to be ABLE to behave as fully as a native app. later on (already discussed) we
want to add security levels (eg on cmdline) that do things like disable module
loading at all, or limit sources (system only, user homedir only, or full paths
and app-dir relative paths - eg app provides native modules) etc... also
modifying behavior. eg filesystem access api may start limiting what you have
access to at all - may totally sandbox you with zero fs access outisde the app
dir itself (data files, reado-only) and a app-specific config/data/cache dir,
and then nothing else, then with various levels of exposing more of the fs.
but to start with... think of it as a native app but keep in mind the ability
of being able to pull in such security later on (via cmd-line args to elev8
and/or envirnoment vars that get read long before any js kicks in).
--
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [elementary] Deprecated API
On Wed, 29 Feb 2012 18:01:19 +0900 Kim Shinwoo kimcinoo@gmail.com said: correct - they do have to be. Dear All, Hello~ The followings should be deprecated. Am I right? but it is not in the elm_deprecated.h elm_gengrid_item_cursor_engine_only_set elm_gengrid_item_cursor_style_set elm_gengrid_item_cursor_unset Please check these APIs and give any feedbacks. Thanks. Sincerely, Shinwoo Kim. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http
On Fri, Mar 2, 2012 at 9:48 AM, Carsten Haitzler ras...@rasterman.com wrote:
On Thu, 1 Mar 2012 23:59:26 +0100 Cedric BAIL cedric.b...@free.fr said:
On Thu, Mar 1, 2012 at 7:35 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
elev8: Allow loading modules in runtime
There are now two kinds of modules: native (.so) and JavaScript (.js).
Both
modules can be loaded using the same interface and is completely
transparent to the application developer, by using the global require()
function. For example, to load the elementary module:
elm = require('elm');
This will try to open 'libelm.so' in the current directory, then
'libelm.so' in elev8's module directory. If that fails, it will try to
open 'elm.js' in the current directory, then 'elm.js' in elev8's directory.
Should any of these attempts work, it will save the module in an internal
cache and return a reference to an object containing all exported symbols
from that module.
That's a really great update. I really like this new activity in
elev8. I have just a little concern about security. I would have
choosen a different order. First I would have tried system module (in
elev8's module directory), then I would have tried 'elm.js' in elev8's
system directory. If all that's failed, I will try current directory,
maybe first the javascript ('elm.js') and the module. Reason is that
.so in current directory are much more likely to contain some nasty
code. If by just putting a file in the right place I can inject native
code, that's sound bad to me.
security here is a matter for a later date. right now the point is for a js
app
to be ABLE to behave as fully as a native app. later on (already discussed) we
want to add security levels (eg on cmdline) that do things like disable module
loading at all, or limit sources (system only, user homedir only, or full
paths
and app-dir relative paths - eg app provides native modules) etc... also
modifying behavior. eg filesystem access api may start limiting what you have
access to at all - may totally sandbox you with zero fs access outisde the app
dir itself (data files, reado-only) and a app-specific config/data/cache dir,
and then nothing else, then with various levels of exposing more of the fs.
but to start with... think of it as a native app but keep in mind the ability
of being able to pull in such security later on (via cmd-line args to elev8
and/or envirnoment vars that get read long before any js kicks in).
ACK
Lucas De Marchi
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http
Sanjeev, On 03/01/2012 11:27 PM, Elevate Efl wrote: Object::HasOwnProperty() is not to be found in v8.h. I did an apt-get update/upgrade and I did not find this in v8.h (version - 3.1.8.22) . The reference API page does provide this API though. Can you tell me which version of libv8 you have used? I'm using the V8 library that comes with Arch Linux (3.6.6.20), which was released September 2011 according to v8's SVN. HasOwnProperty() has a JavaScript counterpart (Object.hasOwnProperty()), so I thought it would be available in V8 since a long time ago. What distribution/version are you using? Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http
On 03/02/2012 10:47 AM, Lucas De Marchi wrote: On Fri, Mar 2, 2012 at 9:48 AM, Carsten Haitzlerras...@rasterman.com wrote: On Thu, 1 Mar 2012 23:59:26 +0100 Cedric BAILcedric.b...@free.fr said: That's a really great update. I really like this new activity in elev8. I have just a little concern about security. (...) security here is a matter for a later date. (...) ACK +1. Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][EYESIGHT] Compile again with mupdf
should be good, now Vincent On Fri, Mar 2, 2012 at 8:46 AM, Vincent Torri vincent.to...@gmail.com wrote: On Thu, Mar 1, 2012 at 7:51 PM, Leif Middelschulte leif.middelschu...@gmail.com wrote: Hi all, find a patch for eyesight, that will make it compile again, attached to this mail. ok. although the patch is correct, there's something a bit better to do. I'll do it this week-end. thanks Vincent -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Fwd: [nox: [PATCH] build fix for emotion with libxine 1.2.x]
The attached patch fixes build for emotion with libxine 1.2.x. I only forward this for nox, who is not subscribed (and seems to have trouble getting in the moderation queue). All credits to him. -- Forwarded message -- From: Juergen Lock n...@jelal.kn-bremen.de Date: Sat, Mar 3, 2012 at 01:47 Subject: [nox: [PATCH] build fix for emotion with libxine 1.2.x] To: tho...@gstaedtner.net - Forwarded message from nox - Date: Tue, 28 Feb 2012 20:53:01 +0100 To: enlightenment-devel@lists.sourceforge.net Subject: [PATCH] build fix for emotion with libxine 1.2.x User-Agent: Mutt/1.5.21 (2010-09-15) Patch also here: http://www.freebsd.org/cgi/cvsweb.cgi/ports/multimedia/emotion/files/patch-src-modules-xine-emotion_xine_vo_out.c --- src/modules/xine/emotion_xine_vo_out.c.orig +++ src/modules/xine/emotion_xine_vo_out.c @@ -119,8 +119,13 @@ _emotion_class_init(xine_t *xine, void * cl = (Emotion_Class *) malloc(sizeof(Emotion_Class)); if (!cl) return NULL; cl-driver_class.open_plugin = _emotion_open; +#if XINE_MAJOR_VERSION 1 || (XINE_MAJOR_VERSION == 1 XINE_MINOR_VERSION 2) cl-driver_class.get_identifier = _emotion_class_identifier_get; cl-driver_class.get_description = _emotion_class_description_get; +#else + cl-driver_class.identifier = _emotion_class_identifier_get(NULL); + cl-driver_class.description = _emotion_class_description_get(NULL); +#endif cl-driver_class.dispose = _emotion_class_dispose; cl-config = xine-config; cl-xine = xine; - End forwarded message - --- src/modules/xine/emotion_xine_vo_out.c.orig +++ src/modules/xine/emotion_xine_vo_out.c @@ -119,8 +119,13 @@ _emotion_class_init(xine_t *xine, void * cl = (Emotion_Class *) malloc(sizeof(Emotion_Class)); if (!cl) return NULL; cl-driver_class.open_plugin = _emotion_open; +#if XINE_MAJOR_VERSION 1 || (XINE_MAJOR_VERSION == 1 XINE_MINOR_VERSION 2) cl-driver_class.get_identifier = _emotion_class_identifier_get; cl-driver_class.get_description = _emotion_class_description_get; +#else + cl-driver_class.identifier = _emotion_class_identifier_get(NULL); + cl-driver_class.description = _emotion_class_description_get(NULL); +#endif cl-driver_class.dispose = _emotion_class_dispose; cl-config = xine-config; cl-xine = xine; -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http
Ubuntu 11.10. I am upgrading to 12.04 beta and it has 3.6.X version. Let me try. Regards Sanjeev On Fri, Mar 2, 2012 at 11:42 PM, Leandro Pereira lean...@profusion.mobiwrote: Sanjeev, On 03/01/2012 11:27 PM, Elevate Efl wrote: Object::HasOwnProperty() is not to be found in v8.h. I did an apt-get update/upgrade and I did not find this in v8.h (version - 3.1.8.22) . The reference API page does provide this API though. Can you tell me which version of libv8 you have used? I'm using the V8 library that comes with Arch Linux (3.6.6.20), which was released September 2011 according to v8's SVN. HasOwnProperty() has a JavaScript counterpart (Object.hasOwnProperty()), so I thought it would be available in V8 since a long time ago. What distribution/version are you using? Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8
Cool. On Sat, Mar 3, 2012 at 2:41 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Test for the existence of Object::HasOwnProperty() Author: acidx Date: 2012-03-02 09:41:22 -0800 (Fri, 02 Mar 2012) New Revision: 68631 Trac: http://trac.enlightenment.org/e/changeset/68631 Modified: trunk/PROTO/elev8/configure.ac Modified: trunk/PROTO/elev8/configure.ac === --- trunk/PROTO/elev8/configure.ac 2012-03-02 17:41:20 UTC (rev 68630) +++ trunk/PROTO/elev8/configure.ac 2012-03-02 17:41:22 UTC (rev 68631) @@ -117,8 +117,10 @@ ]], [[ n = v8::Persistentv8::Number::New(v8::Number::New(0)); + v8::Handlev8::Object o = v8::Object::New(); + o-HasOwnProperty(v8::String::New(bazinga)); ]], -)],[V8_LIBS=-lv8], AC_MSG_ERROR([elev8 requires libv8])) +)],[V8_LIBS=-lv8], AC_MSG_ERROR([elev8 requires libv8 = 3.5.0])) LIBS=$saved_LIBS AC_MSG_RESULT([yes]) AC_LANG_POP -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] (no subject)
Hello,
This patch is for reading socks version5 proxy from global variables.
This is almost same as previous socks version4.
discomfitor can help to review this patch.
Thanks.
--
BRs,
Kim.
Index: src/lib/ecore_con/ecore_con_url.c
===
--- src/lib/ecore_con/ecore_con_url.c (리비전 68637)
+++ src/lib/ecore_con/ecore_con_url.c (작업 사본)
@@ -151,6 +151,8 @@ ecore_con_url_pipeline_get(void)
return EINA_FALSE;
}
+extern Ecore_Con_Socks *_ecore_con_proxy_global;
+
EAPI Ecore_Con_Url *
ecore_con_url_new(const char *url)
{
@@ -182,22 +184,31 @@ ecore_con_url_new(const char *url)
return NULL;
}
+ // Read socks proxy
url_con-proxy_type = -1;
- if (_ecore_con_proxy_global)
- {
-if (_ecore_con_proxy_global-ip)
- {
- char host[128];
- if (_ecore_con_proxy_global-port 0
- _ecore_con_proxy_global-port = 65535)
- snprintf(host, sizeof(host), socks4://%s:%d,
-_ecore_con_proxy_global-ip,
-_ecore_con_proxy_global-port);
- else
- snprintf(host, sizeof(host), socks4://%s,
-_ecore_con_proxy_global-ip);
- ecore_con_url_proxy_set(url_con, host);
- }
+ if (_ecore_con_proxy_global _ecore_con_proxy_global-ip
+ (_ecore_con_proxy_global-version == 4 ||
+_ecore_con_proxy_global-version == 5))
+ {
+char proxy[256];
+char host[256];
+
+if (_ecore_con_proxy_global-version == 5)
+ snprintf(host, sizeof(host), socks5://%s,
+_ecore_con_proxy_global-ip);
+else if (_ecore_con_proxy_global-version == 4)
+ snprintf(host, sizeof(host), socks4://%s,
+_ecore_con_proxy_global-ip);
+
+if (_ecore_con_proxy_global-port 0
+_ecore_con_proxy_global-port = 65535)
+ snprintf(proxy, sizeof(proxy), %s:%d, host,
+_ecore_con_proxy_global-port);
+else snprintf(proxy, sizeof(proxy), %s, host);
+
+ecore_con_url_proxy_set(url_con, proxy);
+ecore_con_url_proxy_username_set(url_con,
+ _ecore_con_proxy_global-username);
}
ret = curl_easy_setopt(url_con-curl_easy, CURLOPT_ENCODING, gzip,deflate);
@@ -1118,17 +1129,20 @@ ecore_con_url_proxy_set(Ecore_Con_Url *u
if (vers-version_num 0x71507)
{
url_con-proxy_type = CURLPROXY_HTTP;
- if (strstr(proxy, socks4)) url_con-proxy_type = CURLPROXY_SOCKS4;
- else if (strstr(proxy, socks4a))
+ if (strstr(proxy, socks4a))
url_con-proxy_type = CURLPROXY_SOCKS4A;
- else if (strstr(proxy, socks5))
- url_con-proxy_type = CURLPROXY_SOCKS5;
+ else if (strstr(proxy, socks4))
+ url_con-proxy_type = CURLPROXY_SOCKS4;
else if (strstr(proxy, socks5h))
url_con-proxy_type = CURLPROXY_SOCKS5_HOSTNAME;
- res = curl_easy_setopt(url_con-curl_easy, CURLOPT_PROXYTYPE, url_con-proxy_type);
+ else if (strstr(proxy, socks5))
+ url_con-proxy_type = CURLPROXY_SOCKS5;
+ res = curl_easy_setopt(url_con-curl_easy, CURLOPT_PROXYTYPE,
+url_con-proxy_type);
if (res != CURLE_OK)
{
- ERR(curl proxy type setting failed: %s, curl_easy_strerror(res));
+ ERR(curl proxy type setting failed: %s,
+ curl_easy_strerror(res));
url_con-proxy_type = -1;
return EINA_FALSE;
}
@@ -1253,6 +1267,7 @@ _ecore_con_url_event_url_complete(Ecore_
if (curlmsg (curlmsg-data.result == CURLE_OK))
curl_easy_getinfo(curlmsg-easy_handle, CURLINFO_RESPONSE_CODE, status);
+ else ERR(Curl message have errors: %d, curlmsg-data.result);
e-status = status;
e-url_con = url_con;
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] (no subject)
On Sat, 3 Mar 2012 13:19:24 +0900 Bluezery ohpo...@gmail.com wrote: Hello, This patch is for reading socks version5 proxy from global variables. This is almost same as previous socks version4. discomfitor can help to review this patch. Thanks. hmm I could be reading this wrong, but it looks to me that this does not allow for socks4a (proxy DNS lookups) inheritance from global proxies? other than that it looks good -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] elm_genlist - add item flip set/get
On Fri, Mar 2, 2012 at 7:39 PM, Daniel Juyung Seo seojuyu...@gmail.com wrote:
Thanks for your patch.
Everything is fine but I still see the floating item bug.
Could you tell me how to reproduce?
i tried several times but i can't see it
And if the item is on dragging, it should not be unrealized.
As far as I know, when an item is on dragging, unrealizing the item
will cause unexpected problems.
I don't remember what it is exactly.
So I politely recommend you to solve this bug with another solution.
dragging is enabled by mouse_move (except group item)
If then how about to define flipped item would not draggable?
Or as i think we should restrict to only one flipped mode item.
What do you think so?
Thanks.
Daniel Juyung Seo (SeoZ)
On Fri, Mar 2, 2012 at 5:14 PM, Hyoyoung Chang hyoyo...@gmail.com wrote:
I attached improved version of flip patch
Thanks
On Thu, Mar 1, 2012 at 10:52 PM, Hyoyoung Chang hyoyo...@gmail.com wrote:
First of all, thanks for detailed review
On Thu, Mar 1, 2012 at 3:01 PM, Daniel Juyung Seo seojuyu...@gmail.com
wrote:
Thanks Hyoyoung, overall it looks good :)
I have some comments.
1. diff option
Create a diff with -x -up optoin.
It shows c function name for each changes.
This makes review so much easier and faster.
$ svn diff -x -up *.c
2. remove default properties from edc.
- mouse_events: 1
- rel1.relative: 0 0
- rel2.relative: 1 1
3. use elm_win_util_standard_add
elm_win_add + elm_bg_add is ok but I encourage you to use
elm_win_util_standard_add in normal cases.
It does elm_win_add + elm_bg_add and reduces 6 lines of code.
I didn't know it. I'll apply
4. formatting
There are some wrong formatted codes.
In or edc?
5. build warnings
test_genlist.c: In function ‘_flip_icon_clicked_cb’:
test_genlist.c:2495:82: warning: unused parameter ‘event_info’
test_genlist.c: In function ‘gl16_content_get’:
test_genlist.c:2516:17: warning: unused variable ‘ic’
test_genlist.c: In function ‘test_genlist16’:
test_genlist.c:2553:39: warning: unused variable ‘bt’
test_genlist.c:2553:33: warning: unused variable ‘bx2’
Yeah, It should be removed
6. In _flip_icon_clicked_cb, you can just do:
tit-checked = !tit-checked
However, I would recommend to use elm_genlist_item_flip_get() instead
of remembering tit-checked.
This covers more API usage and it's useful example.
And without checked, you don't even need to use tit array, you can
just pass (void *)(long) i as an item data.
If you don't prefer to use that casting trick, you can just use tit
but without checked member.
U're right :)
7. const to getters.
Yes, add const to getters.
EAPI Eina_Bool elm_genlist_item_flip_get(const Elm_Object_Item *it);
Yeah i'll add it
8. in elm_genlist_item_flip_set
Instead of
_it-flipped = EINA_TRUE / EINA_FALSE;
You can do
_it-flipped = flip;
9. floating item bug
a. flip many items
b. scroll
Then I can see floating items bug. I attached screenshot.
This also happens easily in this case:
a. flip many items
b. drag flipped item and scroll it out of viewport.
10. if statement in elm_genlist_item_flip_set
You already checked if _it-flipped equals to flip,
so you do not need to check _it-flipped again.
if (_it-flipped == flip) return; you already checked it
if (flip)
else
{
if (_it-flipped) do not need to check this
else
}
First checking is to verify changed.
Second checking is about previous status.
So It leaves at it is.
I don't think it's good or clean code either.
But checking is right. Maybe it should be re-written to make clean code.
These are just trivial comments.
Please apply them.
Otherwise, this patch looks good :)
Thanks.
you're always passionate.
Thanks very much for detail review.
Daniel Juyung Seo (SeoZ)
On Wed, Feb 29, 2012 at 9:17 PM, Hyoyoung Chang hyoyo...@gmail.com wrote:
Dear all.
I made a patch to introduce new genlist item mode.
Two public apis are added.
+EAPI void elm_genlist_item_flip_set(Elm_Object_Item *it, Eina_Bool flip);
+EAPI Eina_Bool elm_genlist_item_flip_get(Elm_Object_Item *it);
It provides on-the-flying item change. It works like that a new item
added on existed item.
In elementary test, you can test it.
It's useful at adding widgets or show buttons in genlist item.
Thanks.
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Virtualization Cloud Management Using Capacity Planning
Cloud computing makes use of
Re: [E-devel] Windows EFL leaking Handles
I tried running the ecore animator example as is. No modifications and the problem persists. The problem is as follows: - TImer is created - Timer continuously creates handles - TImer is deleted - handle creation process comes to a stop If the timer is allowed to continue, Handles are still leaking and real bad. If you let things run with 5 or 6 timers for a couple of hours the computer pretty much grinds to a halt. --- Also again any ideas on the directdraw problem? Anyone? As I said, if the user changes the screen orientation. The drirectdraw canvas dies. Blacks out. I am assuming it is because the graphics device is taken over by windows to change the screen orientation. The ddraw canvas is unable to get the device back once the screen orientation is changed. On Thu, Mar 1, 2012 at 9:59 PM, HariHara Sudhan h...@emo2.com wrote: I had tried this with the ecore animator example yesterday. Will do it again and send you the results. On Thu, Mar 1, 2012 at 6:36 PM, Vincent Torri vincent.to...@gmail.comwrote: On Thu, Mar 1, 2012 at 1:11 PM, HariHara Sudhan h...@emo2.com wrote: Yesterday I was trying to use http://www.codeproject.com/Articles/150463/LeakMon-Track-Handle-leak-GDI-Leak-and-Memory-Leak i've indeed seen it before. Can you try it with the ecore_animator example ? Vincent Do let me know this one is ok. btw on an unrelated problem. I am running EFL on DirectDraw. The application runs perfect and I have to say beautifully well. Except for when the user changes screen orientation. EFL immediately displays a black screen (in the application) and the display is lost. One has to restart the application post that and things work. I have been behind this problem for a day or two now and am hopelessly lost. Is there something we need to do once the enumdisplaysettings is done? Like refresh the buffer or close and reinitialize ddraw? On Thu, Mar 1, 2012 at 4:51 PM, Vincent Torri vincent.to...@gmail.com wrote: On Wed, Feb 29, 2012 at 9:23 AM, HariHara Sudhan h...@emo2.com wrote: Also with GDI the leak is very high while with directx handles leak slower. Nevertheless there is some kind of a leak. Am I doing something wrong ? I don't think so. It's more the GDI engine that is leaking. If you know good tools to see where there are leaks, i'll try to debug that Vincent On Wed, Feb 29, 2012 at 1:50 PM, HariHara Sudhan h...@emo2.com wrote: Hello Devs, I have a strange problem. EFL running on windows minGw starts leaking handles (constantly creates handles crossing 400+ over a few minutes time) when you run a timer or animator. Any guesses on why this is happening? I am running this example - http://docs.enlightenment.org/auto/ecore/ecore_animator_example_8c-example.html To see the handles being created I use windows task manager with handles column enabled -- Regards HariHaraSudhan -- Regards HariHaraSudhan -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Regards HariHaraSudhan -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing
Re: [E-devel] Windows EFL leaking Handles
On Sat, Mar 3, 2012 at 8:15 AM, HariHara Sudhan h...@emo2.com wrote: I tried running the ecore animator example as is. No modifications and the problem persists. The problem is as follows: - TImer is created - Timer continuously creates handles - TImer is deleted - handle creation process comes to a stop If the timer is allowed to continue, Handles are still leaking and real bad. If you let things run with 5 or 6 timers for a couple of hours the computer pretty much grinds to a halt. but does the codeproject program report some useful informations, like the GDI functions that are leaking ? If not, this program is of no use --- Also again any ideas on the directdraw problem? Anyone? As I said, if the user changes the screen orientation. The drirectdraw canvas dies. Blacks out. I am assuming it is because the graphics device is taken over by windows to change the screen orientation. The ddraw canvas is unable to get the device back once the screen orientation is changed. a bug in the directdraw engine. Do you have a minimal test case ? Vincent -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/bin
Hello, On Fri, Mar 2, 2012 at 5:34 AM, Leif Middelschulte leif.middelschu...@gmail.com wrote: Since the order is important, why not use single select and dnd to sort the list? Like this, the reason for multiselect isn't communicated at all. Only people who know that elm has fallbacks could conclude this. Agreed. This is a better solution :) Daniel Juyung Seo (SeoZ) 2012/3/1 Enlightenment SVN no-re...@enlightenment.org: Log: @68591: multiselect here is intentional to allow for theme overlays try asking in irc or mailing list before randomly changing things like this. Author: discomfitor Date: 2012-03-01 12:16:28 -0800 (Thu, 01 Mar 2012) New Revision: 68592 Trac: http://trac.enlightenment.org/e/changeset/68592 Modified: trunk/elementary/src/bin/config.c Modified: trunk/elementary/src/bin/config.c === --- trunk/elementary/src/bin/config.c 2012-03-01 20:12:47 UTC (rev 68591) +++ trunk/elementary/src/bin/config.c 2012-03-01 20:16:28 UTC (rev 68592) @@ -1335,6 +1335,7 @@ evas_object_show(pd); li = elm_list_add(win); + elm_list_multi_select_set(li, EINA_TRUE); evas_object_size_hint_weight_set(li, 1.0, 1.0); evas_object_size_hint_align_set(li, EVAS_HINT_FILL, EVAS_HINT_FILL); elm_object_content_set(pd, li); -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Leif -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
