Re: [FFmpeg-devel] [PATCH] configure: add threads dep for vulkan

2024-03-12 Thread Gyan Doshi
On 2024-03-12 09:15 pm, Lynne wrote: Mar 12, 2024, 05:16 by ffm...@gyani.pro: Fixes #10900 --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 05f8283af9..e0b5bcf589 100755 --- a/configure +++ b/configure @@ -3076,6 +3076,7 @@

Re: [FFmpeg-devel] [PATCH v6 2/9] avcodec/vaapi_encode: introduce a base layer for vaapi encode

2024-03-12 Thread Lynne
Feb 29, 2024, 06:35 by tong1.wu-at-intel@ffmpeg.org: > From: Tong Wu > > Since VAAPI and future D3D12VA implementation may share the same dpb > logic and some other functions. A base layer encode context is introduced > as vaapi context's base and extract the related funtions to a common >

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: avoid asendcmd assertion failure

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024 at 9:01 PM Pavel Koshevoy wrote: > From: Rajiv Harlalka > > Check for zeros equal to the total samples early, because in > that case we would already be leaving the first few frames out. > > Fixes trac ticket #10692 > --- > libavfilter/af_atempo.c | 18 +- >

Re: [FFmpeg-devel] [PATCH v6 8/9] avcodec: add D3D12VA hardware HEVC encoder

2024-03-12 Thread Wu, Tong1
Kindly ping. Hi Mark, do you have more comments on this patch set? >Subject: [FFmpeg-devel][PATCH v6 8/9] avcodec: add D3D12VA hardware HEVC >encoder > >From: Tong Wu > >This implementation is based on D3D12 Video Encoding Spec:

Re: [FFmpeg-devel] [PATCH] af_tempo.c: fix checking of samples and zero frame counts

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024 at 8:22 PM Pavel Koshevoy wrote: > > > On Tue, Mar 12, 2024 at 2:52 AM Rajiv Harlalka > wrote: > >> On 3/8/24 4:34 AM, Rajiv Harlalka wrote: >> > Check for zeros equal to the total samples early, because in case the >> > check is true we would already be leaving the first

[FFmpeg-devel] [PATCH] lavfi/atempo: avoid asendcmd assertion failure

2024-03-12 Thread Pavel Koshevoy
From: Rajiv Harlalka Check for zeros equal to the total samples early, because in that case we would already be leaving the first few frames out. Fixes trac ticket #10692 --- libavfilter/af_atempo.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] af_tempo.c: fix checking of samples and zero frame counts

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024 at 2:52 AM Rajiv Harlalka wrote: > On 3/8/24 4:34 AM, Rajiv Harlalka wrote: > > Check for zeros equal to the total samples early, because in case the > > check is true we would already be leaving the first few frames out. > > > > Signed-off-by: Rajiv Harlalka > > #10692 > >

[FFmpeg-devel] [PATCH] avcodec/ppc/vp8dsp_altivec: Fix out-of-bounds access

2024-03-12 Thread Andreas Rheinhardt
h_subpel_filters_inner[i] and h_subpel_filters_outer[i / 2] belong together and the former allows the range 0..6, so the latter needs to support 0..3. But it has only three elements. Add another one. The value for the last element has been guesstimated from subpel_filters in libavcodec/vp8dsp.c.

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Michael Niedermayer
Hi On Tue, Mar 12, 2024 at 01:14:45PM -0400, Ronald S. Bultje wrote: > Hello, > > On Sat, Mar 9, 2024 at 8:25 PM Michael Niedermayer > wrote: > > > Some members of the CC want to indefinitely ban Balling > > from trac. And as our doc/community.texi says: > > "Indefinite bans from the community

[FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Align idct-block appropriately

2024-03-12 Thread Andreas Rheinhardt
It is accessed via AV_RN64() in ff_simple_idct_put_int32_10bit(). Should fix the UBSan failures in the mpeg4-simple-studio-profile test here: https://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH] avcodec/lossless_videoencdsp: Fix unaligned access

2024-03-12 Thread Andreas Rheinhardt
HAVE_FAST_UNALIGNED being true does not imply that one can simply read from any pointer via *(long*). It is undefined behaviour in case the pointer is not sufficiently aligned; and even if it is, it is (likely) a violation of the effective-type rules. Fix both of these by using the appropriate

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Michael Niedermayer
On Mon, Mar 11, 2024 at 05:40:25PM -0400, Leo Izen wrote: > > > On 3/9/24 20:25, Michael Niedermayer wrote: > > Hi everyone > > > > Some members of the CC want to indefinitely ban Balling > > from trac. And as our doc/community.texi says: > > "Indefinite bans from the community must be

Re: [FFmpeg-devel] [PATCH] avcodec/parser: Check next against buffer index

2024-03-12 Thread James Almer
On 6/24/2023 5:13 PM, Reimar Döffinger wrote: Hi! On 24 Jun 2023, at 21:14, Andreas Rheinhardt wrote: Michael Niedermayer: Fixes: out of array access Fixes: crash-0d640731c7da52415670eb47a2af701cbe2e1a3b Found-by: Catena cyber Signed-off-by: Michael Niedermayer --- libavcodec/parser.c |

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Fix integer overflow iff ULONG_MAX < INT64_MAX

2024-03-12 Thread James Almer
On 3/12/2024 8:01 PM, Andreas Rheinhardt wrote: James Almer: On 3/12/2024 7:57 PM, Andreas Rheinhardt wrote: Affects many FATE-tests, see http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt ---   libavformat/avidec.c

[FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Check before accessing union member

2024-03-12 Thread Andreas Rheinhardt
OptionDef.u is only an offset (i.e. its off member) iff OPT_FLAG_OFFSET is true. Otherwise, the pointer arithmetic can be undefined behaviour. UBSan warns about this (on 32bit arches): src/fftools/ffmpeg_opt.c:102:15: runtime error: pointer index expression with base 0xffa4db10 overflowed to

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Marth64
I get it now. Disregard patch. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Fix integer overflow iff ULONG_MAX < INT64_MAX

2024-03-12 Thread Andreas Rheinhardt
James Almer: > On 3/12/2024 7:57 PM, Andreas Rheinhardt wrote: >> Affects many FATE-tests, see >> http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu >> >> Signed-off-by: Andreas Rheinhardt >> --- >>   libavformat/avidec.c | 2 +- >>   1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Fix integer overflow iff ULONG_MAX < INT64_MAX

2024-03-12 Thread James Almer
On 3/12/2024 7:57 PM, Andreas Rheinhardt wrote: Affects many FATE-tests, see http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt --- libavformat/avidec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Andreas Rheinhardt
Marth64: >> The code block changes str and str is later accessed (via splitconf). > Sorry, for the lack of awareness, but I am confused how. > strstr() shouldn't modify the string right? > The only change I see is in the unused remove_tilde[] > No, but strstr() returns a pointer pointing into

[FFmpeg-devel] [PATCH] avformat/avidec: Fix integer overflow iff ULONG_MAX < INT64_MAX

2024-03-12 Thread Andreas Rheinhardt
Affects many FATE-tests, see http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt --- libavformat/avidec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Marth64
> The code block changes str and str is later accessed (via splitconf). Sorry, for the lack of awareness, but I am confused how. strstr() shouldn't modify the string right? The only change I see is in the unused remove_tilde[] Thank you, for taking a look and explaining.

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Andreas Rheinhardt
Marth64: > I found this code block when looking at this warning thrown in my > compiler (gcc 11.4.0 x86_64-linux-gnu): > > ``` > In function ‘print_buildconf’, > inlined from ‘show_buildconf’ at fftools/opt_common.c:260:5: > fftools/opt_common.c:226:49: warning: writing 1 byte into a region

[FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Marth64
I found this code block when looking at this warning thrown in my compiler (gcc 11.4.0 x86_64-linux-gnu): ``` In function ‘print_buildconf’, inlined from ‘show_buildconf’ at fftools/opt_common.c:260:5: fftools/opt_common.c:226:49: warning: writing 1 byte into a region of size 0

[FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior

2024-03-12 Thread Stone Chen
The documentation correctly states that the rdiv is a multiplier but incorrectly states the default behavior is to multiply by the sum of all matrix elements - it multiplies by 1/sum. This changes the documentation to match the code. --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+),

[FFmpeg-devel] [PATCH] avcodec/ppc/h264dsp: Fix unaligned stores

2024-03-12 Thread Andreas Rheinhardt
Exposed by http://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt --- I only tested that it compiles (and the size of .text even goes down a bit, presumably because of the elimination of int_dst_stride (which basically means

Re: [FFmpeg-devel] [PATCH] avcodec/parser: Check next against buffer index

2024-03-12 Thread Michael Niedermayer
On Sat, Jun 24, 2023 at 10:13:48PM +0200, Reimar Döffinger wrote: > Hi! > > > On 24 Jun 2023, at 21:14, Andreas Rheinhardt > > wrote: > > > > Michael Niedermayer: > >> Fixes: out of array access > >> Fixes: crash-0d640731c7da52415670eb47a2af701cbe2e1a3b > >> > >> Found-by: Catena cyber > >>

Re: [FFmpeg-devel] [PATCH 1/1] avformat/gopher: Add audio and video itemtypes

2024-03-12 Thread Marton Balint
On Tue, 5 Mar 2024, Christian Lee Seibold wrote: The 's', ';', and '<' itemtypes are used for audio and video by Gophernicus and Gopher+. Signed-off-by: Christian Lee Seibold --- libavformat/gopher.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/gopher.c

Re: [FFmpeg-devel] [PATCH] fate: fix generating references when sh=dash

2024-03-12 Thread Marton Balint
On Tue, 12 Mar 2024, Nicolas Gaullier wrote: Regression since 0b98f28c46a7e3e914c51debc461 Signed-off-by: Nicolas Gaullier --- tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 0fead78c58..9863e4f2d9 100755 ---

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_cabac: Let compiler count offsets

2024-03-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This is easily possible with an X macro. > Using an enum for the offsets also allows to remove > two arrays which are not really needed and will typically > be optimized away by the compiler: The first just exists > to count the number of syntax elements*, the second one >

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Vittorio Giovara
On Tue, Mar 12, 2024 at 5:20 PM Marth64 wrote: > I have not interacted with this user and I am just a mediocre contributor. > But from my experience running forums and IRC networks in the past, > this always ends in one process... > >1. toxic user comes along >2. upsets people

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: Skip more parts of header to let parsing continue

2024-03-12 Thread Marton Balint
On Mon, 11 Mar 2024, Kristoffer Brånemyr via ffmpeg-devel wrote: Den måndag 26 februari 2024 kl. 19:36:58 CET, Kristoffer Brånemyr via ffmpeg-devel skrev: Hi, Here is a short patch to skip more parts of the header for the WebVTT subtitle format. Without this the parser seems to stop

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

2024-03-12 Thread Niklas Haas
On Mon, 11 Mar 2024 22:32:01 + Mark Thompson wrote: > This is not correct. Along with scalable cases, the multiple param sets are > to support applying film grain at the display resolution after scaling, > providing a better result than upscaling the grain applied at the decode >

Re: [FFmpeg-devel] [PATCH v2 7/9] avformat/pcm: factorize and improve determining the default packet size

2024-03-12 Thread Marton Balint
On Fri, 8 Mar 2024, Marton Balint wrote: - Remove the 1024 cap on the number of samples, for high sample rate audio it was suboptimal, calculate the low neighbour power of two for the number of samples (audio blocks) instead. - Make the function work correctly for non-pcm codecs by using

Re: [FFmpeg-devel] [PATCH v8 09/14] avcodec: add frame side data array to AVCodecContext

2024-03-12 Thread James Almer
On 3/11/2024 5:58 PM, Jan Ekström wrote: This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 8 libavcodec/options.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 21fc74707f..432a3fd153

Re: [FFmpeg-devel] [PATCH v8 08/14] avutil/frame: add helper for getting side data from array

2024-03-12 Thread James Almer
On 3/11/2024 5:58 PM, Jan Ekström wrote: --- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 30db83a5e5..47ecd964b8 100644 --- a/libavutil/frame.c

Re: [FFmpeg-devel] [PATCH] change av_ts_make_time_string precision

2024-03-12 Thread Marton Balint
On Tue, 12 Mar 2024, Allan Cady via ffmpeg-devel wrote: On Monday, March 11, 2024 at 12:11:45 PM PDT, Marton Balint wrote: On Mon, 11 Mar 2024, Andreas Rheinhardt wrote: Allan Cady via ffmpeg-devel: From: "Allan Cady" I propose changing the format to "%.6f", which will give microsecond

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Marth64
I have not interacted with this user and I am just a mediocre contributor. But from my experience running forums and IRC networks in the past, this always ends in one process... 1. toxic user comes along 2. upsets people repeatedly, which also wastes time 3. admins ponder ban, which

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flac

2024-03-12 Thread Andreas Rheinhardt
Stefano Sabatini: > --- > doc/muxers.texi | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index de4b9b01f5..64d9221198 100644 > --- a/doc/muxers.texi > +++ b/doc/muxers.texi > @@ -1612,6 +1612,17 @@ This image format is used to store

Re: [FFmpeg-devel] [PATCH v8 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-12 Thread James Almer
On 3/11/2024 5:58 PM, Jan Ekström wrote: This was requested to be added in review. --- libavutil/frame.c | 43 ++- libavutil/frame.h | 21 + 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/libavutil/frame.c

Re: [FFmpeg-devel] [PATCH 1/2] doc/muxers: add film_cpk

2024-03-12 Thread Marth64
> SEGA FILM (.cpk) muxer. > This format was used as internal format for several SEGA games. > For more information regarding the Sega FILM file format (trivial nit) Sega should be capitalized SEGA I believe, this would make it consistent in all 3 lines. But it's still fine. LGTM.

Re: [FFmpeg-devel] [PATCH v8 06/14] avutil/frame: add helper for adding existing side data to array

2024-03-12 Thread James Almer
On 3/11/2024 5:58 PM, Jan Ekström wrote: --- libavutil/frame.c | 49 +++ libavutil/frame.h | 20 +++ 2 files changed, 69 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 4074391a92..46f976a3ed 100644 ---

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flac

2024-03-12 Thread Marth64
LGTM On Tue, Mar 12, 2024 at 4:01 PM Stefano Sabatini wrote: > --- > doc/muxers.texi | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index de4b9b01f5..64d9221198 100644 > --- a/doc/muxers.texi > +++ b/doc/muxers.texi > @@ -1612,6

[FFmpeg-devel] [PATCH] doc/muxers: add flac

2024-03-12 Thread Stefano Sabatini
--- doc/muxers.texi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index de4b9b01f5..64d9221198 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1612,6 +1612,17 @@ This image format is used to store astronomical data. For more information

Re: [FFmpeg-devel] [PATCH] avformat/fifo_test: Move into tests/fifo_muxer.c

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 21:25:31 +0100, Andreas Rheinhardt wrote: [...] > > nit: FifoTestMuxerPacketData > > > > This would necessitate changes to the part of the test tool that I did > not change and would therefore need to be a commit of its own. I can do > this, of course. Of course, feel

[FFmpeg-devel] [PATCH] doc/muxers: add fits

2024-03-12 Thread Stefano Sabatini
--- doc/muxers.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 2c05b17f5e..de4b9b01f5 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1604,6 +1604,14 @@ Adobe Filmstrip muxer. This format is used by several Adobe tools to store a

[FFmpeg-devel] [PATCH 2/2] doc/muxers: add filstrip

2024-03-12 Thread Stefano Sabatini
--- doc/muxers.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 7f9ff9929f..2c05b17f5e 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1598,6 +1598,12 @@ For more information regarding the Sega FILM file format, visit It accepts at

[FFmpeg-devel] [PATCH 1/2] doc/muxers: add film_cpk

2024-03-12 Thread Stefano Sabatini
--- doc/muxers.texi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 12bc433409..7f9ff9929f 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1587,6 +1587,17 @@ ffmpeg -re -i ... -c:v libx264 -c:a aac -f fifo -fifo_format fifo_test

Re: [FFmpeg-devel] [PATCH] avformat/fifo_test: Move into tests/fifo_muxer.c

2024-03-12 Thread Andreas Rheinhardt
Stefano Sabatini: > On date Tuesday 2024-03-12 19:43:29 +0100, Andreas Rheinhardt wrote: >> This muxer solely exists to test the fifo muxer via a dedicated >> test tool in libavformat/tests/fifo_muxer.c. It fulfills no >> other role and it is only designed with this role in mind. >> >> The latter

Re: [FFmpeg-devel] [PATCH] avformat/fifo_test: Move into tests/fifo_muxer.c

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 19:43:29 +0100, Andreas Rheinhardt wrote: > This muxer solely exists to test the fifo muxer via a dedicated > test tool in libavformat/tests/fifo_muxer.c. It fulfills no > other role and it is only designed with this role in mind. > > The latter can be seen in two

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Paul B Mahol
On Tue, Mar 12, 2024 at 7:11 PM Kieran Kunhya wrote: > > > > Dear LibAV core developer, thank you for this transcript. > > > > If you feel like trolling, at least get your facts correct. > Dear minor contributor, can you give link to fact checker to use? > > Kieran >

Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers: add fifo_test

2024-03-12 Thread Andreas Rheinhardt
Stefano Sabatini: > On date Tuesday 2024-03-12 13:25:23 +0100, Andreas Rheinhardt wrote: >> Stefano Sabatini: >>> --- >>> doc/muxers.texi | 30 ++ >>> 1 file changed, 30 insertions(+) >>> > [...] >> I do not think that this muxer should be publically documented. In

[FFmpeg-devel] [PATCH 4/4] avformat/matroska: use named constants for ITU-T T.35 metadata

2024-03-12 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskadec.c | 4 +++- libavformat/matroskaenc.c | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index a35ca6ca5b..8897fd622c 100644 --- a/libavformat/matroskadec.c +++

[FFmpeg-devel] [PATCH 3/4] avcodec/libdav1d: use named constants for ITU-T T.35 metadata

2024-03-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libdav1d.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 1aa2d1f343..597944d88d 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -37,6 +37,7 @@

[FFmpeg-devel] [PATCH 2/4] avcodec/h2645_sei: use named constants for ITU-T T.35 metadata

2024-03-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h2645_sei.c | 10 ++ libavcodec/itut35.h| 2 ++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index e60606f43f..e8eb15524f 100644 --- a/libavcodec/h2645_sei.c +++

[FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: use named constants for ITU-T T.35 metadata

2024-03-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/av1dec.c | 12 +++- libavcodec/itut35.h | 28 2 files changed, 35 insertions(+), 5 deletions(-) create mode 100644 libavcodec/itut35.h diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index

[FFmpeg-devel] [PATCH] avformat/fifo_test: Move into tests/fifo_muxer.c

2024-03-12 Thread Andreas Rheinhardt
This muxer solely exists to test the fifo muxer via a dedicated test tool in libavformat/tests/fifo_muxer.c. It fulfills no other role and it is only designed with this role in mind. The latter can be seen in two facts: The muxer uses printf for logging and it simply presumes the packets' data to

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Kieran Kunhya
> > Dear LibAV core developer, thank you for this transcript. > If you feel like trolling, at least get your facts correct. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Paul B Mahol
On Tue, Mar 12, 2024 at 6:15 PM Ronald S. Bultje wrote: > Hello, > > On Sat, Mar 9, 2024 at 8:25 PM Michael Niedermayer > > wrote: > > > Some members of the CC want to indefinitely ban Balling > > from trac. And as our doc/community.texi says: > > "Indefinite bans from the community must be

Re: [FFmpeg-devel] Indefinite ban request [RFC] Was: Re: [FFmpeg-trac] #10882(undetermined:new): swscale wastefully scales luma during yuv420p -> yuv422p

2024-03-12 Thread Ronald S. Bultje
Hello, On Sat, Mar 9, 2024 at 8:25 PM Michael Niedermayer wrote: > Some members of the CC want to indefinitely ban Balling > from trac. And as our doc/community.texi says: > "Indefinite bans from the community must be confirmed by the General > Assembly, in a majority vote." > > Thus some CC

Re: [FFmpeg-devel] [PATCH v3] avformat/dvdvideodec: use int64_t for menu blocks_read and make format expressions portable

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 11:14:09 -0500, Marth64 wrote: > Signed-off-by: Marth64 > --- > libavformat/dvdvideodec.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) LGTM, thanks (will apply soon if there are no further comments).

Re: [FFmpeg-devel] [PATCH v4] avcodec/mpeg12dec: extract only one type of CC substream

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 10:43:11 -0500, Marth64 wrote: > In MPEG-2 user data, there can be different types of Closed Captions > formats embedded (A53, SCTE-20, or DVD). The current behavior of the > CC extraction code in the MPEG-2 decoder is to not be aware of > multiple formats if multiple

Re: [FFmpeg-devel] [PATCH] doc/muxers: add ffmetadata

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 16:33:20 +0530, Gyan Doshi wrote: > On 2024-03-12 04:25 pm, Stefano Sabatini wrote: > > --- > > doc/metadata.texi | 1 + > > doc/muxers.texi | 16 > > 2 files changed, 17 insertions(+) > > Updated. >From ce9846bc53c29ad2ff0331b5c90173120014843e

Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers: add fifo_test

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 13:25:23 +0100, Andreas Rheinhardt wrote: > Stefano Sabatini: > > --- > > doc/muxers.texi | 30 ++ > > 1 file changed, 30 insertions(+) > > [...] > I do not think that this muxer should be publically documented. In fact, > I think it would

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Use ff_tget_long() where appropriate

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 15:49:45 +0100, Andreas Rheinhardt wrote: > No need to use the generic ff_tget() when we know the type. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/tiff.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-)

[FFmpeg-devel] [PATCH v3] avformat/dvdvideodec: use int64_t for menu blocks_read and make format expressions portable

2024-03-12 Thread Marth64
Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index a182f95097..761ac97ec6 100644 --- a/libavformat/dvdvideodec.c +++ b/libavformat/dvdvideodec.c @@

Re: [FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: use int64_t for menu blocks_read and fix format statement

2024-03-12 Thread Marth64
Fix on the way with PRId64 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: use int64_t for menu blocks_read and fix format statement

2024-03-12 Thread Andreas Rheinhardt
Marth64: > Signed-off-by: Marth64 > --- > libavformat/dvdvideodec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c > index a182f95097..19efc068cb 100644 > --- a/libavformat/dvdvideodec.c > +++

[FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: use int64_t for menu blocks_read and fix format statement

2024-03-12 Thread Marth64
Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index a182f95097..19efc068cb 100644 --- a/libavformat/dvdvideodec.c +++ b/libavformat/dvdvideodec.c @@ -392,7 +392,7

Re: [FFmpeg-devel] [PATCH] configure: add threads dep for vulkan

2024-03-12 Thread Lynne
Mar 12, 2024, 05:16 by ffm...@gyani.pro: > Fixes #10900 > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure > index 05f8283af9..e0b5bcf589 100755 > --- a/configure > +++ b/configure > @@ -3076,6 +3076,7 @@ nvdec_deps="ffnvcodec" >

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: use correct format string for menu read error, fixes compiler warning

2024-03-12 Thread Marth64
v2 on the way ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v4] avcodec/mpeg12dec: extract only one type of CC substream

2024-03-12 Thread Marth64
In MPEG-2 user data, there can be different types of Closed Captions formats embedded (A53, SCTE-20, or DVD). The current behavior of the CC extraction code in the MPEG-2 decoder is to not be aware of multiple formats if multiple exist, therefore allowing one format to overwrite the other during

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: use correct format string for menu read error, fixes compiler warning

2024-03-12 Thread Andreas Rheinhardt
Marth64: > Signed-off-by: Marth64 > --- > libavformat/dvdvideodec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c > index a182f95097..0ae2110cd2 100644 > --- a/libavformat/dvdvideodec.c > +++

Re: [FFmpeg-devel] [PATCH v4] avcodec/libx264: fix extradata when config annexb=0

2024-03-12 Thread Andreas Rheinhardt
James Almer: > On 3/12/2024 12:00 PM, Andreas Rheinhardt wrote: >> Zhao Zhili: >>> From: Zhao Zhili >>> >>> --- >>> v4: Fix missing SEI in set_avcc_extradata >>> v3: Remove unnecessary inclusion >>> >>>   configure    |   2 +- >>>   libavcodec/libx264.c | 153

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: use correct format string for menu read error, fixes compiler warning

2024-03-12 Thread Marth64
Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index a182f95097..0ae2110cd2 100644 --- a/libavformat/dvdvideodec.c +++ b/libavformat/dvdvideodec.c @@ -423,7 +423,7 @@

Re: [FFmpeg-devel] [PATCH v4] avcodec/libx264: fix extradata when config annexb=0

2024-03-12 Thread James Almer
On 3/12/2024 12:00 PM, Andreas Rheinhardt wrote: Zhao Zhili: From: Zhao Zhili --- v4: Fix missing SEI in set_avcc_extradata v3: Remove unnecessary inclusion configure| 2 +- libavcodec/libx264.c | 153 --- 2 files changed, 130

Re: [FFmpeg-devel] [PATCH v4] avcodec/libx264: fix extradata when config annexb=0

2024-03-12 Thread Andreas Rheinhardt
Zhao Zhili: > From: Zhao Zhili > > --- > v4: Fix missing SEI in set_avcc_extradata > v3: Remove unnecessary inclusion > > configure| 2 +- > libavcodec/libx264.c | 153 --- > 2 files changed, 130 insertions(+), 25 deletions(-) > > diff

[FFmpeg-devel] [PATCH] avcodec/tiff: Use ff_tget_long() where appropriate

2024-03-12 Thread Andreas Rheinhardt
No need to use the generic ff_tget() when we know the type. Signed-off-by: Andreas Rheinhardt --- libavcodec/tiff.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 8f278bfd12..3238b208d8

Re: [FFmpeg-devel] [PATCH v3 5/6] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-12 Thread Marth64
Will address, thanks for the review. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v4] avcodec/libx264: fix extradata when config annexb=0

2024-03-12 Thread Zhao Zhili
From: Zhao Zhili --- v4: Fix missing SEI in set_avcc_extradata v3: Remove unnecessary inclusion configure| 2 +- libavcodec/libx264.c | 153 --- 2 files changed, 130 insertions(+), 25 deletions(-) diff --git a/configure b/configure index

Re: [FFmpeg-devel] [PATCH v3 6/6] avformat/sccdec: remove unused bprint.h include

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:05 -0500, Marth64 wrote: > Signed-off-by: Marth64 > --- > libavformat/sccdec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c > index 5f2f95d80e..f6d5f29a0a 100644 > --- a/libavformat/sccdec.c > +++

Re: [FFmpeg-devel] [PATCH v3 4/6] avcodec/rcwtenc: canonize name and refresh documentation

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:03 -0500, Marth64 wrote: > The formal title of the muxer according to the specification > is "RCWT (Raw Captions With Time)", so canonize this > in the long name of the codec and docs. > > In the documentation section, point #2 was wrong: ccextractor > extracts

Re: [FFmpeg-devel] [PATCH v3 3/6] avcodec/ccaption_dec: ignore leading non-breaking spaces

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:02 -0500, Marth64 wrote: > In Closed Captions (US), the non-breaking space (0xA0) can be used to > align text horizontally from the left when used as a leading character. > However, CC decoder does not ignore it as a leading character > like it does an ordinary

Re: [FFmpeg-devel] [PATCH v3 2/6] avcodec/ccaption_dec: don't print multiple \an and \pos tags

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:01 -0500, Marth64 wrote: > Closed Captions decoder prints multiple \pos ASS tags per cue, > and preceding the \pos tag is a fixed \an7 that fixes rendering > position from the top left corner and enforces justification. > > Printing multiple \an and \pos tags in

[FFmpeg-devel] [PATCH 4/4] checkasm: hevc_pel: Use checkasm_check for printing failing output

2024-03-12 Thread Martin Storsjö
This simplifies the code for checking the output, and can print the failing output (including a map of matching/mismatching elements) if checkasm is run with the -v/--verbose option. --- tests/checkasm/hevc_pel.c | 71 ++- 1 file changed, 41 insertions(+), 30

[FFmpeg-devel] [PATCH 3/4] checkasm: hevc_pel: Split a couple excessively long lines

2024-03-12 Thread Martin Storsjö
--- tests/checkasm/hevc_pel.c | 134 -- 1 file changed, 98 insertions(+), 36 deletions(-) diff --git a/tests/checkasm/hevc_pel.c b/tests/checkasm/hevc_pel.c index 065da87622..73a4619978 100644 --- a/tests/checkasm/hevc_pel.c +++ b/tests/checkasm/hevc_pel.c @@

[FFmpeg-devel] [PATCH 2/4] checkasm: hevc_pel: Check the full output in hevc_epel/hevc_qpel

2024-03-12 Thread Martin Storsjö
Previously it only checked half the output in 8 bit per pixel mode, as the output actually is 16 bit elements here. --- tests/checkasm/hevc_pel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/hevc_pel.c b/tests/checkasm/hevc_pel.c index

[FFmpeg-devel] [PATCH 1/4] aarch64: Fix ff_hevc_put_hevc_epel_h48_8_neon_i8mm

2024-03-12 Thread Martin Storsjö
The first 32 elements of each row were correct, while the last 16 were scrambled. This hasn't been noticed, because the checkasm test erroneously only checked half of the output (for 8 bit functions), and apparently none of the samples as part of "fate-hevc" seem to trigger this specific

Re: [FFmpeg-devel] [PATCH] af_tempo.c: fix checking of samples and zero frame counts

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024, 02:52 Rajiv Harlalka wrote: > On 3/8/24 4:34 AM, Rajiv Harlalka wrote: > > Check for zeros equal to the total samples early, because in case the > > check is true we would already be leaving the first few frames out. > > > > Signed-off-by: Rajiv Harlalka > > #10692 > > ---

Re: [FFmpeg-devel] [PATCH] lavc/vvc: AVERROR_PATCHWELCOME for subpictures

2024-03-12 Thread Nuo Mi
On Tue, Mar 12, 2024 at 5:09 PM Frank Plowman wrote: > On 12/03/2024 03:33, Wang, Fei W wrote: > > On Mon, 2024-03-11 at 21:57 -0300, James Almer wrote: > >> On 3/11/2024 9:49 PM, Michael Niedermayer wrote: > >>> On Mon, Mar 11, 2024 at 06:53:31PM +, Frank Plowman wrote: > VVC's

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/vvc_ps: Correct NoOutputBeforeRecoveryFlag of IDR

2024-03-12 Thread Nuo Mi
On Mon, Mar 11, 2024 at 9:58 AM wrote: > From: Fei Wang > > The NoOutputBeforeRecoveryFlag of an IDR frame should be set to 1 as > spec says in 8.1.1. > Pushed. Thank you, Fei. > > Signed-off-by: Fei Wang > --- > libavcodec/vvc/vvc_ps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers: add fifo_test

2024-03-12 Thread Andreas Rheinhardt
Stefano Sabatini: > --- > doc/muxers.texi | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index 0aaef2b520..ccbb741992 100644 > --- a/doc/muxers.texi > +++ b/doc/muxers.texi > @@ -1556,6 +1556,36 @@ ffmpeg -re -i ...

[FFmpeg-devel] [PATCH] doc/fate: advise on --assert-level=2

2024-03-12 Thread Nicolas Gaullier
Signed-off-by: Nicolas Gaullier --- doc/fate.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/fate.texi b/doc/fate.texi index 2fa8c34c2d..17644ce65a 100644 --- a/doc/fate.texi +++ b/doc/fate.texi @@ -79,6 +79,14 @@ Do not put a '~' character in the samples path to indicate a

[FFmpeg-devel] [PATCH] fate: fix generating references when sh=dash

2024-03-12 Thread Nicolas Gaullier
Regression since 0b98f28c46a7e3e914c51debc461 Signed-off-by: Nicolas Gaullier --- tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 0fead78c58..9863e4f2d9 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@

Re: [FFmpeg-devel] [PATCH v3 1/6] avcodec/mpeg12dec: extract only one type of CC substream

2024-03-12 Thread Andreas Rheinhardt
Stefano Sabatini: > On date Tuesday 2024-03-12 01:00:00 -0500, Marth64 wrote: >> In MPEG-2 user data, there can be different types of Closed Captions >> formats embedded (A53, SCTE-20, or DVD). The current behavior of the >> CC extraction code in the MPEG-2 decoder is to not be aware of >>

Re: [FFmpeg-devel] [PATCH v3 5/6] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-12 Thread Andreas Rheinhardt
Marth64: > Raw Captions With Time (RCWT) is a format native to ccextractor, a commonly > used open source tool for processing 608/708 Closed Captions (CC) sources. > RCWT can be used to archive the original CC bitstream. The muxer was added > in January 2024. In this commit, add the demuxer. > >

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-12 Thread asivery via ffmpeg-devel
Thank you Stefano Sabatini and Andreas Rheinhardt - you guys have the patience of saints. On Tuesday, March 12th, 2024 at 11:27 AM, Stefano Sabatini wrote: > On date Sunday 2024-03-10 16:10:15 +0100, Stefano Sabatini wrote: > > > On date Sunday 2024-03-10 14:20:12 +, ffmpeg-devel Mailing

Re: [FFmpeg-devel] [PATCH] doc/muxers: add ffmetadata

2024-03-12 Thread Gyan Doshi
On 2024-03-12 04:25 pm, Stefano Sabatini wrote: --- doc/metadata.texi | 1 + doc/muxers.texi | 16 2 files changed, 17 insertions(+) diff --git a/doc/metadata.texi b/doc/metadata.texi index be91059a98..e081da7735 100644 --- a/doc/metadata.texi +++ b/doc/metadata.texi

Re: [FFmpeg-devel] [PATCH v3 1/6] avcodec/mpeg12dec: extract only one type of CC substream

2024-03-12 Thread Stefano Sabatini
On date Tuesday 2024-03-12 01:00:00 -0500, Marth64 wrote: > In MPEG-2 user data, there can be different types of Closed Captions > formats embedded (A53, SCTE-20, or DVD). The current behavior of the > CC extraction code in the MPEG-2 decoder is to not be aware of > multiple formats if multiple

[FFmpeg-devel] [PATCH 3/3] doc/muxers: add fifo_test

2024-03-12 Thread Stefano Sabatini
--- doc/muxers.texi | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0aaef2b520..ccbb741992 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1556,6 +1556,36 @@ ffmpeg -re -i ... -c:v libx264 -c:a aac -f fifo

[FFmpeg-devel] [PATCH 2/3] lavf/fifo_test: use FifoTest in place of Failing

2024-03-12 Thread Stefano Sabatini
Use a more consistent and sensible prefix for the muxer structs and functions. --- libavformat/fifo_test.c | 45 - 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/libavformat/fifo_test.c b/libavformat/fifo_test.c index 84b762db5f..903f4bc34b

  1   2   >