Re: [FFmpeg-devel] [PATCH] ffprobe: move abort() call to after the print statements

On Wed, Oct 28, 2015 at 5:14 AM, Michael Niedermayer wrote: > On Wed, Oct 28, 2015 at 09:55:56AM +0100, wm4 wrote: >> On Tue, 27 Oct 2015 20:21:11 -0400 >> Ganesh Ajjanagadde wrote: >> >> > This fixes warning C4702 "unreachable code" reported in

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

Hi, On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde wrote: > On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, Oct 27, 2015 at 8:53 PM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> ISO C

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_warn_unused_result

On Wed, Oct 28, 2015 at 3:41 AM, Hendrik Leppkes wrote: > On Wed, Oct 28, 2015 at 4:17 AM, Ganesh Ajjanagadde > wrote: >> On Thu, Oct 15, 2015 at 6:05 PM, Ganesh Ajjanagadde >> wrote: >>> Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde > wrote: >> >> On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, Oct 27,

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

On Wed, Oct 28, 2015 at 02:57:14AM +0100, Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 11:15:29PM +0100, Matthieu Bouron wrote: > > On Sun, Oct 18, 2015 at 11:06:50AM +0200, Matthieu Bouron wrote: > > [...] > > > > > > Patch updated, the markers are now properly skipped (which also fixes

Re: [FFmpeg-devel] PATCH: gdigrab work for DPI in windows

On 5 October 2015 at 20:05, Matt Oliver wrote: > On 5 October 2015 at 19:29, Matt Oliver wrote: > >> On 30 September 2015 at 02:48, wm4 wrote: >> >>> On Wed, 23 Sep 2015 12:04:43 -0600 >>> Roger Pack

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

ping 2015.10.18. 14:06 keltezéssel, Bodecs Bela írta: Dear Marton Balint, see may comments below. 2015.10.18. 1:10 keltezéssel, Marton Balint írta: On Thu, 15 Oct 2015, Bodecs Bela wrote: [...] My enhancement does not alter the current behaviour in any way. Are you sure? What if

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pngdec: honor skip_frame option

On Mon, Oct 19, 2015 at 10:28:18AM +0200, Matthieu Bouron wrote: > On Sat, Oct 17, 2015 at 10:34:22PM +0200, Matthieu Bouron wrote: > > From: Matthieu Bouron > > > > --- > > libavcodec/pngdec.c | 34 ++ > > 1 file changed, 34

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

On Wed, Oct 28, 2015 at 02:57:14AM +0100, Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 11:15:29PM +0100, Matthieu Bouron wrote: > > On Sun, Oct 18, 2015 at 11:06:50AM +0200, Matthieu Bouron wrote: > > [...] > > > > > > Patch updated, the markers are now properly skipped (which also fixes

Re: [FFmpeg-devel] [PATCH 1/8] lavu/aes: test CBC functionality

On Wed, Oct 28, 2015 at 05:39:32AM -0500, Rodger Combs wrote: > --- > libavutil/aes.c | 19 ++- > 1 file changed, 14 insertions(+), 5 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The educated differ from the uneducated

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

On Tue, Oct 27, 2015 at 8:18 PM, Ganesh Ajjanagadde wrote: > av_gcd is now always defined regardless of input. This documents this > change in the "documented API". Two benefits (closely related): > 1. The function is robust, and there is no need to worry about INT64_MIN,

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

On Wed, Oct 28, 2015 at 12:58:53PM +0100, Michael Niedermayer wrote: > On Wed, Oct 28, 2015 at 02:57:14AM +0100, Michael Niedermayer wrote: > > On Tue, Oct 27, 2015 at 11:15:29PM +0100, Matthieu Bouron wrote: > > > On Sun, Oct 18, 2015 at 11:06:50AM +0200, Matthieu Bouron wrote: > > > [...] > > >

Re: [FFmpeg-devel] [PATCH 4/8] tools/crypto_bench: add AES-192 and AES-256

On Wed, Oct 28, 2015 at 05:39:35AM -0500, Rodger Combs wrote: > --- > tools/crypto_bench.c | 82 > > 1 file changed, 82 insertions(+) > > diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c > index b3b24a6..ad20f95 100644 > ---

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, Oct 27,

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pngdec: honor skip_frame option

On Wed, Oct 28, 2015 at 12:59:54PM +0100, Michael Niedermayer wrote: > On Mon, Oct 19, 2015 at 10:28:18AM +0200, Matthieu Bouron wrote: > > On Sat, Oct 17, 2015 at 10:34:22PM +0200, Matthieu Bouron wrote: > > > From: Matthieu Bouron > > > > > > --- > > >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

Hi, On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> On

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_warn_unused_result

On Wed, Oct 28, 2015 at 4:17 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 6:05 PM, Ganesh Ajjanagadde > wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavutil/avstring.h | 2 ++ >> 1 file changed, 2

[FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

--- libavcodec/nvenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0e6ef43..083e494 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -912,6 +912,11 @@ static av_cold int nvenc_encode_init(AVCodecContext

[FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

--- libavcodec/nvenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0e6ef43..083e494 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -912,6 +912,11 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx)

Re: [FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

在 2015/10/28 14:53, Agatha Hu 写道: --- libavcodec/nvenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0e6ef43..083e494 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -912,6 +912,11 @@ static av_cold int

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

On 26 October 2015 at 04:46, James Almer wrote: > On 10/25/2015 1:39 PM, Matt Oliver wrote: > > On 26 October 2015 at 00:43, Hendrik Leppkes > wrote: > > > >> On Sun, Oct 25, 2015 at 12:30 PM, Matt Oliver > >> wrote: > >>> On 25

[FFmpeg-devel] [PATCH] avformat: add 3dostr demuxer

Signed-off-by: Paul B Mahol --- libavformat/3dostr.c | 169 +++ libavformat/Makefile | 1 + libavformat/allformats.c | 1 + 3 files changed, 171 insertions(+) create mode 100644 libavformat/3dostr.c diff --git

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

On Wed, 28 Oct 2015 01:06:38 +0100 Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 10:14:49AM +0100, wm4 wrote: > > On Mon, 26 Oct 2015 13:15:39 -0700 > > Dale Curtis wrote: > > > > > On Sun, Oct 25, 2015 at 4:56 AM, Ronald S. Bultje

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

On Sun, Oct 18, 2015 at 02:06:12PM +0200, Bodecs Bela wrote: > Dear Marton Balint, > > see may comments below. > > 2015.10.18. 1:10 keltezéssel, Marton Balint írta: > > > >On Thu, 15 Oct 2015, Bodecs Bela wrote: > > > >[...] > > > My enhancement does not alter the current behaviour in any

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Wed, Oct 28, 2015 at 10:34:37AM -0400, Ronald S. Bultje wrote: [...] > You could do the same for the last 4 values of the cinething changes, they > are clearly not enums, but flags. Flags are always unsigned, so if enums > are unsigned and that causes an issue (as it does here), it makes sense

Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

On Wed, Oct 21, 2015 at 1:52 PM, Hendrik Leppkes wrote: > This implementation does not support TLS listen sockets and loading > CA/Certs from files. > > The Windows API does not support loading PEM certs, and would either > require a manual loader or instead be limited to

Re: [FFmpeg-devel] [PATCH 3/3] WIP: lavf/utils: try to avoid decoding a frame to get the codec parameters

On Sat, Oct 17, 2015 at 10:34:24PM +0200, Matthieu Bouron wrote: > From: Matthieu Bouron > > Avoid decoding twice images such as jpeg and png, once in the > avformat_find_stream_info and once when the actual decode is made. > > The decoder must honor the

[FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

--- libavcodec/vp9_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c index 0437097..6713850 100644 --- a/libavcodec/vp9_parser.c +++ b/libavcodec/vp9_parser.c @@ -64,7 +64,7 @@ static int parse_frame(AVCodecParserContext

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

On Wed, Oct 28, 2015 at 03:10:00PM +0100, Matthieu Bouron wrote: > On Wed, Oct 28, 2015 at 12:58:53PM +0100, Michael Niedermayer wrote: > > On Wed, Oct 28, 2015 at 02:57:14AM +0100, Michael Niedermayer wrote: > > > On Tue, Oct 27, 2015 at 11:15:29PM +0100, Matthieu Bouron wrote: > > > > On Sun,

Re: [FFmpeg-devel] [PATCH 3/3] WIP: lavf/utils: try to avoid decoding a frame to get the codec parameters

Hi, On Sat, Oct 17, 2015 at 4:34 PM, Matthieu Bouron wrote: > From: Matthieu Bouron > > Avoid decoding twice images such as jpeg and png, once in the > avformat_find_stream_info and once when the actual decode is made. > > The decoder

Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

On Wed, Oct 28, 2015 at 6:07 PM, Derek Buitenhuis wrote: > Enjoy my half-assed / useless review. > >> +#ifndef SECBUFFER_ALERT >> +#define SECBUFFER_ALERT17 >> +#endif > > Why? I think it was needed on some configuration, I'll verify. > >> +

Re: [FFmpeg-devel] [PATCH 3/3] WIP: lavf/utils: try to avoid decoding a frame to get the codec parameters

On Sat, Oct 17, 2015 at 10:34 PM, Matthieu Bouron wrote: > From: Matthieu Bouron > > Avoid decoding twice images such as jpeg and png, once in the > avformat_find_stream_info and once when the actual decode is made. > > The decoder must

[FFmpeg-devel] [PATCH] avfilter/asrc_sine: fix options typos

Signed-off-by: Kyle Swanson --- libavfilter/asrc_sine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/asrc_sine.c b/libavfilter/asrc_sine.c index f361faa..2a2f3c3 100644 --- a/libavfilter/asrc_sine.c +++ b/libavfilter/asrc_sine.c @@ -69,8 +69,8

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28,

Re: [FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

On Wed, 28 Oct 2015 14:53:42 +0800 Agatha Hu wrote: > --- > libavcodec/nvenc.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index 0e6ef43..083e494 100644 > --- a/libavcodec/nvenc.c > +++

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Wed, Oct 28, 2015 at 11:33 AM, Hendrik Leppkes wrote: > On Wed, Oct 28, 2015 at 4:00 PM, Ganesh Ajjanagadde > wrote: >> On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje >> wrote: >>> Hi, >>> >>> On Wed, Oct 28, 2015 at 10:48

Re: [FFmpeg-devel] [PATCH] avfilter/asrc_sine: fix options typos

Le septidi 7 brumaire, an CCXXIV, Kyle Swanson a écrit : > Signed-off-by: Kyle Swanson > --- > libavfilter/asrc_sine.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Of course ok, thanks. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Wed, Oct 28, 2015 at 11:44 AM, Clément Bœsch wrote: > On Wed, Oct 28, 2015 at 10:34:37AM -0400, Ronald S. Bultje wrote: > [...] >> You could do the same for the last 4 values of the cinething changes, they >> are clearly not enums, but flags. Flags are always unsigned, so if enums

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

Hi, On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde > > wrote: > >> > >> On Wed,

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28,

Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

Enjoy my half-assed / useless review. > +#ifndef SECBUFFER_ALERT > +#define SECBUFFER_ALERT17 > +#endif Why? > +SecPkgContext_StreamSizes Sizes; Accidental capital? > +if (c->enc_buf == NULL) { > +c->enc_buf_offset = 0; > +c->enc_buf_size =

Re: [FFmpeg-devel] [PATCH 3/3] WIP: lavf/utils: try to avoid decoding a frame to get the codec parameters

On Wed, 28 Oct 2015 13:30:59 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Sat, Oct 17, 2015 at 4:34 PM, Matthieu Bouron > wrote: > > > From: Matthieu Bouron > > > > Avoid decoding twice images such as jpeg and png,

Re: [FFmpeg-devel] [PATCH] swr: do not reject channel layouts that use channel 63

On Mon, 26 Oct 2015 20:31:00 +0100 Michael Niedermayer wrote: > On Sun, Oct 25, 2015 at 06:31:02PM +0100, wm4 wrote: > > Channel layouts are essentially uint64_t, and every value is valid. > > --- > > libswresample/options.c | 8 > > 1 file changed, 4

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

Hi, On Wed, Oct 28, 2015 at 2:46 PM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> On Wed,

Re: [FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

On Wed, 28 Oct 2015 12:21:05 -0400 "Ronald S. Bultje" wrote: > --- > libavcodec/vp9_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c > index 0437097..6713850 100644 > ---

Re: [FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

Hi, On Wed, Oct 28, 2015 at 3:44 PM, wm4 wrote: > On Wed, 28 Oct 2015 12:21:05 -0400 > "Ronald S. Bultje" wrote: > > > --- > > libavcodec/vp9_parser.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] avfilter/asrc_sine: fix options typos

On Wed, Oct 28, 2015 at 07:10:24PM +0100, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXIV, Kyle Swanson a écrit : > > Signed-off-by: Kyle Swanson > > --- > > libavfilter/asrc_sine.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Of course ok, thanks.

Re: [FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

Hi, On Wed, Oct 28, 2015 at 5:51 PM, wm4 wrote: > On Wed, 28 Oct 2015 16:05:49 -0400 > "Ronald S. Bultje" wrote: > > > Hi, > > > > On Wed, Oct 28, 2015 at 3:44 PM, wm4 wrote: > > > > > On Wed, 28 Oct 2015 12:21:05 -0400 > > >

Re: [FFmpeg-devel] [PATCH] avutil/opt: add av_warn_unused_result

On Thu, Oct 15, 2015 at 6:12 PM, Ganesh Ajjanagadde wrote: > Some warnings do get triggered that will need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/opt.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] avutil/opencl: add av_warn_unused_result

On Fri, Oct 16, 2015 at 8:02 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 11:17 PM, highgod0401 wrote: >> >> From: Ganesh Ajjanagadde >> Date: 2015-10-16 08:08 >> To: ffmpeg-devel >> CC: Ganesh Ajjanagadde >> Subject: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH 03/11] avdevice/sndio: add av_warn_unused_result

On Fri, Oct 16, 2015 at 5:31 PM, Ganesh Ajjanagadde wrote: > On Fri, Oct 16, 2015 at 11:46 AM, Michael Niedermayer > wrote: >> On Thu, Oct 15, 2015 at 10:22:17PM -0400, Ganesh Ajjanagadde wrote: >>> This does not trigger any warnings, but adds

[FFmpeg-devel] [PATCH 02/11] avcodec/nellymoserenc: use log2 instead of log()/M_LN2

This is likely more precise and conveys the intent better. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/nellymoserenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nellymoserenc.c b/libavcodec/nellymoserenc.c index d7368d0..d998dba

Re: [FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

On 10/28/2015 11:16 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 5:51 PM, wm4 wrote: > >> On Wed, 28 Oct 2015 16:05:49 -0400 >> "Ronald S. Bultje" wrote: >> >>> Hi, >>> >>> On Wed, Oct 28, 2015 at 3:44 PM, wm4

Re: [FFmpeg-devel] [PATCH] avdevice/dshow_enummediatypes: check return of av_malloc

On Tue, Oct 27, 2015 at 08:09:03PM -0400, Ganesh Ajjanagadde wrote: > Untested. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavdevice/dshow_enummediatypes.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavdevice/dshow_enummediatypes.c >

Re: [FFmpeg-devel] [PATCH] avfilter/tremolo: fix wavetable buffer size

This fixes an obvious bug for sub 1-hz modulation frequencies. Wavetable buffer was too small for frequencies under 1 hz, and also too big for frequencies above 1hz. One cycle is all we need. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCHv2] avutil/buffer: add av_warn_unused_result

On Thu, Oct 15, 2015 at 7:10 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/buffer.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavutil/buffer.h b/libavutil/buffer.h > index b4399fd..e0dbc8a

Re: [FFmpeg-devel] [PATCH 1/2] swresample/swresample: add av_warn_unused_result

On Thu, Oct 15, 2015 at 9:31 PM, Ganesh Ajjanagadde wrote: > This will trigger a few warnings (e.g in avfilter) that need to be > fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libswresample/swresample.h | 9 + > 1 file changed, 9

Re: [FFmpeg-devel] [PATCHv2] avcodec/dvenc: silence -Wdiscarded-qualifiers

On Sun, Oct 4, 2015 at 8:44 PM, Ganesh Ajjanagadde wrote: > On Sun, Sep 20, 2015 at 9:09 AM, Ganesh Ajjanagadde > wrote: >> s->frame is non-const, so this casts them explicitly. >> This suppresses -Wdiscarded-qualifiers seen in e.g >>

[FFmpeg-devel] [PATCH 04/11] avcodec/zmbvenc: use log2 instead of log()/M_LN2

This is likely more precise and conveys the intent better. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/zmbvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/zmbvenc.c b/libavcodec/zmbvenc.c index df06e37..e832bed 100644 ---

[FFmpeg-devel] [PATCH 03/11] avcodec/snowenc: use log2 instead of log() / log(2...)

This is likely more precise and conveys the intent better. The expression has also been accordingly simplified. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/snowenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/snowenc.c

[FFmpeg-devel] [PATCH 10/11] avfilter/vf_ssim: use log10 instead of log()/log(10)

This is likely more precise and conveys the intent better. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_ssim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_ssim.c b/libavfilter/vf_ssim.c index ce1e3db..6b2a8d7 100644 ---

[FFmpeg-devel] [PATCH 08/11] avfilter/avf_showvolume: use log10 instead of log()/M_LN10

This is likely more precise and conveys the intent better. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/avf_showvolume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avf_showvolume.c b/libavfilter/avf_showvolume.c index

[FFmpeg-devel] [PATCH 09/11] avfilter/vf_psnr: use log10 instead of log()/log(10)

This is likely more precise and conveys the intent better. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_psnr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c index 36bbab2..bce5c51 100644 ---

Re: [FFmpeg-devel] [PATCH] avutil/ripemd: make rol macro more robust by adding parentheses

On Wed, Oct 28, 2015 at 11:52 AM, James Almer wrote: > On 10/27/2015 9:00 PM, Ganesh Ajjanagadde wrote: >> This ensures that the macro remains correct in the sense of allowing >> expressions for value and bits, by placing the value and bits expressions >> within >>

Re: [FFmpeg-devel] [PATCH] avutil/frame: add av_warn_unused_result

On Thu, Oct 15, 2015 at 7:47 PM, Ganesh Ajjanagadde wrote: > This is going to trigger a lot of warnings all over the place that need > fixing. Main culprits are in avfilter, when one tries to copy a frame > without checking whether src and dest formats actually are

Re: [FFmpeg-devel] [PATCH] avutil/opencl_internal: add av_warn_unused_result

On Thu, Oct 15, 2015 at 6:24 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/opencl_internal.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/opencl_internal.h b/libavutil/opencl_internal.h >

Re: [FFmpeg-devel] [PATCH] avutil/audio_fifo: add av_warn_unused_result

On Fri, Oct 16, 2015 at 5:16 PM, Ganesh Ajjanagadde wrote: > On Fri, Oct 16, 2015 at 11:44 AM, Michael Niedermayer > wrote: >> On Thu, Oct 15, 2015 at 07:26:04PM -0400, Ganesh Ajjanagadde wrote: >>> This one should not trigger any warnings, but will be

[FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

This is more concise and conveys the intent better. Furthermore, it is likely more precise as well due to lack of floating point division. Signed-off-by: Ganesh Ajjanagadde --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg.c

[FFmpeg-devel] [PATCH 07/11] avfilter/avf_showspectrum: use log10 instead of log()/...

This is likely more precise and conveys the intent better. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/avf_showspectrum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index

[FFmpeg-devel] [PATCH 06/11] avfilter/af_volumedetect: use log10 instead of hardcoded constant

This is likely more precise and conveys the intent better. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_volumedetect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index

[FFmpeg-devel] Idea for a better filter that reduces noise

You all know the CSI episodes where they read a license plate by "enhancing" some super-grainy security footage. Nonsense, right? Well, maybe not.. If the car was parked. And it seems what I found doesn't exist yet. (but perhaps I overlooked it) If you quickly want to know what I'm on about,

Re: [FFmpeg-devel] [PATCH] avdevice/dshow_enummediatypes: check return of av_malloc

On Wed, Oct 28, 2015 at 10:00 PM, Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 08:09:03PM -0400, Ganesh Ajjanagadde wrote: >> Untested. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavdevice/dshow_enummediatypes.c | 2 ++ >> 1 file

[FFmpeg-devel] [PATCH] avutil/mathematics: make av_gcd more robust

This ensures that no undefined behavior is invoked, while retaining identical return values in all cases and at no loss of performance (identical asm on clang and gcc). Essentially, this patch exchanges undefined behavior with implementation defined behavior, a strict improvement. Rationale: 1.

Re: [FFmpeg-devel] [PATCH 1/2] swscale/swscale_internal: add av_warn_unused_result

On Thu, Oct 15, 2015 at 9:46 PM, Ganesh Ajjanagadde wrote: > This triggers a few warnings that need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libswscale/swscale_internal.h | 8 > 1 file changed, 8 insertions(+) > > diff

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

On Thu, Oct 15, 2015 at 10:24 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 10:22 PM, Ganesh Ajjanagadde wrote: >> On Thu, Oct 15, 2015 at 10:16 PM, James Almer wrote: >>> On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote: On

Re: [FFmpeg-devel] [PATCH] avutil/pixdesc: add av_warn_unused_result to av_pix_fmt_get_chroma_sub_sample

On Fri, Oct 16, 2015 at 5:17 PM, Ganesh Ajjanagadde wrote: > On Fri, Oct 16, 2015 at 11:39 AM, Michael Niedermayer > wrote: >> On Thu, Oct 15, 2015 at 07:20:30PM -0400, Ganesh Ajjanagadde wrote: >>> This will trigger a bunch of warnings (rightfully so).

[FFmpeg-devel] [PATCH 05/11] avfilter/af_volume: use log10 instead of log()/M_LN10

This is likely more precise and conveys the intent better. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_volume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c index 16e994c..3ba356a 100644

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: rewrite showcqt and add features

On 10/27/2015 9:56 PM, Michael Niedermayer wrote: > On Mon, Oct 26, 2015 at 12:32:58AM +0700, Muhammad Faiz wrote: >> On Sun, Oct 25, 2015 at 9:51 AM, Michael Niedermayer >> wrote: >>> On Sun, Oct 25, 2015 at 08:43:07AM +0700, Muhammad Faiz wrote: doc/filters.texi

Re: [FFmpeg-devel] [PATCH] avcodec/motion_est_template: replace qsort with AV_QSORT

On Wed, Oct 28, 2015 at 10:00 AM, Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 10:51:29PM -0400, Ganesh Ajjanagadde wrote: >> This code is in a performance critical section. AV_QSORT is >> substantially faster due to the inlining of the comparison callback. >>

[FFmpeg-devel] [PATCH] avfilter/tremolo: fix wavetable buffer size

Signed-off-by: Kyle Swanson --- libavfilter/af_tremolo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_tremolo.c b/libavfilter/af_tremolo.c index 50df2e4..572e9e3 100644 --- a/libavfilter/af_tremolo.c +++ b/libavfilter/af_tremolo.c @@ -72,7

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

On Wed, Oct 28, 2015 at 10:09 AM, Ganesh Ajjanagadde wrote: > On Tue, Oct 27, 2015 at 8:18 PM, Ganesh Ajjanagadde > wrote: >> av_gcd is now always defined regardless of input. This documents this >> change in the "documented API". Two benefits

Re: [FFmpeg-devel] [PATCH] avutil/samplefmt: add av_warn_unused_result

On Thu, Oct 15, 2015 at 6:31 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/samplefmt.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/samplefmt.h b/libavutil/samplefmt.h > index

Re: [FFmpeg-devel] [PATCH] avutil/wchar_filename: add av_warn_unused_result

On Wed, Oct 21, 2015 at 11:46 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:01 PM, Ganesh Ajjanagadde > wrote: >> Current code is fine, this just adds robustness. >> >> Signed-off-by: Ganesh Ajjanagadde >> ---

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Wed, Oct 28, 2015 at 07:02:42PM -0400, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 3:05 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 2:46 PM, Ganesh Ajjanagadde > > wrote: > >> > >> On Wed, Oct 28, 2015 at 2:39 PM,

[FFmpeg-devel] [PATCH 11/11] avutil/rational: use frexp rather than ad-hoc log to get floating point exponent

This simplifies and cleans up the code. Furthermore, it is much faster due to absence of the slow log computation. Signed-off-by: Ganesh Ajjanagadde --- libavutil/rational.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/rational.c

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

On Sun, Oct 25, 2015 at 4:56 AM, Ronald S. Bultje wrote: > > So this is likely because we init all tables instead of just these that we > need, right? So how about having one ff_once per table? That should be > trivial to implement. Just so we're all on the same page, this

Re: [FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

> --- > libavcodec/nvenc.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index 0e6ef43..083e494 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -912,6 +912,11 @@ static av_cold int

[FFmpeg-devel] [PATCH 2/2] avformat: add DC STR demuxer

Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/dcstr.c | 79 3 files changed, 81 insertions(+) create mode 100644 libavformat/dcstr.c diff --git

Re: [FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

On Wed, Oct 28, 2015 at 11:52:50AM -0700, Philip Langdale wrote: > On Wed, 28 Oct 2015 14:53:42 +0800 > Agatha Hu wrote: > > > --- > > libavcodec/nvenc.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/nvenc.c

Re: [FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

On Wed, 28 Oct 2015 16:05:49 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Wed, Oct 28, 2015 at 3:44 PM, wm4 wrote: > > > On Wed, 28 Oct 2015 12:21:05 -0400 > > "Ronald S. Bultje" wrote: > > > > > --- > > >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Wed, Oct 28, 2015 at 3:05 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 2:46 PM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28,

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

On Sun, 18 Oct 2015, Bodecs Bela wrote: [...] It can be anything if it does not change existing behaviour, a complex specifier can be split to basic specifiers without worrying about the syntax of the basic specifier and if there is a well defined rule for escaping special characters. Also

Re: [FFmpeg-devel] [PATCH] ffprobe: move abort() call to after the print statements

On Tue, 27 Oct 2015 20:21:11 -0400 Ganesh Ajjanagadde wrote: > This fixes warning C4702 "unreachable code" reported in MSVC: > http://fate.ffmpeg.org/log.cgi?time=20151026165907=compile=x86_64-msvc12-windows-native, > and also likely fixes the intended behavior. > >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Tue, 27 Oct 2015 20:53:39 -0400 Ganesh Ajjanagadde wrote: > ISO C restricts enumerator values to the range of int. Thus (for instance) > 0x8000 > unfortunately does not work, and throws a warning with -Wpedantic on > clang 3.7. > > This fixes it by using

Re: [FFmpeg-devel] [PATCH] ffprobe: move abort() call to after the print statements

On Wed, Oct 28, 2015 at 09:55:56AM +0100, wm4 wrote: > On Tue, 27 Oct 2015 20:21:11 -0400 > Ganesh Ajjanagadde wrote: > > > This fixes warning C4702 "unreachable code" reported in MSVC: > >

[FFmpeg-devel] [PATCH 1/8] lavu/aes: test CBC functionality

--- libavutil/aes.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/libavutil/aes.c b/libavutil/aes.c index dde15be..9096f03 100644 --- a/libavutil/aes.c +++ b/libavutil/aes.c @@ -280,7 +280,7 @@ int main(int argc, char **argv) { 0x10, 0xa5, 0x88,

[FFmpeg-devel] [PATCH 2/8] lavu/aes: add x86 AESNI optimizations

crypto_bench comparison for AES-128-ECB: lavu_aesni AES-128-ECB size: 1048576 runs: 1024 time:0.596 +- 0.081 lavu_c AES-128-ECB size: 1048576 runs: 1024 time: 17.007 +- 2.131 crypto AES-128-ECB size: 1048576 runs: 1024 time:0.612 +- 1.857 gcrypt AES-128-ECB

[FFmpeg-devel] [PATCH 3/8] checkasm: add tests for AES

--- tests/checkasm/Makefile | 2 +- tests/checkasm/aes.c | 64 +++ tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + 4 files changed, 67 insertions(+), 1 deletion(-) create mode 100644 tests/checkasm/aes.c diff --git

[FFmpeg-devel] [PATCH 5/8] tools/crypto_bench: add AES-CBC modes

--- tools/crypto_bench.c | 140 +-- 1 file changed, 137 insertions(+), 3 deletions(-) diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c index ad20f95..15bb5f1 100644 --- a/tools/crypto_bench.c +++ b/tools/crypto_bench.c @@ -52,6 +52,7 @@

[FFmpeg-devel] [PATCH 6/8] tools/crypto_bench: switch to OpenSSL's faster AES API

--- tools/crypto_bench.c | 85 +--- 1 file changed, 47 insertions(+), 38 deletions(-) diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c index 15bb5f1..8a468ba 100644 --- a/tools/crypto_bench.c +++ b/tools/crypto_bench.c @@ -244,6 +244,7 @@

  1   2   >