Re: [FFmpeg-devel] [PATCH] configure: only check dispatch header on darwin

On Thu, Feb 25, 2016 at 09:41:11PM +0100, Matthieu Bouron wrote: > On Thu, Feb 25, 2016 at 04:09:34PM +, Josh de Kock wrote: > > On 25/02/2016 15:53, Nicolas George wrote: > > >Le septidi 7 ventôse, an CCXXIV, Josh de Kock a écrit : > > >>Just thought it wouldn't hurt to fix the real

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Skip SOF size when probing jpeg

Michael Niedermayer niedermayer.cc> writes: > > case 0xC1: > > case 0xC2: > > case 0xC3: > > +i += AV_RB16([i + 2]) + 1; > > case 0xC5: > > case 0xC6: > > case 0xC7: > > shouldnt this also be done for these 3? Done, I used the

Re: [FFmpeg-devel] [PATCH] submit_thread should also lock the mutex that guards the source avctx (prev_thread->avctx) when calling update_context_from_thread.

Hi, On Thu, Feb 25, 2016 at 9:32 PM, Wan-Teh Chang wrote: > This is because the codec->decode() call in frame_worker_thread may be > modifying that avctx at the same time. This data race is reported by > ThreadSanitizer. > > Although submit_thread holds two locks

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

Michael Niedermayer skrev: (26 februari 2016 22:53:00 CET) >On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: >> On 02/26/2016 05:26 AM, Mats Peterson wrote: >> >On 02/26/2016 05:08 AM, Mats Peterson wrote: >> >>Should hopefully fix the big-endian issue. >>

Re: [FFmpeg-devel] [PATCH] submit_thread should also lock the mutex that guards the source avctx (prev_thread->avctx) when calling update_context_from_thread.

On Fri, Feb 26, 2016 at 1:17 PM, Ronald S. Bultje wrote: > > I'm happy to help out if you tell me which field/member tsan is complaining > about. Hi Ronald, I am using an old version of ffmpeg. Here is the ThreadSanitizer warning on the data race and the relevant source code

Re: [FFmpeg-devel] [PATCH] Read |state| under the protection of |mutex| or |progress_mutex|.

Hi, On Thu, Feb 25, 2016 at 9:18 PM, Wan-Teh Chang wrote: > Although not documented, |state| is guarded by either |mutex| or > |progress_mutex|. In several places |state| is read without mutex > protection, often as a double-checked locking style performance >

[FFmpeg-devel] [PATCH 2/2] sws/yuv2rgb: clarify precision of coeff and offset for mmx code

It makes easier looking at the difference with the generic code just below. --- libswscale/yuv2rgb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index 9d79d79..62abb7d 100644 --- a/libswscale/yuv2rgb.c +++

[FFmpeg-devel] [PATCH 1/2] sws/yuv2rgb: avoid a few ub on signed left shifts

--- libswscale/yuv2rgb.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index 3671fe3..9d79d79 100644 --- a/libswscale/yuv2rgb.c +++ b/libswscale/yuv2rgb.c @@ -824,18 +824,18 @@ av_cold int

Re: [FFmpeg-devel] [PATCH] Document and validate AVFrame plane pointers.

On Fri, 26 Feb 2016 22:25:21 +0100 Reimar Döffinger wrote: > Check that the required plane pointers and only > those are set up. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/utils.c | 14 ++ > libavutil/frame.h | 3

Re: [FFmpeg-devel] [PATCH 1/6] Kill timed SSA

On Sun, Feb 21, 2016 at 01:08:28PM +0100, Clément Bœsch wrote: > --- > libavcodec/Makefile | 4 ++-- > libavcodec/assdec.c | 60 > +++- > libavcodec/assenc.c | 14 ++-- > libavformat/assenc.c | 14 > libavformat/nut.c|

[FFmpeg-devel] [PATCH] Document and validate AVFrame plane pointers.

Check that the required plane pointers and only those are set up. Signed-off-by: Reimar Döffinger --- libavcodec/utils.c | 14 ++ libavutil/frame.h | 3 +++ 2 files changed, 17 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index

Re: [FFmpeg-devel] [PATCH] vp9: add superframe merging bitstream filter.

Hi, On Tue, Feb 23, 2016 at 7:55 AM, Ronald S. Bultje wrote: > Fixes ticket 4313. > --- > ffmpeg.c| 3 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/vp9_superframe_bsf.c | 189 >

Re: [FFmpeg-devel] [PATCH] Move the |die| member of FrameThreadContext to PerThreadContext.

Hi, On Thu, Feb 25, 2016 at 8:26 PM, Wan-Teh Chang wrote: > On Thu, Feb 25, 2016 at 12:00 PM, Ronald S. Bultje > wrote: > If anything, you can use atomic ints instead of regular ints if we don't > > already [1]. > > > [...] > > [1]

Re: [FFmpeg-devel] [PATCH] Always read frame progress values under progress_mutex.

On Thu, Feb 25, 2016 at 08:59:39PM -0800, Wan-Teh Chang wrote: > On Thu, Feb 25, 2016 at 8:14 PM, Michael Niedermayer > wrote: > > > > also considering this is performance relevant code, please provide > > a benchmark > > I'll be happy to provide a benchmark. I don't see

Re: [FFmpeg-devel] [PATCH] avutil/md5: fix unaligned loads

On Wed, Feb 24, 2016 at 09:20:11AM +0100, Clément Bœsch wrote: > On Tue, Feb 23, 2016 at 10:40:08PM -0300, James Almer wrote: > [...] > > That aside, note that these runtime erros happen with every test using md5 > > and > > don't make ubsan register them as failed. In the link above something

Re: [FFmpeg-devel] [PATCH] Document and validate AVFrame plane pointers.

On Fri, Feb 26, 2016 at 10:39:41PM +0100, wm4 wrote: > On Fri, 26 Feb 2016 22:25:21 +0100 > Reimar Döffinger wrote: > > > Check that the required plane pointers and only > > those are set up. > > > > Signed-off-by: Reimar Döffinger > > --- >

Re: [FFmpeg-devel] [PATCH] submit_thread should also lock the mutex that guards the source avctx (prev_thread->avctx) when calling update_context_from_thread.

Hi, On Fri, Feb 26, 2016 at 3:26 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Feb 25, 2016 at 9:32 PM, Wan-Teh Chang < > wtc-at-google@ffmpeg.org> wrote: > >> This is because the codec->decode() call in frame_worker_thread may be >> modifying that avctx at the same

Re: [FFmpeg-devel] [PATCH 3/6] lavc/options: add ass_ro_flush_noop to flags2

On Sun, Feb 21, 2016 at 01:08:30PM +0100, Clément Bœsch wrote: > --- > libavcodec/ass.c | 3 ++- > libavcodec/avcodec.h | 4 > libavcodec/ccaption_dec.c| 3 ++- > libavcodec/libzvbi-teletextdec.c | 3 ++- > libavcodec/movtextdec.c | 3 ++- >

Re: [FFmpeg-devel] [PATCH 2/6] lavc: allow subtitle text format to be ASS without timing

On Thu, Feb 25, 2016 at 02:10:15AM +0100, Michael Niedermayer wrote: > On Wed, Feb 24, 2016 at 03:37:53PM +0100, Clément Bœsch wrote: > > On Sun, Feb 21, 2016 at 06:34:43PM +0100, Michael Niedermayer wrote: > > > On Sun, Feb 21, 2016 at 01:08:29PM +0100, Clément Bœsch wrote: > > > [...] > > > >

[FFmpeg-devel] [PATCH] Document and validate AVFrame plane pointers.

Check that the required plane pointers and only those are set up. Signed-off-by: Reimar Döffinger --- libavcodec/utils.c | 20 libavutil/frame.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c

[FFmpeg-devel] Add segment_copyts to generic file segmenter?

Hi all, this is my first message ever to the ffmpeg mailing list, so please forgive me any noob mistakes. I’m currently working on a little project which uses ffmpeg to live transcode video files for streaming to a web browser. Basically it’s like Plex just at a very early stage. For

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

Michael Niedermayer skrev: (26 februari 2016 22:56:42 CET) >On Fri, Feb 26, 2016 at 08:00:58AM +0100, Mats Peterson wrote: >> On 02/26/2016 07:41 AM, Mats Peterson wrote: >> >>Look at this snippet from libavformat/qtpalette.c that stores a >palette >> >>entry (palette[]

Re: [FFmpeg-devel] [PATCH 6/6] lavc: deprecate decoded ass subtitles with timings

On Sun, Feb 21, 2016 at 01:08:33PM +0100, Clément Bœsch wrote: > --- > libavcodec/assenc.c| 2 ++ > libavcodec/avcodec.h | 2 ++ > libavcodec/movtextenc.c| 7 ++- > libavcodec/options_table.h | 6 ++ > libavcodec/srtenc.c| 7 ++- > libavcodec/utils.c

Re: [FFmpeg-devel] [PATCH] vp9: add superframe merging bitstream filter.

On Tue, Feb 23, 2016 at 07:55:37AM -0500, Ronald S. Bultje wrote: > Fixes ticket 4313. > --- > ffmpeg.c| 3 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/vp9_superframe_bsf.c | 189 >

Re: [FFmpeg-devel] [PATCH] submit_thread should also lock the mutex that guards the source avctx (prev_thread->avctx) when calling update_context_from_thread.

On Fri, Feb 26, 2016 at 12:44 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Feb 26, 2016 at 3:26 PM, Ronald S. Bultje > wrote: > >> >> So doesn't this patch remove all concurrency by making the decode() of >> thread N-1 finish before decode() of thread N

Re: [FFmpeg-devel] [PATCH] Document and validate AVFrame plane pointers.

On Fri, Feb 26, 2016 at 06:13:04PM +, Derek Buitenhuis wrote: > On 2/26/2016 5:42 PM, Reimar Döffinger wrote: > > +av_assert0(frame->format == avctx->pix_fmt); > > Is this valid? Mid-stream colorspace changes are fairly common. I believed we enforce a sequence point (i.e. we make

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On Fri, Feb 26, 2016 at 08:00:58AM +0100, Mats Peterson wrote: > On 02/26/2016 07:41 AM, Mats Peterson wrote: > >>Look at this snippet from libavformat/qtpalette.c that stores a palette > >>entry (palette[] is uint32_t): > >> > >>palette[i] = (a << 24 ) | (r << 16) | (g << 8) | (b); > >> > >>The

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On Fri, Feb 26, 2016 at 11:21:19PM +0100, Mats Peterson wrote: > Michael Niedermayer skrev: (26 februari 2016 > 22:53:00 CET) > >On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: > >> On 02/26/2016 05:26 AM, Mats Peterson wrote: > >> >On 02/26/2016 05:08 AM,

Re: [FFmpeg-devel] [PATCH 5/6] lavfi/ass: use ass_process_chunk() instead of ass_process_data()

On Sun, Feb 21, 2016 at 01:08:32PM +0100, Clément Bœsch wrote: > --- > libavfilter/vf_subtitles.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c > index 63b22c3..9e55002 100644 > ---

Re: [FFmpeg-devel] [PATCH 4/6] ffmpeg: set sub_text_format to ass (without timing) by default

On Sun, Feb 21, 2016 at 01:08:31PM +0100, Clément Bœsch wrote: > --- > ffmpeg.c | 2 ++ > tests/ref/fate/sub-charenc | 2 +- > tests/ref/fate/sub-textenc | 66 > ++-- > tests/ref/fate/sub-webvttenc | 66 >

Re: [FFmpeg-devel] [PATCH] Always read frame progress values under progress_mutex.

Hi, On Fri, Feb 26, 2016 at 5:30 AM, wm4 wrote: > I don't know about this case, but the frame threading code uses > improper double-checked logging. Basically it doesn't use proper > barrier or atomics, assumes x86 semantics, and hopes the compiler won't > get into the

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: > On 02/26/2016 05:26 AM, Mats Peterson wrote: > >On 02/26/2016 05:08 AM, Mats Peterson wrote: > >>Should hopefully fix the big-endian issue. > >> > > > >Not that I understand why. I thought the palette was already in > >"big-endian"

Re: [FFmpeg-devel] [PATCH] lavf/mux: do not fail in case of non monotonically increasing DTS values for data packets

On date Friday 2016-02-26 01:52:47 +0100, Michael Niedermayer encoded: > On Thu, Feb 25, 2016 at 07:02:31PM +0100, Stefano Sabatini wrote: [...] > > From 0996189555f4a2402b396801da318b4ffcfb1a13 Mon Sep 17 00:00:00 2001 > > From: Stefano Sabatini > > Date: Thu, 17 Dec 2015

Re: [FFmpeg-devel] [PATCH] mss2: Fix buffer overflow.

On Thu, 25 Feb 2016 22:39:51 +0100 Reimar Döffinger wrote: > On Thu, Feb 25, 2016 at 09:25:08PM +0100, wm4 wrote: > > On Thu, 25 Feb 2016 21:06:46 +0100 > > Reimar Döffinger wrote: > > > > > Reported as https://trac.mplayerhq.hu/ticket/2264

Re: [FFmpeg-devel] [PATCH] Always read frame progress values under progress_mutex.

On Fri, 26 Feb 2016 05:14:47 +0100 Michael Niedermayer wrote: > On Thu, Feb 25, 2016 at 04:42:22PM -0800, Wan-Teh Chang wrote: > > On Thu, Feb 25, 2016 at 4:15 PM, Hendrik Leppkes > > wrote: > > > > > > Similar to the other patch, please explain

Re: [FFmpeg-devel] New filter: remap?

On 2/26/16, Thilo Borgmann wrote: > Am 25.02.16 um 22:24 schrieb F.Sluiter: >> If it doesn exist I would like to develop a new filter and would like to >> check if nobody is already working on it or that it exists under a >> different name. >> >> I have been researching

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On Fri, Feb 26, 2016 at 11:35 AM, Reimar Döffinger wrote: > On 26.02.2016, at 02:38, Michael Niedermayer wrote: > >> On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar Döffinger wrote: >>> We do neither document nor check such a requirement >>> and

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On 26.02.2016, at 11:42, Hendrik Leppkes wrote: > On Fri, Feb 26, 2016 at 11:35 AM, Reimar Döffinger > wrote: >> On 26.02.2016, at 02:38, Michael Niedermayer wrote: >> >>> On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar

Re: [FFmpeg-devel] [PATCH] IFF ANIM support

Hi, > > And check also this: > > > > http://www.randelshofer.ch/animapplet/ > > > > public class ANIMDeltaFrame > > extends ANIMFrame { > > > > private int leftBound, topBound, rightBound, bottomBound; > > private final static int // > > ENCODING_BYTE_VERTICAL = 5, > > ENCODING_VERTICAL_7_SHORT =

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On Fri, 26 Feb 2016 12:19:18 +0100 Reimar Döffinger wrote: > On 26.02.2016, at 11:42, Hendrik Leppkes wrote: > > > On Fri, Feb 26, 2016 at 11:35 AM, Reimar Döffinger > > wrote: > >> On 26.02.2016, at 02:38, Michael

[FFmpeg-devel] [PATCH 1/2] avcodec/utils: Check all data[] pointers in video_get_buffer() not just the first

Signed-off-by: Michael Niedermayer --- libavcodec/utils.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index af21cdd..f8dee50 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -656,8 +656,8 @@

[FFmpeg-devel] [PATCH 2/2] avcodec/utils: Check that the video data[] arrays are NULL on the input to get_buffer_internal()

This should return an error to the decoder if the struct it tried to getbuffer is dirty Signed-off-by: Michael Niedermayer --- libavcodec/utils.c |5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index f8dee50..c7798e6

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/utils: Check that the video data[] arrays are NULL on the input to get_buffer_internal()

On Fri, Feb 26, 2016 at 12:59:08PM +0100, Michael Niedermayer wrote: > This should return an error to the decoder if the struct it tried to > getbuffer is dirty It seems like a good idea, however it likely won't help for programs providing their own getbuffer2 as they will probably fill the

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On Fri, Feb 26, 2016 at 11:29:05AM +0100, wm4 wrote: > On Fri, 26 Feb 2016 02:38:13 +0100 > Michael Niedermayer wrote: > > > On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar Döffinger wrote: > > > We do neither document nor check such a requirement > > > and for

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

Well, there I go, doing my own idle discussions I just complained about ;) On Fri, Feb 26, 2016 at 01:00:23PM +0100, wm4 wrote: > On Fri, 26 Feb 2016 12:19:18 +0100 > Reimar Döffinger wrote: > > I am not exactly sure what their opinion is to be honest. > > However this

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On Fri, 26 Feb 2016 02:38:13 +0100 Michael Niedermayer wrote: > On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar Döffinger wrote: > > We do neither document nor check such a requirement > > and for application-provided get_buffer2 they could > > contain the result of a

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On Fri, Feb 26, 2016 at 12:40:19PM +0100, Clément Bœsch wrote: > On Fri, Feb 26, 2016 at 11:29:05AM +0100, wm4 wrote: > > Unfortunately I have to agree. I got some crashes in libavfilter when I > > didn't set some "unused" plane pointers to NULL. Some code is just lazy > > and checks plane

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On 26.02.2016, at 02:38, Michael Niedermayer wrote: > On Fri, Feb 26, 2016 at 12:15:19AM +0100, Reimar Döffinger wrote: >> We do neither document nor check such a requirement >> and for application-provided get_buffer2 they could >> contain the result of a malloc(0) or

Re: [FFmpeg-devel] New filter: remap?

Am 25.02.16 um 22:24 schrieb F.Sluiter: > If it doesn exist I would like to develop a new filter and would like to > check if nobody is already working on it or that it exists under a > different name. > > I have been researching the following usecase: > > Similar tot the displace filter, I

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On 02/26/2016 08:34 AM, Mats Peterson wrote: On 02/26/2016 08:28 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

Derek Buitenhuis gmail.com> writes: > On 2/25/2016 4:30 PM, Carl Eugen Hoyos wrote: > >> In terms of how the score for a MIME type match compares with > >> those of the individual content matching probe functions, I'd > >> say it makes sense. The stronger probing functions have a > >> score

Re: [FFmpeg-devel] FFmpeg in Outreachy Round 12

I should be on the twitter chat (@kierank_) on the Monday. Kieran From: Marina Zhurakhinskaya To: Michael Niedermayer Cc: FFmpeg development discussions and patches ; outreachy-admins ;

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On 02/26/2016 01:16 PM, Mats Peterson wrote: On 02/26/2016 08:34 AM, Mats Peterson wrote: On 02/26/2016 08:28 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On 26.02.2016, at 14:01, Michael Niedermayer wrote: > On Fri, Feb 26, 2016 at 01:17:29PM +0100, Reimar Döffinger wrote: >> Well, there I go, doing my own idle discussions >> I just complained about ;) >> >> On Fri, Feb 26, 2016 at 01:00:23PM +0100, wm4 wrote: >>> On Fri,

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On Fri, 26 Feb 2016 13:17:29 +0100 Reimar Döffinger wrote: > Well, there I go, doing my own idle discussions > I just complained about ;) > > On Fri, Feb 26, 2016 at 01:00:23PM +0100, wm4 wrote: > > On Fri, 26 Feb 2016 12:19:18 +0100 > > Reimar Döffinger

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

Derek Buitenhuis gmail.com> writes: > I'm saying scoring should be as such: > > 1) Probing the file file itself: Highest score. > 2) Mime-type: Medium score. There is no format except jpeg where this ever can fix an issue. Or in other words: Except for jpeg, there is no probe function that

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

On 2/26/2016 2:44 PM, Carl Eugen Hoyos wrote: > Derek Buitenhuis gmail.com> writes: > >> On 2/25/2016 4:30 PM, Carl Eugen Hoyos wrote: > You misunderstand: > Most "imageauto" demuxers return a score of 51. In all cases > when 51 is returned, the detection is nearly certain. Your > patch

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

Michael Niedermayer skrev: (27 februari 2016 01:30:52 CET) >On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: >> On 02/26/2016 05:26 AM, Mats Peterson wrote: >> >On 02/26/2016 05:08 AM, Mats Peterson wrote: >> >>Should hopefully fix the big-endian issue. >>

Re: [FFmpeg-devel] [PATCH] Document and validate AVFrame plane pointers.

On Fri, 26 Feb 2016 22:59:17 +0100 Reimar Döffinger wrote: > On Fri, Feb 26, 2016 at 10:39:41PM +0100, wm4 wrote: > > On Fri, 26 Feb 2016 22:25:21 +0100 > > Reimar Döffinger wrote: > > > > > Check that the required plane pointers and only >

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On 02/26/2016 11:37 PM, Mats Peterson wrote: On 02/26/2016 11:36 PM, Mats Peterson wrote: i use qemu-mips myself mips is not fast, building on mips is really slow if one did that also cross building to mips should be the same speed as building to x86 would be qemu-mips would only run for a few

Re: [FFmpeg-devel] [PATCH] Document and validate AVFrame plane pointers.

On Fri, Feb 26, 2016 at 11:06:22PM +0100, Reimar Döffinger wrote: > Check that the required plane pointers and only > those are set up. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/utils.c | 20 > libavutil/frame.h | 3 +++ > 2 files

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Process QuickTime palette per track

On 02/27/2016 03:05 AM, Michael Niedermayer wrote: On Wed, Feb 24, 2016 at 06:16:25PM +0100, Mats Peterson wrote: The QuickTime palette was incorrectly stored in the MatroskaDemuxContext instead of a MatroskaTrack. -- Mats Peterson http://matsp888.no-ip.org/~mats/ matroskadec.c | 19

Re: [FFmpeg-devel] [PATCH v7 1/3] mips: improve detection of ISAs, FPU and ASEs (DSP, MSA)

On Wed, Feb 24, 2016 at 04:38:20PM +, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v6 -> v7: > - Do not pass -msoft-float. Leave the mipsfpu handling as it was >before, so nothing changes. This could be improbed in the

Re: [FFmpeg-devel] [PATCH v7 2/3] mips: do not disable any feature for generic cores

On Wed, Feb 24, 2016 at 04:38:21PM +, Vicente Olivert Riera wrote: > We don't know which features are available when the user selects a > generic core, so don't disable anything by default and let the user > decide. > > Signed-off-by: Vicente Olivert Riera > --- >

[FFmpeg-devel] [Consulting] Converting an Audio Visualization application to CLI using FFMpeg

Hello, I am not sure if this is the right page to post this, but your consulting page recommended I use this list. I recent built an audio visualization app using html5. I'm currently using that app with xsplit to stream music to an RTMP endpoint on either twitch.tv or YouTube. For an example

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Process QuickTime palette per track

On 02/27/2016 04:24 AM, Mats Peterson wrote: On 02/27/2016 03:05 AM, Michael Niedermayer wrote: On Wed, Feb 24, 2016 at 06:16:25PM +0100, Mats Peterson wrote: The QuickTime palette was incorrectly stored in the MatroskaDemuxContext instead of a MatroskaTrack. -- Mats Peterson

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Process QuickTime palette per track

On Wed, Feb 24, 2016 at 06:16:25PM +0100, Mats Peterson wrote: > The QuickTime palette was incorrectly stored in the > MatroskaDemuxContext instead of a MatroskaTrack. > > -- > Mats Peterson > http://matsp888.no-ip.org/~mats/ > matroskadec.c | 19 +++ > 1 file changed, 11

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On 02/26/2016 11:31 PM, Michael Niedermayer wrote: On Fri, Feb 26, 2016 at 11:21:19PM +0100, Mats Peterson wrote: Michael Niedermayer skrev: (26 februari 2016 22:53:00 CET) On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: On 02/26/2016 05:26 AM, Mats

Re: [FFmpeg-devel] [PATCH] submit_thread should also lock the mutex that guards the source avctx (prev_thread->avctx) when calling update_context_from_thread.

Hi, On Fri, Feb 26, 2016 at 5:49 PM, Ronald S. Bultje wrote: > Now, one could argue that maybe we shouldn't copy the value *at all* if we > don't use it anyway, which would incidentally also make tools like tsan > happy about this particular thingy. I'm not against that, if

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote: > On 02/26/2016 05:26 AM, Mats Peterson wrote: > >On 02/26/2016 05:08 AM, Mats Peterson wrote: > >>Should hopefully fix the big-endian issue. > >> > > > >Not that I understand why. I thought the palette was already in > >"big-endian"

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On 02/26/2016 11:36 PM, Mats Peterson wrote: i use qemu-mips myself mips is not fast, building on mips is really slow if one did that also cross building to mips should be the same speed as building to x86 would be qemu-mips would only run for a few seconds to do whatever you want to test. I

Re: [FFmpeg-devel] [PATCH 2/2] sws/yuv2rgb: clarify precision of coeff and offset for mmx code

On Fri, Feb 26, 2016 at 10:34:46PM +0100, Clément Bœsch wrote: > It makes easier looking at the difference with the generic code just > below. > --- > libswscale/yuv2rgb.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 1/2] sws/yuv2rgb: avoid a few ub on signed left shifts

On Fri, Feb 26, 2016 at 10:34:45PM +0100, Clément Bœsch wrote: > --- > libswscale/yuv2rgb.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you

Re: [FFmpeg-devel] [PATCH] submit_thread should also lock the mutex that guards the source avctx (prev_thread->avctx) when calling update_context_from_thread.

Hi, On Fri, Feb 26, 2016 at 5:35 PM, Wan-Teh Chang wrote: > The data race is reported on the |qscale| member of MpegEncContext. sl->qscale is unconditionally assigned in ff_h264_decode_slice_header(), which run at the start of each frame. Therefore, qscale is

Re: [FFmpeg-devel] [PATCH] submit_thread should also lock the mutex that guards the source avctx (prev_thread->avctx) when calling update_context_from_thread.

Hi, On Fri, Feb 26, 2016 at 4:12 PM, Wan-Teh Chang wrote: > On Fri, Feb 26, 2016 at 12:44 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Fri, Feb 26, 2016 at 3:26 PM, Ronald S. Bultje > > wrote: > > > >> > >> So doesn't

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

On Fri, Feb 26, 2016 at 5:02 PM, Carl Eugen Hoyos wrote: > Matthieu Bouron gmail.com> writes: > > > Patch updated > > > + --enable-mediacodec enable Android MediaCodec support [no] > > > +enabled mediacodec&& { enabled jni || die > > Sorry if you have already

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

On Tue, Feb 23, 2016 at 11:28:01AM +0100, wm4 wrote: > On Tue, 23 Feb 2016 09:53:43 +0100 > Matthieu Bouron wrote: > > > On Mon, Feb 22, 2016 at 01:08:49PM +0100, Michael Niedermayer wrote: > > > On Mon, Feb 22, 2016 at 12:20:36PM +0100, Matthieu Bouron wrote: > > >

Re: [FFmpeg-devel] [PATCH 1/2] lavc: add JNI support

On Mon, Feb 22, 2016 at 12:20:35PM +0100, Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > configure | 5 + > libavcodec/Makefile | 2 + > libavcodec/ffjni.c | 480 > > libavcodec/ffjni.h

Re: [FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

Matthieu Bouron gmail.com> writes: > Patch updated > + --enable-mediacodec enable Android MediaCodec support [no] > +enabled mediacodec&& { enabled jni || die Sorry if you have already explained: Why are two separate enable-options necessary? How is jni useful without

Re: [FFmpeg-devel] [PATCH] IFF ANIM support

Dana 26. 2. 2016. 12:29 osoba "Piotr Bandurski" napisala je: > > Hi, > > > > And check also this: > > > > > > http://www.randelshofer.ch/animapplet/ > > > > > > public class ANIMDeltaFrame > > > extends ANIMFrame { > > > > > > private int leftBound, topBound, rightBound,

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On Fri, Feb 26, 2016 at 01:17:29PM +0100, Reimar Döffinger wrote: > Well, there I go, doing my own idle discussions > I just complained about ;) > > On Fri, Feb 26, 2016 at 01:00:23PM +0100, wm4 wrote: > > On Fri, 26 Feb 2016 12:19:18 +0100 > > Reimar Döffinger wrote: >

Re: [FFmpeg-devel] [PATCH] mss2: Fix buffer overflow.

On 26.02.2016, at 11:26, wm4 wrote: > On Thu, 25 Feb 2016 22:39:51 +0100 > Reimar Döffinger wrote: > >> On Thu, Feb 25, 2016 at 09:25:08PM +0100, wm4 wrote: >>> On Thu, 25 Feb 2016 21:06:46 +0100 >>> Reimar Döffinger

Re: [FFmpeg-devel] [PATCH] mjpegdec: Do not assume unused plane pointer are NULL.

On Fri, Feb 26, 2016 at 02:20:33PM +0100, Reimar Döffinger wrote: > On 26.02.2016, at 14:01, Michael Niedermayer wrote: > > > On Fri, Feb 26, 2016 at 01:17:29PM +0100, Reimar Döffinger wrote: > >> Well, there I go, doing my own idle discussions > >> I just complained

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Process QuickTime palette per track

On 02/24/2016 06:16 PM, Mats Peterson wrote: The QuickTime palette was incorrectly stored in the MatroskaDemuxContext instead of a MatroskaTrack. ping -- Mats Peterson http://matsp888.no-ip.org/~mats/ ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] FFmpeg in Outreachy Round 12

On Thu, Feb 25, 2016 at 04:35:37AM +0100, Michael Niedermayer wrote: [...] > can you change the link for FFmpeg on > https://wiki.gnome.org/action/login/Outreachy/2016/MayAugust > to point to our outreachy page > https://trac.ffmpeg.org/wiki/SponsoringPrograms/Outreachy/2016-05 > currently it

Re: [FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

On 02/26/2016 01:46 PM, Mats Peterson wrote: On 02/26/2016 01:16 PM, Mats Peterson wrote: On 02/26/2016 08:34 AM, Mats Peterson wrote: On 02/26/2016 08:28 AM, Mats Peterson wrote: On 02/26/2016 05:08 AM, Mats Peterson wrote: Should hopefully fix the big-endian issue.

Re: [FFmpeg-devel] [PATCH] lavf/mp3: Properly check return values of seeks and reads while reading the header

On 2/26/2016 5:14 PM, Derek Buitenhuis wrote: > +ret = avio_read(pb, _buf[0], 4); > +if (ret <= 0) > +return CHECK_SEEK_FAILED; This check should be <, not <=. Changed locally. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/2] img2dec: Add mime_type to image formats

On 2/26/2016 3:05 PM, Carl Eugen Hoyos wrote: > Or in other words: Except for jpeg, there is no > probe function that returns 0 although the decoder > can decode the image. I'll take your word for it on this part. > So please provide your failing jpeg cases to > improve the probing. > I will

[FFmpeg-devel] [PATCH] Document and validate AVFrame plane pointers.

Check that the required plane pointers and only those are set up. Signed-off-by: Reimar Döffinger --- libavcodec/utils.c | 15 +++ libavutil/frame.h | 3 +++ 2 files changed, 18 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index

Re: [FFmpeg-devel] [PATCH] lavf/mp3: Properly check return values of seeks and reads while reading the header

On Fri, 26 Feb 2016 17:32:36 + Derek Buitenhuis wrote: > On 2/26/2016 5:30 PM, wm4 wrote: > > The ffio_ensure_seekback() checks are probably unnecessary. > > I can remove them if you prefer. Should I? I'd vote yet, but that's just my personal opinion. > >

Re: [FFmpeg-devel] [PATCH] lavf/mp3: Properly check return values of seeks and reads while reading the header

On Fri, 26 Feb 2016 17:14:24 + Derek Buitenhuis wrote: > Fixes large amounts of seeking past EOF, which could be extremely > slow over a network. > > Signed-off-by: Derek Buitenhuis > --- > Example of the problem: > ffmpeg -f mp3

Re: [FFmpeg-devel] [PATCH] lavf/mp3: Properly check return values of seeks and reads while reading the header

On 2/26/2016 5:30 PM, wm4 wrote: > The ffio_ensure_seekback() checks are probably unnecessary. I can remove them if you prefer. Should I? > Seems a bit verbose, but ok. I added the av_log stuff because otherwise you just get "Invalid Argument" from the ffmpeg cli, with no other explanation. -

Re: [FFmpeg-devel] [PATCH 1/2] lavc: add JNI support

On Fri, Feb 26, 2016 at 4:41 PM, Matthieu Bouron wrote: > On Mon, Feb 22, 2016 at 12:20:35PM +0100, Matthieu Bouron wrote: > > From: Matthieu Bouron > > > [...] > > Patch updated with the following differences: > * fix of

[FFmpeg-devel] [PATCH] lavf/mp3: Properly check return values of seeks and reads while reading the header

Fixes large amounts of seeking past EOF, which could be extremely slow over a network. Signed-off-by: Derek Buitenhuis --- Example of the problem: ffmpeg -f mp3 -i http://chromashift.org/skyfire.ico This problem was exacerbated even more by the fact that

Re: [FFmpeg-devel] FFmpeg in Outreachy Round 12

- Original Message - > From: "Michael Niedermayer" > To: "FFmpeg development discussions and patches" > Cc: "outreachy-admins" , o...@ffmpeg.org > Sent: Friday, February 26, 2016 8:29:19 AM > Subject: Re:

Re: [FFmpeg-devel] [PATCH] fate: Add test for packed mp3 in mp4 demuxing

On Thu, Feb 25, 2016 at 03:13:07AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tests/fate/demux.mak |3 + > tests/ref/fate/mov-mp3-demux | 289 > ++ > 2 files changed, 292

Re: [FFmpeg-devel] [PATCH] Document and validate AVFrame plane pointers.

On 2/26/2016 5:42 PM, Reimar Döffinger wrote: > +av_assert0(frame->format == avctx->pix_fmt); Is this valid? Mid-stream colorspace changes are fairly common. - erek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org