Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: zero initialize codec_name in mov_parse_stsd_video()

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 11:15:50PM -0300, James Almer wrote: > On 10/17/2016 9:57 PM, Michael Niedermayer wrote: > > On Sun, Oct 16, 2016 at 09:34:50PM -0300, James Almer wrote: > >> Fixes valgrind warning about "Conditional jump or move depends on > >> uninitialised value(s)" > >> > >>

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 11:26:24PM +0200, Andreas Cadhalpun wrote: > On 18.10.2016 22:56, Michael Niedermayer wrote: > > On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: > >> Nothing guarantees to set request_probe to -1, so this assert can be > >> triggered, e.g. if

[FFmpeg-devel] [PATCH] avformat/matroskaenc: write DisplayWidth and DisplayHeight elements only if they differ from PixelWidth and PixelHeight

2016-10-18 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskaenc.c | 6 -- tests/fate/matroska.mak | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 6f2957c..03d5326 100644 ---

Re: [FFmpeg-devel] [PATCH] libavcodec/tests: Added test for libavcodec/avpacket.c

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 01:38:27PM -0700, Thomas Turner wrote: > Improved code coverage for libavcodec > Function(s) Tested: av_packet_clone() > > Signed-off-by: Thomas Turner > --- > libavcodec/Makefile | 3 +- > libavcodec/tests/avpacket.c | 254 >

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Detect field_order based on video_line_map

2016-10-18 Thread Tobias Rapp
On 11.10.2016 10:40, Tobias Rapp wrote: Read video_line_map from MXF generic picture essence descriptor and use it to derive the coded field order. Use field_dominance to derive the display field order from coded field order. If field_dominance is not available the default value "1" is used as

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-10-18 Thread Stefano Sabatini
On date Friday 2016-10-14 00:11:49 +0200, Moritz Barsnick encoded: > On Thu, Oct 13, 2016 at 19:46:41 +0200, Stefano Sabatini wrote: > > +In particular, can be also used to inject data stream generated by > ^ it can > > > +Unrecognized values are discarded (this allows the

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-18 Thread Moritz Barsnick
On Mon, Oct 17, 2016 at 23:23:31 +0200, Michael Behrisch wrote: > My main reason is that we are compiling with different compilers for > different platforms If you're trying to keep ffmpeg more portable, you could at least try the real-life thing and actually attempt to build with Sun Studio or

Re: [FFmpeg-devel] [PATCH] fate: add swr-convertaudio test

2016-10-18 Thread Muhammad Faiz
On Tue, Oct 18, 2016 at 6:20 AM, Michael Niedermayer wrote: > On Mon, Oct 17, 2016 at 05:37:41AM +0700, Muhammad Faiz wrote: >> test for flt to s16 >> should pass on correct rounding to nearest >> >> Signed-off-by: Muhammad Faiz >> --- >>

Re: [FFmpeg-devel] [PATCH v3] aacenc: add SIMD optimizations for abs_pow34 and quantization

2016-10-18 Thread Rostislav Pehlivanov
On 17 October 2016 at 23:43, Michael Niedermayer wrote: > On Mon, Oct 17, 2016 at 10:24:48PM +0100, Rostislav Pehlivanov wrote: > > Should fix segfaults on x86-32 > > > > Performance improvements: > > > > quant_bands: > > with: 681 decicycles in quant_bands, 8388453

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-10-18 Thread Stefano Sabatini
On date Thursday 2016-09-29 21:02:14 +0100, Josh de Kock encoded: [...] > Are you sure this cannot be done from outside of libav*? It really > seems like something which wouldn't actually be very useful for > anyone else. It can be done outside of libav* (reading from a custom format, and then

Re: [FFmpeg-devel] [PATCHv3] mov: Evaluate the movie display matrix

2016-10-18 Thread Benoit Fouet
Hi, On 14/10/2016 00:50, Vittorio Giovara wrote: > diff --git a/libavformat/mov.c b/libavformat/mov.c > index a15c8d1..e8da77f 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c [...] > @@ -3798,16 +3804,33 @@ static int mov_read_meta(MOVContext *c, AVIOContext > *pb, MOVAtom atom) >

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-10-18 Thread Stefano Sabatini
On date Thursday 2016-10-13 19:46:41 +0200, Stefano Sabatini encoded: > On date Thursday 2016-09-29 21:55:11 +0200, wm4 encoded: [...] > > This seems like a rather special use case. Why does it have a demuxer, > > and can't be in your own C code using libavcodec/libavformat? > > > > > In

Re: [FFmpeg-devel] [PATCH]lavf/avidec: Be more verbose when ignoring very large tag size

2016-10-18 Thread Carl Eugen Hoyos
2016-10-18 8:11 GMT+02:00 Clément Bœsch : > On Tue, Oct 18, 2016 at 12:42:18AM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch prints the tag and the tag size when ignoring the size. >> >> Please comment, Carl Eugen > >> From e99dc274b7b4b4b5ef502ddb0a8245c1f47c2ece Mon Sep

Re: [FFmpeg-devel] [PATCH] doc/examples/demuxing_decoding: Drop AVFrame->pts use

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 01:53:58PM +0200, Stefano Sabatini wrote: > On date Tuesday 2016-10-18 04:58:52 +0200, Michael Niedermayer encoded: > > This code is not correct for git master > > > > Signed-off-by: Michael Niedermayer > > --- > > doc/examples/demuxing_decoding.c

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/loudnorm: add an internal libebur128 library

2016-10-18 Thread Martin Vignali
Hello, Maybe you can also update the doc removing this line : To enable compilation of this filter you need to configure FFmpeg with --enable-libebur128 Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] lavf/mov: support gopro hero moments udta tag

2016-10-18 Thread Jean Caillé
From: Jean Caillé --- libavformat/mov.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index cd3e46a..011eb77 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -268,6 +268,23 @@ static int

Re: [FFmpeg-devel] [PATCH] doc/examples/demuxing_decoding: Drop AVFrame->pts use

2016-10-18 Thread Stefano Sabatini
On date Tuesday 2016-10-18 04:58:52 +0200, Michael Niedermayer encoded: > This code is not correct for git master > > Signed-off-by: Michael Niedermayer > --- > doc/examples/demuxing_decoding.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH]lavc/sheervideo: Increase av_get_codec_tag_string() input buffer size.

2016-10-18 Thread Carl Eugen Hoyos
Hi! Attached patch increases the size of the input buffer for av_get_codec_tag_string() to 32, typically used in FFmpeg. Carl Eugen From 79eff70eb71106b8b2330f5d1d119d40775f1f77 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 18 Oct 2016 14:53:30 +0200 Subject:

Re: [FFmpeg-devel] [PATCH 4/4] lavc/mediacodec: use more meaningful filenames

2016-10-18 Thread Matthieu Bouron
On Wed, Oct 12, 2016 at 03:22:42PM +0200, Matthieu Bouron wrote: > From: Matthieu Bouron > > Adds the following changes: > * mediacodecdec.{c,h} -> mediacodecdec_common.{c,h} > * mediacodecdec_h2645.c -> mediacodecdec.c > --- > libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH] lavf/aviobuf: add ff_get_line2() variant

2016-10-18 Thread Stefano Sabatini
On date Thursday 2016-10-13 21:59:19 +0200, Michael Niedermayer encoded: > On Thu, Oct 13, 2016 at 07:40:59PM +0200, Stefano Sabatini wrote: > > This allows to probe if the read line was partially discarded. > > --- > > libavformat/aviobuf.c | 10 +- > > libavformat/internal.h | 14

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-18 Thread Carl Eugen Hoyos
2016-10-18 13:11 GMT+02:00 Moritz Barsnick : > On Tue, Oct 18, 2016 at 00:21:42 +0200, Carl Eugen Hoyos wrote: >> In any case, your second patch is acceptable, should not have >> any adversary effects and we have significantly worse cosmetic >> patches in our tree, so it is ok

Re: [FFmpeg-devel] [PATCH v3] aacenc: add SIMD optimizations for abs_pow34 and quantization

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 09:02:19AM +0100, Rostislav Pehlivanov wrote: > On 17 October 2016 at 23:43, Michael Niedermayer > wrote: > > > On Mon, Oct 17, 2016 at 10:24:48PM +0100, Rostislav Pehlivanov wrote: > > > Should fix segfaults on x86-32 > > > > > > Performance

Re: [FFmpeg-devel] [PATCH v3] aacenc: add SIMD optimizations for abs_pow34 and quantization

2016-10-18 Thread Rostislav Pehlivanov
On 18 October 2016 at 16:32, James Almer wrote: > On 10/18/2016 12:07 PM, Rostislav Pehlivanov wrote: > > diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c > > index ee3cbf8..622f0ba 100644 > > --- a/libavcodec/aacenc.c > > +++ b/libavcodec/aacenc.c > > @@ -1033,6

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-18 Thread Moritz Barsnick
On Tue, Oct 18, 2016 at 00:21:42 +0200, Carl Eugen Hoyos wrote: > In any case, your second patch is acceptable, should not have > any adversary effects and we have significantly worse cosmetic > patches in our tree, so it is ok imo. I only see one patch - did I miss one? - , and if that's the one

Re: [FFmpeg-devel] [PATCH] swresample/resample: fix return value of build_filter

2016-10-18 Thread Muhammad Faiz
On 10/18/16, Michael Niedermayer wrote: > On Tue, Oct 18, 2016 at 02:17:49PM +0700, Muhammad Faiz wrote: >> return AVERROR code on error >> >> Signed-off-by: Muhammad Faiz >> --- >> libswresample/resample.c | 4 +++- >> 1 file changed, 3 insertions(+),

Re: [FFmpeg-devel] [PATCH] avfilter/firequalizer: add dumpfile and dumpscale option

2016-10-18 Thread Muhammad Faiz
On 10/18/16, Muhammad Faiz wrote: > Signed-off-by: Muhammad Faiz > --- > doc/filters.texi | 7 > libavfilter/af_firequalizer.c | 97 > --- > 2 files changed, 90 insertions(+), 14 deletions(-) >

Re: [FFmpeg-devel] [PATCH] avfilter/af_silenceremove: add optional tone when silence is removed

2016-10-18 Thread Greg Rowe
see libavfilter/asrc_sine.c this code should probably be reused / factored (note, any code moving/factoring of existing code should be in a seperate patch) Since silenceremove works only on AV_SAMPLE_FMT_DBL is it OK to use floating point for the generated tone or is it recommended to create

[FFmpeg-devel] [PATCH] avfilter/firequalizer: add cubic_interpolate function on gain

2016-10-18 Thread Muhammad Faiz
smoother version of gain_interpolate Signed-off-by: Muhammad Faiz --- doc/filters.texi | 2 ++ libavfilter/af_firequalizer.c | 49 +-- 2 files changed, 49 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi

[FFmpeg-devel] [PATCH] avformat/movenc: Skip duration check for discontinuous fragments

2016-10-18 Thread Michael Niedermayer
Found-by: Daemon404 Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index d7c7158..50be8ff 100644 --- a/libavformat/movenc.c +++

Re: [FFmpeg-devel] [PATCH] lavf/aviobuf: add ff_get_line2() variant

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 01:32:12PM +0200, Stefano Sabatini wrote: > On date Thursday 2016-10-13 21:59:19 +0200, Michael Niedermayer encoded: > > On Thu, Oct 13, 2016 at 07:40:59PM +0200, Stefano Sabatini wrote: > > > This allows to probe if the read line was partially discarded. > > > --- > > >

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 01:33:27PM +0200, Stefano Sabatini wrote: > On date Thursday 2016-10-13 19:46:41 +0200, Stefano Sabatini encoded: > > On date Thursday 2016-09-29 21:55:11 +0200, wm4 encoded: > [...] > > > This seems like a rather special use case. Why does it have a demuxer, > > > and

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

2016-10-18 Thread wm4
On Fri, 5 Aug 2016 17:18:39 -0700 Sasi Inguva wrote: > In YouTube we have long been receiving MOV files from users, which have > non-trivial edit lists (Those edit lists which are not just used to offset > video start from audio start) and multiple edit lists.

Re: [FFmpeg-devel] [PATCH] libavcodec/tests: Added selftest for libavcodec/avpacket.c

2016-10-18 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 11:22:21PM -0700, tdtur...@ucdavis.edu wrote: > From: Thomas Turner > > Improved code coverage for libavcodec. > Function(s) Tested: av_packet_clone() > > Signed-off-by: Thomas Turner > --- > libavcodec/Makefile | 3

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec: Factor duplicate include

2016-10-18 Thread Matthieu Bouron
On Mon, Oct 17, 2016 at 07:43:37AM +0200, Matthieu Bouron wrote: > On Sun, Oct 16, 2016 at 04:52:10PM +0200, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/mediacodec.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3

Re: [FFmpeg-devel] [PATCH v3] aacenc: add SIMD optimizations for abs_pow34 and quantization

2016-10-18 Thread Rostislav Pehlivanov
On 18 October 2016 at 14:51, Michael Niedermayer wrote: > On Tue, Oct 18, 2016 at 09:02:19AM +0100, Rostislav Pehlivanov wrote: > > On 17 October 2016 at 23:43, Michael Niedermayer > > > wrote: > > > > > On Mon, Oct 17, 2016 at 10:24:48PM +0100,

Re: [FFmpeg-devel] [PATCH] swresample/resample: fix return value of build_filter

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 02:17:49PM +0700, Muhammad Faiz wrote: > return AVERROR code on error > > Signed-off-by: Muhammad Faiz > --- > libswresample/resample.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 2/3 v2] avformat/matroskadec: support parsing Chroma Location elements

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 12:18:01AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/matroska.h| 14 ++ > libavformat/matroskadec.c | 7 +++ > 2 files changed, 21 insertions(+) > > diff --git a/libavformat/matroska.h

Re: [FFmpeg-devel] [PATCH 4/4] lavc/mediacodec: use more meaningful filenames

2016-10-18 Thread Matthieu Bouron
On Wed, Oct 12, 2016 at 03:22:42PM +0200, Matthieu Bouron wrote: > From: Matthieu Bouron > > Adds the following changes: > * mediacodecdec.{c,h} -> mediacodecdec_common.{c,h} > * mediacodecdec_h2645.c -> mediacodecdec.c > --- > libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH] avfilter/af_silenceremove: add optional tone when silence is removed

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 12:46:56PM -0400, Greg Rowe wrote: > >see > >libavfilter/asrc_sine.c > >this code should probably be reused / factored > >(note, any code moving/factoring of existing code should be in a > > seperate patch) > > Since silenceremove works only on AV_SAMPLE_FMT_DBL is it OK

Re: [FFmpeg-devel] [PATCH 0/2] Fix gapless encoding/remuxing for MP3

2016-10-18 Thread Andreas Cadhalpun
On 17.10.2016 23:55, Jon Toohill wrote: > Round trip wav->mp3->wav now preserves the correct number of samples. > Remuxing mp3->mp3 with -c:a copy also preserves any existing gapless > metadata in the Info tag. > > The code in libmp3lame.c to set AV_PKT_DATA_SKIP_SAMPLES was mostly > copied from

Re: [FFmpeg-devel] [PATCH]lavf/rtp_g726: Map mime type G726 to the g726le decoder

2016-10-18 Thread Carl Eugen Hoyos
2016-10-14 15:12 GMT+02:00 Carl Eugen Hoyos : > Hi! > > Attached patch fixes ticket #5890, completely untested. I will apply this if there are no objections. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-10-18 Thread Aman Gupta
On Mon, Oct 17, 2016 at 6:03 PM, Aman Gupta wrote: > > > On Mon, Oct 17, 2016 at 5:51 PM, Richard Kern wrote: > >> >> On Oct 17, 2016, at 8:47 PM, Aman Gupta wrote: >> >> >> >> On Mon, Oct 17, 2016 at 6:35 AM, Richard Kern

Re: [FFmpeg-devel] [PATCH]lavf/avidec: Be more verbose when ignoring very large tag size

2016-10-18 Thread Clément Bœsch
On Tue, Oct 18, 2016 at 12:42:18AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch prints the tag and the tag size when ignoring the size. > > Please comment, Carl Eugen > From e99dc274b7b4b4b5ef502ddb0a8245c1f47c2ece Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos

[FFmpeg-devel] [PATCH] vf_colorspace: Add support for iec61966-2.1 (sRGB) transfer

2016-10-18 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- Special thanks to Andrew Roland for helping me figure out these numbers. Please keep me in CC. Vittorio libavfilter/vf_colorspace.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_colorspace.c

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-10-18 Thread Richard Kern
> On Oct 18, 2016, at 2:30 PM, Aman Gupta wrote: > > > > On Mon, Oct 17, 2016 at 6:03 PM, Aman Gupta > wrote: > > > On Mon, Oct 17, 2016 at 5:51 PM, Richard Kern > wrote: > >> On Oct

[FFmpeg-devel] Memcpy Operation Duration

2016-10-18 Thread Ali KIZIL
Hi Everyone, Today, I was analyzing memcpy duration in FFmpeg. I noticed that it is taking longer time compared to an optimized SSE, SSE2, MMX, MMX2, AVX or AVX2 based memcpy operation. I tried march=corei7-avx2 compiled FFmpeg version, it does not change the duration of memcpy operation. I also

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

2016-10-18 Thread Sasi Inguva
With the current state of code, we will only encounterdemuxer outputting non-monotonic DTS when there are multiple edit lists . Avoiding non-monotonic DTS for mulitple edit lists will not be possible with how the edit list support is currently implemented. That would only be possible if the

Re: [FFmpeg-devel] Memcpy Operation Duration

2016-10-18 Thread Ronald S. Bultje
Hi Ali, On Tue, Oct 18, 2016 at 3:57 PM, Ali KIZIL wrote: > 2016-10-18 22:44 GMT+03:00 Sven C. Dack : > > > On 18/10/16 20:26, Ali KIZIL wrote: > > > >> Hi Everyone, > >> > >> Today, I was analyzing memcpy duration in FFmpeg. I noticed that it is > >>

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

2016-10-18 Thread Sasi Inguva
I am also happy to fix any breaking files, if they don't fall under the above category. On Tue, Oct 18, 2016 at 1:08 PM, Sasi Inguva wrote: > With the current state of code, we will only encounterdemuxer > outputting non-monotonic DTS when there are multiple edit lists .

Re: [FFmpeg-devel] Memcpy Operation Duration

2016-10-18 Thread Ali KIZIL
2016-10-18 22:44 GMT+03:00 Sven C. Dack : > On 18/10/16 20:26, Ali KIZIL wrote: > >> Hi Everyone, >> >> Today, I was analyzing memcpy duration in FFmpeg. I noticed that it is >> taking longer time compared to an optimized SSE, SSE2, MMX, MMX2, AVX or >> AVX2 based memcpy

Re: [FFmpeg-devel] Memcpy Operation Duration

2016-10-18 Thread Ali KIZIL
On Oct 18, 2016 11:08 PM, "Ronald S. Bultje" wrote: > > Hi Ali, > > On Tue, Oct 18, 2016 at 3:57 PM, Ali KIZIL wrote: > > > 2016-10-18 22:44 GMT+03:00 Sven C. Dack : > > > > > On 18/10/16 20:26, Ali KIZIL wrote: > > > > > >> Hi

[FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Andreas Cadhalpun
Nothing guarantees to set request_probe to -1, so this assert can be triggered, e.g. if st->probe_packets is 0. Signed-off-by: Andreas Cadhalpun --- I think the reason why this assert isn't triggered way more often is that the probing code usually works quite

Re: [FFmpeg-devel] Memcpy Operation Duration

2016-10-18 Thread Sven C. Dack
On 18/10/16 20:26, Ali KIZIL wrote: Hi Everyone, Today, I was analyzing memcpy duration in FFmpeg. I noticed that it is taking longer time compared to an optimized SSE, SSE2, MMX, MMX2, AVX or AVX2 based memcpy operation. I tried march=corei7-avx2 compiled FFmpeg version, it does not change

Re: [FFmpeg-devel] [PATCH v3] aacenc: add SIMD optimizations for abs_pow34 and quantization

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 05:33:13PM +0100, Rostislav Pehlivanov wrote: > On 18 October 2016 at 16:32, James Almer wrote: > > > On 10/18/2016 12:07 PM, Rostislav Pehlivanov wrote: > > > diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c > > > index ee3cbf8..622f0ba 100644 >

[FFmpeg-devel] [PATCH] libavcodec/tests: Added test for libavcodec/avpacket.c

2016-10-18 Thread Thomas Turner
Improved code coverage for libavcodec Function(s) Tested: av_packet_clone() Signed-off-by: Thomas Turner --- libavcodec/Makefile | 3 +- libavcodec/tests/avpacket.c | 254 tests/fate/libavcodec.mak | 5 + 3 files

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: > Nothing guarantees to set request_probe to -1, so this assert can be > triggered, e.g. if st->probe_packets is 0. probe_codec() called with NULL should cause st->probe_packets = 0 st->request_probe = -1; [...] -- Michael

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Andreas Cadhalpun
On 18.10.2016 22:56, Michael Niedermayer wrote: > On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: >> Nothing guarantees to set request_probe to -1, so this assert can be >> triggered, e.g. if st->probe_packets is 0. > > probe_codec() called with NULL should cause >

Re: [FFmpeg-devel] [PATCH v3] aacenc: add SIMD optimizations for abs_pow34 and quantization

2016-10-18 Thread Rostislav Pehlivanov
On 18 October 2016 at 21:04, Michael Niedermayer wrote: > On Tue, Oct 18, 2016 at 05:33:13PM +0100, Rostislav Pehlivanov wrote: > > On 18 October 2016 at 16:32, James Almer wrote: > > > > > On 10/18/2016 12:07 PM, Rostislav Pehlivanov wrote: > > > >

[FFmpeg-devel] [PATCH] swresample/resample: fix return value of build_filter

2016-10-18 Thread Muhammad Faiz
return AVERROR code on error Signed-off-by: Muhammad Faiz --- libswresample/resample.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libswresample/resample.c b/libswresample/resample.c index b834248..8635bf1 100644 --- a/libswresample/resample.c +++

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Hendrik Leppkes
On Tue, Oct 18, 2016 at 11:26 PM, Andreas Cadhalpun wrote: > On 18.10.2016 22:56, Michael Niedermayer wrote: >> On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: >>> Nothing guarantees to set request_probe to -1, so this assert can be >>>

Re: [FFmpeg-devel] [PATCH] avformat: remove request_probe assert from ff_read_packet

2016-10-18 Thread Andreas Cadhalpun
On 18.10.2016 23:46, Hendrik Leppkes wrote: > On Tue, Oct 18, 2016 at 11:26 PM, Andreas Cadhalpun > wrote: >> On 18.10.2016 22:56, Michael Niedermayer wrote: >>> On Tue, Oct 18, 2016 at 10:31:37PM +0200, Andreas Cadhalpun wrote: Nothing guarantees to set

[FFmpeg-devel] [PATCH 0/4] V14 - SCTE-35 support

2016-10-18 Thread Carlos Fernandez Sanz
- Addresses all things mentioned by Anssi Hannula about HLS Carlos Fernandez (4): Adding SCTE-35 CUI codec SCTE-35 extraction from mpegts SCTE-35 support in hlsenc Correct Indentation libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 6 + libavformat/Makefile| 2 +-

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: zero initialize codec_name in mov_parse_stsd_video()

2016-10-18 Thread James Almer
On 10/17/2016 9:57 PM, Michael Niedermayer wrote: > On Sun, Oct 16, 2016 at 09:34:50PM -0300, James Almer wrote: >> Fixes valgrind warning about "Conditional jump or move depends on >> uninitialised value(s)" >> >> Signed-off-by: James Almer >> --- >> libavformat/mov.c | 2 +-

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: pass the demuxer's AVFormatContext to avpriv_request_sample()

2016-10-18 Thread James Almer
On 10/17/2016 6:42 PM, Michael Niedermayer wrote: > On Sun, Oct 16, 2016 at 09:34:51PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/mov.c | 7 --- >> 1 file changed, 4 insertions(+), 3 deletions(-) > > LGTM > > thx Pushed, thanks.

[FFmpeg-devel] [PATCH 2/4] V14 - SCTE-35 extraction from mpegts

2016-10-18 Thread Carlos Fernandez Sanz
From: Carlos Fernandez Signed-off-by: Carlos Fernandez --- libavformat/mpegts.c | 47 +-- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index

[FFmpeg-devel] [PATCH 3/4] V14 - SCTE-35 support in hlsenc

2016-10-18 Thread Carlos Fernandez Sanz
From: Carlos Fernandez Signed-off-by: Carlos Fernandez --- libavformat/Makefile | 2 +- libavformat/hlsenc.c | 104 -- libavformat/scte_35.c | 527 ++ libavformat/scte_35.h | 86