Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On 12/11/17, Ronald S. Bultje wrote: > Hi, > > On Sat, Dec 9, 2017 at 10:37 AM, Paul B Mahol wrote: > >> @@ -3376,6 +3376,7 @@ typedef struct AVCodec { >> uint8_t max_lowres; ///< maximum value for lowres >> supported by the decoder

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On Mon, 11 Dec 2017 08:32:52 -0500 "Ronald S. Bultje" wrote: > Hi, > > On Sat, Dec 9, 2017 at 10:37 AM, Paul B Mahol wrote: > > > @@ -3376,6 +3376,7 @@ typedef struct AVCodec { > > uint8_t max_lowres; ///< maximum value for lowres

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On Mon, 11 Dec 2017 15:28:31 +0100 Hendrik Leppkes wrote: > On Mon, Dec 11, 2017 at 2:22 PM, Paul B Mahol wrote: > > On 12/11/17, Hendrik Leppkes wrote: > >> On Mon, Dec 11, 2017 at 12:07 PM, Paul B Mahol wrote:

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On Mon, 11 Dec 2017 14:22:43 +0100 Paul B Mahol wrote: > On 12/11/17, Hendrik Leppkes wrote: > > On Mon, Dec 11, 2017 at 12:07 PM, Paul B Mahol wrote: > >>> > >>> Fine, but it's inevitable that the encoder supports the J formats still

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On 12/11/2017 11:28 AM, Hendrik Leppkes wrote: > On Mon, Dec 11, 2017 at 2:22 PM, Paul B Mahol wrote: >> On 12/11/17, Hendrik Leppkes wrote: >>> On Mon, Dec 11, 2017 at 12:07 PM, Paul B Mahol wrote: > > Fine, but it's inevitable

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On 11.12.2017 14:22, Paul B Mahol wrote: On 12/11/17, Hendrik Leppkes wrote: On Mon, Dec 11, 2017 at 12:07 PM, Paul B Mahol wrote: Fine, but it's inevitable that the encoder supports the J formats still for a while. Why are you all dismissive about

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On Mon, 11 Dec 2017 11:36:52 -0300 James Almer wrote: > On 12/11/2017 11:28 AM, Hendrik Leppkes wrote: > > On Mon, Dec 11, 2017 at 2:22 PM, Paul B Mahol wrote: > >> On 12/11/17, Hendrik Leppkes wrote: > >>> On Mon, Dec 11, 2017 at

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On Mon, Dec 11, 2017 at 2:22 PM, Paul B Mahol wrote: > On 12/11/17, Hendrik Leppkes wrote: >> On Mon, Dec 11, 2017 at 12:07 PM, Paul B Mahol wrote: Fine, but it's inevitable that the encoder supports the J formats still for

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On Mon, Dec 11, 2017 at 12:07 PM, Paul B Mahol wrote: >> >> Fine, but it's inevitable that the encoder supports the J formats still >> for a while. > > > Why are you all dismissive about this? Because we have an established way to remove things like this, and that doesn't

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On 12/11/17, Hendrik Leppkes wrote: > On Mon, Dec 11, 2017 at 12:07 PM, Paul B Mahol wrote: >>> >>> Fine, but it's inevitable that the encoder supports the J formats still >>> for a while. >> >> >> Why are you all dismissive about this? > > > Because we

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

Hi, On Sat, Dec 9, 2017 at 10:37 AM, Paul B Mahol wrote: > @@ -3376,6 +3376,7 @@ typedef struct AVCodec { > uint8_t max_lowres; ///< maximum value for lowres > supported by the decoder > const AVClass *priv_class; ///< AVClass for the

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

Paul B Mahol (2017-12-11): > Endless bikeshed... It is not bikeshedding, it is preparing for the future. You should try maintaining part of the framework, for a change. That is not as simple as porting a filter or implementing a demuxer. If the API is not well designed, it will need to be

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On 12/11/17, wm4 wrote: > On Sat, 9 Dec 2017 16:37:53 +0100 > Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/avcodec.h | 1 + >> libavcodec/utils.c | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff

Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/mediacodec: use AVMediaCodecDeviceContext hw_device_ctx if set

On Sun, Dec 03, 2017 at 05:32:22PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/mediacodecdec.c| 2 +- > libavcodec/mediacodecdec_common.c | 14 +- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/mediacodec: use AVMediaCodecDeviceContext hw_device_ctx if set

On Mon, Dec 11, 2017 at 01:33:18PM +0100, Matthieu Bouron wrote: > On Sun, Dec 03, 2017 at 05:32:22PM -0800, Aman Gupta wrote: > > From: Aman Gupta > > > > --- > > libavcodec/mediacodecdec.c| 2 +- > > libavcodec/mediacodecdec_common.c | 14 +- > > 2 files

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

On Fri, 8 Dec 2017 18:51:52 +0100 Carl Eugen Hoyos wrote: > 2017-12-08 18:45 GMT+01:00 Tiejun.Peng : > > i agree with you. too much experience value in condition of Judgement > > like this: > > "else if(max_frames>=4 && max_frames >=

Re: [FFmpeg-devel] [PATCH 4/7] avfilter/vf_framerate: factorize get_scene_score

On 12/10/17, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavfilter/vf_framerate.c | 78 > ++ > 1 file changed, 31 insertions(+), 47 deletions(-) > lgtm ___

Re: [FFmpeg-devel] [PATCH 5/7] avfilter/vf_framerate: fix scene change detection score

On 12/10/17, Marton Balint wrote: > - normalize score to [0..100] instead of [0..85] > - change the default score to 8.2 to roughly keep existing behaviour > - take into account bit depth > - do not truncate to integer > > Signed-off-by: Marton Balint > --- >

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

W dniu 11.12.2017 o 00:51, Mateusz pisze: > W dniu 10.12.2017 o 21:13, Martin Vignali pisze: >>> >>> For me there is no "src + (width - 1) * step" in tests/checkasm/vf_hflip.c >>> >>> You pass start of the src buffer but you should pass end of the buffer. >>> >>> >>> >>> Thanks ! >> >> New patch

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

> > It doesn't run (the test is skipped) on 32-bit VS 2017 with command: > configure --enable-gpl --toolchain=msvc && make fate-rsync > SAMPLES=../fate-suite && make fate SAMPLES=../fate-suite > > With exactly the same command it runs on 64-bit VS 2017. > With similar command line (without

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On Sat, 9 Dec 2017 16:37:53 +0100 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/avcodec.h | 1 + > libavcodec/utils.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

W dniu 11.12.2017 o 11:00, Martin Vignali pisze: > 2017-12-11 10:49 GMT+01:00 Mateusz : > >> W dniu 11.12.2017 o 00:51, Mateusz pisze: >>> W dniu 10.12.2017 o 21:13, Martin Vignali pisze: > > For me there is no "src + (width - 1) * step" in >>

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: Fix capability check with old drivers.

2017-12-08 10:38 GMT+01:00 Timo Rothenpieler : > lgtm, feel free to push or remind me to do so if I forget Please push patches that you review and consider ok. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On Mon, 11 Dec 2017 12:07:34 +0100 Paul B Mahol wrote: > On 12/11/17, wm4 wrote: > > On Sat, 9 Dec 2017 16:37:53 +0100 > > Paul B Mahol wrote: > > > >> Signed-off-by: Paul B Mahol > >> --- > >>

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

W dniu 11.12.2017 o 11:28, Martin Vignali pisze: >> >> It doesn't run (the test is skipped) on 32-bit VS 2017 with command: >> configure --enable-gpl --toolchain=msvc && make fate-rsync >> SAMPLES=../fate-suite && make fate SAMPLES=../fate-suite >> >> With exactly the same command it runs on

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-11 10:49 GMT+01:00 Mateusz : > W dniu 11.12.2017 o 00:51, Mateusz pisze: > > W dniu 10.12.2017 o 21:13, Martin Vignali pisze: > >>> > >>> For me there is no "src + (width - 1) * step" in > tests/checkasm/vf_hflip.c > >>> > >>> You pass start of the src buffer but

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: Fix capability check with old drivers.

This patch is already applied for a while now. I'm not always near a my development system to test and push patches... smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 1/2] libavutil/hwcontext: add AV_HWDEVICE_TYPE_MEDIACODEC

On Mon, Dec 04, 2017 at 02:50:22PM +0100, Matthieu Bouron wrote: [...] > > It works but output the following error: > > Invalid setup for format mediacodec: does not match the type of the provided > device context. > Invalid return from get_format(): mediacodec not in possible list. > >

Re: [FFmpeg-devel] [PATCH 3/7] avfilter/vf_framerate: factorize blend_frames

On 12/10/17, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavfilter/vf_framerate.c | 54 > ++ > 1 file changed, 7 insertions(+), 47 deletions(-) > lgtm ___

Re: [FFmpeg-devel] [PATCH 2/7] avfilter/vf_framerate: add threaded blending operations

On 12/10/17, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavfilter/vf_framerate.c | 202 > - > 1 file changed, 125 insertions(+), 77 deletions(-) > lgtm ___

Re: [FFmpeg-devel] [PATCH 7/7] avfilter/vf_framerate: fix scene score with negative linesize

On 12/10/17, Marton Balint wrote: > Also, do not overread input if linesize > width, or linesize is not > divisible > by 8, and use the proper rounded width/height for MAFD calculation. > > Signed-off-by: Marton Balint > --- > libavfilter/vf_framerate.c | 18

Re: [FFmpeg-devel] [PATCH] lavf/mov: atom box parsing returneofcause play fail

yes, it is. maybe we should add every stream's status and the whole file status can't be fail only by one of streams. but the modification will be too much and the effect is extensive. -- Original -- From: "Michael Niedermayer";;

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On Mon, Dec 11, 2017 at 3:36 PM, James Almer wrote: > On 12/11/2017 11:28 AM, Hendrik Leppkes wrote: >> On Mon, Dec 11, 2017 at 2:22 PM, Paul B Mahol wrote: >>> On 12/11/17, Hendrik Leppkes wrote: On Mon, Dec 11, 2017 at 12:07 PM,

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On 12/11/17, Hendrik Leppkes wrote: > On Mon, Dec 11, 2017 at 3:36 PM, James Almer wrote: >> On 12/11/2017 11:28 AM, Hendrik Leppkes wrote: >>> On Mon, Dec 11, 2017 at 2:22 PM, Paul B Mahol wrote: On 12/11/17, Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH 0/2] avcodec: metadata for hardware backed decoders

On Mon, 27 Nov 2017 20:45:59 -0800 Philip Langdale wrote: > We have a number of hardware backed implementations in the codebase > that are done as full decoders instead of HWAccels for various > reasons. These decoders cannot be discovered today, and clients > which care end

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

>* On Sat, Dec 9, 2017 at 10:37 AM, Paul B Mahol > wrote:* > Endless bikeshed... Being dismissive to valid points is not good for project health. > I hate how people can be so ignorant these days. Can you tone it down a notch maybe? I can't

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On 12/11/17, Paul B Mahol wrote: > On 12/11/17, Hendrik Leppkes wrote: >> On Mon, Dec 11, 2017 at 3:36 PM, James Almer wrote: >>> On 12/11/2017 11:28 AM, Hendrik Leppkes wrote: On Mon, Dec 11, 2017 at 2:22 PM, Paul B Mahol

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/mjpeg: remove YUVJ mentions

On 12/11/17, Vittorio Giovara wrote: >>* On 12/8/17, Paul B Mahol http://gmail.com>>* >>> On 12/8/17, Vittorio Giovara >> > wrote: >>*> If we were to break this feature, I'd suggest going the full route of > *>*> adding

Re: [FFmpeg-devel] [PATCH 0/2] avcodec: metadata for hardware backed decoders

On 2017-12-11 07:34, wm4 wrote: On Mon, 27 Nov 2017 20:45:59 -0800 Philip Langdale wrote: We have a number of hardware backed implementations in the codebase that are done as full decoders instead of HWAccels for various reasons. These decoders cannot be discovered today,

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/mjpeg: remove YUVJ mentions

>* On 12/8/17, Paul B Mahol http://gmail.com>>* >> On 12/8/17, Vittorio Giovara > > wrote: >*> If we were to break this feature, I'd suggest going the full route of *>*> adding a PixelFormaton and work on a sws alternative (one is allowed to *>*>

[FFmpeg-devel] [WIP][RFC][PATCH] avfilter: negotiate color_range between filters

Signed-off-by: Paul B Mahol --- This is with color range negotiation. To be applied on top of previous patch set. It fixes issue Michael found. This needs more work as every filter needs its query_formats() changed. --- fftools/ffmpeg_filter.c | 13 +++---

Re: [FFmpeg-devel] [WIP][RFC][PATCH] avfilter: negotiate color_range between filters

I do not have time to look at the code in details right now, and I do not know when I will have time, but here are a few remarks. Paul B Mahol (2017-12-11): > Signed-off-by: Paul B Mahol > --- > > This is with color range negotiation. > To be applied on top of previous patch

Re: [FFmpeg-devel] [WIP][RFC][PATCH] avfilter: negotiate color_range between filters

On 12/11/17, Nicolas George wrote: > I do not have time to look at the code in details right now, and I do > not know when I will have time, but here are a few remarks. > > Paul B Mahol (2017-12-11): >> Signed-off-by: Paul B Mahol >> --- >> >> This is with

[FFmpeg-devel] [PATCH] avfilter: negotiate color_range between filters

Signed-off-by: Paul B Mahol --- Now with mjpeg vsynth tests passing. --- fftools/ffmpeg_filter.c | 33 +++- libavfilter/avfilter.c | 9 --- libavfilter/avfilter.h | 4 ++- libavfilter/avfiltergraph.c | 53

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/mjpeg: remove YUVJ mentions

On Mon, Dec 11, 2017 at 12:09:33PM -0500, Vittorio Giovara wrote: > >* On 12/8/17, Paul B Mahol http://gmail.com>>* > >> On 12/8/17, Vittorio Giovara >> > wrote: > >*> If we were to break this feature, I'd suggest going the full route of > *>*>

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

On Mon, Dec 11, 2017 at 11:43:30AM +0100, wm4 wrote: > On Fri, 8 Dec 2017 18:51:52 +0100 > Carl Eugen Hoyos wrote: > > > 2017-12-08 18:45 GMT+01:00 Tiejun.Peng : > > > i agree with you. too much experience value in condition of Judgement > > > like

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/mjpeg: remove YUVJ mentions

On Mon, Dec 11, 2017 at 10:58:41PM +0100, Paul B Mahol wrote: > On 12/11/17, Michael Niedermayer wrote: > > On Mon, Dec 11, 2017 at 12:09:33PM -0500, Vittorio Giovara wrote: > >> >* On 12/8/17, Paul B Mahol http://gmail.com>>* > >> >> On 12/8/17, Vittorio Giovara >> >>

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

On 12/9/2017 11:25 PM, Rostislav Pehlivanov wrote: On 10 December 2017 at 02:41, Aaron Levinson wrote: On 12/9/2017 6:24 PM, Aaron Levinson wrote: On 12/9/2017 6:15 PM, Aaron Levinson wrote: On 12/9/2017 1:18 AM, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/mjpeg: remove YUVJ mentions

On 12/11/17, Michael Niedermayer wrote: > On Mon, Dec 11, 2017 at 12:09:33PM -0500, Vittorio Giovara wrote: >> >* On 12/8/17, Paul B Mahol http://gmail.com>>* >> >> On 12/8/17, Vittorio Giovara > >> > wrote: >> >*> If we

Re: [FFmpeg-devel] [PATCH] lavc/utils: remove unnecessary locking

On 12/8/2017 2:27 AM, Michael Niedermayer wrote: On Fri, Dec 08, 2017 at 09:49:25AM +0100, Hendrik Leppkes wrote: On Fri, Dec 8, 2017 at 6:09 AM, Rostislav Pehlivanov wrote: Its already done by lockmgr. Signed-off-by: Rostislav Pehlivanov ---

Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/mediacodec: use AVMediaCodecDeviceContext hw_device_ctx if set

On 11/12/17 12:34, Matthieu Bouron wrote: >> >> New patch attached fixing errors in get_format() by keeping the original >> AVCodecHWConfigInternal (ad-hoc) and adding a new one (hw-device) with the >> device_type field set to the MediaCodec. >> >> The updated patchset works without errors with

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix wrong function name in error message

On 2017/12/7 8:49, Jun Zhao wrote: > > On 2017/12/5 17:25, Hendrik Leppkes wrote: >> On Tue, Dec 5, 2017 at 6:42 AM, Jun Zhao wrote: >>> On 2017/12/5 2:32, Michael Niedermayer wrote: On Mon, Dec 04, 2017 at 11:07:11AM +0100, Hendrik Leppkes wrote: > On Mon, Dec 4,

Re: [FFmpeg-devel] [PATCH V2] lavc/vp8: Fix HWAccel VP8 decoder can't support resolution change.

Re-ping, any comments? On 2017/12/5 11:03, Jun Zhao wrote: > ping ? > > On 2017/11/30 7:53, Jun Zhao wrote: >> V2: fix the V1 lead to webp crash issue. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/mediacodec: use AVMediaCodecDeviceContext hw_device_ctx if set

On Mon, 11 Dec 2017 22:10:24 + Mark Thompson wrote: > On 11/12/17 12:34, Matthieu Bouron wrote: > >> > >> New patch attached fixing errors in get_format() by keeping the original > >> AVCodecHWConfigInternal (ad-hoc) and adding a new one (hw-device) with the > >> device_type

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail

On Mon, 11 Dec 2017 22:56:24 +0100 Michael Niedermayer wrote: > On Mon, Dec 11, 2017 at 11:43:30AM +0100, wm4 wrote: > > On Fri, 8 Dec 2017 18:51:52 +0100 > > Carl Eugen Hoyos wrote: > > > > > 2017-12-08 18:45 GMT+01:00 Tiejun.Peng

Re: [FFmpeg-devel] [PATCH] lavc/utils: remove unnecessary locking

On Tue, Dec 12, 2017 at 12:25 AM, Aaron Levinson wrote: > On 12/8/2017 2:27 AM, Michael Niedermayer wrote: >> >> On Fri, Dec 08, 2017 at 09:49:25AM +0100, Hendrik Leppkes wrote: >>> >>> On Fri, Dec 8, 2017 at 6:09 AM, Rostislav Pehlivanov >>> wrote: