Re: [FFmpeg-devel] [PATCH 2/2] avformat: add avformat_flush()

2014-09-30 Thread Reimar Döffinger
On 30.09.2014, at 22:25, wm4 wrote: > On Tue, 30 Sep 2014 08:06:16 +0200 > Reimar Döffinger wrote: > >> On 29.09.2014, at 22:02, Michael Niedermayer wrote: >>> On Mon, Sep 29, 2014 at 08:34:44PM +0200, wm4 wrote: On Mon, 29 Sep 2014 20:25:47 +0200 Michael Niedermayer wrote: >>>

Re: [FFmpeg-devel] IRC meeting

2014-09-30 Thread Timothy Gu
Hi, On Mon, Sep 29, 2014 at 8:39 AM, Stefano Sabatini wrote: > Hi, > > I want to propose to have an FFmpeg IRC meeting the next Saturday, 4th > October, UTC 16. Alternatively, I propose the Saturday of the next > week, Saturday October 11, same time. I don't think I will be available for the ent

Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft

2014-09-30 Thread James Almer
On 01/10/14 12:18 AM, Michael Niedermayer wrote: > On Tue, Sep 30, 2014 at 11:57:14PM -0300, James Almer wrote: >> On 30/09/14 11:34 PM, Michael Niedermayer wrote: >>> On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: On 15.09.2014 22:03, Michael Niedermayer wrote: > On Mo

Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 11:57:14PM -0300, James Almer wrote: > On 30/09/14 11:34 PM, Michael Niedermayer wrote: > > On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: > >> On 15.09.2014 22:03, Michael Niedermayer wrote: > >>> On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wro

Re: [FFmpeg-devel] [PATCH 2/2] av_lockmgr_register defines behavior on failure.

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 07:34:28PM -0700, Manfred Georg wrote: > Yeah, that seemed a bit odd to meI guess I get to go correct some > calling code. > > Here is yet another update with a comment which tells you not to use a > static mutex. > > Subject: [PATCH] av_lockmgr_register defines behavi

Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft

2014-09-30 Thread James Almer
On 30/09/14 11:34 PM, Michael Niedermayer wrote: > On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: >> On 15.09.2014 22:03, Michael Niedermayer wrote: >>> On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: On 15/09/14 6:07 AM, Michael Niedermayer wrote: > On Sun

Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft

2014-09-30 Thread Michael Niedermayer
On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: > On 15.09.2014 22:03, Michael Niedermayer wrote: > >On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: > >>On 15/09/14 6:07 AM, Michael Niedermayer wrote: > >>>On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote:

Re: [FFmpeg-devel] [PATCH 2/2] av_lockmgr_register defines behavior on failure.

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 07:00:19PM -0700, Manfred Georg wrote: > Here's the updated patch. Of note is the fact that I'm not sure it's > actually legal to have a mutex manager which uses a single > static mutex (and hence has all created mutex backed by the > same underlying locking mechanism). i

Re: [FFmpeg-devel] [PATCH 2/2] av_lockmgr_register defines behavior on failure.

2014-09-30 Thread Manfred Georg
Here's the updated patch. Of note is the fact that I'm not sure it's actually legal to have a mutex manager which uses a single static mutex (and hence has all created mutex backed by the same underlying locking mechanism). Hopefully this patch is legible: Subject: [PATCH] av_lockmgr_register de

Re: [FFmpeg-devel] [PATCH 2/2] av_lockmgr_register defines behavior on failure.

2014-09-30 Thread James Almer
On 30/09/14 10:46 PM, Manfred Georg wrote: > Sure, I've made the change to the comment within my local code. I'm sorry, > but I'm not familiar with FFmpeg development cycle: how would you like me > to post it? > 1) A patch on top of the patch that is already in this thread (i.e. > something that w

Re: [FFmpeg-devel] [PATCH 2/2] av_lockmgr_register defines behavior on failure.

2014-09-30 Thread Manfred Georg
Sure, I've made the change to the comment within my local code. I'm sorry, but I'm not familiar with FFmpeg development cycle: how would you like me to post it? 1) A patch on top of the patch that is already in this thread (i.e. something that will be squished into this patch). 2) A new patch in a

[FFmpeg-devel] [PATCH] x86/mpegvideoencdsp: improve ff_pix_sum16_sse2

2014-09-30 Thread James Almer
~15 faster. Also add an mmxext version that takes advantage of the new code, and build it alongside with the mmx version only on x86_32. Signed-off-by: James Almer --- libavcodec/x86/mpegvideoencdsp.asm| 51 +++ libavcodec/x86/mpegvideoencdsp_init.c | 7

Re: [FFmpeg-devel] [PATCH 2/2] av_lockmgr_register defines behavior on failure.

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 03:20:43PM -0700, Manfred Georg wrote: > The register function now specifies that the user callback should > leave things in the same state that it found them on failure but > that failure to destroy is ignored by ffmpeg. The register > function is also now explicit about i

Re: [FFmpeg-devel] [PATCH 1/2] Force mutex to NULL after destruction.

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 03:20:42PM -0700, Manfred Georg wrote: > A badly behaving user provided mutex manager (such as that in OpenCV) may not > reset the mutex to NULL on destruction. This can cause a problem for a later > mutex manager (which may assert that the mutex is NULL before creating).

Re: [FFmpeg-devel] [PATCH 2/2] avformat: Add format_whitelist

2014-09-30 Thread Michael Niedermayer
On Wed, Oct 01, 2014 at 12:12:43AM +0200, wm4 wrote: > On Tue, 30 Sep 2014 23:33:51 +0200 > Michael Niedermayer wrote: > > > This allows restricting demuxers to a list of needed ones for improved > > security > > Note, some demuxers themselfs open other demuxers, these are only > > restricted i

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add avcodec_register_list() to register a list of codec/parser/bsf/hwaccel

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 09:07:43PM +0200, Reimar Döffinger wrote: > On Tue, Sep 30, 2014 at 07:41:08PM +0200, Michael Niedermayer wrote: > > + * @param list ',' seperated list of entities to register, the list used > > must > > + * have a sufficient lifetime so future calls to > > avcodec_r

Re: [FFmpeg-devel] [PATCH 2/2] avformat: Add format_whitelist

2014-09-30 Thread wm4
On Tue, 30 Sep 2014 23:33:51 +0200 Michael Niedermayer wrote: > This allows restricting demuxers to a list of needed ones for improved > security > Note, some demuxers themselfs open other demuxers, these are only restricted > if > AVOptions are forwarded to them. Please check that your code do

Re: [FFmpeg-devel] [PATCH] Reset mutex to NULL after mutex destruction.

2014-09-30 Thread Manfred Georg
I took a crack at the more general change (it will be arriving shortly). It's split into two patches, the first is a simplified version of this change and the second patch more strongly defines the behavior on failure of both the user supplied function and av_lockmgr_register. Please consider this

[FFmpeg-devel] [PATCH 2/2] avformat: Add format_whitelist

2014-09-30 Thread Michael Niedermayer
This allows restricting demuxers to a list of needed ones for improved security Note, some demuxers themselfs open other demuxers, these are only restricted if AVOptions are forwarded to them. Please check that your code does that. Signed-off-by: Michael Niedermayer --- libavformat/avformat.h

[FFmpeg-devel] [PATCH 1/2] avcodec: add codec_whitelist

2014-09-30 Thread Michael Niedermayer
This allows restricting decoders to a list of needed ones for improved security Signed-off-by: Michael Niedermayer --- libavcodec/avcodec.h |8 libavcodec/options_table.h |1 + libavcodec/utils.c |6 ++ 3 files changed, 15 insertions(+) diff --git a/libavc

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add avformat_flush()

2014-09-30 Thread wm4
On Tue, 30 Sep 2014 08:06:16 +0200 Reimar Döffinger wrote: > On 29.09.2014, at 22:02, Michael Niedermayer wrote: > > On Mon, Sep 29, 2014 at 08:34:44PM +0200, wm4 wrote: > >> On Mon, 29 Sep 2014 20:25:47 +0200 > >> Michael Niedermayer wrote: > >> > >>> On Mon, Sep 29, 2014 at 07:41:28PM +0200,

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/aviobuf: fix avio_flush() for read streams

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 06:46:48PM +0200, wm4 wrote: > avio_flush() did nothing useful for read streams. Fix it to behave as > expected, and discard the currently read buffer properly. > --- > In addition to v1, also make sure that avio_flush() never enters the > write path with read streams. This

Re: [FFmpeg-devel] IRC meeting

2014-09-30 Thread Lou Logan
On Mon, 29 Sep 2014 17:39:23 +0200, Stefano Sabatini wrote: > Hi, > > I want to propose to have an FFmpeg IRC meeting the next Saturday, 4th > October, UTC 16. Alternatively, I propose the Saturday of the next > week, Saturday October 11, same time. I can most likely show up on Oct 4. I'll be un

Re: [FFmpeg-devel] [PATCH] Reset mutex to NULL after mutex destruction.

2014-09-30 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 09:57:02PM -0700, Manfred Georg wrote: > Answers inline. > > On Mon, Sep 29, 2014 at 7:07 PM, Michael Niedermayer > wrote: > > > On Mon, Sep 29, 2014 at 02:41:38PM -0700, Manfred Georg wrote: > > > A badly behaving user provided mutex manager (such as that in OpenCV) > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add avcodec_register_list() to register a list of codec/parser/bsf/hwaccel

2014-09-30 Thread Reimar Döffinger
On Tue, Sep 30, 2014 at 07:41:08PM +0200, Michael Niedermayer wrote: > + * @param list ',' seperated list of entities to register, the list used must > + * have a sufficient lifetime so future calls to > avcodec_register_list() > + * can access it for comparission. I think you can avo

Re: [FFmpeg-devel] [PATCH 2/2] x86/mlpdec: add ff_mlp_rematrix_channel_{sse4, avx2}

2014-09-30 Thread James Almer
On 30/09/14 3:50 PM, James Almer wrote: > av_cold void ff_mlpdsp_init_x86(MLPDSPContext *c) > { > -#if HAVE_7REGS && HAVE_INLINE_ASM && HAVE_INLINE_ASM_NONLOCAL_LABELS > int cpu_flags = av_get_cpu_flags(); > +#if HAVE_7REGS && HAVE_INLINE_ASM && HAVE_INLINE_ASM_NONLOCAL_LABELS > if (INL

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add avcodec_register_one() to register one codec/parser/bsf/hwaccel by its char* name

2014-09-30 Thread Reimar Döffinger
On Tue, Sep 30, 2014 at 05:21:20PM +0200, Michael Niedermayer wrote: > > with no > > global mutable state. > > i disagree, applications that care about security must > restrict used entities globally, thus by definition want to change > global state. maybe not the way its done in this patch yes, i

Re: [FFmpeg-devel] [RFC] Direct Stream Transfer (DST) decoder

2014-09-30 Thread Reimar Döffinger
On Tue, Sep 30, 2014 at 11:42:20PM +1000, Peter Ross wrote: > +/** > + * Calculate FS44 ratio > + */ > +#define DSD_FS44(sample_rate) (sample_rate / 44100) > + > +/** > + * Calculate DST frame size > + * @return samples per frame (1-bit samples) > + */ > +#define DST_SAMPLES_PER_FRAME(sample_rate)

[FFmpeg-devel] [PATCH 2/2] x86/mlpdec: add ff_mlp_rematrix_channel_{sse4, avx2}

2014-09-30 Thread James Almer
2x to 2.5x faster than the C version. Signed-off-by: James Almer --- libavcodec/mlpdec.c| 4 +- libavcodec/x86/Makefile| 6 +- libavcodec/x86/mlpdsp.asm | 198 + libavcodec/x86/{mlpdsp.c => mlpdsp_init.c

[FFmpeg-devel] [PATCH 1/2] mlpdec: move rematrix_channels code to output_data()

2014-09-30 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mlpdec.c | 45 ++--- 1 file changed, 18 insertions(+), 27 deletions(-) diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c index e443f81..2c5426c 100644 --- a/libavcodec/mlpdec.c +++ b/libavcodec/mlpdec.c @@ -10

Re: [FFmpeg-devel] [PATCH] avcodec/srtdec: use AVBPrint API

2014-09-30 Thread Clément Bœsch
On Mon, Sep 29, 2014 at 05:36:15PM +0200, Nicolas George wrote: > Le septidi 7 vendémiaire, an CCXXIII, Clément Bœsch a écrit : > > --- > > Can only be applied after timed SRT is dropped. > > --- > > libavcodec/srtdec.c | 78 > > - > > 1 file ch

Re: [FFmpeg-devel] [PATCH 1/2] Kill timed SRT

2014-09-30 Thread Clément Bœsch
On Mon, Sep 29, 2014 at 07:27:02PM +0200, Clément Bœsch wrote: > On Mon, Sep 29, 2014 at 05:42:09PM +0200, Nicolas George wrote: > > L'octidi 28 fructidor, an CCXXII, Clément Bœsch a écrit : > > > --- > > > libavcodec/srtdec.c | 33 +++ > > > libavcodec/srtenc.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add avcodec_register_one() to register one codec/parser/bsf/hwaccel by its char* name

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 06:23:38PM +0200, wm4 wrote: [...] > But then you might as well create a better API, like a per > AV(Codec/Format)Context whitelist of allowed codecs. The goal is security, and for that its neccessary to ensure it cannot easily or through plausible programming mistakes be

Re: [FFmpeg-devel] [PATCH v2] Add SUP/PGS subtitle muxer

2014-09-30 Thread Reimar Döffinger
Hello, I didn't see any real issues either. On Tue, Sep 30, 2014 at 11:01:17AM +0300, phint...@gmail.com wrote: > +static int sup_write_packet(AVFormatContext *s, AVPacket *pkt) > +{ > +uint8_t *data = pkt->data; const uint8_t * would be a bit nicer though, to make sure nobody gets any bad id

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add avcodec_register_one() to register one codec/parser/bsf/hwaccel by its char* name

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 06:23:38PM +0200, wm4 wrote: > On Tue, 30 Sep 2014 17:21:20 +0200 > Michael Niedermayer wrote: > > > Hi > > > > On Tue, Sep 30, 2014 at 03:51:13PM +0200, wm4 wrote: > > > On Tue, 30 Sep 2014 02:02:49 +0200 > > > Michael Niedermayer wrote: > > > > > > > Signed-off-by: Mi

Re: [FFmpeg-devel] patch 1/4: libavcodec/ppc/pixblockdsp.c: fix get_pixels_altivec() and diff_pixels_altivec() for POWER LE

2014-09-30 Thread Reimar Döffinger
On Tue, Sep 30, 2014 at 03:51:55PM +0800, rongyan wrote: > Hi, > I present 4 patches to fix bugs for POWER8 little endian. > I will send 4 patches in 4 different email. This is the first. > The fate test result after merge these 4 patches can be found on > http://fate.ffmpeg.org/ by search "ibmc

[FFmpeg-devel] [PATCH 2/2] avcodec: add avcodec_register_list() to register a list of codec/parser/bsf/hwaccel

2014-09-30 Thread Michael Niedermayer
This allows globally limiting the allowed entities for security purposes by the application Signed-off-by: Michael Niedermayer --- libavcodec/allcodecs.c | 49 ++-- libavcodec/avcodec.h | 20 2 files changed, 55 insertions(+)

[FFmpeg-devel] [PATCH 1/2] avutil/avstring: Factor av_match_list() out

2014-09-30 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/APIchanges |3 +++ libavformat/format.c | 20 +++- libavutil/avstring.c | 21 + libavutil/avstring.h |7 +++ 4 files changed, 34 insertions(+), 17 deletions(-) diff --git a/doc/APIchanges b/doc/A

[FFmpeg-devel] [PATCH v2 1/2] avformat/aviobuf: fix avio_flush() for read streams

2014-09-30 Thread wm4
avio_flush() did nothing useful for read streams. Fix it to behave as expected, and discard the currently read buffer properly. --- In addition to v1, also make sure that avio_flush() never enters the write path with read streams. This wasn't ensured before. avio_close() calls avio_flush() uncondit

[FFmpeg-devel] [PATCH v2 2/2] avformat: add avformat_flush()

2014-09-30 Thread wm4
TODO: add entry to APIchanges, bump minor version. --- Updated the doxygen. --- libavformat/avformat.h | 17 + libavformat/utils.c| 6 ++ 2 files changed, 23 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 78054de..550cc50 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: read reel_name and source timecode from physical source package

2014-09-30 Thread Mark Reid
On Sun, Sep 28, 2014 at 3:16 AM, Michael Niedermayer wrote: > On Sun, Sep 28, 2014 at 11:04:34AM +0200, Tomas Härdin wrote: > > On Thu, 2014-09-25 at 16:13 -0700, Mark Reid wrote: > > > --- > > > libavformat/mxfdec.c | 118 > ++- > > > 1 file chang

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add avcodec_register_one() to register one codec/parser/bsf/hwaccel by its char* name

2014-09-30 Thread wm4
On Tue, 30 Sep 2014 17:21:20 +0200 Michael Niedermayer wrote: > Hi > > On Tue, Sep 30, 2014 at 03:51:13PM +0200, wm4 wrote: > > On Tue, 30 Sep 2014 02:02:49 +0200 > > Michael Niedermayer wrote: > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/allcodecs.c | 51 > > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add avcodec_register_one() to register one codec/parser/bsf/hwaccel by its char* name

2014-09-30 Thread Michael Niedermayer
Hi On Tue, Sep 30, 2014 at 03:51:13PM +0200, wm4 wrote: > On Tue, 30 Sep 2014 02:02:49 +0200 > Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/allcodecs.c | 51 > > +--- > > libavcodec/avcodec.h |5

Re: [FFmpeg-devel] More specific error codes

2014-09-30 Thread Andrey Utkin
2014-09-29 21:06 GMT+04:00 Nicolas George : > L'octidi 8 vendémiaire, an CCXXIII, Andrey Utkin a écrit : >> At last I got back to this issue. >> First I thought of adding such new error codes: > >> What do you think about it? Which would you prefer? > > I am sorry to have to say your proposal has

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add jpeg2000 support

2014-09-30 Thread Matthieu Bouron
On Tue, Sep 30, 2014 at 3:37 PM, Benoit Fouet wrote: > Hi, > Hi Benoit, Thanks for your patch. I've reviewed the ULs values and they look good to me. > > this patch adds support for j2k muxing in MXF. > tested with: > $ ffmpeg -t 5 -f lavfi -i testsrc -y -c:v libopenjpeg -y out.mxf > > Played

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-30 Thread wm4
On Tue, 30 Sep 2014 12:01:33 +0300 Petri Hintukainen wrote: > Hello, > > Missing DTS combined with non-monotonic PTS seems to cause some > problems. This is with the file from ticket #2208 (I added dumping > timestamps to demuxer and muxer): > > > $ ../ffmpeg -i orig/track_06\ -\ Subtitle.sup

Re: [FFmpeg-devel] [RFC] Direct Stream Transfer (DST) decoder

2014-09-30 Thread compn
On Tue, 30 Sep 2014 23:42:20 +1000 Peter Ross wrote: > +++ b/libavcodec/allcodecs.c > @@ -343,6 +343,7 @@ void avcodec_register_all(void) > REGISTER_ENCDEC (DSD_MSBF, dsd_msbf); > REGISTER_ENCDEC (DSD_LSBF_PLANAR, dsd_lsbf_planar); > REGISTER_ENCDEC (DSD_MSBF_PLANAR, d

Re: [FFmpeg-devel] [PATCH v2] Add SUP/PGS subtitle muxer

2014-09-30 Thread wm4
On Tue, 30 Sep 2014 11:01:17 +0300 phint...@gmail.com wrote: > From: Petri Hintukainen > > Fixes ticket #2208 > --- > Changelog| 2 +- > doc/general.texi | 2 +- > libavformat/Makefile | 1 + > libavformat/allformats.c | 2 +- > libavformat/supenc.c | 96 > +

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add avcodec_register_one() to register one codec/parser/bsf/hwaccel by its char* name

2014-09-30 Thread wm4
On Tue, 30 Sep 2014 02:02:49 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/allcodecs.c | 51 > +--- > libavcodec/avcodec.h |5 + > 2 files changed, 40 insertions(+), 16 deletions(-) > > diff --g

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: fix avio_flush() for read streams

2014-09-30 Thread wm4
On Tue, 30 Sep 2014 01:02:45 +0200 Michael Niedermayer wrote: > On Mon, Sep 29, 2014 at 07:41:27PM +0200, wm4 wrote: > > avio_flush() did nothing useful for read streams. Fix it to behave as > > expected, and discard the currently read buffer properly. > > --- > > Since avio_flush() was just brok

[FFmpeg-devel] [RFC] Direct Stream Transfer (DST) decoder

2014-09-30 Thread Peter Ross
Signed-off-by: Peter Ross --- DST (described in 14496 Part 3 Subpart 10) is the lossless compression standard for DSD samples. My implementation is ~45% faster than the reference decoder. Even so, single threaded decoding is still very demanding and there does not appear to much scope for SIMD opt

[FFmpeg-devel] [PATCH] avformat/mxfenc: add jpeg2000 support

2014-09-30 Thread Benoit Fouet
Hi, this patch adds support for j2k muxing in MXF. tested with: $ ffmpeg -t 5 -f lavfi -i testsrc -y -c:v libopenjpeg -y out.mxf Played back in ffplay (linux), vlc (windows), Acrok MXF converter (windows). I have no idea against what other players this should be tested. -- Ben From 448810ec5b39

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_mp4toannexb_bsf: use the given padding in h264_extradata_to_annexb().#

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 01:06:30PM +0200, Benoit Fouet wrote: > --- > libavcodec/h264_mp4toannexb_bsf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matt

Re: [FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 01:05:09PM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > On Tue, Sep 30, 2014 at 11:15:06AM +0200, Benoit Fouet wrote: > > > Hi, > > > > > > - Mail original - > > > > On Tue, Sep 30, 2014 at 09:45:47AM +0200, Benoit Fouet wrote: > > > > > Hi, >

[FFmpeg-devel] [PATCH 2/2] avcodec/h264_mp4toannexb_bsf: reset the new IDR flag when SPS/PPS is seen.

2014-09-30 Thread Benoit Fouet
--- libavcodec/h264_mp4toannexb_bsf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_mp4toannexb_bsf.c b/libavcodec/h264_mp4toannexb_bsf.c index be42304..ae96ee9 100644 --- a/libavcodec/h264_mp4toannexb_bsf.c +++ b/libavcodec/h264_mp4toannexb_bsf.c @@ -186

[FFmpeg-devel] [PATCH 1/2] avcodec/h264_mp4toannexb_bsf: use the given padding in h264_extradata_to_annexb().

2014-09-30 Thread Benoit Fouet
--- libavcodec/h264_mp4toannexb_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_mp4toannexb_bsf.c b/libavcodec/h264_mp4toannexb_bsf.c index 3ec4170..be42304 100644 --- a/libavcodec/h264_mp4toannexb_bsf.c +++ b/libavcodec/h264_mp4toannexb_bsf.c @@ -117,7 +

Re: [FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

2014-09-30 Thread Benoit Fouet
Hi, - Mail original - > On Tue, Sep 30, 2014 at 11:15:06AM +0200, Benoit Fouet wrote: > > Hi, > > > > - Mail original - > > > On Tue, Sep 30, 2014 at 09:45:47AM +0200, Benoit Fouet wrote: > > > > Hi, > > > > > > > > - Mail original - > > > > > On Mon, Sep 29, 2014 at 03:3

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: fix glob pattern detection.

2014-09-30 Thread Benoit Fouet
Hi, - Mail original - > The is_glob() function was not working with unescaped glob patterns, > which is the way only glob_sequence (which is deprecated) works. > Fixes ticket #3948 > --- > libavformat/img2dec.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) > > di

Re: [FFmpeg-devel] RTMP Play file descriptor leak

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 08:46:54PM +1100, Alexander Drozdov wrote: > 2014-09-30 20:25 GMT+11:00 Michael Niedermayer : > > > > > applied > > > > thanks > > > You are welcome! > > > > > > PS: i think theres another case in there that needs a similar change > > > > Does you regard return at the top

Re: [FFmpeg-devel] [PATCH] avformat/movenc: AVC Intra support

2014-09-30 Thread Kieran Kunhya
> Some of the DPP AVCI100 test samples were created using x264* so could > be used for reference. Or I could knock up something if I can find my > reference CL I used last time. www.obe.tv/about-us/obe-blog/item/1-oss-dpp-creation Remember to use the latest x264. Even then the values in the "UMID

Re: [FFmpeg-devel] RTMP Play file descriptor leak

2014-09-30 Thread Alexander Drozdov
2014-09-30 20:25 GMT+11:00 Michael Niedermayer : > > applied > > thanks > You are welcome! > > PS: i think theres another case in there that needs a similar change > > Does you regard return at the top of this function? It seems that there is no resource allocation before so it is safe to do ret

Re: [FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 11:15:06AM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > On Tue, Sep 30, 2014 at 09:45:47AM +0200, Benoit Fouet wrote: > > > Hi, > > > > > > - Mail original - > > > > On Mon, Sep 29, 2014 at 03:31:36PM +0200, Benoit Fouet wrote: > > > > > > >

Re: [FFmpeg-devel] RTMP Play file descriptor leak

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 08:01:23PM +1100, Alexander Drozdov wrote: > Hi! > > In our project we uses FFmpeg to demux RTMP streams. Input stream takes > from Wowza/nginx-rtmp. Our application is a daemon that try to connect to > source periodicaly if it does not present (does not published to Wowza,

Re: [FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

2014-09-30 Thread Benoit Fouet
Hi, - Mail original - > On Tue, Sep 30, 2014 at 09:45:47AM +0200, Benoit Fouet wrote: > > Hi, > > > > - Mail original - > > > On Mon, Sep 29, 2014 at 03:31:36PM +0200, Benoit Fouet wrote: > > > > > > > [...] > > > > > does this ensure that the sps is before the pps ? > > > if no

Re: [FFmpeg-devel] [PATCH] avformat/movenc: AVC Intra support

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 09:50:58AM +0100, tim nicholson wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 28/09/14 02:59, Michael Niedermayer wrote: > > On Sun, Sep 28, 2014 at 03:53:15AM +0200, Michael Niedermayer wrote: > >> On Sun, Sep 28, 2014 at 02:00:00AM +0100, Kieran Kunhya w

[FFmpeg-devel] RTMP Play file descriptor leak

2014-09-30 Thread Alexander Drozdov
Hi! In our project we uses FFmpeg to demux RTMP streams. Input stream takes from Wowza/nginx-rtmp. Our application is a daemon that try to connect to source periodicaly if it does not present (does not published to Wowza, for example). We also use interrupt callback to break connection if timeout

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-30 Thread Petri Hintukainen
Hello, Missing DTS combined with non-monotonic PTS seems to cause some problems. This is with the file from ticket #2208 (I added dumping timestamps to demuxer and muxer): $ ../ffmpeg -i orig/track_06\ -\ Subtitle.sup -scodec copy 6.sup ffmpeg version N-66546-gea74007 Copyright (c) 2000-2014 the

Re: [FFmpeg-devel] [PATCH] avformat/movenc: AVC Intra support

2014-09-30 Thread tim nicholson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/09/14 02:59, Michael Niedermayer wrote: > On Sun, Sep 28, 2014 at 03:53:15AM +0200, Michael Niedermayer wrote: >> On Sun, Sep 28, 2014 at 02:00:00AM +0100, Kieran Kunhya wrote: >>> On 28 September 2014 00:49, Michael Niedermayer wrote:

Re: [FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

2014-09-30 Thread Michael Niedermayer
On Tue, Sep 30, 2014 at 09:45:47AM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > On Mon, Sep 29, 2014 at 03:31:36PM +0200, Benoit Fouet wrote: > > > > [...] > > > does this ensure that the sps is before the pps ? > > if not that might be the reason for the warnings > > > >

[FFmpeg-devel] patch 4/4: libavcodec/ppc/hpeldsp_altivec.c: fix ff_put_pixels16_altivec() for POWER LE

2014-09-30 Thread Grace Ryan
Hi, I present 4 patches to fix bugs for POWER8 little endian. I will send 4 patches in 4 different email. This is the fourth. The fate test result after merge these 4 patches can be found on http://fate.ffmpeg.org/ by search "ibmcrl", also attached here to facilitate the review: ​ The passed test

[FFmpeg-devel] patch 3/4: libavcodec/ppc/me_cmp.c: fixe sad16_altivec(), sad16_altivec(), sad16_xy2_altivec(), sad16_x2_altivec(), sad16_y2_altivec(), sad8_altivec() for POWER LE

2014-09-30 Thread Grace Ryan
Hi, I present 4 patches to fix bugs for POWER8 little endian. I will send 4 patches in 4 different email. This is the third. The fate test result after merge these 4 patches can be found on http://fate.ffmpeg.org/ by search "ibmcrl", also attached here to facilitate the review: ​ The passed test

[FFmpeg-devel] patch 2/4: libavcodec/ppc/mpegvideoencdsp.c: fix pix_normal_altivec() and pix_sum_altivec() for POWER LE

2014-09-30 Thread Grace Ryan
Hi, I present 4 patches to fix bugs for POWER8 little endian. I will send 4 patches in 4 different email. This is the second. The fate test result after merge these 4 patches can be found on http://fate.ffmpeg.org/ by search "ibmcrl", also attached here to facilitate the review: ​ The passed test

[FFmpeg-devel] [PATCH v2] Add SUP/PGS subtitle muxer

2014-09-30 Thread phintuka
From: Petri Hintukainen Fixes ticket #2208 --- Changelog| 2 +- doc/general.texi | 2 +- libavformat/Makefile | 1 + libavformat/allformats.c | 2 +- libavformat/supenc.c | 96 5 files changed, 100 insertions(+)

[FFmpeg-devel] patch1/4: libavcodec/ppc/pixblockdsp.c: fix get_pixels_altivec() and diff_pixels_altivec() for POWER LE

2014-09-30 Thread Grace Ryan
Hi, I present 4 patches to fix bugs for POWER8 little endian. I will send 4 patches in 4 different email. This is the first. The fate test result after merge these 4 patches can be found on http://fate.ffmpeg.org/ by search "ibmcrl", also attached here to facilitate the review: ​ The passed test

[FFmpeg-devel] patch 1/4: libavcodec/ppc/pixblockdsp.c: fix get_pixels_altivec() and diff_pixels_altivec() for POWER LE

2014-09-30 Thread rongyan
Hi, I present 4 patches to fix bugs for POWER8 little endian. I will send 4 patches in 4 different email. This is the first. The fate test result after merge these 4 patches can be found on http://fate.ffmpeg.org/ by search "ibmcrl", also attached here to facilitate the review: ​ The passed t

Re: [FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

2014-09-30 Thread Benoit Fouet
Hi, - Mail original - > On Mon, Sep 29, 2014 at 03:31:36PM +0200, Benoit Fouet wrote: > [...] > does this ensure that the sps is before the pps ? > if not that might be the reason for the warnings > It does not. I can update this so that when the pps is seen and not the sps, it prepen