[FFmpeg-devel] [PATCH] avformat/img2dec: Use AVOpenCallback

2016-01-19 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavformat/img2dec.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index db4b4b7..1039cce 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andy Furniss
Hendrik Leppkes wrote: I do not agree that it should be a warning. As outlined in the commit message and this thread, there are serious flaws with frame threading and hwaccel. I'm fine with it being an error, but since it is an API change, it should follow the usual deprecation period to allow

Re: [FFmpeg-devel] [PATCH] avcodec/ass_split: Fix null pointer dereference in ff_ass_style_get()

2016-01-19 Thread Andreas Cadhalpun
On 17.01.2016 15:55, Michael Niedermayer wrote: > From: Michael Niedermayer > > Fixes: > 55d71971da50365d542ed14b65565fe1/signal_sigsegv_4765a4_8499_f146af090a94f591d6254515c7700ef5.mkv > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > Signed-off-by: Michael Niedermayer > --- > lib

[FFmpeg-devel] [PATCH] ffplay: Update docs after previous changes in ffplay mouse behaviour.

2016-01-19 Thread Vittorio Gambaletta (VittGam)
Signed-off-by: Vittorio Gambaletta --- doc/ffplay.texi |5 - ffplay.c|3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/ffplay.texi b/doc/ffplay.texi index 2a35c21..4bc3ced 100644 --- a/doc/ffplay.texi +++ b/doc/ffplay.texi @@ -238,9 +238,12 @@ Seek to

Re: [FFmpeg-devel] [PATCH v3 2/2] ffplay: Toggle full screen when double-clicking the video window with the left mouse button.

2016-01-19 Thread Vittorio Gambaletta (VittGam)
On 19/01/2016 23:40:22 CET, Marton Balint wrote: On Tue, 19 Jan 2016, Marton Balint wrote: On Tue, 19 Jan 2016, Vittorio Gambaletta (VittGam) wrote: Now that the seek only happens with the right mouse button, it makes sense to toggle full screen when double-clicking with the left mouse butto

Re: [FFmpeg-devel] [PATCH 2/2] avformat/avio: Remove url options parsing

2016-01-19 Thread Andreas Cadhalpun
On 19.01.2016 22:13, Michael Niedermayer wrote: > From: Michael Niedermayer > > This feature is not know much or used much AFAIK, and it might be helpfull in > exploits. > No specific case is known where it can be used in an exploit though I have no idea how widely used this feature is, but it i

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
Hi Ronald, On 19.01.2016 21:53, Ronald S. Bultje wrote: > Crashes are never good and should be fixed immediately. > > What exact issue is left after the crash is fixed, and why? The issue is that VLC from git master doesn't compile with FFmpeg from git master, unless all hardware acceleration o

Re: [FFmpeg-devel] [PATCH 1/2] avformat/concatdec: set safe mode to enabled instead of auto

2016-01-19 Thread Andreas Cadhalpun
On 19.01.2016 22:13, Michael Niedermayer wrote: > From: Michael Niedermayer > > This is safer, as a selected demuxer could still mean that it was > auto-detected > by a user application > > Signed-off-by: Michael Niedermayer > --- > libavformat/concatdec.c |2 +- > 1 file changed, 1 inser

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
On 19.01.2016 21:46, wm4 wrote: > On Tue, 19 Jan 2016 21:31:19 +0100 > Hendrik Leppkes wrote: >> On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun >> wrote: >>> On 19.01.2016 21:22, Hendrik Leppkes wrote: On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun wrote: They don't la

Re: [FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread Bodecs Bela
2016.01.19. 19:00 keltezéssel, Bodecs Bela írta: 2016.01.19. 16:53 keltezéssel, Carl Eugen Hoyos írta: Bodecs Bela vivanet.hu> writes: To retain the current behaviour and not to break any earlier app, a new config parameter has been introduced. Is the current behaviour useful or do you co

Re: [FFmpeg-devel] [PATCH v3 2/2] ffplay: Toggle full screen when double-clicking the video window with the left mouse button.

2016-01-19 Thread Marton Balint
On Tue, 19 Jan 2016, Marton Balint wrote: On Tue, 19 Jan 2016, Vittorio Gambaletta (VittGam) wrote: Now that the seek only happens with the right mouse button, it makes sense to toggle full screen when double-clicking with the left mouse button, like other video players do. Signed-off-by: V

Re: [FFmpeg-devel] [PATCH] checkasm: add fixed_dsp tests

2016-01-19 Thread Michael Niedermayer
On Tue, Jan 19, 2016 at 01:43:45PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/checkasm/Makefile| 3 + > tests/checkasm/checkasm.c | 3 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/fixed_dsp.c | 184 > + >

Re: [FFmpeg-devel] [PATCH] vf_overlay handles expression evaluation of frame size change in frame-by-frame evalutaion mode

2016-01-19 Thread Michael Niedermayer
On Tue, Jan 19, 2016 at 08:08:12PM +, Paul B Mahol wrote: > On 1/19/16, Bodecs Bela wrote: > > Hi All, > > > > vf_overlay video filter accepts expressions in its parameters. In > > 'frame-by-frame' evaluation mode it recalculates them regularly, but > > incoming video frame size changes did no

Re: [FFmpeg-devel] [PATCH v3 2/2] ffplay: Toggle full screen when double-clicking the video window with the left mouse button.

2016-01-19 Thread Marton Balint
On Tue, 19 Jan 2016, Vittorio Gambaletta (VittGam) wrote: Now that the seek only happens with the right mouse button, it makes sense to toggle full screen when double-clicking with the left mouse button, like other video players do. Signed-off-by: Vittorio Gambaletta Thanks, applied. Rega

Re: [FFmpeg-devel] [PATCH v3 1/2] ffplay: Seek only when pressing the right mouse button on the video window.

2016-01-19 Thread Marton Balint
On Tue, 19 Jan 2016, Vittorio Gambaletta (VittGam) wrote: Seeking by clicking on the video window can be annoying, because the user might click on it accidentally while eg. trying to get focus on it, and ffplay seeks instead. This commit changes that behaviour to seek only when the right mouse

Re: [FFmpeg-devel] [PATCH v6 1/3] mips: improve detection of ISAs, FPU and ASEs (DSP, MSA)

2016-01-19 Thread Michael Niedermayer
On Thu, Jan 14, 2016 at 02:59:03PM +, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v5 -> v6: > - Multiple changes: >- Use separate if blocks when detecting the MIPS ISA, this way when a block > disables one ISA it will be detected by the next on

Re: [FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread Bodecs Bela
2016.01.19. 22:23 keltezéssel, Paul B Mahol írta: On 1/19/16, Bodecs Bela wrote: 2016.01.19. 21:42 keltezessel, Paul B Mahol irta: On 1/19/16, wm4 wrote: On Tue, 19 Jan 2016 19:00:18 +0100 Bodecs Bela wrote: 2016.01.19. 16:53 keltezessel, Carl Eugen Hoyos irta: Bodecs Bela vivanet.hu

Re: [FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread Paul B Mahol
On 1/19/16, Bodecs Bela wrote: > > > 2016.01.19. 21:42 keltezessel, Paul B Mahol irta: >> On 1/19/16, wm4 wrote: >>> On Tue, 19 Jan 2016 19:00:18 +0100 >>> Bodecs Bela wrote: >>> 2016.01.19. 16:53 keltezessel, Carl Eugen Hoyos irta: > Bodecs Bela vivanet.hu> writes: > >> To ret

[FFmpeg-devel] [PATCH 1/2] avformat/concatdec: set safe mode to enabled instead of auto

2016-01-19 Thread Michael Niedermayer
From: Michael Niedermayer This is safer, as a selected demuxer could still mean that it was auto-detected by a user application Signed-off-by: Michael Niedermayer --- libavformat/concatdec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/concatdec.c b/libavf

[FFmpeg-devel] [PATCH 2/2] avformat/avio: Remove url options parsing

2016-01-19 Thread Michael Niedermayer
From: Michael Niedermayer This feature is not know much or used much AFAIK, and it might be helpfull in exploits. No specific case is known where it can be used in an exploit though Signed-off-by: Michael Niedermayer --- libavformat/avio.c | 30 +- 1 file changed,

Re: [FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread Bodecs Bela
2016.01.19. 21:42 keltezéssel, Paul B Mahol írta: On 1/19/16, wm4 wrote: On Tue, 19 Jan 2016 19:00:18 +0100 Bodecs Bela wrote: 2016.01.19. 16:53 keltezessel, Carl Eugen Hoyos irta: Bodecs Bela vivanet.hu> writes: To retain the current behaviour and not to break any earlier app, a new c

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Ronald S. Bultje
Hi, On Tue, Jan 19, 2016 at 3:41 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 19.01.2016 21:31, Hendrik Leppkes wrote: > > On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun > > wrote: > >> On 19.01.2016 21:22, Hendrik Leppkes wrote: > >>> On Tue, Jan 19, 2016 at 9:13 PM

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread wm4
On Tue, 19 Jan 2016 21:31:19 +0100 Hendrik Leppkes wrote: > On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun > wrote: > > On 19.01.2016 21:22, Hendrik Leppkes wrote: > >> On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun > >> wrote: > >>> On 22.10.2015 11:44, Hendrik Leppkes wrote: > >

Re: [FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread Paul B Mahol
On 1/19/16, wm4 wrote: > On Tue, 19 Jan 2016 19:00:18 +0100 > Bodecs Bela wrote: > >> 2016.01.19. 16:53 keltezessel, Carl Eugen Hoyos irta: >> > Bodecs Bela vivanet.hu> writes: >> > >> >> To retain the current behaviour and not to break any >> >> earlier app, a new config parameter has been intr

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
On 19.01.2016 21:31, Hendrik Leppkes wrote: > On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun > wrote: >> On 19.01.2016 21:22, Hendrik Leppkes wrote: >>> On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun >>> wrote: On 22.10.2015 11:44, Hendrik Leppkes wrote: They now made VLC's conf

Re: [FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread Bodecs Bela
2016.01.19. 21:09 keltezéssel, wm4 írta: On Tue, 19 Jan 2016 19:00:18 +0100 Bodecs Bela wrote: 2016.01.19. 16:53 keltezéssel, Carl Eugen Hoyos írta: Bodecs Bela vivanet.hu> writes: To retain the current behaviour and not to break any earlier app, a new config parameter has been introdu

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Hendrik Leppkes
On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun wrote: > On 19.01.2016 21:22, Hendrik Leppkes wrote: >> On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun >> wrote: >>> On 22.10.2015 11:44, Hendrik Leppkes wrote: On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: > VLC is using frame

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
On 19.01.2016 21:22, Hendrik Leppkes wrote: > On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun > wrote: >> On 22.10.2015 11:44, Hendrik Leppkes wrote: >>> On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: VLC is using frame threading with hwaccel >>> >>> Then they should fix their usage, i

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Hendrik Leppkes
On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun wrote: > On 22.10.2015 11:44, Hendrik Leppkes wrote: >> On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: >>> VLC is using frame threading with hwaccel >> >> Then they should fix their usage, its broken by design, as explained >> in detail my pos

Re: [FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread wm4
On Tue, 19 Jan 2016 19:00:18 +0100 Bodecs Bela wrote: > 2016.01.19. 16:53 keltezéssel, Carl Eugen Hoyos írta: > > Bodecs Bela vivanet.hu> writes: > > > >> To retain the current behaviour and not to break any > >> earlier app, a new config parameter has been introduced. > > Is the current beh

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
On 22.10.2015 11:44, Hendrik Leppkes wrote: > On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: >> VLC is using frame threading with hwaccel > > Then they should fix their usage, its broken by design, as explained > in detail my post earlier in this thread. Care to provide a patch for them? The

Re: [FFmpeg-devel] [PATCH] vf_overlay handles expression evaluation of frame size change in frame-by-frame evalutaion mode

2016-01-19 Thread Paul B Mahol
On 1/19/16, Bodecs Bela wrote: > Hi All, > > vf_overlay video filter accepts expressions in its parameters. In > 'frame-by-frame' evaluation mode it recalculates them regularly, but > incoming video frame size changes did not reflect in their values. So if > you used > width or height of any sourc

Re: [FFmpeg-devel] [PATCH v3 5/5] libavfilter: VAAPI surface converter

2016-01-19 Thread wm4
On Tue, 19 Jan 2016 14:10:59 + Mark Thompson wrote: > ... > >> +static int vaapi_conv_config_input(AVFilterLink *inlink) > >> +{ > >> +AVFilterContext *avctx = inlink->dst; > >> +VAAPIConvContext *ctx = avctx->priv; > >> +AVVAAPISurfaceConfig *config = &ctx->input_config; > >> + >

Re: [FFmpeg-devel] [PATCH v3 2/5] ffmpeg: initialisation code for VAAPI, hwaccel helper

2016-01-19 Thread wm4
On Tue, 19 Jan 2016 13:54:25 + Mark Thompson wrote: > >> +surface = (AVVAAPISurface*)input_frame->buf[0]->data; > > > > I haven't paid attention to this before. Shouldn't this be a vaapi > > surface ID according to how libavcodec works? > > data[3] is the VAAPI surface ID, as used i

Re: [FFmpeg-devel] [PATCH v3 1/5] libavutil: some VAAPI infrastructure

2016-01-19 Thread wm4
On Tue, 19 Jan 2016 13:19:36 + Mark Thompson wrote: > ... > >> + > >> +static void vaapi_codec_release_surface(void *opaque, uint8_t *data) > >> +{ > >> +AVVAAPISurface *surface = opaque; > >> + > >> +av_assert0(surface->refcount > 0); > >> +--surface->refcount; > >> +} > > > >

[FFmpeg-devel] [PATCH] vf_overlay handles expression evaluation of frame size change in frame-by-frame evalutaion mode

2016-01-19 Thread Bodecs Bela
Hi All, vf_overlay video filter accepts expressions in its parameters. In 'frame-by-frame' evaluation mode it recalculates them regularly, but incoming video frame size changes did not reflect in their values. So if you used width or height of any source videos in expressions as parameters, the

Re: [FFmpeg-devel] libavformat/tcp.c : add send_buffer_size and recv_buffer_size options

2016-01-19 Thread Perette Barella
> tabs aren’t allowed in ffmpeg git (except makefiles) fixed > SO_RCVBUF occurs twice, is that intended ? Not intended, fixed, thanks. > cleaning up the indention is welcome, but please in a seperate patch Removed from this patch. > also an update to the docs is needed Done. Updated patch follo

Re: [FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread Bodecs Bela
2016.01.19. 16:53 keltezéssel, Carl Eugen Hoyos írta: Bodecs Bela vivanet.hu> writes: To retain the current behaviour and not to break any earlier app, a new config parameter has been introduced. Is the current behaviour useful or do you consider it a bug? First I thought that it was a bug,

[FFmpeg-devel] [PATCH v2] lavc/rawdec: Use AV_PIX_FMT_PAL8 for 1-bit raw AVI video

2016-01-19 Thread Mats Peterson
Simplified the setting of the default palette for 1-bit AVI files in raw_init_decoder(). Mats >From d2ffdb87a32be74c1a3e1e9a996fa0b1cdda8b87 Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Tue, 19 Jan 2016 18:48:06 +0100 Subject: [PATCH v2] lavc/rawdec: Use AV_PIX_FMT_PAL8 for 1-bit raw AVI

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread John Cox
>On 1/19/2016 2:24 PM, John Cox wrote: >> On Tue, 19 Jan 2016 14:09:22 -0300, you wrote: >> >>> On 1/19/2016 2:05 PM, John Cox wrote: > On 1/19/2016 9:46 AM, John Cox wrote: >> +// Helper fns >> +#ifndef hevc_mem_bits32 >> +static av_always_inline uint32_t hevc_mem_bits32(const voi

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread James Almer
On 1/19/2016 2:24 PM, John Cox wrote: > On Tue, 19 Jan 2016 14:09:22 -0300, you wrote: > >> On 1/19/2016 2:05 PM, John Cox wrote: On 1/19/2016 9:46 AM, John Cox wrote: > +// Helper fns > +#ifndef hevc_mem_bits32 > +static av_always_inline uint32_t hevc_mem_bits32(const void * buf,

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread John Cox
On Tue, 19 Jan 2016 14:09:22 -0300, you wrote: >On 1/19/2016 2:05 PM, John Cox wrote: >>> On 1/19/2016 9:46 AM, John Cox wrote: +// Helper fns +#ifndef hevc_mem_bits32 +static av_always_inline uint32_t hevc_mem_bits32(const void * buf, const unsigned int offset) +{ +

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread James Almer
On 1/19/2016 2:05 PM, John Cox wrote: >> On 1/19/2016 9:46 AM, John Cox wrote: >>> +// Helper fns >>> +#ifndef hevc_mem_bits32 >>> +static av_always_inline uint32_t hevc_mem_bits32(const void * buf, const >>> unsigned int offset) >>> +{ >>> +return AV_RB32((const uint8_t *)buf + (offset >> 3))

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread John Cox
>On 1/19/2016 9:46 AM, John Cox wrote: >> +// Helper fns >> +#ifndef hevc_mem_bits32 >> +static av_always_inline uint32_t hevc_mem_bits32(const void * buf, const >> unsigned int offset) >> +{ >> +return AV_RB32((const uint8_t *)buf + (offset >> 3)) << (offset & 7); >> +} >> +#endif >> + >> +#i

Re: [FFmpeg-devel] libavformat/tcp.c : add send_buffer_size and recv_buffer_size options

2016-01-19 Thread Michael Niedermayer
On Fri, Jan 15, 2016 at 10:16:45PM -0500, Perette Barella wrote: > On 2016年01月15日, at 18:42, Michael Niedermayer wrote: > > no, theres no patch > > > Trying again, including it inline below: > > --- tcp.c 2015-12-19 21:07:51.0 -0500 > +++ /Users/perette/Desktop/tcp.c 2016-01-15

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread James Almer
On 1/19/2016 9:46 AM, John Cox wrote: > +// Helper fns > +#ifndef hevc_mem_bits32 > +static av_always_inline uint32_t hevc_mem_bits32(const void * buf, const > unsigned int offset) > +{ > +return AV_RB32((const uint8_t *)buf + (offset >> 3)) << (offset & 7); > +} > +#endif > + > +#if AV_GCC_VE

Re: [FFmpeg-devel] [PATCH] checkasm: add fixed_dsp tests

2016-01-19 Thread Ronald S. Bultje
Hi, On Tue, Jan 19, 2016 at 11:43 AM, James Almer wrote: > +report("vector_fmul_add"); grep suggests you may be able to do report("%s", name); to get the _reverse suffix as appropriate. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread John Cox
>John Cox kynesim.co.uk> writes: > >> On Tue, 19 Jan 2016 15:59:39 + (UTC), you wrote: >> >> >John Cox kynesim.co.uk> writes: >> > >> >> >> +#define UNCHECKED_BITSTREAM_READER 1 >> >> > >> >> >I don't think that's right, and is a security issue. >> >> >> >> I added that line as (nearly) eve

[FFmpeg-devel] [PATCH] checkasm: add fixed_dsp tests

2016-01-19 Thread James Almer
Signed-off-by: James Almer --- tests/checkasm/Makefile| 3 + tests/checkasm/checkasm.c | 3 + tests/checkasm/checkasm.h | 1 + tests/checkasm/fixed_dsp.c | 184 + 4 files changed, 191 insertions(+) create mode 100644 tests/checkasm/fixed_ds

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread Carl Eugen Hoyos
John Cox kynesim.co.uk> writes: > On Tue, 19 Jan 2016 15:59:39 + (UTC), you wrote: > > >John Cox kynesim.co.uk> writes: > > > >> >> +#define UNCHECKED_BITSTREAM_READER 1 > >> > > >> >I don't think that's right, and is a security issue. > >> > >> I added that line as (nearly) every other de

Re: [FFmpeg-devel] [PATCH] avformat/hls: Require the file extension to be m3u / m3u8 for probing to succeed

2016-01-19 Thread Michael Niedermayer
On Sat, Jan 16, 2016 at 05:28:34PM +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > If the filename isnt set by the user application then the code behaves like > before > > Signed-off-by: Michael Niedermayer > --- > libavformat/hls.c |4 > 1 file changed, 4 insertion

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread John Cox
On Tue, 19 Jan 2016 15:59:39 + (UTC), you wrote: >John Cox kynesim.co.uk> writes: > >> >> +#define UNCHECKED_BITSTREAM_READER 1 >> > >> >I don't think that's right, and is a security issue. >> >> I added that line as (nearly) every other decoder in >> liavcodec has it - > >Sure? OK - not a

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread Carl Eugen Hoyos
John Cox kynesim.co.uk> writes: > >> +#define UNCHECKED_BITSTREAM_READER 1 > > > >I don't think that's right, and is a security issue. > > I added that line as (nearly) every other decoder in > liavcodec has it - Sure? > in particular h264_cabac.c has it. Extensive testing was done before it

Re: [FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread Carl Eugen Hoyos
Bodecs Bela vivanet.hu> writes: > To retain the current behaviour and not to break any > earlier app, a new config parameter has been introduced. Is the current behaviour useful or do you consider it a bug? Carl Eugen ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH] libavutil: add mastering display metadata sidedata

2016-01-19 Thread Michael Niedermayer
On Tue, Jan 19, 2016 at 01:34:12PM +0100, wm4 wrote: > On Tue, 19 Jan 2016 13:02:25 +0100 > Michael Niedermayer wrote: > > > On Tue, Jan 19, 2016 at 10:18:16AM +0100, wm4 wrote: > > > On Tue, 19 Jan 2016 00:32:43 +0100 > > > Michael Niedermayer wrote: > > > > > > > On Sat, Jan 16, 2016 at 04:

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread John Cox
Hi >On Tue, Jan 19, 2016 at 7:46 AM, John Cox wrote: > >> Hi >> >> I've just done a fair bit of work on hevc_cabac decode for the Rasberry >> Pi2 and I think that the patch is generally applicable. Patch is >> attached but you may prefer to take it from git: > > >Cool! Two non-technical comments

[FFmpeg-devel] [PATCH] vf_scale: Detecting changes of incoming frame properties and dinamically evaluate width and height expressions

2016-01-19 Thread Bodecs Bela
Hi All, currently scale video filter accepts expressions in its width and height parameters but evaluates them only once at init and replaces them with their actual values. Later on, if any parameter of incoming frames changes - ie those were used in the original size expressions - then they new

[FFmpeg-devel] [PATCH] doc/demuxers: add some concat demuxer script examples

2016-01-19 Thread Tobias Rapp
Attached patch adds some example scripts for the concat demuxer to the documentation. Regards, Tobias >From 5ffc11e8139476d18cd2eaa28338adb0dda80999 Mon Sep 17 00:00:00 2001 From: Tobias Rapp Date: Tue, 19 Jan 2016 15:42:33 +0100 Subject: [PATCH] doc/demuxers: add some concat demuxer script exa

Re: [FFmpeg-devel] [PATCH v3 5/5] libavfilter: VAAPI surface converter

2016-01-19 Thread Mark Thompson
On 19/01/16 12:27, wm4 wrote: > On Mon, 18 Jan 2016 22:53:33 + > Mark Thompson wrote: > >> --- >> configure | 1 + >> libavfilter/Makefile| 1 + >> libavfilter/allfilters.c| 1 + >> libavfilter/vf_vaapi_conv.c | 480 >>

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread Mats Peterson
On 01/19/2016 03:05 PM, Mats Peterson wrote: from "normal" indentations of 4 columns. But I'll try to stick to what's stick with ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread Mats Peterson
On 01/19/2016 02:51 PM, Ronald S. Bultje wrote: What I did in vp8 (if I remember correctly) in those cases is to split the top line: static av_always_inline long_return_type_name far_too_long_function_name(type arg1, type arg2, type arg3, type arg4) { .. } May b

Re: [FFmpeg-devel] [PATCH v3 2/5] ffmpeg: initialisation code for VAAPI, hwaccel helper

2016-01-19 Thread Mark Thompson
On 19/01/16 12:16, wm4 wrote: > On Mon, 18 Jan 2016 22:50:50 + > Mark Thompson wrote: > >> --- >> Makefile | 1 + >> ffmpeg.c | 5 + >> ffmpeg.h | 5 + >> ffmpeg_opt.c | 14 ++ >> ffmpeg_vaapi.c | 622 >> + >>

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread Ronald S. Bultje
Hi, On Tue, Jan 19, 2016 at 8:42 AM, Mats Peterson < matsp888-at-yahoo@ffmpeg.org> wrote: > On 01/19/2016 02:40 PM, Ronald S. Bultje wrote: > >> We tend to indent the second line so it aligns with the opening bracket of >> the first line. >> > > Excuse me if i chime in here, Ronald, yes, I'v

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread Mats Peterson
On 01/19/2016 02:40 PM, Ronald S. Bultje wrote: We tend to indent the second line so it aligns with the opening bracket of the first line. Excuse me if i chime in here, Ronald, yes, I've noticed that as well. However, sometimes it can be quite awkward to do this alignment when having a lot o

Re: [FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread Ronald S. Bultje
Hi, On Tue, Jan 19, 2016 at 7:46 AM, John Cox wrote: > Hi > > I've just done a fair bit of work on hevc_cabac decode for the Rasberry > Pi2 and I think that the patch is generally applicable. Patch is > attached but you may prefer to take it from git: Cool! Two non-technical comments first, I

Re: [FFmpeg-devel] [PATCH v3 1/5] libavutil: some VAAPI infrastructure

2016-01-19 Thread Mark Thompson
On 19/01/16 11:54, wm4 wrote: > On Mon, 18 Jan 2016 22:49:51 + > Mark Thompson wrote: > >> --- >> configure | 4 + >> libavutil/Makefile | 1 + >> libavutil/vaapi.c | 497 >> + >> libavutil/vaapi.h | 123 + >> 4

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Use AV_PIX_FMT_PAL8 for 1-bit raw AVI video

2016-01-19 Thread Mats Peterson
On 01/19/2016 01:51 PM, Mats Peterson wrote: This one will probably cause Michael to oppose, but I think it should be implemented as well. As long as we don't have a "pal1" pixel format, we'll have to use the somewhat redundant pal8. Below are two sample AVI files, one without a palette, and one

[FFmpeg-devel] [PATCH] lavc/rawdec: Use AV_PIX_FMT_PAL8 for 1-bit raw AVI video

2016-01-19 Thread Mats Peterson
This one will probably cause Michael to oppose, but I think it should be implemented as well. As long as we don't have a "pal1" pixel format, we'll have to use the somewhat redundant pal8. Below are two sample AVI files, one without a palette, and one with a blue palette. No palette (black & wh

[FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

2016-01-19 Thread John Cox
Hi I've just done a fair bit of work on hevc_cabac decode for the Rasberry Pi2 and I think that the patch is generally applicable. Patch is attached but you may prefer to take it from git: https://github.com/jc-kynesim/rpi-ffmpeg.git branch: test/ff_hevc_cabac_3 commit: 423e160e639d301feb2b4ba22

Re: [FFmpeg-devel] [PATCH] libavutil: add mastering display metadata sidedata

2016-01-19 Thread wm4
On Tue, 19 Jan 2016 13:02:25 +0100 Michael Niedermayer wrote: > On Tue, Jan 19, 2016 at 10:18:16AM +0100, wm4 wrote: > > On Tue, 19 Jan 2016 00:32:43 +0100 > > Michael Niedermayer wrote: > > > > > On Sat, Jan 16, 2016 at 04:19:38PM -0800, Neil Birkbeck wrote: > > > > Adding mastering displa

Re: [FFmpeg-devel] [PATCH v3 5/5] libavfilter: VAAPI surface converter

2016-01-19 Thread wm4
On Mon, 18 Jan 2016 22:53:33 + Mark Thompson wrote: > --- > configure | 1 + > libavfilter/Makefile| 1 + > libavfilter/allfilters.c| 1 + > libavfilter/vf_vaapi_conv.c | 480 > > 4 files changed, 483 insertion

Re: [FFmpeg-devel] [PATCH v3 2/5] ffmpeg: initialisation code for VAAPI, hwaccel helper

2016-01-19 Thread wm4
On Mon, 18 Jan 2016 22:50:50 + Mark Thompson wrote: > --- > Makefile | 1 + > ffmpeg.c | 5 + > ffmpeg.h | 5 + > ffmpeg_opt.c | 14 ++ > ffmpeg_vaapi.c | 622 > + > 5 files changed, 647 insertions(+) > crea

Re: [FFmpeg-devel] [PATCH] libavutil: add mastering display metadata sidedata

2016-01-19 Thread Michael Niedermayer
On Tue, Jan 19, 2016 at 10:18:16AM +0100, wm4 wrote: > On Tue, 19 Jan 2016 00:32:43 +0100 > Michael Niedermayer wrote: > > > On Sat, Jan 16, 2016 at 04:19:38PM -0800, Neil Birkbeck wrote: > > > Adding mastering display metadata struct to avutil. The mastering display > > > metadata contains info

Re: [FFmpeg-devel] [PATCH v3 1/5] libavutil: some VAAPI infrastructure

2016-01-19 Thread wm4
On Mon, 18 Jan 2016 22:49:51 + Mark Thompson wrote: > --- > configure | 4 + > libavutil/Makefile | 1 + > libavutil/vaapi.c | 497 > + > libavutil/vaapi.h | 123 + > 4 files changed, 625 insertions(+) > create

Re: [FFmpeg-devel] [PATCH] libkvazaar: Set frame rate as a rational number

2016-01-19 Thread Arttu Ylä-Outinen
On 2016-01-18 15:46, Nicolas George wrote: EOVERFLOW does not exist on some windows versions. IIRC, we usually use EINVAL in this kind of case. Thanks. I'll change that to EINVAL and apply the patch tomorrow if there are no other issues. - Arttu

Re: [FFmpeg-devel] [PATCH]lavc/h264: Show "Increasing reorder buffer" message with loglevel info

2016-01-19 Thread Michael Niedermayer
On Tue, Jan 19, 2016 at 11:01:40AM +0100, Carl Eugen Hoyos wrote: > Hi! > > The message "Increasing reorder buffer" when decoding h264 seems quite > important to me, it should be shown by default imo (or as a warning). > See also ticket #5138. > > Please comment, Carl Eugen > h264.c |2 +-

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Fix incorrect palettes

2016-01-19 Thread Mats Peterson
On 01/19/2016 11:19 AM, Michael Niedermayer wrote: applied thanks Thank you. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Fix incorrect palettes

2016-01-19 Thread Michael Niedermayer
On Tue, Jan 19, 2016 at 03:40:14AM +0100, Mats Peterson wrote: > Minor changes. > > Mats > qtpalette.h | 34 ++ > 1 file changed, 18 insertions(+), 16 deletions(-) > 10d99683bb90fc71b959edc02f375222d0e12e48 > 0001-lavf-qtpalette-Fix-incorrect-palettes.patch >

Re: [FFmpeg-devel] [PATCH]lavc/mjpegdec: Only set SAR if resolution is available

2016-01-19 Thread Michael Niedermayer
On Tue, Jan 19, 2016 at 09:16:26AM +0100, Carl Eugen Hoyos wrote: > On Tuesday 19 January 2016 02:09:06 am Michael Niedermayer wrote: > > On Tue, Jan 19, 2016 at 12:33:40AM +0100, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes ticket #4479 here. > > > > > > Please comment, Carl

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Fix incorrect palettes

2016-01-19 Thread Mats Peterson
On 01/19/2016 03:40 AM, Mats Peterson wrote: Minor changes. Sample 1-frame clip with all 16 colors in the default 4 bpp palette. The display in QuickTime in Windows/Mac and FFmpeg should be identical after the patch has been applied. https://drive.google.com/open?id=0B3_pEBoLs0fad2VyRE5Pdn

Re: [FFmpeg-devel] [PATCH] checkasm: add fixed_dsp tests

2016-01-19 Thread Michael Niedermayer
On Tue, Jan 19, 2016 at 02:01:58AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/checkasm/Makefile| 3 + > tests/checkasm/checkasm.c | 3 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/fixed_dsp.c | 169 > + >

Re: [FFmpeg-devel] [PATCH]ape: Show more information for loglevel verbose

2016-01-19 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > > Please comment, Carl Eugen > > > > ok Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH]lavc/h264: Show "Increasing reorder buffer" message with loglevel info

2016-01-19 Thread Carl Eugen Hoyos
Hi! The message "Increasing reorder buffer" when decoding h264 seems quite important to me, it should be shown by default imo (or as a warning). See also ticket #5138. Please comment, Carl Eugen diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 545ac14..2361660 100644 --- a/libavcodec/h26

Re: [FFmpeg-devel] [PATCH]ape: Show more information for loglevel verbose

2016-01-19 Thread Paul B Mahol
On 1/19/16, Carl Eugen Hoyos wrote: > Hi! > > As requested by user Andy E. > > Please comment, Carl Eugen > ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH]ape: Show more information for loglevel verbose

2016-01-19 Thread Carl Eugen Hoyos
Hi! As requested by user Andy E. Please comment, Carl Eugen diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index a528e60..bed9a96 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -247,7 +247,7 @@ static av_cold int ape_decode_init(AVCodecContext *avctx) s->compression_le

Re: [FFmpeg-devel] [PATCH] libavutil: add mastering display metadata sidedata

2016-01-19 Thread wm4
On Tue, 19 Jan 2016 00:32:43 +0100 Michael Niedermayer wrote: > On Sat, Jan 16, 2016 at 04:19:38PM -0800, Neil Birkbeck wrote: > > Adding mastering display metadata struct to avutil. The mastering display > > metadata contains information > > about the mastering display color volume (SMPTE 2086

Re: [FFmpeg-devel] [PATCH]lavc/x264: Improve level setting

2016-01-19 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Nicolas George nsup.org> writes: > > > Le nonidi 29 nivôse, an CCXXIV, Carl Eugen Hoyos a écrit : > > > The original patch (that does not care about tail > > > since it can't be reached anyway) uses atoi(). > > > Is that not ok? > > > > atoi() has undefine

Re: [FFmpeg-devel] [PATCH]lavc/mjpegdec: Only set SAR if resolution is available

2016-01-19 Thread Carl Eugen Hoyos
On Tuesday 19 January 2016 02:09:06 am Michael Niedermayer wrote: > On Tue, Jan 19, 2016 at 12:33:40AM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #4479 here. > > > > Please comment, Carl Eugen > > if w/h is set at that point then their values may be unrelated to the