Re: [FFmpeg-devel] Build failure un Debian Testing

On Fri, Jul 14, 2023 at 10:47 AM James Almer wrote: > > On 7/14/2023 1:49 PM, James Zern wrote: > > On Fri, Jul 14, 2023 at 5:37 AM James Almer wrote: > >> > >> On 7/14/2023 7:12 AM, Nicolas George wrote: > >>> James Almer (12023-07-13): > Curious that they pull git snapshots of this

Re: [FFmpeg-devel] [PATCH] lavc/audiotoolbox: fix build failure on osx 10.5

On 7/11/2023 11:10 AM, Pavel Koshevoy wrote: --- libavcodec/audiotoolboxdec.c | 2 ++ libavcodec/audiotoolboxenc.c | 4 2 files changed, 6 insertions(+) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c index 82babe3d31..7b33cdf87d 100644 ---

Re: [FFmpeg-devel] [PATCH] lavc/audiotoolbox: fix build failure on osx 10.5

ping ... could someone review this please On Tue, Jul 11, 2023 at 8:10 AM Pavel Koshevoy wrote: > --- > libavcodec/audiotoolboxdec.c | 2 ++ > libavcodec/audiotoolboxenc.c | 4 > 2 files changed, 6 insertions(+) > > diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c

Re: [FFmpeg-devel] [PATCH v2 01/14] vvcdec: add thread executor

On Fri, Jul 07, 2023 at 10:05:27PM +0800, Nuo Mi wrote: > The executor design pattern was inroduced by java > > it also adapted by python >

[FFmpeg-devel] [PATCH] lavu/fixed_dsp: unroll RISC-V V loop

Before: butterflies_fixed_c: 804.7 butterflies_fixed_rvv_i32: 348.2 After: butterflies_fixed_rvv_i32: 308.7 --- libavutil/riscv/fixed_dsp_rvv.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/riscv/fixed_dsp_rvv.S b/libavutil/riscv/fixed_dsp_rvv.S index

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: use av_random_bytes() for generating AES128 key

On Thu, 6 Jul 2023, Marton Balint wrote: av_random_bytes() can use OS provided strong random functions and does not depend soley on openssl/gcrypt external libraries. Fixes ticket #10441. Will apply. Regards, Marton Signed-off-by: Marton Balint --- configure| 1 -

Re: [FFmpeg-devel] [PATCH] avutil/random_seed: turn off buffering when reading from urandom

On Sun, 9 Jul 2023, Marton Balint wrote: Signed-off-by: Marton Balint --- libavutil/random_seed.c | 1 + 1 file changed, 1 insertion(+ Will apply. Regards, Marton diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c index f167b172f2..6d399cee49 100644 ---

[FFmpeg-devel] [PATCH] checkasm: print usage on invalid arguments

This checks that arguments are handled. If not, then this prints a short usage notice and returns an error. --- tests/checkasm/checkasm.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c

[FFmpeg-devel] [PATCH 6/7] checkasm: allow run-time fallback to AV_READ_TIME

On Linux RISC-V, depending on kernel version and configuration, the cycle counters may be available: - via Linux perf (as on Arm), - directly with RDCYCLE (which is considered legacy), - neither (if admistratively disabled), or - or both (in legacy compatibility mode). This allows to try Linux

[FFmpeg-devel] [PATCH 7/7] configure: enable Linux perf on RISC-V by default

Now that checkasm can automatically fall back to RDCYCLE, it is safe to enable this for forward compatibility with kernel versions mitigating the "Cycle Drift" side channel attack. Where available, this should also reduce measurement noise, since kernel and hypervisor cycles should no longer be

[FFmpeg-devel] [PATCH 5/7] checkasm: remove unused variable

--- tests/checkasm/checkasm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 4b6164301a..c3075fe37c 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -524,7 +524,6 @@ static int measure_nop_time(void) {

[FFmpeg-devel] [PATCH 4/7] checkasm: use pointers for start/stop functions

This makes all calls to the bench start and stop functions via function pointers. While the primary goal is to support run-time selection of the performance measurement back-end in later commits, this has the side benefit of containing platform dependencies in to checkasm.c and out of checkasm.h.

[FFmpeg-devel] [PATCH 3/7] checkasm: make perf macros functional

This converts the bench/perf start/stop macros into functional macros, and for that to work, take the Linux perf code out of line. --- tests/checkasm/checkasm.c | 24 tests/checkasm/checkasm.h | 36 +--- 2 files changed, 33 insertions(+),

[FFmpeg-devel] [PATCH 2/7] checkasm: improve Linux perf error message

Report the failing system call name, as is convention, rather than just a rather unhelpful "syscall". --- tests/checkasm/checkasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 1da0877be5..bfc0a48079 100644 ---

[FFmpeg-devel] [PATCH 1/7] checkasm: fix Linux perf cleanup

0 is a valid file descriptor. --- tests/checkasm/checkasm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 4311a8ffcb..1da0877be5 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -317,7

[FFmpeg-devel] git email hook

Hi all I today added and tested git-multimail to git.ffmpeg.org as our git mail sending script is old and unmaintained I intend to use libavradio for testing it, this will result in different looking mails for avradio. (probably on the next push in a day or 2) If that goes well i intend to

[FFmpeg-devel] [PATCH 0/7] checkasm RISC-V Linux perf enablement

Hello, This enables use of Linux perf without breaking RISC-V Linux kernel versions that don't support it. Rémi Denis-Courmont (7): checkasm: fix Linux perf cleanup checkasm: improve Linux perf error message

[FFmpeg-devel] [PATCH] avcodec/decode: factor out filling frame props

Signed-off-by: James Almer --- libavcodec/decode.c | 67 - 1 file changed, 23 insertions(+), 44 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 68525e47a6..51216988a6 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c

Re: [FFmpeg-devel] [PATCH 2/2] aarch64: remove VFP feature check

On Fri, 14 Jul 2023, Rémi Denis-Courmont wrote: This is not actually used for anything. The configure check causes the CPU feature flag to be set, but nothing consumes it at all. While AArch64 does have VFP, it is only used for the scalar C code. Conversely, it is still possible to disable

Re: [FFmpeg-devel] [PATCH 16/33] fftools/ffmpeg_mux_init: improve of_add_programs()

On Fri, Jul 14, 2023 at 11:07:19AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-14 01:30:24) > > On Thu, Jul 13, 2023 at 12:55:36PM +0200, Anton Khirnov wrote: > > > Replace duplicated(!) and broken* custom string parsing with > > > av_dict_parse_string(). Return error codes

[FFmpeg-devel] [PATCH 2/2] avradio/sdrdemux: Some corrections to the FM stereo side channel

Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 041775730e..5a6a9b8894 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -656,7 +656,7 @@

[FFmpeg-devel] [PATCH 1/2] avradio/sdrdemux: avoid repeated litteral number

Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index d40b92dd24..041775730e 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -57,6

Re: [FFmpeg-devel] Build failure un Debian Testing

On 7/14/2023 1:49 PM, James Zern wrote: On Fri, Jul 14, 2023 at 5:37 AM James Almer wrote: On 7/14/2023 7:12 AM, Nicolas George wrote: James Almer (12023-07-13): Curious that they pull git snapshots of this package for Debian testing. For others they seem to stick to tagged releases. I do

Re: [FFmpeg-devel] [PATCH 25/33] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

Quoting Michael Niedermayer (2023-07-14 17:47:19) > On Fri, Jul 14, 2023 at 11:44:07AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-07-14 01:11:07) > > > On Thu, Jul 13, 2023 at 12:55:45PM +0200, Anton Khirnov wrote: > > > > When the user explicitly specifies a pixel format

Re: [FFmpeg-devel] [PATCH v4 1/4] avcodec/decode: move processing discard samples to its own function

On 7/12/2023 7:07 PM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/decode.c | 269 +++- 1 file changed, 141 insertions(+), 128 deletions(-) Patchset applied. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

On Thu, Jul 13, 2023 at 12:38 PM James Zern wrote: > > On Fri, Jul 7, 2023 at 2:31 PM David Lemler wrote: > > > > Prevent the fifo used in encoding VPx videos from filling up and > > stopping encode when it reaches 21845 items, which happens when the > > video has more than that number of

Re: [FFmpeg-devel] Build failure un Debian Testing

On Fri, Jul 14, 2023 at 5:37 AM James Almer wrote: > > On 7/14/2023 7:12 AM, Nicolas George wrote: > > James Almer (12023-07-13): > >> Curious that they pull git snapshots of this package for Debian testing. > >> For > >> others they seem to stick to tagged releases. > > > > I do not understand

[FFmpeg-devel] [PATCH 2/2] aarch64: remove VFP feature check

This is not actually used for anything. The configure check causes the CPU feature flag to be set, but nothing consumes it at all. While AArch64 does have VFP, it is only used for the scalar C code. Conversely, it is still possible to disable VFP, by changing the C compiler flags as before

[FFmpeg-devel] [PATCH 1/2] lavc/aarch64: remove bogus HAVE_VFP guard

The IMDCT offset is only relevant for NEON optimisations. There are no VFP optimisations here that would justify the HAVE_VFP flag. In practice, this makes no difference because HAVE_NEON is practically always true for standard Armv8 platforms. --- libavcodec/aarch64/synth_filter_init.c | 2 +- 1

[FFmpeg-devel] [PATCH] lavc/audiodsp: fix aliasing violation

Even though they have the same size, and typically the same alignment, uint32_t and float are under no circumstances compatible types in C. The casts from float * to uint32_t * are invalid here. Insofar as the resulting pointers are dereferenced, this is undefined behaviour. This patch uses

[FFmpeg-devel] [PATCH] lavc/aacpsdsp: use restrict qualifier

Except for add_squares, telling the compiler that the output vector(s) cannot alias helps quite a bit (cycles on SiFive U74-MC): ps_add_squares_c: 98277.7 ps_add_squares_r: 98320.2 ps_hybrid_analysis_c: 3731.2 ps_hybrid_analysis_r: 2495.7 ps_hybrid_analysis_ileave_c: 20478.0

Re: [FFmpeg-devel] [PATCH 25/33] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

On Fri, Jul 14, 2023 at 11:44:07AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-14 01:11:07) > > On Thu, Jul 13, 2023 at 12:55:45PM +0200, Anton Khirnov wrote: > > > When the user explicitly specifies a pixel format that is not supported > > > by the encoder, ffmpeg CLI will

Re: [FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

On 7/14/2023 11:57 AM, Kieran Kunhya wrote: On Fri, 14 Jul 2023 at 14:03, James Almer wrote: On 7/14/2023 9:59 AM, Kieran Kunhya wrote: +#if ARCH_X86_64 && HAVE_AVX512_EXTERNAL +if (EXTERNAL_AVX512(cpu_flags)) +c->yuv2planeX = yuv2yuvX_avx512; #endif You want

Re: [FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

On Fri, 14 Jul 2023 at 14:03, James Almer wrote: > On 7/14/2023 9:59 AM, Kieran Kunhya wrote: > >> +#if ARCH_X86_64 && HAVE_AVX512_EXTERNAL > >> +if (EXTERNAL_AVX512(cpu_flags)) > >> +c->yuv2planeX = yuv2yuvX_avx512; > >> #endif > >> > > > > You want EXTERNAL_AVX512ICL

Re: [FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

On 7/14/2023 9:59 AM, Kieran Kunhya wrote: +#if ARCH_X86_64 && HAVE_AVX512_EXTERNAL +if (EXTERNAL_AVX512(cpu_flags)) +c->yuv2planeX = yuv2yuvX_avx512; #endif You want EXTERNAL_AVX512ICL here. vpermt2q with zmm registers is avx512f and not any of the extensions, so

Re: [FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

> +#if ARCH_X86_64 && HAVE_AVX512_EXTERNAL > +if (EXTERNAL_AVX512(cpu_flags)) > +c->yuv2planeX = yuv2yuvX_avx512; > #endif > You want EXTERNAL_AVX512ICL here. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] Build failure un Debian Testing

On 7/14/2023 7:12 AM, Nicolas George wrote: James Almer (12023-07-13): Curious that they pull git snapshots of this package for Debian testing. For others they seem to stick to tagged releases. I do not understand what you mean. *I* pulled my work tree to the head to fix a bug in the OpenGL

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_dec: properly set output frames as keyframes

Should fix ticket #10426. Signed-off-by: James Almer --- libavcodec/mpegvideo_dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c index fcca147cd6..670b0912e2 100644 --- a/libavcodec/mpegvideo_dec.c +++

[FFmpeg-devel] [PATCH] lavfi/vf_libplacebo: test for renderable pixel formats

From: Niklas Haas Requires a new upstream function to test not for *import* support on a given output pixel format, but also whether we can render to it. Fixes: https://github.com/haasn/libplacebo/issues/173 --- libavfilter/vf_libplacebo.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH 25/33] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

On 14/07/2023 11:44, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-07-14 01:11:07) On Thu, Jul 13, 2023 at 12:55:45PM +0200, Anton Khirnov wrote: When the user explicitly specifies a pixel format that is not supported by the encoder, ffmpeg CLI will currently use some heuristics to

Re: [FFmpeg-devel] Build failure un Debian Testing

James Almer (12023-07-13): > Curious that they pull git snapshots of this package for Debian testing. For > others they seem to stick to tagged releases. I do not understand what you mean. *I* pulled my work tree to the head to fix a bug in the OpenGL device, it was the first time since Testing

[FFmpeg-devel] [PATCH 3/3] swscale/x86/yuv2yuvX: Process tails by jumping back into the main loop.

--- libswscale/x86/swscale.c| 11 --- libswscale/x86/yuv2yuvX.asm | 12 ++-- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 52423a1199..71434f58d3 100644 --- a/libswscale/x86/swscale.c +++

[FFmpeg-devel] [PATCH 2/3] swscale/x86/yuv2yuvX: Add yuv2yuvX avx512

--- libswscale/x86/swscale.c| 7 +++ libswscale/x86/yuv2yuvX.asm | 19 ++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 8c67bf4fab..52423a1199 100644 --- a/libswscale/x86/swscale.c +++

[FFmpeg-devel] [PATCH 1/3] swscale/x86/swscale: Process yuv2yuvX tails using next largest register size

--- libswscale/x86/swscale.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index ff16398988..8c67bf4fab 100644 --- a/libswscale/x86/swscale.c +++ b/libswscale/x86/swscale.c @@ -194,7 +194,7 @@ static void yuv2yuvX_

Re: [FFmpeg-devel] [PATCH 25/33] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

Quoting Michael Niedermayer (2023-07-14 01:11:07) > On Thu, Jul 13, 2023 at 12:55:45PM +0200, Anton Khirnov wrote: > > When the user explicitly specifies a pixel format that is not supported > > by the encoder, ffmpeg CLI will currently use some heuristics to pick > > another supported format.

Re: [FFmpeg-devel] [PATCH 5/5] lavc/aarch64: new optimization for 8-bit hevc_epel_uni_w_hv

On Thu, 13 Jul 2023, Logan.Lyu wrote: Hi, Martin, Thanks for your comments. I have now amended the unreasonable parts of ldp/stp that I have seen.  And I updated patch 3 and patch 5. (Although I have attached all 5 patches) In addition, I thought that q8-q15 was required to be saved

Re: [FFmpeg-devel] [PATCH 16/33] fftools/ffmpeg_mux_init: improve of_add_programs()

Quoting Michael Niedermayer (2023-07-14 01:30:24) > On Thu, Jul 13, 2023 at 12:55:36PM +0200, Anton Khirnov wrote: > > Replace duplicated(!) and broken* custom string parsing with > > av_dict_parse_string(). Return error codes instead of aborting. > > > > * e.g. it treats NULL returned from