Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-08-29 Thread Clément Bœsch
On Sat, Aug 01, 2015 at 01:31:16PM -0300, James Almer wrote: [...] Also, rc4 currently can't encrypt, only decrypt. No idea if adding encryption functionality will require changes to the struct. There is no distinction between encryption and decryption with RC4 -- Clément B.

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-08-29 Thread Michael Niedermayer
On Sat, Aug 29, 2015 at 02:54:06AM -0300, James Almer wrote: On 8/1/2015 1:31 PM, James Almer wrote: On 01/08/15 7:15 AM, Nicolas George wrote: Le quartidi 14 thermidor, an CCXXIII, Reimar Döffinger a écrit : If the goal is consistency, wouldn't an API like av_hash be the better solution?

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-08-29 Thread James Almer
On 8/29/2015 8:56 AM, Michael Niedermayer wrote: On Sat, Aug 29, 2015 at 02:54:06AM -0300, James Almer wrote: On 8/1/2015 1:31 PM, James Almer wrote: On 01/08/15 7:15 AM, Nicolas George wrote: Le quartidi 14 thermidor, an CCXXIII, Reimar Döffinger a écrit : If the goal is consistency,

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-08-28 Thread James Almer
On 8/1/2015 1:31 PM, James Almer wrote: On 01/08/15 7:15 AM, Nicolas George wrote: Le quartidi 14 thermidor, an CCXXIII, Reimar Döffinger a écrit : If the goal is consistency, wouldn't an API like av_hash be the better solution? Hear, hear! (Actually, when reading that discussion for the

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-08-01 Thread Reimar Döffinger
On 31.07.2015, at 19:18, James Almer jamr...@gmail.com wrote: Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 3 +++ libavutil/blowfish.c | 15 +++ libavutil/blowfish.h | 10 ++ libavutil/version.h | 5 - 4 files changed, 32 insertions(+), 1

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-08-01 Thread James Almer
On 01/08/15 1:31 PM, James Almer wrote: Also, rc4 currently can't encrypt, only decrypt. No idea if adding encryption functionality will require changes to the struct. Whoops. Apparently that's not the case. Next time I'll read how a given algorithm works before commenting on an implementation.

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-08-01 Thread James Almer
On 01/08/15 7:15 AM, Nicolas George wrote: Le quartidi 14 thermidor, an CCXXIII, Reimar Döffinger a écrit : If the goal is consistency, wouldn't an API like av_hash be the better solution? Hear, hear! (Actually, when reading that discussion for the first time, I had not noticed it was

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-08-01 Thread Nicolas George
Le quartidi 14 thermidor, an CCXXIII, Reimar Döffinger a écrit : If the goal is consistency, wouldn't an API like av_hash be the better solution? Hear, hear! (Actually, when reading that discussion for the first time, I had not noticed it was about ciphers and not hashes, and my first reaction

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-07-31 Thread Michael Niedermayer
On Fri, Jul 31, 2015 at 05:58:48PM -0300, James Almer wrote: On 31/07/15 5:40 PM, Michael Niedermayer wrote: On Fri, Jul 31, 2015 at 02:18:07PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 3 +++ libavutil/blowfish.c | 15

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-07-31 Thread James Almer
On 31/07/15 3:33 PM, Paul B Mahol wrote: For what is this useful? So these four modules are consistent with the rest of the crypto modules. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-07-31 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 3 +++ libavutil/blowfish.c | 15 +++ libavutil/blowfish.h | 10 ++ libavutil/version.h | 5 - 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-07-31 Thread Michael Niedermayer
On Fri, Jul 31, 2015 at 02:18:07PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 3 +++ libavutil/blowfish.c | 15 +++ libavutil/blowfish.h | 10 ++ libavutil/version.h | 5 - 4 files changed, 32 insertions(+),

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-07-31 Thread James Almer
On 31/07/15 5:40 PM, Michael Niedermayer wrote: On Fri, Jul 31, 2015 at 02:18:07PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 3 +++ libavutil/blowfish.c | 15 +++ libavutil/blowfish.h | 10 ++ libavutil/version.h

Re: [FFmpeg-devel] [PATCH 1/4] blowfish: add av_blowfish_alloc()

2015-07-31 Thread James Almer
On 31/07/15 11:09 PM, Michael Niedermayer wrote: On Fri, Jul 31, 2015 at 05:58:48PM -0300, James Almer wrote: On 31/07/15 5:40 PM, Michael Niedermayer wrote: On Fri, Jul 31, 2015 at 02:18:07PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges |