Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-27 4:24 GMT+01:00 James Almer : > On 11/27/2017 12:17 AM, Carl Eugen Hoyos wrote: >> That's completely apart from the fact that this header file does >> not comply with any style guide while Nvidia's does (from a >> very quick look at both files). > > That would be

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 11/27/2017 12:17 AM, Carl Eugen Hoyos wrote: > 2017-11-27 4:00 GMT+01:00 James Almer : >> On 11/26/2017 11:57 PM, Carl Eugen Hoyos wrote: >>> 2017-11-27 3:42 GMT+01:00 James Almer : >>> No comments about the code, but given this patchset has started a

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: November 26, 2017 10:20 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-27 4:06 GMT+01:00 Mironov, Mikhail : > I think as a side affect we can help integrate Vulkan acceleration to FFmpeg. > It is much better then OpenCL for multimedia from performance perspective. Why did I so strongly expect this argument? (I have neither ever used

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-27 4:00 GMT+01:00 James Almer : > On 11/26/2017 11:57 PM, Carl Eugen Hoyos wrote: >> 2017-11-27 3:42 GMT+01:00 James Almer : >> >>> No comments about the code, but given this patchset has started a policy >>> controversy I'll state I'm in favor of

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: November 26, 2017 9:57 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-27 3:48 GMT+01:00 Philip Langdale : [...] Unrelated to this topic: Please cut your quotes, I believe this is not the first message where your content is very difficult to find. Thank you, Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 11/26/2017 11:57 PM, Carl Eugen Hoyos wrote: > 2017-11-27 3:42 GMT+01:00 James Almer : > >> No comments about the code, but given this patchset has started a policy >> controversy I'll state I'm in favor of including this external header. > > Will the header work for

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-27 3:42 GMT+01:00 James Almer : > No comments about the code, but given this patchset has started a policy > controversy I'll state I'm in favor of including this external header. Will the header work for operating systems other than Windows? Carl Eugen

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 11/26/2017 11:36 PM, mmironov wrote: > From 21d99252fad543d3d27a015912c0458b6ae11e08 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Tue, 14 Nov 2017 17:54:24 -0500 > Subject: [PATCH] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF > SDK > >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> > A few minor fixups below. I would be happy to apply this if it didn't contain > the external header. > > Thanks, > > - Mark > > I will resubmit the changes you mentioned. As of header inclusion issue I've sent a separate email. Thanks, Mikhail

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 22/11/17 23:28, mmironov wrote: > From c669277afd764903d3da09d92a263d0fb58e24b1 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Tue, 14 Nov 2017 17:54:24 -0500 > Subject: [PATCH] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF > SDK > > Signed-off-by:

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-23 2:15 GMT+01:00 Marton Balint : > All your points apply to Nvidia external headers as well The Nvidia driver works on Linux where self-compilation is at least not unusual. Self compiled binaries by Windows users are very rare, the one script that is typically used in

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-22 23:36 GMT+01:00 Timo Rothenpieler : > Also, I don't see a problem with including this AMD header. It very much > increases the accessibility and maintainability > (no need to watch out for potential breaking upstream changes, however > likely that might be). If

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Wed, 22 Nov 2017, Mark Thompson wrote: On 22/11/17 22:53, Philip Langdale wrote: On Wed, 22 Nov 2017 23:36:23 +0100 Timo Rothenpieler wrote: I'd like to look through it again and test a bit more (will try to do so tomorrow, certainly by the end of the week), but

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 22/11/17 22:53, Philip Langdale wrote: > On Wed, 22 Nov 2017 23:36:23 +0100 > Timo Rothenpieler wrote: > I'd like to look through it again and test a bit more (will try to do so tomorrow, certainly by the end of the week), but I think it should be ready

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Timo Rothenpieler > Sent: November 22, 2017 5:36 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs based on AMF SDK > > Am

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Wed, 22 Nov 2017 23:36:23 +0100 Timo Rothenpieler wrote: > >> I'd like to look through it again and test a bit more (will try to > >> do so tomorrow, certainly by the end of the week), but I think it > >> should be ready to commit with the external header removed. > >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

I'd like to look through it again and test a bit more (will try to do so tomorrow, certainly by the end of the week), but I think it should be ready to commit with the external header removed. Are you planning to remove Nvidia headers as well? No, I am very much against this. And others have

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

Am 17.11.2017 um 06:07 schrieb mmironov: From 454aad17fea28e8e4c5abb904341181271971bfc Mon Sep 17 00:00:00 2001 From: mmironov Date: Tue, 14 Nov 2017 17:54:24 -0500 Subject: [PATCH] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK Signed-off-by:

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

Am 17.11.2017 um 06:07 schrieb mmironov: From 454aad17fea28e8e4c5abb904341181271971bfc Mon Sep 17 00:00:00 2001 From: mmironov Date: Tue, 14 Nov 2017 17:54:24 -0500 Subject: [PATCH] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK Signed-off-by:

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: November 21, 2017 7:40 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs based on AMF SDK > > On 21/11/17

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 21/11/17 23:08, Timo Rothenpieler wrote: > Am 21.11.2017 um 16:32 schrieb Mironov, Mikhail: >> >> Are you all busy right now? Any hint on timing? >> Thanks, >> Mikhail > > I cannot test this patch due to lack of hardware, but by now the code has > been polished for a while, and if no further

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

Am 21.11.2017 um 16:32 schrieb Mironov, Mikhail: ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Are you all busy right now? Any hint on timing? Thanks, Mikhail I cannot test this patch due to lack of hardware, but by now the code has been

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Are you all busy right now? Any hint on timing? Thanks, Mikhail ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Tue, Nov 14, 2017 at 05:55:33PM -0500, mmironov wrote: > From 643006c4be514dd513232f7438b17add2a763685 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Tue, 14 Nov 2017 17:54:24 -0500 > Subject: [PATCH] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF > SDK

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: November 14, 2017 6:11 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs based on AMF SDK > > On 14/11/17

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 14/11/17 22:10, Mironov, Mikhail wrote: >> On 14/11/17 17:14, Mironov, Mikhail wrote: > +res = ctx->factory->pVtbl->CreateContext(ctx->factory, > + >>> context); > +AMF_RETURN_IF_FALSE(ctx, res == AMF_OK, AVERROR_UNKNOWN, "CreateContext()

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Hendrik Leppkes > Sent: November 14, 2017 5:32 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Tue, Nov 14, 2017 at 6:45 PM, Mark Thompson wrote: > > Decode via D3D11 does work for me on Windows 7 with both AMD and Intel; I > don't know anything about how, though. (I don't really care about Windows 7 > - this was just a set of parts mashed together into a working

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> On 14/11/17 17:14, Mironov, Mikhail wrote: > >>> +res = ctx->factory->pVtbl->CreateContext(ctx->factory, > >>> + > > context); > >>> +AMF_RETURN_IF_FALSE(ctx, res == AMF_OK, > >> AVERROR_UNKNOWN, > >> "CreateContext() failed with error %d\n", res); > >>> +//

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 13/11/17 23:09, mmironov wrote: > From d6f467ec7f610f21f929f9c21f03af3cabe84cf2 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Tue, 7 Nov 2017 10:57:21 -0500 > Subject: [PATCH] Added HW accelerated H.264 and HEVC encoding for AMD > > Signed-off-by: mmironov

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 14/11/17 17:14, Mironov, Mikhail wrote: >>> +res = ctx->factory->pVtbl->CreateContext(ctx->factory, > context); >>> +AMF_RETURN_IF_FALSE(ctx, res == AMF_OK, >> AVERROR_UNKNOWN, >> "CreateContext() failed with error %d\n", res); >>> +// try to reuse existing DX

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> > +res = ctx->factory->pVtbl->CreateContext(ctx->factory, > >>> context); > > +AMF_RETURN_IF_FALSE(ctx, res == AMF_OK, > AVERROR_UNKNOWN, > "CreateContext() failed with error %d\n", res); > > +// try to reuse existing DX device > > +if (avctx->hw_frames_ctx)

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 14/11/17 15:51, Mironov, Mikhail wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mark Thompson >> Sent: November 14, 2017 9:14 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mironov, Mikhail > Sent: November 14, 2017 10:51 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: November 14, 2017 9:14 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs based on AMF SDK > > On 13/11/17

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 13/11/17 23:00, Mironov, Mikhail wrote: >>> +res = ctx->factory->pVtbl->CreateContext(ctx->factory, >context); >>> +AMF_RETURN_IF_FALSE(ctx, res == AMF_OK, AVERROR_UNKNOWN, >> "CreateContext() failed with error %d\n", res); >>> +// try to reuse existing DX device >>> +if

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Mon, Nov 13, 2017 at 06:09:39PM -0500, mmironov wrote: > From d6f467ec7f610f21f929f9c21f03af3cabe84cf2 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Tue, 7 Nov 2017 10:57:21 -0500 > Subject: [PATCH] Added HW accelerated H.264 and HEVC encoding for AMD > >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> > +res = ctx->factory->pVtbl->CreateContext(ctx->factory, >context); > > +AMF_RETURN_IF_FALSE(ctx, res == AMF_OK, AVERROR_UNKNOWN, > "CreateContext() failed with error %d\n", res); > > +// try to reuse existing DX device > > +if (avctx->hw_frames_ctx) { > > +

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 05/11/17 03:49, Mikhail Mironov wrote: > From fc6a3f63eb9c3734f4101cee2a2f5707e063ab62 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Fri, 27 Oct 2017 13:03:15 -0400 > Subject: [PATCH] Added: HW accelerated H.264 and HEVC encoding for AMD GPUs > based on AMF SDK >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: November 8, 2017 10:15 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs based on AMF SDK > > On 06/11/17

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 06/11/17 22:46, Michael Niedermayer wrote: > ... > In file included from src/libavcodec/amfenc.h:24:0, > from src/libavcodec/amfenc.c:27: > src/compat/amd/amfsdkenc.h:191:23: error: no previous prototype for > ‘AMFConstructRect’ [-Werror=missing-prototypes] > AMF_INLINE

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Hendrik Leppkes > Sent: November 7, 2017 3:25 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Tue, Nov 7, 2017 at 12:28 AM, Mironov, Mikhail wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Michael Niedermayer >> Sent: November 6, 2017 5:47 PM >> To: FFmpeg development discussions and patches >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Tue, Nov 07, 2017 at 01:36:57AM +, Mironov, Mikhail wrote: > > > > theres no match for ID3D11VideoContext in my d3d11.h > > > my mingw stuff should be just the official packages from > > ubuntu LTS 14.04 > > Then how would you compile hwcontext_d3d11va.h where ID3D11DeviceContext and >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> theres no match for ID3D11VideoContext in my d3d11.h > my mingw stuff should be just the official packages from > ubuntu LTS 14.04 Then how would you compile hwcontext_d3d11va.h where ID3D11DeviceContext and ID3D11VideoDevice are used? Thanks, Mikhail

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Mon, Nov 06, 2017 at 11:28:38PM +, Mironov, Mikhail wrote: > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Michael Niedermayer > > Sent: November 6, 2017 5:47 PM > > To: FFmpeg development discussions and patches >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Sat, Nov 04, 2017 at 10:49:44PM -0500, Mikhail Mironov wrote: > From fc6a3f63eb9c3734f4101cee2a2f5707e063ab62 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Fri, 27 Oct 2017 13:03:15 -0400 > Subject: [PATCH] Added: HW accelerated H.264 and HEVC encoding for AMD GPUs

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Moritz Barsnick > Sent: November 5, 2017 2:11 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Sun, Nov 05, 2017 at 02:41:54 +, Mironov, Mikhail wrote: > > > +{ "quality","", 0, AV_OPT_TYPE_CONST, { .i64 = > > AMF_VIDEO_ENCODER_HEVC_QUALITY_PRESET_QUALITY }, 0, 0, VE, > > "quality" }, > > > > These are 0, 5, 10. Do the intermediate values work? Should they be > >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> > +// > > + > > +// Reduced AMF API > > +// > > +// Full version of AMF SDK and the latest version of this file > > +// can be found at https://github.com/GPUOpen-LibrariesAndSDKs/AMF > > On further consideration I am against including this header. Just ask the > user > to get it from this

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 31/10/17 19:39, mmironov wrote: > From 8640b995634f827eb39ae87bcbe2c1992d8140f2 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Fri, 27 Oct 2017 13:03:15 -0400 > Subject: [PATCH] Added: HW accelerated H.264 and HEVC encoding for AMD GPUs > based on AMF SDK > >

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of mmironov > Sent: October 31, 2017 3:39 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs > based on AMF SDK > > From

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Marton Balint > Sent: October 31, 2017 2:06 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Tue, 31 Oct 2017, Mironov, Mikhail wrote: [...] I see some confusion. The user can call send_frame/receive_packet in any order, and you can implement send_frame and receive_packet any way you want, the only thing you have to guarantee is that you cannot return EAGAIN for both send_frame

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> >>> +AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, > >> AMF_VIDEO_ENCODER_HEVC_DE_BLOCKING_FILTER_DISABLE, > >> deblocking_filter); > >> > >> What about SAO? > > > > SAO ??? > > You're looking at AV_CODEC_FLAG_LOOP_FILTER to disable this, so you > might want to consider both loop filters in

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Marton Balint > Sent: October 30, 2017 9:26 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Mon, 30 Oct 2017, Mironov, Mikhail wrote: [...] I still think this would be much better off using the send_frame()/receive_packet() API. Even if your API doesn't expose any information about the queue length, you only need to hold a single input frame transiently to get around that (the

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> >>> + > >>> +int ff_amf_encode_frame(AVCodecContext *avctx, AVPacket *pkt, > >>> +const AVFrame *frame, int *got_packet) { > >>> +int ret = 0; > >>> +AMF_RESULT res = AMF_OK; > >>> +AmfContext *ctx = avctx->priv_data; > >>> +AMFSurface

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

Mikhail > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: October 30, 2017 6:19 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-10-30 23:35 GMT+01:00 Mark Thompson : > On 30/10/17 21:30, Mironov, Mikhail wrote: +static void AMF_CDECL_CALL AMFTraceWriter_Write(AMFTraceWriter >>> *pThis, +const wchar_t *scope, const wchar_t *message) +{ +AmfTraceWriter *tracer =

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 30/10/17 21:30, Mironov, Mikhail wrote: >>> +static void AMF_CDECL_CALL AMFTraceWriter_Write(AMFTraceWriter >> *pThis, >>> +const wchar_t *scope, const wchar_t *message) >>> +{ >>> +AmfTraceWriter *tracer = (AmfTraceWriter*)pThis; >>> +av_log(tracer->avctx, AV_LOG_DEBUG, "%ls: %ls",

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-10-30 18:56 GMT+01:00 mmironov : [...] > +const enum AVPixelFormat ff_amf_pix_fmts[] = { > +AV_PIX_FMT_NV12, > +AV_PIX_FMT_0RGB32, > +AV_PIX_FMT_0BGR32, > +AV_PIX_FMT_YUV420P, > +AV_PIX_FMT_D3D11, > +AV_PIX_FMT_NONE > +}; > + > +typedef

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> > +static void AMF_CDECL_CALL AMFTraceWriter_Write(AMFTraceWriter > *pThis, > > +const wchar_t *scope, const wchar_t *message) > > +{ > > +AmfTraceWriter *tracer = (AmfTraceWriter*)pThis; > > +av_log(tracer->avctx, AV_LOG_DEBUG, "%ls: %ls", scope, message); > > Does the message

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 30/10/17 17:56, mmironov wrote: > From 9337cb69176bc15aaaf74186cb3468f106236f04 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Fri, 27 Oct 2017 13:03:15 -0400 > Subject: [PATCH] Added: HW accelerated H.264 and HEVC encoding for AMD GPUs > based on AMF SDK > >