[FFmpeg-devel] [PATCH] avutil/opt: print more meaningful default flags values

2015-10-24 Thread Clément Bœsch
Example: % ./ffmpeg -h encoder=gif [...] GIF encoder AVOptions: -gifflagsE..V set GIF flags (default offsetting+transdiff) offsetting E..V enable picture offsetting transdiffE..V enable transparency detection between

[FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread Ganesh Ajjanagadde
Hi all, Apologies for the copy/pasted patch, but can't send via send-email. Copy pasted for review below, attached also for a non-clobbered version. -- >From 99cd052b614553757efa1954bf8bf4dd3caf66d0 Mon Sep 17

Re: [FFmpeg-devel] [PATCH 2/2] libzvbi-teletextdec: fix AVSubtitleRect pict compatiblity code

2015-10-24 Thread Marton Balint
On Fri, 23 Oct 2015, Marton Balint wrote: Only set pict if we got a valid rect. Signed-off-by: Marton Balint --- libavcodec/libzvbi-teletextdec.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) Applied. Regards, Marton

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:52 AM, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Thanks for the super quick review. Will apply shortly. Do you (or >> others) think adding -Wgnu-zero-variadic-macro-arguments to configure >> is a good idea? >

Re: [FFmpeg-devel] [PATCH 3/5] all: use function pointer instead of void * data pointer

2015-10-24 Thread wm4
On Sat, 24 Oct 2015 09:28:52 -0400 Ganesh Ajjanagadde wrote: > ISO C does not guarantee that functions and data live in the same > address space. It is thus (strictly speaking) illegal to assign to a POSIX does. > void * (which is a data pointer) from a function

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > Why does configure even check for 2.x if the actual > lavc wrappers don't currently support it? It is possible to use openjpeg2 with current FFmpeg (I use it for testing) but it is everything but user-friendly. Carl Eugen

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/pthread_frame: fix null pointer dereference

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > Fixes CID 1322329. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/pthread_frame.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/pthread_frame.c

Re: [FFmpeg-devel] [PATCH] swresample: Add support for clipping float/double to -1.0..1.0 range

2015-10-24 Thread Clément Bœsch
On Fri, Oct 23, 2015 at 12:41:18PM -0400, Ronald S. Bultje wrote: [...] > ffmpeg -h full, searching to -sws_flags, gives this: > -sws_flags E..V scaler flags (default 4) > fast_bilinearE..V fast bilinear > bilinear E..V

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:33 AM, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> ISO C requires at least one argument in the place of the ellipsis in a >> variadic macro. In particular, under -pedantic, this triggers the >> warning

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > Thanks for the super quick review. Will apply shortly. Do you (or > others) think adding -Wgnu-zero-variadic-macro-arguments to configure > is a good idea? Considering that each additional option takes ~15 ms in configure on a fairly

Re: [FFmpeg-devel] [PATCH] videodsp: don't overread edges in vfix3 emu_edge.

2015-10-24 Thread Andreas Cadhalpun
On 24.10.2015 14:47, Ronald S. Bultje wrote: > --- > libavcodec/x86/videodsp.asm | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/x86/videodsp.asm b/libavcodec/x86/videodsp.asm > index 25d4364..48f5ac0 100644 > --- a/libavcodec/x86/videodsp.asm

Re: [FFmpeg-devel] [PATCH] videodsp: don't overread edges in vfix3 emu_edge.

2015-10-24 Thread Andreas Cadhalpun
Hi Ronald, On 24.10.2015 17:55, Ronald S. Bultje wrote: > On Sat, Oct 24, 2015 at 11:41 AM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 24.10.2015 14:47, Ronald S. Bultje wrote: >>> --- >>> libavcodec/x86/videodsp.asm | 15 +++ >>> 1 file changed, 11

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Carl Eugen Hoyos
Michael Bradshaw gmail.com> writes: > tl;dr: I've got a patch that updates OpenJPEG to 2.0/2.1. > Currently, I've opted to drop OpenJPEG 1.5. Should I > proceed with preparing this patch for submission, or > should I alter it to keep 1.5 support? Do distributions support (contain) 2.x? Carl

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 09:03:43AM -0700, Michael Bradshaw wrote: > tl;dr: I've got a patch that updates OpenJPEG to 2.0/2.1. Currently, I've > opted to drop OpenJPEG 1.5. Should I proceed with preparing this patch for > submission, or should I alter it to keep 1.5 support? > > > > The

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > Definitely not. Even Arch Linux, generally an early adopter, does not > use openjpeg2, but instead openjpeg for most things. https://www.archlinux.org/packages/community/x86_64/openjpeg2/ Are you sure of your statement? Regards, --

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Andreas Cadhalpun
On 24.10.2015 18:59, Carl Eugen Hoyos wrote: > Michael Bradshaw gmail.com> writes: > >> tl;dr: I've got a patch that updates OpenJPEG to 2.0/2.1. >> Currently, I've opted to drop OpenJPEG 1.5. Should I >> proceed with preparing this patch for submission, or >> should I alter it to keep 1.5

Re: [FFmpeg-devel] [PATCH] vp9: uses ff_set_dimensions (which sets coded_width/height).

2015-10-24 Thread wm4
On Fri, 23 Oct 2015 21:40:14 -0400 "Ronald S. Bultje" wrote: > Fixes ticket 4935. > --- > libavcodec/vp9.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index 3753e89..cee17d9 100644 > --- a/libavcodec/vp9.c

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-24 Thread wm4
On Fri, 23 Oct 2015 15:35:15 -0700 Dale Curtis wrote: > Changes from partial initialization which happens for every > initialize call to a full initialization once per process. Changes > as discussed on list by wm4 and rbultje. > > Passes fft-test and fate suite. > >

Re: [FFmpeg-devel] [PATCH 01/11] libavformat/mxfdec.c: klv_read_packet: Properly check klv_decode_ber_length return value.

2015-10-24 Thread Tomas Härdin
On Thu, 2015-10-22 at 19:25 +0200, Alexis Ballier wrote: > On Wed, 21 Oct 2015 23:31:29 +0200 > Tomas Härdin wrote: > > > On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > > > klv_decode_ber_length cannot return -1, but can return > > > AVERROR_INVALIDDATA.

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/pthread_frame: fix null pointer dereference

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:15 AM, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Fixes CID 1322329. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavcodec/pthread_frame.c | 2 +- >> 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread wm4
On Sat, 24 Oct 2015 09:29:23 -0400 Ganesh Ajjanagadde wrote: > ISO C restricts enumerator values to the range of int. Thus (for instance) > 0x8000 > unfortunately does not work, and throws a warning with -Wpedantic on > clang 3.7. > > This fixes such errors by

Re: [FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 11:08 AM, wm4 wrote: > On Sat, 24 Oct 2015 09:29:23 -0400 > Ganesh Ajjanagadde wrote: > >> ISO C restricts enumerator values to the range of int. Thus (for instance) >> 0x8000 >> unfortunately does not work, and throws a

Re: [FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:44 AM, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Apologies for the copy/pasted patch, but can't send via send-email. > > Maybe you should take some time to tackle your email troubles? I have spent some time

[FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Michael Bradshaw
tl;dr: I've got a patch that updates OpenJPEG to 2.0/2.1. Currently, I've opted to drop OpenJPEG 1.5. Should I proceed with preparing this patch for submission, or should I alter it to keep 1.5 support? The OpenJPEG API went through a bit of an overhaul in the 1.x to 2.x transition. This

Re: [FFmpeg-devel] [PATCH 3/5] all: use function pointer instead of void * data pointer

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 09:28:52AM -0400, Ganesh Ajjanagadde wrote: > ISO C does not guarantee that functions and data live in the same > address space. It is thus (strictly speaking) illegal to assign to a > void * (which is a data pointer) from a function pointer. > > Found by enabling

Re: [FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > Apologies for the copy/pasted patch, but can't send via send-email. Maybe you should take some time to tackle your email troubles? > ISO C %p format specifier applies to void * data pointers. This casts > relevant pointers to void *

Re: [FFmpeg-devel] [PATCHv2 1/2] ffplay: use a separate struct for the rescaled YUVA AVSubtitle rectangles

2015-10-24 Thread Marton Balint
On Sat, 24 Oct 2015, Marton Balint wrote: Current code segfaults since the deprecation of AVSubtitleRect.pict because it freed/realloced AVSubtitleRect.pict.data by itself. The new code stores the generated YUVA AVSubtitle rectangles in their own struct and keeps the original AVSubtitle

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 10:16 AM, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 9:52 AM, Nicolas George wrote: >> Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >>> Thanks for the super quick review. Will apply shortly. Do you (or >>>

Re: [FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread Hendrik Leppkes
On Sat, Oct 24, 2015 at 5:29 PM, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 9:44 AM, Nicolas George wrote: >> Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >>> Apologies for the copy/pasted patch, but can't send via send-email. >> >>

[FFmpeg-devel] [PATCH 3/7] lavfi/fifo: do not assume request_frame() returns a frame.

2015-10-24 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/fifo.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavfilter/fifo.c b/libavfilter/fifo.c index e477cff..f0b77ff 100644 --- a/libavfilter/fifo.c +++ b/libavfilter/fifo.c @@ -201,7 +201,8 @@ static int

[FFmpeg-devel] [PATCH 2/7] lavfi/avf_concat: return immediately after requesting a frame on input.

2015-10-24 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/avf_concat.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c index 5a4b356..4fa9447 100644 --- a/libavfilter/avf_concat.c +++ b/libavfilter/avf_concat.c @@

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 12:59 PM, Carl Eugen Hoyos wrote: > Michael Bradshaw gmail.com> writes: > >> tl;dr: I've got a patch that updates OpenJPEG to 2.0/2.1. >> Currently, I've opted to drop OpenJPEG 1.5. Should I >> proceed with preparing this patch for submission, or >>

Re: [FFmpeg-devel] [PATCH] avcodec/huffman: replace qsort with AV_QSORT

2015-10-24 Thread Ganesh Ajjanagadde
On Thu, Oct 22, 2015 at 10:25 PM, Ganesh Ajjanagadde wrote: > > On Thu, Oct 22, 2015 at 9:28 PM, Timothy Gu wrote: > > On Thu, Oct 22, 2015 at 5:01 PM Ganesh Ajjanagadde > > wrote: > >> > >> Sample benchmark (x86-64,

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-24 Thread wm4
On Sat, 24 Oct 2015 04:13:18 +0200 Michael Niedermayer wrote: > On Thu, Oct 22, 2015 at 09:48:30PM -0700, Dale Curtis wrote: > > On Wed, Oct 21, 2015 at 6:52 PM, Dale Curtis > > wrote: > > > > > On Tue, Oct 20, 2015 at 11:50 PM, Michael

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/pthread_frame: fix null pointer dereference

2015-10-24 Thread Hendrik Leppkes
On Sat, Oct 24, 2015 at 3:26 PM, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 9:15 AM, Nicolas George wrote: >> Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >>> Fixes CID 1322329. >>> >>> Signed-off-by: Ganesh Ajjanagadde

[FFmpeg-devel] [PATCH] lavfi/vf_decimate: do not compare the first frame to itself.

2015-10-24 Thread Nicolas George
This is a waste of computing power and will result to 0, making it always dropped. Use maximum difference values instead. Signed-off-by: Nicolas George --- libavfilter/vf_decimate.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] videodsp: don't overread edges in vfix3 emu_edge.

2015-10-24 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > Great, thanks for verifying that. I'll apply with > your suggested addition to the commit message. Please do, you could also mention ticket #3226: I was never able to reproduce (I can reproduce the Debian bug) but it has a very similar description iirc.

Re: [FFmpeg-devel] [PATCH] videodsp: don't overread edges in vfix3 emu_edge.

2015-10-24 Thread Ronald S. Bultje
Hi Andreas, On Sat, Oct 24, 2015 at 11:41 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 24.10.2015 14:47, Ronald S. Bultje wrote: > > --- > > libavcodec/x86/videodsp.asm | 15 +++ > > 1 file changed, 11 insertions(+), 4 deletions(-) > > > > diff --git

[FFmpeg-devel] [PATCH 4/7] lavfi/af_join: partially fix scheduling.

2015-10-24 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/af_join.c | 50 +- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c index f5a1c50..bd780cc 100644 ---

[FFmpeg-devel] [PATCH 6/7] lavfi/af_amix: mostly fix scheduling.

2015-10-24 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/af_amix.c | 142 ++ 1 file changed, 62 insertions(+), 80 deletions(-) diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c index 434dd90..223328b 100644 ---

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 1:09 PM, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Definitely not. Even Arch Linux, generally an early adopter, does not >> use openjpeg2, but instead openjpeg for most things. > >

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 1:48 PM, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 03:52:25PM +0200, Nicolas George wrote: >> Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> > Thanks for the super quick review. Will apply shortly. Do you (or >> > others)

[FFmpeg-devel] Wanted to contribute

2015-10-24 Thread rishi shah
Hi ! I wanted to contribute in FFMpeg organization. What can be the good starting point? I have Mac OS. Thanks, Rishi ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] version.sh: add note that ffversion.h is auto-generated

2015-10-24 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 7:04 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > version.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/version.sh b/version.sh > index f9754eb..a9d7e39 100755 > --- a/version.sh >

[FFmpeg-devel] [PATCH][RFC] avcodec/pthread_frame: fix null pointer dereference

2015-10-24 Thread Ganesh Ajjanagadde
Fixes CID 1322329. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/pthread_frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 7651211..ca06e3d 100644 --- a/libavcodec/pthread_frame.c

Re: [FFmpeg-devel] Wanted to contribute

2015-10-24 Thread wm4
On Sat, 24 Oct 2015 18:21:45 +0530 rishi shah wrote: > Hi ! > I wanted to contribute in FFMpeg organization. What can be the good > starting point? I have Mac OS. Here's an overview: http://ffmpeg.org/developer.html#Contributing

Re: [FFmpeg-devel] [PATCH] swresample: Add support for clipping float/double to -1.0..1.0 range

2015-10-24 Thread Clément Bœsch
On Sat, Oct 24, 2015 at 03:16:15PM +0200, Clément Bœsch wrote: > On Fri, Oct 23, 2015 at 12:41:18PM -0400, Ronald S. Bultje wrote: > [...] > > ffmpeg -h full, searching to -sws_flags, gives this: > > -sws_flags E..V scaler flags (default 4) > > fast_bilinear

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > ISO C requires at least one argument in the place of the ellipsis in a > variadic macro. In particular, under -pedantic, this triggers the > warning -Wgnu-zero-variadic-macro-arguments on clang 3.7. > > Signed-off-by: Ganesh

[FFmpeg-devel] [PATCH 1/5] all: fix -Wextra-semi reported on clang

2015-10-24 Thread Ganesh Ajjanagadde
Hi all, Apologies for the copy/pasted patch, but can't send via send-email. Copy pasted for review below, attached also for a non-clobbered version. -- >From 82b889a359925d1f9f7496c916cf24146b44e648 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH 3/5] all: use function pointer instead of void * data pointer

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 11:01 AM, wm4 wrote: > On Sat, 24 Oct 2015 09:28:52 -0400 > Ganesh Ajjanagadde wrote: > >> ISO C does not guarantee that functions and data live in the same >> address space. It is thus (strictly speaking) illegal to assign

Re: [FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread wm4
On Sat, 24 Oct 2015 09:35:48 -0400 Ganesh Ajjanagadde wrote: > Hi all, > > Apologies for the copy/pasted patch, but can't send via send-email. > Copy pasted for review below, attached also for a non-clobbered > version. > >

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > I did not say it is not present, just that more packages rely on > openjpeg instead of openjpeg2. Ok. But having it available is enough, we do not really care how many other programs use it, only that Michael, the maintainer for this

Re: [FFmpeg-devel] [PATCH] videodsp: don't overread edges in vfix3 emu_edge.

2015-10-24 Thread Ronald S. Bultje
Hi Andreas, On Sat, Oct 24, 2015 at 11:58 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Hi Ronald, > > On 24.10.2015 17:55, Ronald S. Bultje wrote: > > On Sat, Oct 24, 2015 at 11:41 AM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > >> On 24.10.2015

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 03:52:25PM +0200, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > > Thanks for the super quick review. Will apply shortly. Do you (or > > others) think adding -Wgnu-zero-variadic-macro-arguments to configure > > is a good idea? > >

[FFmpeg-devel] [PATCH] videodsp: don't overread edges in vfix3 emu_edge.

2015-10-24 Thread Ronald S. Bultje
--- libavcodec/x86/videodsp.asm | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/videodsp.asm b/libavcodec/x86/videodsp.asm index 25d4364..48f5ac0 100644 --- a/libavcodec/x86/videodsp.asm +++ b/libavcodec/x86/videodsp.asm @@ -194,8 +194,12 @@

[FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Ganesh Ajjanagadde
ISO C requires at least one argument in the place of the ellipsis in a variadic macro. In particular, under -pedantic, this triggers the warning -Wgnu-zero-variadic-macro-arguments on clang 3.7. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_asetrate.c | 4 ++--

[FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread Ganesh Ajjanagadde
ISO C restricts enumerator values to the range of int. Thus (for instance) 0x8000 unfortunately does not work, and throws a warning with -Wpedantic on clang 3.7. This fixes such errors by explicitly casting as an int, doing the desired unsigned to signed conversion. This method works on all

[FFmpeg-devel] [PATCH 3/5] all: use function pointer instead of void * data pointer

2015-10-24 Thread Ganesh Ajjanagadde
ISO C does not guarantee that functions and data live in the same address space. It is thus (strictly speaking) illegal to assign to a void * (which is a data pointer) from a function pointer. Found by enabling -Wpedantic on clang 3.7. Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:44 AM, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Apologies for the copy/pasted patch, but can't send via send-email. > > Maybe you should take some time to tackle your email troubles? > >> ISO C %p format

Re: [FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > I have spent some time on this. Given up on gmail, as it is not in my > control, and is inconsistent. I have tried following my university's > mail configuration, but it does not work. Will need to speak with them > at some point.

[FFmpeg-devel] [PATCH 1/7] lavfi: remove astreamsync.

2015-10-24 Thread Nicolas George
It was only useful for very specific testing purposes and appears to be currently partially broken. Signed-off-by: Nicolas George --- MAINTAINERS | 1 - doc/filters.texi | 36 --- libavfilter/Makefile | 1 -

[FFmpeg-devel] [PATCH 5/7] lavfi/vf_framepack: fix scheduling.

2015-10-24 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/vf_framepack.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_framepack.c b/libavfilter/vf_framepack.c index be52507..621a034 100644 --- a/libavfilter/vf_framepack.c +++

[FFmpeg-devel] [PATCH 7/7] lavfi/af_asyncts: remove looping on request_frame().

2015-10-24 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/af_asyncts.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/af_asyncts.c b/libavfilter/af_asyncts.c index 214cefd..209fc4c 100644 --- a/libavfilter/af_asyncts.c +++ b/libavfilter/af_asyncts.c @@

Re: [FFmpeg-devel] [PATCH] avutil/opt: print more meaningful default flags values

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 03:14:33PM +0200, Clément Bœsch wrote: > Example: > % ./ffmpeg -h encoder=gif > [...] > GIF encoder AVOptions: > -gifflagsE..V set GIF flags (default > offsetting+transdiff) > offsetting E..V enable picture offsetting >

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread James Almer
On 10/24/2015 1:03 PM, Michael Bradshaw wrote: > tl;dr: I've got a patch that updates OpenJPEG to 2.0/2.1. Currently, I've > opted to drop OpenJPEG 1.5. Should I proceed with preparing this patch for > submission, or should I alter it to keep 1.5 support? > > > > The OpenJPEG API went

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, James Almer a écrit : > No idea about other distros, but in any case, if there's any that doesn't > ship it then we should keep supporting it for a while, even if it means > adding some ugly macros. Depending on the ugliness of the macros, maybe duplicating the

Re: [FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 02:41:59PM -0400, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 2:33 PM, Michael Niedermayer > wrote: > > On Sat, Oct 24, 2015 at 09:29:23AM -0400, Ganesh Ajjanagadde wrote: > >> ISO C restricts enumerator values to the range of int. Thus (for

Re: [FFmpeg-devel] [PATCH 3/5] all: use function pointer instead of void * data pointer

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 1:23 PM, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 09:28:52AM -0400, Ganesh Ajjanagadde wrote: >> ISO C does not guarantee that functions and data live in the same >> address space. It is thus (strictly speaking) illegal to assign to a >>

[FFmpeg-devel] [PATCH 4/5] concatdec: add metadata for file start time and duration

2015-10-24 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/concatdec.c| 6 ++ tests/ref/fate/concat-demuxer-lavf-mxf | 2 +- tests/ref/fate/concat-demuxer-lavf-mxf_d10 | 2 +- tests/ref/fate/concat-demuxer-lavf-ts | 2 +- 4 files changed, 9 insertions(+), 3

[FFmpeg-devel] [PATCH 2/5] fate: add concat demuxer tests

2015-10-24 Thread Marton Balint
Signed-off-by: Marton Balint --- tests/Makefile | 1 + tests/fate-run.sh | 14 tests/fate/concatdec.mak | 12 tests/ref/fate/concat-demuxer-lavf-mxf | 1 +

[FFmpeg-devel] [PATCH 3/5] concatdec: move duration calculating code to open_file

2015-10-24 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/concatdec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 7686f28..f262d44 100644 --- a/libavformat/concatdec.c +++

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 03:10:58PM +0200, wm4 wrote: > On Sat, 24 Oct 2015 04:13:18 +0200 > Michael Niedermayer wrote: > > > On Thu, Oct 22, 2015 at 09:48:30PM -0700, Dale Curtis wrote: > > > On Wed, Oct 21, 2015 at 6:52 PM, Dale Curtis > > >

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 6:08 PM, James Almer wrote: > This gives the compiler some flexibility > > Signed-off-by: James Almer > --- > libavutil/x86/intmath.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/x86/intmath.h

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_deshake: use a void * comparator for consistency

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 7:07 PM, Henrik Gramner wrote: > On Sun, Oct 25, 2015 at 12:02 AM, Ganesh Ajjanagadde > wrote: >> -static int cmp(const double *a, const double *b) >> +static int cmp(const void *a, const void *b) >> { >> -return *a < *b ?

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_deshake: use a void * comparator for consistency

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 7:04 PM, wm4 wrote: > On Sat, 24 Oct 2015 18:02:36 -0400 > Ganesh Ajjanagadde wrote: > >> For generality, qsort uses a comparator whose elements are void *. This >> makes the comparator have such a form, and thus makes the

Re: [FFmpeg-devel] [PATCH 1/5] all: fix -Wextra-semi reported on clang

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 4:12 PM, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 09:33:22AM -0400, Ganesh Ajjanagadde wrote: >> Hi all, >> >> Apologies for the copy/pasted patch, but can't send via send-email. >> Copy pasted for review below, attached also for a

Re: [FFmpeg-devel] [PATCH 1/5] all: fix -Wextra-semi reported on clang

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 04:16:56PM -0400, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 4:12 PM, Michael Niedermayer > wrote: > > On Sat, Oct 24, 2015 at 09:33:22AM -0400, Ganesh Ajjanagadde wrote: > >> Hi all, > >> > >> Apologies for the copy/pasted patch, but can't

[FFmpeg-devel] [PATCH 1/5] ffprobe: add support for printing packet strings metadata as packet tags

2015-10-24 Thread Marton Balint
ffprobe.xsd already contains the tag element. Signed-off-by: Marton Balint --- ffprobe.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/ffprobe.c b/ffprobe.c index ac03689..f5930ae 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -77,6 +77,7 @@

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Michael Bradshaw
On Sat, Oct 24, 2015 at 11:28 AM, Timothy Gu wrote: > On Sat, Oct 24, 2015 at 11:03 AM James Almer wrote: > > > Gentoo and Debian both seem to ship it. Arch does as well but on their > > Community repository (ffmpeg adopting it may be incentive enough

Re: [FFmpeg-devel] [PATCH 1/5] all: fix -Wextra-semi reported on clang

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 4:28 PM, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 04:16:56PM -0400, Ganesh Ajjanagadde wrote: >> On Sat, Oct 24, 2015 at 4:12 PM, Michael Niedermayer >> wrote: >> > On Sat, Oct 24, 2015 at 09:33:22AM -0400,

Re: [FFmpeg-devel] [PATCH 1/7] lavfi: remove astreamsync.

2015-10-24 Thread Paul B Mahol
Dana 24. 10. 2015. 19:06 osoba "Nicolas George" napisala je: > > It was only useful for very specific testing purposes > and appears to be currently partially broken. What's broken? > > Signed-off-by: Nicolas George > --- > MAINTAINERS | 1

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-24 Thread Ronald S. Bultje
On Sat, Oct 24, 2015 at 6:45 PM, Michael Niedermayer wrote: > either way, this subject is rather uninterresting ill try to do > something more usefull for FFmpeg than arguing about these > hypothetical cases ... +100. Many of these tools are like -Wpedantic. Reminds

Re: [FFmpeg-devel] [PATCH] videodsp: don't overread edges in vfix3 emu_edge.

2015-10-24 Thread Ronald S. Bultje
Hi, On Sat, Oct 24, 2015 at 2:13 PM, Carl Eugen Hoyos wrote: > Ronald S. Bultje gmail.com> writes: > > > Great, thanks for verifying that. I'll apply with > > your suggested addition to the commit message. > > Please do, you could also mention ticket #3226: I > was never able

Re: [FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 09:29:23AM -0400, Ganesh Ajjanagadde wrote: > ISO C restricts enumerator values to the range of int. Thus (for instance) > 0x8000 > unfortunately does not work, and throws a warning with -Wpedantic on > clang 3.7. > > This fixes such errors by explicitly casting as an

[FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-24 Thread James Almer
This gives the compiler some flexibility Signed-off-by: James Almer --- libavutil/x86/intmath.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/x86/intmath.h b/libavutil/x86/intmath.h index 7881e3c..10d3e7f 100644 --- a/libavutil/x86/intmath.h

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-24 Thread James Almer
On 10/24/2015 7:48 PM, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 6:08 PM, James Almer wrote: >> This gives the compiler some flexibility >> >> Signed-off-by: James Almer >> --- >> libavutil/x86/intmath.h | 2 +- >> 1 file changed, 1 insertion(+),

Re: [FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > or do you prefer a static const style? static const is not build-time constant, and therefore unusable for this: impossible to use it as case label or constant initializer. Regards, -- Nicolas George signature.asc Description:

Re: [FFmpeg-devel] Wanted to contribute

2015-10-24 Thread rishi shah
Hi wm4, I went through that link but its all about just coding convention and patch submission methodology. Nothing about dev setup or nothing about list of projects, modules and bugs. Thanks, Rishi On Sat, Oct 24, 2015 at 6:48 PM, wm4 wrote: > On Sat, 24 Oct 2015

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Ben Boeckel
On Sat, 24 Oct, 2015 at 21:37:57 GMT, Michael Bradshaw wrote: > Crap, you're right. Before I started this I checked if Ubuntu had openjpeg2 > and they do[1] but it turns out it's really just openjpeg 1.3 (if anyone > knows why they made a separate package named libopenjpeg2 when it's really >

[FFmpeg-devel] [PATCH 5/5] lavfi/select: add support for concatdec_select option

2015-10-24 Thread Marton Balint
This option can be used to select useful frames from an ffconcat file which is using inpoints and outpoints but where the source files are not intra frame only. Signed-off-by: Marton Balint --- doc/filters.texi | 17 + libavfilter/f_select.c | 20

[FFmpeg-devel] [PATCH 2/3] avutil/tree: improve documentation for av_tree_find, av_tree_insert

2015-10-24 Thread Ganesh Ajjanagadde
This documents the additional constness, and provides a useful libc reference for the API specification of the comparator. Signed-off-by: Ganesh Ajjanagadde --- libavutil/tree.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavutil/tree.h

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_deshake: use a void * comparator for consistency

2015-10-24 Thread Ganesh Ajjanagadde
For generality, qsort uses a comparator whose elements are void *. This makes the comparator have such a form, and thus makes the void * cast of the comparator pointer useless. Furthermore, this makes the code more consistent with other usages of qsort across the codebase. Signed-off-by: Ganesh

Re: [FFmpeg-devel] [PATCH 1/7] lavfi: remove astreamsync.

2015-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Paul B Mahol a écrit : > What's broken? EOF handling. I am not sure it did ever work. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] Can we drop OpenJPEG 1.5 in favor of 2.x?

2015-10-24 Thread Dominik 'Rathann' Mierzejewski
On Saturday, 24 October 2015 at 18:59, Carl Eugen Hoyos wrote: > Michael Bradshaw gmail.com> writes: > > > tl;dr: I've got a patch that updates OpenJPEG to 2.0/2.1. > > Currently, I've opted to drop OpenJPEG 1.5. Should I > > proceed with preparing this patch for submission, or > > should I

[FFmpeg-devel] [PATCH] all: simplify qsort comparators, and add const-correctness

2015-10-24 Thread Ganesh Ajjanagadde
All the comparator API needs is > 0, < 0, or = 0 signalling: it does not need +1, -1, 0. This avoids some useless branching. This also adds const-correctness when needed for the comparators. Signed-off-by: Ganesh Ajjanagadde --- cmdutils_opencl.c | 2 +-

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 7:17 PM, Henrik Gramner wrote: > On Sun, Oct 25, 2015 at 12:02 AM, Ganesh Ajjanagadde > wrote: >> -static int cmp(void *key, const void *node) >> +static int cmp(const void *key, const void *node) >> { >> return (*(int64_t

Re: [FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 2:33 PM, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 09:29:23AM -0400, Ganesh Ajjanagadde wrote: >> ISO C restricts enumerator values to the range of int. Thus (for instance) >> 0x8000 >> unfortunately does not work, and throws a

Re: [FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 02:01:07PM -0400, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 1:48 PM, Michael Niedermayer > wrote: > > On Sat, Oct 24, 2015 at 03:52:25PM +0200, Nicolas George wrote: > >> Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > >> >

Re: [FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 02:41:59PM -0400, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 2:33 PM, Michael Niedermayer > wrote: > > On Sat, Oct 24, 2015 at 09:29:23AM -0400, Ganesh Ajjanagadde wrote: > >> ISO C restricts enumerator values to the range of int. Thus (for

Re: [FFmpeg-devel] [PATCH 5/5] all: fix enum definition for large values

2015-10-24 Thread Hendrik Leppkes
On Sat, Oct 24, 2015 at 8:58 PM, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 02:41:59PM -0400, Ganesh Ajjanagadde wrote: >> On Sat, Oct 24, 2015 at 2:33 PM, Michael Niedermayer >> wrote: >> > On Sat, Oct 24, 2015 at 09:29:23AM -0400,

  1   2   >