Re: [FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

2015-10-28 Thread Agatha Hu
在 2015/10/28 14:53, Agatha Hu 写道: --- libavcodec/nvenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0e6ef43..083e494 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -912,6 +912,11 @@ static av_cold int nve

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_warn_unused_result

2015-10-28 Thread Hendrik Leppkes
On Wed, Oct 28, 2015 at 4:17 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 6:05 PM, Ganesh Ajjanagadde > wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavutil/avstring.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavutil/avstring.h b/libavutil/avstring.h

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-28 Thread Matt Oliver
On 26 October 2015 at 04:46, James Almer wrote: > On 10/25/2015 1:39 PM, Matt Oliver wrote: > > On 26 October 2015 at 00:43, Hendrik Leppkes > wrote: > > > >> On Sun, Oct 25, 2015 at 12:30 PM, Matt Oliver > >> wrote: > >>> On 25 October 2015 at 22:16, Hendrik Leppkes > >> wrote: > >>> > O

[FFmpeg-devel] [PATCH] avformat: add 3dostr demuxer

2015-10-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/3dostr.c | 169 +++ libavformat/Makefile | 1 + libavformat/allformats.c | 1 + 3 files changed, 171 insertions(+) create mode 100644 libavformat/3dostr.c diff --git a/libavformat/3dostr.c b/liba

Re: [FFmpeg-devel] [PATCH] ffprobe: move abort() call to after the print statements

2015-10-28 Thread wm4
On Tue, 27 Oct 2015 20:21:11 -0400 Ganesh Ajjanagadde wrote: > This fixes warning C4702 "unreachable code" reported in MSVC: > http://fate.ffmpeg.org/log.cgi?time=20151026165907&log=compile&slot=x86_64-msvc12-windows-native, > and also likely fixes the intended behavior. > > Signed-off-by: Ganes

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread wm4
On Tue, 27 Oct 2015 20:53:39 -0400 Ganesh Ajjanagadde wrote: > ISO C restricts enumerator values to the range of int. Thus (for instance) > 0x8000 > unfortunately does not work, and throws a warning with -Wpedantic on > clang 3.7. > > This fixes it by using alternative expressions that resu

Re: [FFmpeg-devel] [PATCH] ffprobe: move abort() call to after the print statements

2015-10-28 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 09:55:56AM +0100, wm4 wrote: > On Tue, 27 Oct 2015 20:21:11 -0400 > Ganesh Ajjanagadde wrote: > > > This fixes warning C4702 "unreachable code" reported in MSVC: > > http://fate.ffmpeg.org/log.cgi?time=20151026165907&log=compile&slot=x86_64-msvc12-windows-native, > > and a

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-28 Thread wm4
On Wed, 28 Oct 2015 01:06:38 +0100 Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 10:14:49AM +0100, wm4 wrote: > > On Mon, 26 Oct 2015 13:15:39 -0700 > > Dale Curtis wrote: > > > > > On Sun, Oct 25, 2015 at 4:56 AM, Ronald S. Bultje > > > wrote: > > > > > > > > So this is likely beca

[FFmpeg-devel] [PATCH 1/8] lavu/aes: test CBC functionality

2015-10-28 Thread Rodger Combs
--- libavutil/aes.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/libavutil/aes.c b/libavutil/aes.c index dde15be..9096f03 100644 --- a/libavutil/aes.c +++ b/libavutil/aes.c @@ -280,7 +280,7 @@ int main(int argc, char **argv) { 0x10, 0xa5, 0x88,

[FFmpeg-devel] [PATCH 2/8] lavu/aes: add x86 AESNI optimizations

2015-10-28 Thread Rodger Combs
crypto_bench comparison for AES-128-ECB: lavu_aesni AES-128-ECB size: 1048576 runs: 1024 time:0.596 +- 0.081 lavu_c AES-128-ECB size: 1048576 runs: 1024 time: 17.007 +- 2.131 crypto AES-128-ECB size: 1048576 runs: 1024 time:0.612 +- 1.857 gcrypt AES-128-ECB si

[FFmpeg-devel] [PATCH 3/8] checkasm: add tests for AES

2015-10-28 Thread Rodger Combs
--- tests/checkasm/Makefile | 2 +- tests/checkasm/aes.c | 64 +++ tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + 4 files changed, 67 insertions(+), 1 deletion(-) create mode 100644 tests/checkasm/aes.c diff --git a/tests/c

[FFmpeg-devel] [PATCH 4/8] tools/crypto_bench: add AES-192 and AES-256

2015-10-28 Thread Rodger Combs
--- tools/crypto_bench.c | 82 1 file changed, 82 insertions(+) diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c index b3b24a6..ad20f95 100644 --- a/tools/crypto_bench.c +++ b/tools/crypto_bench.c @@ -118,6 +118,24 @@ static void run_la

[FFmpeg-devel] [PATCH 5/8] tools/crypto_bench: add AES-CBC modes

2015-10-28 Thread Rodger Combs
--- tools/crypto_bench.c | 140 +-- 1 file changed, 137 insertions(+), 3 deletions(-) diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c index ad20f95..15bb5f1 100644 --- a/tools/crypto_bench.c +++ b/tools/crypto_bench.c @@ -52,6 +52,7 @@ stat

[FFmpeg-devel] [PATCH 6/8] tools/crypto_bench: switch to OpenSSL's faster AES API

2015-10-28 Thread Rodger Combs
--- tools/crypto_bench.c | 85 +--- 1 file changed, 47 insertions(+), 38 deletions(-) diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c index 15bb5f1..8a468ba 100644 --- a/tools/crypto_bench.c +++ b/tools/crypto_bench.c @@ -244,6 +244,7 @@ st

[FFmpeg-devel] [PATCH 7/8] tools/crypto_bench: add support for multiple lavu versions by cpuflag

2015-10-28 Thread Rodger Combs
--- tools/crypto_bench.c | 50 ++ 1 file changed, 42 insertions(+), 8 deletions(-) diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c index 8a468ba..b513c55 100644 --- a/tools/crypto_bench.c +++ b/tools/crypto_bench.c @@ -32,6 +32,7 @@ #inclu

[FFmpeg-devel] [PATCH 8/8] FATE: add crypto protocol test

2015-10-28 Thread Rodger Combs
--- tests/Makefile | 5 + tests/fate/avformat.mak | 1 + tests/lavf-regression.sh | 9 + tests/ref/lavf/crypto| 3 +++ 4 files changed, 18 insertions(+) create mode 100644 tests/ref/lavf/crypto diff --git a/tests/Makefile b/tests/Makefile index 7ee4a46..c501813 100644

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde wrote: > On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, Oct 27, 2015 at 8:53 PM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> ISO C restricts enumerator values to the range of in

Re: [FFmpeg-devel] [PATCH]lavc/proresdec2: Fix slice_count for very high resolutions

2015-10-28 Thread Michael Niedermayer
On Sun, Oct 25, 2015 at 03:09:24PM +0100, Carl Eugen Hoyos wrote: > On Sunday 25 October 2015 01:37:15 pm Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch intends to fix an issue reported by forum user Koracas: > > For slice_count > 0x1 FFmpeg fails to decode a frame, QT seems to > > igno

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

2015-10-28 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 02:57:14AM +0100, Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 11:15:29PM +0100, Matthieu Bouron wrote: > > On Sun, Oct 18, 2015 at 11:06:50AM +0200, Matthieu Bouron wrote: > > [...] > > > > > > Patch updated, the markers are now properly skipped (which also fixes a

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pngdec: honor skip_frame option

2015-10-28 Thread Michael Niedermayer
On Mon, Oct 19, 2015 at 10:28:18AM +0200, Matthieu Bouron wrote: > On Sat, Oct 17, 2015 at 10:34:22PM +0200, Matthieu Bouron wrote: > > From: Matthieu Bouron > > > > --- > > libavcodec/pngdec.c | 34 ++ > > 1 file changed, 34 insertions(+) > > > > diff --git a/li

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 3:41 AM, Hendrik Leppkes wrote: > On Wed, Oct 28, 2015 at 4:17 AM, Ganesh Ajjanagadde > wrote: >> On Thu, Oct 15, 2015 at 6:05 PM, Ganesh Ajjanagadde >> wrote: >>> Signed-off-by: Ganesh Ajjanagadde >>> --- >>> libavutil/avstring.h | 2 ++ >>> 1 file changed, 2 insertion

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde > wrote: >> >> On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, Oct 27, 2015 at 8:53 PM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >>

Re: [FFmpeg-devel] [PATCH] ffprobe: move abort() call to after the print statements

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 5:14 AM, Michael Niedermayer wrote: > On Wed, Oct 28, 2015 at 09:55:56AM +0100, wm4 wrote: >> On Tue, 27 Oct 2015 20:21:11 -0400 >> Ganesh Ajjanagadde wrote: >> >> > This fixes warning C4702 "unreachable code" reported in MSVC: >> > http://fate.ffmpeg.org/log.cgi?time=2015

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/png: read and write stereo3d frame side data information

2015-10-28 Thread Michael Niedermayer
On Thu, Oct 22, 2015 at 11:50:35PM +0300, Kirill Gavrilov wrote: > Use optional sTER chunk defining side-by-side stereo pair > within "Extensions to the PNG 1.2 Specification", version 1.3.0. > > Specification: > http://www.libpng.org/pub/png/spec/register/pngext-1.4.0-pdg.html > > Note that patc

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

2015-10-28 Thread Bodecs Bela
ping 2015.10.18. 14:06 keltezéssel, Bodecs Bela írta: Dear Marton Balint, see may comments below. 2015.10.18. 1:10 keltezéssel, Marton Balint írta: On Thu, 15 Oct 2015, Bodecs Bela wrote: [...] My enhancement does not alter the current behaviour in any way. Are you sure? What if somebod

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

2015-10-28 Thread Matthieu Bouron
On Wed, Oct 28, 2015 at 02:57:14AM +0100, Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 11:15:29PM +0100, Matthieu Bouron wrote: > > On Sun, Oct 18, 2015 at 11:06:50AM +0200, Matthieu Bouron wrote: > > [...] > > > > > > Patch updated, the markers are now properly skipped (which also fixes a

Re: [FFmpeg-devel] PATCH: gdigrab work for DPI in windows

2015-10-28 Thread Matt Oliver
On 5 October 2015 at 20:05, Matt Oliver wrote: > On 5 October 2015 at 19:29, Matt Oliver wrote: > >> On 30 September 2015 at 02:48, wm4 wrote: >> >>> On Wed, 23 Sep 2015 12:04:43 -0600 >>> Roger Pack wrote: >>> >>> > From 6a972dda58bd5ab31524cd4e5326b4bcdeaeaa8c Mon Sep 17 00:00:00 2001 >>> >

Re: [FFmpeg-devel] [PATCH] avcodec/motion_est_template: replace qsort with AV_QSORT

2015-10-28 Thread Michael Niedermayer
On Tue, Oct 27, 2015 at 10:51:29PM -0400, Ganesh Ajjanagadde wrote: > This code is in a performance critical section. AV_QSORT is > substantially faster due to the inlining of the comparison callback. > Thus, the increase in performance is worth the increase in binary size. > > Signed-off-by: Gane

Re: [FFmpeg-devel] [PATCH 1/8] lavu/aes: test CBC functionality

2015-10-28 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 05:39:32AM -0500, Rodger Combs wrote: > --- > libavutil/aes.c | 19 ++- > 1 file changed, 14 insertions(+), 5 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The educated differ from the uneducated

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pngdec: honor skip_frame option

2015-10-28 Thread Matthieu Bouron
On Wed, Oct 28, 2015 at 12:59:54PM +0100, Michael Niedermayer wrote: > On Mon, Oct 19, 2015 at 10:28:18AM +0200, Matthieu Bouron wrote: > > On Sat, Oct 17, 2015 at 10:34:22PM +0200, Matthieu Bouron wrote: > > > From: Matthieu Bouron > > > > > > --- > > > libavcodec/pngdec.c | 34

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-28 Thread Ganesh Ajjanagadde
On Tue, Oct 27, 2015 at 8:18 PM, Ganesh Ajjanagadde wrote: > av_gcd is now always defined regardless of input. This documents this > change in the "documented API". Two benefits (closely related): > 1. The function is robust, and there is no need to worry about INT64_MIN, etc. > > 2. Clients of av

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

2015-10-28 Thread Matthieu Bouron
On Wed, Oct 28, 2015 at 12:58:53PM +0100, Michael Niedermayer wrote: > On Wed, Oct 28, 2015 at 02:57:14AM +0100, Michael Niedermayer wrote: > > On Tue, Oct 27, 2015 at 11:15:29PM +0100, Matthieu Bouron wrote: > > > On Sun, Oct 18, 2015 at 11:06:50AM +0200, Matthieu Bouron wrote: > > > [...] > > > >

Re: [FFmpeg-devel] [PATCH 4/8] tools/crypto_bench: add AES-192 and AES-256

2015-10-28 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 05:39:35AM -0500, Rodger Combs wrote: > --- > tools/crypto_bench.c | 82 > > 1 file changed, 82 insertions(+) > > diff --git a/tools/crypto_bench.c b/tools/crypto_bench.c > index b3b24a6..ad20f95 100644 > --- a/tools/cr

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde > > wrote: > >> > >> On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje > >> wrote: > >> > Hi, > >>

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde >> > wrote: >> >> >> >> On T

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Hendrik Leppkes
On Wed, Oct 28, 2015 at 4:00 PM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje wrote: >> Hi, >> >> On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde >> wrote: >>> >>> On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje >>> wrote: >>> > Hi, >>> > >>> > On Wed,

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde > > wrote: > >> > >> On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje > >> wrote: > >> > Hi, > >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Clément Bœsch
On Wed, Oct 28, 2015 at 10:34:37AM -0400, Ronald S. Bultje wrote: [...] > You could do the same for the last 4 values of the cinething changes, they > are clearly not enums, but flags. Flags are always unsigned, so if enums > are unsigned and that causes an issue (as it does here), it makes sense t

Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

2015-10-28 Thread Hendrik Leppkes
On Wed, Oct 21, 2015 at 1:52 PM, Hendrik Leppkes wrote: > This implementation does not support TLS listen sockets and loading > CA/Certs from files. > > The Windows API does not support loading PEM certs, and would either > require a manual loader or instead be limited to loading Windows PFX > cer

Re: [FFmpeg-devel] [PATCH] avutil/ripemd: make rol macro more robust by adding parentheses

2015-10-28 Thread James Almer
On 10/27/2015 9:00 PM, Ganesh Ajjanagadde wrote: > This ensures that the macro remains correct in the sense of allowing > expressions for value and bits, by placing the value and bits expressions > within > parentheses. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/ripemd.c | 2 +- >

[FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

2015-10-28 Thread Ronald S. Bultje
--- libavcodec/vp9_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c index 0437097..6713850 100644 --- a/libavcodec/vp9_parser.c +++ b/libavcodec/vp9_parser.c @@ -64,7 +64,7 @@ static int parse_frame(AVCodecParserContext

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

2015-10-28 Thread Michael Niedermayer
On Sun, Oct 18, 2015 at 02:06:12PM +0200, Bodecs Bela wrote: > Dear Marton Balint, > > see may comments below. > > 2015.10.18. 1:10 keltezéssel, Marton Balint írta: > > > >On Thu, 15 Oct 2015, Bodecs Bela wrote: > > > >[...] > > > My enhancement does not alter the current behaviour in any way

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pngdec: honor skip_frame option

2015-10-28 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 03:09:02PM +0100, Matthieu Bouron wrote: > On Wed, Oct 28, 2015 at 12:59:54PM +0100, Michael Niedermayer wrote: > > On Mon, Oct 19, 2015 at 10:28:18AM +0200, Matthieu Bouron wrote: > > > On Sat, Oct 17, 2015 at 10:34:22PM +0200, Matthieu Bouron wrote: > > > > From: Matthieu

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

2015-10-28 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 03:10:00PM +0100, Matthieu Bouron wrote: > On Wed, Oct 28, 2015 at 12:58:53PM +0100, Michael Niedermayer wrote: > > On Wed, Oct 28, 2015 at 02:57:14AM +0100, Michael Niedermayer wrote: > > > On Tue, Oct 27, 2015 at 11:15:29PM +0100, Matthieu Bouron wrote: > > > > On Sun, Oct

Re: [FFmpeg-devel] [PATCH 3/3] WIP: lavf/utils: try to avoid decoding a frame to get the codec parameters

2015-10-28 Thread Michael Niedermayer
On Sat, Oct 17, 2015 at 10:34:24PM +0200, Matthieu Bouron wrote: > From: Matthieu Bouron > > Avoid decoding twice images such as jpeg and png, once in the > avformat_find_stream_info and once when the actual decode is made. > > The decoder must honor the skip_frame option in order to skip > deco

Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

2015-10-28 Thread Derek Buitenhuis
Enjoy my half-assed / useless review. > +#ifndef SECBUFFER_ALERT > +#define SECBUFFER_ALERT17 > +#endif Why? > +SecPkgContext_StreamSizes Sizes; Accidental capital? > +if (c->enc_buf == NULL) { > +c->enc_buf_offset = 0; > +c->enc_buf_size = SCHANNEL_INIT

Re: [FFmpeg-devel] [PATCH 3/3] WIP: lavf/utils: try to avoid decoding a frame to get the codec parameters

2015-10-28 Thread Ronald S. Bultje
Hi, On Sat, Oct 17, 2015 at 4:34 PM, Matthieu Bouron wrote: > From: Matthieu Bouron > > Avoid decoding twice images such as jpeg and png, once in the > avformat_find_stream_info and once when the actual decode is made. > > The decoder must honor the skip_frame option in order to skip > decoding

Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

2015-10-28 Thread Hendrik Leppkes
On Wed, Oct 28, 2015 at 6:07 PM, Derek Buitenhuis wrote: > Enjoy my half-assed / useless review. > >> +#ifndef SECBUFFER_ALERT >> +#define SECBUFFER_ALERT17 >> +#endif > > Why? I think it was needed on some configuration, I'll verify. > >> +SecPkgContext_StreamSizes Sizes; >

Re: [FFmpeg-devel] [PATCH 3/3] WIP: lavf/utils: try to avoid decoding a frame to get the codec parameters

2015-10-28 Thread Hendrik Leppkes
On Sat, Oct 17, 2015 at 10:34 PM, Matthieu Bouron wrote: > From: Matthieu Bouron > > Avoid decoding twice images such as jpeg and png, once in the > avformat_find_stream_info and once when the actual decode is made. > > The decoder must honor the skip_frame option in order to skip > decoding. For

Re: [FFmpeg-devel] [PATCH 3/3] WIP: lavf/utils: try to avoid decoding a frame to get the codec parameters

2015-10-28 Thread wm4
On Wed, 28 Oct 2015 13:30:59 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Sat, Oct 17, 2015 at 4:34 PM, Matthieu Bouron > wrote: > > > From: Matthieu Bouron > > > > Avoid decoding twice images such as jpeg and png, once in the > > avformat_find_stream_info and once when the actual decode is m

[FFmpeg-devel] [PATCH] avfilter/asrc_sine: fix options typos

2015-10-28 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/asrc_sine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/asrc_sine.c b/libavfilter/asrc_sine.c index f361faa..2a2f3c3 100644 --- a/libavfilter/asrc_sine.c +++ b/libavfilter/asrc_sine.c @@ -69,8 +69,8 @@ typedef str

Re: [FFmpeg-devel] [PATCH] avfilter/asrc_sine: fix options typos

2015-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXIV, Kyle Swanson a écrit : > Signed-off-by: Kyle Swanson > --- > libavfilter/asrc_sine.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Of course ok, thanks. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] swr: do not reject channel layouts that use channel 63

2015-10-28 Thread wm4
On Mon, 26 Oct 2015 20:31:00 +0100 Michael Niedermayer wrote: > On Sun, Oct 25, 2015 at 06:31:02PM +0100, wm4 wrote: > > Channel layouts are essentially uint64_t, and every value is valid. > > --- > > libswresample/options.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde >> > wrote: >> >> >> >> On

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 11:44 AM, Clément Bœsch wrote: > On Wed, Oct 28, 2015 at 10:34:37AM -0400, Ronald S. Bultje wrote: > [...] >> You could do the same for the last 4 values of the cinething changes, they >> are clearly not enums, but flags. Flags are always unsigned, so if enums >> are unsign

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 11:33 AM, Hendrik Leppkes wrote: > On Wed, Oct 28, 2015 at 4:00 PM, Ganesh Ajjanagadde > wrote: >> On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje >> wrote: >>> Hi, >>> >>> On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde >>> wrote: On Wed, Oct 28, 2015

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde > > wrote: > >> > >> On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje > >> wrote: > >> > Hi, > >>

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde >> > wrote: >> >> >> >> On W

Re: [FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

2015-10-28 Thread Philip Langdale
On Wed, 28 Oct 2015 14:53:42 +0800 Agatha Hu wrote: > --- > libavcodec/nvenc.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index 0e6ef43..083e494 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -912

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 2:46 PM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje >

Re: [FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

2015-10-28 Thread wm4
On Wed, 28 Oct 2015 12:21:05 -0400 "Ronald S. Bultje" wrote: > --- > libavcodec/vp9_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c > index 0437097..6713850 100644 > --- a/libavcodec/vp9_parser.c > +++ b/libavco

Re: [FFmpeg-devel] [PATCH] avfilter/asrc_sine: fix options typos

2015-10-28 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 07:10:24PM +0100, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXIV, Kyle Swanson a écrit : > > Signed-off-by: Kyle Swanson > > --- > > libavfilter/asrc_sine.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Of course ok, thanks. applied thanks

Re: [FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 3:44 PM, wm4 wrote: > On Wed, 28 Oct 2015 12:21:05 -0400 > "Ronald S. Bultje" wrote: > > > --- > > libavcodec/vp9_parser.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c > > index 0437

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-28 Thread Dale Curtis
On Sun, Oct 25, 2015 at 4:56 AM, Ronald S. Bultje wrote: > > So this is likely because we init all tables instead of just these that we > need, right? So how about having one ff_once per table? That should be > trivial to implement. Just so we're all on the same page, this is trivial, but will g

Re: [FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

2015-10-28 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 11:52:50AM -0700, Philip Langdale wrote: > On Wed, 28 Oct 2015 14:53:42 +0800 > Agatha Hu wrote: > > > --- > > libavcodec/nvenc.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > > index 0e6e

Re: [FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

2015-10-28 Thread Timo Rothenpieler
> --- > libavcodec/nvenc.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index 0e6ef43..083e494 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -912,6 +912,11 @@ static av_cold int nvenc_encode_init(AVCod

[FFmpeg-devel] [PATCH 1/2] avcodec: add ADPCM AICA decoder

2015-10-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 13 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 +++ 5 files changed, 23 insertions(+) diff --git a/libavcodec/Makefile b/libavcodec/Makefi

[FFmpeg-devel] [PATCH 2/2] avformat: add DC STR demuxer

2015-10-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/dcstr.c | 79 3 files changed, 81 insertions(+) create mode 100644 libavformat/dcstr.c diff --git a/libavformat/Makefile b/libavfor

Re: [FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

2015-10-28 Thread wm4
On Wed, 28 Oct 2015 16:05:49 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Wed, Oct 28, 2015 at 3:44 PM, wm4 wrote: > > > On Wed, 28 Oct 2015 12:21:05 -0400 > > "Ronald S. Bultje" wrote: > > > > > --- > > > libavcodec/vp9_parser.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 3:05 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 2:46 PM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >> O

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

2015-10-28 Thread Marton Balint
On Sun, 18 Oct 2015, Bodecs Bela wrote: [...] It can be anything if it does not change existing behaviour, a complex specifier can be split to basic specifiers without worrying about the syntax of the basic specifier and if there is a well defined rule for escaping special characters. Also i

Re: [FFmpeg-devel] [PATCH] avutil/ripemd: make rol macro more robust by adding parentheses

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 11:52 AM, James Almer wrote: > On 10/27/2015 9:00 PM, Ganesh Ajjanagadde wrote: >> This ensures that the macro remains correct in the sense of allowing >> expressions for value and bits, by placing the value and bits expressions >> within >> parentheses. >> >> Signed-off-b

Re: [FFmpeg-devel] [PATCH] avcodec/motion_est_template: replace qsort with AV_QSORT

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 10:00 AM, Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 10:51:29PM -0400, Ganesh Ajjanagadde wrote: >> This code is in a performance critical section. AV_QSORT is >> substantially faster due to the inlining of the comparison callback. >> Thus, the increase in perform

Re: [FFmpeg-devel] [PATCH] avdevice/dshow_enummediatypes: check return of av_malloc

2015-10-28 Thread Michael Niedermayer
On Tue, Oct 27, 2015 at 08:09:03PM -0400, Ganesh Ajjanagadde wrote: > Untested. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavdevice/dshow_enummediatypes.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavdevice/dshow_enummediatypes.c > b/libavdevice/dshow_enummediatypes.c

Re: [FFmpeg-devel] [PATCH] avdevice/dshow_enummediatypes: check return of av_malloc

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 10:00 PM, Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 08:09:03PM -0400, Ganesh Ajjanagadde wrote: >> Untested. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavdevice/dshow_enummediatypes.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libav

Re: [FFmpeg-devel] [PATCH] vp9_parser: don't overwrite cached timestamps with nopts.

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 5:51 PM, wm4 wrote: > On Wed, 28 Oct 2015 16:05:49 -0400 > "Ronald S. Bultje" wrote: > > > Hi, > > > > On Wed, Oct 28, 2015 at 3:44 PM, wm4 wrote: > > > > > On Wed, 28 Oct 2015 12:21:05 -0400 > > > "Ronald S. Bultje" wrote: > > > > > > > --- > > > > libavcodec/vp9

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_mpa_robust: change assignment to equality test in conditional

2015-10-28 Thread Michael Niedermayer
On Tue, Oct 27, 2015 at 07:58:03PM -0400, Ganesh Ajjanagadde wrote: > In the spirit of commit 8199908fdf9b3797cceaea9d1e2fc09d02ef7309, likely > typo originally. > > Found by enabling -Wparentheses on clang 3.7 and running a manual audit. > To the best of my knowledge, no such instances remain. >

[FFmpeg-devel] [PATCH] avfilter/tremolo: fix wavetable buffer size

2015-10-28 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/af_tremolo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_tremolo.c b/libavfilter/af_tremolo.c index 50df2e4..572e9e3 100644 --- a/libavfilter/af_tremolo.c +++ b/libavfilter/af_tremolo.c @@ -72,7 +72,7 @@ stat

Re: [FFmpeg-devel] [PATCH] avfilter/tremolo: fix wavetable buffer size

2015-10-28 Thread Kyle Swanson
This fixes an obvious bug for sub 1-hz modulation frequencies. Wavetable buffer was too small for frequencies under 1 hz, and also too big for frequencies above 1hz. One cycle is all we need. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://f

[FFmpeg-devel] [PATCH] avutil/mathematics: make av_gcd more robust

2015-10-28 Thread Ganesh Ajjanagadde
This ensures that no undefined behavior is invoked, while retaining identical return values in all cases and at no loss of performance (identical asm on clang and gcc). Essentially, this patch exchanges undefined behavior with implementation defined behavior, a strict improvement. Rationale: 1. Th

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 10:09 AM, Ganesh Ajjanagadde wrote: > On Tue, Oct 27, 2015 at 8:18 PM, Ganesh Ajjanagadde > wrote: >> av_gcd is now always defined regardless of input. This documents this >> change in the "documented API". Two benefits (closely related): >> 1. The function is robust, and

Re: [FFmpeg-devel] [PATCH] avutil/opt: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:12 PM, Ganesh Ajjanagadde wrote: > Some warnings do get triggered that will need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/opt.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/opt.h b/libavutil/opt.h > index 753434d..5abe

Re: [FFmpeg-devel] [PATCH] avutil/frame: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 7:47 PM, Ganesh Ajjanagadde wrote: > This is going to trigger a lot of warnings all over the place that need > fixing. Main culprits are in avfilter, when one tries to copy a frame > without checking whether src and dest formats actually are compatible. > > Signed-off-by: G

Re: [FFmpeg-devel] [PATCH] avutil/opencl_internal: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:24 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/opencl_internal.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/opencl_internal.h b/libavutil/opencl_internal.h > index dacd930..a4f5885 100644 > --- a/libavutil/

Re: [FFmpeg-devel] [PATCH] avutil/samplefmt: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:31 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/samplefmt.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/samplefmt.h b/libavutil/samplefmt.h > index 6a8a031..246147f 100644 > --- a/libavutil/samplefmt.h > ++

Re: [FFmpeg-devel] [PATCHv2] avutil/buffer: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 7:10 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/buffer.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavutil/buffer.h b/libavutil/buffer.h > index b4399fd..e0dbc8a 100644 > --- a/libavutil/buffer.h > +++ b/libavut

Re: [FFmpeg-devel] [PATCH 1/2] swresample/swresample: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 9:31 PM, Ganesh Ajjanagadde wrote: > This will trigger a few warnings (e.g in avfilter) that need to be > fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libswresample/swresample.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libswresample/swresa

Re: [FFmpeg-devel] [PATCH 1/2] swscale/swscale_internal: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 9:46 PM, Ganesh Ajjanagadde wrote: > This triggers a few warnings that need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libswscale/swscale_internal.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libswscale/swscale_internal.h b/libswscale

Re: [FFmpeg-devel] [PATCH] avutil/pixdesc: add av_warn_unused_result to av_pix_fmt_get_chroma_sub_sample

2015-10-28 Thread Ganesh Ajjanagadde
On Fri, Oct 16, 2015 at 5:17 PM, Ganesh Ajjanagadde wrote: > On Fri, Oct 16, 2015 at 11:39 AM, Michael Niedermayer > wrote: >> On Thu, Oct 15, 2015 at 07:20:30PM -0400, Ganesh Ajjanagadde wrote: >>> This will trigger a bunch of warnings (rightfully so). This API has been >>> abused, see the Doxyg

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:24 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 10:22 PM, Ganesh Ajjanagadde wrote: >> On Thu, Oct 15, 2015 at 10:16 PM, James Almer wrote: >>> On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote: On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: >

Re: [FFmpeg-devel] [PATCH] avutil/audio_fifo: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Fri, Oct 16, 2015 at 5:16 PM, Ganesh Ajjanagadde wrote: > On Fri, Oct 16, 2015 at 11:44 AM, Michael Niedermayer > wrote: >> On Thu, Oct 15, 2015 at 07:26:04PM -0400, Ganesh Ajjanagadde wrote: >>> This one should not trigger any warnings, but will be useful for future >>> robustness. >>> >>> Si

Re: [FFmpeg-devel] [PATCH] avutil/wchar_filename: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 21, 2015 at 11:46 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:01 PM, Ganesh Ajjanagadde > wrote: >> Current code is fine, this just adds robustness. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavutil/wchar_filename.h | 1 + >> 1 file changed, 1 insertion(+) >>

Re: [FFmpeg-devel] [PATCHv2] avcodec/dvenc: silence -Wdiscarded-qualifiers

2015-10-28 Thread Ganesh Ajjanagadde
On Sun, Oct 4, 2015 at 8:44 PM, Ganesh Ajjanagadde wrote: > On Sun, Sep 20, 2015 at 9:09 AM, Ganesh Ajjanagadde > wrote: >> s->frame is non-const, so this casts them explicitly. >> This suppresses -Wdiscarded-qualifiers seen in e.g >> http://fate.ffmpeg.org/log.cgi?time=20150919100330&log=compile

Re: [FFmpeg-devel] [PATCH] avutil/opencl: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Fri, Oct 16, 2015 at 8:02 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 11:17 PM, highgod0401 wrote: >> >> From: Ganesh Ajjanagadde >> Date: 2015-10-16 08:08 >> To: ffmpeg-devel >> CC: Ganesh Ajjanagadde >> Subject: [FFmpeg-devel] [PATCH] avutil/opencl: add av_warn_unused_result >> T

Re: [FFmpeg-devel] [PATCH 03/11] avdevice/sndio: add av_warn_unused_result

2015-10-28 Thread Ganesh Ajjanagadde
On Fri, Oct 16, 2015 at 5:31 PM, Ganesh Ajjanagadde wrote: > On Fri, Oct 16, 2015 at 11:46 AM, Michael Niedermayer > wrote: >> On Thu, Oct 15, 2015 at 10:22:17PM -0400, Ganesh Ajjanagadde wrote: >>> This does not trigger any warnings, but adds robustness. >>> Untested, as my configure does not co

[FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-28 Thread Ganesh Ajjanagadde
This is more concise and conveys the intent better. Furthermore, it is likely more precise as well due to lack of floating point division. Signed-off-by: Ganesh Ajjanagadde --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index f91fb7b..148c21b

[FFmpeg-devel] [PATCH 02/11] avcodec/nellymoserenc: use log2 instead of log()/M_LN2

2015-10-28 Thread Ganesh Ajjanagadde
This is likely more precise and conveys the intent better. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/nellymoserenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nellymoserenc.c b/libavcodec/nellymoserenc.c index d7368d0..d998dba 100644 --- a/libavcodec/n

[FFmpeg-devel] [PATCH 03/11] avcodec/snowenc: use log2 instead of log() / log(2...)

2015-10-28 Thread Ganesh Ajjanagadde
This is likely more precise and conveys the intent better. The expression has also been accordingly simplified. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/snowenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index 7e8269c

  1   2   >