Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=32.

2019-08-22 Thread Moritz Barsnick
On Wed, Aug 21, 2019 at 18:03:23 -0700, James Zern wrote: > > From: elliottk > > Current default is 256kbps, which produces inconsistent > > results (too high for low-res, too low for hi-res). > > Use CRF instead, which will adapt. > > lgtm. I'll apply this soon if there aren't any other

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust max_pixels for IDCIN

2019-08-22 Thread Michael Niedermayer
On Thu, Aug 22, 2019 at 10:23:40AM +0200, Paul B Mahol wrote: > On Thu, Aug 22, 2019 at 10:16 AM Michael Niedermayer > wrote: > > > On Thu, Aug 22, 2019 at 10:09:30AM +0200, Paul B Mahol wrote: > > > Why not fix issues listed in decoder code instead of this hack? > > > > I can improve the VLC

Re: [FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-22 Thread Moritz Barsnick
On Thu, Aug 22, 2019 at 08:56:28 +0800, Guo, Yejun wrote: > +/* This list must be iterated in reverse, so for the case that > + * two regions overlapping, the more important area takes effect. Nit: "overlap" or "are overlapping". > +#ifdef VPX_CTRL_VP9E_SET_ROI_MAP [...] > +#endif > + >

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-22 Thread Paul B Mahol
On Wed, Aug 21, 2019 at 10:10 PM Marton Balint wrote: > > > On Tue, 20 Aug 2019, Carl Eugen Hoyos wrote: > > > Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol < > one...@gmail.com>: > > > >> I kindly ask that following commit: > d702769213487923c0fb0abe4b61f4d9ebddb88b > > > > I still

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust max_pixels for IDCIN

2019-08-22 Thread Paul B Mahol
Why not fix issues listed in decoder code instead of this hack? On Thu, Aug 22, 2019 at 12:21 AM Michael Niedermayer wrote: > Fixes: Timeout (128sec -> 6sec) > Fixes: > 16568/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IDCIN_fuzzer-5675004095627264 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 2/4] avformat/vividas: Check av_xiphlacing() return value before use

2019-08-22 Thread Paul B Mahol
probably ok On Thu, Aug 22, 2019 at 12:21 AM Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 16277/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5696629440512000 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-22 Thread Michael Niedermayer
On Wed, Aug 21, 2019 at 10:10:02PM +0200, Marton Balint wrote: > > > On Tue, 20 Aug 2019, Carl Eugen Hoyos wrote: > > >Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol : > > > >>I kindly ask that following commit: d702769213487923c0fb0abe4b61f4d9ebddb88b > > > >I still believe what the

Re: [FFmpeg-devel] [PATCH 1/1] avformat/matroska: fully parse stsd atom in v_quicktime tracks

2019-08-22 Thread Stanislav Ionascu
Hi! On Tue, Aug 20, 2019 at 10:19 AM Michael Niedermayer wrote: > > On Sun, Aug 18, 2019 at 12:32:03PM +0200, Stanislav Ionascu wrote: > > Hi, > > > > thanks for looking into this. > > > > On Sun, Aug 18, 2019 at 4:55 AM Andreas Rheinhardt > > wrote: > > > > > > Hello, > > > > > > I am no

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-22 Thread Michael Niedermayer
On Wed, Aug 21, 2019 at 01:58:52PM -0700, Niki Bowe wrote: > On Mon, Aug 19, 2019 at 7:22 PM Carl Eugen Hoyos wrote: > > > > > This score would mean that mjpeg can never be detected. > > I suspect you have to reduce one of the demuxers to "- 1". > > > > > Thanks Carl. > Attached patch to reduce

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/iff: Check for overlap in cmap_read_palette()

2019-08-22 Thread Moritz Barsnick
On Thu, Aug 22, 2019 at 00:18:54 +0200, Michael Niedermayer wrote: Nits: > Fixes: undefined mempcpy() use memcpy > +avpriv_request_sample(avctx, "overlaping mask"); overlapping Cheers, Moritz ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust max_pixels for IDCIN

2019-08-22 Thread Michael Niedermayer
On Thu, Aug 22, 2019 at 10:09:30AM +0200, Paul B Mahol wrote: > Why not fix issues listed in decoder code instead of this hack? I can improve the VLC reader and will probably look into that but i dont think that will provide the factor of 2000 speedup needed to avoid the adjustment. It might

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust max_pixels for IDCIN

2019-08-22 Thread Paul B Mahol
On Thu, Aug 22, 2019 at 10:16 AM Michael Niedermayer wrote: > On Thu, Aug 22, 2019 at 10:09:30AM +0200, Paul B Mahol wrote: > > Why not fix issues listed in decoder code instead of this hack? > > I can improve the VLC reader and will probably look into that > but i dont think that will provide

Re: [FFmpeg-devel] EOF and IO error checking

2019-08-22 Thread Marton Balint
On Sun, 18 Aug 2019, Michael Niedermayer wrote: On Sat, Aug 17, 2019 at 09:10:59PM +0200, Marton Balint wrote: Hi, As you might now avio_feof() returns true both in case of actual EOF and in case of IO errors. Some demuxers (matroska) have special handling for this exact reason, e.g.: if

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust max_pixels for IDCIN

2019-08-22 Thread Paul B Mahol
On Thu, Aug 22, 2019 at 11:24 AM Tomas Härdin wrote: > tor 2019-08-22 klockan 10:34 +0200 skrev Michael Niedermayer: > > On Thu, Aug 22, 2019 at 10:23:40AM +0200, Paul B Mahol wrote: > > > On Thu, Aug 22, 2019 at 10:16 AM Michael Niedermayer < > > > mich...@niedermayer.cc> > > > wrote: > > > > >

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-22 Thread Paul B Mahol
On Thu, Aug 22, 2019 at 11:19 AM Carl Eugen Hoyos wrote: > Am Mi., 21. Aug. 2019 um 23:05 Uhr schrieb Niki Bowe > : > > > > On Mon, Aug 19, 2019 at 7:22 PM Carl Eugen Hoyos > wrote: > > > > > > > > This score would mean that mjpeg can never be detected. > > > I suspect you have to reduce one of

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-22 Thread Carl Eugen Hoyos
Am Mi., 21. Aug. 2019 um 23:05 Uhr schrieb Niki Bowe : > > On Mon, Aug 19, 2019 at 7:22 PM Carl Eugen Hoyos wrote: > > > > > This score would mean that mjpeg can never be detected. > > I suspect you have to reduce one of the demuxers to "- 1". > > > > > Thanks Carl. > Attached patch to reduce

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust max_pixels for IDCIN

2019-08-22 Thread Tomas Härdin
tor 2019-08-22 klockan 10:34 +0200 skrev Michael Niedermayer: > On Thu, Aug 22, 2019 at 10:23:40AM +0200, Paul B Mahol wrote: > > On Thu, Aug 22, 2019 at 10:16 AM Michael Niedermayer < > > mich...@niedermayer.cc> > > wrote: > > > > > On Thu, Aug 22, 2019 at 10:09:30AM +0200, Paul B Mahol wrote: >

[FFmpeg-devel] [PATCH]lavf/r3d: Check avio_read() return value

2019-08-22 Thread Carl Eugen Hoyos
Hi! Attached patch fixes usage of uninitialized data reading broken r3d files. Please review, Carl Eugen From efce9940b890b9cf5a9e7400b05be10f6906fbb1 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 22 Aug 2019 12:02:36 +0200 Subject: [PATCH] lavf/r3d: Check avio_read() return value.

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support decoding ACELP.KELVIN

2019-08-22 Thread Carl Eugen Hoyos
Am Mo., 19. Aug. 2019 um 23:37 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Attached patch fixes tickets #4799 and #8081, thanks to Paul for his help. New patch attached. Carl Eugen From 8af0b279ad0c25425d075498f60b0770528687a2 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 19 Aug

Re: [FFmpeg-devel] [v3] avformat/flvdec: delete unused code

2019-08-22 Thread Tao Zhang
Michael Niedermayer 于2019年8月18日周日 下午5:49写道: > > On Wed, Aug 14, 2019 at 11:07:18AM +0800, leozhang wrote: > > Reviewed-by: Carl Eugen Hoyos > > Signed-off-by: leozhang > > --- > > libavformat/flvdec.c | 17 - > > 1 file changed, 17 deletions(-) > > probably ok Hi Michael, I'm

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-22 Thread Carl Eugen Hoyos
Am Do., 22. Aug. 2019 um 12:42 Uhr schrieb Michael Niedermayer : > > On Wed, Aug 21, 2019 at 06:28:08PM +0200, Anthony Delannoy wrote: > > Hi, > > > > In the attached files is the first implementation of: > > * dvb descriptors parsing api to ease their use on different sections (for > > now i've

Re: [FFmpeg-devel] [PATCH v2] Add assembly support for -fsanitize=hwaddress tagged globals.

2019-08-22 Thread Carl Eugen Hoyos
Am Mi., 21. Aug. 2019 um 21:27 Uhr schrieb Peter Collingbourne : > > As of LLVM r368102, Clang will set a pointer tag in bits 56-63 of the > address of a global when compiling with -fsanitize=hwaddress. This requires > an adjustment to assembly code that takes the address of such globals: the >

[FFmpeg-devel] [PATCH v2] libavfilter: Add dehaze-filter option in existing derain.

2019-08-22 Thread Xuewei Meng
Add the support of dehaze filter in existing derain filter source code. As the processing procedure in FFmpeg is the same for current derain and dehaze, we reuse the derain filter source code. The model training and generation scripts are in repo https://github.com/XueweiMeng/derain_filter.git

Re: [FFmpeg-devel] [PATCH] libavfilter: Add dehaze-filter option in existing derain filter.

2019-08-22 Thread Liu Steven
> 在 2019年8月22日,下午5:08,Xuewei Meng 写道: > > Add the support of dehaze filter in existing derain filter source > code. As the processing procedure in FFmpeg is the same for current > derain and dehaze, we reuse the derain filter source code. The > model training and generation scripts are in repo

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: do not ignore bad size errors

2019-08-22 Thread Tomas Härdin
ons 2019-08-21 klockan 21:54 +0200 skrev Marton Balint: > > On Sun, 18 Aug 2019, Tomas Härdin wrote: > > > lör 2019-08-17 klockan 21:41 +0200 skrev Marton Balint: > > > The return value was unintentionally lost after > > > 00a2652df3bf25a27d174cc67ed508b5317cb115. > > > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-22 Thread Tomas Härdin
ons 2019-08-21 klockan 12:47 -0700 skrev Baptiste Coudurier: > Hey guys, > > > > On Aug 19, 2019, at 9:54 AM, Thomas Mundt wrote: > > > > Am Fr., 16. Aug. 2019 um 23:31 Uhr schrieb Tomas Härdin > > : > > > tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt: > > > > Am Do., 15. Aug. 2019 um

[FFmpeg-devel] [PATCH] libavfilter: Add dehaze-filter option in existing derain filter.

2019-08-22 Thread Xuewei Meng
Add the support of dehaze filter in existing derain filter source code. As the processing procedure in FFmpeg is the same for current derain and dehaze, we reuse the derain filter source code. The model training and generation scripts are in repo https://github.com/XueweiMeng/derain_filter.git.

Re: [FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-22 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Moritz Barsnick > Sent: Thursday, August 22, 2019 3:31 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add ROI-based >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp5/6/8: use vpX_rac_is_end()

2019-08-22 Thread Michael Niedermayer
On Wed, Aug 21, 2019 at 07:41:00PM +1000, Peter Ross wrote: > On Tue, Aug 20, 2019 at 11:51:48AM +0200, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vp5.c | 2 +- > > libavcodec/vp6.c | 2 +- > > libavcodec/vp8.c | 8 > > 3 files changed, 6

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/iff: Check for overlap in cmap_read_palette()

2019-08-22 Thread Michael Niedermayer
On Thu, Aug 22, 2019 at 09:32:39AM +0200, Moritz Barsnick wrote: > On Thu, Aug 22, 2019 at 00:18:54 +0200, Michael Niedermayer wrote: > > Nits: > > > Fixes: undefined mempcpy() use > > memcpy > > > +avpriv_request_sample(avctx, "overlaping mask"); > > overlapping locally

Re: [FFmpeg-devel] [PATCH 2/4] avformat/vividas: Check av_xiphlacing() return value before use

2019-08-22 Thread Michael Niedermayer
On Thu, Aug 22, 2019 at 09:44:02AM +0200, Paul B Mahol wrote: > probably ok will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire signature.asc

Re: [FFmpeg-devel] [PATCH 1/4] avformat/realtextdec: free queue on error

2019-08-22 Thread Michael Niedermayer
On Wed, Aug 21, 2019 at 08:48:25PM -0300, James Almer wrote: > On 8/21/2019 7:18 PM, Michael Niedermayer wrote: > > Fixes: memleak > > Fixes: > > 16277/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5696629440512000 > > > > Found-by: continuous fuzzing process > >

[FFmpeg-devel] [PATCH] avformat/mov: improve timecode calculation

2019-08-22 Thread Paul B Mahol
Hi, patch attached. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-22 Thread Michael Niedermayer
On Wed, Aug 21, 2019 at 06:28:08PM +0200, Anthony Delannoy wrote: > Hi, > > In the attached files is the first implementation of: > * dvb descriptors parsing api to ease their use on different sections (for > now i've only implemented EIT section) > * EIT table and subtable > * EIT callback in

Re: [FFmpeg-devel] [PATCH v15 06/15] lavc/tiff: Fix edge case with full-length/width tiles

2019-08-22 Thread Moritz Barsnick
On Tue, Aug 20, 2019 at 16:37:38 +0300, Nick Renieris wrote: > In an image [1], the height was equal to the tile length (full-height Nit: "[1]" doesn't refer to anything here. Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v15 08/15] lavc/tiff: Force DNG pixel data endianness on an edge case

2019-08-22 Thread Moritz Barsnick
On Tue, Aug 20, 2019 at 16:37:40 +0300, Nick Renieris wrote: > +/* Force endianness as mentioned in 'DNG Specification: Chapter 3: > BitsPerSample' > +NOTE: The spec actually specifies big-endian, not sure why we > need little-endian, > + but such images

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vsrc_mptestsrc: simplify the code and change the type of frame

2019-08-22 Thread Moritz Barsnick
On Mon, Aug 12, 2019 at 23:39:52 +0800, lance.lmw...@gmail.com wrote: This looks very wrong. Does it work? > -if (tt == TEST_ALL && frame%test->max_frames) /* draw a black frame at > the beginning of each test */ > -tt = (frame/test->max_frames)%(TEST_NB-1); > +frame =

Re: [FFmpeg-devel] [PATCH v15 05/15] lavc/jpegtables: Handle multiple mappings to the same value

2019-08-22 Thread Moritz Barsnick
On Tue, Aug 20, 2019 at 16:37:37 +0300, Nick Renieris wrote: > Some JPEGs [1] have incorrect DHT entries that map 2 codes to This [1] becomes part of the commit message, ... > --- > > [1]: Embedded JPEGs in "X7 RAW" and "X7 CinemaDNG" samples here: >

Re: [FFmpeg-devel] [PATCH v15 03/15] lavc/tiff: Convert DNGs to sRGB color space

2019-08-22 Thread Moritz Barsnick
On Tue, Aug 20, 2019 at 16:37:35 +0300, Nick Renieris wrote: > +static float av_always_inline linear_to_srgb(float value) { > +if (value <= 0.0031308) > +return value * 12.92; > +else > +return pow(value * 1.055, 1.0 / 2.4) - 0.055; > +} Do you need the intermediate double

Re: [FFmpeg-devel] EOF and IO error checking

2019-08-22 Thread James Almer
On 8/17/2019 4:10 PM, Marton Balint wrote: > Hi, > > As you might now avio_feof() returns true both in case of actual EOF and > in case of IO errors. > > Some demuxers (matroska) have special handling for this exact reason, e.g.: > > if (avio_feof(pb)) { >     if (pb->error) { >     return

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-22 Thread Baptiste Coudurier
Hi Tomas > On Aug 22, 2019, at 3:47 AM, Tomas Härdin wrote: > > ons 2019-08-21 klockan 12:47 -0700 skrev Baptiste Coudurier: >> Hey guys, >> >> >>> On Aug 19, 2019, at 9:54 AM, Thomas Mundt wrote: >>> >>> Am Fr., 16. Aug. 2019 um 23:31 Uhr schrieb Tomas Härdin >>> : tor 2019-08-15

[FFmpeg-devel] [PATCH 2/3] avcodec/idcinvideo: Add 320x240 default maximum resolution

2019-08-22 Thread Michael Niedermayer
Fixes: Timeout (128sec -> 2ms) Fixes: 16568/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IDCIN_fuzzer-5675004095627264 See: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust max_pixels for IDCIN Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 3/3] avcodec/vqavideo: Limit resolution

2019-08-22 Thread Michael Niedermayer
Fixes: Timeout (288sec -> 1ms) Fixes: 16353/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQA_fuzzer-5633402606190592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vqavideo.c | 6 ++

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=32.

2019-08-22 Thread James Zern
Hi, On Thu, Aug 22, 2019 at 12:25 AM Moritz Barsnick wrote: > > On Wed, Aug 21, 2019 at 18:03:23 -0700, James Zern wrote: > > > From: elliottk > > > Current default is 256kbps, which produces inconsistent > > > results (too high for low-res, too low for hi-res). > > > Use CRF instead, which

Re: [FFmpeg-devel] [PATCH] avformat/mov: improve timecode calculation

2019-08-22 Thread Kieran O Leary
On Thu, 22 Aug 2019, 17:18 Paul B Mahol, wrote: > Hi, > > patch attached. > Maybe it's a Gmail issue but I see no attachment. Also for those of us unable to understand the code,what's the improvement? Best, Kieran > > ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Do not increase max_pixels

2019-08-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index d83039417c..5119a7c5da 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_parse: retry decoding SPS with complete NAL

2019-08-22 Thread Jun Li
On Tue, Aug 20, 2019 at 5:52 PM Jun Li wrote: > > > On Mon, Aug 19, 2019 at 7:24 PM Jun Li wrote: > >> Fix #6591 >> The content has no rbsp_stop_one_bit for ending the SPS, that >> causes the decoding SPS failure, results decoding frame failure as well. >> >> The patch is just adding a retry

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/idcinvideo: Add 320x240 default maximum resolution

2019-08-22 Thread Tomas Härdin
tor 2019-08-22 klockan 23:00 +0200 skrev Tomas Härdin: > tor 2019-08-22 klockan 20:09 +0200 skrev Michael Niedermayer: > > Fixes: Timeout (128sec -> 2ms) > > Fixes: > > 16568/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IDCIN_fuzzer-5675004095627264 > > > > See: [FFmpeg-devel] [PATCH 4/4]

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: do not ignore bad size errors

2019-08-22 Thread Marton Balint
On Thu, 22 Aug 2019, Tomas Härdin wrote: ons 2019-08-21 klockan 21:54 +0200 skrev Marton Balint: On Sun, 18 Aug 2019, Tomas Härdin wrote: > lör 2019-08-17 klockan 21:41 +0200 skrev Marton Balint: > > The return value was unintentionally lost after > >

Re: [FFmpeg-devel] [PATCH 2/3] avutil/imgutils: remove dead assignment

2019-08-22 Thread Marton Balint
On Sun, 18 Aug 2019, Michael Niedermayer wrote: On Sat, Aug 17, 2019 at 09:41:04PM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- libavutil/imgutils.c | 1 - 1 file changed, 1 deletion(-) LGTM Applied, thanks. Marton ___

Re: [FFmpeg-devel] [PATCH]lavf/r3d: Check avio_read() return value

2019-08-22 Thread Reimar Döffinger
On Thu, Aug 22, 2019 at 12:06:03PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes usage of uninitialized data reading broken r3d files. > > Please review, Carl Eugen > From efce9940b890b9cf5a9e7400b05be10f6906fbb1 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Thu, 22

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_parse: retry decoding SPS with complete NAL

2019-08-22 Thread James Almer
On 8/19/2019 11:24 PM, Jun Li wrote: > Fix #6591 > The content has no rbsp_stop_one_bit for ending the SPS, that > causes the decoding SPS failure, results decoding frame failure as well. > > The patch is just adding a retry with complete NALU, copied from the retry in > decode_nal_unit() > ---

[FFmpeg-devel] [PATCH] fate/als: Add test for conformance file with 512 channels.

2019-08-22 Thread Thilo Borgmann
Hi, new fate test for many channels in ALS, like requested. I already uploaded the corresponding file into fate-suite. If there are no objections, I'll commit this in a day or two. Thanks, Thilo From 5ed096ab3eac956f235e7924d52810b5ec9e8203 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date:

Re: [FFmpeg-devel] [PATCH v2] tools/target_dec_fuzzer: use refcounted packets

2019-08-22 Thread James Almer
On 8/21/2019 10:21 AM, James Almer wrote: > On 8/21/2019 6:15 AM, Tomas Härdin wrote: >> tis 2019-08-20 klockan 21:05 -0300 skrev James Almer: >>> Should reduce date copying considerably. >>> >>> Signed-off-by: James Almer >>> --- >>> Fixed a stupid mistake when checking the return value for

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: remove some dead assignments

2019-08-22 Thread Marton Balint
On Sat, 17 Aug 2019, Marton Balint wrote: Signed-off-by: Marton Balint --- libavcodec/bsf.c| 1 - libavcodec/decode.c | 1 - 2 files changed, 2 deletions(-) Applied this as well, as it was trivial enough. Regards, Marton diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index

[FFmpeg-devel] [PATCH 6/8] avcodec/v4l2_buffers: fix minor typos and whitespace

2019-08-22 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 4 ++-- libavcodec/v4l2_buffers.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index aef911f3bb..4f889509f9 100644 ---

[FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-22 Thread Guo, Yejun
example command line to verify it: ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M tmp.webm Signed-off-by: Guo, Yejun --- libavcodec/libvpxenc.c | 194 + 1 file changed, 194 insertions(+) diff --git

[FFmpeg-devel] [PATCH 4/8] avcodec/v4l2_m2m: remove trailing whitespace in output identifier

2019-08-22 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_m2m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c index 334ba0a038..746ae96a21 100644 --- a/libavcodec/v4l2_m2m.c +++ b/libavcodec/v4l2_m2m.c @@ -67,7 +67,7 @@

[FFmpeg-devel] [PATCH 3/8] avcodec/v4l2_m2m: log requested pixel formats

2019-08-22 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_m2m.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c index be13f68707..334ba0a038 100644 --- a/libavcodec/v4l2_m2m.c +++ b/libavcodec/v4l2_m2m.c @@ -135,6 +135,7 @@

[FFmpeg-devel] [PATCH 2/8] avcodec/v4l2_m2m: disable info logging during device probe

2019-08-22 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_m2m.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c index 7d65747df2..be13f68707 100644 --- a/libavcodec/v4l2_m2m.c +++ b/libavcodec/v4l2_m2m.c @@

[FFmpeg-devel] [PATCH 1/8] avcodec/v4l2_m2m: log planar mode used by driver

2019-08-22 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_m2m.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c index 427e165f58..7d65747df2 100644 --- a/libavcodec/v4l2_m2m.c +++ b/libavcodec/v4l2_m2m.c @@ -76,7 +76,9

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_parse: retry decoding SPS with complete NAL

2019-08-22 Thread Jun Li
On Thu, Aug 22, 2019 at 12:00 PM James Almer wrote: > On 8/19/2019 11:24 PM, Jun Li wrote: > > Fix #6591 > > The content has no rbsp_stop_one_bit for ending the SPS, that > > causes the decoding SPS failure, results decoding frame failure as well. > > > > The patch is just adding a retry with

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-22 Thread Tomas Härdin
tor 2019-08-22 klockan 09:17 -0700 skrev Baptiste Coudurier: > Hi Tomas > > > > On Aug 22, 2019, at 3:47 AM, Tomas Härdin wrote: > > > > ons 2019-08-21 klockan 12:47 -0700 skrev Baptiste Coudurier: > > > Hey guys, > > > > > > Yeah, it’s been an issue for quite some time, s356m mentions: > > >

[FFmpeg-devel] [PATCH 8/8] avcodec/v4l2_buffers: Add handling for NV21 and YUV420P

2019-08-22 Thread Aman Gupta
From: Dave Stevenson The single planar support was for NV21 only. Add NV21 and YUV420P support. Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index

[FFmpeg-devel] [PATCH 3/4] avcodec/omx: ensure zerocopy mode can be disabled on rpi builds

2019-08-22 Thread Aman Gupta
From: Aman Gupta fixes https://trac.ffmpeg.org/ticket/6586 Signed-off-by: Aman Gupta --- libavcodec/omx.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/omx.c b/libavcodec/omx.c index 8c722b573c..1a9a0715f8 100644 --- a/libavcodec/omx.c +++

[FFmpeg-devel] [PATCH 1/4] MAINTAINERS: add myself to OMX

2019-08-22 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta Signed-off-by: Martin Storsjö --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 84dcb411f1..7f60ef0021 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -213,6 +213,7 @@ Codecs: msvideo1.c

[FFmpeg-devel] [PATCH 4/4] avcodec/omx: Fix handling of fragmented buffers

2019-08-22 Thread Aman Gupta
From: Dave Stevenson See https://trac.ffmpeg.org/ticket/7687 If an encoded frame is returned split over two or more IL buffers due to the size, then there is a race between whether get_buffer will fail, return NULL, and a truncated frame is passed on, or IL will return the remaining part of the

[FFmpeg-devel] [PATCH 7/8] avcodec/v4l2_buffers: teach ff_v4l2_buffer_avframe_to_buf about contiguous planar formats

2019-08-22 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_buffers.c | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index 4f889509f9..3f9b8b5e31 100644 ---

[FFmpeg-devel] [PATCH 2/4] avcodec/omx: add support for -force_key_frames

2019-08-22 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/omx.c | 20 1 file changed, 20 insertions(+) diff --git a/libavcodec/omx.c b/libavcodec/omx.c index a1e5a46a54..8c722b573c 100644 --- a/libavcodec/omx.c +++ b/libavcodec/omx.c @@ -802,6 +802,26 @@ static int

[FFmpeg-devel] [PATCH 5/8] avcodec/v4l2_context: log VIDIOC_REQBUFS failures

2019-08-22 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/v4l2_context.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index efcb0426e4..4958c634bf 100644 --- a/libavcodec/v4l2_context.c +++

[FFmpeg-devel] [PATCH 1/2] avcodec/aacdec: Add FF_CODEC_CAP_INIT_CLEANUP

2019-08-22 Thread Michael Niedermayer
Fixes: memleaks Fixes: 16289/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-5200695692623872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aacdec.c | 4 ++-- 1 file

[FFmpeg-devel] [PATCH 2/2] avcodec/mpeg4videodec: Fix integer overflow in mpeg4_decode_studio_block()

2019-08-22 Thread Michael Niedermayer
Fixes: signed integer overflow: 24023040 * 112 cannot be represented in type 'int' Fixes: 16570/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5173275211071488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpegtsenc: add support for setting PCR interval for VBR streams

2019-08-22 Thread Marton Balint
On Fri, 16 Aug 2019, Andreas Håkon wrote: Hi Marton, Very good work with your series of patches on the mpegtsenc! ‐‐‐ Original Message ‐‐‐ On Thursday, 15 de August de 2019 1:51, Marton Balint wrote: Also document the algorithm for the default PCR interval. [...] + if

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-22 Thread Marton Balint
On Thu, 22 Aug 2019, Anthony Delannoy wrote: Hi fails to build on MIPS Seems to be because of these two structs within EPGTable and EPGSubTable: +struct { +int nb_descriptors; +void **descriptors; +}; I made modifications to avoid issues you encountered and put

Re: [FFmpeg-devel] [PATCH v3 3/3] lavfi: add deshake_opencl filter

2019-08-22 Thread Mark Thompson
On 08/08/2019 14:24, Jarek Samic wrote: > --- > > This filter is the subject of my GSoC project. > > This is a video stabilization / deshake filter (name undetermined, feel free > to discuss) that uses feature > point matching and RANSAC to determine a camera path, smooths the camera path >

[FFmpeg-devel] [PATCH v3] avcodec/h264_parse: retry decoding SPS with complete NAL

2019-08-22 Thread Jun Li
Fix #6591 The content has no rbsp_stop_one_bit for ending the SPS, that causes the decoding SPS failure, results decoding frame failure as well. The patch is just adding a retry with complete NALU, copied from the retry in decode_nal_unit() --- libavcodec/h264_parse.c | 20

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/idcinvideo: Add 320x240 default maximum resolution

2019-08-22 Thread Tomas Härdin
tor 2019-08-22 klockan 20:09 +0200 skrev Michael Niedermayer: > Fixes: Timeout (128sec -> 2ms) > Fixes: > 16568/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IDCIN_fuzzer-5675004095627264 > > See: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust max_pixels > for IDCIN > >