Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove sonic lossy/lossless audio

2024-03-02 Thread Vittorio Giovara
On Fri, Mar 1, 2024 at 10:34 PM Lynne wrote: > >> If it's the last case, or simply being a one-off, I can agree with > deprecating > >> and remove it next bump. But if the developer thinks they will have > time and > >> have motivation to work on it in the future, I think we should leave it > at

Re: [FFmpeg-devel] [PATCH v4 2/3] avformat/flvenc: support enhanced flv PacketTypeMetadata

2024-03-02 Thread Andreas Rheinhardt
zhupengfei via ffmpeg-devel: > From: Zhu Pengfei <411294...@qq.com> > > Signed-off-by: Zhu Pengfei <411294...@qq.com> > --- > libavformat/flvenc.c | 142 +++ > 1 file changed, 142 insertions(+) > > diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c

[FFmpeg-devel] [PATCH v4 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-02 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvdec.c | 178 ++- 1 file changed, 177 insertions(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index e25b5bd163..d0806c5338

[FFmpeg-devel] [PATCH v4 2/3] avformat/flvenc: support enhanced flv PacketTypeMetadata

2024-03-02 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvenc.c | 142 +++ 1 file changed, 142 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index f6d10f331c..ae7ea84bad 100644 ---

[FFmpeg-devel] [PATCH v4 3/3] fate/flvenc: support enhanced flv PacketTypeMetadata

2024-03-02 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- tests/fate/lavf-container.mak| 2 ++ tests/ref/fate/enhanced-flv-hevc | 4 ++-- tests/ref/fate/enhanced-flv-vp9 | 4 ++-- tests/ref/lavf-fate/hevc.flv | 3 +++ 4 files changed, 9 insertions(+), 4

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-02 Thread Rémi Denis-Courmont
Le lauantaina 2. maaliskuuta 2024, 9.42.06 EET flow gg a écrit : > You would need a lot fewer if/else if you passed the order/bit-width instead of the size as macro parameter. Similarly, this can be folded as a single .else: +.elseif \type == 127 +li t1, 127 +.elseif \type

[FFmpeg-devel] [PATCH] avcodec/vvcdec: fix boundary strength when IBC involved

2024-03-02 Thread Nuo Mi
The following cases should set bs to 1: If the prediction modes are not the same. If both prediction modes are MODE_IBC, but the motion vector delta is larger than 8 of 1/16 pixels. see 8.8.3.5 How to reproduce it: vvencapp -i sintel_trailer_2k_1080p24.y4m --preset fast --additional "IBC=1" -o

[FFmpeg-devel] [PATCH 2/2] lavc/vc1dsp: R-V V mspel_pixels

2024-03-02 Thread flow gg
Here adjusting the order, rather than simply using .rept, will be 13%-24% faster. From 07aa3e2eff0fe1660ac82dec5d06d50fa4c433a4 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Wed, 28 Feb 2024 16:32:39 +0800 Subject: [PATCH 2/2] lavc/vc1dsp: R-V V mspel_pixels

[FFmpeg-devel] [PATCH 1/2] checkasm/vc1dsp: add mspel_pixels test

2024-03-02 Thread flow gg
From efcb91959cb373145f2fc9fcbfcc6659610172cc Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 1 Mar 2024 19:45:53 +0800 Subject: [PATCH 1/2] checkasm/vc1dsp: add mspel_pixels test --- tests/checkasm/vc1dsp.c | 37 + 1 file changed, 37 insertions(+) diff

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-02 Thread flow gg
Okay, reduced if/else in the response. Rémi Denis-Courmont 于2024年3月2日周六 17:03写道: > Le lauantaina 2. maaliskuuta 2024, 9.42.06 EET flow gg a écrit : > > > > You would need a lot fewer if/else if you passed the order/bit-width > instead > of the size as macro parameter. > > Similarly, this can be

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-02 Thread James Almer
On 3/2/2024 5:51 AM, zhupengfei via ffmpeg-devel wrote: @@ -1100,8 +1262,17 @@ retry: video_codec_id = avio_rb32(s->pb); size -= 4; } -if ((flags & FLV_VIDEO_FRAMETYPE_MASK) == FLV_FRAME_VIDEO_INFO_CMD) + +if (enhanced_flv && stream_type ==

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-02 Thread Sean McGovern
On Sat, Mar 2, 2024, 18:19 Michael Niedermayer wrote: > On Sun, Mar 03, 2024 at 12:06:14AM +0100, Sebastian Ramacher wrote: > > On 2024-03-02 23:55:38 +0100, Michael Niedermayer wrote: > > > On Tue, Jan 23, 2024 at 08:22:41PM +0100, Michael Niedermayer wrote: > > > > Hi all > > > > > > > > As it

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: check pred flag to fix undefined beavhiours

2024-03-02 Thread Andreas Rheinhardt
Nuo Mi: > libavcodec/vvc/vvc_inter.c:823:18: runtime error: signed integer overflow: > 1426128896 + 1426128896 cannot be represented in type 'int' > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior > libavcodec/vvc/vvc_inter.c:823:18 > --- > libavcodec/vvc/vvc_inter.c | 15

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > How has this slipped through? Answer: AVIOContext starts with an AVClass* that is unset when using ffio_init_context(). Therefore the av_freep() leads to freeing of a NULL pointer which does not segfault. > Btw: This patchset is

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavformat/dvdvideo: add DVD-Video demuxer, powered by libdvdread and libdvdnav

2024-03-02 Thread James Almer
On 3/2/2024 2:03 PM, Jean-Baptiste Kempf wrote: Hello, This is missing an "enabled gpl" in the configure. The libraries were added to EXTERNAL_LIBRARY_GPL_LIST, so configure will not suceed without --enable-gpl. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-02 Thread Ronald S. Bultje
Hi, On Sat, Mar 2, 2024 at 12:37 AM Gyan Doshi wrote: > [..] > This recusal may be effected either directly by >the TC member, or by a vote of the Community Committee (CC) > The CC is for enforcement of behavioural guidelines (CoC), not for technical matters, so this strikes me as a bit

Re: [FFmpeg-devel] [PATCH] libavcodec/h264pred: Remove pred8x8_horizontal_8_mmxext

2024-03-02 Thread Kieran Kunhya
On Sat, 2 Mar 2024 at 21:18, Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Kieran Kunhya: > > $subj > > > > Old: > > pred8x8_horizontal_8_c: 6.8 > > pred8x8_horizontal_8_mmxext: 8.6 > > pred8x8_horizontal_8_ssse3: 4.8 > > > > New: > > pred8x8_horizontal_8_c: 9.2 > >

[FFmpeg-devel] [PATCH] libavcodec/vp9dsp: Convert vp9_vert_8x8_8bpp_mmx to sse2

2024-03-02 Thread Kieran Kunhya
$subj Old: vp9_vert_8x8_8bpp_c: 8.1 vp9_vert_8x8_8bpp_mmx: 2.4 New: vp9_vert_8x8_8bpp_c: 6.8 vp9_vert_8x8_8bpp_sse2: 2.3 0001-libavcodec-vp9dsp-Convert-vp9_vert_8x8_8bpp_mmx-to-s.patch Description: Binary data ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-02 Thread Sebastian Ramacher
On 2024-03-02 23:55:38 +0100, Michael Niedermayer wrote: > On Tue, Jan 23, 2024 at 08:22:41PM +0100, Michael Niedermayer wrote: > > Hi all > > > > As it was a little difficult for me to not loose track of what is > > blocking a release. I suggest that for all release blocking issues > > open a

[FFmpeg-devel] [PATCH 1/4] avformat/dvdvideodec: Explicitly return 0 on success

2024-03-02 Thread Andreas Rheinhardt
Don't "return ret" even when ret is zero on success. Signed-off-by: Andreas Rheinhardt --- libavformat/dvdvideodec.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index 3355010356..fd1f640560 100644 ---

[FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- How has this slipped through? Btw: This patchset is based upon code inspection, not on reading actual files. libavformat/dvdvideodec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index

[FFmpeg-devel] [PATCH 4/4] avformat/dvdvideodec: Reorder allocations to simplify freeing

2024-03-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/dvdvideodec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index f2f23affb2..7f4ecf2b61 100644 --- a/libavformat/dvdvideodec.c +++

[FFmpeg-devel] [PATCH 2/4] avformat/dvdvideodec: Don't store AVInputFormat*

2024-03-02 Thread Andreas Rheinhardt
The inner AVInputFormat* of the inner mpegps-demuxer is only used once (in avformat_open_input()), so don't even store it. In fact, just use ff_mpegps_demuxer directly, as this demuxer has a configure dependency on it. Signed-off-by: Andreas Rheinhardt --- libavformat/dvdvideodec.c | 8 ++--

Re: [FFmpeg-devel] [PATCH] libavcodec/h264pred: Remove pred8x8_horizontal_8_mmxext

2024-03-02 Thread Andreas Rheinhardt
Kieran Kunhya: > $subj > > Old: > pred8x8_horizontal_8_c: 6.8 > pred8x8_horizontal_8_mmxext: 8.6 > pred8x8_horizontal_8_ssse3: 4.8 > > New: > pred8x8_horizontal_8_c: 9.2 > pred8x8_horizontal_8_sse2: 12.2 > pred8x8_horizontal_8_ssse3: 4.9 > You do realize that the SSE2 version is worse than the

Re: [FFmpeg-devel] [PATCH] libavcodec/h264pred: Remove pred8x8_horizontal_8_mmxext

2024-03-02 Thread Henrik Gramner via ffmpeg-devel
On Sat, Mar 2, 2024 at 10:13 PM Kieran Kunhya wrote: > SPLATB_LOAD m0, r0+r1*0-1, m2 > SPLATB_LOAD m1, r0+r1*1-1, m2 This adds an extra unnecessary shuffle in the SSE2 code as it splats to a full register. The easiest way of fixing it would probably be to unroll the macro and manually

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Andreas Rheinhardt
James Almer: > On 3/2/2024 12:47 PM, Andreas Rheinhardt wrote: >> Andreas Rheinhardt: >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> How has this slipped through? >> >> Answer: AVIOContext starts with an AVClass* that is unset when using >> ffio_init_context(). Therefore the av_freep() leads

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: detect synchronous metadata KLV more reliably

2024-03-02 Thread Marton Balint
On Fri, 1 Mar 2024, Marton Balint wrote: The mpegts code historically tries to strip (the first) metadata access unit header from synchronous KLV metadata, but the detection for such streams was unreliable causing strips of asynchronous metadata or ID3 as well. MISB ST 1402 specifies

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-02 Thread Michael Niedermayer
On Sat, Mar 02, 2024 at 11:07:40AM +0530, Gyan Doshi wrote: > > > On 2024-03-01 11:03 pm, Anton Khirnov wrote: > > * Any member of the TC who had a strong opinion on the question raised > >before it was raised should recuse themselves. > > > >In particular, must recuse themselves any

[FFmpeg-devel] [PATCH] avformat/mov: don't mark an item referenced by a grid as dependent if it's the primary item

2024-03-02 Thread James Almer
If it's the primary item, then it's expected to be ready for presentation even outside of the grid it belongs to. Signed-off-by: James Almer --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index

[FFmpeg-devel] [PATCH] fftools/ffprobe: Print dispositions generically

2024-03-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- fftools/ffprobe.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index ea225f14ab..ac6b92f5d6 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@

Re: [FFmpeg-devel] [PATCH] aarch64: Use regular hwcaps flags instead of HWCAP_CPUID for CPU feature detection on Linux

2024-03-02 Thread Martin Storsjö
On Wed, 28 Feb 2024, Martin Storsjö wrote: The CPU feature detection was added in 493fcde50a84cb23854335bcb0e55c6f383d55db, using HWCAP_CPUID. The argument for using that, was that HWCAP_CPUID was added much earlier in the kernel (in Linux v4.11), while the HWCAP flags for individual features

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-02 Thread Michael Niedermayer
On Tue, Jan 23, 2024 at 08:22:41PM +0100, Michael Niedermayer wrote: > Hi all > > As it was a little difficult for me to not loose track of what is > blocking a release. I suggest that for all release blocking issues > open a ticket and set Blocking to 7.0 > that way this: >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written

2024-03-02 Thread Michael Niedermayer
On Thu, Feb 29, 2024 at 02:41:22PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/iamfenc.c | 30 +- > tests/ref/fate/iamf-5_1_4 | 14 +++--- > tests/ref/fate/iamf-7_1_4 | 16 >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written

2024-03-02 Thread James Almer
On 3/2/2024 9:27 PM, Michael Niedermayer wrote: On Thu, Feb 29, 2024 at 02:41:22PM -0300, James Almer wrote: Signed-off-by: James Almer --- libavformat/iamfenc.c | 30 +- tests/ref/fate/iamf-5_1_4 | 14 +++--- tests/ref/fate/iamf-7_1_4

Re: [FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written

2024-03-02 Thread Michael Niedermayer
On Sat, Mar 02, 2024 at 09:31:09PM -0300, James Almer wrote: > On 3/2/2024 9:27 PM, Michael Niedermayer wrote: > > On Thu, Feb 29, 2024 at 02:41:22PM -0300, James Almer wrote: > > > Signed-off-by: James Almer > > > --- > > > libavformat/iamfenc.c | 30 +- >

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-02 Thread Cosmin Stejerean via ffmpeg-devel
> On Mar 2, 2024, at 11:01 AM, Ronald S. Bultje wrote: > > This recusal may be effected either directly by >> the TC member, or by a vote of the Community Committee (CC) >> > > The CC is for enforcement of behavioural guidelines (CoC), not for > technical matters, so this strikes me as a

[FFmpeg-devel] [PATCH 2/4] avformat/avio: Avoid function pointer casts

2024-03-02 Thread Andreas Rheinhardt
It is undefined behaviour to use a different type for a call than the actual type of the function. Signed-off-by: Andreas Rheinhardt --- libavformat/avio.c | 5 ++--- libavformat/librtmp.c | 6 -- libavformat/mmsh.c | 3 ++- libavformat/rtmpproto.c | 6 -- libavformat/url.h

[FFmpeg-devel] [PATCH 4/4] avformat/avio: Avoid av_strdup(NULL)

2024-03-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/avio.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index f3d10fac39..5186c2b464 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -436,15 +436,19 @@

[FFmpeg-devel] [PATCH 3/4] avformat/avio: Avoid indirection in ffio_fdopen()

2024-03-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/avio.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 1622a03d7f..f3d10fac39 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@

[FFmpeg-devel] [PATCH] libavcodec/h264pred: Remove pred8x8_horizontal_8_mmxext

2024-03-02 Thread Kieran Kunhya
$subj Old: pred8x8_horizontal_8_c: 6.8 pred8x8_horizontal_8_mmxext: 8.6 pred8x8_horizontal_8_ssse3: 4.8 New: pred8x8_horizontal_8_c: 9.2 pred8x8_horizontal_8_sse2: 12.2 pred8x8_horizontal_8_ssse3: 4.9 0001-libavcodec-h264pred-Remove-pred8x8_horizontal_8_mmxe.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] libavcodec/h264pred: Remove pred8x8_horizontal_8_mmxext

2024-03-02 Thread James Almer
On 3/2/2024 6:20 PM, Andreas Rheinhardt wrote: Kieran Kunhya: $subj Old: pred8x8_horizontal_8_c: 6.8 pred8x8_horizontal_8_mmxext: 8.6 pred8x8_horizontal_8_ssse3: 4.8 New: pred8x8_horizontal_8_c: 9.2 pred8x8_horizontal_8_sse2: 12.2 pred8x8_horizontal_8_ssse3: 4.9 You do realize that the

[FFmpeg-devel] [PATCH 1/3] avformat/rmdec: support RMHD file format

2024-03-02 Thread Peter Ross
Signed-off-by: Peter Ross --- libavformat/rmdec.c | 43 ++- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index 0f1534b582..e7f2480464 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c @@

[FFmpeg-devel] [PATCH 3/3] fate: rv60 test cases

2024-03-02 Thread Peter Ross
--- samples: https://pross.sdf.org/sandpit/test72x72.rmhd (32 KiB) https://pross.sdf.org/sandpit/test512x512.rmhd (64 KiB) tests/fate/video.mak| 8 tests/ref/fate/rv60-512x512 | 9 + tests/ref/fate/rv60-72x72 | 40 + 3 files

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread James Almer
On 3/2/2024 12:47 PM, Andreas Rheinhardt wrote: Andreas Rheinhardt: Signed-off-by: Andreas Rheinhardt --- How has this slipped through? Answer: AVIOContext starts with an AVClass* that is unset when using ffio_init_context(). Therefore the av_freep() leads to freeing of a NULL pointer which

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavformat/dvdvideo: add DVD-Video demuxer, powered by libdvdread and libdvdnav

2024-03-02 Thread Jean-Baptiste Kempf
Hello, This is missing an "enabled gpl" in the configure. BR, On Sat, 2 Mar 2024, at 09:08, Marth64 wrote: > ffmpeg | branch: master | Marth64 | Sun Feb 18 > 22:01:44 2024 -0600| [a1304272c3a0ef7c3d77c702dd466b3f11bf300f] | > committer: Anton Khirnov > > libavformat/dvdvideo: add DVD-Video

[FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: add support for Stream Groups

2024-03-02 Thread James Almer
Signed-off-by: James Almer --- fftools/ffprobe.c | 186 ++ 1 file changed, 157 insertions(+), 29 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index ea225f14ab..ec3c713849 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@

[FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: print some basic Tile Grid Stream Group parameters

2024-03-02 Thread James Almer
Signed-off-by: James Almer --- fftools/ffprobe.c | 8 1 file changed, 8 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index ec3c713849..6e66f4dfa8 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -3362,7 +3362,15 @@ static void

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-02 Thread Andreas Rheinhardt
zhupengfei via ffmpeg-devel: > From: Zhu Pengfei <411294...@qq.com> > > Signed-off-by: Zhu Pengfei <411294...@qq.com> > --- > libavformat/flvdec.c | 178 ++- > 1 file changed, 177 insertions(+), 1 deletion(-) > > diff --git a/libavformat/flvdec.c

[FFmpeg-devel] [PATCH 1/4] avformat/aviobuf: Move code specific to URLContexts to avio.c

2024-03-02 Thread Andreas Rheinhardt
This separates the URL-layer adjacent parts of the code from the parts that are also usable with custom IO. Signed-off-by: Andreas Rheinhardt --- libavformat/avio.c| 191 +- libavformat/aviobuf.c | 186

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-02 Thread Michael Niedermayer
On Sun, Mar 03, 2024 at 12:06:14AM +0100, Sebastian Ramacher wrote: > On 2024-03-02 23:55:38 +0100, Michael Niedermayer wrote: > > On Tue, Jan 23, 2024 at 08:22:41PM +0100, Michael Niedermayer wrote: > > > Hi all > > > > > > As it was a little difficult for me to not loose track of what is > > >

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: fix -pgc and -pg options

2024-03-02 Thread Marth64
In merged DVD patch, -pgc and -pg options were broken. While these are rather advanced options, they are the only means to get content for some strangely authored discs. Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 23 +-- 1 file changed, 13 insertions(+), 10

Re: [FFmpeg-devel] [PATCH 1/3] doc/community: Vote in the interest of the project (first part of Antons proposal)

2024-03-02 Thread Michael Niedermayer
On Mon, Feb 26, 2024 at 11:44:36PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/community.texi | 2 ++ > 1 file changed, 2 insertions(+) I intend to apply the patchset tomorrow if there are no objections thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 4/4] avformat/dvdvideodec: Reorder allocations to simplify freeing

2024-03-02 Thread Marth64
Patchset LGTM. On Sat, Mar 2, 2024 at 9:42 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/dvdvideodec.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/libavformat/dvdvideodec.c

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-02 Thread Gyan Doshi
On 2024-03-03 07:04 am, Michael Niedermayer wrote: On Sat, Mar 02, 2024 at 11:07:40AM +0530, Gyan Doshi wrote: On 2024-03-01 11:03 pm, Anton Khirnov wrote: * Any member of the TC who had a strong opinion on the question raised before it was raised should recuse themselves. In

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-02 Thread Jean-Baptiste Kempf
n Sat, 2 Mar 2024, at 23:55, Michael Niedermayer wrote: > On Tue, Jan 23, 2024 at 08:22:41PM +0100, Michael Niedermayer wrote: >> Hi all >> >> As it was a little difficult for me to not loose track of what is >> blocking a release. I suggest that for all release blocking issues >> open a ticket

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

2024-03-02 Thread Andreas Rheinhardt
Peter Ross: > Reviewed-by: Anton Khirnov > Reviewed-by: Andreas Rheinhardt > Signed-off-by: Peter Ross > --- > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/codec_desc.c |7 + > libavcodec/codec_id.h |1 + > libavcodec/rv60data.h | 118 ++ >

Re: [FFmpeg-devel] [PATCH 2/4] lavc/vp9dsp: R-V V ipred vert

2024-03-02 Thread flow gg
Due to the PATCH 1/4 update, updates here. flow gg 于2024年3月2日周六 15:42写道: > > From ed44215bff4cbf0372cd04f87f45a6ba25274564 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 1 Mar 2024 18:38:43 +0800 Subject: [PATCH 2/4] lavc/vp9dsp: R-V V ipred vert C908: vp9_vert_8x8_8bpp_c: 22.0

Re: [FFmpeg-devel] [PATCH 4/4] lavc/vp9dsp: R-V V ipred tm

2024-03-02 Thread flow gg
Due to the PATCH 1/4 update, updates are made here. flow gg 于2024年3月2日周六 15:42写道: > > From d7aa14940f52b627baf0ae4905e8af6038dc16fc Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Sat, 2 Mar 2024 09:35:22 +0800 Subject: [PATCH 4/4] lavc/vp9dsp: R-V V ipred tm C908: vp9_tm_4x4_8bpp_c: 116.5

Re: [FFmpeg-devel] [PATCH 3/4] lavc/vp9dsp: R-V V ipred hor

2024-03-02 Thread flow gg
flow gg 于2024年3月2日周六 15:42写道: > > From 006dcbe723592a3653bceb0d7f8cc3004e05cb05 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Sat, 2 Mar 2024 08:35:39 +0800 Subject: [PATCH 3/4] lavc/vp9dsp: R-V V ipred hor C908: vp9_hor_8x8_8bpp_c: 74.7 vp9_hor_8x8_8bpp_rvv_i32: 35.7 vp9_hor_16x16_8bpp_c:

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavformat/dvdvideo: add DVD-Video demuxer, powered by libdvdread and libdvdnav

2024-03-02 Thread Marth64
I did take caution here, ffmpeg must be built with all of the following flags: ./configure --enable-demuxer=dvdvideo --enable-libdvdread --enable-libdvdnav --enable-gpl This is also called out in the docs: > FFmpeg must be built with GPL library support available as well as the configure switches

[FFmpeg-devel] [PATCH] doc/community: rule to avoid conflict of interest and prejudice in TC

2024-03-02 Thread Gyan Doshi
--- doc/community.texi | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/doc/community.texi b/doc/community.texi index 90d2b6f366..8d5722bd7f 100644 --- a/doc/community.texi +++ b/doc/community.texi @@ -82,7 +82,20 @@ The TC has 2 modes of operation: a RFC one

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavformat/dvdvideo: add DVD-Video demuxer, powered by libdvdread and libdvdnav

2024-03-02 Thread Jean-Baptiste Kempf
On Sun, 3 Mar 2024, at 05:28, Marth64 wrote: > I did take caution here, > ffmpeg must be built with all of the following flags: ./configure > --enable-demuxer=dvdvideo --enable-libdvdread --enable-libdvdnav > --enable-gpl > > This is also called out in the docs: >> FFmpeg must be built with GPL

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-02 Thread Michael Niedermayer
Hi On Fri, Mar 01, 2024 at 06:33:12PM +0100, Anton Khirnov wrote: > Hi all, > it seems the discussion died down, There are patches pending, which i will apply soon if no objections have been raised. And noone owns law texts. Everyone can propose any derivation of anothers suggestion. Thats the

Re: [FFmpeg-devel] [PATCH v4 2/3] avformat/flvenc: support enhanced flv PacketTypeMetadata

2024-03-02 Thread zhupengfei via ffmpeg-devel
> 2024年3月2日 22:59,Andreas Rheinhardt 写道: > > zhupengfei via ffmpeg-devel: >> From: Zhu Pengfei <411294...@qq.com> >> >> Signed-off-by: Zhu Pengfei <411294...@qq.com> >> --- >> libavformat/flvenc.c | 142 +++ >> 1 file changed, 142 insertions(+) >> >>

[FFmpeg-devel] [PATCH] avcodec/vvcdec: check pred flag to fix undefined beavhiours

2024-03-02 Thread Nuo Mi
libavcodec/vvc/vvc_inter.c:823:18: runtime error: signed integer overflow: 1426128896 + 1426128896 cannot be represented in type 'int' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior libavcodec/vvc/vvc_inter.c:823:18 --- libavcodec/vvc/vvc_inter.c | 15 +-- 1 file changed, 9

Re: [FFmpeg-devel] [PATCH v14 2/2] libavformat/dvdvideo: add CLUT utilities and enable subtitle palette support

2024-03-02 Thread Marth64
Bump on this one. Would be really nice to have since dvd demuxer is merged, and colors are part of the presentation. It did have 2 reviews. Thank you. On Sun, Feb 18, 2024 at 10:02 PM Marth64 wrote: > Signed-off-by: Marth64 > --- > doc/demuxers.texi | 5 +++ > libavformat/Makefile

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vp9dsp: R-V V ipred dc

2024-03-02 Thread flow gg
updated a little improve in this reply flow gg 于2024年3月2日周六 17:48写道: > Okay, reduced if/else in the response. > > Rémi Denis-Courmont 于2024年3月2日周六 17:03写道: > >> Le lauantaina 2. maaliskuuta 2024, 9.42.06 EET flow gg a écrit : >> > >> >> You would need a lot fewer if/else if you passed the

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Marth64
Nevermind, disregard. They do not, and I misread. Thanks for catching this. On Sat, Mar 2, 2024 at 8:31 PM Marth64 wrote: > FYI: hls, dashdec do the same av_freep(). Doesn't make this right, but > saying that was where I used as an example (so they should probably fixed > too?) > > On Sat, Mar

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Marth64
FYI: hls, dashdec do the same av_freep(). Doesn't make this right, but saying that was where I used as an example (so they should probably fixed too?) On Sat, Mar 2, 2024 at 10:17 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > James Almer: > > On 3/2/2024 12:47 PM, Andreas