Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Paul B Mahol
On 11/24/17, Nicolas George wrote: > Paul B Mahol (2017-11-24): >> WTF you are very evil persona. > > I do not know what you mean, and please stop ad-hominem attacks. > > I only want time to review the code while knowing what it is supposed to > do. So please re-submit your patch. > > Regards, and

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Nicolas George
Paul B Mahol (2017-11-24): > WTF you are very evil persona. I do not know what you mean, and please stop ad-hominem attacks. I only want time to review the code while knowing what it is supposed to do. So please re-submit your patch. Regards, and EOT for me tonight, -- Nicolas George ___

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Paul B Mahol
On 11/24/17, Nicolas George wrote: > Paul B Mahol (2017-11-24): >> But for what option instead was consensus? > > I do not remember. That is your patch, therefore I think it is your > responsibility to re-read the discussion, make a choice that you think > will suit everybody, and re-submit the pa

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Nicolas George
Paul B Mahol (2017-11-24): > But for what option instead was consensus? I do not remember. That is your patch, therefore I think it is your responsibility to re-read the discussion, make a choice that you think will suit everybody, and re-submit the patch for final approval. By the way, since the

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Paul B Mahol
On 11/24/17, Nicolas George wrote: > Paul B Mahol (2017-11-24): >> What you want to change? > > The name of the option and its documentation. The documentation was > unclear, and if there was a consensus about the name of the option, it > was not for "queue". But for what option instead was conse

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Nicolas George
Paul B Mahol (2017-11-24): > What you want to change? The name of the option and its documentation. The documentation was unclear, and if there was a consensus about the name of the option, it was not for "queue". Regards, -- Nicolas George signature.asc Description: Digital signature _

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Paul B Mahol
On 11/24/17, Nicolas George wrote: > Paul B Mahol (2017-11-24): >> Because there are no more comments can I assume pushing this patch as is >> OK? > > Depends on how you amended it after the discussion. What you want to change? ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Nicolas George
Paul B Mahol (2017-11-24): > Because there are no more comments can I assume pushing this patch as is OK? Depends on how you amended it after the discussion. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Paul B Mahol
On 11/21/17, Paul B Mahol wrote: > On 11/19/17, Nicolas George wrote: >> Thilo Borgmann (2017-11-19): >>> Based on Dave's example I'd say the queue parameter defines the >>> minimum of available tiles before output is generated. >>> >>> 'queue' -> 'min' >>> 'queue' -> 'min_tiles' >>> 'queue' -> '

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-21 Thread Paul B Mahol
On 11/19/17, Nicolas George wrote: > Thilo Borgmann (2017-11-19): >> Based on Dave's example I'd say the queue parameter defines the >> minimum of available tiles before output is generated. >> >> 'queue' -> 'min' >> 'queue' -> 'min_tiles' >> 'queue' -> 'min_available' >> >> I'd suggest something

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-20 Thread Thilo Borgmann
> Am 20.11.2017 um 06:25 schrieb Gyan Doshi : > > >> On 11/20/2017 5:04 AM, Thilo Borgmann wrote: >> >> min_start >> n_begin > > start_delay ? Just to complete my thoughts... init_padding would be good and for code-viewing people it is way better than queue. My thoughts are about the name o

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Gyan Doshi
On 11/20/2017 5:04 AM, Thilo Borgmann wrote: min_start n_begin start_delay ? Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Thilo Borgmann
> Am 19.11.2017 um 23:25 schrieb Nicolas George : > > Thilo Borgmann (2017-11-19): >> Based on Dave's example I'd say the queue parameter defines the >> minimum of available tiles before output is generated. >> >> 'queue' -> 'min' >> 'queue' -> 'min_tiles' >> 'queue' -> 'min_available' >> >>

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Nicolas George
Thilo Borgmann (2017-11-19): > Based on Dave's example I'd say the queue parameter defines the > minimum of available tiles before output is generated. > > 'queue' -> 'min' > 'queue' -> 'min_tiles' > 'queue' -> 'min_available' > > I'd suggest something like that. "min" would imply a global min

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Thilo Borgmann
> Am 19.11.2017 um 21:22 schrieb Nicolas George : > > Dave Rice (2017-11-19): >> IMHO, ‘queue' is a good name for what it does. > > Based on your explanation, I would say not at all. It rather seems to > say the opposite. I would suggest something like "init_padding". Based on Dave's example I

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Nicolas George
Dave Rice (2017-11-19): > IMHO, ‘queue' is a good name for what it does. Based on your explanation, I would say not at all. It rather seems to say the opposite. I would suggest something like "init_padding". Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Dave Rice
> On Nov 19, 2017, at 2:19 PM, Nicolas George wrote: > > Paul B Mahol (2017-11-19): >> So what you propose? > > I do not know. It is your patch, and I am not even sure I understood > your explanation correctly. IMHO, ‘queue' is a good name for what it does. Perhaps an additional example woul

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Nicolas George
Paul B Mahol (2017-11-19): > So what you propose? I do not know. It is your patch, and I am not even sure I understood your explanation correctly. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Paul B Mahol
On 11/19/17, Nicolas George wrote: > Le nonidi 29 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> It allows user to start outputing video frames immediately with first >> input frame. >> Instead of after nb_frames. > > I think I understand what it means, but only because I have read the > code, and

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Nicolas George
Le nonidi 29 brumaire, an CCXXVI, Paul B Mahol a écrit : > It allows user to start outputing video frames immediately with first > input frame. > Instead of after nb_frames. I think I understand what it means, but only because I have read the code, and even like that I am not entirely sure. This n

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Paul B Mahol
On 11/19/17, Nicolas George wrote: > Le septidi 27 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 4 >> libavfilter/vf_tile.c | 18 +- >> 2 files changed, 21 insertions(+), 1 deletion(-) >> >> diff --git a/doc/fi

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-19 Thread Nicolas George
Le septidi 27 brumaire, an CCXXVI, Paul B Mahol a écrit : > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 4 > libavfilter/vf_tile.c | 18 +- > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 5d9943

[FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 4 libavfilter/vf_tile.c | 18 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 5d99437871..7eeeafab8e 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -