Re: [fink-core] Merge #166 ?

2018-12-16 Thread Daniel Johnson
> On Dec 16, 2018, at 11:33 AM, Max Horn wrote: > > PS: > > I have now committed a fix for python2.7, in which I point it at the > SDK_PATH. So, yeah, it seems useful to expose that to packages. Perhaps we > might even want to add `-I$SDK_PATH/usr/include` to the default CPPFLAGS? > >

Re: [fink-core] Merge #166 ?

2018-12-16 Thread Max Horn
PS: I have now committed a fix for python2.7, in which I point it at the SDK_PATH. So, yeah, it seems useful to expose that to packages. Perhaps we might even want to add `-I$SDK_PATH/usr/include` to the default CPPFLAGS? Note: the headers in /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk

Re: [fink-core] Merge #166 ?

2018-12-16 Thread Hanspeter Niederstrasser
On 12/16/18 9:41 AM, Max Horn wrote: Hi all, thanks for the feedback, I have fixed the ARCHFLAGS now and made the code generally more robust, adding a new helper Fink::Services::get_sdkpath() which returns an empty string on Darwin < 18 and the SDK path as returned by `xcrun --sdk macosx

Re: [fink-core] Merge #166 ?

2018-12-16 Thread Max Horn
Hi all, thanks for the feedback, I have fixed the ARCHFLAGS now and made the code generally more robust, adding a new helper Fink::Services::get_sdkpath() which returns an empty string on Darwin < 18 and the SDK path as returned by `xcrun --sdk macosx --show-sdk-path`. I believe it would make

Re: [fink-core] Merge #166 ?

2018-12-14 Thread Justin Hallett
Yes this is the issue and I have a review on the PR for this. --- TS http://www.southofheaven.org/ Life begins and ends with chaos, live between the chaos! > On Dec 14, 2018, at 6:23 AM, Hanspeter Niederstrasser > wrote: > > Also, should your ARCHFLAGS have an unresolved $sdkpath and

Re: [fink-core] Merge #166 ?

2018-12-14 Thread Justin Hallett
I started a review on your PR for changes. Your modulebuild won’t work as is and that is likely part of the issue. Also you have an extra patch in there which is only for Xcode 10.0 for XCode10.1 it should be removed. --- TS http://www.southofheaven.org/ Life begins and ends with chaos, live

Re: [fink-core] Merge #166 ?

2018-12-14 Thread Hanspeter Niederstrasser
On 12/14/18 6:18 AM, Max Horn wrote: On 12. Dec 2018, at 12:14, Max Horn wrote: On 12. Dec 2018, at 11:11, Hanspeter Niederstrasser wrote: On 12/11/18 11:14 PM, Alexander Hansen wrote: I was thinking that it might help us if we do the aforementioned merge to facilitate community

Re: [fink-core] Merge #166 ?

2018-12-14 Thread Max Horn
> On 12. Dec 2018, at 12:14, Max Horn wrote: > > > >> On 12. Dec 2018, at 11:11, Hanspeter Niederstrasser >> wrote: >> >> On 12/11/18 11:14 PM, Alexander Hansen wrote: >>> I was thinking that it might help us if we do the aforementioned merge to >>> facilitate community testing, etc.

Re: [fink-core] Merge #166 ?

2018-12-12 Thread Alexander Hansen
: [fink-core] Merge #166 ? On 12/11/18 11:14 PM, Alexander Hansen wrote: > I was thinking that it might help us if we do the aforementioned merge to > facilitate community testing, etc. > > -akh I'm OK with that. TheSin said he'd added a couple local changes on top of jwhowarth's p

Re: [fink-core] Merge #166 ?

2018-12-12 Thread Max Horn
> On 12. Dec 2018, at 11:11, Hanspeter Niederstrasser > wrote: > > On 12/11/18 11:14 PM, Alexander Hansen wrote: >> I was thinking that it might help us if we do the aforementioned merge to >> facilitate community testing, etc. >> -akh > > I'm OK with that. TheSin said he'd added a couple

Re: [fink-core] Merge #166 ?

2018-12-12 Thread Hanspeter Niederstrasser
On 12/11/18 11:14 PM, Alexander Hansen wrote: I was thinking that it might help us if we do the aforementioned merge to facilitate community testing, etc. -akh I'm OK with that. TheSin said he'd added a couple local changes on top of jwhowarth's pull and been running OK with them. I *think*

[fink-core] Merge #166 ?

2018-12-11 Thread Alexander Hansen
I was thinking that it might help us if we do the aforementioned merge to facilitate community testing, etc. -akh ___ fink-core mailing list fink-core@lists.sourceforge.net List archive: http://news.gmane.org/gmane.os.apple.fink.core Subscription