Re: [fink-core] Merge #166 ?

[Daniel Johnson]

> On Dec 16, 2018, at 11:33 AM, Max Horn  wrote:
> 
> PS:
> 
> I have now committed a fix for python2.7, in which I point it at the 
> SDK_PATH. So, yeah, it seems useful to expose that to packages. Perhaps we 
> might even want to add `-I$SDK_PATH/usr/include` to the default CPPFLAGS?
> 
> Note: the headers in /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk are 
> not enough, it really needs to "see" the full 10.14 SDK in order to work.
> 
> I am told that another way to solve the problem with Python 2.7 (and probably 
> many other packages) is to install headers into /usr/include, by running
> 
> sudo installer -pkg 
> /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg
>  -target / 
> 
> See also 
> 
> 
> Alas, I am not sure that we can or want to suggest this to users.
> 
> 
> Cheers,
> Max
> 
> ___
> fink-core mailing list
> fink-core@lists.sourceforge.net
> List archive:
> http://news.gmane.org/gmane.os.apple.fink.core
> Subscription management:
> https://lists.sourceforge.net/lists/listinfo/fink-core

Cool, thanks for the fix. I don’t have 10.14 so I’m glad you could do this. And 
yes, I don’t think forcing users to install another package is a good idea. 
We’re just going to have to make changes to use the SDK.

Daniel



___
fink-core mailing list
fink-core@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core

Re: [fink-core] Merge #166 ?

[Max Horn]

PS:

I have now committed a fix for python2.7, in which I point it at the SDK_PATH. 
So, yeah, it seems useful to expose that to packages. Perhaps we might even 
want to add `-I$SDK_PATH/usr/include` to the default CPPFLAGS?

Note: the headers in /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk are 
not enough, it really needs to "see" the full 10.14 SDK in order to work.

I am told that another way to solve the problem with Python 2.7 (and probably 
many other packages) is to install headers into /usr/include, by running

sudo installer -pkg 
/Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg
 -target / 

See also 


Alas, I am not sure that we can or want to suggest this to users.


Cheers,
Max

___
fink-core mailing list
fink-core@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core

Re: [fink-core] Merge #166 ?

[Hanspeter Niederstrasser]

On 12/16/18 9:41 AM, Max Horn wrote:

Hi all,

thanks for the feedback, I have fixed the ARCHFLAGS now and made the code 
generally more robust, adding a new helper Fink::Services::get_sdkpath() which 
returns an empty string on Darwin < 18 and the SDK path as returned by `xcrun 
--sdk macosx --show-sdk-path`. I believe it would make sense to change that Darwin 
version cutoff to a lower value, but for now wanted to play it safe.

The perlmodule builds fine now, but python is still broken. Hanspeter hinted 
that normally it finds zlib; so I am guessing this might be another case where 
the SDK path needs to be inserted somewhere. I'll take a look.

In general, I noticed that in various .info files, we might have to start using 
the SDK path now. Perhaps time to introduce %{sdkpath} for that? Any concerns 
about doing just that?

E.g. in libcurl4.info, we have this in the PatchScript:

/bin/cp /usr/include/lber*.h .
/bin/cp /usr/include/ldap*.h .
/bin/cp /usr/lib/libldap.dylib .

That is of course easy to adjust (and indeed, I just see that somebody did it). 
But there is also this in ConfigureParams:

ConfigureParams: <<
--with-darwinssl \
--without-ssl \
--without-gnutls \
--with-libssh2=%p \
--with-gssapi=/usr \
...

and that last line could be easily turned into

--with-gssapi=%{sdkpath}/usr \



fink-buildenv-modules currently can set SDK_PATH (tested through Xcode9) 
[1] but this could easily be folded into fink code if it would help more 
there. The above snippet --with-pkg=/path is very common throughout our 
.info jungle.


Hanspeter

[1] 
https://github.com/nieder/fink-buildenv-modules/blob/master/modules/base.sh.in#L56




___
fink-core mailing list
fink-core@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core

Re: [fink-core] Merge #166 ?

[Max Horn]

Hi all,

thanks for the feedback, I have fixed the ARCHFLAGS now and made the code 
generally more robust, adding a new helper Fink::Services::get_sdkpath() which 
returns an empty string on Darwin < 18 and the SDK path as returned by `xcrun 
--sdk macosx --show-sdk-path`. I believe it would make sense to change that 
Darwin version cutoff to a lower value, but for now wanted to play it safe.

The perlmodule builds fine now, but python is still broken. Hanspeter hinted 
that normally it finds zlib; so I am guessing this might be another case where 
the SDK path needs to be inserted somewhere. I'll take a look.

In general, I noticed that in various .info files, we might have to start using 
the SDK path now. Perhaps time to introduce %{sdkpath} for that? Any concerns 
about doing just that?

E.g. in libcurl4.info, we have this in the PatchScript:

/bin/cp /usr/include/lber*.h .
/bin/cp /usr/include/ldap*.h .
/bin/cp /usr/lib/libldap.dylib .

That is of course easy to adjust (and indeed, I just see that somebody did it). 
But there is also this in ConfigureParams:

ConfigureParams: <<
--with-darwinssl \
--without-ssl \
--without-gnutls \
--with-libssh2=%p \
--with-gssapi=/usr \
...

and that last line could be easily turned into

--with-gssapi=%{sdkpath}/usr \


Any thoughts on that?

Cheers,
Max

___
fink-core mailing list
fink-core@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core

Re: [fink-core] Merge #166 ?

[Justin Hallett]

Yes this is the issue and I have a review on the PR for this.
---
TS
http://www.southofheaven.org/
Life begins and ends with chaos, live between the chaos!

> On Dec 14, 2018, at 6:23 AM, Hanspeter Niederstrasser 
>  wrote:
> 
> Also, should your ARCHFLAGS have an unresolved $sdkpath and $perlversion? Or 
> are those variables set somehow in that shell?

___
fink-core mailing list
fink-core@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core

Re: [fink-core] Merge #166 ?

[Justin Hallett]

I started a review on your PR for changes.  Your modulebuild won’t work as is 
and that is likely part of the issue.  Also you have an extra patch in there 
which is only for Xcode 10.0 for XCode10.1 it should be removed.
---
TS
http://www.southofheaven.org/
Life begins and ends with chaos, live between the chaos!

> On Dec 14, 2018, at 5:18 AM, Max Horn  wrote:
> 
> 
> 
>> On 12. Dec 2018, at 12:14, Max Horn  wrote:
>> 
>> 
>> 
>>> On 12. Dec 2018, at 11:11, Hanspeter Niederstrasser 
>>>  wrote:
>>> 
>>> On 12/11/18 11:14 PM, Alexander Hansen wrote:
 I was thinking that it might help us if we do the aforementioned merge to 
 facilitate community testing, etc.
 -akh
>>> 
>>> I'm OK with that. TheSin said he'd added a couple local changes on top of 
>>> jwhowarth's pull and been running OK with them. I *think* it might be 
>>> possible to edit the files via the web interface even though the pull comes 
>>> from jwhowarth's clone. I know I can see the edit pencil icon, but I 
>>> haven't tried to actually save a change.
>> 
>> You can probably also push to this PR. And then e.g. squash some changes.
>> 
>>> 
>>> Might be good to have those changes then merge, or just merge as is and 
>>> then ask TheSin to make a pull for his changes and merge them quickly.
>> 
>> Or, make a new PR with all the changes?
>> 
>> By chance, I have finally updated from OS X 10.11 to 10.14, so I guess I 
>> could help.
>> 
>> I just made a new https://github.com/fink/fink/pull/170 with the changes 
>> squashed into a PR, and will now work on addressing the open suggestions, 
>> and test it on my system.
> 
> So that PR seems to work, basically, but various packages have issues. Would 
> be interesting to know what additional changes TheSin has...
> 
> I already pushed a fix for texinfo.info  which enables 
> it on 10.14. But now python27 fails to build (and that blocks a ton of other 
> stuff):
> 
> gcc -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -fwrapv -O3 -Wall 
> -Wstrict-prototypes -I_ctypes/darwin -I/sw/include -I. -IInclude -I./Include 
> -I/sw/include -I/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Include 
> -I/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15 -c 
> /sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/darwin/dlfcn_simple.c
>  -o 
> build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/darwin/dlfcn_simple.o
>  -DMACOSX
> gcc -L/sw/lib -bundle 
> /sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/libpython2.7.dylib 
> -L/sw/lib -L/sw/lib -I. -IInclude -I./Include -I/sw/include 
> build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/_ctypes.o
>  
> build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/callbacks.o
>  
> build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/callproc.o
>  
> build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/stgdict.o
>  
> build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/cfield.o
>  
> build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/malloc_closure.o
>  
> build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/darwin/dlfcn_simple.o
>  -L/sw/lib -L. -lffi -ldl -o build/lib.macosx-10.14-x86_64-2.7/_ctypes.so
> 
> Python build finished, but the necessary bits to build these modules were not 
> found:
> bsddb185   dl imageop
> linuxaudiodev  nisossaudiodev
> spwd   sunaudiodevzlib
> To find the necessary bits, look in setup.py in detect_modules() for the 
> module's name.
> (Fink package build should have 7 missing)
> 
> make: *** [sharedmods] Error 1
> ### execution of make failed, exit code 2
> ### execution of /tmp/fink.2ROxo failed, exit code 2
> Removing runtime build-lock...
> Removing build-lock package...
> /sw/bin/dpkg-lockwait -r fink-buildlock-python27-2.7.15-1
> (Reading database ... 91352 files and directories currently installed.)
> Removing fink-buildlock-python27-2.7.15-1 ...
> Failed: phase compiling: python27-2.7.15-1 failed
> 
> 
> 
> Moreover, it seems that building -pm5182 perlmod packages may fail, e.g.:
> 
> Params-Util-1.07/t/13_all.t
> Params-Util-1.07/t/03_all.t
> sudo -u fink-bld [ENV] sh -c /tmp/fink.fdGjL
> /tmp/fink.L76Fh
> #!/bin/sh -ev
> export PERL_EXTUTILS_AUTOINSTALL=--skip
> ARCHFLAGS="-I$sdkpath/System/Library/Perl/$perlversion/darwin-thread-multi-2level/CORE"
>  /usr/bin/arch -x86_64 perl5.18 Makefile.PL PERL="/usr/bin/arch -x86_64 
> perl5.18" PREFIX=/sw INSTALLPRIVLIB=/sw/lib/perl5/5.18.2 
> INSTALLARCHLIB=/sw/lib/perl5/5.18.2/darwin-thread-multi-2level 
> INSTALLSITELIB=/sw/lib/perl5/5.18.2 
> 

Re: [fink-core] Merge #166 ?

[Hanspeter Niederstrasser]

On 12/14/18 6:18 AM, Max Horn wrote:




On 12. Dec 2018, at 12:14, Max Horn  wrote:




On 12. Dec 2018, at 11:11, Hanspeter Niederstrasser  
wrote:

On 12/11/18 11:14 PM, Alexander Hansen wrote:

I was thinking that it might help us if we do the aforementioned merge to 
facilitate community testing, etc.
-akh


I'm OK with that. TheSin said he'd added a couple local changes on top of 
jwhowarth's pull and been running OK with them. I *think* it might be possible 
to edit the files via the web interface even though the pull comes from 
jwhowarth's clone. I know I can see the edit pencil icon, but I haven't tried 
to actually save a change.


You can probably also push to this PR. And then e.g. squash some changes.



Might be good to have those changes then merge, or just merge as is and then 
ask TheSin to make a pull for his changes and merge them quickly.


Or, make a new PR with all the changes?

By chance, I have finally updated from OS X 10.11 to 10.14, so I guess I could 
help.

I just made a new https://github.com/fink/fink/pull/170 with the changes 
squashed into a PR, and will now work on addressing the open suggestions, and 
test it on my system.


So that PR seems to work, basically, but various packages have issues. Would be 
interesting to know what additional changes TheSin has...

I already pushed a fix for texinfo.info which enables it on 10.14. But now 
python27 fails to build (and that blocks a ton of other stuff):

gcc -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -fwrapv -O3 -Wall 
-Wstrict-prototypes -I_ctypes/darwin -I/sw/include -I. -IInclude -I./Include 
-I/sw/include -I/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Include 
-I/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15 -c 
/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/darwin/dlfcn_simple.c
 -o 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/darwin/dlfcn_simple.o
 -DMACOSX
gcc -L/sw/lib -bundle 
/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/libpython2.7.dylib -L/sw/lib 
-L/sw/lib -I. -IInclude -I./Include -I/sw/include 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/_ctypes.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/callbacks.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/callproc.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/stgdict.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/cfield.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/malloc_closure.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/darwin/dlfcn_simple.o
 -L/sw/lib -L. -lffi -ldl -o build/lib.macosx-10.
  14-x86_64-2.7/_ctypes.so

Python build finished, but the necessary bits to build these modules were not 
found:
bsddb185   dl imageop
linuxaudiodev  nisossaudiodev
spwd   sunaudiodevzlib
To find the necessary bits, look in setup.py in detect_modules() for the 
module's name.
(Fink package build should have 7 missing)


On a working 10.11 system, I get this output on python27:

bsddb185   dl imageop
linuxaudiodev  ossaudiodevspwd
sunaudiodev

(zlib is found and used)


Moreover, it seems that building -pm5182 perlmod packages may fail, e.g.:

Params-Util-1.07/t/13_all.t
Params-Util-1.07/t/03_all.t
sudo -u fink-bld [ENV] sh -c /tmp/fink.fdGjL
/tmp/fink.L76Fh
#!/bin/sh -ev
  export PERL_EXTUTILS_AUTOINSTALL=--skip
  ARCHFLAGS="-I$sdkpath/System/Library/Perl/$perlversion/darwin-thread-multi-2level/CORE" 
/usr/bin/arch -x86_64 perl5.18 Makefile.PL PERL="/usr/bin/arch -x86_64 perl5.18" 
PREFIX=/sw INSTALLPRIVLIB=/sw/lib/perl5/5.18.2 
INSTALLARCHLIB=/sw/lib/perl5/5.18.2/darwin-thread-multi-2level INSTALLSITELIB=/sw/lib/perl5/5.18.2 
INSTALLSITEARCH=/sw/lib/perl5/5.18.2/darwin-thread-multi-2level INSTALLMAN1DIR=/sw/share/man/man1 
INSTALLMAN3DIR=/sw/share/man/man3 INSTALLSITEMAN1DIR=/sw/share/man/man1 
INSTALLSITEMAN3DIR=/sw/share/man/man3 INSTALLBIN=/sw/bin INSTALLSITEBIN=/sw/bin 
INSTALLSCRIPT=/sw/bin
sanexs-Fq82m.c:1:10: fatal error: 'EXTERN.h' file not found
#include "EXTERN.h"
  ^~
1 error generated.
Unresolvable broken external dependency.
This package requires a C compiler with full perl headers.
Trivial test code using them failed to compile.
NA: Unable to build distribution on this platform.
/usr/bin/make CC=gcc CXX=g++
make: *** No targets specified and no makefile found.  Stop.
### execution of /tmp/fink.L76Fh failed, exit code 2
### execution of /tmp/fink.fdGjL failed, exit code 2
Removing runtime build-lock...
Removing build-lock package...

Re: [fink-core] Merge #166 ?

[Max Horn]

> On 12. Dec 2018, at 12:14, Max Horn  wrote:
> 
> 
> 
>> On 12. Dec 2018, at 11:11, Hanspeter Niederstrasser  
>> wrote:
>> 
>> On 12/11/18 11:14 PM, Alexander Hansen wrote:
>>> I was thinking that it might help us if we do the aforementioned merge to 
>>> facilitate community testing, etc.
>>> -akh
>> 
>> I'm OK with that. TheSin said he'd added a couple local changes on top of 
>> jwhowarth's pull and been running OK with them. I *think* it might be 
>> possible to edit the files via the web interface even though the pull comes 
>> from jwhowarth's clone. I know I can see the edit pencil icon, but I haven't 
>> tried to actually save a change.
> 
> You can probably also push to this PR. And then e.g. squash some changes.
> 
>> 
>> Might be good to have those changes then merge, or just merge as is and then 
>> ask TheSin to make a pull for his changes and merge them quickly.
> 
> Or, make a new PR with all the changes?
> 
> By chance, I have finally updated from OS X 10.11 to 10.14, so I guess I 
> could help.
> 
> I just made a new https://github.com/fink/fink/pull/170 with the changes 
> squashed into a PR, and will now work on addressing the open suggestions, and 
> test it on my system.

So that PR seems to work, basically, but various packages have issues. Would be 
interesting to know what additional changes TheSin has...

I already pushed a fix for texinfo.info which enables it on 10.14. But now 
python27 fails to build (and that blocks a ton of other stuff):

gcc -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -fwrapv -O3 -Wall 
-Wstrict-prototypes -I_ctypes/darwin -I/sw/include -I. -IInclude -I./Include 
-I/sw/include -I/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Include 
-I/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15 -c 
/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/darwin/dlfcn_simple.c
 -o 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/darwin/dlfcn_simple.o
 -DMACOSX
gcc -L/sw/lib -bundle 
/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/libpython2.7.dylib -L/sw/lib 
-L/sw/lib -I. -IInclude -I./Include -I/sw/include 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/_ctypes.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/callbacks.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/callproc.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/stgdict.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/cfield.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/malloc_closure.o
 
build/temp.macosx-10.14-x86_64-2.7/sw/src/fink.build/python27-2.7.15-1/Python-2.7.15/Modules/_ctypes/darwin/dlfcn_simple.o
 -L/sw/lib -L. -lffi -ldl -o build/lib.macosx-10.14-x86_64-2.7/_ctypes.so

Python build finished, but the necessary bits to build these modules were not 
found:
bsddb185   dl imageop
linuxaudiodev  nisossaudiodev
spwd   sunaudiodevzlib
To find the necessary bits, look in setup.py in detect_modules() for the 
module's name.
(Fink package build should have 7 missing)

make: *** [sharedmods] Error 1
### execution of make failed, exit code 2
### execution of /tmp/fink.2ROxo failed, exit code 2
Removing runtime build-lock...
Removing build-lock package...
/sw/bin/dpkg-lockwait -r fink-buildlock-python27-2.7.15-1
(Reading database ... 91352 files and directories currently installed.)
Removing fink-buildlock-python27-2.7.15-1 ...
Failed: phase compiling: python27-2.7.15-1 failed



Moreover, it seems that building -pm5182 perlmod packages may fail, e.g.:

Params-Util-1.07/t/13_all.t
Params-Util-1.07/t/03_all.t
sudo -u fink-bld [ENV] sh -c /tmp/fink.fdGjL
/tmp/fink.L76Fh
#!/bin/sh -ev
 export PERL_EXTUTILS_AUTOINSTALL=--skip
 
ARCHFLAGS="-I$sdkpath/System/Library/Perl/$perlversion/darwin-thread-multi-2level/CORE"
 /usr/bin/arch -x86_64 perl5.18 Makefile.PL PERL="/usr/bin/arch -x86_64 
perl5.18" PREFIX=/sw INSTALLPRIVLIB=/sw/lib/perl5/5.18.2 
INSTALLARCHLIB=/sw/lib/perl5/5.18.2/darwin-thread-multi-2level 
INSTALLSITELIB=/sw/lib/perl5/5.18.2 
INSTALLSITEARCH=/sw/lib/perl5/5.18.2/darwin-thread-multi-2level 
INSTALLMAN1DIR=/sw/share/man/man1 INSTALLMAN3DIR=/sw/share/man/man3 
INSTALLSITEMAN1DIR=/sw/share/man/man1 INSTALLSITEMAN3DIR=/sw/share/man/man3 
INSTALLBIN=/sw/bin INSTALLSITEBIN=/sw/bin INSTALLSCRIPT=/sw/bin
sanexs-Fq82m.c:1:10: fatal error: 'EXTERN.h' file not found
#include "EXTERN.h"
 ^~
1 error generated.
Unresolvable broken external dependency.
This package requires a C compiler with full perl headers.
Trivial test code using them failed to compile.
NA: Unable to build distribution on this platform.
/usr/bin/make 

Re: [fink-core] Merge #166 ?

[Alexander Hansen]

If the web UI works like it does in GitLab, what might happen is that your 
changes get sent to a new branch if you don’t have write privileges to the 
branch.  However, in GitLab admins can redirect merge requests to alternate 
branches, so it’s probably best not to assume too much.

I’m going to have some Fink time due to unforeseen and unpleasant 
circumstances, so I can do a release and document the procedure I follow once 
we’re ready.

Sent from Mail for Windows 10

From: Hanspeter Niederstrasser
Sent: Wednesday, December 12, 2018 2:11 AM
To: Alexander Hansen; fink-core
Subject: Re: [fink-core] Merge #166 ?

On 12/11/18 11:14 PM, Alexander Hansen wrote:
> I was thinking that it might help us if we do the aforementioned merge to 
> facilitate community testing, etc.
> 
> -akh

I'm OK with that. TheSin said he'd added a couple local changes on top 
of jwhowarth's pull and been running OK with them. I *think* it might be 
possible to edit the files via the web interface even though the pull 
comes from jwhowarth's clone. I know I can see the edit pencil icon, but 
I haven't tried to actually save a change.

Might be good to have those changes then merge, or just merge as is and 
then ask TheSin to make a pull for his changes and merge them quickly.

Hanspeter

___
fink-core mailing list
fink-core@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core

Re: [fink-core] Merge #166 ?

[Max Horn]

> On 12. Dec 2018, at 11:11, Hanspeter Niederstrasser  
> wrote:
> 
> On 12/11/18 11:14 PM, Alexander Hansen wrote:
>> I was thinking that it might help us if we do the aforementioned merge to 
>> facilitate community testing, etc.
>> -akh
> 
> I'm OK with that. TheSin said he'd added a couple local changes on top of 
> jwhowarth's pull and been running OK with them. I *think* it might be 
> possible to edit the files via the web interface even though the pull comes 
> from jwhowarth's clone. I know I can see the edit pencil icon, but I haven't 
> tried to actually save a change.

You can probably also push to this PR. And then e.g. squash some changes.

> 
> Might be good to have those changes then merge, or just merge as is and then 
> ask TheSin to make a pull for his changes and merge them quickly.

Or, make a new PR with all the changes?

By chance, I have finally updated from OS X 10.11 to 10.14, so I guess I could 
help.

I just made a new https://github.com/fink/fink/pull/170 with the changes 
squashed into a PR, and will now work on addressing the open suggestions, and 
test it on my system.

Cheers,
Max

___
fink-core mailing list
fink-core@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core

Re: [fink-core] Merge #166 ?

[Hanspeter Niederstrasser]

On 12/11/18 11:14 PM, Alexander Hansen wrote:

I was thinking that it might help us if we do the aforementioned merge to 
facilitate community testing, etc.

-akh


I'm OK with that. TheSin said he'd added a couple local changes on top 
of jwhowarth's pull and been running OK with them. I *think* it might be 
possible to edit the files via the web interface even though the pull 
comes from jwhowarth's clone. I know I can see the edit pencil icon, but 
I haven't tried to actually save a change.


Might be good to have those changes then merge, or just merge as is and 
then ask TheSin to make a pull for his changes and merge them quickly.


Hanspeter


___
fink-core mailing list
fink-core@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core