https://issues.apache.org/bugzilla/show_bug.cgi?id=49801
alpa...@gmail.com changed:
What|Removed |Added
CC||alpa...@gmail.com
--
On 22 Feb 2011, at 08:50, Simon Pepping wrote:
On Mon, Feb 21, 2011 at 08:28:33PM +0100, Andreas Delmelle wrote:
I saw one exclusion --unconfirmed cast-- that would seem to stem from my
recent refactoring in the BlockStackingLMs. Not sure why an exclusion was
chosen here, but adding an
On 22 Feb 2011, at 08:34, Simon Pepping wrote:
When I build the project or part of it with Eclipse, and run findbugs
afterwards (with ant), I get a number of errors. Now I always make a
clean compile before running findbugs. I do not understand why Eclipse
builds would create findbugs errors
On 22 Feb 2011, at 19:04, Andreas Delmelle wrote:
On 22 Feb 2011, at 08:50, Simon Pepping wrote:
It would be nice if assertions were checked during the junit tests.
However, when I set: junit ... jvm=java -ea/, I get
junit.framework.AssertionFailedError errors. How can this be done?
Since the FOP project itself does not use any IDE for builds, then the ANT
build process should be considered the standard process for compilation,
junit tests, checkstyle tests, findbugs tests, etc.
I always run:
ant clean junit checkstyle findbugs
in order to verify no reported errors before
On 22/02/11 07:24, Simon Pepping wrote:
Not all FOP developers are willing to use findbugs. I hid the findbugs
errors as a courtesy to those FOP developers who do use findbugs, so
they can check their own code based on a clean slate.
I agree that ignoring all the existing issues at the time
On 22 Feb 2011, at 20:15, Vincent Hennebert wrote:
snip /
Can we revert commit 1071912 and re-consider the issues one-by-one
before ignoring them?
+1
As far as I can see, the raised warnings are really not so challenging that
they cannot be addressed right away. Implementing an equals()
On 22 Feb 2011, at 20:39, Andreas Delmelle wrote:
...
--and so, I caved in started already...
In PDFFactory, I have some conflicts to work out first, but the fix-up is
rather simple there. In the respective methods, eliminate all unnecessary
boxing and use explicit (double) casts where
On 22 Feb 2011, at 21:50, Andreas Delmelle wrote:
ColorUtil seems to be somewhat of a can of worms...
snip /
If I judge correctly, for some (if not most) of the methods, there seems to
be no need for a try-catch block (?)
Sorry, forgot RuntimeExceptions, of course, which are converted into
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723
--- Comment #4 from Peter Coppens pc.subscripti...@gmail.com 2011-02-22
16:44:59 EST ---
Wonder whether anyone of the fop community is willing to share viewpoints on
the approach taken in the patch. Seems a fairly safe change at first
On 22 Feb 2011, at 22:38, adelme...@apache.org wrote:
Author: adelmelle
Date: Tue Feb 22 21:38:28 2011
New Revision: 1073518
snip /
@@ -402,7 +398,6 @@ public final class ColorUtil {
/* Ask FOP factory to get ColorSpace for the specified ICC
profile source */
On 22 Feb 2011, at 19:25, Andreas Delmelle wrote:
One way to enable assertions I found so far, and that seems to work:
- use fork=true on the junit target
- insert: assertionsenabled //assertions in that target
That seems to yield the expected behavior at first glance. Our junit targets
I support enabling assertions by default on junit tests. More testing is a
good thing.
G.
On Tue, Feb 22, 2011 at 3:40 PM, Andreas Delmelle
andreas.delme...@telenet.be wrote:
On 22 Feb 2011, at 19:25, Andreas Delmelle wrote:
One way to enable assertions I found so far, and that seems to
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723
--- Comment #5 from Andreas L. Delmelle adelme...@apache.org 2011-02-22
18:15:02 EST ---
Looking closer, this indeed seems like a fairly inconsequential (apart from
fixing the bug, obviously ;-P).
Still, endorsing and committing it would
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723
Andreas L. Delmelle adelme...@apache.org changed:
What|Removed |Added
Depends on||50483
https://issues.apache.org/bugzilla/show_bug.cgi?id=50483
Andreas L. Delmelle adelme...@apache.org changed:
What|Removed |Added
Blocks||50723
On Tue, Feb 22, 2011 at 07:15:17PM +, Vincent Hennebert wrote:
On 22/02/11 07:24, Simon Pepping wrote:
Not all FOP developers are willing to use findbugs. I hid the findbugs
errors as a courtesy to those FOP developers who do use findbugs, so
they can check their own code based on a
On Tue, Feb 22, 2011 at 11:25:20AM -0700, Glenn Adams wrote:
I notice also that the nightly build target does not run all the junit
tests. It would be better if it run all of them plus checkstyle and
findbugs.
Many junit tests require a display. Nightly builds are run in a
headless
18 matches
Mail list logo
