Eclipse and JUnit [was: Re: Font work (CLA needed)]
On Mon, Dec 19, 2005 at 08:52:59PM +0100, Jeremias Maerki wrote: On 19.12.2005 20:06:26 Vincent Hennebert wrote: Moreover my patched Fop still doesn't pass the unitary tests. I'm trying to figure out what is going on but so far I've spent more time fighting against Eclipse to make the debugger work on the junit system than searching for errors. Not sure yet if I've won. Hmm, so far I've had no problems debugging inside Eclipse's JUnit environment. I try to avoid it by running fop directly with the XSL stylesheet test/layoutengine/testcase2fo.xsl, or I even generate the FO using this stylesheet. Maybe unnecessary, but if you are not so experienced with eclipse, you can have a hard time to make it do what you want. Avoiding JUnit in the debugging process helps me. Simon -- Simon Pepping home page: http://www.leverkruid.nl
Re: Eclipse and JUnit [was: Re: Font work (CLA needed)]
That's very unfortunate. Can you guys explain to me what exactly the problems are? Maybe I can help. It is very helpful to simply run a single test under JUnit control directly from Eclipse. I simply have to specify the test case I want to run in the system properties and off I go. On 21.12.2005 09:34:07 Simon Pepping wrote: On Mon, Dec 19, 2005 at 08:52:59PM +0100, Jeremias Maerki wrote: On 19.12.2005 20:06:26 Vincent Hennebert wrote: Moreover my patched Fop still doesn't pass the unitary tests. I'm trying to figure out what is going on but so far I've spent more time fighting against Eclipse to make the debugger work on the junit system than searching for errors. Not sure yet if I've won. Hmm, so far I've had no problems debugging inside Eclipse's JUnit environment. I try to avoid it by running fop directly with the XSL stylesheet test/layoutengine/testcase2fo.xsl, or I even generate the FO using this stylesheet. Maybe unnecessary, but if you are not so experienced with eclipse, you can have a hard time to make it do what you want. Avoiding JUnit in the debugging process helps me. Simon -- Simon Pepping home page: http://www.leverkruid.nl Jeremias Maerki
Review of the FOrayFont patch and FOrayFont itself
I've applied Vincent's patch locally and went through the code. I had to do several modifications because I've recently changed a few things in the Trunk which broke Vincent's patch. I managed to get it to work without bigger problems. However, I must say that I currently could not vote +1 to apply the patch. Let me show why: The main reason right now is lack of time. This topic will eat quite some time as it turns out. There are several points I would want to have improved first: 1. As I suggested earlier, having a mandatory font configuration is not acceptable IMO. The whole thing needs to work out-of-the-box for the set of fonts that can be considered present for each target format (Base 14 fonts for PDF and PS, AWT fonts for Java2D output etc.). To make this work, the AFM files for the Base 14 fonts would be placed in the JAR file. However, while going through FOray's source code I found that the font loading code currently needs a RandomAccessFile which means that either the file has to be first copied to the file system, a new implementation of the RandomInput interface would have to be written for access on an in-memory copy on the AFM files or the code has to be rewritten to work on a simple InputStream. 2. I'm a little disappointed that Victor did not follow my ideas of font sources, but I guess it was easier for him this way. So I can understand. With my approach, the FontServer would hold a set of font sources each of which provides access to a set of fonts (i.e. the AWT fonts, the Base14 fonts, a directory of Type1 fonts etc.). The client application would tell the FontServer (via the FontConsumer I guess) which font sources are acceptable. For each font source an URI could be defined that identifies it so that interoperability and extensibility are preserved. ATM, there are only the two somewhat artificial groups: free standing fonts and system fonts. I don't think this is flexible enough on the long run. Anyway, the current aXSL Font API feels a little strange still. But some of that I've already pointed out to Victor at an earlier opportunity. The way the used fonts are stored is also a suspect point to me since it bears the possibility of a memory-leak if a FontConsumer is not properly unregistered in case of an exception. Currently, the FontConsumer is not released at all. This would have to be looked at closely. 3. The configuration file is too complicated in my opinion (especially the mapping part). It should be much easier. The complexity somewhat kills the benefit of loading fonts directly, and not via XML font metrics files. I would really, really like to have the possibility to specify a directory and all fonts are all automatically made available. People already have problems all the time to get their fonts working. I would not like to see it getting even more complicated. After all, you don't have to write a complex configuration file when you install a font in Windows, for example. I agree that there can be sections in the config file to specify font substitutions but the default font names should be available automatically. While testing I had to specify absolute paths to get the font config working quickly. In the short time, I was looking at it I didn't manage to get it to work otherwise. In the end, I have to look at the cost/benefit ratio: + ToUnicode fix (also available through Adam's patch) + Getting rid of the need to generated XML font metric files o Change in config format (documentation etc.) - Config format too complicated - Config is mandatory - Extensibility not easily visible in the API. Many output specific aspects are in general interfaces. How would AFP fonts be handled? - Two projects will depend on the font package. That means a restriction on freedom. Changes cannot easily be made. - Lack of time on my side to push the font integration right now. Not much left in the end, I'm afraid. I know that with my comments above I'm criticising a lot but that doesn't mean I'm not willing to invest time here and in FOray/aXSL to help improve things. It's just that currently I'm not able to invest the necessary time right now. I also know that it's bad for Vincent because of all the time he has spent so far. We can talk about putting the changes into a branch, but I don't feel comfortable saying +1 for inclusion in the Trunk right now. Another approach could be to pack our current font support into a aXSL font implementation so the transition to FOrayFont would come easier later, but IMHO it would still make some changes necessary in aXSL. I don't agree with some of the patterns used there. If there's another champion among the FOP committers to take the lead here, the situation could also look different. Other opinions? Jeremias Maerki
Re: [VOTE] Release FOP 0.91beta
On Tue, Dec 20, 2005 at 11:43:29AM +0100, Jeremias Maerki wrote: I'd like to call for a PMC vote to release FOP 0.91beta from this newly created branch. (Votes to [EMAIL PROTECTED], please) +1 from me. Simon -- Simon Pepping home page: http://www.leverkruid.nl
Re: Eclipse and JUnit
On Wed, Dec 21, 2005 at 09:48:52AM +0100, Jeremias Maerki wrote: That's very unfortunate. Can you guys explain to me what exactly the problems are? Maybe I can help. It is very helpful to simply run a single test under JUnit control directly from Eclipse. I simply have to specify the test case I want to run in the system properties and off I go. Running a single test is always a problem, with ant and with eclipse. The point is just that I do not do this often, and everytime I have to look through the test suite code to dig up the exact system property to set. Eclipse is a bewildering huge beast when you start with it. I have just spent some time learning how to use it properly, and now I feel more comfortable with it. I suppose it is a matter of habit. At the moment I happen to write scripts more easily than eclipse launch configurations. So I tend to avoid complications and use the simplest solution. Simon -- Simon Pepping home page: http://www.leverkruid.nl
junit failures with revision
I get many junit errors with revision 358224. The all seem to be related to the notation of colors in the area tree, e.g.: [junit] Testcase: block-container_borders.xml(org.apache.fop.layoutengine.LayoutEngineTestSuite$1): Caused an ERROR [junit] Expected XPath expression to evaluate to '(solid,#00,5000)', but got '(solid,[EMAIL PROTECTED],5000)' (XPath: /areaTree/pageSequence/pageViewport/page[1]/regionViewport/regionBody/mainReference/span/flow/block[1]/@border-start) [junit] java.lang.RuntimeException: Expected XPath expression to evaluate to '(solid,#00,5000)', but got '(solid,[EMAIL PROTECTED],5000)' (XPath: /areaTree/pageSequence/pageViewport/page[1]/regionViewport/regionBody/mainReference/span/flow/block[1]/@border-start) -- Simon Pepping home page: http://www.leverkruid.nl
Re: junit failures with revision
Already fixed: http://svn.apache.org/viewcvs?rev=358240view=rev Sorry for the trouble. On 21.12.2005 10:51:05 Simon Pepping wrote: I get many junit errors with revision 358224. The all seem to be related to the notation of colors in the area tree, e.g.: [junit] Testcase: block-container_borders.xml(org.apache.fop.layoutengine.LayoutEngineTestSuite$1): Caused an ERROR [junit] Expected XPath expression to evaluate to '(solid,#00,5000)', but got '(solid,[EMAIL PROTECTED],5000)' (XPath: /areaTree/pageSequence/pageViewport/page[1]/regionViewport/regionBody/mainReference/span/flow/block[1]/@border-start) [junit] java.lang.RuntimeException: Expected XPath expression to evaluate to '(solid,#00,5000)', but got '(solid,[EMAIL PROTECTED],5000)' (XPath: /areaTree/pageSequence/pageViewport/page[1]/regionViewport/regionBody/mainReference/span/flow/block[1]/@border-start) -- Simon Pepping home page: http://www.leverkruid.nl Jeremias Maerki
Great news! New Apache Members!
It is with big pleasure that I can announce that we have two new Apache Members. Congratulations to Christian Geisert and Jörg Pietschmann!!! Both were elected during the last member's meeting at the ApacheCon in San Diego. Christian and Jörg seem to have made an impression on the Apache membership by their continuous participation in various projects and places inside the ASF. Keep it up guys! Jeremias Maerki
Re: Eclipse and JUnit
On Wed, Dec 21, 2005 at 11:03:59AM +0100, Jeremias Maerki wrote: Yes, digging up the right system properties is a nuisance, but you only have to do it once. Have a look at the attached screen shots that show how I set up the launch config for running the FOP test suite. You can see that I simply add an x somewhere to effectively disable the setting for a system property. Like this I'm can change the parameters to the test suite very quickly. Maybe that helps make things easier. Thanks. The x is a nice trick. It would be good to have a document describing the system properties of the test suites. If you do not do it, I will write one. I see you have a project 'FOP Temp', which probably is a copy of project FOP. I have a problem making a copy of a project, when I make a copy of the working directory for a specific task. Esp. one has to duplicate the lauch configurations. I solve it by reusing the same symlink on Unix. Is there an easier way to work with a changing set of copies of the working directory? Simon -- Simon Pepping home page: http://www.leverkruid.nl
Re: Eclipse and JUnit
On 21.12.2005 14:50:58 Simon Pepping wrote: On Wed, Dec 21, 2005 at 11:03:59AM +0100, Jeremias Maerki wrote: Yes, digging up the right system properties is a nuisance, but you only have to do it once. Have a look at the attached screen shots that show how I set up the launch config for running the FOP test suite. You can see that I simply add an x somewhere to effectively disable the setting for a system property. Like this I'm can change the parameters to the test suite very quickly. Maybe that helps make things easier. Thanks. The x is a nice trick. It would be good to have a document describing the system properties of the test suites. If you do not do it, I will write one. I've started documentation about the layout engine test suite here: http://wiki.apache.org/xmlgraphics-fop/HowToCreateLayoutEngineTests I'm going to add some notes about the various system properties in a few minutes. I see you have a project 'FOP Temp', which probably is a copy of project FOP. I have a problem making a copy of a project, when I make a copy of the working directory for a specific task. Esp. one has to duplicate the lauch configurations. I solve it by reusing the same symlink on Unix. Is there an easier way to work with a changing set of copies of the working directory? Well, being on Windows I don't have symlinks. I simply check out from the same SVN URL again and switch the project dependency in my project with my custom FOP test code from one FOP checkout to the other. Not ideal but not a big deal for me. Jeremias Maerki
Re: Great news! New Apache Members!
On Dec 21, 2005, at 6:21 AM, Jeremias Maerki wrote: It is with big pleasure that I can announce that we have two new Apache Members. Congratulations to Christian Geisert and Jörg Pietschmann!!! Both were elected during the last member's meeting at the ApacheCon in San Diego. Christian and Jörg seem to have made an impression on the Apache membership by their continuous participation in various projects and places inside the ASF. Keep it up guys! Jeremias Maerki Congratulations, Christian Jörg! That is great news. The Apache community can only benefit by your inclusion into Apache membership. Thank you for you continued participation and contributions... Web Maestro Clay
Re: Great news! New Apache Members!
Jeremias Maerki wrote: It is with big pleasure that I can announce that we have two new Apache Members. Congratulations to Christian Geisert and Jörg Pietschmann!!! Both were elected during the last member's meeting at the ApacheCon in San Diego. Christian and Jörg seem to have made an impression on the Apache membership by their continuous participation in various projects and places inside the ASF. Keep it up guys! Congratulations Christian and Jörg! Chris
DO NOT REPLY [Bug 37993] New: - PDF bookmarks: A second bookmark with the same internal-destination gets skipped
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=37993. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=37993 Summary: PDF bookmarks: A second bookmark with the same internal- destination gets skipped Product: Fop Version: 0.90 Platform: All URL: http://www.nabble.com/Bookmark-Support-in-%22fop- 0.90alpha1%22-t784246.html OS/Version: All Status: NEW Severity: normal Priority: P2 Component: pdf AssignedTo: fop-dev@xmlgraphics.apache.org ReportedBy: [EMAIL PROTECTED] The subject basically says it all. I'll attach a test case. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 37993] - PDF bookmarks: A second bookmark with the same internal-destination gets skipped
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=37993. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=37993 --- Additional Comments From [EMAIL PROTECTED] 2005-12-21 16:16 --- Created an attachment (id=17252) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17252action=view) Sample FO file that demonstrates the problem -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
