Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

Warren Young wrote: On May 27, 2014, at 7:55 PM, Joel Bruick wrote: Richard Hipp wrote: I think that's an HTTP thing. In a URL, spaces are encoded as "+". It's really an HTML form thing [1] that only applies to the query portion of the URL. In the path component, we technically should be p

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On 5/28/2014 11:58, Stephan Beal wrote: On Wed, May 28, 2014 at 7:51 PM, Warren Young mailto:war...@etr-usa.com>> wrote: I don't see that there is ambiguity here at all. Ah, correct. The onus is on the one creating the link to do the escaping. ...which does mean it is *partly* Fossil's pr

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On Wed, May 28, 2014 at 7:51 PM, Warren Young wrote: > I don't see that there is ambiguity here at all. Doesn't your case happen > after URL parsing? URL escape decoding should happen *before* the URL is > parsed. > ...If I have a wiki article called "foo++" and want to access it with query > s

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On 5/28/2014 10:14, Stephan Beal wrote: So fossil is incorrect to convert + to space if it is before the first ? in the URL. Interesting question, especially in the face of this case: /wiki/foo equivalent to ===> /wiki?name=foo the first one has no QUERY_STRING but is, internally, tr

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On Wed, May 28, 2014 at 9:28 AM, Francis Daly wrote: > Strictly, space is only encoded as "+" in the QUERY_STRING part of a URL. > > So fossil is incorrect to convert + to space if it is before the first > ? in the URL. > Interesting question, especially in the face of this case: /wiki/foo equi

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On Tue, May 27, 2014 at 02:19:09PM -0600, Andy Bradford wrote: > Thus said Richard Hipp on Tue, 27 May 2014 15:46:30 -0400: Hi there, > Perhaps this should really be something like the following? > > > html "" > > > This results in the following output: > > $ printf 'GET /doc/tip/file%%2b%

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On Wed, May 28, 2014 at 01:08:26AM +, Joe Prostko wrote: > On Tue, May 27, 2014 at 11:31 PM, Warren Young wrote: Hi there, > > 1. You don't need to do regex matching on the URL here. This does the same > > thing more efficiently and more clearly: > > > > location /demo_project/ { > I a

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On Tue, May 27, 2014 at 03:46:30PM -0400, Richard Hipp wrote: > On Tue, May 27, 2014 at 3:43 PM, Warren Young wrote: Hi there, > > I had a file called README-Visual-C++.txt in one of my repositories and > > wanted to link to the tip version of it from an outside web page. I > > discovered the "

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On May 27, 2014, at 7:55 PM, Joel Bruick wrote: > Richard Hipp wrote: >> I think that's an HTTP thing. In a URL, spaces are encoded as "+". > > It's really an HTML form thing [1] that only applies to the query portion of > the URL. In the path component, we technically should be percent-enco

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

Thus said Joel Bruick on Tue, 27 May 2014 21:55:06 -0400: > It's really an HTML form thing [1] that only applies to the query > portion of the URL. In the path component, we technically should be > percent-encoding spaces and leaving any instances of "+" alone, which > would then allow yo

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

Richard Hipp wrote: I think that's an HTTP thing. In a URL, spaces are encoded as "+". So fossil is doing the right thing in converting "+" characters in the URL into spaces. If the filename really does contain "+" symbols, then the URL should have "%2b" for each plus. ex: http://localhos

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On Tue, May 27, 2014 at 11:31 PM, Warren Young wrote: > On 5/27/2014 17:10, Joe Prostko wrote: >> >> On May 27, 2014 6:58 PM, "Warren Young" > > wrote: >> >> > Incidentally, I'm bothering with nginx proxying because the SCGI >> method seems to have broken in 1.28. It w

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

Thus said Richard Hipp on Tue, 27 May 2014 16:37:01 -0400: > Candidate fix checked into trunk. Works here, and much nicer than what I suggested: Before: $ printf 'GET /doc/tip/test/test-page%%2b%%2b.wiki HTTP/1.1\r\nHost: localhost:8080\r\n\r\n' | nc localhost 8080 | grep base http://localhost

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On 5/27/2014 17:48, Warren Young wrote: On 5/27/2014 17:41, Richard Hipp wrote: Is the documentation better now? Yes, thanks! Ooops, grammar bug: "Add one might want..." Do you mean "Additionally, ..."? ___ fossil-users mailing list fossil-users@

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On 5/27/2014 17:41, Richard Hipp wrote: Is the documentation better now? Yes, thanks! ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

Is the documentation better now? http://www.fossil-scm.org/fossil/doc/trunk/www/server.wiki#scgi Thanks for testing out SCGI for us. On Tue, May 27, 2014 at 7:31 PM, Warren Young wrote: > On 5/27/2014 17:10, Joe Prostko wrote: > >> On May 27, 2014 6:58 PM, "Warren Young" >

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On 5/27/2014 17:10, Joe Prostko wrote: On May 27, 2014 6:58 PM, "Warren Young" mailto:war...@etr-usa.com>> wrote: > Incidentally, I'm bothering with nginx proxying because the SCGI method seems to have broken in 1.28. It was working fine on my site with 1.27 from the Ubuntu repository until I

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On May 27, 2014 6:58 PM, "Warren Young" wrote: > Incidentally, I'm bothering with nginx proxying because the SCGI method seems to have broken in 1.28. It was working fine on my site with 1.27 from the Ubuntu repository until I upgraded to 1.28 by building from source. (I wanted the /tree featur

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On 5/27/2014 14:37, Richard Hipp wrote: Candidate fix checked into trunk. I just installed [5d4400400a] and it still doesn't work, regardless of %2b or not %2b. (That *was* the query, quoth Hamlet after all.) I get a "Document Not Found" page back from Fossil, with the body section being "

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On 5/27/2014 13:46, Richard Hipp wrote: If the filename really does contain "+" symbols, then the URL should have "%2b" for each plus. Sorry, I should have mentioned that I did try that. This is with the nginx-proxied configuration that I posted here about on Sunday. I suspect nginx is tran

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

Hello, on Tuesday 27 May 2014 at 15:46, Richard Hipp wrote: > On Tue, May 27, 2014 at 3:43 PM, Warren Young wrote: > > > I had a file called README-Visual-C++.txt in one of my repositories and > > wanted to link to the tip version of it from an outside web page. I > > discovered the "doc URL" f

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

Candidate fix checked into trunk. On Tue, May 27, 2014 at 4:21 PM, Richard Hipp wrote: > Or, maybe $current_page should be HTTP-encoded instead of plaintext. > > > On Tue, May 27, 2014 at 4:19 PM, Andy Bradford > wrote: > >> Thus said Richard Hipp on Tue, 27 May 2014 15:46:30 -0400: >> >> > I

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

Or, maybe $current_page should be HTTP-encoded instead of plaintext. On Tue, May 27, 2014 at 4:19 PM, Andy Bradford wrote: > Thus said Richard Hipp on Tue, 27 May 2014 15:46:30 -0400: > > > I think that's an HTTP thing. In a URL, spaces are encoded as "+". So > > fossil is doing the right thin

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

Thus said Richard Hipp on Tue, 27 May 2014 15:46:30 -0400: > I think that's an HTTP thing. In a URL, spaces are encoded as "+". So > fossil is doing the right thing in converting "+" characters in the > URL into spaces. It certainly handles them correctly when given them, however, there may

Re: [fossil-users] FYI: doc URLs don't work with filenames that have + in their names

On Tue, May 27, 2014 at 3:43 PM, Warren Young wrote: > I had a file called README-Visual-C++.txt in one of my repositories and > wanted to link to the tip version of it from an outside web page. I > discovered the "doc URL" feature in Fossil, but it didn't work with that > file. Apparently ther