Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-30 Thread George Bakhtadze
> For example, if I have changes in separate files that I want to split up, how > might one go about it without manually modiying the patch files? (As an easy > example, I split up the uComplex patches into two... one with the alignment > and vectorcall changes, and the other with the "const"

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-29 Thread J. Gareth Moreton
Thanks George, As Florian stated, my work on the optimiser overhaul has been rejected because of how intertwined it is, along with some elements of 'code smell', but there's plenty to salvage and he hasn't slammed the door on the concept.  I'm still learning to use git and patches, especially

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-29 Thread George Bakhtadze
> Oh yeah, conflict resolution is the thing nobody really gets right, but TGit is> a bit less wrong.> I've pretty much resigned myself to Ctrl-F ">"... I use Intellij IDEA as VCS client (both git and svn supported).Patches, partial commits and conflicts resolution (automatic for many cases)

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-28 Thread Ewald
On 10/27/2019 08:16 PM, Martok wrote: > Am 27.10.2019 um 17:48 schrieb Florian Klämpfl: >>> I guess the main difference is whether one prefers side-by-side >>> diffs or udiffs. >> >> In particular partial commits as well as conflict resolution work much >> better with TortoiseGit for me. > > Oh

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-27 Thread Michael Van Canneyt
On Sun, 27 Oct 2019, Martok wrote: Am 27.10.2019 um 17:48 schrieb Florian Klämpfl: I guess the main difference is whether one prefers side-by-side diffs or udiffs. In particular partial commits as well as conflict resolution work much better with TortoiseGit for me. Oh yeah, conflict

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-27 Thread Martok
Am 27.10.2019 um 17:48 schrieb Florian Klämpfl: >> I guess the main difference is whether one prefers side-by-side >> diffs or udiffs. > > In particular partial commits as well as conflict resolution work much > better with TortoiseGit for me. Oh yeah, conflict resolution is the thing nobody

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-27 Thread Benito van der Zander
Hi, I use TortoiseHg and then a Mercurial to Git converter... Unfortunately the linux distributions do not want to maintain it and most ship with an outdated TortoiseHg in their package management Best, Benito On 27.10.19 17:48, Florian Klämpfl wrote: Am 27.10.19 um 15:32 schrieb Martok:

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-27 Thread Florian Klämpfl
Am 27.10.19 um 15:32 schrieb Martok: cover one single topic. Today, using e.g. TortoiseGit on Windows (sorry, on Linux there is no tool which comes close) such patches can be re-arranged without too much hazzle. Just plain ol' git-gui can also do it. SmartGit is cross-platform and also pretty

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-27 Thread Martok
> cover one single topic. Today, using e.g. TortoiseGit on Windows (sorry, > on Linux there is no tool which comes close) such patches can be > re-arranged without too much hazzle. Just plain ol' git-gui can also do it. SmartGit is cross-platform and also pretty nice. I guess the main

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-26 Thread Florian Klämpfl
Am 26.10.19 um 16:47 schrieb J. Gareth Moreton: Hi Florian, That seems like a fair assessment.  I'll see what I can do, especially as I have a design spec to go by, so maybe there's stuff to salvage and re-implement. If I recall, there was a similar TODO in the current code and it just got

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-26 Thread J. Gareth Moreton
Still, if anything, contributing to the compiler like this and having patches rejected is teaching me to be a better coder, so thank you Florian! Gareth aka. Kit -- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-26 Thread J. Gareth Moreton
Sorry, I meant a "repeat... until False;" loop, using "Break" or "Exit" statements when I actually want to leave it, and "Continue" for the 'not-a-goto' statement! On 26/10/2019 15:47, J. Gareth Moreton wrote: Hi Florian, That seems like a fair assessment.  I'll see what I can do, especially

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-26 Thread J. Gareth Moreton
Hi Florian, That seems like a fair assessment.  I'll see what I can do, especially as I have a design spec to go by, so maybe there's stuff to salvage and re-implement. If I recall, there was a similar TODO in the current code and it just got moved, but I'll double-check that. I've seen

Re: [fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-26 Thread Florian Klämpfl
Am 18.10.19 um 18:07 schrieb J. Gareth Moreton: Hi everyone, How is everyone doing?  Sorry for my silence - been a bit tied up with things in life.  Anyway, that aside, has there been any further progress on reviewing the x86_64 optimizer overhaul over at

[fpc-devel] Progress on reviewing x86_64 optimizer overhaul and node semantic pass

2019-10-18 Thread J. Gareth Moreton
Hi everyone, How is everyone doing?  Sorry for my silence - been a bit tied up with things in life.  Anyway, that aside, has there been any further progress on reviewing the x86_64 optimizer overhaul over at https://bugs.freepascal.org/view.php?id=34628? I ask because I've sort-of blocked