Re: make modules kicks the first module directory twice

2000-11-15 Thread Bruce Evans
On Tue, 14 Nov 2000, Warner Losh wrote: make depend is already *REQUIRED* when you are updating a kernel from an older version of the kernel. For config -r FOO kernels it isn't. It is neither necessary nor sufficient for updating. config -r removes conflicting garbage from previous builds.

Re: make modules kicks the first module directory twice

2000-11-14 Thread David O'Brien
On Mon, Nov 13, 2000 at 09:17:54PM -0700, Warner Losh wrote: The implications are that make obj isn't done unless you've run make depend first. If a new directory is added and a make depend isn't run, then the modules won't get built into the obj tree, but instead will be built into

Re: RQ review: [was: Re: make modules kicks the first module directory twice]

2000-11-14 Thread David O'Brien
On Mon, Nov 13, 2000 at 08:02:47PM -0800, Marcel Moolenaar wrote: Any objections? Yes. (patches follow for your convenience) [its easier to read patches when they aren't quoted in their entirety ;-)] modules-depend: @mkdir -p ${.OBJDIR}/modules ! cd $S/modules; env

Re: make modules kicks the first module directory twice

2000-11-14 Thread Warner Losh
In message [EMAIL PROTECTED] "David O'Brien" writes: : On Mon, Nov 13, 2000 at 09:17:54PM -0700, Warner Losh wrote: : The implications are that make obj isn't done unless you've run make : depend first. If a new directory is added and a make depend isn't : run, then the modules won't get

Re: make modules kicks the first module directory twice

2000-11-14 Thread David O'Brien
[stable dropped, this should have only been in a single list to start with!!] On Tue, Nov 14, 2000 at 01:27:32PM -0700, Warner Losh wrote: : I'd rather take a major compile time hit and be deterministic than not. I'd rather not. We don't do an implicit make obj in the rest of the tree.

Re: make modules kicks the first module directory twice

2000-11-14 Thread Warner Losh
In message [EMAIL PROTECTED] "David O'Brien" writes: : [stable dropped, this should have only been in a single list to start with!!] Agreed. My summary: o We disagree about the support impact o Peter's stuff may OBE this whole thread o My change shouldn't be committed

Re: RQ review: [was: Re: make modules kicks the first module directory twice]

2000-11-14 Thread Marcel Moolenaar
David O'Brien wrote: modules-depend: @mkdir -p ${.OBJDIR}/modules ! cd $S/modules; env ${MKMODULESENV} ${MAKE} obj ! env ${MKMODULESENV} ${MAKE} depend This is broken for non -j case. Yes, this was known. The right diff was given at the beginning of the

Re: make modules kicks the first module directory twice

2000-11-13 Thread Bruce Evans
On Sun, 12 Nov 2000, Marcel Moolenaar wrote: Makoto MATSUSHITA wrote: % make -j 2 modules cd ../../modules env MAKEOBJDIRPREFIX=/usr/src/sys/compile/GENERIC/modules KMODDIR=/boot/kernel make obj all === 3dfx === 3dfx Warning: Object directory not changed from original

Re: make modules kicks the first module directory twice

2000-11-13 Thread Makoto MATSUSHITA
bde (In the above example, the targets are built concurrently and race bde each other. This is bad when the `all' target wins the race. The bde `obj' target runs faster, so it usually wins the race except in the bde first directory (3dfx)). More .ORDER statements in *.mk are required. Thank

Re: make modules kicks the first module directory twice

2000-11-13 Thread Bruce Evans
On Mon, 13 Nov 2000, Makoto MATSUSHITA wrote: bde (In the above example, the targets are built concurrently and race bde each other. This is bad when the `all' target wins the race. The bde `obj' target runs faster, so it usually wins the race except in the bde first directory (3dfx)).

Re: make modules kicks the first module directory twice

2000-11-13 Thread David O'Brien
On Sun, Nov 12, 2000 at 11:58:39PM -0700, Warner Losh wrote: In message [EMAIL PROTECTED] Makoto MATSUSHITA writes: : It does not fix this problem. However, if we separate the execution of : "make obj" and "make all", we can avoid (again, not *fix*) the problem. : Maybe this change is

Re: make modules kicks the first module directory twice

2000-11-13 Thread David O'Brien
On Mon, Nov 13, 2000 at 07:51:11PM +0900, Makoto MATSUSHITA wrote: ! cd $S/modules env ${MKMODULESENV} ${MAKE} obj all --- 310,322 ! cd $S/modules env ${MKMODULESENV} ${MAKE} obj ! cd $S/modules env ${MKMODULESENV} ${MAKE} all I can certainly commit this type of fix.

Re: make modules kicks the first module directory twice

2000-11-13 Thread Marcel Moolenaar
Bruce Evans wrote: Index: Makefile.i386 === RCS file: /home/ncvs/src/sys/conf/Makefile.i386,v retrieving revision 1.212 diff -u -r1.212 Makefile.i386 --- Makefile.i386 2000/10/29 09:47:50 1.212 +++

Re: make modules kicks the first module directory twice

2000-11-13 Thread Marcel Moolenaar
David O'Brien wrote: On Mon, Nov 13, 2000 at 07:51:11PM +0900, Makoto MATSUSHITA wrote: ! cd $S/modules env ${MKMODULESENV} ${MAKE} obj all --- 310,322 ! cd $S/modules env ${MKMODULESENV} ${MAKE} obj ! cd $S/modules env ${MKMODULESENV} ${MAKE} all I can certainly

Re: make modules kicks the first module directory twice

2000-11-13 Thread Marcel Moolenaar
Marcel Moolenaar wrote: David O'Brien wrote: On Mon, Nov 13, 2000 at 07:51:11PM +0900, Makoto MATSUSHITA wrote: ! cd $S/modules env ${MKMODULESENV} ${MAKE} obj all --- 310,322 ! cd $S/modules env ${MKMODULESENV} ${MAKE} obj ! cd $S/modules env

Re: make modules kicks the first module directory twice

2000-11-13 Thread Warner Losh
In message [EMAIL PROTECTED] "David O'Brien" writes: : On Sun, Nov 12, 2000 at 11:58:39PM -0700, Warner Losh wrote: : In message [EMAIL PROTECTED] Makoto MATSUSHITA writes: : : It does not fix this problem. However, if we separate the execution of : : "make obj" and "make all", we can avoid

Re: make modules kicks the first module directory twice

2000-11-13 Thread David O'Brien
On Mon, Nov 13, 2000 at 01:19:38PM -0500, Marcel Moolenaar wrote: I'll commit a fix with just semi-colons today for all architectures if someone hasn't done that already by that time. Can you post a patch first. There seems to be some subtleties here that might make a review useful. -- --

Re: make modules kicks the first module directory twice

2000-11-13 Thread David O'Brien
On Mon, Nov 13, 2000 at 12:23:08PM -0700, Warner Losh wrote: : I think that make has no business doing an implicit make obj for the : all target. : Someone has to run `make obj' for the modules tree. How are you doing it : locally? Right now we do it twice. Once in make dpeend and

Re: make modules kicks the first module directory twice

2000-11-13 Thread Warner Losh
In message [EMAIL PROTECTED] "David O'Brien" writes: : It doesn't warn the user, it errors out (possibly a suttle distinction : I'm making). Also in the past a `make depend' for the kernel was not : required. Just highly suggested. Are we really prepared to make it a : requirement now? I am,

Re: make modules kicks the first module directory twice

2000-11-13 Thread Marcel Moolenaar
David O'Brien wrote: On Mon, Nov 13, 2000 at 01:19:38PM -0500, Marcel Moolenaar wrote: I'll commit a fix with just semi-colons today for all architectures if someone hasn't done that already by that time. Can you post a patch first. There seems to be some subtleties here that might

Re: make modules kicks the first module directory twice

2000-11-13 Thread Makoto MATSUSHITA
marcel No you can't. $S expands to "../.." which only works for the marcel first cd in the -jX case. The second cd will fail. Ouch... give me one more chance to submit a patch. Here's summary: * src/release/Makefile should use 'module-depend' while checking dependancy of

Re: make modules kicks the first module directory twice

2000-11-13 Thread Marcel Moolenaar
[-stable removed from the cc list] Makoto MATSUSHITA wrote: marcel No you can't. $S expands to "../.." which only works for the marcel first cd in the -jX case. The second cd will fail. Ouch... Sorry :-) give me one more chance to submit a patch. Here's summary: You're not going to

RQ review: [was: Re: make modules kicks the first module directory twice]

2000-11-13 Thread Marcel Moolenaar
Makoto MATSUSHITA wrote: Ouch... give me one more chance to submit a patch. Here's summary: I see no reason to not commit Makoto-san's patches with the fix he sent me for the modules-depend target. The fix is (modulo indentation): modules-depend: ! cd $S/modules; env

Re: make modules kicks the first module directory twice

2000-11-13 Thread Warner Losh
In message [EMAIL PROTECTED] Marcel Moolenaar writes: : BTW: I'm also looking at Warner's patch. Maybe that's the better fix for : it, but I have to dig into the Makefiles a bit more to get a better : picture... The implications are that make obj isn't done unless you've run make depend first.

Re: make modules kicks the first module directory twice

2000-11-12 Thread Warner Losh
In message [EMAIL PROTECTED] Makoto MATSUSHITA writes: : It does not fix this problem. However, if we separate the execution of : "make obj" and "make all", we can avoid (again, not *fix*) the problem. : Maybe this change is reasonable; there is few meaning doing "make : kernel-depend" in

Re: make modules kicks the first module directory twice

2000-11-12 Thread Marcel Moolenaar
Makoto MATSUSHITA wrote: % make -j 2 modules cd ../../modules env MAKEOBJDIRPREFIX=/usr/src/sys/compile/GENERIC/modules KMODDIR=/boot/kernel make obj all === 3dfx === 3dfx Warning: Object directory not changed from original /usr/src/sys/modules/3dfx (... ok, break it ...) The problem