[Freeciv-Dev] [bug #13841] [Patch] Worklist clean up

2009-07-01 Thread Marko Lindqvist
Update of bug #13841 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?13841 ___ Message sent

[Freeciv-Dev] [bug #13842] [Patch] Base flag NoAggressive works with units other than land moving

2009-07-01 Thread Marko Lindqvist
URL: http://gna.org/bugs/?13842 Summary: [Patch] Base flag NoAggressive works with units other than land moving Project: Freeciv Submitted by: cazfi Submitted on: Wednesday 07/01/2009 at 19:54 Category: general

[Freeciv-Dev] [bug #13843] [Patch] Build base menu

2009-07-01 Thread Marko Lindqvist
URL: http://gna.org/bugs/?13843 Summary: [Patch] Build base menu Project: Freeciv Submitted by: cazfi Submitted on: Wednesday 07/01/2009 at 20:11 Category: client-gtk-2.0 Severity: 3 - Normal

[Freeciv-Dev] [bug #13750] [Patch] Configure time fix for ggz enabled gtk client

2009-07-01 Thread Marko Lindqvist
Update of bug #13750 (project freeciv): Status:None = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

Re: [Freeciv-Dev] how to use git locally for freeciv

2009-07-01 Thread Matthias Pfafferodt
and here is one copy for the list .. Am Wednesday 01 July 2009 01:48:20 schrieben Sie: On 30/06/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote: Am Tuesday 30 June 2009 05:06:02 schrieben Sie: On 29/06/2009, Madeline Book madeline.b...@gmail.com wrote: I just made a git

Re: [Freeciv-Dev] settings rework

2009-07-01 Thread Matthias Pfafferodt
The thing is, using just s as the variable name might conflict with string variables, and ss is not much better (but probably as good as op, if some other pointer-to-object variables do not use it already). Another possibility is psetting (like there is pcity, punit, etc.), though it is quite

[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings

2009-07-01 Thread Matthias Pfafferodt
Follow-up Comment #7, bug #13810 (project freeciv): version 4; changes: - rename op_* to pset_* (pset = pointer to struct setting) (file #6104) ___ Additional Item Attachment: File name: version4-gna13810.patch.diff Size:41 KB

[Freeciv-Dev] [bug #13684] [Patch] AI: Check fuel, not AIR_MOVING, when determining type simpliness

2009-07-01 Thread Marko Lindqvist
Update of bug #13684 (project freeciv): Status:None = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #13707] [Patch] Free memory allocated by init_nls()

2009-07-01 Thread Marko Lindqvist
Follow-up Comment #1, bug #13707 (project freeciv): S2_1 version (file #6105) ___ Additional Item Attachment: File name: NlsMemLeakFix_13707-S2_1.diff Size:2 KB ___ Reply to

Re: [Freeciv-Dev] settings rework

2009-07-01 Thread Matthias Pfafferodt
Those are the 3 that are being actively developed. My longterm goal is to merge them all into one project. Looking through the patches of longturn and warclient I found the patch 'Setting to control distance of traderoutes.' (longturn 20090623). This is something I also wanted to implement

[Freeciv-Dev] [bug #13753] [Patch] TerrainDefense unit class flag

2009-07-01 Thread Marko Lindqvist
Update of bug #13753 (project freeciv): Status:None = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #13845] [Patch] Help mentions if unit has no TerrainDefense flag

2009-07-01 Thread Marko Lindqvist
URL: http://gna.org/bugs/?13845 Summary: [Patch] Help mentions if unit has no TerrainDefense flag Project: Freeciv Submitted by: cazfi Submitted on: Thursday 07/02/2009 at 00:23 Category: client Severity:

[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings

2009-07-01 Thread Madeline Book
Follow-up Comment #8, bug #13810 (project freeciv): I meant pset only for the variable names; functions structs, etc. should have setting. The variable name should usually give some hint as to what it stands for. So cmd, when the type is struct setting *, would not be a good variable name

[Freeciv-Dev] [bug #13846] recursion checking for the read command

2009-07-01 Thread Matthias Pfafferodt
URL: http://gna.org/bugs/?13846 Summary: recursion checking for the read command Project: Freeciv Submitted by: syntron Submitted on: Mittwoch 01.07.2009 um 21:42 Category: general Severity: 2 - Minor

[Freeciv-Dev] [bug #13846] recursion checking for the read command

2009-07-01 Thread Matthias Pfafferodt
Follow-up Comment #1, bug #13846 (project freeciv): add missing changes to stdinhand.h (file #6108) ___ Additional Item Attachment: File name: 0001-recursion-checking-for-the-read-command.patch Size:7 KB

[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings

2009-07-01 Thread Madeline Book
Follow-up Comment #9, bug #13810 (project freeciv): _(pset_short_help(i)) Why not put the _() in setting_short_help() and write in the comment header that it returns the translated version? This goes for all such dupicated expressions. Why do you use the setting number as first argument to

[Freeciv-Dev] [bug #13846] recursion checking for the read command

2009-07-01 Thread Marko Lindqvist
Follow-up Comment #2, bug #13846 (project freeciv): Just infinite recursion should be prohibited, not any read inside other read. That is, original file should not read itself, nor file that reads the original, nor file that reads file that read original... but otherwise read should be allowed.

Re: [Freeciv-Dev] settings rework

2009-07-01 Thread Madeline Book
On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote: Those are the 3 that are being actively developed. My longterm goal is to merge them all into one project. Looking through the patches of longturn and warclient I found the patch 'Setting to control distance of

[Freeciv-Dev] [bug #13847] Build of multiple clients fails when one of them is ggz enabled gtk

2009-07-01 Thread Marko Lindqvist
URL: http://gna.org/bugs/?13847 Summary: Build of multiple clients fails when one of them is ggz enabled gtk Project: Freeciv Submitted by: cazfi Submitted on: Thursday 07/02/2009 at 01:21 Category: client

Re: [Freeciv-Dev] settings rework

2009-07-01 Thread Madeline Book
On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote: I did rename op_* to pset_* as it matches the purpose of the variable: a pointer to a setting struct Do this for variable names whose type is 'struct setting *' or 'const struct setting *' only, not function names. How

[Freeciv-Dev] [bug #13846] recursion checking for the read command

2009-07-01 Thread Madeline Book
Follow-up Comment #4, bug #13846 (project freeciv): Please no static variables. Use a context argument and a wrapper/recursive function pair. Ask if you need an example. なんじゃそりゃ。

Re: [Freeciv-Dev] how to use git locally for freeciv

2009-07-01 Thread Madeline Book
On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote: You don't need to. As I said the 3 GB size is not a problem. I think I will also get warclient and longturn to compare ... The 3 GB is just silly. The entire history of the trunk and S2_1 branches when cloned from

[Freeciv-Dev] [bug #13847] Build of multiple clients fails when one of them is ggz enabled gtk

2009-07-01 Thread Marko Lindqvist
Follow-up Comment #1, bug #13847 (project freeciv): Fix (file #6109) ___ Additional Item Attachment: File name: EmbedGgzMultiClient.diff Size:11 KB ___ Reply to this item

[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

2009-07-01 Thread Madeline Book
URL: http://gna.org/bugs/?13848 Summary: [Patch] More detailed coding style guidelines Project: Freeciv Submitted by: mbook Submitted on: Thursday 07/02/2009 at 02:33 Category: docs Severity: 4 -