[Freeciv-Dev] [patch #4402] Fix typo that allowed custom formats only up to sizeof(char*)

2014-01-03 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4402 Summary: Fix typo that allowed custom formats only up to sizeof(char*) Project: Freeciv Submitted by: silene Submitted on: Fri 03 Jan 2014 01:22:58 PM CET Category: general

[Freeciv-Dev] [patch #4387] Store client options inside .freeciv/

2014-01-02 Thread Guillaume Melquiond
Follow-up Comment #1, patch #4387 (project freeciv): Would it be possible to convince you to use the XDG specification [1] rather than hardcoding the configuration directory? This specification has now been the de facto standard for several years and it would be unfortunate if Freeciv was not

[Freeciv-Dev] [patch #4387] Store client options inside .freeciv/

2014-01-02 Thread Guillaume Melquiond
Follow-up Comment #4, patch #4387 (project freeciv): You make it sound like an all-or-nothing situation. I'm not suggesting to fully support XDG at once (nor ever). I am just suggesting that, instead of moving from ~/.freeciv-client-rc-2.6 to ~/.freeciv/freeciv-client-rc-2.6, you move to

[Freeciv-Dev] [patch #4387] Store client options inside .freeciv/

2014-01-02 Thread Guillaume Melquiond
Follow-up Comment #6, patch #4387 (project freeciv): For Windows, I think the scheme can be adapted easily. Indeed, on XDG-compliant systems, either $XDG_CONFIG_HOME is set and the program uses it, or it uses ~/.config instead. For Windows, the same logic could be used, either $XDG_CONFIG_HOME is

[Freeciv-Dev] [patch #4378] Minimize the gold clause when exchanging technologies

2014-01-02 Thread Guillaume Melquiond
Follow-up Comment #2, patch #4378 (project freeciv): Good catch. It wasn't initialized on purpose (no sane default, except perhaps the largest integer), but it was meant to be protected by a check on tech_p1, which is initialized. The check somehow got lost when removing all the debugging cruft

[Freeciv-Dev] [patch #4373] Silence some compiler warnings and fix some severe bugs along the way

2013-12-31 Thread Guillaume Melquiond
Follow-up Comment #4, patch #4373 (project freeciv): I have updated the patches for trunk and S2_5, since the cast that allowed to hide the memory corruption in client/tilespec.c is no longer needed. I have also submitted patches for S2_4 and S2_3. (I finally got them to compile.) They silence a

[Freeciv-Dev] [patch #4378] Minimize the gold clause when exchanging technologies

2013-12-31 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4378 Summary: Minimize the gold clause when exchanging technologies Project: Freeciv Submitted by: silene Submitted on: Tue 31 Dec 2013 03:20:26 PM CET Category: ai Priority: 5 -

[Freeciv-Dev] [patch #4373] Silence some compiler warnings and fix some severe bugs along the way

2013-12-30 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4373 Summary: Silence some compiler warnings and fix some severe bugs along the way Project: Freeciv Submitted by: silene Submitted on: Mon 30 Dec 2013 06:04:01 PM CET Category: None

[Freeciv-Dev] [patch #4373] Silence some compiler warnings and fix some severe bugs along the way

2013-12-30 Thread Guillaume Melquiond
Follow-up Comment #2, patch #4373 (project freeciv): Which branches are considered stable (and not just obsolete)? I attach a patch for S2_5: it contains the changes for client/tilespec.c and common/map.c. S2_4 does not compile for me, but from visual inspection of the code, the same issues are

[Freeciv-Dev] [patch #4369] Untranslate rule_name fields in the civ2civ3 ruleset

2013-12-29 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4369 Summary: Untranslate rule_name fields in the civ2civ3 ruleset Project: Freeciv Submitted by: silene Submitted on: Sun 29 Dec 2013 01:58:06 PM CET Category: rulesets

[Freeciv-Dev] [patch #4370] Fix broken reason for AI war

2013-12-29 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4370 Summary: Fix broken reason for AI war Project: Freeciv Submitted by: silene Submitted on: Sun 29 Dec 2013 05:39:08 PM CET Category: ai Priority: 5 - Normal

[Freeciv-Dev] [patch #4365] Propose a ceasefire on first contact only in case of war

2013-12-29 Thread Guillaume Melquiond
Follow-up Comment #3, patch #4365 (project freeciv): Step 4 does not happen, since the second player proposes a ceasefire only if the first player is not an AI. (server/plrhand.c:1928) ___ Reply to this item at:

[Freeciv-Dev] [patch #4370] Fix broken reason for AI war

2013-12-29 Thread Guillaume Melquiond
Follow-up Comment #2, patch #4370 (project freeciv): I am not sure if I understand correctly what you suggest, but I don't think it can happen. The AI tests if there already is a countdown going on before declaring war, so it won't be overriding a space race reason.

[Freeciv-Dev] [patch #4298] Fix shutdown sequence for gtk3 client

2013-11-08 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4298 Summary: Fix shutdown sequence for gtk3 client Project: Freeciv Submitted by: silene Submitted on: Fri 08 Nov 2013 03:15:42 PM CET Category: client-gtk-3.0 Priority: 5 -

[Freeciv-Dev] [patch #4296] Remove incorrect assertion for non-null nationality

2013-11-07 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4296 Summary: Remove incorrect assertion for non-null nationality Project: Freeciv Submitted by: silene Submitted on: Thu 07 Nov 2013 10:35:40 PM CET Category: client Priority: 5

[Freeciv-Dev] [patch #4296] Remove incorrect assertion for non-null nationality

2013-11-07 Thread Guillaume Melquiond
Follow-up Comment #2, patch #4296 (project freeciv): Sorry for the ambiguous sentence. Server-side, nationality is indeed always non-null. What I meant is that some units received by the clients from the server have their nationality set to null, e.g. enemy units.

[Freeciv-Dev] [patch #4293] Fix broken menu items for gtk clients

2013-11-06 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4293 Summary: Fix broken menu items for gtk clients Project: Freeciv Submitted by: silene Submitted on: Wed 06 Nov 2013 02:53:18 PM CET Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #4294] Fix ctrl+click in the city list for the gtk3 client

2013-11-06 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4294 Summary: Fix ctrl+click in the city list for the gtk3 client Project: Freeciv Submitted by: silene Submitted on: Wed 06 Nov 2013 08:34:22 PM CET Category: client-gtk-3.0

[Freeciv-Dev] [patch #3904] Fix auto-settler mode breaking when units travel through transports

2013-05-11 Thread Guillaume Melquiond
URL: http://gna.org/patch/?3904 Summary: Fix auto-settler mode breaking when units travel through transports Project: Freeciv Submitted by: silene Submitted on: sam. 11 mai 2013 15:21:59 CEST Category: None

[Freeciv-Dev] [patch #3902] Fix unit disband when cities starve

2013-05-08 Thread Guillaume Melquiond
URL: http://gna.org/patch/?3902 Summary: Fix unit disband when cities starve Project: Freeciv Submitted by: silene Submitted on: mer. 08 mai 2013 11:18:45 CEST Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #3896] Fix some memory leaks

2013-05-05 Thread Guillaume Melquiond
URL: http://gna.org/patch/?3896 Summary: Fix some memory leaks Project: Freeciv Submitted by: silene Submitted on: dim. 05 mai 2013 19:40:44 CEST Category: None Priority: 5 - Normal