Re: [Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-08-01 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 2008/7/28 Nicolas R. Wadhwani: tile_city() returns real current situation. Instead server should send to client what player knows. Player may think there is a city in fogged tile, when in reality city has been destroyed since last

Re: [Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-27 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 Indeed Marko is right; this is a server problem after all. You should be sending the city ID of the dumb city. This code has been rewritten however and apparently I no longer have any clue how it works. See maphand.h. -jason

Re: [Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 tile_city() returns real current situation. Instead server should send to client what player knows. Player may think there is a city in fogged tile, when in reality city has been destroyed since last seen, or new city has been founded

Re: [Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-27 Thread Nicolas R. Wadhwani
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 tile_city() returns real current situation. Instead server should send to client what player knows. Player may think there is a city in fogged tile, when in reality city has been destroyed since last seen, or new city has been

Re: [Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-25 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 2008/7/25 Marko Lindqvist: You seem to be avoiding setting ptile-worked to NULL when server requests it by sending worked == IDENTITY_NUMBER_ZERO. It seems to me that problem has to be in server side sending such information in the

[Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-25 Thread Freeciv guest user
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 [EMAIL PROTECTED] - Fr 25. Jul 2008, 16:12:11]: It seems to me that problem has to be in server side sending such information in the first place. Something wrong with send_tile_info()? Thanks for the hint. The same I did on the

[Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-25 Thread Freeciv guest user
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 [EMAIL PROTECTED] - Fr 25. Jul 2008, 16:12:11]: It seems to me that problem has to be in server side sending such information in the first place. Something wrong with send_tile_info()? Thanks for the hint. The same I did on the

Re: [Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-24 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 2008/7/24 guest user: There is the catch: Between the versions the ptile-city member has been replaced by ptile-worked which points to the city working on the tile, so many tiles are pointing to the same city (in the city radius I

Re: [Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-24 Thread Per I. Mathisen
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 On Thu, Jul 24, 2008 at 1:01 PM, Marko Lindqvist [EMAIL PROTECTED] wrote: This also brings the concept of client sied invisible cities. These are cities client knows to exist, because it has seen some tile it uses, but doesn't know

[Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 [per - Thu Jul 24 12:14:28 2008]: On Thu, Jul 24, 2008 at 1:01 PM, Marko Lindqvist [EMAIL PROTECTED] wrote: This also brings the concept of client sied invisible cities. These are cities client knows to exist, because it has

Re: [Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-23 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 On Wed, Jul 23, 2008 at 6:13 PM, guest user Freeciv wrote: There is the catch: Between the versions the ptile-city member has been replaced by ptile-worked which points to the city working on the tile, so many tiles are pointing to

[Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-23 Thread Freeciv guest user
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 [EMAIL PROTECTED] Well I probably have the time for working on this but my experience doesn't quite match yours with neither the C programming language nor the freeciv source code, so I'm not all that confident that it would be just a

[Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-23 Thread Freeciv guest user
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 pcity-tile and ptile-city are both set to the correct values. In general ptile-city-tile == ptile and pcity-tile-city == pcity all the time (that would be a useful assertion to add somewhere - in fact client-side sanity checks might

Re: [Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40316 On Tue, Jul 22, 2008 at 4:34 PM, guest user Freeciv wrote: Attached patch will let the cities be visible in the fog after you viewed them with a unit or something else. Note that if you test it on a savegame affected by the current