Update of patch #3325 (project freeciv):
Status:None = Ready For Test
___
Reply to this item at:
http://gna.org/patch/?3325
___
Message sent
Follow-up Comment #12, patch #3325 (project freeciv):
READY FOR TEST - Merged and diff'd against svn 21347.
I worked out the bug, took me all week as I manually mapped out all function
calls and struct types. I had restored the function that turns the packet
government struct into the real one
Follow-up Comment #11, patch #3325 (project freeciv):
Ignore that last one. I changed something and it doesn't work anymore.. time
for me to learn svn I guess. I'll try again next week... :(
___
Reply to this item at:
Follow-up Comment #7, patch #3325 (project freeciv):
It's WORKING! I just started a game with it. Everything is getting read in
correctly and effects are getting matched against everything. There is still
some general weirdness (bonus to tiles shows up in the output but not in
display and units
Follow-up Comment #8, patch #3325 (project freeciv):
Ok, just found why ALL the effects are working and server checking on whether
or not a unit can be built based on govflag_req is going fine, but city
production dialog doesn't know it can build a unit.
Turns out the same bug happens if a unit
Follow-up Comment #9, patch #3325 (project freeciv):
I am 99% sure the bug is in collect_production_targets(...) in climisc.c
My testing and many inserted debug comments shows everything else is working
behind the scenes.. it is just the client worklist window for some reason
won't add govreq
Follow-up Comment #10, patch #3325 (project freeciv):
Here is the completed patch, diff'd against the latest nightly.
(file #15848)
___
Additional Item Attachment:
File name: governmentflags.diff Size:24 KB
Follow-up Comment #1, patch #3325 (project freeciv):
O.k. I've spent all day working on it and I am starting to get my head around
it. I am not messing with requirements yet, just working on getting flags read
from the ruleset, stored in the government struct and passed around correctly.
In this
Follow-up Comment #2, patch #3325 (project freeciv):
You remember me, but I've spent months with #1339.
Gmake result in SVN (rev. 21329) with your ruleset.c
ruleset.c: In function 'load_government_names':
ruleset.c:2488:24: error: 'MAX_NUM_USER_GOV_FLAGS' undeclared (first use in
this function)
Follow-up Comment #3, patch #3325 (project freeciv):
fc_assert(!gtype_has_flag(g, F_LAST - 1));
F_LAST (last unit type flag) seems like copypaste error here...
if (F_LAST == ival) {
...and here.
for(j=0; jnval; j++) {
Spaces: for (j = 0; j nval; j++) {
log_error(%s
Follow-up Comment #4, patch #3325 (project freeciv):
Thanks for the pickup. I've fixed it all (all enums related to gov flag now
start with G_). I've taken gorbs advice and been running make clean / make
every time I save a file, so now I am compiling with no warnings/errors w/
regard to:
Follow-up Comment #5, patch #3325 (project freeciv):
Hmm. I have another problem I need to sort through in rulesets.c.
Are requirements in [unit_type] or ||? That is, if a unit has gov_req =
SomeMilitaryGov and govflag_req = NotAMilitaryGov, does that mean that a
unit can never be built, does
Follow-up Comment #6, patch #3325 (project freeciv):
Heck yeah, 9 functions left to write and this is ready! (for testing)
The only warnings/errors I am getting are for undefined functions. Everything
else seems to be in order an I even got the unit govflag_req thing working.
I have decided that
URL:
http://gna.org/patch/?3325
Summary: Allow custom types for governments to be used in
effect requirements.
Project: Freeciv
Submitted by: henkutsu_tama
Submitted on: Sat 16 Jun 2012 10:36:38 PM GMT
Category: general
14 matches
Mail list logo
